mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-06-28 09:41:47 +00:00
Compare commits
71 Commits
8077ffab34
..
main
| Author | SHA1 | Date | |
|---|---|---|---|
| 0631e34a79 | |||
| 8a013f6fa9 | |||
| 7c3440f139 | |||
| 4ceea09e31 | |||
| 03cdb4d276 | |||
| f0877a2e7d | |||
| aa91f009ad | |||
| 2277f28a57 | |||
| 1ec2d62b1c | |||
| 649735726f | |||
| 4e91fbca48 | |||
| 4cb9b18cc6 | |||
| f3b54166fb | |||
| 8c63235cd2 | |||
| 3554fde8d6 | |||
| eb0ab4001d | |||
| 497d8e854f | |||
| e6fe14cac2 | |||
| 2a8caf6e7d | |||
| 005e0c109d | |||
| e54ea2f17d | |||
| 544a76d2da | |||
| a5ba246cb8 | |||
| 0b2780ead2 | |||
| 91fcaa50f6 | |||
| 9669642c62 | |||
| 7531badbe8 | |||
| 424018fc66 | |||
| 9d8af4b357 | |||
| 5b3f77f11d | |||
| e04cf85bef | |||
| 3d65bb0c12 | |||
| 94dca8cad7 | |||
| b1145e7e0a | |||
| 382ec37142 | |||
| 92e3ebb4d5 | |||
| 49fb2fded2 | |||
| 4cd4c9c8d8 | |||
| 6cc8908f87 | |||
| 68f48bc070 | |||
| 76d8abb44d | |||
| 91c350c946 | |||
| 1e4a9a95c2 | |||
| fe54f45d62 | |||
| b36c9931b3 | |||
| c1fe1d2d6a | |||
| ebbbf91d60 | |||
| 328d1c9468 | |||
| 48ebdff2d5 | |||
| 457a42b229 | |||
| 7df5956920 | |||
| 0d50d5d7c3 | |||
| 4a3aa478c6 | |||
| abee2fc088 | |||
| e40465ba1f | |||
| 8dab26fe7b | |||
| 7459067b2e | |||
| a2c552f04d | |||
| 27762458e6 | |||
| adbe15abc4 | |||
| 982b99f0f6 | |||
| 6a797a39ae | |||
| d2cd317070 | |||
| 6ab6d79494 | |||
| d35972db39 | |||
| 438d4fc400 | |||
| d152f9d02b | |||
| f6af1d67a2 | |||
| ad893eb1cc | |||
| b25eb18ea4 | |||
| 8410d7c4a5 |
@@ -32,6 +32,7 @@ server/tests/
|
|||||||
server/vitest.config.ts
|
server/vitest.config.ts
|
||||||
server/reset-admin.js
|
server/reset-admin.js
|
||||||
**/*.test.ts
|
**/*.test.ts
|
||||||
|
**/*.spec.ts
|
||||||
wiki/
|
wiki/
|
||||||
scripts/
|
scripts/
|
||||||
charts/
|
charts/
|
||||||
|
|||||||
@@ -34,4 +34,5 @@ jobs:
|
|||||||
command: cves
|
command: cves
|
||||||
image: trek:scan
|
image: trek:scan
|
||||||
only-severities: critical,high
|
only-severities: critical,high
|
||||||
|
only-fixed: true
|
||||||
exit-code: true
|
exit-code: true
|
||||||
|
|||||||
+19
-2
@@ -1,3 +1,10 @@
|
|||||||
|
# ── Stage 0: gosu ────────────────────────────────────────────────────────────
|
||||||
|
# Rebuild gosu with a current Go toolchain so the runtime image ships no stale
|
||||||
|
# Go stdlib (Debian's apt gosu is built with an old Go that trips CVE scanners).
|
||||||
|
# The binary and its runtime behaviour are identical to the apt package.
|
||||||
|
FROM golang:1.25-alpine AS gosu-build
|
||||||
|
RUN CGO_ENABLED=0 GOBIN=/out go install github.com/tianon/gosu@latest
|
||||||
|
|
||||||
# ── Stage 1: shared ──────────────────────────────────────────────────────────
|
# ── Stage 1: shared ──────────────────────────────────────────────────────────
|
||||||
FROM node:24-alpine AS shared-builder
|
FROM node:24-alpine AS shared-builder
|
||||||
WORKDIR /app
|
WORKDIR /app
|
||||||
@@ -44,7 +51,7 @@ COPY server/package.json ./server/
|
|||||||
# amd64 — static binary from KDE CDN (glibc 2.17+; wget stays for healthcheck)
|
# amd64 — static binary from KDE CDN (glibc 2.17+; wget stays for healthcheck)
|
||||||
# arm64 — apt package (KDE publishes no arm64 static binary)
|
# arm64 — apt package (KDE publishes no arm64 static binary)
|
||||||
RUN apt-get update && \
|
RUN apt-get update && \
|
||||||
apt-get install -y --no-install-recommends tzdata dumb-init gosu wget ca-certificates python3 build-essential && \
|
apt-get install -y --no-install-recommends tzdata dumb-init wget ca-certificates python3 build-essential && \
|
||||||
npm ci --workspace=server --omit=dev && \
|
npm ci --workspace=server --omit=dev && \
|
||||||
ARCH=$(dpkg --print-architecture) && \
|
ARCH=$(dpkg --print-architecture) && \
|
||||||
if [ "$ARCH" = "amd64" ]; then \
|
if [ "$ARCH" = "amd64" ]; then \
|
||||||
@@ -60,6 +67,9 @@ RUN apt-get update && \
|
|||||||
apt-get autoremove -y && \
|
apt-get autoremove -y && \
|
||||||
rm -rf /var/lib/apt/lists/* /usr/local/lib/node_modules/npm /usr/local/bin/npm /usr/local/bin/npx
|
rm -rf /var/lib/apt/lists/* /usr/local/lib/node_modules/npm /usr/local/bin/npm /usr/local/bin/npx
|
||||||
|
|
||||||
|
# gosu rebuilt with a current Go toolchain (stage 0) — used by CMD to drop to node.
|
||||||
|
COPY --from=gosu-build /out/gosu /usr/local/bin/gosu
|
||||||
|
|
||||||
ENV XDG_CACHE_HOME=/tmp/kf6-cache
|
ENV XDG_CACHE_HOME=/tmp/kf6-cache
|
||||||
# Prevent Qt from probing for a display in headless containers.
|
# Prevent Qt from probing for a display in headless containers.
|
||||||
ENV QT_QPA_PLATFORM=offscreen
|
ENV QT_QPA_PLATFORM=offscreen
|
||||||
@@ -75,6 +85,10 @@ COPY --from=server-builder /app/server/dist ./server/dist
|
|||||||
COPY --from=server-builder /app/server/assets ./server/assets
|
COPY --from=server-builder /app/server/assets ./server/assets
|
||||||
# tsconfig-paths/register reads this at runtime to resolve MCP SDK paths.
|
# tsconfig-paths/register reads this at runtime to resolve MCP SDK paths.
|
||||||
COPY server/tsconfig.json ./server/
|
COPY server/tsconfig.json ./server/
|
||||||
|
# Encryption-key rotation is run on demand via tsx (a prod dep) straight from the
|
||||||
|
# raw .ts source — it never enters dist, so it must be copied in explicitly or
|
||||||
|
# `node --import tsx scripts/migrate-encryption.ts` fails with module-not-found.
|
||||||
|
COPY server/scripts/migrate-encryption.ts ./server/scripts/migrate-encryption.ts
|
||||||
COPY --from=shared-builder /app/shared/dist ./shared/dist
|
COPY --from=shared-builder /app/shared/dist ./shared/dist
|
||||||
COPY --from=client-builder /app/client/dist ./server/public
|
COPY --from=client-builder /app/client/dist ./server/public
|
||||||
COPY --from=client-builder /app/client/public/fonts ./server/public/fonts
|
COPY --from=client-builder /app/client/public/fonts ./server/public/fonts
|
||||||
@@ -95,5 +109,8 @@ HEALTHCHECK --interval=30s --timeout=5s --start-period=15s --retries=3 \
|
|||||||
CMD wget -qO- http://localhost:3000/api/health || exit 1
|
CMD wget -qO- http://localhost:3000/api/health || exit 1
|
||||||
|
|
||||||
ENTRYPOINT ["dumb-init", "--"]
|
ENTRYPOINT ["dumb-init", "--"]
|
||||||
|
# Preflight: if the app code is missing, a volume was almost certainly mounted
|
||||||
|
# over /app (it hides the image's node_modules + dist). Fail with actionable
|
||||||
|
# guidance instead of a cryptic "Cannot find module 'tsconfig-paths/register'".
|
||||||
# cd into server/ so tsconfig-paths/register finds tsconfig.json and ../node_modules resolves correctly.
|
# cd into server/ so tsconfig-paths/register finds tsconfig.json and ../node_modules resolves correctly.
|
||||||
CMD ["sh", "-c", "chown -R node:node /app/data /app/uploads 2>/dev/null || true; cd /app/server && exec gosu node node --require tsconfig-paths/register dist/index.js"]
|
CMD ["sh", "-c", "if [ ! -f /app/server/dist/index.js ] || [ ! -d /app/node_modules/tsconfig-paths ]; then echo 'FATAL: TREK application files are missing from the image.'; echo 'A volume is likely mounted over /app, which hides the app code.'; echo 'Mount ONLY your data and uploads dirs: -v ./data:/app/data -v ./uploads:/app/uploads'; echo 'Do NOT mount a volume at /app. See the Troubleshooting section of the README.'; exit 1; fi; chown -R node:node /app/data /app/uploads 2>/dev/null || true; cd /app/server && exec gosu node node --require tsconfig-paths/register dist/index.js"]
|
||||||
|
|||||||
@@ -51,10 +51,10 @@ A self-hosted, real-time collaborative travel planner — with maps, budgets, pa
|
|||||||
<a href="docs/screenshots/dashboard.png"><img src="docs/screenshots/dashboard.png" alt="Dashboard" width="49%" /></a>
|
<a href="docs/screenshots/dashboard.png"><img src="docs/screenshots/dashboard.png" alt="Dashboard" width="49%" /></a>
|
||||||
<a href="docs/screenshots/trip-planner.png"><img src="docs/screenshots/trip-planner.png" alt="Trip planner with 3D map" width="49%" /></a>
|
<a href="docs/screenshots/trip-planner.png"><img src="docs/screenshots/trip-planner.png" alt="Trip planner with 3D map" width="49%" /></a>
|
||||||
<a href="docs/screenshots/journey.png"><img src="docs/screenshots/journey.png" alt="Journey journal" width="49%" /></a>
|
<a href="docs/screenshots/journey.png"><img src="docs/screenshots/journey.png" alt="Journey journal" width="49%" /></a>
|
||||||
<a href="docs/screenshots/budget.png"><img src="docs/screenshots/budget.png" alt="Budget tracker" width="49%" /></a>
|
<a href="docs/screenshots/budget.png"><img src="docs/screenshots/budget.png" alt="Costs · expense splitting" width="49%" /></a>
|
||||||
<a href="docs/screenshots/atlas.png"><img src="docs/screenshots/atlas.png" alt="Atlas · visited countries" width="49%" /></a>
|
<a href="docs/screenshots/atlas.png"><img src="docs/screenshots/atlas.png" alt="Atlas · visited countries" width="49%" /></a>
|
||||||
<a href="docs/screenshots/vacay.png"><img src="docs/screenshots/vacay.png" alt="Vacay planner" width="49%" /></a>
|
<a href="docs/screenshots/vacay.png"><img src="docs/screenshots/vacay.png" alt="Vacay planner" width="49%" /></a>
|
||||||
<a href="docs/screenshots/trip-iceland.png"><img src="docs/screenshots/trip-iceland.png" alt="Iceland Ring Road" width="49%" /></a>
|
<a href="docs/screenshots/trip-iceland.png"><img src="docs/screenshots/trip-iceland.png" alt="Trip planner · day plan and route" width="49%" /></a>
|
||||||
<a href="docs/screenshots/admin.png"><img src="docs/screenshots/admin.png" alt="Admin panel" width="49%" /></a>
|
<a href="docs/screenshots/admin.png"><img src="docs/screenshots/admin.png" alt="Admin panel" width="49%" /></a>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
@@ -79,6 +79,7 @@ A self-hosted, real-time collaborative travel planner — with maps, budgets, pa
|
|||||||
- **Drag & drop planner** — organise places into day plans with reordering and cross-day moves
|
- **Drag & drop planner** — organise places into day plans with reordering and cross-day moves
|
||||||
- **Interactive map** — Leaflet or Mapbox GL with 3D buildings, terrain, photo markers, clustering, route visualization
|
- **Interactive map** — Leaflet or Mapbox GL with 3D buildings, terrain, photo markers, clustering, route visualization
|
||||||
- **Place search** — Google Places (photos, ratings, hours) or OpenStreetMap (free, no API key)
|
- **Place search** — Google Places (photos, ratings, hours) or OpenStreetMap (free, no API key)
|
||||||
|
- **Place import** — shared Google Maps / Naver Maps lists, plus GPX and KML/KMZ/GeoJSON map files
|
||||||
- **Day notes** — timestamped, icon-tagged notes with drag-and-drop reordering
|
- **Day notes** — timestamped, icon-tagged notes with drag-and-drop reordering
|
||||||
- **Route optimisation** — auto-sort places and export to Google Maps
|
- **Route optimisation** — auto-sort places and export to Google Maps
|
||||||
- **Weather forecasts** — 16-day via Open-Meteo (no key) + historical climate fallback
|
- **Weather forecasts** — 16-day via Open-Meteo (no key) + historical climate fallback
|
||||||
@@ -90,7 +91,7 @@ A self-hosted, real-time collaborative travel planner — with maps, budgets, pa
|
|||||||
#### 🧳 Travel management
|
#### 🧳 Travel management
|
||||||
|
|
||||||
- **Reservations** — flights, accommodations, restaurants with status, confirmation numbers, files; import from booking confirmation emails and PDFs ([KDE Itinerary](https://invent.kde.org/pim/kitinerary))
|
- **Reservations** — flights, accommodations, restaurants with status, confirmation numbers, files; import from booking confirmation emails and PDFs ([KDE Itinerary](https://invent.kde.org/pim/kitinerary))
|
||||||
- **Budget tracking** — category-based expenses with pie chart, per-person / per-day splits, multi-currency
|
- **Costs** — track and split trip expenses (Splitwise-style): per-person / per-day breakdowns, settle-up, multi-currency
|
||||||
- **Packing lists** — categories, templates, user assignment, progress tracking
|
- **Packing lists** — categories, templates, user assignment, progress tracking
|
||||||
- **Bag tracking** — optional weight tracking with iOS-style distribution
|
- **Bag tracking** — optional weight tracking with iOS-style distribution
|
||||||
- **Document manager** — attach docs, tickets, PDFs to trips / places / reservations (≤ 50 MB each)
|
- **Document manager** — attach docs, tickets, PDFs to trips / places / reservations (≤ 50 MB each)
|
||||||
@@ -108,6 +109,7 @@ A self-hosted, real-time collaborative travel planner — with maps, budgets, pa
|
|||||||
- **Invite links** — one-time or reusable links with expiry
|
- **Invite links** — one-time or reusable links with expiry
|
||||||
- **SSO (OIDC)** — Google, Apple, Authentik, Keycloak, or any OIDC provider
|
- **SSO (OIDC)** — Google, Apple, Authentik, Keycloak, or any OIDC provider
|
||||||
- **2FA** — TOTP + backup codes
|
- **2FA** — TOTP + backup codes
|
||||||
|
- **Passkeys** — passwordless WebAuthn login (fingerprint / face / PIN / security key), admin-toggleable
|
||||||
- **Collab suite** — group chat, shared notes, polls, day check-ins
|
- **Collab suite** — group chat, shared notes, polls, day check-ins
|
||||||
|
|
||||||
</td>
|
</td>
|
||||||
@@ -128,13 +130,13 @@ A self-hosted, real-time collaborative travel planner — with maps, budgets, pa
|
|||||||
#### 🧩 Addons (admin-toggleable)
|
#### 🧩 Addons (admin-toggleable)
|
||||||
|
|
||||||
- **Lists** — packing lists + to-dos with templates, member assignments, optional bag tracking
|
- **Lists** — packing lists + to-dos with templates, member assignments, optional bag tracking
|
||||||
- **Budget** — expense tracker with splits, pie chart, multi-currency
|
- **Costs** — expense tracker with splits and settle-up (who owes whom), multi-currency
|
||||||
- **Documents** — file attachments on trips, places, and reservations
|
- **Documents** — file attachments on trips, places, and reservations
|
||||||
- **Collab** — chat, notes, polls, day-by-day attendance
|
- **Collab** — chat, notes, polls, day-by-day attendance
|
||||||
- **Vacay** — personal vacation planner with calendar, 100+ country holidays, carry-over tracking
|
- **Vacay** — personal vacation planner with calendar, 100+ country holidays, carry-over tracking
|
||||||
- **Atlas** — world map of visited countries, bucket list, travel stats, streak tracking, liquid-glass UI
|
- **Atlas** — world map of visited countries, bucket list, travel stats, streak tracking, liquid-glass UI
|
||||||
- **Journey** — magazine-style travel journal with entries, photos (Immich/Synology), maps, moods
|
- **Journey** — magazine-style travel journal with entries, photos (Immich/Synology), maps, moods
|
||||||
- **Naver List Import** — one-click import from shared Naver Maps lists
|
- **AirTrail** — connect a self-hosted AirTrail instance to import and sync flights into reservations
|
||||||
- **MCP** — expose TREK to AI assistants via OAuth 2.1
|
- **MCP** — expose TREK to AI assistants via OAuth 2.1
|
||||||
|
|
||||||
</td>
|
</td>
|
||||||
@@ -156,8 +158,9 @@ A self-hosted, real-time collaborative travel planner — with maps, budgets, pa
|
|||||||
#### ⚙️ Admin & customisation
|
#### ⚙️ Admin & customisation
|
||||||
|
|
||||||
- **Dashboard views** — card grid or compact list · **Dark mode** — full theme with matching status bar
|
- **Dashboard views** — card grid or compact list · **Dark mode** — full theme with matching status bar
|
||||||
- **15 languages** — EN, DE, ES, FR, IT, NL, HU, RU, ZH, ZH-TW, PL, CS, AR (RTL), BR, ID
|
- **20 languages** — EN, DE, ES, FR, IT, NL, HU, RU, ZH, ZH-TW, PL, CS, AR (RTL), BR, ID, TR, JA, KO, UK, GR
|
||||||
- **Admin panel** — users, invites, packing templates, categories, addons, API keys, backups, GitHub history
|
- **Admin panel** — users, invites, packing templates, categories, addons, API keys, backups, GitHub history
|
||||||
|
- **Notifications** — per-user preferences across email (SMTP), webhook, ntfy, and an in-app notification center
|
||||||
- **Auto-backups** — scheduled with configurable retention · **Units** — °C/°F, 12h/24h, map tile sources, default coordinates
|
- **Auto-backups** — scheduled with configurable retention · **Units** — °C/°F, 12h/24h, map tile sources, default coordinates
|
||||||
|
|
||||||
</td>
|
</td>
|
||||||
@@ -191,9 +194,9 @@ Open `http://localhost:3000`. On first boot TREK seeds an admin account — if y
|
|||||||
<div align="center">
|
<div align="center">
|
||||||
|
|
||||||

|

|
||||||

|

|
||||||

|

|
||||||

|

|
||||||

|

|
||||||

|

|
||||||

|

|
||||||
@@ -202,7 +205,7 @@ Open `http://localhost:3000`. On first boot TREK seeds an admin account — if y
|
|||||||
|
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
Real-time sync via WebSocket (`ws`). State with Zustand. Auth via JWT + OAuth 2.1 + OIDC + TOTP MFA. Weather via Open-Meteo (no key required). Maps with Leaflet and Mapbox GL.
|
Real-time sync via WebSocket (`ws`). Backend on NestJS 11. State with Zustand. Auth via JWT + OAuth 2.1 + OIDC + Passkeys (WebAuthn) + TOTP MFA. Weather via Open-Meteo (no key required). Maps with Leaflet and Mapbox GL.
|
||||||
|
|
||||||
<br />
|
<br />
|
||||||
|
|
||||||
@@ -263,7 +266,7 @@ Then:
|
|||||||
docker compose up -d
|
docker compose up -d
|
||||||
```
|
```
|
||||||
|
|
||||||
**HTTPS notes:** `FORCE_HTTPS=true` is optional — it adds a 301 redirect, HSTS, CSP upgrade-insecure-requests, and forces the `secure` cookie flag. Only use it behind a TLS-terminating reverse proxy. `TRUST_PROXY=1` tells Express how many proxies sit in front so real client IPs and `X-Forwarded-Proto` work.
|
**HTTPS notes:** `FORCE_HTTPS=true` is optional — it adds a 301 redirect, HSTS, CSP upgrade-insecure-requests, and forces the `secure` cookie flag. Only use it behind a TLS-terminating reverse proxy. `TRUST_PROXY=1` tells the server how many proxies sit in front so real client IPs and `X-Forwarded-Proto` work.
|
||||||
|
|
||||||
</details>
|
</details>
|
||||||
|
|
||||||
@@ -311,6 +314,9 @@ docker run -d --name trek -p 3000:3000 -v ./data:/app/data -v ./uploads:/app/upl
|
|||||||
|
|
||||||
Your data stays in the mounted `data` and `uploads` volumes — updates never touch it.
|
Your data stays in the mounted `data` and `uploads` volumes — updates never touch it.
|
||||||
|
|
||||||
|
> [!IMPORTANT]
|
||||||
|
> Mount **only** the data and uploads directories — `-v ./data:/app/data -v ./uploads:/app/uploads`. **Never mount a volume at `/app`.** Doing so hides the application code shipped in the image and the container fails to start with `Cannot find module 'tsconfig-paths/register'`. If you previously mounted `/app`, switch to the two mounts above; your data in `data/` and `uploads/` is preserved.
|
||||||
|
|
||||||
<h3>Rotating the Encryption Key</h3>
|
<h3>Rotating the Encryption Key</h3>
|
||||||
|
|
||||||
If you need to rotate `ENCRYPTION_KEY` (e.g. upgrading from a version that derived encryption from `JWT_SECRET`):
|
If you need to rotate `ENCRYPTION_KEY` (e.g. upgrading from a version that derived encryption from `JWT_SECRET`):
|
||||||
@@ -397,12 +403,14 @@ Caddy handles TLS and WebSockets automatically.
|
|||||||
| `ENCRYPTION_KEY` | At-rest encryption key for stored secrets (API keys, MFA, SMTP, OIDC). Recommended: generate with `openssl rand -hex 32`. If unset, falls back to `data/.jwt_secret` (existing installs) or auto-generates a key (fresh installs). | Auto |
|
| `ENCRYPTION_KEY` | At-rest encryption key for stored secrets (API keys, MFA, SMTP, OIDC). Recommended: generate with `openssl rand -hex 32`. If unset, falls back to `data/.jwt_secret` (existing installs) or auto-generates a key (fresh installs). | Auto |
|
||||||
| `TZ` | Timezone for logs, reminders and cron jobs (e.g. `Europe/Berlin`) | `UTC` |
|
| `TZ` | Timezone for logs, reminders and cron jobs (e.g. `Europe/Berlin`) | `UTC` |
|
||||||
| `LOG_LEVEL` | `info` = concise user actions, `debug` = verbose details | `info` |
|
| `LOG_LEVEL` | `info` = concise user actions, `debug` = verbose details | `info` |
|
||||||
| `DEFAULT_LANGUAGE` | Default language on the login page for users with no saved preference. Browser/OS language is auto-detected first; this is the fallback. Supported: `de`, `en`, `es`, `fr`, `hu`, `nl`, `br`, `cs`, `pl`, `ru`, `zh`, `zh-TW`, `it`, `ar` | `en` |
|
| `DEFAULT_LANGUAGE` | Default language on the login page for users with no saved preference. Browser/OS language is auto-detected first; this is the fallback. Supported: `de`, `en`, `es`, `fr`, `hu`, `nl`, `br`, `cs`, `pl`, `ru`, `zh`, `zh-TW`, `it`, `ar`, `id`, `tr`, `ja`, `ko`, `uk`, `gr` | `en` |
|
||||||
| `ALLOWED_ORIGINS` | Comma-separated origins for CORS and email links | same-origin |
|
| `ALLOWED_ORIGINS` | Comma-separated origins for CORS and email links | same-origin |
|
||||||
| `FORCE_HTTPS` | Optional. When `true`: 301-redirects HTTP to HTTPS, sends HSTS, adds CSP `upgrade-insecure-requests`, forces the session cookie `secure` flag. Useful behind a TLS-terminating reverse proxy. Requires `TRUST_PROXY`. | `false` |
|
| `FORCE_HTTPS` | Optional. When `true`: 301-redirects HTTP to HTTPS, sends HSTS, adds CSP `upgrade-insecure-requests`, forces the session cookie `secure` flag. Useful behind a TLS-terminating reverse proxy. Requires `TRUST_PROXY`. | `false` |
|
||||||
| `HSTS_INCLUDE_SUBDOMAINS` | When `true`: adds the `includeSubDomains` directive to the HSTS header, extending HTTPS enforcement to all subdomains. Only effective when HSTS is active (`FORCE_HTTPS=true` or `NODE_ENV=production`). Leave `false` if you run other services on sibling subdomains over plain HTTP. | `false` |
|
| `HSTS_INCLUDE_SUBDOMAINS` | When `true`: adds the `includeSubDomains` directive to the HSTS header, extending HTTPS enforcement to all subdomains. Only effective when HSTS is active (`FORCE_HTTPS=true` or `NODE_ENV=production`). Leave `false` if you run other services on sibling subdomains over plain HTTP. | `false` |
|
||||||
| `COOKIE_SECURE` | Controls the `secure` flag on the `trek_session` cookie. Auto-derived: on when `NODE_ENV=production` or `FORCE_HTTPS=true`. Escape hatch: set `false` to allow session cookies over plain HTTP. Not recommended in production. | auto |
|
| `COOKIE_SECURE` | Controls the `secure` flag on the `trek_session` cookie. Auto-derived: on when `NODE_ENV=production` or `FORCE_HTTPS=true`. Escape hatch: set `false` to allow session cookies over plain HTTP. Not recommended in production. | auto |
|
||||||
| `TRUST_PROXY` | Number of trusted reverse proxies. Tells Express to read client IP from `X-Forwarded-For` and protocol from `X-Forwarded-Proto`. Defaults to `1` in production; off in dev unless set. | `1` |
|
| `SESSION_DURATION` | How long a login session stays valid when **"Remember me" is unchecked** (the default): sets the `trek_session` JWT `exp` and issues a browser-session cookie (cleared when the browser closes). Accepts `ms`-style strings: `1h`, `12h`, `7d`, `30d`, `90d`. Invalid values warn at startup and fall back to the default. | `24h` |
|
||||||
|
| `SESSION_DURATION_REMEMBER` | Session length when **"Remember me" is ticked** at login: a longer-lived JWT plus a persistent `trek_session` cookie that survives browser restarts. Same format and startup-fallback behaviour as `SESSION_DURATION`. | `30d` |
|
||||||
|
| `TRUST_PROXY` | Number of trusted reverse proxies. Tells the server to read client IP from `X-Forwarded-For` and protocol from `X-Forwarded-Proto`. Defaults to `1` in production; off in dev unless set. | `1` |
|
||||||
| `ALLOW_INTERNAL_NETWORK` | Allow outbound requests to private/RFC-1918 IPs (e.g. Immich on your LAN). Loopback and link-local addresses remain blocked. | `false` |
|
| `ALLOW_INTERNAL_NETWORK` | Allow outbound requests to private/RFC-1918 IPs (e.g. Immich on your LAN). Loopback and link-local addresses remain blocked. | `false` |
|
||||||
| `APP_URL` | Public base URL of this instance (e.g. `https://trek.example.com`). Required when OIDC is enabled; used as base for email notification links. | — |
|
| `APP_URL` | Public base URL of this instance (e.g. `https://trek.example.com`). Required when OIDC is enabled; used as base for email notification links. | — |
|
||||||
| **OIDC / SSO** | | |
|
| **OIDC / SSO** | | |
|
||||||
|
|||||||
@@ -0,0 +1,9 @@
|
|||||||
|
<?xml version="1.0"?>
|
||||||
|
<CommunityApplications>
|
||||||
|
<Profile>TREK is a self-hosted, real-time collaborative travel planner. Plan trips together with interactive maps, budgets, bookings, packing lists, day-by-day itineraries and file management — every change syncs instantly across everyone in your group. Includes OIDC/SSO, TOTP MFA, dark mode, PWA support, multi-language UI and a modular addon system (Vacay, Atlas, Collab, Budget, Packing, Journey). Maintained by mauriceboe — support and bug reports via GitHub Issues.</Profile>
|
||||||
|
<Icon>https://raw.githubusercontent.com/mauriceboe/TREK/main/docs/trek-icon.png</Icon>
|
||||||
|
<WebPage>https://github.com/mauriceboe/TREK</WebPage>
|
||||||
|
<Forum>https://github.com/mauriceboe/TREK/issues</Forum>
|
||||||
|
<DonateLink>https://ko-fi.com/mauriceboe</DonateLink>
|
||||||
|
<DonateText>Support TREK development</DonateText>
|
||||||
|
</CommunityApplications>
|
||||||
+1
-1
@@ -39,7 +39,7 @@ See `values.yaml` for more options.
|
|||||||
|
|
||||||
## Notes
|
## Notes
|
||||||
- Ingress is off by default. Enable and configure hosts for your domain.
|
- Ingress is off by default. Enable and configure hosts for your domain.
|
||||||
- PVCs require a default StorageClass or specify one as needed.
|
- PVCs use the cluster's default StorageClass. Set `persistence.data.storageClassName` and/or `persistence.uploads.storageClassName` to bind a specific class.
|
||||||
- `JWT_SECRET` is managed entirely by the server — auto-generated into the data PVC on first start and rotatable via the admin panel (Settings → Danger Zone). No Helm configuration needed.
|
- `JWT_SECRET` is managed entirely by the server — auto-generated into the data PVC on first start and rotatable via the admin panel (Settings → Danger Zone). No Helm configuration needed.
|
||||||
- `ENCRYPTION_KEY` encrypts stored secrets (API keys, MFA, SMTP, OIDC) at rest. Recommended: set via `secretEnv.ENCRYPTION_KEY` or `existingSecret`. If left empty, the server falls back automatically: existing installs use `data/.jwt_secret` (no action needed on upgrade); fresh installs auto-generate a key persisted to the data PVC.
|
- `ENCRYPTION_KEY` encrypts stored secrets (API keys, MFA, SMTP, OIDC) at rest. Recommended: set via `secretEnv.ENCRYPTION_KEY` or `existingSecret`. If left empty, the server falls back automatically: existing installs use `data/.jwt_secret` (no action needed on upgrade); fresh installs auto-generate a key persisted to the data PVC.
|
||||||
- If using ingress, you must manually keep `env.ALLOWED_ORIGINS` and `ingress.hosts` in sync to ensure CORS works correctly. The chart does not sync these automatically.
|
- If using ingress, you must manually keep `env.ALLOWED_ORIGINS` and `ingress.hosts` in sync to ensure CORS works correctly. The chart does not sync these automatically.
|
||||||
|
|||||||
@@ -1,5 +1,5 @@
|
|||||||
apiVersion: v2
|
apiVersion: v2
|
||||||
name: trek
|
name: trek
|
||||||
version: 3.0.22
|
version: 3.1.3
|
||||||
description: Minimal Helm chart for TREK app
|
description: Minimal Helm chart for TREK app
|
||||||
appVersion: "3.0.22"
|
appVersion: "3.1.3"
|
||||||
|
|||||||
@@ -28,6 +28,12 @@ data:
|
|||||||
{{- if .Values.env.COOKIE_SECURE }}
|
{{- if .Values.env.COOKIE_SECURE }}
|
||||||
COOKIE_SECURE: {{ .Values.env.COOKIE_SECURE | quote }}
|
COOKIE_SECURE: {{ .Values.env.COOKIE_SECURE | quote }}
|
||||||
{{- end }}
|
{{- end }}
|
||||||
|
{{- if .Values.env.SESSION_DURATION }}
|
||||||
|
SESSION_DURATION: {{ .Values.env.SESSION_DURATION | quote }}
|
||||||
|
{{- end }}
|
||||||
|
{{- if .Values.env.SESSION_DURATION_REMEMBER }}
|
||||||
|
SESSION_DURATION_REMEMBER: {{ .Values.env.SESSION_DURATION_REMEMBER | quote }}
|
||||||
|
{{- end }}
|
||||||
{{- if .Values.env.TRUST_PROXY }}
|
{{- if .Values.env.TRUST_PROXY }}
|
||||||
TRUST_PROXY: {{ .Values.env.TRUST_PROXY | quote }}
|
TRUST_PROXY: {{ .Values.env.TRUST_PROXY | quote }}
|
||||||
{{- end }}
|
{{- end }}
|
||||||
@@ -64,3 +70,9 @@ data:
|
|||||||
{{- if .Values.env.MCP_RATE_LIMIT }}
|
{{- if .Values.env.MCP_RATE_LIMIT }}
|
||||||
MCP_RATE_LIMIT: {{ .Values.env.MCP_RATE_LIMIT | quote }}
|
MCP_RATE_LIMIT: {{ .Values.env.MCP_RATE_LIMIT | quote }}
|
||||||
{{- end }}
|
{{- end }}
|
||||||
|
{{- if .Values.env.OVERPASS_URL }}
|
||||||
|
OVERPASS_URL: {{ .Values.env.OVERPASS_URL | quote }}
|
||||||
|
{{- end }}
|
||||||
|
{{- if .Values.env.OVERPASS_TIMEOUT_MS }}
|
||||||
|
OVERPASS_TIMEOUT_MS: {{ .Values.env.OVERPASS_TIMEOUT_MS | quote }}
|
||||||
|
{{- end }}
|
||||||
|
|||||||
@@ -5,9 +5,16 @@ metadata:
|
|||||||
name: {{ include "trek.fullname" . }}-data
|
name: {{ include "trek.fullname" . }}-data
|
||||||
labels:
|
labels:
|
||||||
app: {{ include "trek.name" . }}
|
app: {{ include "trek.name" . }}
|
||||||
|
{{- with .Values.persistence.data.annotations }}
|
||||||
|
annotations:
|
||||||
|
{{- toYaml . | nindent 4 }}
|
||||||
|
{{- end }}
|
||||||
spec:
|
spec:
|
||||||
accessModes:
|
accessModes:
|
||||||
- ReadWriteOnce
|
- ReadWriteOnce
|
||||||
|
{{- with .Values.persistence.data.storageClassName }}
|
||||||
|
storageClassName: {{ . | quote }}
|
||||||
|
{{- end }}
|
||||||
resources:
|
resources:
|
||||||
requests:
|
requests:
|
||||||
storage: {{ .Values.persistence.data.size }}
|
storage: {{ .Values.persistence.data.size }}
|
||||||
@@ -18,9 +25,16 @@ metadata:
|
|||||||
name: {{ include "trek.fullname" . }}-uploads
|
name: {{ include "trek.fullname" . }}-uploads
|
||||||
labels:
|
labels:
|
||||||
app: {{ include "trek.name" . }}
|
app: {{ include "trek.name" . }}
|
||||||
|
{{- with .Values.persistence.uploads.annotations }}
|
||||||
|
annotations:
|
||||||
|
{{- toYaml . | nindent 4 }}
|
||||||
|
{{- end }}
|
||||||
spec:
|
spec:
|
||||||
accessModes:
|
accessModes:
|
||||||
- ReadWriteOnce
|
- ReadWriteOnce
|
||||||
|
{{- with .Values.persistence.uploads.storageClassName }}
|
||||||
|
storageClassName: {{ . | quote }}
|
||||||
|
{{- end }}
|
||||||
resources:
|
resources:
|
||||||
requests:
|
requests:
|
||||||
storage: {{ .Values.persistence.uploads.size }}
|
storage: {{ .Values.persistence.uploads.size }}
|
||||||
|
|||||||
@@ -34,6 +34,10 @@ env:
|
|||||||
# When "true": adds includeSubDomains to the HSTS header. Only effective when HSTS is active. Leave "false" if sibling subdomains still run over plain HTTP.
|
# When "true": adds includeSubDomains to the HSTS header. Only effective when HSTS is active. Leave "false" if sibling subdomains still run over plain HTTP.
|
||||||
# COOKIE_SECURE: "true"
|
# COOKIE_SECURE: "true"
|
||||||
# Auto-derived (true in production or when FORCE_HTTPS=true). Set "false" to force cookies over plain HTTP. Not recommended for production.
|
# Auto-derived (true in production or when FORCE_HTTPS=true). Set "false" to force cookies over plain HTTP. Not recommended for production.
|
||||||
|
# SESSION_DURATION: "24h"
|
||||||
|
# How long a login session stays valid when "Remember me" is unchecked (the default): trek_session JWT exp + a browser-session cookie. Accepts 1h, 12h, 7d, 30d, 90d. Defaults to 24h.
|
||||||
|
# SESSION_DURATION_REMEMBER: "30d"
|
||||||
|
# Session length when "Remember me" is ticked: a longer-lived JWT + persistent cookie that survives browser restarts. Same format as SESSION_DURATION. Defaults to 30d.
|
||||||
# TRUST_PROXY: "1"
|
# TRUST_PROXY: "1"
|
||||||
# Trusted proxy hops for X-Forwarded-For/X-Forwarded-Proto. Defaults to 1 in production. Must be set for FORCE_HTTPS to work.
|
# Trusted proxy hops for X-Forwarded-For/X-Forwarded-Proto. Defaults to 1 in production. Must be set for FORCE_HTTPS to work.
|
||||||
# ALLOW_INTERNAL_NETWORK: "false"
|
# ALLOW_INTERNAL_NETWORK: "false"
|
||||||
@@ -63,6 +67,12 @@ env:
|
|||||||
# Max MCP API requests per user per minute. Defaults to 300.
|
# Max MCP API requests per user per minute. Defaults to 300.
|
||||||
# MCP_MAX_SESSION_PER_USER: "20"
|
# MCP_MAX_SESSION_PER_USER: "20"
|
||||||
# Max concurrent MCP sessions per user. Defaults to 20.
|
# Max concurrent MCP sessions per user. Defaults to 20.
|
||||||
|
# OVERPASS_URL: ""
|
||||||
|
# Custom Overpass endpoint(s) for the map POI "explore" search, comma-separated. When set, REPLACES the bundled
|
||||||
|
# public mirrors — point it at an internal/self-hosted Overpass instance when the public mirrors are unreachable
|
||||||
|
# from the cluster (e.g. locked-down egress). Non-http(s) entries are ignored.
|
||||||
|
# OVERPASS_TIMEOUT_MS: "12000"
|
||||||
|
# Per-endpoint timeout (ms) for Overpass POI requests. Raise it for a slow self-hosted Overpass instance. Defaults to 12000.
|
||||||
|
|
||||||
|
|
||||||
# Secret environment variables stored in a Kubernetes Secret.
|
# Secret environment variables stored in a Kubernetes Secret.
|
||||||
@@ -94,8 +104,13 @@ persistence:
|
|||||||
enabled: true
|
enabled: true
|
||||||
data:
|
data:
|
||||||
size: 1Gi
|
size: 1Gi
|
||||||
|
# Leave empty to use the cluster's default StorageClass; set to bind a specific class.
|
||||||
|
storageClassName: ""
|
||||||
|
annotations: {}
|
||||||
uploads:
|
uploads:
|
||||||
size: 1Gi
|
size: 1Gi
|
||||||
|
storageClassName: ""
|
||||||
|
annotations: {}
|
||||||
|
|
||||||
resources:
|
resources:
|
||||||
requests:
|
requests:
|
||||||
|
|||||||
+1
-1
@@ -13,7 +13,7 @@
|
|||||||
<link rel="apple-touch-icon" href="/icons/apple-touch-icon-180x180.png" />
|
<link rel="apple-touch-icon" href="/icons/apple-touch-icon-180x180.png" />
|
||||||
|
|
||||||
<!-- Favicon -->
|
<!-- Favicon -->
|
||||||
<link rel="icon" type="image/svg+xml" href="/icons/icon-dark.svg" />
|
<link rel="icon" type="image/svg+xml" href="/icons/icon.svg" />
|
||||||
|
|
||||||
<!-- Fonts -->
|
<!-- Fonts -->
|
||||||
<link rel="preconnect" href="https://fonts.googleapis.com" />
|
<link rel="preconnect" href="https://fonts.googleapis.com" />
|
||||||
|
|||||||
+8
-6
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "@trek/client",
|
"name": "@trek/client",
|
||||||
"version": "3.0.22",
|
"version": "3.1.3",
|
||||||
"private": true,
|
"private": true,
|
||||||
"type": "module",
|
"type": "module",
|
||||||
"scripts": {
|
"scripts": {
|
||||||
@@ -34,6 +34,7 @@
|
|||||||
"leaflet": "^1.9.4",
|
"leaflet": "^1.9.4",
|
||||||
"lucide-react": "^0.344.0",
|
"lucide-react": "^0.344.0",
|
||||||
"mapbox-gl": "^3.22.0",
|
"mapbox-gl": "^3.22.0",
|
||||||
|
"maplibre-gl": "^5.24.0",
|
||||||
"marked": "^18.0.0",
|
"marked": "^18.0.0",
|
||||||
"react": "^19.2.6",
|
"react": "^19.2.6",
|
||||||
"react-dom": "^19.2.6",
|
"react-dom": "^19.2.6",
|
||||||
@@ -58,11 +59,12 @@
|
|||||||
"@testing-library/user-event": "^14.6.1",
|
"@testing-library/user-event": "^14.6.1",
|
||||||
"@trivago/prettier-plugin-sort-imports": "^6.0.2",
|
"@trivago/prettier-plugin-sort-imports": "^6.0.2",
|
||||||
"@types/leaflet": "^1.9.8",
|
"@types/leaflet": "^1.9.8",
|
||||||
|
"@types/node": "^25.9.3",
|
||||||
"@types/react": "^19.2.15",
|
"@types/react": "^19.2.15",
|
||||||
"@types/react-dom": "^19.2.3",
|
"@types/react-dom": "^19.2.3",
|
||||||
"@types/react-window": "^1.8.8",
|
"@types/react-window": "^1.8.8",
|
||||||
"@vitejs/plugin-react": "^4.2.1",
|
"@vitejs/plugin-react": "^6.0.2",
|
||||||
"@vitest/coverage-v8": "^3.2.4",
|
"@vitest/coverage-v8": "^4.1.9",
|
||||||
"autoprefixer": "^10.4.18",
|
"autoprefixer": "^10.4.18",
|
||||||
"eslint": "^10.2.1",
|
"eslint": "^10.2.1",
|
||||||
"eslint-config-flat-gitignore": "^2.3.0",
|
"eslint-config-flat-gitignore": "^2.3.0",
|
||||||
@@ -80,8 +82,8 @@
|
|||||||
"tailwindcss": "^3.4.1",
|
"tailwindcss": "^3.4.1",
|
||||||
"typescript": "^6.0.2",
|
"typescript": "^6.0.2",
|
||||||
"typescript-eslint": "^8.58.2",
|
"typescript-eslint": "^8.58.2",
|
||||||
"vite": "^5.1.4",
|
"vite": "8.1.0",
|
||||||
"vite-plugin-pwa": "^0.21.0",
|
"vite-plugin-pwa": "^1.3.0",
|
||||||
"vitest": "^3.2.4"
|
"vitest": "^4.1.9"
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -100,6 +100,7 @@ const RATE_LIMIT_MESSAGES: Record<string, string> = {
|
|||||||
ja: '試行回数が多すぎます。時間をおいて再度お試しください。',
|
ja: '試行回数が多すぎます。時間をおいて再度お試しください。',
|
||||||
ko: '시도 횟수가 너무 많습니다. 잠시 후 다시 시도해 주세요.',
|
ko: '시도 횟수가 너무 많습니다. 잠시 후 다시 시도해 주세요.',
|
||||||
uk: 'Занадто багато спроб. Спробуйте пізніше.',
|
uk: 'Занадто багато спроб. Спробуйте пізніше.',
|
||||||
|
sv: 'För många försök. Prova igen senare.',
|
||||||
}
|
}
|
||||||
|
|
||||||
function translateRateLimit(): string {
|
function translateRateLimit(): string {
|
||||||
@@ -489,7 +490,7 @@ export const addonsApi = {
|
|||||||
|
|
||||||
export const airtrailApi = {
|
export const airtrailApi = {
|
||||||
getSettings: () => apiClient.get('/integrations/airtrail/settings').then(r => r.data),
|
getSettings: () => apiClient.get('/integrations/airtrail/settings').then(r => r.data),
|
||||||
saveSettings: (data: { url: string; apiKey?: string; allowInsecureTls?: boolean }) =>
|
saveSettings: (data: { url: string; apiKey?: string; allowInsecureTls?: boolean; writeEnabled?: boolean }) =>
|
||||||
apiClient.put('/integrations/airtrail/settings', data).then(r => r.data),
|
apiClient.put('/integrations/airtrail/settings', data).then(r => r.data),
|
||||||
status: () => apiClient.get('/integrations/airtrail/status').then(r => r.data),
|
status: () => apiClient.get('/integrations/airtrail/status').then(r => r.data),
|
||||||
test: (data: { url?: string; apiKey?: string; allowInsecureTls?: boolean }) =>
|
test: (data: { url?: string; apiKey?: string; allowInsecureTls?: boolean }) =>
|
||||||
@@ -595,6 +596,7 @@ export const budgetApi = {
|
|||||||
perPersonSummary: (tripId: number | string) => apiClient.get(`/trips/${tripId}/budget/summary/per-person`).then(r => r.data),
|
perPersonSummary: (tripId: number | string) => apiClient.get(`/trips/${tripId}/budget/summary/per-person`).then(r => r.data),
|
||||||
settlement: (tripId: number | string, base?: string) => apiClient.get(`/trips/${tripId}/budget/settlement`, base ? { params: { base } } : undefined).then(r => r.data),
|
settlement: (tripId: number | string, base?: string) => apiClient.get(`/trips/${tripId}/budget/settlement`, base ? { params: { base } } : undefined).then(r => r.data),
|
||||||
createSettlement: (tripId: number | string, data: { from_user_id: number; to_user_id: number; amount: number }) => apiClient.post(`/trips/${tripId}/budget/settlements`, data).then(r => r.data),
|
createSettlement: (tripId: number | string, data: { from_user_id: number; to_user_id: number; amount: number }) => apiClient.post(`/trips/${tripId}/budget/settlements`, data).then(r => r.data),
|
||||||
|
updateSettlement: (tripId: number | string, settlementId: number, data: { from_user_id: number; to_user_id: number; amount: number }) => apiClient.put(`/trips/${tripId}/budget/settlements/${settlementId}`, data).then(r => r.data),
|
||||||
deleteSettlement: (tripId: number | string, settlementId: number) => apiClient.delete(`/trips/${tripId}/budget/settlements/${settlementId}`).then(r => r.data),
|
deleteSettlement: (tripId: number | string, settlementId: number) => apiClient.delete(`/trips/${tripId}/budget/settlements/${settlementId}`).then(r => r.data),
|
||||||
reorderItems: (tripId: number | string, orderedIds: number[]) => apiClient.put(`/trips/${tripId}/budget/reorder/items`, { orderedIds }).then(r => r.data),
|
reorderItems: (tripId: number | string, orderedIds: number[]) => apiClient.put(`/trips/${tripId}/budget/reorder/items`, { orderedIds }).then(r => r.data),
|
||||||
reorderCategories: (tripId: number | string, orderedCategories: string[]) => apiClient.put(`/trips/${tripId}/budget/reorder/categories`, { orderedCategories } satisfies BudgetReorderCategoriesRequest).then(r => r.data),
|
reorderCategories: (tripId: number | string, orderedCategories: string[]) => apiClient.put(`/trips/${tripId}/budget/reorder/categories`, { orderedCategories } satisfies BudgetReorderCategoriesRequest).then(r => r.data),
|
||||||
|
|||||||
@@ -20,6 +20,12 @@ export function getSocketId(): string | null {
|
|||||||
return mySocketId
|
return mySocketId
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/** Trip ids the app currently has open (joined). Used to re-hydrate the active
|
||||||
|
* trip's store after the network comes back via the `online` event. */
|
||||||
|
export function getActiveTrips(): string[] {
|
||||||
|
return Array.from(activeTrips)
|
||||||
|
}
|
||||||
|
|
||||||
export function setRefetchCallback(fn: RefetchCallback | null): void {
|
export function setRefetchCallback(fn: RefetchCallback | null): void {
|
||||||
refetchCallback = fn
|
refetchCallback = fn
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -6,7 +6,17 @@ import { useToast } from '../shared/Toast'
|
|||||||
import Section from '../Settings/Section'
|
import Section from '../Settings/Section'
|
||||||
import CustomSelect from '../shared/CustomSelect'
|
import CustomSelect from '../shared/CustomSelect'
|
||||||
import { MapView } from '../Map/MapView'
|
import { MapView } from '../Map/MapView'
|
||||||
import type { Place } from '../../types'
|
import { CURRENCIES, SYMBOLS } from '../Budget/BudgetPanel.constants'
|
||||||
|
import type { DistanceUnit, Place } from '../../types'
|
||||||
|
import {
|
||||||
|
MAPBOX_DEFAULT_STYLE,
|
||||||
|
defaultStyleForProvider,
|
||||||
|
getStylePresets,
|
||||||
|
isOpenFreeMapStyle,
|
||||||
|
normalizeStyleForProvider,
|
||||||
|
styleSettingKey,
|
||||||
|
type GlMapProvider,
|
||||||
|
} from '../Map/glProviders'
|
||||||
|
|
||||||
const MAP_PRESETS = [
|
const MAP_PRESETS = [
|
||||||
{ name: 'OpenStreetMap', url: 'https://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png' },
|
{ name: 'OpenStreetMap', url: 'https://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png' },
|
||||||
@@ -18,25 +28,31 @@ const MAP_PRESETS = [
|
|||||||
|
|
||||||
type Defaults = {
|
type Defaults = {
|
||||||
temperature_unit?: string
|
temperature_unit?: string
|
||||||
|
distance_unit?: DistanceUnit
|
||||||
dark_mode?: string | boolean
|
dark_mode?: string | boolean
|
||||||
time_format?: string
|
time_format?: string
|
||||||
|
default_currency?: string
|
||||||
blur_booking_codes?: boolean
|
blur_booking_codes?: boolean
|
||||||
map_tile_url?: string
|
map_tile_url?: string
|
||||||
map_provider?: string
|
map_provider?: string
|
||||||
mapbox_access_token?: string
|
mapbox_access_token?: string
|
||||||
mapbox_style?: string
|
mapbox_style?: string
|
||||||
|
maplibre_style?: string
|
||||||
mapbox_3d_enabled?: boolean
|
mapbox_3d_enabled?: boolean
|
||||||
mapbox_quality_mode?: boolean
|
mapbox_quality_mode?: boolean
|
||||||
}
|
}
|
||||||
|
|
||||||
const MAPBOX_STYLE_PRESETS = [
|
type MapProvider = 'leaflet' | GlMapProvider
|
||||||
{ name: 'Standard', url: 'mapbox://styles/mapbox/standard' },
|
|
||||||
{ name: 'Streets', url: 'mapbox://styles/mapbox/streets-v12' },
|
function normalizeProvider(value: unknown): MapProvider {
|
||||||
{ name: 'Outdoors', url: 'mapbox://styles/mapbox/outdoors-v12' },
|
return value === 'mapbox-gl' || value === 'maplibre-gl' ? value : 'leaflet'
|
||||||
{ name: 'Light', url: 'mapbox://styles/mapbox/light-v11' },
|
}
|
||||||
{ name: 'Dark', url: 'mapbox://styles/mapbox/dark-v11' },
|
|
||||||
{ name: 'Satellite Streets', url: 'mapbox://styles/mapbox/satellite-streets-v12' },
|
function styleForProvider(provider: MapProvider, style?: string | null): string {
|
||||||
]
|
if (provider === 'leaflet') return style || MAPBOX_DEFAULT_STYLE
|
||||||
|
if (provider === 'mapbox-gl' && isOpenFreeMapStyle(style)) return MAPBOX_DEFAULT_STYLE
|
||||||
|
return normalizeStyleForProvider(provider, style)
|
||||||
|
}
|
||||||
|
|
||||||
function OptionRow({
|
function OptionRow({
|
||||||
label,
|
label,
|
||||||
@@ -96,10 +112,11 @@ export default function DefaultUserSettingsTab(): React.ReactElement {
|
|||||||
|
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
adminApi.getDefaultUserSettings().then((data: Defaults) => {
|
adminApi.getDefaultUserSettings().then((data: Defaults) => {
|
||||||
|
const provider = normalizeProvider(data.map_provider)
|
||||||
setDefaults(data)
|
setDefaults(data)
|
||||||
setMapTileUrl(data.map_tile_url || '')
|
setMapTileUrl(data.map_tile_url || '')
|
||||||
setMapboxToken(data.mapbox_access_token || '')
|
setMapboxToken(data.mapbox_access_token || '')
|
||||||
setMapboxStyle(data.mapbox_style || '')
|
setMapboxStyle(provider === 'leaflet' ? (data.mapbox_style || '') : styleForProvider(provider, provider === 'maplibre-gl' ? data.maplibre_style : data.mapbox_style))
|
||||||
setLoaded(true)
|
setLoaded(true)
|
||||||
}).catch(() => setLoaded(true))
|
}).catch(() => setLoaded(true))
|
||||||
}, [])
|
}, [])
|
||||||
@@ -120,7 +137,10 @@ export default function DefaultUserSettingsTab(): React.ReactElement {
|
|||||||
setDefaults(updated)
|
setDefaults(updated)
|
||||||
if (key === 'map_tile_url') setMapTileUrl('')
|
if (key === 'map_tile_url') setMapTileUrl('')
|
||||||
if (key === 'mapbox_access_token') setMapboxToken('')
|
if (key === 'mapbox_access_token') setMapboxToken('')
|
||||||
if (key === 'mapbox_style') setMapboxStyle('')
|
if (key === 'mapbox_style' || key === 'maplibre_style') {
|
||||||
|
const provider = normalizeProvider(defaults.map_provider)
|
||||||
|
setMapboxStyle(provider === 'leaflet' ? '' : defaultStyleForProvider(provider))
|
||||||
|
}
|
||||||
toast.success(t('admin.defaultSettings.reset'))
|
toast.success(t('admin.defaultSettings.reset'))
|
||||||
} catch (err: unknown) {
|
} catch (err: unknown) {
|
||||||
toast.error(err instanceof Error ? err.message : t('common.error'))
|
toast.error(err instanceof Error ? err.message : t('common.error'))
|
||||||
@@ -170,6 +190,20 @@ export default function DefaultUserSettingsTab(): React.ReactElement {
|
|||||||
}
|
}
|
||||||
|
|
||||||
const darkMode = defaults.dark_mode
|
const darkMode = defaults.dark_mode
|
||||||
|
const mapProvider = normalizeProvider(defaults.map_provider)
|
||||||
|
const glStylePresets = mapProvider === 'leaflet' ? [] : getStylePresets(mapProvider)
|
||||||
|
const styleKey: keyof Defaults = mapProvider === 'maplibre-gl' ? 'maplibre_style' : 'mapbox_style'
|
||||||
|
const saveMapProvider = (nextProvider: MapProvider) => {
|
||||||
|
const patch: Partial<Defaults> = { map_provider: nextProvider }
|
||||||
|
if (nextProvider !== 'leaflet') {
|
||||||
|
// Load + save the new provider's own style slot so the other provider's style is kept.
|
||||||
|
const slot = nextProvider === 'maplibre-gl' ? defaults.maplibre_style : defaults.mapbox_style
|
||||||
|
const nextStyle = styleForProvider(nextProvider, slot)
|
||||||
|
setMapboxStyle(nextStyle)
|
||||||
|
patch[styleSettingKey(nextProvider)] = nextStyle
|
||||||
|
}
|
||||||
|
save(patch)
|
||||||
|
}
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<Section title={t('admin.defaultSettings.title')} icon={Settings2}>
|
<Section title={t('admin.defaultSettings.title')} icon={Settings2}>
|
||||||
@@ -210,6 +244,22 @@ export default function DefaultUserSettingsTab(): React.ReactElement {
|
|||||||
))}
|
))}
|
||||||
</OptionRow>
|
</OptionRow>
|
||||||
|
|
||||||
|
{/* Distance */}
|
||||||
|
<OptionRow label={<>{t('settings.distance')} <ResetButton field="distance_unit" /></>}>
|
||||||
|
{([
|
||||||
|
{ value: 'metric', label: 'km Metric' },
|
||||||
|
{ value: 'imperial', label: 'mi Imperial' },
|
||||||
|
] as const).map(opt => (
|
||||||
|
<OptionButton
|
||||||
|
key={opt.value}
|
||||||
|
active={defaults.distance_unit === opt.value}
|
||||||
|
onClick={() => save({ distance_unit: opt.value })}
|
||||||
|
>
|
||||||
|
{opt.label}
|
||||||
|
</OptionButton>
|
||||||
|
))}
|
||||||
|
</OptionRow>
|
||||||
|
|
||||||
{/* Time Format */}
|
{/* Time Format */}
|
||||||
<OptionRow label={<>{t('settings.timeFormat')} <ResetButton field="time_format" /></>}>
|
<OptionRow label={<>{t('settings.timeFormat')} <ResetButton field="time_format" /></>}>
|
||||||
{([
|
{([
|
||||||
@@ -226,6 +276,23 @@ export default function DefaultUserSettingsTab(): React.ReactElement {
|
|||||||
))}
|
))}
|
||||||
</OptionRow>
|
</OptionRow>
|
||||||
|
|
||||||
|
{/* Default Currency */}
|
||||||
|
<div>
|
||||||
|
<label className="block text-sm font-medium mb-1.5 text-content-secondary">
|
||||||
|
{t('settings.currency')} <ResetButton field="default_currency" />
|
||||||
|
</label>
|
||||||
|
<CustomSelect
|
||||||
|
value={defaults.default_currency || ''}
|
||||||
|
onChange={(value: string) => { if (value) save({ default_currency: value }) }}
|
||||||
|
placeholder={t('settings.currency')}
|
||||||
|
searchable
|
||||||
|
options={CURRENCIES.map(c => ({ value: c, label: SYMBOLS[c] ? `${c} ${SYMBOLS[c]}` : c }))}
|
||||||
|
size="sm"
|
||||||
|
style={{ maxWidth: 240 }}
|
||||||
|
/>
|
||||||
|
<p className="text-xs mt-1 text-content-faint">{t('settings.currencyHint')}</p>
|
||||||
|
</div>
|
||||||
|
|
||||||
{/* Blur Booking Codes */}
|
{/* Blur Booking Codes */}
|
||||||
<OptionRow label={<>{t('settings.blurBookingCodes')} <ResetButton field="blur_booking_codes" /></>}>
|
<OptionRow label={<>{t('settings.blurBookingCodes')} <ResetButton field="blur_booking_codes" /></>}>
|
||||||
{([
|
{([
|
||||||
@@ -297,19 +364,21 @@ export default function DefaultUserSettingsTab(): React.ReactElement {
|
|||||||
{([
|
{([
|
||||||
{ value: 'leaflet', label: t('admin.defaultSettings.providerLeaflet') },
|
{ value: 'leaflet', label: t('admin.defaultSettings.providerLeaflet') },
|
||||||
{ value: 'mapbox-gl', label: t('admin.defaultSettings.providerMapbox') },
|
{ value: 'mapbox-gl', label: t('admin.defaultSettings.providerMapbox') },
|
||||||
|
{ value: 'maplibre-gl', label: t('admin.defaultSettings.providerMapLibre') },
|
||||||
] as const).map(opt => (
|
] as const).map(opt => (
|
||||||
<OptionButton
|
<OptionButton
|
||||||
key={opt.value}
|
key={opt.value}
|
||||||
active={(defaults.map_provider || 'leaflet') === opt.value}
|
active={mapProvider === opt.value}
|
||||||
onClick={() => save({ map_provider: opt.value })}
|
onClick={() => saveMapProvider(opt.value)}
|
||||||
>
|
>
|
||||||
{opt.label}
|
{opt.label}
|
||||||
</OptionButton>
|
</OptionButton>
|
||||||
))}
|
))}
|
||||||
</OptionRow>
|
</OptionRow>
|
||||||
|
|
||||||
{defaults.map_provider === 'mapbox-gl' && (
|
{mapProvider !== 'leaflet' && (
|
||||||
<div style={{ marginTop: 16, display: 'flex', flexDirection: 'column', gap: 18 }}>
|
<div style={{ marginTop: 16, display: 'flex', flexDirection: 'column', gap: 18 }}>
|
||||||
|
{mapProvider === 'mapbox-gl' && (
|
||||||
<div>
|
<div>
|
||||||
<label className="block text-sm font-medium mb-1.5 text-content-secondary">
|
<label className="block text-sm font-medium mb-1.5 text-content-secondary">
|
||||||
{t('admin.defaultSettings.mapboxToken')}
|
{t('admin.defaultSettings.mapboxToken')}
|
||||||
@@ -327,17 +396,18 @@ export default function DefaultUserSettingsTab(): React.ReactElement {
|
|||||||
/>
|
/>
|
||||||
<p className="text-xs mt-1 text-content-faint">{t('admin.defaultSettings.mapboxTokenHint')}</p>
|
<p className="text-xs mt-1 text-content-faint">{t('admin.defaultSettings.mapboxTokenHint')}</p>
|
||||||
</div>
|
</div>
|
||||||
|
)}
|
||||||
|
|
||||||
<div>
|
<div>
|
||||||
<label className="block text-sm font-medium mb-1.5 text-content-secondary">
|
<label className="block text-sm font-medium mb-1.5 text-content-secondary">
|
||||||
{t('admin.defaultSettings.mapboxStyle')}
|
{t('admin.defaultSettings.mapboxStyle')}
|
||||||
<ResetButton field="mapbox_style" />
|
<ResetButton field={styleKey} />
|
||||||
</label>
|
</label>
|
||||||
<CustomSelect
|
<CustomSelect
|
||||||
value={mapboxStyle}
|
value={mapboxStyle}
|
||||||
onChange={(value: string) => { if (value) { setMapboxStyle(value); save({ mapbox_style: value }) } }}
|
onChange={(value: string) => { if (value) { setMapboxStyle(value); save({ [styleKey]: value }) } }}
|
||||||
placeholder={t('admin.defaultSettings.mapboxStylePlaceholder')}
|
placeholder={t('admin.defaultSettings.mapboxStylePlaceholder')}
|
||||||
options={MAPBOX_STYLE_PRESETS.map(p => ({ value: p.url, label: p.name }))}
|
options={glStylePresets.map(p => ({ value: p.url, label: p.name }))}
|
||||||
size="sm"
|
size="sm"
|
||||||
style={{ marginBottom: 8 }}
|
style={{ marginBottom: 8 }}
|
||||||
/>
|
/>
|
||||||
@@ -345,12 +415,18 @@ export default function DefaultUserSettingsTab(): React.ReactElement {
|
|||||||
type="text"
|
type="text"
|
||||||
value={mapboxStyle}
|
value={mapboxStyle}
|
||||||
onChange={(e: React.ChangeEvent<HTMLInputElement>) => setMapboxStyle(e.target.value)}
|
onChange={(e: React.ChangeEvent<HTMLInputElement>) => setMapboxStyle(e.target.value)}
|
||||||
onBlur={() => save({ mapbox_style: mapboxStyle })}
|
onBlur={() => {
|
||||||
placeholder="mapbox://styles/mapbox/standard"
|
const nextStyle = normalizeStyleForProvider(mapProvider, mapboxStyle)
|
||||||
|
setMapboxStyle(nextStyle)
|
||||||
|
save({ [styleKey]: nextStyle })
|
||||||
|
}}
|
||||||
|
placeholder={defaultStyleForProvider(mapProvider)}
|
||||||
className="w-full px-3 py-2 border border-slate-300 rounded-lg text-sm focus:ring-2 focus:ring-slate-400 focus:border-transparent"
|
className="w-full px-3 py-2 border border-slate-300 rounded-lg text-sm focus:ring-2 focus:ring-slate-400 focus:border-transparent"
|
||||||
/>
|
/>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
|
{mapProvider === 'mapbox-gl' && (
|
||||||
|
<>
|
||||||
<OptionRow label={<>{t('admin.defaultSettings.mapbox3d')} <ResetButton field="mapbox_3d_enabled" /></>}>
|
<OptionRow label={<>{t('admin.defaultSettings.mapbox3d')} <ResetButton field="mapbox_3d_enabled" /></>}>
|
||||||
{([
|
{([
|
||||||
{ value: true, label: t('settings.on') || 'On' },
|
{ value: true, label: t('settings.on') || 'On' },
|
||||||
@@ -372,6 +448,8 @@ export default function DefaultUserSettingsTab(): React.ReactElement {
|
|||||||
</OptionButton>
|
</OptionButton>
|
||||||
))}
|
))}
|
||||||
</OptionRow>
|
</OptionRow>
|
||||||
|
</>
|
||||||
|
)}
|
||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
</div>
|
</div>
|
||||||
|
|||||||
@@ -0,0 +1,197 @@
|
|||||||
|
// FE-COMP-COSTS: settlements surfaced inline in the Costs ledger (issue #1241)
|
||||||
|
import { render, screen, waitFor } from '../../../tests/helpers/render'
|
||||||
|
import { http, HttpResponse } from 'msw'
|
||||||
|
import { server } from '../../../tests/helpers/msw/server'
|
||||||
|
import { useAuthStore } from '../../store/authStore'
|
||||||
|
import { useTripStore } from '../../store/tripStore'
|
||||||
|
import { resetAllStores, seedStore } from '../../../tests/helpers/store'
|
||||||
|
import { buildUser, buildTrip, buildBudgetItem } from '../../../tests/helpers/factories'
|
||||||
|
import CostsPanel from './CostsPanel'
|
||||||
|
|
||||||
|
const tripMembers = [
|
||||||
|
{ id: 1, username: 'alice', avatar_url: null },
|
||||||
|
{ id: 2, username: 'bob', avatar_url: null },
|
||||||
|
]
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
resetAllStores()
|
||||||
|
seedStore(useAuthStore, { user: buildUser(), isAuthenticated: true })
|
||||||
|
seedStore(useTripStore, { trip: buildTrip({ id: 1, currency: 'EUR' }) })
|
||||||
|
})
|
||||||
|
|
||||||
|
describe('CostsPanel — settlements in the ledger', () => {
|
||||||
|
it('renders a settle-up payment as a ledger row with an undo action', async () => {
|
||||||
|
const item = { ...buildBudgetItem({ trip_id: 1, category: 'food', name: 'Dinner' }), total_price: 90, expense_date: '2025-06-15' }
|
||||||
|
server.use(
|
||||||
|
http.get('/api/trips/1/budget', () => HttpResponse.json({ items: [item] })),
|
||||||
|
http.get('/api/trips/1/budget/settlement', () =>
|
||||||
|
HttpResponse.json({
|
||||||
|
balances: [],
|
||||||
|
flows: [],
|
||||||
|
settlements: [
|
||||||
|
{ id: 7, trip_id: 1, from_user_id: 2, to_user_id: 1, amount: 30, created_at: '2025-06-16 10:00:00', from_username: 'bob', to_username: 'alice' },
|
||||||
|
],
|
||||||
|
})
|
||||||
|
),
|
||||||
|
)
|
||||||
|
render(<CostsPanel tripId={1} tripMembers={tripMembers} />)
|
||||||
|
|
||||||
|
// The expense and the settlement (payment) both appear in the unified ledger.
|
||||||
|
await screen.findByText('Dinner')
|
||||||
|
await screen.findByText('Payment')
|
||||||
|
// The payment row exposes an inline undo (no need to open a separate History modal).
|
||||||
|
expect(screen.getByTitle('Undo')).toBeInTheDocument()
|
||||||
|
})
|
||||||
|
|
||||||
|
it('records a manual payment via the Add payment button', async () => {
|
||||||
|
let posted: Record<string, unknown> | null = null
|
||||||
|
server.use(
|
||||||
|
http.get('/api/trips/1/budget', () => HttpResponse.json({ items: [] })),
|
||||||
|
http.get('/api/trips/1/budget/settlement', () => HttpResponse.json({ balances: [], flows: [], settlements: [] })),
|
||||||
|
http.post('/api/trips/1/budget/settlements', async ({ request }) => {
|
||||||
|
posted = await request.json() as Record<string, unknown>
|
||||||
|
return HttpResponse.json({ settlement: { id: 1, ...posted } })
|
||||||
|
}),
|
||||||
|
)
|
||||||
|
const { default: userEvent } = await import('@testing-library/user-event')
|
||||||
|
const user = userEvent.setup()
|
||||||
|
render(<CostsPanel tripId={1} tripMembers={tripMembers} />)
|
||||||
|
|
||||||
|
await user.click(await screen.findByRole('button', { name: 'Add payment' }))
|
||||||
|
await user.type(await screen.findByPlaceholderText('0.00'), '25')
|
||||||
|
// The footer submit is the second "Add payment" control once the modal is open.
|
||||||
|
const addButtons = screen.getAllByRole('button', { name: 'Add payment' })
|
||||||
|
const submit = addButtons[addButtons.length - 1]
|
||||||
|
await user.click(submit)
|
||||||
|
await waitFor(() => expect(posted).toMatchObject({ amount: 25 }))
|
||||||
|
})
|
||||||
|
|
||||||
|
it('hides payment rows while a text search is active', async () => {
|
||||||
|
const item = { ...buildBudgetItem({ trip_id: 1, category: 'food', name: 'Dinner' }), total_price: 90, expense_date: '2025-06-15' }
|
||||||
|
server.use(
|
||||||
|
http.get('/api/trips/1/budget', () => HttpResponse.json({ items: [item] })),
|
||||||
|
http.get('/api/trips/1/budget/settlement', () =>
|
||||||
|
HttpResponse.json({
|
||||||
|
balances: [],
|
||||||
|
flows: [],
|
||||||
|
settlements: [
|
||||||
|
{ id: 7, trip_id: 1, from_user_id: 2, to_user_id: 1, amount: 30, created_at: '2025-06-16 10:00:00', from_username: 'bob', to_username: 'alice' },
|
||||||
|
],
|
||||||
|
})
|
||||||
|
),
|
||||||
|
)
|
||||||
|
const { default: userEvent } = await import('@testing-library/user-event')
|
||||||
|
const user = userEvent.setup()
|
||||||
|
render(<CostsPanel tripId={1} tripMembers={tripMembers} />)
|
||||||
|
|
||||||
|
await screen.findByText('Payment')
|
||||||
|
await user.type(screen.getByPlaceholderText('Search expenses…'), 'Dinner')
|
||||||
|
// Payment rows have no name, so a search hides them while the matching expense stays.
|
||||||
|
expect(screen.queryByText('Payment')).not.toBeInTheDocument()
|
||||||
|
expect(screen.getByText('Dinner')).toBeInTheDocument()
|
||||||
|
})
|
||||||
|
|
||||||
|
it('auto-splits the total across participants and rebalances a pinned amount on save', async () => {
|
||||||
|
let posted: Record<string, unknown> | null = null
|
||||||
|
server.use(
|
||||||
|
http.get('/api/trips/1/budget', () => HttpResponse.json({ items: [] })),
|
||||||
|
http.get('/api/trips/1/budget/settlement', () => HttpResponse.json({ balances: [], flows: [], settlements: [] })),
|
||||||
|
http.post('/api/trips/1/budget', async ({ request }) => {
|
||||||
|
posted = await request.json() as Record<string, unknown>
|
||||||
|
return HttpResponse.json({ item: { ...buildBudgetItem({ trip_id: 1, name: 'Dinner' }), id: 5 } })
|
||||||
|
}),
|
||||||
|
)
|
||||||
|
const { default: userEvent } = await import('@testing-library/user-event')
|
||||||
|
const user = userEvent.setup()
|
||||||
|
render(<CostsPanel tripId={1} tripMembers={tripMembers} />)
|
||||||
|
|
||||||
|
await user.click(await screen.findByRole('button', { name: 'Add expense' }))
|
||||||
|
await user.type(await screen.findByPlaceholderText('e.g. Dinner, souvenirs, gas…'), 'Dinner')
|
||||||
|
const nums = () => screen.getAllByPlaceholderText('0.00') as HTMLInputElement[]
|
||||||
|
await user.type(nums()[0], '100') // total → auto equal-split across the 2 participants
|
||||||
|
await waitFor(() => expect(nums()[1].value).toBe('50'))
|
||||||
|
expect(nums()[2].value).toBe('50')
|
||||||
|
// Pin the first participant to 30 → the other non-pinned field rebalances to 70.
|
||||||
|
await user.clear(nums()[1]); await user.type(nums()[1], '30')
|
||||||
|
await waitFor(() => expect(nums()[2].value).toBe('70'))
|
||||||
|
|
||||||
|
const addBtns = screen.getAllByRole('button', { name: 'Add expense' })
|
||||||
|
await user.click(addBtns[addBtns.length - 1]) // footer submit
|
||||||
|
await waitFor(() => expect(posted).toBeTruthy())
|
||||||
|
expect(posted!.total_price).toBe(100)
|
||||||
|
expect(posted!.payers).toEqual(expect.arrayContaining([
|
||||||
|
expect.objectContaining({ user_id: 1, amount: 30 }),
|
||||||
|
expect.objectContaining({ user_id: 2, amount: 70 }),
|
||||||
|
]))
|
||||||
|
})
|
||||||
|
|
||||||
|
it('accepts a comma as the decimal separator in the total amount (#1256)', async () => {
|
||||||
|
let posted: Record<string, unknown> | null = null
|
||||||
|
server.use(
|
||||||
|
http.get('/api/trips/1/budget', () => HttpResponse.json({ items: [] })),
|
||||||
|
http.get('/api/trips/1/budget/settlement', () => HttpResponse.json({ balances: [], flows: [], settlements: [] })),
|
||||||
|
http.post('/api/trips/1/budget', async ({ request }) => {
|
||||||
|
posted = await request.json() as Record<string, unknown>
|
||||||
|
return HttpResponse.json({ item: { ...buildBudgetItem({ trip_id: 1, name: 'AirTags' }), id: 6 } })
|
||||||
|
}),
|
||||||
|
)
|
||||||
|
const { default: userEvent } = await import('@testing-library/user-event')
|
||||||
|
const user = userEvent.setup()
|
||||||
|
render(<CostsPanel tripId={1} tripMembers={tripMembers} />)
|
||||||
|
|
||||||
|
await user.click(await screen.findByRole('button', { name: 'Add expense' }))
|
||||||
|
await user.type(await screen.findByPlaceholderText('e.g. Dinner, souvenirs, gas…'), 'AirTags')
|
||||||
|
await user.type(screen.getAllByPlaceholderText('0.00')[0], '39,99') // comma → normalized to 39.99
|
||||||
|
|
||||||
|
const addBtns = screen.getAllByRole('button', { name: 'Add expense' })
|
||||||
|
await user.click(addBtns[addBtns.length - 1]) // footer submit
|
||||||
|
await waitFor(() => expect(posted).toBeTruthy())
|
||||||
|
expect(posted!.total_price).toBe(39.99)
|
||||||
|
})
|
||||||
|
|
||||||
|
it('marks an expense with no payer as Unfinished', async () => {
|
||||||
|
const item = { ...buildBudgetItem({ trip_id: 1, category: 'food', name: 'Hotel' }), total_price: 90, payers: [], members: [{ user_id: 1, username: 'alice', paid: 0 }] }
|
||||||
|
server.use(
|
||||||
|
http.get('/api/trips/1/budget', () => HttpResponse.json({ items: [item] })),
|
||||||
|
http.get('/api/trips/1/budget/settlement', () => HttpResponse.json({ balances: [], flows: [], settlements: [] })),
|
||||||
|
)
|
||||||
|
render(<CostsPanel tripId={1} tripMembers={tripMembers} />)
|
||||||
|
await screen.findByText('Hotel')
|
||||||
|
expect(screen.getByText('Unfinished')).toBeInTheDocument()
|
||||||
|
})
|
||||||
|
|
||||||
|
it('records a recorded-total expense with nobody to split with (#1286)', async () => {
|
||||||
|
let posted: Record<string, unknown> | null = null
|
||||||
|
server.use(
|
||||||
|
http.get('/api/trips/1/budget', () => HttpResponse.json({ items: [] })),
|
||||||
|
http.get('/api/trips/1/budget/settlement', () => HttpResponse.json({ balances: [], flows: [], settlements: [] })),
|
||||||
|
http.post('/api/trips/1/budget', async ({ request }) => {
|
||||||
|
posted = await request.json() as Record<string, unknown>
|
||||||
|
return HttpResponse.json({ item: { ...buildBudgetItem({ trip_id: 1, name: 'Hotel' }), id: 9 } })
|
||||||
|
}),
|
||||||
|
)
|
||||||
|
const { default: userEvent } = await import('@testing-library/user-event')
|
||||||
|
const user = userEvent.setup()
|
||||||
|
render(<CostsPanel tripId={1} tripMembers={tripMembers} />)
|
||||||
|
|
||||||
|
await user.click(await screen.findByRole('button', { name: 'Add expense' }))
|
||||||
|
await user.type(await screen.findByPlaceholderText('e.g. Dinner, souvenirs, gas…'), 'Hotel')
|
||||||
|
await user.type(screen.getAllByPlaceholderText('0.00')[0], '120') // total only, paid on-site later
|
||||||
|
|
||||||
|
// Deselect everyone — the cost is recorded without a split (the bug: this was blocked).
|
||||||
|
// The participant toggles are buttons; the same names also appear as plain text in
|
||||||
|
// the Balances sidebar, so target the buttons specifically.
|
||||||
|
await user.click(screen.getByRole('button', { name: /alice/i }))
|
||||||
|
await user.click(screen.getByRole('button', { name: /bob/i }))
|
||||||
|
|
||||||
|
const addBtns = screen.getAllByRole('button', { name: 'Add expense' })
|
||||||
|
const submit = addBtns[addBtns.length - 1] // footer submit
|
||||||
|
expect(submit).not.toBeDisabled()
|
||||||
|
await user.click(submit)
|
||||||
|
|
||||||
|
await waitFor(() => expect(posted).toBeTruthy())
|
||||||
|
expect(posted!.total_price).toBe(120)
|
||||||
|
expect(posted!.member_ids).toEqual([])
|
||||||
|
expect(posted!.payers).toEqual([])
|
||||||
|
})
|
||||||
|
})
|
||||||
@@ -1,6 +1,6 @@
|
|||||||
import { useState, useEffect, useMemo, useCallback } from 'react'
|
import { useState, useEffect, useMemo, useCallback } from 'react'
|
||||||
import { useSearchParams } from 'react-router-dom'
|
import { useSearchParams } from 'react-router-dom'
|
||||||
import { ArrowDown, ArrowUp, BarChart3, Plus, Search, ArrowRight, Check, RotateCcw, History, Pencil, Trash2 } from 'lucide-react'
|
import { ArrowDown, ArrowUp, BarChart3, Plus, Search, ArrowRight, ArrowLeftRight, Check, RotateCcw, Pencil, Trash2 } from 'lucide-react'
|
||||||
import { useTripStore } from '../../store/tripStore'
|
import { useTripStore } from '../../store/tripStore'
|
||||||
import { useAuthStore } from '../../store/authStore'
|
import { useAuthStore } from '../../store/authStore'
|
||||||
import { useSettingsStore } from '../../store/settingsStore'
|
import { useSettingsStore } from '../../store/settingsStore'
|
||||||
@@ -39,6 +39,12 @@ interface SettlementData {
|
|||||||
settlements: Settlement[]
|
settlements: Settlement[]
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// One row in the unified Costs ledger — either an expense or a settle-up payment,
|
||||||
|
// carrying the date used to group it by day.
|
||||||
|
type LedgerEntry =
|
||||||
|
| { kind: 'expense'; date: string; e: BudgetItem }
|
||||||
|
| { kind: 'payment'; date: string; s: Settlement }
|
||||||
|
|
||||||
const round2 = (n: number) => Math.round(n * 100) / 100
|
const round2 = (n: number) => Math.round(n * 100) / 100
|
||||||
const FIELD_H = 40 // shared height for the amount / currency / day row in the modal
|
const FIELD_H = 40 // shared height for the amount / currency / day row in the modal
|
||||||
|
|
||||||
@@ -62,9 +68,10 @@ export default function CostsPanel({ tripId, tripMembers = [] }: CostsPanelProps
|
|||||||
const [settlement, setSettlement] = useState<SettlementData | null>(null)
|
const [settlement, setSettlement] = useState<SettlementData | null>(null)
|
||||||
const [filter, setFilter] = useState<'all' | 'mine' | 'owed'>('all')
|
const [filter, setFilter] = useState<'all' | 'mine' | 'owed'>('all')
|
||||||
const [search, setSearch] = useState('')
|
const [search, setSearch] = useState('')
|
||||||
const [histOpen, setHistOpen] = useState(false)
|
|
||||||
const [modalOpen, setModalOpen] = useState(false)
|
const [modalOpen, setModalOpen] = useState(false)
|
||||||
const [editing, setEditing] = useState<BudgetItem | null>(null)
|
const [editing, setEditing] = useState<BudgetItem | null>(null)
|
||||||
|
const [editingSettlement, setEditingSettlement] = useState<Settlement | null>(null)
|
||||||
|
const [addingPayment, setAddingPayment] = useState(false)
|
||||||
|
|
||||||
const people = tripMembers
|
const people = tripMembers
|
||||||
const personById = useCallback((id: number) => people.find(p => p.id === id), [people])
|
const personById = useCallback((id: number) => people.find(p => p.id === id), [people])
|
||||||
@@ -122,21 +129,37 @@ export default function CostsPanel({ tripId, tripMembers = [] }: CostsPanelProps
|
|||||||
return list
|
return list
|
||||||
}, [budgetItems, filter, search, me])
|
}, [budgetItems, filter, search, me])
|
||||||
|
|
||||||
|
// Settlements ("payments") shown inline in the ledger. They have no name, so a
|
||||||
|
// text search hides them; they're excluded from the "owed" expense filter and,
|
||||||
|
// under "mine", only show transfers I'm part of.
|
||||||
|
const filteredSettlements = useMemo(() => {
|
||||||
|
if (search.trim()) return []
|
||||||
|
if (filter === 'owed') return []
|
||||||
|
let list = settlement?.settlements || []
|
||||||
|
if (filter === 'mine') list = list.filter(s => s.from_user_id === me || s.to_user_id === me)
|
||||||
|
return list
|
||||||
|
}, [settlement, filter, search, me])
|
||||||
|
|
||||||
const dayGroups = useMemo(() => {
|
const dayGroups = useMemo(() => {
|
||||||
const groups: { day: string; items: BudgetItem[] }[] = []
|
const entries: LedgerEntry[] = [
|
||||||
const labelOf = (e: BudgetItem) => {
|
...filtered.map(e => ({ kind: 'expense' as const, date: e.expense_date || '', e })),
|
||||||
if (!e.expense_date) return t('costs.noDate')
|
...filteredSettlements.map(s => ({ kind: 'payment' as const, date: (s.created_at || '').slice(0, 10), s })),
|
||||||
try { return new Date(e.expense_date + 'T00:00:00Z').toLocaleDateString(locale, { weekday: 'short', day: 'numeric', month: 'short', timeZone: 'UTC' }) } catch { return e.expense_date }
|
]
|
||||||
|
const labelOf = (date: string) => {
|
||||||
|
if (!date) return t('costs.noDate')
|
||||||
|
try { return new Date(date + 'T00:00:00Z').toLocaleDateString(locale, { weekday: 'short', day: 'numeric', month: 'short', timeZone: 'UTC' }) } catch { return date }
|
||||||
}
|
}
|
||||||
const sorted = filtered.slice().sort((a, b) => (b.expense_date || '').localeCompare(a.expense_date || ''))
|
// Newest day first; within a day, expenses before payments (insertion order).
|
||||||
for (const e of sorted) {
|
const sorted = entries.slice().sort((a, b) => (b.date || '').localeCompare(a.date || ''))
|
||||||
const day = labelOf(e)
|
const groups: { day: string; entries: LedgerEntry[] }[] = []
|
||||||
|
for (const en of sorted) {
|
||||||
|
const day = labelOf(en.date)
|
||||||
let g = groups.find(x => x.day === day)
|
let g = groups.find(x => x.day === day)
|
||||||
if (!g) { g = { day, items: [] }; groups.push(g) }
|
if (!g) { g = { day, entries: [] }; groups.push(g) }
|
||||||
g.items.push(e)
|
g.entries.push(en)
|
||||||
}
|
}
|
||||||
return groups
|
return groups
|
||||||
}, [filtered, locale, t])
|
}, [filtered, filteredSettlements, locale, t])
|
||||||
|
|
||||||
// ── settle actions ──────────────────────────────────────────────────────
|
// ── settle actions ──────────────────────────────────────────────────────
|
||||||
const settleFlow = async (fromId: number, toId: number, amount: number) => {
|
const settleFlow = async (fromId: number, toId: number, amount: number) => {
|
||||||
@@ -280,14 +303,16 @@ export default function CostsPanel({ tripId, tripMembers = [] }: CostsPanelProps
|
|||||||
{search ? t('costs.noMatch') : t('costs.emptyText')}
|
{search ? t('costs.noMatch') : t('costs.emptyText')}
|
||||||
</div>
|
</div>
|
||||||
) : dayGroups.map(g => {
|
) : dayGroups.map(g => {
|
||||||
const dtot = g.items.reduce((a, e) => a + baseTotal(e), 0)
|
const dtot = g.entries.reduce((a, en) => en.kind === 'expense' ? a + baseTotal(en.e) : a, 0)
|
||||||
return (
|
return (
|
||||||
<div key={g.day} style={{ marginBottom: 22 }}>
|
<div key={g.day} style={{ marginBottom: 22 }}>
|
||||||
<div className={labelCls} style={{ display: 'flex', alignItems: 'center', margin: '0 0 10px 4px' }}>
|
<div className={labelCls} style={{ display: 'flex', alignItems: 'center', margin: '0 0 10px 4px' }}>
|
||||||
{g.day}<span className="text-content-muted" style={{ marginLeft: 'auto', textTransform: 'none', letterSpacing: 0, fontWeight: 500, fontSize: 12 }}>{t('costs.spent', { amount: fmt(dtot) })}</span>
|
{g.day}<span className="text-content-muted" style={{ marginLeft: 'auto', textTransform: 'none', letterSpacing: 0, fontWeight: 500, fontSize: 12 }}>{t('costs.spent', { amount: fmt(dtot) })}</span>
|
||||||
</div>
|
</div>
|
||||||
<div style={{ display: 'flex', flexDirection: 'column', gap: 8 }}>
|
<div style={{ display: 'flex', flexDirection: 'column', gap: 8 }}>
|
||||||
{g.items.map(e => <ExpenseRow key={e.id} e={e} />)}
|
{g.entries.map(en => en.kind === 'expense'
|
||||||
|
? <ExpenseRow key={'e' + en.e.id} e={en.e} />
|
||||||
|
: <SettlementRow key={'s' + en.s.id} s={en.s} />)}
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
)
|
)
|
||||||
@@ -300,11 +325,13 @@ export default function CostsPanel({ tripId, tripMembers = [] }: CostsPanelProps
|
|||||||
<div className={cardCls} style={{ borderRadius: 22, padding: '22px 24px' }}>
|
<div className={cardCls} style={{ borderRadius: 22, padding: '22px 24px' }}>
|
||||||
<div style={{ display: 'flex', alignItems: 'center', justifyContent: 'space-between', marginBottom: 14 }}>
|
<div style={{ display: 'flex', alignItems: 'center', justifyContent: 'space-between', marginBottom: 14 }}>
|
||||||
<div className={labelCls}>{t('costs.settleUp')} · <span className="text-content">{(settlement?.flows || []).length}</span></div>
|
<div className={labelCls}>{t('costs.settleUp')} · <span className="text-content">{(settlement?.flows || []).length}</span></div>
|
||||||
<button disabled={!(settlement?.settlements || []).length} onClick={() => setHistOpen(true)}
|
{canEdit && (
|
||||||
className="text-content-muted bg-surface-secondary border border-edge disabled:opacity-40"
|
<button onClick={() => setAddingPayment(true)}
|
||||||
style={{ display: 'inline-flex', alignItems: 'center', gap: 5, padding: '5px 9px', borderRadius: 8, fontSize: 11.5, fontWeight: 600, cursor: 'pointer', fontFamily: 'inherit' }}>
|
className="text-content-muted bg-surface-secondary border border-edge"
|
||||||
<History size={13} /> {t('costs.history')}{(settlement?.settlements || []).length ? ` (${settlement!.settlements.length})` : ''}
|
style={{ display: 'inline-flex', alignItems: 'center', gap: 5, padding: '5px 9px', borderRadius: 8, fontSize: 11.5, fontWeight: 600, cursor: 'pointer', fontFamily: 'inherit' }}>
|
||||||
</button>
|
<Plus size={13} /> {t('costs.addPayment')}
|
||||||
|
</button>
|
||||||
|
)}
|
||||||
</div>
|
</div>
|
||||||
<SettleFlows />
|
<SettleFlows />
|
||||||
</div>
|
</div>
|
||||||
@@ -330,9 +357,11 @@ export default function CostsPanel({ tripId, tripMembers = [] }: CostsPanelProps
|
|||||||
onSaved={() => { setModalOpen(false); loadBudgetItems(tripId); loadSettlement() }} />
|
onSaved={() => { setModalOpen(false); loadBudgetItems(tripId); loadSettlement() }} />
|
||||||
)}
|
)}
|
||||||
|
|
||||||
<Modal isOpen={histOpen} onClose={() => setHistOpen(false)} title={t('costs.settleHistory')} size="md">
|
{(editingSettlement || addingPayment) && (
|
||||||
<SettleHistory settlements={settlement?.settlements || []} fmt={fmt} Avatar={Avatar} name={personName} onUndo={undoSettlement} canEdit={canEdit} />
|
<SettlementModal tripId={tripId} people={people} me={me} editing={editingSettlement}
|
||||||
</Modal>
|
onClose={() => { setEditingSettlement(null); setAddingPayment(false) }}
|
||||||
|
onSaved={() => { setEditingSettlement(null); setAddingPayment(false); loadSettlement() }} />
|
||||||
|
)}
|
||||||
|
|
||||||
<style>{`
|
<style>{`
|
||||||
.costs-root {
|
.costs-root {
|
||||||
@@ -438,7 +467,9 @@ export default function CostsPanel({ tripId, tripMembers = [] }: CostsPanelProps
|
|||||||
<div className={cardCls} style={{ borderRadius: 18, padding: 16 }}>
|
<div className={cardCls} style={{ borderRadius: 18, padding: 16 }}>
|
||||||
<div style={{ display: 'flex', alignItems: 'center', justifyContent: 'space-between', marginBottom: 14, gap: 8 }}>
|
<div style={{ display: 'flex', alignItems: 'center', justifyContent: 'space-between', marginBottom: 14, gap: 8 }}>
|
||||||
<div className="text-content" style={{ fontSize: 19, fontWeight: 700, letterSpacing: '-0.02em', display: 'flex', alignItems: 'baseline', gap: 8 }}>{t('costs.settleUp')} <span className="text-content-faint" style={{ fontSize: 12, fontWeight: 500 }}>{(settlement?.flows || []).length}</span></div>
|
<div className="text-content" style={{ fontSize: 19, fontWeight: 700, letterSpacing: '-0.02em', display: 'flex', alignItems: 'baseline', gap: 8 }}>{t('costs.settleUp')} <span className="text-content-faint" style={{ fontSize: 12, fontWeight: 500 }}>{(settlement?.flows || []).length}</span></div>
|
||||||
<button disabled={!(settlement?.settlements || []).length} onClick={() => setHistOpen(true)} className="text-content-muted bg-surface-card border border-edge disabled:opacity-40" style={{ display: 'inline-flex', alignItems: 'center', gap: 5, padding: '6px 10px', borderRadius: 9, fontSize: 11.5, fontWeight: 600, cursor: 'pointer', fontFamily: 'inherit' }}><History size={13} /> {t('costs.history')}</button>
|
{canEdit && (
|
||||||
|
<button onClick={() => setAddingPayment(true)} className="text-content-muted bg-surface-card border border-edge" style={{ display: 'inline-flex', alignItems: 'center', gap: 5, padding: '6px 10px', borderRadius: 9, fontSize: 11.5, fontWeight: 600, cursor: 'pointer', fontFamily: 'inherit' }}><Plus size={13} /> {t('costs.addPayment')}</button>
|
||||||
|
)}
|
||||||
</div>
|
</div>
|
||||||
<SettleFlows />
|
<SettleFlows />
|
||||||
</div>
|
</div>
|
||||||
@@ -458,11 +489,13 @@ export default function CostsPanel({ tripId, tripMembers = [] }: CostsPanelProps
|
|||||||
{dayGroups.length === 0
|
{dayGroups.length === 0
|
||||||
? <div className="text-content-faint" style={{ textAlign: 'center', padding: '36px 16px', fontSize: 13 }}>{search ? t('costs.noMatch') : t('costs.emptyText')}</div>
|
? <div className="text-content-faint" style={{ textAlign: 'center', padding: '36px 16px', fontSize: 13 }}>{search ? t('costs.noMatch') : t('costs.emptyText')}</div>
|
||||||
: dayGroups.map(g => {
|
: dayGroups.map(g => {
|
||||||
const dtot = g.items.reduce((a, e) => a + baseTotal(e), 0)
|
const dtot = g.entries.reduce((a, en) => en.kind === 'expense' ? a + baseTotal(en.e) : a, 0)
|
||||||
return (
|
return (
|
||||||
<div key={g.day} style={{ display: 'flex', flexDirection: 'column', gap: 8 }}>
|
<div key={g.day} style={{ display: 'flex', flexDirection: 'column', gap: 8 }}>
|
||||||
<div className={labelCls} style={{ display: 'flex', alignItems: 'center', padding: '0 2px' }}>{g.day}<span className="text-content-muted" style={{ marginLeft: 'auto', textTransform: 'none', letterSpacing: 0, fontWeight: 500, fontSize: 11.5 }}>{t('costs.spent', { amount: fmt(dtot) })}</span></div>
|
<div className={labelCls} style={{ display: 'flex', alignItems: 'center', padding: '0 2px' }}>{g.day}<span className="text-content-muted" style={{ marginLeft: 'auto', textTransform: 'none', letterSpacing: 0, fontWeight: 500, fontSize: 11.5 }}>{t('costs.spent', { amount: fmt(dtot) })}</span></div>
|
||||||
<div style={{ display: 'flex', flexDirection: 'column', gap: 8 }}>{g.items.map(e => <ExpenseRow key={e.id} e={e} />)}</div>
|
<div style={{ display: 'flex', flexDirection: 'column', gap: 8 }}>{g.entries.map(en => en.kind === 'expense'
|
||||||
|
? <ExpenseRow key={'e' + en.e.id} e={en.e} />
|
||||||
|
: <SettlementRow key={'s' + en.s.id} s={en.s} />)}</div>
|
||||||
</div>
|
</div>
|
||||||
)
|
)
|
||||||
})}
|
})}
|
||||||
@@ -490,11 +523,27 @@ export default function CostsPanel({ tripId, tripMembers = [] }: CostsPanelProps
|
|||||||
const cur = curOf(e)
|
const cur = curOf(e)
|
||||||
const payers = (e.payers || []).filter(p => p.amount > 0)
|
const payers = (e.payers || []).filter(p => p.amount > 0)
|
||||||
const net = round2(myPaidOf(e) - myShareOf(e))
|
const net = round2(myPaidOf(e) - myShareOf(e))
|
||||||
|
// "Unfinished": a recorded total nobody has paid yet — counts toward the trip
|
||||||
|
// total but stays out of settlements until who-paid is filled in.
|
||||||
|
const isUnfinished = baseTotal(e) > 0 && payers.length === 0
|
||||||
return (
|
return (
|
||||||
<div className="bg-surface-card border border-edge exp-row" style={{ display: 'grid', gridTemplateColumns: '46px 1fr auto', gap: 16, alignItems: 'center', borderRadius: 18, padding: '16px 20px' }}>
|
<div className="bg-surface-card border border-edge exp-row" style={{ display: 'grid', gridTemplateColumns: '46px 1fr auto', gap: 16, alignItems: 'center', borderRadius: 18, padding: '16px 20px' }}>
|
||||||
<span style={{ width: 46, height: 46, borderRadius: 13, display: 'grid', placeItems: 'center', background: c.color + '22', color: c.color }}><Icon size={21} /></span>
|
<span style={{ position: 'relative', width: 46, height: 46, borderRadius: 13, display: 'grid', placeItems: 'center', background: c.color + '22', color: c.color }}>
|
||||||
|
<Icon size={21} />
|
||||||
|
{isMobile && isUnfinished && (
|
||||||
|
<span title={t('costs.unfinishedHint')} style={{ position: 'absolute', bottom: -4, right: -4, width: 20, height: 20, borderRadius: '50%', background: '#d97706', color: '#fff', display: 'grid', placeItems: 'center', fontSize: 12, fontWeight: 800, lineHeight: 1, border: '2px solid var(--bg-card)' }}>!</span>
|
||||||
|
)}
|
||||||
|
</span>
|
||||||
<div style={{ minWidth: 0 }}>
|
<div style={{ minWidth: 0 }}>
|
||||||
<div className="text-content" style={{ fontSize: 15, fontWeight: 600, marginBottom: 6 }}>{e.name}</div>
|
<div style={{ display: 'flex', alignItems: 'center', gap: 7, marginBottom: 6 }}>
|
||||||
|
<span className="text-content" style={{ fontSize: 15, fontWeight: 600 }}>{e.name}</span>
|
||||||
|
{isUnfinished && !isMobile && (
|
||||||
|
<span title={t('costs.unfinishedHint')} style={{ display: 'inline-flex', alignItems: 'center', gap: 4, padding: '2px 8px 2px 6px', borderRadius: 999, background: 'rgba(217,119,6,0.14)', color: '#d97706', fontSize: 11, fontWeight: 700, flexShrink: 0 }}>
|
||||||
|
<span style={{ width: 14, height: 14, borderRadius: '50%', background: '#d97706', color: '#fff', display: 'grid', placeItems: 'center', fontSize: 10, fontWeight: 800 }}>!</span>
|
||||||
|
{t('costs.unfinished')}
|
||||||
|
</span>
|
||||||
|
)}
|
||||||
|
</div>
|
||||||
{payers.length > 0 && (
|
{payers.length > 0 && (
|
||||||
<div style={{ display: 'flex', flexWrap: 'wrap', gap: 5, marginBottom: 5 }}>
|
<div style={{ display: 'flex', flexWrap: 'wrap', gap: 5, marginBottom: 5 }}>
|
||||||
{payers.map(p => (
|
{payers.map(p => (
|
||||||
@@ -514,7 +563,7 @@ export default function CostsPanel({ tripId, tripMembers = [] }: CostsPanelProps
|
|||||||
<div style={{ display: 'flex', alignItems: 'center', gap: 10, alignSelf: 'center' }}>
|
<div style={{ display: 'flex', alignItems: 'center', gap: 10, alignSelf: 'center' }}>
|
||||||
<div style={{ textAlign: 'right', whiteSpace: 'nowrap' }}>
|
<div style={{ textAlign: 'right', whiteSpace: 'nowrap' }}>
|
||||||
<div className="text-content" style={{ fontSize: 18, fontWeight: 600 }}>{fmt(baseTotal(e))}</div>
|
<div className="text-content" style={{ fontSize: 18, fontWeight: 600 }}>{fmt(baseTotal(e))}</div>
|
||||||
{(e.members || []).length > 0 && Math.abs(net) > 0.01 && (
|
{!isUnfinished && (e.members || []).length > 0 && Math.abs(net) > 0.01 && (
|
||||||
<div style={{ fontSize: 12, marginTop: 2, fontWeight: 500, whiteSpace: 'nowrap', color: net > 0 ? '#16a34a' : '#dc2626' }}>
|
<div style={{ fontSize: 12, marginTop: 2, fontWeight: 500, whiteSpace: 'nowrap', color: net > 0 ? '#16a34a' : '#dc2626' }}>
|
||||||
{net > 0 ? t('costs.youLent', { amount: fmt(net) }) : t('costs.youBorrowed', { amount: fmt(-net) })}
|
{net > 0 ? t('costs.youLent', { amount: fmt(net) }) : t('costs.youBorrowed', { amount: fmt(-net) })}
|
||||||
</div>
|
</div>
|
||||||
@@ -531,6 +580,32 @@ export default function CostsPanel({ tripId, tripMembers = [] }: CostsPanelProps
|
|||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// A settle-up payment as a ledger row — visually distinct from an expense, with
|
||||||
|
// inline edit + undo (reuses deleteSettlement) so it isn't buried in a modal.
|
||||||
|
function SettlementRow({ s }: { s: Settlement }) {
|
||||||
|
return (
|
||||||
|
<div className="bg-surface-card border border-edge exp-row" style={{ display: 'grid', gridTemplateColumns: '46px 1fr auto', gap: 16, alignItems: 'center', borderRadius: 18, padding: '16px 20px' }}>
|
||||||
|
<span style={{ width: 46, height: 46, borderRadius: 13, display: 'grid', placeItems: 'center', background: 'rgba(22,163,74,0.12)', color: '#16a34a' }}><ArrowLeftRight size={21} /></span>
|
||||||
|
<div style={{ minWidth: 0 }}>
|
||||||
|
<div className="text-content" style={{ fontSize: 15, fontWeight: 600, marginBottom: 6 }}>{t('costs.payment')}</div>
|
||||||
|
<div style={{ display: 'flex', alignItems: 'center', gap: 7, minWidth: 0 }} title={`${personName(s.from_user_id)} → ${personName(s.to_user_id)}`}>
|
||||||
|
<Avatar id={s.from_user_id} size={20} /><ArrowRight size={13} className="text-content-faint" /><Avatar id={s.to_user_id} size={20} />
|
||||||
|
<span className="text-content-faint" style={{ fontSize: 12, whiteSpace: 'nowrap', overflow: 'hidden', textOverflow: 'ellipsis' }}>{personName(s.from_user_id)} → {personName(s.to_user_id)}</span>
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
<div style={{ display: 'flex', alignItems: 'center', gap: 10, alignSelf: 'center' }}>
|
||||||
|
<div className="text-content" style={{ fontSize: 18, fontWeight: 600, whiteSpace: 'nowrap' }}>{fmt(s.amount)}</div>
|
||||||
|
{canEdit && (
|
||||||
|
<div className="exp-actions" style={{ display: 'flex', flexDirection: 'column', gap: 6, flexShrink: 0 }}>
|
||||||
|
<button title={t('common.edit')} onClick={() => setEditingSettlement(s)} className="bg-surface-secondary border border-edge text-content-muted" style={{ display: 'inline-flex', alignItems: 'center', justifyContent: 'center', width: 28, height: 28, borderRadius: 999, cursor: 'pointer' }}><Pencil size={13} /></button>
|
||||||
|
<button title={t('costs.undo')} onClick={() => undoSettlement(s.id)} className="bg-surface-secondary border border-edge" style={{ display: 'inline-flex', alignItems: 'center', justifyContent: 'center', width: 28, height: 28, borderRadius: 999, cursor: 'pointer', color: '#dc2626' }}><RotateCcw size={13} /></button>
|
||||||
|
</div>
|
||||||
|
)}
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
function BalancesList({ balances }: { balances: SettlementData['balances'] }) {
|
function BalancesList({ balances }: { balances: SettlementData['balances'] }) {
|
||||||
const rows = people.map(p => balances.find(b => b.user_id === p.id) || { user_id: p.id, username: p.username, avatar_url: null, balance: 0 })
|
const rows = people.map(p => balances.find(b => b.user_id === p.id) || { user_id: p.id, username: p.username, avatar_url: null, balance: 0 })
|
||||||
const max = Math.max(1, ...rows.map(r => Math.abs(r.balance)))
|
const max = Math.max(1, ...rows.map(r => Math.abs(r.balance)))
|
||||||
@@ -562,14 +637,16 @@ export default function CostsPanel({ tripId, tripMembers = [] }: CostsPanelProps
|
|||||||
|
|
||||||
function CategoryBreakdown() {
|
function CategoryBreakdown() {
|
||||||
const tot: Record<string, number> = {}
|
const tot: Record<string, number> = {}
|
||||||
let grand = 0
|
for (const e of budgetItems) { const k = catMeta(e.category).key; tot[k] = (tot[k] || 0) + baseTotal(e) }
|
||||||
for (const e of budgetItems) { const k = catMeta(e.category).key; tot[k] = (tot[k] || 0) + baseTotal(e); grand += baseTotal(e) }
|
|
||||||
const rows = COST_CATEGORY_LIST.filter(c => (tot[c.key] || 0) > 0).sort((a, b) => (tot[b.key] || 0) - (tot[a.key] || 0))
|
const rows = COST_CATEGORY_LIST.filter(c => (tot[c.key] || 0) > 0).sort((a, b) => (tot[b.key] || 0) - (tot[a.key] || 0))
|
||||||
if (rows.length === 0) return <div className="text-content-faint" style={{ fontSize: 12.5 }}>{t('costs.noCategories')}</div>
|
if (rows.length === 0) return <div className="text-content-faint" style={{ fontSize: 12.5 }}>{t('costs.noCategories')}</div>
|
||||||
|
// Bars are scaled relative to the most expensive category (the top row fills the
|
||||||
|
// bar), not to the trip grand total — makes the relative ranking readable.
|
||||||
|
const maxCat = Math.max(0, ...rows.map(c => tot[c.key] || 0))
|
||||||
return (
|
return (
|
||||||
<div style={{ display: 'flex', flexDirection: 'column', gap: 12 }}>
|
<div style={{ display: 'flex', flexDirection: 'column', gap: 12 }}>
|
||||||
{rows.map(c => {
|
{rows.map(c => {
|
||||||
const v = tot[c.key]; const pct = grand ? v / grand * 100 : 0
|
const v = tot[c.key]; const pct = maxCat ? v / maxCat * 100 : 0
|
||||||
return (
|
return (
|
||||||
<div key={c.key} style={{ display: 'grid', gridTemplateColumns: 'auto 1fr auto', gap: 10, alignItems: 'center' }}>
|
<div key={c.key} style={{ display: 'grid', gridTemplateColumns: 'auto 1fr auto', gap: 10, alignItems: 'center' }}>
|
||||||
<span style={{ width: 10, height: 10, borderRadius: 3, background: c.color }} />
|
<span style={{ width: 10, height: 10, borderRadius: 3, background: c.color }} />
|
||||||
@@ -633,37 +710,75 @@ function FlowPills({ ids, lead, Avatar, name }: { ids: number[]; lead: string; A
|
|||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
function SettleHistory({ settlements, fmt, Avatar, name, onUndo, canEdit }: {
|
// Add or edit a settle-up payment (from / to / amount). Reachable inline from the
|
||||||
settlements: Settlement[]; fmt: (v: number) => string; Avatar: (p: { id: number; size?: number }) => React.JSX.Element; name: (id: number) => string; onUndo: (id: number) => void; canEdit: boolean
|
// ledger row and from a manual "Add payment" button, so recording "I sent money to
|
||||||
|
// X" works the same whether or not there's an outstanding expense behind it.
|
||||||
|
function SettlementModal({ tripId, people, me, editing, onClose, onSaved }: {
|
||||||
|
tripId: number; people: TripMember[]; me: number; editing: Settlement | null; onClose: () => void; onSaved: () => void
|
||||||
}) {
|
}) {
|
||||||
const { t } = useTranslation()
|
const { t } = useTranslation()
|
||||||
if (settlements.length === 0) return <div className="text-content-faint" style={{ textAlign: 'center', padding: 30, fontSize: 13 }}>{t('costs.noSettlements')}</div>
|
const toast = useToast()
|
||||||
const total = settlements.reduce((a, s) => a + s.amount, 0)
|
const otherDefault = people.find(p => p.id !== me)?.id ?? me
|
||||||
|
const [fromId, setFromId] = useState<string>(String(editing?.from_user_id ?? me))
|
||||||
|
const [toId, setToId] = useState<string>(String(editing?.to_user_id ?? otherDefault))
|
||||||
|
const [amount, setAmount] = useState<string>(editing ? String(editing.amount) : '')
|
||||||
|
const [saving, setSaving] = useState(false)
|
||||||
|
|
||||||
|
const amt = parseFloat(amount) || 0
|
||||||
|
const valid = amt > 0 && fromId !== toId
|
||||||
|
const opts = people.map(p => ({ value: String(p.id), label: p.id === me ? t('costs.you') : p.username }))
|
||||||
|
|
||||||
|
const save = async () => {
|
||||||
|
if (!valid) return
|
||||||
|
setSaving(true)
|
||||||
|
const data = { from_user_id: Number(fromId), to_user_id: Number(toId), amount: amt }
|
||||||
|
try {
|
||||||
|
if (editing) await budgetApi.updateSettlement(tripId, editing.id, data)
|
||||||
|
else await budgetApi.createSettlement(tripId, data)
|
||||||
|
onSaved()
|
||||||
|
} catch { toast.error(t('common.unknownError')) } finally { setSaving(false) }
|
||||||
|
}
|
||||||
|
|
||||||
|
const inputCls = 'w-full bg-surface-input border border-edge text-content'
|
||||||
|
const labelCls = 'block text-[11px] font-semibold uppercase tracking-[0.08em] text-content-faint mb-[6px]'
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<div>
|
<Modal isOpen onClose={onClose} title={editing ? t('costs.editPayment') : t('costs.addPayment')} size="md"
|
||||||
<div style={{ display: 'flex', justifyContent: 'space-between', padding: '12px 14px', borderRadius: 12, marginBottom: 14, background: 'rgba(22,163,74,0.1)', color: '#16a34a', fontWeight: 600, fontSize: 13 }}>
|
footer={
|
||||||
<span>{t('costs.paymentsSettled', { count: settlements.length })}</span><span>{fmt(total)}</span>
|
<div style={{ display: 'flex', justifyContent: 'flex-end', gap: 8 }}>
|
||||||
|
<button onClick={onClose} className="text-content-muted border border-edge" style={{ padding: '8px 16px', borderRadius: 10, background: 'none', fontSize: 13, cursor: 'pointer', fontFamily: 'inherit' }}>{t('common.cancel')}</button>
|
||||||
|
<button onClick={save} disabled={!valid || saving} className="bg-[var(--text-primary)] text-[var(--bg-primary)]" style={{ padding: '8px 20px', borderRadius: 10, border: 0, fontSize: 13, fontWeight: 600, cursor: 'pointer', fontFamily: 'inherit', opacity: !valid || saving ? 0.5 : 1 }}>{editing ? t('common.save') : t('costs.addPayment')}</button>
|
||||||
|
</div>
|
||||||
|
}>
|
||||||
|
<div style={{ display: 'flex', flexDirection: 'column', gap: 14 }}>
|
||||||
|
<div>
|
||||||
|
<label className={labelCls}>{t('costs.from')}</label>
|
||||||
|
<CustomSelect value={fromId} onChange={v => setFromId(String(v))} options={opts} style={{ width: '100%' }} />
|
||||||
|
</div>
|
||||||
|
<div>
|
||||||
|
<label className={labelCls}>{t('costs.to')}</label>
|
||||||
|
<CustomSelect value={toId} onChange={v => setToId(String(v))} options={opts} style={{ width: '100%' }} />
|
||||||
|
</div>
|
||||||
|
<div>
|
||||||
|
<label className={labelCls}>{t('costs.amount')}</label>
|
||||||
|
<input type="text" inputMode="decimal" placeholder="0.00" value={amount}
|
||||||
|
onChange={e => setAmount(e.target.value.replace(',', '.'))} className={inputCls} style={{ borderRadius: 10, padding: '11px 13px', fontSize: 14, outline: 'none', fontWeight: 600 }} />
|
||||||
|
</div>
|
||||||
</div>
|
</div>
|
||||||
<div style={{ display: 'flex', flexDirection: 'column', gap: 10 }}>
|
</Modal>
|
||||||
{settlements.map(s => (
|
|
||||||
<div key={s.id} className="bg-surface-secondary border border-edge" style={{ display: 'flex', alignItems: 'center', justifyContent: 'space-between', gap: 12, padding: '12px 14px', borderRadius: 12 }}>
|
|
||||||
<div style={{ display: 'flex', alignItems: 'center', gap: 8, minWidth: 0 }} title={`${name(s.from_user_id)} → ${name(s.to_user_id)}`}>
|
|
||||||
<Avatar id={s.from_user_id} size={30} /><ArrowRight size={15} className="text-content-faint" /><Avatar id={s.to_user_id} size={30} />
|
|
||||||
</div>
|
|
||||||
<div style={{ display: 'flex', alignItems: 'center', gap: 10 }}>
|
|
||||||
<span className="text-content" style={{ fontSize: 14, fontWeight: 600 }}>{fmt(s.amount)}</span>
|
|
||||||
{canEdit && <button onClick={() => onUndo(s.id)} className="bg-surface-card border border-edge text-content-muted" style={{ display: 'inline-flex', alignItems: 'center', gap: 5, padding: '6px 10px', borderRadius: 8, fontSize: 12, fontWeight: 600, cursor: 'pointer', fontFamily: 'inherit' }}><RotateCcw size={12} /> {t('costs.undo')}</button>}
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
))}
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
// ── Add / edit expense modal ───────────────────────────────────────────────
|
// ── Add / edit expense modal ───────────────────────────────────────────────
|
||||||
function ExpenseModal({ tripId, base, people, me, editing, onClose, onSaved }: {
|
export interface ExpensePrefill {
|
||||||
tripId: number; base: string; people: TripMember[]; me: number; editing: BudgetItem | null; onClose: () => void; onSaved: () => void
|
name?: string
|
||||||
|
category?: string
|
||||||
|
amount?: number
|
||||||
|
reservationId?: number
|
||||||
|
}
|
||||||
|
|
||||||
|
export function ExpenseModal({ tripId, base, people, me, editing, prefill, onClose, onSaved }: {
|
||||||
|
tripId: number; base: string; people: TripMember[]; me: number; editing: BudgetItem | null; prefill?: ExpensePrefill; onClose: () => void; onSaved: () => void
|
||||||
}) {
|
}) {
|
||||||
const { t, locale } = useTranslation()
|
const { t, locale } = useTranslation()
|
||||||
const toast = useToast()
|
const toast = useToast()
|
||||||
@@ -671,34 +786,99 @@ function ExpenseModal({ tripId, base, people, me, editing, onClose, onSaved }: {
|
|||||||
const { convert } = useExchangeRates(base)
|
const { convert } = useExchangeRates(base)
|
||||||
const sym = (c: string) => SYMBOLS[c] || (c + ' ')
|
const sym = (c: string) => SYMBOLS[c] || (c + ' ')
|
||||||
|
|
||||||
const [name, setName] = useState(editing?.name || '')
|
const [name, setName] = useState(editing?.name || prefill?.name || '')
|
||||||
const [cat, setCat] = useState<string>(editing ? catMeta(editing.category).key : 'food')
|
const [cat, setCat] = useState<string>(editing ? catMeta(editing.category).key : (prefill?.category || 'food'))
|
||||||
const [currency, setCurrency] = useState((editing?.currency || base).toUpperCase())
|
const [currency, setCurrency] = useState((editing?.currency || base).toUpperCase())
|
||||||
const [day, setDay] = useState(editing?.expense_date || new Date().toISOString().slice(0, 10))
|
const [day, setDay] = useState(editing?.expense_date || new Date().toISOString().slice(0, 10))
|
||||||
const [payers, setPayers] = useState<Record<number, string>>(() => {
|
// One participant list: a person is "in" the split and may have paid an amount.
|
||||||
|
// Entering the total auto-distributes it equally across the non-pinned participants;
|
||||||
|
// touching an amount pins it and the rest rebalance so the paid amounts always sum
|
||||||
|
// back to the total. Leaving every amount blank = an unfinished expense (counts
|
||||||
|
// toward the trip total only, never settlements, until who-paid is filled in).
|
||||||
|
const [total, setTotal] = useState<string>(() => {
|
||||||
|
if (editing) return editing.total_price ? String(editing.total_price) : ''
|
||||||
|
if (prefill?.amount != null) return String(prefill.amount)
|
||||||
|
return ''
|
||||||
|
})
|
||||||
|
const [participants, setParticipants] = useState<Set<number>>(() =>
|
||||||
|
editing ? new Set((editing.members || []).map(m => m.user_id)) : new Set(people.map(p => p.id)))
|
||||||
|
const [paid, setPaid] = useState<Record<number, string>>(() => {
|
||||||
const m: Record<number, string> = {}
|
const m: Record<number, string> = {}
|
||||||
for (const p of editing?.payers || []) m[p.user_id] = String(p.amount)
|
for (const p of editing?.payers || []) if (p.amount > 0) m[p.user_id] = String(p.amount)
|
||||||
return m
|
return m
|
||||||
})
|
})
|
||||||
const [split, setSplit] = useState<Set<number>>(() =>
|
// Amounts the user pinned by typing — kept out of the auto-rebalance. Existing
|
||||||
editing ? new Set((editing.members || []).map(m => m.user_id)) : new Set(people.map(p => p.id)))
|
// payer amounts load as pinned so opening an expense never reshuffles them.
|
||||||
|
const [dirty, setDirty] = useState<Set<number>>(() =>
|
||||||
|
new Set((editing?.payers || []).filter(p => p.amount > 0).map(p => p.user_id)))
|
||||||
const [saving, setSaving] = useState(false)
|
const [saving, setSaving] = useState(false)
|
||||||
|
|
||||||
const payersTotal = Object.values(payers).reduce((a, v) => a + (parseFloat(v) || 0), 0)
|
const totalNum = parseFloat(total) || 0
|
||||||
const each = split.size > 0 ? payersTotal / split.size : 0
|
const paidSum = round2([...participants].reduce((a, id) => a + (parseFloat(paid[id]) || 0), 0))
|
||||||
const valid = name.trim().length > 0 && split.size > 0 && payersTotal > 0
|
const paidEntered = paidSum > 0
|
||||||
|
const balanced = Math.abs(paidSum - totalNum) < 0.01
|
||||||
|
const each = participants.size > 0 ? totalNum / participants.size : 0
|
||||||
|
// No participants = a recorded total with nobody to split with (e.g. a booking
|
||||||
|
// paid on-site later). It saves as an "unfinished" expense (#1286); selecting
|
||||||
|
// people only adds the who-owes-whom split on top.
|
||||||
|
const valid = name.trim().length > 0 && totalNum > 0 && (!paidEntered || balanced)
|
||||||
|
|
||||||
|
// Spread `amount` across `n` people in whole cents so the parts sum back exactly.
|
||||||
|
const splitCents = (amount: number, n: number): number[] => {
|
||||||
|
if (n <= 0) return []
|
||||||
|
const cents = Math.max(0, Math.round(amount * 100))
|
||||||
|
const base = Math.floor(cents / n), rem = cents - base * n
|
||||||
|
return Array.from({ length: n }, (_, i) => (base + (i < rem ? 1 : 0)) / 100)
|
||||||
|
}
|
||||||
|
// Recompute the non-pinned participants so every paid amount sums to the total.
|
||||||
|
const rebalance = (paidMap: Record<number, string>, dirtySet: Set<number>, parts: Set<number>, totalVal: number): Record<number, string> => {
|
||||||
|
const ids = [...parts]
|
||||||
|
const free = ids.filter(id => !dirtySet.has(id))
|
||||||
|
if (free.length === 0) return paidMap
|
||||||
|
const pinnedSum = ids.filter(id => dirtySet.has(id)).reduce((a, id) => a + (parseFloat(paidMap[id]) || 0), 0)
|
||||||
|
const shares = splitCents(totalVal - pinnedSum, free.length)
|
||||||
|
const next = { ...paidMap }
|
||||||
|
free.forEach((id, i) => { next[id] = shares[i] ? String(shares[i]) : '' })
|
||||||
|
return next
|
||||||
|
}
|
||||||
|
|
||||||
|
const onTotalChange = (v: string) => {
|
||||||
|
v = v.replace(',', '.')
|
||||||
|
setTotal(v)
|
||||||
|
setPaid(prev => rebalance(prev, dirty, participants, parseFloat(v) || 0))
|
||||||
|
}
|
||||||
|
const onPaidChange = (id: number, v: string) => {
|
||||||
|
v = v.replace(',', '.')
|
||||||
|
const nextDirty = new Set(dirty); nextDirty.add(id)
|
||||||
|
setDirty(nextDirty)
|
||||||
|
setPaid(prev => rebalance({ ...prev, [id]: v }, nextDirty, participants, totalNum))
|
||||||
|
}
|
||||||
|
const toggleParticipant = (id: number) => {
|
||||||
|
const nextParts = new Set(participants), nextDirty = new Set(dirty), nextPaid = { ...paid }
|
||||||
|
if (nextParts.has(id)) { nextParts.delete(id); nextDirty.delete(id); delete nextPaid[id] }
|
||||||
|
else nextParts.add(id)
|
||||||
|
setParticipants(nextParts); setDirty(nextDirty)
|
||||||
|
setPaid(rebalance(nextPaid, nextDirty, nextParts, totalNum))
|
||||||
|
}
|
||||||
|
|
||||||
const save = async () => {
|
const save = async () => {
|
||||||
if (!valid) return
|
if (!valid) return
|
||||||
setSaving(true)
|
setSaving(true)
|
||||||
const payerList = Object.entries(payers).map(([uid, v]) => ({ user_id: Number(uid), amount: parseFloat(v) || 0 })).filter(p => p.amount > 0)
|
const payerList = [...participants]
|
||||||
|
.map(id => ({ user_id: id, amount: parseFloat(paid[id]) || 0 }))
|
||||||
|
.filter(p => p.amount > 0)
|
||||||
const data = {
|
const data = {
|
||||||
name: name.trim(), category: cat,
|
name: name.trim(), category: cat,
|
||||||
// Store the actual currency the amounts were entered in; conversion to the
|
// Store the actual currency the amounts were entered in; conversion to the
|
||||||
// viewer's display currency happens live (real rates), no manual rate.
|
// viewer's display currency happens live (real rates), no manual rate.
|
||||||
currency,
|
currency,
|
||||||
payers: payerList, member_ids: [...split],
|
payers: payerList, member_ids: [...participants],
|
||||||
expense_date: day || null,
|
expense_date: day || null,
|
||||||
|
// Always record the entered total: the server keeps it as-is for an unfinished
|
||||||
|
// expense (no payers) and otherwise re-derives it from the payer sum (== total).
|
||||||
|
total_price: totalNum,
|
||||||
|
// Link a freshly-created expense to its booking (create-from-booking flow).
|
||||||
|
...(!editing && prefill?.reservationId ? { reservation_id: prefill.reservationId } : {}),
|
||||||
}
|
}
|
||||||
try {
|
try {
|
||||||
if (editing) await updateBudgetItem(tripId, editing.id, data)
|
if (editing) await updateBudgetItem(tripId, editing.id, data)
|
||||||
@@ -728,7 +908,9 @@ function ExpenseModal({ tripId, base, people, me, editing, onClose, onSaved }: {
|
|||||||
<label className={labelCls}>{t('costs.totalAmount')}</label>
|
<label className={labelCls}>{t('costs.totalAmount')}</label>
|
||||||
<div className="bg-surface-input border border-edge" style={{ height: FIELD_H, boxSizing: 'border-box', display: 'flex', alignItems: 'center', borderRadius: 10, padding: '0 12px' }}>
|
<div className="bg-surface-input border border-edge" style={{ height: FIELD_H, boxSizing: 'border-box', display: 'flex', alignItems: 'center', borderRadius: 10, padding: '0 12px' }}>
|
||||||
<span className="text-content-faint" style={{ fontSize: 15 }}>{sym(currency)}</span>
|
<span className="text-content-faint" style={{ fontSize: 15 }}>{sym(currency)}</span>
|
||||||
<span className="text-content" style={{ flex: 1, fontSize: 15, fontWeight: 600, paddingLeft: 6 }}>{payersTotal.toFixed(2)}</span>
|
<input type="text" inputMode="decimal" placeholder="0.00" value={total}
|
||||||
|
onChange={e => onTotalChange(e.target.value)}
|
||||||
|
className="text-content" style={{ flex: 1, border: 0, background: 'none', outline: 'none', fontSize: 15, fontWeight: 600, paddingLeft: 6, width: '100%' }} />
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
<div style={{ display: 'grid', gridTemplateColumns: '1fr 1fr', gap: 10 }}>
|
<div style={{ display: 'grid', gridTemplateColumns: '1fr 1fr', gap: 10 }}>
|
||||||
@@ -744,11 +926,11 @@ function ExpenseModal({ tripId, base, people, me, editing, onClose, onSaved }: {
|
|||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
{currency !== base && payersTotal > 0 && (
|
{currency !== base && totalNum > 0 && (
|
||||||
<div className="bg-surface-secondary border border-edge text-content-muted" style={{ borderRadius: 10, padding: '10px 12px', fontSize: 12.5, display: 'flex', alignItems: 'center', gap: 8, flexWrap: 'wrap' }}>
|
<div className="bg-surface-secondary border border-edge text-content-muted" style={{ borderRadius: 10, padding: '10px 12px', fontSize: 12.5, display: 'flex', alignItems: 'center', gap: 8, flexWrap: 'wrap' }}>
|
||||||
<span>{formatMoney(payersTotal, currency, locale)}</span>
|
<span>{formatMoney(totalNum, currency, locale)}</span>
|
||||||
<span className="text-content-faint">≈</span>
|
<span className="text-content-faint">≈</span>
|
||||||
<span className="text-content" style={{ fontWeight: 600 }}>{formatMoney(convert(payersTotal, currency), base, locale)}</span>
|
<span className="text-content" style={{ fontWeight: 600 }}>{formatMoney(convert(totalNum, currency), base, locale)}</span>
|
||||||
<span className="text-content-faint">· {t('costs.liveRate')}</span>
|
<span className="text-content-faint">· {t('costs.liveRate')}</span>
|
||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
@@ -773,39 +955,37 @@ function ExpenseModal({ tripId, base, people, me, editing, onClose, onSaved }: {
|
|||||||
<div>
|
<div>
|
||||||
<label className={labelCls}>{t('costs.whoPaid')}</label>
|
<label className={labelCls}>{t('costs.whoPaid')}</label>
|
||||||
<div style={{ display: 'flex', flexDirection: 'column', gap: 7 }}>
|
<div style={{ display: 'flex', flexDirection: 'column', gap: 7 }}>
|
||||||
{people.map(p => (
|
{people.map((p, idx) => {
|
||||||
<div key={p.id} className="bg-surface-secondary border border-edge" style={{ display: 'grid', gridTemplateColumns: '1fr 130px', gap: 10, alignItems: 'center', padding: '8px 11px', borderRadius: 10 }}>
|
const on = participants.has(p.id)
|
||||||
<span className="text-content" style={{ fontSize: 14, fontWeight: 500 }}>{p.id === me ? t('costs.you') : p.username}</span>
|
|
||||||
<div className="bg-surface-input border border-edge" style={{ display: 'flex', alignItems: 'center', gap: 4, borderRadius: 8, padding: '0 10px' }}>
|
|
||||||
<span className="text-content-faint" style={{ fontSize: 13 }}>{sym(currency)}</span>
|
|
||||||
<input type="number" inputMode="decimal" min="0" step="0.01" placeholder="0.00" value={payers[p.id] || ''}
|
|
||||||
onChange={e => setPayers(prev => ({ ...prev, [p.id]: e.target.value }))}
|
|
||||||
className="text-content" style={{ width: '100%', border: 0, background: 'none', outline: 'none', fontSize: 14, fontWeight: 600, padding: '8px 0', textAlign: 'right' }} />
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
))}
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
|
|
||||||
<div>
|
|
||||||
<label className={labelCls}>{t('costs.splitBetween')}</label>
|
|
||||||
<div style={{ display: 'flex', flexWrap: 'wrap', gap: 7 }}>
|
|
||||||
{people.map(p => {
|
|
||||||
const on = split.has(p.id)
|
|
||||||
return (
|
return (
|
||||||
<button key={p.id} onClick={() => setSplit(prev => { const n = new Set(prev); n.has(p.id) ? n.delete(p.id) : n.add(p.id); return n })}
|
<div key={p.id} className="bg-surface-secondary border border-edge" style={{ display: 'grid', gridTemplateColumns: '1fr 130px', gap: 10, alignItems: 'center', padding: '8px 11px', borderRadius: 10, opacity: on ? 1 : 0.5 }}>
|
||||||
className={on ? 'bg-surface-card text-content border' : 'bg-surface-secondary text-content-faint border border-edge'}
|
<button onClick={() => toggleParticipant(p.id)} style={{ display: 'inline-flex', alignItems: 'center', gap: 8, background: 'none', border: 0, cursor: 'pointer', fontFamily: 'inherit', padding: 0, minWidth: 0, textAlign: 'left' }}>
|
||||||
style={{ display: 'inline-flex', alignItems: 'center', gap: 7, padding: '6px 13px 6px 7px', borderRadius: 999, fontSize: 13, fontWeight: 500, cursor: 'pointer', fontFamily: 'inherit', borderColor: on ? 'var(--text-primary)' : undefined }}>
|
{p.avatar_url
|
||||||
{p.avatar_url
|
? <img src={p.avatar_url} alt="" style={{ width: 22, height: 22, borderRadius: '50%', objectFit: 'cover', display: 'block', flexShrink: 0, opacity: on ? 1 : 0.45 }} />
|
||||||
? <img src={p.avatar_url} alt="" style={{ width: 22, height: 22, borderRadius: '50%', objectFit: 'cover', display: 'block', opacity: on ? 1 : 0.45 }} />
|
: <span style={{ width: 22, height: 22, borderRadius: '50%', background: SPLIT_COLORS[idx % SPLIT_COLORS.length].gradient, color: '#fff', display: 'grid', placeItems: 'center', fontSize: 9, fontWeight: 700, flexShrink: 0, opacity: on ? 1 : 0.45 }}>{(p.id === me ? t('costs.youShort') : p.username.charAt(0)).toUpperCase()}</span>}
|
||||||
: <span style={{ width: 22, height: 22, borderRadius: '50%', background: SPLIT_COLORS[people.findIndex(x => x.id === p.id) % SPLIT_COLORS.length].gradient, color: '#fff', display: 'grid', placeItems: 'center', fontSize: 9, fontWeight: 700, opacity: on ? 1 : 0.45 }}>{(p.id === me ? t('costs.youShort') : p.username.charAt(0)).toUpperCase()}</span>}
|
<span className="text-content" style={{ fontSize: 14, fontWeight: 500, overflow: 'hidden', textOverflow: 'ellipsis', whiteSpace: 'nowrap' }}>{p.id === me ? t('costs.you') : p.username}</span>
|
||||||
{p.id === me ? t('costs.you') : p.username}
|
</button>
|
||||||
</button>
|
{on ? (
|
||||||
|
<div className="bg-surface-input border border-edge" style={{ display: 'flex', alignItems: 'center', gap: 4, borderRadius: 8, padding: '0 10px' }}>
|
||||||
|
<span className="text-content-faint" style={{ fontSize: 13 }}>{sym(currency)}</span>
|
||||||
|
<input type="text" inputMode="decimal" placeholder="0.00" value={paid[p.id] || ''}
|
||||||
|
onChange={e => onPaidChange(p.id, e.target.value)}
|
||||||
|
className="text-content" style={{ width: '100%', border: 0, background: 'none', outline: 'none', fontSize: 14, fontWeight: 600, padding: '8px 0', textAlign: 'right' }} />
|
||||||
|
</div>
|
||||||
|
) : (
|
||||||
|
<button onClick={() => toggleParticipant(p.id)} className="text-content-faint" style={{ background: 'none', border: 0, cursor: 'pointer', fontFamily: 'inherit', fontSize: 12, textAlign: 'right' }}>{t('costs.tapToInclude')}</button>
|
||||||
|
)}
|
||||||
|
</div>
|
||||||
)
|
)
|
||||||
})}
|
})}
|
||||||
</div>
|
</div>
|
||||||
<div className="text-content-faint" style={{ marginTop: 10, fontSize: 12.5 }}>
|
<div style={{ marginTop: 10, fontSize: 12.5, display: 'flex', justifyContent: 'space-between', gap: 10, flexWrap: 'wrap' }}>
|
||||||
{split.size === 0 ? t('costs.pickSomeone') : t('costs.splitSummary', { count: split.size, amount: sym(currency) + each.toFixed(2) })}
|
<span className="text-content-faint">
|
||||||
|
{participants.size > 0 && t('costs.splitSummary', { count: participants.size, amount: sym(currency) + each.toFixed(2) })}
|
||||||
|
</span>
|
||||||
|
{paidEntered
|
||||||
|
? <span style={{ fontWeight: 600, color: balanced ? '#16a34a' : '#dc2626' }}>{sym(currency)}{paidSum.toFixed(2)} / {sym(currency)}{totalNum.toFixed(2)}</span>
|
||||||
|
: (totalNum > 0 && <span style={{ color: '#d97706', fontWeight: 600 }}>{t('costs.unfinishedHint')}</span>)}
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
|
|||||||
@@ -32,8 +32,32 @@ export const COST_CAT_META: Record<CostCategory, CostCategoryMeta> = {
|
|||||||
|
|
||||||
export const COST_CATEGORY_LIST: CostCategoryMeta[] = COST_CATEGORIES.map(k => COST_CAT_META[k])
|
export const COST_CATEGORY_LIST: CostCategoryMeta[] = COST_CATEGORIES.map(k => COST_CAT_META[k])
|
||||||
|
|
||||||
/** Map any stored category (incl. legacy free-text values) to a known meta. */
|
/**
|
||||||
export function catMeta(cat: string | null | undefined): CostCategoryMeta {
|
* Legacy / English free-text categories (and reservation type labels) mapped to
|
||||||
if (cat && cat in COST_CAT_META) return COST_CAT_META[cat as CostCategory]
|
* the fixed keys. Bookings used to store labels like "Flight"/"Train"/"Other",
|
||||||
return COST_CAT_META.other
|
* which never matched the lowercase keys and fell through to `other`.
|
||||||
|
*/
|
||||||
|
const LEGACY_CATEGORY_MAP: Record<string, CostCategory> = {
|
||||||
|
flight: 'flights', flights: 'flights', plane: 'flights', flug: 'flights',
|
||||||
|
train: 'transport', bus: 'transport', car: 'transport', 'car rental': 'transport',
|
||||||
|
ferry: 'transport', boat: 'transport', taxi: 'transport', transfer: 'transport',
|
||||||
|
transport: 'transport', transportation: 'transport',
|
||||||
|
hotel: 'accommodation', accommodation: 'accommodation', lodging: 'accommodation', hostel: 'accommodation',
|
||||||
|
restaurant: 'food', food: 'food', dining: 'food', meal: 'food', meals: 'food',
|
||||||
|
grocery: 'groceries', groceries: 'groceries',
|
||||||
|
activity: 'activities', activities: 'activities',
|
||||||
|
sightseeing: 'sightseeing', sights: 'sightseeing',
|
||||||
|
shop: 'shopping', shopping: 'shopping',
|
||||||
|
fee: 'fees', fees: 'fees',
|
||||||
|
health: 'health', medical: 'health',
|
||||||
|
tip: 'tips', tips: 'tips',
|
||||||
|
other: 'other', misc: 'other',
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Map any stored category (incl. legacy/localized free-text values) to a known meta. */
|
||||||
|
export function catMeta(cat: string | null | undefined): CostCategoryMeta {
|
||||||
|
if (!cat) return COST_CAT_META.other
|
||||||
|
if (cat in COST_CAT_META) return COST_CAT_META[cat as CostCategory]
|
||||||
|
const mapped = LEGACY_CATEGORY_MAP[cat.trim().toLowerCase()]
|
||||||
|
return mapped ? COST_CAT_META[mapped] : COST_CAT_META.other
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,7 +1,11 @@
|
|||||||
import { forwardRef, useImperativeHandle, useRef } from 'react'
|
import { forwardRef, lazy, Suspense, useImperativeHandle, useRef } from 'react'
|
||||||
import { useSettingsStore } from '../../store/settingsStore'
|
import { useSettingsStore } from '../../store/settingsStore'
|
||||||
import JourneyMap, { type JourneyMapHandle } from './JourneyMap'
|
import JourneyMap, { type JourneyMapHandle } from './JourneyMap'
|
||||||
import JourneyMapGL, { type JourneyMapGLHandle } from './JourneyMapGL'
|
import type { JourneyMapGLHandle } from './JourneyMapGL'
|
||||||
|
|
||||||
|
// Lazy-load the GL renderer (and its ~230 KB gzip engine) so Leaflet-only
|
||||||
|
// installs never download it — it ships only once a GL provider is picked.
|
||||||
|
const JourneyMapGL = lazy(() => import('./JourneyMapGL'))
|
||||||
|
|
||||||
// Unified handle — both providers expose the same three methods.
|
// Unified handle — both providers expose the same three methods.
|
||||||
export type JourneyMapAutoHandle = JourneyMapHandle
|
export type JourneyMapAutoHandle = JourneyMapHandle
|
||||||
@@ -37,8 +41,9 @@ const JourneyMapAuto = forwardRef<JourneyMapAutoHandle, Props>(function JourneyM
|
|||||||
const glRef = useRef<JourneyMapGLHandle>(null)
|
const glRef = useRef<JourneyMapGLHandle>(null)
|
||||||
|
|
||||||
// Fall back to Leaflet when the user selected Mapbox GL but hasn't
|
// Fall back to Leaflet when the user selected Mapbox GL but hasn't
|
||||||
// supplied a token yet — otherwise the map would just show a stub.
|
// supplied a token yet. MapLibre/OpenFreeMap is tokenless.
|
||||||
const useGL = provider === 'mapbox-gl' && !!token
|
const useGL = provider === 'maplibre-gl' || (provider === 'mapbox-gl' && !!token)
|
||||||
|
const glProvider = provider === 'maplibre-gl' ? 'maplibre-gl' : 'mapbox-gl'
|
||||||
|
|
||||||
useImperativeHandle(ref, () => ({
|
useImperativeHandle(ref, () => ({
|
||||||
highlightMarker: (id) => (useGL ? glRef.current : leafletRef.current)?.highlightMarker(id),
|
highlightMarker: (id) => (useGL ? glRef.current : leafletRef.current)?.highlightMarker(id),
|
||||||
@@ -47,8 +52,12 @@ const JourneyMapAuto = forwardRef<JourneyMapAutoHandle, Props>(function JourneyM
|
|||||||
}), [useGL])
|
}), [useGL])
|
||||||
|
|
||||||
if (useGL) {
|
if (useGL) {
|
||||||
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
return (
|
||||||
return <JourneyMapGL ref={glRef} {...(props as any)} />
|
<Suspense fallback={null}>
|
||||||
|
{/* eslint-disable-next-line @typescript-eslint/no-explicit-any */}
|
||||||
|
<JourneyMapGL ref={glRef} {...(props as any)} glProvider={glProvider} />
|
||||||
|
</Suspense>
|
||||||
|
)
|
||||||
}
|
}
|
||||||
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
||||||
return <JourneyMap ref={leafletRef} {...(props as any)} />
|
return <JourneyMap ref={leafletRef} {...(props as any)} />
|
||||||
|
|||||||
@@ -1,8 +1,11 @@
|
|||||||
import { useEffect, useRef, useImperativeHandle, forwardRef, useCallback } from 'react'
|
import { useEffect, useRef, useImperativeHandle, forwardRef, useCallback } from 'react'
|
||||||
import mapboxgl from 'mapbox-gl'
|
import mapboxgl from 'mapbox-gl'
|
||||||
|
import maplibregl from 'maplibre-gl'
|
||||||
import 'mapbox-gl/dist/mapbox-gl.css'
|
import 'mapbox-gl/dist/mapbox-gl.css'
|
||||||
|
import 'maplibre-gl/dist/maplibre-gl.css'
|
||||||
import { useSettingsStore } from '../../store/settingsStore'
|
import { useSettingsStore } from '../../store/settingsStore'
|
||||||
import { isStandardFamily, supportsCustom3d, wantsTerrain, addCustom3dBuildings, addTerrainAndSky } from '../Map/mapboxSetup'
|
import { isStandardFamily, supportsCustom3d, wantsTerrain, addCustom3dBuildings, addTerrainAndSky } from '../Map/mapboxSetup'
|
||||||
|
import { MAPBOX_DEFAULT_STYLE, styleForActiveProvider, basemapLanguage, type GlMapProvider } from '../Map/glProviders'
|
||||||
|
|
||||||
export interface JourneyMapGLHandle {
|
export interface JourneyMapGLHandle {
|
||||||
highlightMarker: (id: string | null) => void
|
highlightMarker: (id: string | null) => void
|
||||||
@@ -32,6 +35,7 @@ interface Props {
|
|||||||
onMarkerClick?: (id: string, type?: string) => void
|
onMarkerClick?: (id: string, type?: string) => void
|
||||||
fullScreen?: boolean
|
fullScreen?: boolean
|
||||||
paddingBottom?: number
|
paddingBottom?: number
|
||||||
|
glProvider?: GlMapProvider
|
||||||
}
|
}
|
||||||
|
|
||||||
interface Item {
|
interface Item {
|
||||||
@@ -95,8 +99,10 @@ function ensureJourneyPopupStyle() {
|
|||||||
const s = document.createElement('style')
|
const s = document.createElement('style')
|
||||||
s.id = 'trek-journey-popup-style'
|
s.id = 'trek-journey-popup-style'
|
||||||
s.textContent = `
|
s.textContent = `
|
||||||
.mapboxgl-popup.trek-journey-popup { pointer-events: none; animation: trek-journey-popup-in 180ms ease-out; }
|
.mapboxgl-popup.trek-journey-popup,
|
||||||
.mapboxgl-popup.trek-journey-popup .mapboxgl-popup-content {
|
.maplibregl-popup.trek-journey-popup { pointer-events: none; animation: trek-journey-popup-in 180ms ease-out; }
|
||||||
|
.mapboxgl-popup.trek-journey-popup .mapboxgl-popup-content,
|
||||||
|
.maplibregl-popup.trek-journey-popup .maplibregl-popup-content {
|
||||||
padding: 9px 14px 10px;
|
padding: 9px 14px 10px;
|
||||||
border-radius: 14px;
|
border-radius: 14px;
|
||||||
background: rgba(255, 255, 255, 0.94);
|
background: rgba(255, 255, 255, 0.94);
|
||||||
@@ -108,20 +114,24 @@ function ensureJourneyPopupStyle() {
|
|||||||
min-width: 160px;
|
min-width: 160px;
|
||||||
max-width: 280px;
|
max-width: 280px;
|
||||||
}
|
}
|
||||||
.mapboxgl-popup.trek-journey-popup.trek-dark .mapboxgl-popup-content {
|
.mapboxgl-popup.trek-journey-popup.trek-dark .mapboxgl-popup-content,
|
||||||
|
.maplibregl-popup.trek-journey-popup.trek-dark .maplibregl-popup-content {
|
||||||
background: rgba(24, 24, 27, 0.88);
|
background: rgba(24, 24, 27, 0.88);
|
||||||
border-color: rgba(255, 255, 255, 0.08);
|
border-color: rgba(255, 255, 255, 0.08);
|
||||||
color: #FAFAFA;
|
color: #FAFAFA;
|
||||||
}
|
}
|
||||||
.mapboxgl-popup.trek-journey-popup .mapboxgl-popup-tip {
|
.mapboxgl-popup.trek-journey-popup .mapboxgl-popup-tip,
|
||||||
|
.maplibregl-popup.trek-journey-popup .maplibregl-popup-tip {
|
||||||
border-top-color: rgba(255, 255, 255, 0.94);
|
border-top-color: rgba(255, 255, 255, 0.94);
|
||||||
border-bottom-color: rgba(255, 255, 255, 0.94);
|
border-bottom-color: rgba(255, 255, 255, 0.94);
|
||||||
}
|
}
|
||||||
.mapboxgl-popup.trek-journey-popup.trek-dark .mapboxgl-popup-tip {
|
.mapboxgl-popup.trek-journey-popup.trek-dark .mapboxgl-popup-tip,
|
||||||
|
.maplibregl-popup.trek-journey-popup.trek-dark .maplibregl-popup-tip {
|
||||||
border-top-color: rgba(24, 24, 27, 0.88);
|
border-top-color: rgba(24, 24, 27, 0.88);
|
||||||
border-bottom-color: rgba(24, 24, 27, 0.88);
|
border-bottom-color: rgba(24, 24, 27, 0.88);
|
||||||
}
|
}
|
||||||
.mapboxgl-popup.trek-journey-popup .mapboxgl-popup-close-button { display: none; }
|
.mapboxgl-popup.trek-journey-popup .mapboxgl-popup-close-button,
|
||||||
|
.maplibregl-popup.trek-journey-popup .maplibregl-popup-close-button { display: none; }
|
||||||
.trek-journey-popup-title {
|
.trek-journey-popup-title {
|
||||||
font-size: 13.5px;
|
font-size: 13.5px;
|
||||||
font-weight: 600;
|
font-weight: 600;
|
||||||
@@ -132,7 +142,8 @@ function ensureJourneyPopupStyle() {
|
|||||||
overflow: hidden;
|
overflow: hidden;
|
||||||
text-overflow: ellipsis;
|
text-overflow: ellipsis;
|
||||||
}
|
}
|
||||||
.mapboxgl-popup.trek-journey-popup.trek-dark .trek-journey-popup-title { color: #FAFAFA; }
|
.mapboxgl-popup.trek-journey-popup.trek-dark .trek-journey-popup-title,
|
||||||
|
.maplibregl-popup.trek-journey-popup.trek-dark .trek-journey-popup-title { color: #FAFAFA; }
|
||||||
.trek-journey-popup-sub {
|
.trek-journey-popup-sub {
|
||||||
display: flex;
|
display: flex;
|
||||||
align-items: baseline;
|
align-items: baseline;
|
||||||
@@ -143,7 +154,8 @@ function ensureJourneyPopupStyle() {
|
|||||||
line-height: 1.35;
|
line-height: 1.35;
|
||||||
white-space: nowrap;
|
white-space: nowrap;
|
||||||
}
|
}
|
||||||
.mapboxgl-popup.trek-journey-popup.trek-dark .trek-journey-popup-sub { color: #A1A1AA; }
|
.mapboxgl-popup.trek-journey-popup.trek-dark .trek-journey-popup-sub,
|
||||||
|
.maplibregl-popup.trek-journey-popup.trek-dark .trek-journey-popup-sub { color: #A1A1AA; }
|
||||||
.trek-journey-popup-place {
|
.trek-journey-popup-place {
|
||||||
min-width: 0;
|
min-width: 0;
|
||||||
overflow: hidden;
|
overflow: hidden;
|
||||||
@@ -194,20 +206,29 @@ function markerHtml(dayColor: string, dayLabel: number, highlighted: boolean): H
|
|||||||
const EMPTY_TRAIL: { lat: number; lng: number }[] = []
|
const EMPTY_TRAIL: { lat: number; lng: number }[] = []
|
||||||
|
|
||||||
const JourneyMapGL = forwardRef<JourneyMapGLHandle, Props>(function JourneyMapGL(
|
const JourneyMapGL = forwardRef<JourneyMapGLHandle, Props>(function JourneyMapGL(
|
||||||
{ entries, trail, height = 220, dark, activeMarkerId, onMarkerClick, fullScreen, paddingBottom },
|
{ entries, trail, height = 220, dark, activeMarkerId, onMarkerClick, fullScreen, paddingBottom, glProvider = 'mapbox-gl' },
|
||||||
ref
|
ref
|
||||||
) {
|
) {
|
||||||
const stableTrail = trail || EMPTY_TRAIL
|
const stableTrail = trail || EMPTY_TRAIL
|
||||||
const mapboxStyle = useSettingsStore(s => s.settings.mapbox_style || 'mapbox://styles/mapbox/standard')
|
const rawMapboxStyle = useSettingsStore(s => s.settings.mapbox_style || MAPBOX_DEFAULT_STYLE)
|
||||||
|
const rawMaplibreStyle = useSettingsStore(s => s.settings.maplibre_style || '')
|
||||||
const mapboxToken = useSettingsStore(s => s.settings.mapbox_access_token || '')
|
const mapboxToken = useSettingsStore(s => s.settings.mapbox_access_token || '')
|
||||||
const mapbox3d = useSettingsStore(s => s.settings.mapbox_3d_enabled !== false)
|
const mapbox3d = useSettingsStore(s => s.settings.mapbox_3d_enabled !== false)
|
||||||
const mapboxQuality = useSettingsStore(s => s.settings.mapbox_quality_mode === true)
|
const mapboxQuality = useSettingsStore(s => s.settings.mapbox_quality_mode === true)
|
||||||
|
const mapLang = useSettingsStore(s => s.settings.language)
|
||||||
|
const isMapLibre = glProvider === 'maplibre-gl'
|
||||||
|
const gl = (isMapLibre ? maplibregl : mapboxgl) as any
|
||||||
|
const glStyle = styleForActiveProvider(glProvider, rawMapboxStyle, rawMaplibreStyle)
|
||||||
|
const enableMapbox3d = !isMapLibre && mapbox3d
|
||||||
const containerRef = useRef<HTMLDivElement>(null)
|
const containerRef = useRef<HTMLDivElement>(null)
|
||||||
const mapRef = useRef<mapboxgl.Map | null>(null)
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
||||||
const markersRef = useRef<Map<string, mapboxgl.Marker>>(new Map())
|
const mapRef = useRef<any | null>(null)
|
||||||
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
||||||
|
const markersRef = useRef<Map<string, any>>(new Map())
|
||||||
const itemsRef = useRef<Item[]>([])
|
const itemsRef = useRef<Item[]>([])
|
||||||
const highlightedRef = useRef<string | null>(null)
|
const highlightedRef = useRef<string | null>(null)
|
||||||
const popupRef = useRef<mapboxgl.Popup | null>(null)
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
||||||
|
const popupRef = useRef<any | null>(null)
|
||||||
const onMarkerClickRef = useRef(onMarkerClick)
|
const onMarkerClickRef = useRef(onMarkerClick)
|
||||||
onMarkerClickRef.current = onMarkerClick
|
onMarkerClickRef.current = onMarkerClick
|
||||||
const darkRef = useRef(dark)
|
const darkRef = useRef(dark)
|
||||||
@@ -247,7 +268,7 @@ const JourneyMapGL = forwardRef<JourneyMapGLHandle, Props>(function JourneyMapGL
|
|||||||
const el = popupRef.current.getElement()
|
const el = popupRef.current.getElement()
|
||||||
if (el) el.classList.toggle('trek-dark', !!darkRef.current)
|
if (el) el.classList.toggle('trek-dark', !!darkRef.current)
|
||||||
} else {
|
} else {
|
||||||
popupRef.current = new mapboxgl.Popup({
|
popupRef.current = new gl.Popup({
|
||||||
closeButton: false,
|
closeButton: false,
|
||||||
closeOnClick: false,
|
closeOnClick: false,
|
||||||
closeOnMove: false,
|
closeOnMove: false,
|
||||||
@@ -260,7 +281,7 @@ const JourneyMapGL = forwardRef<JourneyMapGLHandle, Props>(function JourneyMapGL
|
|||||||
.setHTML(html)
|
.setHTML(html)
|
||||||
.addTo(mapRef.current)
|
.addTo(mapRef.current)
|
||||||
}
|
}
|
||||||
}, [])
|
}, [gl])
|
||||||
|
|
||||||
const hidePopup = useCallback(() => {
|
const hidePopup = useCallback(() => {
|
||||||
if (popupRef.current) {
|
if (popupRef.current) {
|
||||||
@@ -305,11 +326,11 @@ const JourneyMapGL = forwardRef<JourneyMapGLHandle, Props>(function JourneyMapGL
|
|||||||
mapRef.current.flyTo({
|
mapRef.current.flyTo({
|
||||||
center: marker.getLngLat(),
|
center: marker.getLngLat(),
|
||||||
zoom: Math.max(mapRef.current.getZoom(), 14),
|
zoom: Math.max(mapRef.current.getZoom(), 14),
|
||||||
pitch: mapbox3d ? 45 : 0,
|
pitch: enableMapbox3d ? 45 : 0,
|
||||||
duration: 600,
|
duration: 600,
|
||||||
})
|
})
|
||||||
} catch { /* map not yet ready */ }
|
} catch { /* map not yet ready */ }
|
||||||
}, [highlightMarker, mapbox3d])
|
}, [highlightMarker, enableMapbox3d])
|
||||||
|
|
||||||
const invalidateSize = useCallback(() => {
|
const invalidateSize = useCallback(() => {
|
||||||
try { mapRef.current?.resize() } catch { /* map not yet ready */ }
|
try { mapRef.current?.resize() } catch { /* map not yet ready */ }
|
||||||
@@ -320,39 +341,46 @@ const JourneyMapGL = forwardRef<JourneyMapGLHandle, Props>(function JourneyMapGL
|
|||||||
// Build map once per style/token change. Markers and layers are rebuilt
|
// Build map once per style/token change. Markers and layers are rebuilt
|
||||||
// inside the same effect so they stay in sync with the active style.
|
// inside the same effect so they stay in sync with the active style.
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
if (!containerRef.current || !mapboxToken) return
|
if (!containerRef.current || (!isMapLibre && !mapboxToken)) return
|
||||||
mapboxgl.accessToken = mapboxToken
|
if (!isMapLibre) mapboxgl.accessToken = mapboxToken
|
||||||
|
|
||||||
const items = buildItems(entries)
|
const items = buildItems(entries)
|
||||||
itemsRef.current = items
|
itemsRef.current = items
|
||||||
|
|
||||||
const bounds = new mapboxgl.LngLatBounds()
|
const bounds = new gl.LngLatBounds()
|
||||||
items.forEach(i => bounds.extend([i.lng, i.lat]))
|
items.forEach(i => bounds.extend([i.lng, i.lat]))
|
||||||
stableTrail.forEach(p => bounds.extend([p.lng, p.lat]))
|
stableTrail.forEach(p => bounds.extend([p.lng, p.lat]))
|
||||||
const hasPoints = items.length > 0 || stableTrail.length > 0
|
const hasPoints = items.length > 0 || stableTrail.length > 0
|
||||||
|
|
||||||
const map = new mapboxgl.Map({
|
const mapOptions: Record<string, unknown> = {
|
||||||
container: containerRef.current,
|
container: containerRef.current,
|
||||||
style: mapboxStyle,
|
style: glStyle,
|
||||||
center: hasPoints ? bounds.getCenter() : [0, 30],
|
center: hasPoints ? bounds.getCenter() : [0, 30],
|
||||||
zoom: hasPoints ? 2 : 1,
|
zoom: hasPoints ? 2 : 1,
|
||||||
pitch: mapbox3d && fullScreen ? 45 : 0,
|
pitch: enableMapbox3d && fullScreen ? 45 : 0,
|
||||||
attributionControl: true,
|
attributionControl: true,
|
||||||
antialias: mapboxQuality,
|
antialias: mapboxQuality,
|
||||||
projection: mapboxQuality ? 'globe' : 'mercator',
|
}
|
||||||
})
|
if (!isMapLibre) mapOptions.projection = mapboxQuality ? 'globe' : 'mercator'
|
||||||
|
|
||||||
|
const map = new gl.Map(mapOptions as any)
|
||||||
mapRef.current = map
|
mapRef.current = map
|
||||||
|
|
||||||
map.on('load', () => {
|
map.on('load', () => {
|
||||||
if (mapbox3d) {
|
if (enableMapbox3d) {
|
||||||
if (!isStandardFamily(mapboxStyle) && wantsTerrain(mapboxStyle)) addTerrainAndSky(map)
|
if (!isStandardFamily(glStyle) && wantsTerrain(glStyle)) addTerrainAndSky(map)
|
||||||
if (supportsCustom3d(mapboxStyle)) addCustom3dBuildings(map, !!darkRef.current)
|
if (supportsCustom3d(glStyle)) addCustom3dBuildings(map, !!darkRef.current)
|
||||||
}
|
}
|
||||||
// Flatten Mapbox Standard's built-in DEM so HTML markers (at Z=0)
|
// Flatten Mapbox Standard's built-in DEM so HTML markers (at Z=0)
|
||||||
// stay pinned to their coordinates at every zoom and pitch.
|
// stay pinned to their coordinates at every zoom and pitch.
|
||||||
if (mapboxStyle === 'mapbox://styles/mapbox/standard') {
|
if (glStyle === MAPBOX_DEFAULT_STYLE) {
|
||||||
try { map.setTerrain(null) } catch { /* noop */ }
|
try { map.setTerrain(null) } catch { /* noop */ }
|
||||||
}
|
}
|
||||||
|
// Pin the basemap label language to the UI language so labels don't fall back to the
|
||||||
|
// browser/OS locale and stack multiple scripts per place (#1299).
|
||||||
|
if (!isMapLibre && isStandardFamily(glStyle)) {
|
||||||
|
try { map.setConfigProperty('basemap', 'language', basemapLanguage(mapLang)) } catch { /* style/SDK may not support it */ }
|
||||||
|
}
|
||||||
|
|
||||||
// route trail — dashed line connecting entries in time order
|
// route trail — dashed line connecting entries in time order
|
||||||
if (items.length > 1) {
|
if (items.length > 1) {
|
||||||
@@ -383,7 +411,7 @@ const JourneyMapGL = forwardRef<JourneyMapGLHandle, Props>(function JourneyMapGL
|
|||||||
// markers
|
// markers
|
||||||
items.forEach((item) => {
|
items.forEach((item) => {
|
||||||
const el = markerHtml(item.dayColor, item.dayLabel, false)
|
const el = markerHtml(item.dayColor, item.dayLabel, false)
|
||||||
const marker = new mapboxgl.Marker({ element: el, anchor: 'bottom' })
|
const marker = new gl.Marker({ element: el, anchor: 'bottom' })
|
||||||
.setLngLat([item.lng, item.lat])
|
.setLngLat([item.lng, item.lat])
|
||||||
.addTo(map)
|
.addTo(map)
|
||||||
el.addEventListener('click', (ev) => {
|
el.addEventListener('click', (ev) => {
|
||||||
@@ -400,7 +428,7 @@ const JourneyMapGL = forwardRef<JourneyMapGLHandle, Props>(function JourneyMapGL
|
|||||||
map.fitBounds(bounds, {
|
map.fitBounds(bounds, {
|
||||||
padding: { top: 50, bottom: pb, left: 50, right: 50 },
|
padding: { top: 50, bottom: pb, left: 50, right: 50 },
|
||||||
maxZoom: 16,
|
maxZoom: 16,
|
||||||
pitch: mapbox3d && fullScreen ? 45 : 0,
|
pitch: enableMapbox3d && fullScreen ? 45 : 0,
|
||||||
duration: 0,
|
duration: 0,
|
||||||
})
|
})
|
||||||
} catch { /* empty bounds */ }
|
} catch { /* empty bounds */ }
|
||||||
@@ -418,7 +446,7 @@ const JourneyMapGL = forwardRef<JourneyMapGLHandle, Props>(function JourneyMapGL
|
|||||||
try { map.remove() } catch { /* noop */ }
|
try { map.remove() } catch { /* noop */ }
|
||||||
mapRef.current = null
|
mapRef.current = null
|
||||||
}
|
}
|
||||||
}, [entries, stableTrail, mapboxStyle, mapboxToken, mapbox3d, mapboxQuality, fullScreen, paddingBottom])
|
}, [entries, stableTrail, glProvider, glStyle, mapboxToken, enableMapbox3d, mapboxQuality, fullScreen, paddingBottom])
|
||||||
|
|
||||||
// external activeMarkerId → highlight + flyTo
|
// external activeMarkerId → highlight + flyTo
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
@@ -431,15 +459,15 @@ const JourneyMapGL = forwardRef<JourneyMapGLHandle, Props>(function JourneyMapGL
|
|||||||
mapRef.current.flyTo({
|
mapRef.current.flyTo({
|
||||||
center: marker.getLngLat(),
|
center: marker.getLngLat(),
|
||||||
zoom: Math.max(mapRef.current.getZoom(), 12),
|
zoom: Math.max(mapRef.current.getZoom(), 12),
|
||||||
pitch: mapbox3d && fullScreen ? 45 : 0,
|
pitch: enableMapbox3d && fullScreen ? 45 : 0,
|
||||||
duration: 500,
|
duration: 500,
|
||||||
})
|
})
|
||||||
} catch { /* map not ready */ }
|
} catch { /* map not ready */ }
|
||||||
}, 50)
|
}, 50)
|
||||||
return () => clearTimeout(t)
|
return () => clearTimeout(t)
|
||||||
}, [activeMarkerId, highlightMarker, mapbox3d, fullScreen])
|
}, [activeMarkerId, highlightMarker, enableMapbox3d, fullScreen])
|
||||||
|
|
||||||
if (!mapboxToken) {
|
if (!isMapLibre && !mapboxToken) {
|
||||||
return (
|
return (
|
||||||
<div
|
<div
|
||||||
style={{ position: 'relative', height: height === 9999 ? '100%' : height, width: '100%', borderRadius: 'inherit', overflow: 'hidden' }}
|
style={{ position: 'relative', height: height === 9999 ? '100%' : height, width: '100%', borderRadius: 'inherit', overflow: 'hidden' }}
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
// FE-COMP-MDTOOLBAR-001 to FE-COMP-MDTOOLBAR-006
|
// FE-COMP-MDTOOLBAR-001 to FE-COMP-MDTOOLBAR-006
|
||||||
|
|
||||||
import { describe, it, expect, vi, beforeEach } from 'vitest';
|
import { describe, it, expect, vi, beforeEach, type Mock } from 'vitest';
|
||||||
import { render, screen, fireEvent } from '../../../tests/helpers/render';
|
import { render, screen, fireEvent } from '../../../tests/helpers/render';
|
||||||
import MarkdownToolbar from './MarkdownToolbar';
|
import MarkdownToolbar from './MarkdownToolbar';
|
||||||
import React from 'react';
|
import React from 'react';
|
||||||
@@ -16,10 +16,10 @@ function createTextareaRef(value = '', selectionStart = 0, selectionEnd = 0) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
describe('MarkdownToolbar', () => {
|
describe('MarkdownToolbar', () => {
|
||||||
let onUpdate: ReturnType<typeof vi.fn>;
|
let onUpdate: Mock<(value: string) => void>;
|
||||||
|
|
||||||
beforeEach(() => {
|
beforeEach(() => {
|
||||||
onUpdate = vi.fn();
|
onUpdate = vi.fn<(value: string) => void>();
|
||||||
});
|
});
|
||||||
|
|
||||||
it('FE-COMP-MDTOOLBAR-001: renders all 8 toolbar buttons', () => {
|
it('FE-COMP-MDTOOLBAR-001: renders all 8 toolbar buttons', () => {
|
||||||
|
|||||||
@@ -0,0 +1,42 @@
|
|||||||
|
import { afterEach, describe, expect, it, vi } from 'vitest'
|
||||||
|
import { screen, waitFor } from '@testing-library/react'
|
||||||
|
import { render } from '../../../tests/helpers/render'
|
||||||
|
import OfflineBanner from './OfflineBanner'
|
||||||
|
|
||||||
|
vi.mock('../../sync/mutationQueue', () => ({
|
||||||
|
mutationQueue: {
|
||||||
|
pendingCount: vi.fn(),
|
||||||
|
failedCount: vi.fn(),
|
||||||
|
},
|
||||||
|
}))
|
||||||
|
|
||||||
|
import { mutationQueue } from '../../sync/mutationQueue'
|
||||||
|
|
||||||
|
const pendingCount = mutationQueue.pendingCount as ReturnType<typeof vi.fn>
|
||||||
|
const failedCount = mutationQueue.failedCount as ReturnType<typeof vi.fn>
|
||||||
|
|
||||||
|
afterEach(() => {
|
||||||
|
vi.clearAllMocks()
|
||||||
|
Object.defineProperty(navigator, 'onLine', { value: true, writable: true, configurable: true })
|
||||||
|
})
|
||||||
|
|
||||||
|
describe('OfflineBanner (B3 surface)', () => {
|
||||||
|
it('shows the failed pill when failedCount > 0 while online', async () => {
|
||||||
|
pendingCount.mockResolvedValue(0)
|
||||||
|
failedCount.mockResolvedValue(2)
|
||||||
|
|
||||||
|
render(<OfflineBanner />)
|
||||||
|
|
||||||
|
expect(await screen.findByText(/2 changes failed to sync/i)).toBeInTheDocument()
|
||||||
|
})
|
||||||
|
|
||||||
|
it('stays hidden when online with nothing pending or failed', async () => {
|
||||||
|
pendingCount.mockResolvedValue(0)
|
||||||
|
failedCount.mockResolvedValue(0)
|
||||||
|
|
||||||
|
const { container } = render(<OfflineBanner />)
|
||||||
|
// Give the async poll a tick to resolve.
|
||||||
|
await waitFor(() => expect(failedCount).toHaveBeenCalled())
|
||||||
|
expect(container.querySelector('[role="status"]')).toBeNull()
|
||||||
|
})
|
||||||
|
})
|
||||||
@@ -2,6 +2,7 @@
|
|||||||
* OfflineBanner — connectivity + sync state indicator.
|
* OfflineBanner — connectivity + sync state indicator.
|
||||||
*
|
*
|
||||||
* States:
|
* States:
|
||||||
|
* N failed → red pill "N changes failed to sync" (takes priority)
|
||||||
* offline + N queued → amber pill "Offline · N queued"
|
* offline + N queued → amber pill "Offline · N queued"
|
||||||
* offline + 0 queued → amber pill "Offline"
|
* offline + 0 queued → amber pill "Offline"
|
||||||
* online + N pending → blue pill "Syncing N…"
|
* online + N pending → blue pill "Syncing N…"
|
||||||
@@ -12,7 +13,7 @@
|
|||||||
* headers. On mobile it hovers just above the bottom tab bar.
|
* headers. On mobile it hovers just above the bottom tab bar.
|
||||||
*/
|
*/
|
||||||
import React, { useState, useEffect } from 'react'
|
import React, { useState, useEffect } from 'react'
|
||||||
import { WifiOff, RefreshCw } from 'lucide-react'
|
import { WifiOff, RefreshCw, AlertTriangle } from 'lucide-react'
|
||||||
import { mutationQueue } from '../../sync/mutationQueue'
|
import { mutationQueue } from '../../sync/mutationQueue'
|
||||||
|
|
||||||
const POLL_MS = 3_000
|
const POLL_MS = 3_000
|
||||||
@@ -20,6 +21,7 @@ const POLL_MS = 3_000
|
|||||||
export default function OfflineBanner(): React.ReactElement | null {
|
export default function OfflineBanner(): React.ReactElement | null {
|
||||||
const [isOnline, setIsOnline] = useState(navigator.onLine)
|
const [isOnline, setIsOnline] = useState(navigator.onLine)
|
||||||
const [pendingCount, setPendingCount] = useState(0)
|
const [pendingCount, setPendingCount] = useState(0)
|
||||||
|
const [failedCount, setFailedCount] = useState(0)
|
||||||
|
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
const onOnline = () => setIsOnline(true)
|
const onOnline = () => setIsOnline(true)
|
||||||
@@ -35,26 +37,36 @@ export default function OfflineBanner(): React.ReactElement | null {
|
|||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
let cancelled = false
|
let cancelled = false
|
||||||
async function poll() {
|
async function poll() {
|
||||||
const n = await mutationQueue.pendingCount()
|
const [n, failed] = await Promise.all([
|
||||||
if (!cancelled) setPendingCount(n)
|
mutationQueue.pendingCount(),
|
||||||
|
mutationQueue.failedCount(),
|
||||||
|
])
|
||||||
|
if (!cancelled) {
|
||||||
|
setPendingCount(n)
|
||||||
|
setFailedCount(failed)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
poll()
|
poll()
|
||||||
const id = setInterval(poll, POLL_MS)
|
const id = setInterval(poll, POLL_MS)
|
||||||
return () => { cancelled = true; clearInterval(id) }
|
return () => { cancelled = true; clearInterval(id) }
|
||||||
}, [])
|
}, [])
|
||||||
|
|
||||||
const hidden = isOnline && pendingCount === 0
|
const hidden = isOnline && pendingCount === 0 && failedCount === 0
|
||||||
if (hidden) return null
|
if (hidden) return null
|
||||||
|
|
||||||
const offline = !isOnline
|
const offline = !isOnline
|
||||||
const bg = offline ? '#92400e' : '#1e40af'
|
// Failed mutations are the most important signal — they mean data was dropped.
|
||||||
|
const failed = failedCount > 0
|
||||||
|
const bg = failed ? '#b91c1c' : offline ? '#92400e' : '#1e40af'
|
||||||
const text = '#fff'
|
const text = '#fff'
|
||||||
|
|
||||||
const label = offline
|
const label = failed
|
||||||
? pendingCount > 0
|
? `${failedCount} change${failedCount !== 1 ? 's' : ''} failed to sync`
|
||||||
? `Offline · ${pendingCount} queued`
|
: offline
|
||||||
: 'Offline'
|
? pendingCount > 0
|
||||||
: `Syncing ${pendingCount}…`
|
? `Offline · ${pendingCount} queued`
|
||||||
|
: 'Offline'
|
||||||
|
: `Syncing ${pendingCount}…`
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<div
|
<div
|
||||||
@@ -82,9 +94,11 @@ export default function OfflineBanner(): React.ReactElement | null {
|
|||||||
pointerEvents: 'none',
|
pointerEvents: 'none',
|
||||||
}}
|
}}
|
||||||
>
|
>
|
||||||
{offline
|
{failed
|
||||||
? <WifiOff size={12} />
|
? <AlertTriangle size={12} />
|
||||||
: <RefreshCw size={12} style={{ animation: 'spin 1s linear infinite' }} />
|
: offline
|
||||||
|
? <WifiOff size={12} />
|
||||||
|
: <RefreshCw size={12} style={{ animation: 'spin 1s linear infinite' }} />
|
||||||
}
|
}
|
||||||
{label}
|
{label}
|
||||||
</div>
|
</div>
|
||||||
|
|||||||
@@ -1,15 +1,21 @@
|
|||||||
import { useEffect, useState } from 'react'
|
import { useEffect, useState } from 'react'
|
||||||
import { Navigation } from 'lucide-react'
|
import { Navigation } from 'lucide-react'
|
||||||
import type mapboxgl from 'mapbox-gl'
|
|
||||||
|
export interface CompassMap {
|
||||||
|
getBearing: () => number
|
||||||
|
on: (type: 'rotate', listener: () => void) => unknown
|
||||||
|
off: (type: 'rotate', listener: () => void) => unknown
|
||||||
|
easeTo: (options: { bearing: number; pitch: number; duration: number }) => unknown
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Round compass pill for the Mapbox planner map. The Mapbox map can be rotated and
|
* Round compass pill for the GL planner map. The map can be rotated and
|
||||||
* pitched, so this shows the current bearing (the arrow points to north) and snaps
|
* pitched, so this shows the current bearing (the arrow points to north) and snaps
|
||||||
* the camera back to north + flat on click. Rendered next to the POI "explore" pill
|
* the camera back to north + flat on click. Rendered next to the POI "explore" pill
|
||||||
* (Mapbox only) and built as the SAME frosted shell (padding 4 around a 34px button)
|
* (GL only) and built as the SAME frosted shell (padding 4 around a 34px button)
|
||||||
* so its height and transparency match the POI pill exactly.
|
* so its height and transparency match the POI pill exactly.
|
||||||
*/
|
*/
|
||||||
export function MapCompassPill({ map }: { map: mapboxgl.Map }) {
|
export function MapCompassPill({ map }: { map: CompassMap }) {
|
||||||
const [bearing, setBearing] = useState(() => map.getBearing())
|
const [bearing, setBearing] = useState(() => map.getBearing())
|
||||||
|
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
|
|||||||
@@ -1,16 +1,36 @@
|
|||||||
|
import { lazy, Suspense } from 'react'
|
||||||
import { useSettingsStore } from '../../store/settingsStore'
|
import { useSettingsStore } from '../../store/settingsStore'
|
||||||
import { MapView } from './MapView'
|
import { MapView } from './MapView'
|
||||||
import { MapViewGL } from './MapViewGL'
|
|
||||||
|
// MapLibre/Mapbox pull in a ~230 KB (gzip) GL engine. Lazy-load the GL renderer so
|
||||||
|
// Leaflet-only installs never download it — it ships only once a GL provider is picked.
|
||||||
|
const MapViewGL = lazy(() => import('./MapViewGL').then(m => ({ default: m.MapViewGL })))
|
||||||
|
|
||||||
// Auto-selects the map renderer based on user settings. Keeps the existing
|
// Auto-selects the map renderer based on user settings. Keeps the existing
|
||||||
// Leaflet MapView untouched so the Mapbox GL variant can mature iteratively
|
// Leaflet MapView untouched so the Mapbox GL variant can mature iteratively
|
||||||
// behind a toggle. Atlas is not affected — it imports Leaflet directly.
|
// behind a toggle. Atlas is not affected — it imports Leaflet directly.
|
||||||
|
//
|
||||||
|
// Offline maps: only the Leaflet renderer supports full pre-download (raster
|
||||||
|
// tiles via sync/tilePrefetcher.ts). GL maps are best-effort offline — their
|
||||||
|
// vector tiles are cached opportunistically by the Service Worker as you view
|
||||||
|
// them online (see the GL tile rules in vite.config.js), not prefetched.
|
||||||
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
||||||
export function MapViewAuto(props: any) {
|
export function MapViewAuto(props: any) {
|
||||||
const provider = useSettingsStore(s => s.settings.map_provider)
|
const provider = useSettingsStore(s => s.settings.map_provider)
|
||||||
const token = useSettingsStore(s => s.settings.mapbox_access_token)
|
const token = useSettingsStore(s => s.settings.mapbox_access_token)
|
||||||
// Fall back to Leaflet when Mapbox is selected but no token is set,
|
// Fall back to Leaflet when Mapbox is selected but no token is set,
|
||||||
// so trip planner never shows an empty map due to a missing token.
|
// so trip planner never shows an empty map due to a missing token.
|
||||||
if (provider === 'mapbox-gl' && token) return <MapViewGL {...props} />
|
const glProvider = provider === 'maplibre-gl' ? 'maplibre-gl'
|
||||||
|
: provider === 'mapbox-gl' && token ? 'mapbox-gl'
|
||||||
|
: null
|
||||||
|
if (glProvider) {
|
||||||
|
// Render the previous Leaflet map as the fallback so there's no blank flash
|
||||||
|
// while the GL chunk loads on first use.
|
||||||
|
return (
|
||||||
|
<Suspense fallback={<MapView {...props} />}>
|
||||||
|
<MapViewGL {...props} glProvider={glProvider} />
|
||||||
|
</Suspense>
|
||||||
|
)
|
||||||
|
}
|
||||||
return <MapView {...props} />
|
return <MapView {...props} />
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -31,25 +31,62 @@ const glMap = vi.hoisted(() => ({
|
|||||||
vi.mock('mapbox-gl', () => ({
|
vi.mock('mapbox-gl', () => ({
|
||||||
default: {
|
default: {
|
||||||
accessToken: '',
|
accessToken: '',
|
||||||
Map: vi.fn(() => glMap),
|
Map: vi.fn(function () {
|
||||||
Marker: vi.fn(() => ({
|
return glMap
|
||||||
setLngLat: vi.fn().mockReturnThis(),
|
}),
|
||||||
addTo: vi.fn().mockReturnThis(),
|
Marker: vi.fn(function () {
|
||||||
remove: vi.fn(),
|
return {
|
||||||
getElement: vi.fn(() => document.createElement('div')),
|
setLngLat: vi.fn().mockReturnThis(),
|
||||||
})),
|
addTo: vi.fn().mockReturnThis(),
|
||||||
LngLatBounds: vi.fn(() => ({ extend: vi.fn().mockReturnThis() })),
|
remove: vi.fn(),
|
||||||
|
getElement: vi.fn(() => document.createElement('div')),
|
||||||
|
}
|
||||||
|
}),
|
||||||
|
LngLatBounds: vi.fn(function () {
|
||||||
|
return { extend: vi.fn().mockReturnThis() }
|
||||||
|
}),
|
||||||
NavigationControl: vi.fn(),
|
NavigationControl: vi.fn(),
|
||||||
Popup: vi.fn(() => ({
|
Popup: vi.fn(function () {
|
||||||
setLngLat: vi.fn().mockReturnThis(),
|
return {
|
||||||
setHTML: vi.fn().mockReturnThis(),
|
setLngLat: vi.fn().mockReturnThis(),
|
||||||
addTo: vi.fn().mockReturnThis(),
|
setHTML: vi.fn().mockReturnThis(),
|
||||||
remove: vi.fn(),
|
addTo: vi.fn().mockReturnThis(),
|
||||||
})),
|
remove: vi.fn(),
|
||||||
|
}
|
||||||
|
}),
|
||||||
},
|
},
|
||||||
}))
|
}))
|
||||||
vi.mock('mapbox-gl/dist/mapbox-gl.css', () => ({}))
|
vi.mock('mapbox-gl/dist/mapbox-gl.css', () => ({}))
|
||||||
|
|
||||||
|
vi.mock('maplibre-gl', () => ({
|
||||||
|
default: {
|
||||||
|
Map: vi.fn(function () {
|
||||||
|
return glMap
|
||||||
|
}),
|
||||||
|
Marker: vi.fn(function () {
|
||||||
|
return {
|
||||||
|
setLngLat: vi.fn().mockReturnThis(),
|
||||||
|
addTo: vi.fn().mockReturnThis(),
|
||||||
|
remove: vi.fn(),
|
||||||
|
getElement: vi.fn(() => document.createElement('div')),
|
||||||
|
}
|
||||||
|
}),
|
||||||
|
LngLatBounds: vi.fn(function () {
|
||||||
|
return { extend: vi.fn().mockReturnThis() }
|
||||||
|
}),
|
||||||
|
NavigationControl: vi.fn(),
|
||||||
|
Popup: vi.fn(function () {
|
||||||
|
return {
|
||||||
|
setLngLat: vi.fn().mockReturnThis(),
|
||||||
|
setHTML: vi.fn().mockReturnThis(),
|
||||||
|
addTo: vi.fn().mockReturnThis(),
|
||||||
|
remove: vi.fn(),
|
||||||
|
}
|
||||||
|
}),
|
||||||
|
},
|
||||||
|
}))
|
||||||
|
vi.mock('maplibre-gl/dist/maplibre-gl.css', () => ({}))
|
||||||
|
|
||||||
vi.mock('./mapboxSetup', () => ({
|
vi.mock('./mapboxSetup', () => ({
|
||||||
isStandardFamily: vi.fn(() => false),
|
isStandardFamily: vi.fn(() => false),
|
||||||
supportsCustom3d: vi.fn(() => false),
|
supportsCustom3d: vi.fn(() => false),
|
||||||
@@ -63,7 +100,9 @@ vi.mock('./locationMarkerMapbox', () => ({
|
|||||||
}))
|
}))
|
||||||
|
|
||||||
vi.mock('./reservationsMapbox', () => ({
|
vi.mock('./reservationsMapbox', () => ({
|
||||||
ReservationMapboxOverlay: vi.fn().mockImplementation(() => ({ update: vi.fn() })),
|
ReservationMapboxOverlay: vi.fn(function () {
|
||||||
|
return { update: vi.fn() }
|
||||||
|
}),
|
||||||
}))
|
}))
|
||||||
|
|
||||||
vi.mock('../../hooks/useGeolocation', () => ({
|
vi.mock('../../hooks/useGeolocation', () => ({
|
||||||
@@ -167,4 +206,25 @@ describe('MapViewGL', () => {
|
|||||||
await act(async () => {})
|
await act(async () => {})
|
||||||
expect(glMap.fitBounds.mock.calls.length).toBeGreaterThan(after_first)
|
expect(glMap.fitBounds.mock.calls.length).toBeGreaterThan(after_first)
|
||||||
})
|
})
|
||||||
|
|
||||||
|
it('FE-COMP-MAPVIEWGL-004: renders with the MapLibre provider and no token', async () => {
|
||||||
|
const mapboxgl = (await import('mapbox-gl')).default
|
||||||
|
const maplibregl = (await import('maplibre-gl')).default
|
||||||
|
useSettingsStore.setState({
|
||||||
|
settings: {
|
||||||
|
...useSettingsStore.getState().settings,
|
||||||
|
map_provider: 'maplibre-gl',
|
||||||
|
mapbox_access_token: '', // MapLibre/OpenFreeMap is tokenless — must not short-circuit
|
||||||
|
maplibre_style: 'https://tiles.openfreemap.org/styles/liberty',
|
||||||
|
},
|
||||||
|
} as any)
|
||||||
|
const places = [buildMapPlace({ id: 1, lat: 48.8584, lng: 2.2945 })]
|
||||||
|
|
||||||
|
render(<MapViewGL places={places} fitKey={1} glProvider="maplibre-gl" />)
|
||||||
|
await act(async () => {})
|
||||||
|
|
||||||
|
// The MapLibre engine builds the map even without a token; Mapbox is not used.
|
||||||
|
expect(maplibregl.Map).toHaveBeenCalled()
|
||||||
|
expect(mapboxgl.Map).not.toHaveBeenCalled()
|
||||||
|
})
|
||||||
})
|
})
|
||||||
|
|||||||
@@ -1,7 +1,9 @@
|
|||||||
import { useEffect, useRef, useMemo, useState, createElement } from 'react'
|
import { useEffect, useRef, useMemo, useState, createElement } from 'react'
|
||||||
import { renderToStaticMarkup } from 'react-dom/server'
|
import { renderToStaticMarkup } from 'react-dom/server'
|
||||||
import mapboxgl from 'mapbox-gl'
|
import mapboxgl from 'mapbox-gl'
|
||||||
|
import maplibregl from 'maplibre-gl'
|
||||||
import 'mapbox-gl/dist/mapbox-gl.css'
|
import 'mapbox-gl/dist/mapbox-gl.css'
|
||||||
|
import 'maplibre-gl/dist/maplibre-gl.css'
|
||||||
import { useSettingsStore } from '../../store/settingsStore'
|
import { useSettingsStore } from '../../store/settingsStore'
|
||||||
import { useAuthStore } from '../../store/authStore'
|
import { useAuthStore } from '../../store/authStore'
|
||||||
import { getCached, isLoading, fetchPhoto, onThumbReady, getAllThumbs } from '../../services/photoService'
|
import { getCached, isLoading, fetchPhoto, onThumbReady, getAllThumbs } from '../../services/photoService'
|
||||||
@@ -9,6 +11,7 @@ import { CATEGORY_ICON_MAP } from '../shared/categoryIcons'
|
|||||||
import { isStandardFamily, supportsCustom3d, wantsTerrain, addCustom3dBuildings, addTerrainAndSky } from './mapboxSetup'
|
import { isStandardFamily, supportsCustom3d, wantsTerrain, addCustom3dBuildings, addTerrainAndSky } from './mapboxSetup'
|
||||||
import { attachLocationMarker, type LocationMarkerHandle } from './locationMarkerMapbox'
|
import { attachLocationMarker, type LocationMarkerHandle } from './locationMarkerMapbox'
|
||||||
import { ReservationMapboxOverlay } from './reservationsMapbox'
|
import { ReservationMapboxOverlay } from './reservationsMapbox'
|
||||||
|
import { MAPBOX_DEFAULT_STYLE, styleForActiveProvider, basemapLanguage, type GlMapProvider } from './glProviders'
|
||||||
import LocationButton from './LocationButton'
|
import LocationButton from './LocationButton'
|
||||||
import { useGeolocation } from '../../hooks/useGeolocation'
|
import { useGeolocation } from '../../hooks/useGeolocation'
|
||||||
import type { Place, Reservation } from '../../types'
|
import type { Place, Reservation } from '../../types'
|
||||||
@@ -54,7 +57,9 @@ interface Props {
|
|||||||
pois?: Poi[]
|
pois?: Poi[]
|
||||||
onPoiClick?: (poi: Poi) => void
|
onPoiClick?: (poi: Poi) => void
|
||||||
onViewportChange?: (bbox: { south: number; west: number; north: number; east: number }) => void
|
onViewportChange?: (bbox: { south: number; west: number; north: number; east: number }) => void
|
||||||
onMapReady?: (map: mapboxgl.Map | null) => void
|
glProvider?: GlMapProvider
|
||||||
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
||||||
|
onMapReady?: (map: any | null) => void
|
||||||
}
|
}
|
||||||
|
|
||||||
function createMarkerElement(place: Place & { category_color?: string; category_icon?: string }, photoUrl: string | null, orderNumbers: number[] | null, selected: boolean): HTMLDivElement {
|
function createMarkerElement(place: Place & { category_color?: string; category_icon?: string }, photoUrl: string | null, orderNumbers: number[] | null, selected: boolean): HTMLDivElement {
|
||||||
@@ -91,8 +96,8 @@ function createMarkerElement(place: Place & { category_color?: string; category_
|
|||||||
}
|
}
|
||||||
|
|
||||||
const wrap = document.createElement('div')
|
const wrap = document.createElement('div')
|
||||||
// Do NOT set `position: relative` here — mapbox-gl ships
|
// Do NOT set `position: relative` here — GL map libraries ship
|
||||||
// `.mapboxgl-marker { position: absolute }` and relies on it. An inline
|
// marker classes with `position: absolute` and rely on it. An inline
|
||||||
// `position: relative` here overrides the class, turns every marker into
|
// `position: relative` here overrides the class, turns every marker into
|
||||||
// a static block element, and stacks them in document order inside the
|
// a static block element, and stacks them in document order inside the
|
||||||
// canvas container. The result looks exactly like "markers drift as the
|
// canvas container. The result looks exactly like "markers drift as the
|
||||||
@@ -169,29 +174,40 @@ export function MapViewGL({
|
|||||||
pois = [],
|
pois = [],
|
||||||
onPoiClick,
|
onPoiClick,
|
||||||
onViewportChange,
|
onViewportChange,
|
||||||
|
glProvider = 'mapbox-gl',
|
||||||
onMapReady,
|
onMapReady,
|
||||||
}: Props) {
|
}: Props) {
|
||||||
const mapboxStyle = useSettingsStore(s => s.settings.mapbox_style || 'mapbox://styles/mapbox/standard')
|
const rawMapboxStyle = useSettingsStore(s => s.settings.mapbox_style || MAPBOX_DEFAULT_STYLE)
|
||||||
|
const rawMaplibreStyle = useSettingsStore(s => s.settings.maplibre_style || '')
|
||||||
const mapboxToken = useSettingsStore(s => s.settings.mapbox_access_token || '')
|
const mapboxToken = useSettingsStore(s => s.settings.mapbox_access_token || '')
|
||||||
const mapbox3d = useSettingsStore(s => s.settings.mapbox_3d_enabled !== false)
|
const mapbox3d = useSettingsStore(s => s.settings.mapbox_3d_enabled !== false)
|
||||||
const mapboxQuality = useSettingsStore(s => s.settings.mapbox_quality_mode === true)
|
const mapboxQuality = useSettingsStore(s => s.settings.mapbox_quality_mode === true)
|
||||||
const showEndpointLabels = useSettingsStore(s => s.settings.map_booking_labels) !== false
|
const showEndpointLabels = useSettingsStore(s => s.settings.map_booking_labels) !== false
|
||||||
|
const mapLang = useSettingsStore(s => s.settings.language)
|
||||||
|
const isMapLibre = glProvider === 'maplibre-gl'
|
||||||
|
const gl = (isMapLibre ? maplibregl : mapboxgl) as any
|
||||||
|
const glStyle = styleForActiveProvider(glProvider, rawMapboxStyle, rawMaplibreStyle)
|
||||||
|
const enableMapbox3d = !isMapLibre && mapbox3d
|
||||||
const placesPhotosEnabled = useAuthStore(s => s.placesPhotosEnabled)
|
const placesPhotosEnabled = useAuthStore(s => s.placesPhotosEnabled)
|
||||||
const [photoUrls, setPhotoUrls] = useState<Record<string, string>>(getAllThumbs)
|
const [photoUrls, setPhotoUrls] = useState<Record<string, string>>(getAllThumbs)
|
||||||
const [mapReady, setMapReady] = useState(false)
|
const [mapReady, setMapReady] = useState(false)
|
||||||
const containerRef = useRef<HTMLDivElement>(null)
|
const containerRef = useRef<HTMLDivElement>(null)
|
||||||
const mapRef = useRef<mapboxgl.Map | null>(null)
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
||||||
const markersRef = useRef<Map<number, mapboxgl.Marker>>(new Map())
|
const mapRef = useRef<any | null>(null)
|
||||||
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
||||||
|
const markersRef = useRef<Map<number, any>>(new Map())
|
||||||
const locationMarkerRef = useRef<LocationMarkerHandle | null>(null)
|
const locationMarkerRef = useRef<LocationMarkerHandle | null>(null)
|
||||||
const reservationOverlayRef = useRef<ReservationMapboxOverlay | null>(null)
|
const reservationOverlayRef = useRef<ReservationMapboxOverlay | null>(null)
|
||||||
// Refs so the reservation overlay always sees the latest callback /
|
// Refs so the reservation overlay always sees the latest callback /
|
||||||
// options without forcing a full overlay rebuild on every prop change.
|
// options without forcing a full overlay rebuild on every prop change.
|
||||||
const onReservationClickRef = useRef(onReservationClick)
|
const onReservationClickRef = useRef(onReservationClick)
|
||||||
onReservationClickRef.current = onReservationClick
|
onReservationClickRef.current = onReservationClick
|
||||||
const poiMarkersRef = useRef<mapboxgl.Marker[]>([])
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
||||||
|
const poiMarkersRef = useRef<any[]>([])
|
||||||
// Single reusable hover popup (name/category/address card) shared by planned
|
// Single reusable hover popup (name/category/address card) shared by planned
|
||||||
// places and POI markers — mirrors the Leaflet map's hover tooltip.
|
// places and POI markers — mirrors the Leaflet map's hover tooltip.
|
||||||
const popupRef = useRef<mapboxgl.Popup | null>(null)
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
||||||
|
const popupRef = useRef<any | null>(null)
|
||||||
const onPoiClickRef = useRef(onPoiClick)
|
const onPoiClickRef = useRef(onPoiClick)
|
||||||
onPoiClickRef.current = onPoiClick
|
onPoiClickRef.current = onPoiClick
|
||||||
const onViewportChangeRef = useRef(onViewportChange)
|
const onViewportChangeRef = useRef(onViewportChange)
|
||||||
@@ -204,23 +220,25 @@ export function MapViewGL({
|
|||||||
onClickRefs.current.map = onMapClick
|
onClickRefs.current.map = onMapClick
|
||||||
onClickRefs.current.context = onMapContextMenu
|
onClickRefs.current.context = onMapContextMenu
|
||||||
|
|
||||||
// Build/rebuild the map on style/token/3d change
|
// Build/rebuild the map on provider/style/token/3d change
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
if (!containerRef.current || !mapboxToken) return
|
if (!containerRef.current || (!isMapLibre && !mapboxToken)) return
|
||||||
mapboxgl.accessToken = mapboxToken
|
if (!isMapLibre) mapboxgl.accessToken = mapboxToken
|
||||||
|
|
||||||
const map = new mapboxgl.Map({
|
const mapOptions: Record<string, unknown> = {
|
||||||
container: containerRef.current,
|
container: containerRef.current,
|
||||||
style: mapboxStyle,
|
style: glStyle,
|
||||||
center: [center[1], center[0]],
|
center: [center[1], center[0]],
|
||||||
zoom,
|
zoom,
|
||||||
pitch: mapbox3d ? 45 : 0,
|
pitch: enableMapbox3d ? 45 : 0,
|
||||||
attributionControl: true,
|
attributionControl: true,
|
||||||
antialias: mapboxQuality,
|
antialias: mapboxQuality,
|
||||||
projection: mapboxQuality ? 'globe' : 'mercator',
|
}
|
||||||
})
|
if (!isMapLibre) mapOptions.projection = mapboxQuality ? 'globe' : 'mercator'
|
||||||
|
|
||||||
|
const map = new gl.Map(mapOptions as any)
|
||||||
mapRef.current = map
|
mapRef.current = map
|
||||||
popupRef.current = new mapboxgl.Popup({
|
popupRef.current = new gl.Popup({
|
||||||
closeButton: false,
|
closeButton: false,
|
||||||
closeOnClick: false,
|
closeOnClick: false,
|
||||||
offset: 18,
|
offset: 18,
|
||||||
@@ -234,12 +252,12 @@ export function MapViewGL({
|
|||||||
;(window as any).__trek_map = map
|
;(window as any).__trek_map = map
|
||||||
|
|
||||||
map.on('load', () => {
|
map.on('load', () => {
|
||||||
if (mapbox3d) {
|
if (enableMapbox3d) {
|
||||||
// Terrain is only valuable on satellite styles — on clean vector
|
// Terrain is only valuable on satellite styles — on clean vector
|
||||||
// styles it makes route lines drift off the HTML markers because
|
// styles it makes route lines drift off the HTML markers because
|
||||||
// the lines snap to DEM height while markers stay at sea level.
|
// the lines snap to DEM height while markers stay at sea level.
|
||||||
if (!isStandardFamily(mapboxStyle) && wantsTerrain(mapboxStyle)) addTerrainAndSky(map)
|
if (!isStandardFamily(glStyle) && wantsTerrain(glStyle)) addTerrainAndSky(map)
|
||||||
if (supportsCustom3d(mapboxStyle)) {
|
if (supportsCustom3d(glStyle)) {
|
||||||
const dark = document.documentElement.classList.contains('dark')
|
const dark = document.documentElement.classList.contains('dark')
|
||||||
addCustom3dBuildings(map, dark)
|
addCustom3dBuildings(map, dark)
|
||||||
}
|
}
|
||||||
@@ -252,7 +270,7 @@ export function MapViewGL({
|
|||||||
// non-satellite Standard style still looks great without terrain,
|
// non-satellite Standard style still looks great without terrain,
|
||||||
// so flatten it out to keep markers pinned. (Satellite variants
|
// so flatten it out to keep markers pinned. (Satellite variants
|
||||||
// are left alone — the DEM is what gives them their character.)
|
// are left alone — the DEM is what gives them their character.)
|
||||||
if (mapboxStyle === 'mapbox://styles/mapbox/standard') {
|
if (glStyle === MAPBOX_DEFAULT_STYLE) {
|
||||||
try { map.setTerrain(null) } catch { /* noop */ }
|
try { map.setTerrain(null) } catch { /* noop */ }
|
||||||
}
|
}
|
||||||
// initial route source — kept around so updates can setData() cheaply
|
// initial route source — kept around so updates can setData() cheaply
|
||||||
@@ -298,7 +316,7 @@ export function MapViewGL({
|
|||||||
|
|
||||||
map.on('click', (e) => {
|
map.on('click', (e) => {
|
||||||
const t = e.originalEvent.target as HTMLElement
|
const t = e.originalEvent.target as HTMLElement
|
||||||
if (t.closest('.mapboxgl-marker')) return // markers handle their own click
|
if (t.closest('.mapboxgl-marker, .maplibregl-marker')) return // markers handle their own click
|
||||||
onClickRefs.current.map?.({ latlng: { lat: e.lngLat.lat, lng: e.lngLat.lng } })
|
onClickRefs.current.map?.({ latlng: { lat: e.lngLat.lat, lng: e.lngLat.lng } })
|
||||||
})
|
})
|
||||||
// Emit the viewport bbox (pan/zoom + once on first idle) so the POI-explore
|
// Emit the viewport bbox (pan/zoom + once on first idle) so the POI-explore
|
||||||
@@ -309,7 +327,7 @@ export function MapViewGL({
|
|||||||
}
|
}
|
||||||
map.on('moveend', emitViewport)
|
map.on('moveend', emitViewport)
|
||||||
map.once('idle', emitViewport)
|
map.once('idle', emitViewport)
|
||||||
// In the mapbox-gl map the right mouse button is reserved for the
|
// In the GL map the right mouse button is reserved for the
|
||||||
// built-in rotate/pitch gesture, so we bind the "add place" action
|
// built-in rotate/pitch gesture, so we bind the "add place" action
|
||||||
// to the middle mouse button (button === 1) instead.
|
// to the middle mouse button (button === 1) instead.
|
||||||
const canvas = map.getCanvasContainer()
|
const canvas = map.getCanvasContainer()
|
||||||
@@ -356,7 +374,9 @@ export function MapViewGL({
|
|||||||
const ll = marker.getLngLat()
|
const ll = marker.getLngLat()
|
||||||
let alt = 0
|
let alt = 0
|
||||||
try {
|
try {
|
||||||
const e = map.queryTerrainElevation([ll.lng, ll.lat])
|
const e = typeof map.queryTerrainElevation === 'function'
|
||||||
|
? map.queryTerrainElevation([ll.lng, ll.lat])
|
||||||
|
: null
|
||||||
if (typeof e === 'number' && Number.isFinite(e)) alt = e
|
if (typeof e === 'number' && Number.isFinite(e)) alt = e
|
||||||
} catch { /* terrain not ready */ }
|
} catch { /* terrain not ready */ }
|
||||||
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
||||||
@@ -368,7 +388,9 @@ export function MapViewGL({
|
|||||||
}
|
}
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
map.on('render', syncMarkerAltitudes)
|
// Terrain altitude sync only matters with mapbox 3D/terrain on; skip the per-frame
|
||||||
|
// listener entirely for MapLibre and flat mapbox styles.
|
||||||
|
if (enableMapbox3d) map.on('render', syncMarkerAltitudes)
|
||||||
|
|
||||||
return () => {
|
return () => {
|
||||||
canvas.removeEventListener('mousedown', onAuxDown)
|
canvas.removeEventListener('mousedown', onAuxDown)
|
||||||
@@ -389,7 +411,17 @@ export function MapViewGL({
|
|||||||
mapRef.current = null
|
mapRef.current = null
|
||||||
setMapReady(false)
|
setMapReady(false)
|
||||||
}
|
}
|
||||||
}, [mapboxStyle, mapboxToken, mapbox3d]) // rebuild on style changes only
|
}, [glProvider, glStyle, mapboxToken, enableMapbox3d, mapboxQuality]) // rebuild on provider/style changes only
|
||||||
|
|
||||||
|
// Pin the basemap label language to the UI language so labels don't fall back to the
|
||||||
|
// browser/OS locale and stack multiple scripts per place (e.g. "India/भारत/India", #1299).
|
||||||
|
// Mapbox Standard exposes this via a basemap config property; classic and MapLibre styles
|
||||||
|
// are left as-is. Runs on load (mapReady) and whenever the UI language changes.
|
||||||
|
useEffect(() => {
|
||||||
|
const map = mapRef.current
|
||||||
|
if (!map || !mapReady || isMapLibre || !isStandardFamily(glStyle)) return
|
||||||
|
try { map.setConfigProperty('basemap', 'language', basemapLanguage(mapLang)) } catch { /* style/SDK may not support the basemap language property */ }
|
||||||
|
}, [mapLang, mapReady, isMapLibre, glStyle])
|
||||||
|
|
||||||
// Photo loading — mirrors the Leaflet MapView. Updates via RAF to batch
|
// Photo loading — mirrors the Leaflet MapView. Updates via RAF to batch
|
||||||
// simultaneous thumb arrivals into one re-render.
|
// simultaneous thumb arrivals into one re-render.
|
||||||
@@ -489,12 +521,12 @@ export function MapViewGL({
|
|||||||
// pitch. Tried `pitchAlignment: 'map'` to snap markers onto terrain,
|
// pitch. Tried `pitchAlignment: 'map'` to snap markers onto terrain,
|
||||||
// but it rotates the element by the pitch angle and visually offsets
|
// but it rotates the element by the pitch angle and visually offsets
|
||||||
// the anchor by ~100px at 45° tilt, which caused the observed drift.
|
// the anchor by ~100px at 45° tilt, which caused the observed drift.
|
||||||
const m = new mapboxgl.Marker({ element: el, anchor: 'center' })
|
const m = new gl.Marker({ element: el, anchor: 'center' })
|
||||||
.setLngLat([place.lng, place.lat])
|
.setLngLat([place.lng, place.lat])
|
||||||
.addTo(map)
|
.addTo(map)
|
||||||
markersRef.current.set(place.id, m)
|
markersRef.current.set(place.id, m)
|
||||||
})
|
})
|
||||||
}, [places, selectedPlaceId, dayOrderMap, photoUrls])
|
}, [places, selectedPlaceId, dayOrderMap, photoUrls, mapReady, glProvider])
|
||||||
|
|
||||||
// Reconcile OSM "explore" POI markers (imperative, kept separate from the
|
// Reconcile OSM "explore" POI markers (imperative, kept separate from the
|
||||||
// planned-place markers so they don't cluster or get confused with them).
|
// planned-place markers so they don't cluster or get confused with them).
|
||||||
@@ -511,10 +543,10 @@ export function MapViewGL({
|
|||||||
})
|
})
|
||||||
el.addEventListener('mouseleave', () => { popupRef.current?.remove() })
|
el.addEventListener('mouseleave', () => { popupRef.current?.remove() })
|
||||||
el.addEventListener('click', (ev) => { ev.stopPropagation(); onPoiClickRef.current?.(poi) })
|
el.addEventListener('click', (ev) => { ev.stopPropagation(); onPoiClickRef.current?.(poi) })
|
||||||
const m = new mapboxgl.Marker({ element: el, anchor: 'center' }).setLngLat([poi.lng, poi.lat]).addTo(map)
|
const m = new gl.Marker({ element: el, anchor: 'center' }).setLngLat([poi.lng, poi.lat]).addTo(map)
|
||||||
poiMarkersRef.current.push(m)
|
poiMarkersRef.current.push(m)
|
||||||
}
|
}
|
||||||
}, [pois, mapReady])
|
}, [pois, mapReady, glProvider])
|
||||||
|
|
||||||
// Update route geojson
|
// Update route geojson
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
@@ -578,7 +610,7 @@ export function MapViewGL({
|
|||||||
showStats: showReservationStats,
|
showStats: showReservationStats,
|
||||||
showEndpointLabels,
|
showEndpointLabels,
|
||||||
onEndpointClick: (id) => onReservationClickRef.current?.(id),
|
onEndpointClick: (id) => onReservationClickRef.current?.(id),
|
||||||
})
|
}, gl.Marker as any)
|
||||||
}
|
}
|
||||||
reservationOverlayRef.current.update(visibleReservations, {
|
reservationOverlayRef.current.update(visibleReservations, {
|
||||||
showConnections: true,
|
showConnections: true,
|
||||||
@@ -586,7 +618,7 @@ export function MapViewGL({
|
|||||||
showEndpointLabels,
|
showEndpointLabels,
|
||||||
onEndpointClick: (id) => onReservationClickRef.current?.(id),
|
onEndpointClick: (id) => onReservationClickRef.current?.(id),
|
||||||
})
|
})
|
||||||
}, [visibleReservations, showReservationStats, showEndpointLabels, mapReady])
|
}, [visibleReservations, showReservationStats, showEndpointLabels, mapReady, glProvider])
|
||||||
|
|
||||||
// Fit bounds on fitKey change — matches the Leaflet BoundsController
|
// Fit bounds on fitKey change — matches the Leaflet BoundsController
|
||||||
const paddingOpts = useMemo(() => {
|
const paddingOpts = useMemo(() => {
|
||||||
@@ -606,14 +638,14 @@ export function MapViewGL({
|
|||||||
const target = dayPlaces.length > 0 ? dayPlaces : places
|
const target = dayPlaces.length > 0 ? dayPlaces : places
|
||||||
const valid = target.filter(p => p.lat && p.lng)
|
const valid = target.filter(p => p.lat && p.lng)
|
||||||
if (valid.length === 0) return
|
if (valid.length === 0) return
|
||||||
const bounds = new mapboxgl.LngLatBounds()
|
const bounds = new gl.LngLatBounds()
|
||||||
valid.forEach(p => bounds.extend([p.lng, p.lat]))
|
valid.forEach(p => bounds.extend([p.lng, p.lat]))
|
||||||
const run = () => {
|
const run = () => {
|
||||||
try {
|
try {
|
||||||
map.fitBounds(bounds, {
|
map.fitBounds(bounds, {
|
||||||
padding: paddingOpts,
|
padding: paddingOpts,
|
||||||
maxZoom: 15,
|
maxZoom: 15,
|
||||||
pitch: mapbox3d ? 45 : 0,
|
pitch: enableMapbox3d ? 45 : 0,
|
||||||
duration: 400,
|
duration: 400,
|
||||||
})
|
})
|
||||||
} catch { /* noop */ }
|
} catch { /* noop */ }
|
||||||
@@ -632,7 +664,7 @@ export function MapViewGL({
|
|||||||
map.flyTo({
|
map.flyTo({
|
||||||
center: [target.lng, target.lat],
|
center: [target.lng, target.lat],
|
||||||
zoom: Math.max(map.getZoom(), 14),
|
zoom: Math.max(map.getZoom(), 14),
|
||||||
pitch: mapbox3d ? 45 : 0,
|
pitch: enableMapbox3d ? 45 : 0,
|
||||||
duration: 400,
|
duration: 400,
|
||||||
// Account for the side panels and the bottom inspector / day-detail panel
|
// Account for the side panels and the bottom inspector / day-detail panel
|
||||||
// so the selected pin lands in the centre of the *visible* map area rather
|
// so the selected pin lands in the centre of the *visible* map area rather
|
||||||
@@ -640,7 +672,7 @@ export function MapViewGL({
|
|||||||
padding: paddingOpts,
|
padding: paddingOpts,
|
||||||
})
|
})
|
||||||
} catch { /* noop */ }
|
} catch { /* noop */ }
|
||||||
}, [selectedPlaceId, mapbox3d]) // eslint-disable-line react-hooks/exhaustive-deps
|
}, [selectedPlaceId, enableMapbox3d]) // eslint-disable-line react-hooks/exhaustive-deps
|
||||||
|
|
||||||
// External center/zoom prop changes — jump without animation
|
// External center/zoom prop changes — jump without animation
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
@@ -663,7 +695,7 @@ export function MapViewGL({
|
|||||||
}
|
}
|
||||||
if (!userPosition) return
|
if (!userPosition) return
|
||||||
const apply = () => {
|
const apply = () => {
|
||||||
if (!locationMarkerRef.current) locationMarkerRef.current = attachLocationMarker(map)
|
if (!locationMarkerRef.current) locationMarkerRef.current = attachLocationMarker(map, gl.Marker as any)
|
||||||
locationMarkerRef.current.update(userPosition)
|
locationMarkerRef.current.update(userPosition)
|
||||||
if (trackingMode === 'follow') {
|
if (trackingMode === 'follow') {
|
||||||
// easeTo is gentler than flyTo for continuous updates
|
// easeTo is gentler than flyTo for continuous updates
|
||||||
@@ -679,9 +711,9 @@ export function MapViewGL({
|
|||||||
}
|
}
|
||||||
if (map.loaded()) apply()
|
if (map.loaded()) apply()
|
||||||
else map.once('load', apply)
|
else map.once('load', apply)
|
||||||
}, [userPosition, trackingMode])
|
}, [userPosition, trackingMode, glProvider])
|
||||||
|
|
||||||
if (!mapboxToken) {
|
if (!isMapLibre && !mapboxToken) {
|
||||||
return (
|
return (
|
||||||
<div className="w-full h-full flex items-center justify-center bg-zinc-100 dark:bg-zinc-800 text-center px-6">
|
<div className="w-full h-full flex items-center justify-center bg-zinc-100 dark:bg-zinc-800 text-center px-6">
|
||||||
<div className="text-sm text-zinc-500">
|
<div className="text-sm text-zinc-500">
|
||||||
|
|||||||
@@ -6,6 +6,7 @@ import {
|
|||||||
calculateSegments,
|
calculateSegments,
|
||||||
optimizeRoute,
|
optimizeRoute,
|
||||||
generateGoogleMapsUrl,
|
generateGoogleMapsUrl,
|
||||||
|
withHotelBookends,
|
||||||
} from './RouteCalculator'
|
} from './RouteCalculator'
|
||||||
|
|
||||||
const OSRM_BASE = 'https://router.project-osrm.org/route/v1'
|
const OSRM_BASE = 'https://router.project-osrm.org/route/v1'
|
||||||
@@ -241,3 +242,46 @@ describe('generateGoogleMapsUrl', () => {
|
|||||||
expect(result).toContain('48.86,2.36')
|
expect(result).toContain('48.86,2.36')
|
||||||
})
|
})
|
||||||
})
|
})
|
||||||
|
|
||||||
|
// ── withHotelBookends (#1275: draw the hotel → first / last → hotel legs) ────────
|
||||||
|
|
||||||
|
describe('withHotelBookends', () => {
|
||||||
|
const hotel = { lat: 1, lng: 1 }
|
||||||
|
const a = { lat: 2, lng: 2 }
|
||||||
|
const b = { lat: 3, lng: 3 }
|
||||||
|
const evening = { lat: 4, lng: 4 }
|
||||||
|
|
||||||
|
it('FE-COMP-ROUTECALCULATOR-021: leaves runs untouched when there is no hotel', () => {
|
||||||
|
const runs = [[a, b]]
|
||||||
|
expect(withHotelBookends(runs, a, b, null, null)).toEqual([[a, b]])
|
||||||
|
})
|
||||||
|
|
||||||
|
it('FE-COMP-ROUTECALCULATOR-022: prepends hotel→first and appends last→hotel around the runs', () => {
|
||||||
|
const runs = [[a, b]]
|
||||||
|
expect(withHotelBookends(runs, a, b, hotel, evening)).toEqual([
|
||||||
|
[hotel, a],
|
||||||
|
[a, b],
|
||||||
|
[b, evening],
|
||||||
|
])
|
||||||
|
})
|
||||||
|
|
||||||
|
it('FE-COMP-ROUTECALCULATOR-023: a single stop with no runs still draws hotel→stop→hotel', () => {
|
||||||
|
expect(withHotelBookends([], a, a, hotel, evening)).toEqual([
|
||||||
|
[hotel, a],
|
||||||
|
[a, evening],
|
||||||
|
])
|
||||||
|
})
|
||||||
|
|
||||||
|
it('FE-COMP-ROUTECALCULATOR-024: a missing first/last waypoint skips that bookend', () => {
|
||||||
|
const runs = [[a, b]]
|
||||||
|
expect(withHotelBookends(runs, undefined, undefined, hotel, evening)).toEqual([[a, b]])
|
||||||
|
})
|
||||||
|
|
||||||
|
it('FE-COMP-ROUTECALCULATOR-025: only the start hotel adds just the opening leg', () => {
|
||||||
|
const runs = [[a, b]]
|
||||||
|
expect(withHotelBookends(runs, a, b, hotel, null)).toEqual([
|
||||||
|
[hotel, a],
|
||||||
|
[a, b],
|
||||||
|
])
|
||||||
|
})
|
||||||
|
})
|
||||||
|
|||||||
@@ -1,4 +1,6 @@
|
|||||||
import type { RouteResult, RouteSegment, RouteWithLegs, Waypoint, RouteAnchors } from '../../types'
|
import { useSettingsStore } from '../../store/settingsStore'
|
||||||
|
import type { DistanceUnit, RouteResult, RouteSegment, RouteWithLegs, Waypoint, RouteAnchors } from '../../types'
|
||||||
|
import { formatDistance } from '../../utils/units'
|
||||||
|
|
||||||
const OSRM_BASE = 'https://router.project-osrm.org/route/v1'
|
const OSRM_BASE = 'https://router.project-osrm.org/route/v1'
|
||||||
|
|
||||||
@@ -60,13 +62,34 @@ export async function calculateRoute(
|
|||||||
coordinates,
|
coordinates,
|
||||||
distance,
|
distance,
|
||||||
duration,
|
duration,
|
||||||
distanceText: formatDistance(distance),
|
distanceText: formatRouteDistance(distance),
|
||||||
durationText: formatDuration(duration),
|
durationText: formatDuration(duration),
|
||||||
walkingText: formatDuration(walkingDuration),
|
walkingText: formatDuration(walkingDuration),
|
||||||
drivingText: formatDuration(drivingDuration),
|
drivingText: formatDuration(drivingDuration),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Prepends a hotel→first-waypoint run and appends a last-waypoint→hotel run to the
|
||||||
|
* day's activity runs, so the drawn route starts and ends at the day's accommodation
|
||||||
|
* (matching the sidebar's hotel connectors). A bookend is only added when both its
|
||||||
|
* hotel and the first/last located waypoint exist; passing nulls leaves `runs`
|
||||||
|
* untouched. The shared first/last waypoint is repeated so the polylines join.
|
||||||
|
*/
|
||||||
|
export function withHotelBookends(
|
||||||
|
runs: Waypoint[][],
|
||||||
|
firstWay: Waypoint | undefined,
|
||||||
|
lastWay: Waypoint | undefined,
|
||||||
|
startHotel: Waypoint | null,
|
||||||
|
endHotel: Waypoint | null,
|
||||||
|
): Waypoint[][] {
|
||||||
|
const out: Waypoint[][] = []
|
||||||
|
if (startHotel && firstWay) out.push([startHotel, firstWay])
|
||||||
|
out.push(...runs)
|
||||||
|
if (endHotel && lastWay) out.push([lastWay, endHotel])
|
||||||
|
return out
|
||||||
|
}
|
||||||
|
|
||||||
export function generateGoogleMapsUrl(places: Waypoint[]): string | null {
|
export function generateGoogleMapsUrl(places: Waypoint[]): string | null {
|
||||||
const valid = places.filter((p) => p.lat && p.lng)
|
const valid = places.filter((p) => p.lat && p.lng)
|
||||||
if (valid.length === 0) return null
|
if (valid.length === 0) return null
|
||||||
@@ -197,7 +220,7 @@ export async function calculateSegments(
|
|||||||
duration: leg.duration,
|
duration: leg.duration,
|
||||||
walkingText: formatDuration(walkingDuration),
|
walkingText: formatDuration(walkingDuration),
|
||||||
drivingText: formatDuration(leg.duration),
|
drivingText: formatDuration(leg.duration),
|
||||||
distanceText: formatDistance(leg.distance),
|
distanceText: formatRouteDistance(leg.distance),
|
||||||
}
|
}
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
@@ -217,7 +240,9 @@ export async function calculateRouteWithLegs(
|
|||||||
}
|
}
|
||||||
|
|
||||||
const coords = waypoints.map((p) => `${p.lng},${p.lat}`).join(';')
|
const coords = waypoints.map((p) => `${p.lng},${p.lat}`).join(';')
|
||||||
const cacheKey = `${profile}:${coords}`
|
// The cached result carries formatted leg distances, so the active distance unit is
|
||||||
|
// part of the key — otherwise switching km↔mi would return stale text (#1300).
|
||||||
|
const cacheKey = `${profile}:${getDistanceUnit()}:${coords}`
|
||||||
const cached = routeCache.get(cacheKey)
|
const cached = routeCache.get(cacheKey)
|
||||||
if (cached) return cached
|
if (cached) return cached
|
||||||
|
|
||||||
@@ -244,7 +269,7 @@ export async function calculateRouteWithLegs(
|
|||||||
duration: leg.duration,
|
duration: leg.duration,
|
||||||
walkingText: formatDuration(walkingDuration),
|
walkingText: formatDuration(walkingDuration),
|
||||||
drivingText: formatDuration(leg.duration),
|
drivingText: formatDuration(leg.duration),
|
||||||
distanceText: formatDistance(leg.distance),
|
distanceText: formatRouteDistance(leg.distance),
|
||||||
durationText: formatDuration(leg.duration),
|
durationText: formatDuration(leg.duration),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -259,11 +284,16 @@ export async function calculateRouteWithLegs(
|
|||||||
return result
|
return result
|
||||||
}
|
}
|
||||||
|
|
||||||
function formatDistance(meters: number): string {
|
function getDistanceUnit(): DistanceUnit {
|
||||||
if (meters < 1000) {
|
return useSettingsStore.getState().settings.distance_unit === 'imperial' ? 'imperial' : 'metric'
|
||||||
|
}
|
||||||
|
|
||||||
|
function formatRouteDistance(meters: number): string {
|
||||||
|
const unit = getDistanceUnit()
|
||||||
|
if (unit === 'metric' && meters < 1000) {
|
||||||
return `${Math.round(meters)} m`
|
return `${Math.round(meters)} m`
|
||||||
}
|
}
|
||||||
return `${(meters / 1000).toFixed(1)} km`
|
return formatDistance(meters / 1000, unit)
|
||||||
}
|
}
|
||||||
|
|
||||||
function formatDuration(seconds: number): string {
|
function formatDuration(seconds: number): string {
|
||||||
|
|||||||
@@ -0,0 +1,72 @@
|
|||||||
|
import { describe, expect, it } from 'vitest'
|
||||||
|
import {
|
||||||
|
MAPBOX_DEFAULT_STYLE,
|
||||||
|
OPENFREEMAP_DEFAULT_STYLE,
|
||||||
|
isOpenFreeMapStyle,
|
||||||
|
normalizeStyleForProvider,
|
||||||
|
styleForActiveProvider,
|
||||||
|
basemapLanguage,
|
||||||
|
} from './glProviders'
|
||||||
|
|
||||||
|
describe('glProviders', () => {
|
||||||
|
it('keeps OpenFreeMap styles for MapLibre', () => {
|
||||||
|
const style = 'https://tiles.openfreemap.org/styles/bright'
|
||||||
|
|
||||||
|
expect(normalizeStyleForProvider('maplibre-gl', style)).toBe(style)
|
||||||
|
})
|
||||||
|
|
||||||
|
it('falls back to OpenFreeMap for MapLibre styles outside the CSP allowlist', () => {
|
||||||
|
expect(normalizeStyleForProvider('maplibre-gl', 'https://demotiles.maplibre.org/style.json')).toBe(
|
||||||
|
OPENFREEMAP_DEFAULT_STYLE,
|
||||||
|
)
|
||||||
|
expect(normalizeStyleForProvider('maplibre-gl', MAPBOX_DEFAULT_STYLE)).toBe(OPENFREEMAP_DEFAULT_STYLE)
|
||||||
|
})
|
||||||
|
|
||||||
|
it('leaves Mapbox styles unchanged for Mapbox GL', () => {
|
||||||
|
expect(normalizeStyleForProvider('mapbox-gl', MAPBOX_DEFAULT_STYLE)).toBe(MAPBOX_DEFAULT_STYLE)
|
||||||
|
})
|
||||||
|
|
||||||
|
it('matches the OpenFreeMap CSP host', () => {
|
||||||
|
expect(isOpenFreeMapStyle('https://tiles.openfreemap.org/styles/liberty')).toBe(true)
|
||||||
|
expect(isOpenFreeMapStyle('https://demotiles.maplibre.org/style.json')).toBe(false)
|
||||||
|
})
|
||||||
|
|
||||||
|
it('rejects host/userinfo spoofing and http downgrade', () => {
|
||||||
|
expect(isOpenFreeMapStyle('https://tiles.openfreemap.org.evil.com/styles/x')).toBe(false)
|
||||||
|
expect(isOpenFreeMapStyle('https://evil.com/@tiles.openfreemap.org/styles/x')).toBe(false)
|
||||||
|
expect(isOpenFreeMapStyle('http://tiles.openfreemap.org/styles/liberty')).toBe(false)
|
||||||
|
expect(isOpenFreeMapStyle(' https://tiles.openfreemap.org/styles/liberty ')).toBe(true)
|
||||||
|
})
|
||||||
|
|
||||||
|
it('falls back to provider defaults for empty/whitespace styles', () => {
|
||||||
|
expect(normalizeStyleForProvider('maplibre-gl', '')).toBe(OPENFREEMAP_DEFAULT_STYLE)
|
||||||
|
expect(normalizeStyleForProvider('maplibre-gl', ' ')).toBe(OPENFREEMAP_DEFAULT_STYLE)
|
||||||
|
expect(normalizeStyleForProvider('mapbox-gl', '')).toBe(MAPBOX_DEFAULT_STYLE)
|
||||||
|
expect(normalizeStyleForProvider('mapbox-gl', null)).toBe(MAPBOX_DEFAULT_STYLE)
|
||||||
|
})
|
||||||
|
|
||||||
|
it('styleForActiveProvider reads each provider\'s own style slot', () => {
|
||||||
|
const mb = 'mapbox://styles/me/custom'
|
||||||
|
const ofm = 'https://tiles.openfreemap.org/styles/bright'
|
||||||
|
expect(styleForActiveProvider('mapbox-gl', mb, ofm)).toBe(mb)
|
||||||
|
expect(styleForActiveProvider('maplibre-gl', mb, ofm)).toBe(ofm)
|
||||||
|
// An empty MapLibre slot falls back to the OpenFreeMap default, leaving mapbox untouched.
|
||||||
|
expect(styleForActiveProvider('maplibre-gl', mb, '')).toBe(OPENFREEMAP_DEFAULT_STYLE)
|
||||||
|
})
|
||||||
|
|
||||||
|
it('basemapLanguage maps TREK UI codes to basemap label codes (#1299)', () => {
|
||||||
|
// Pass-through for plain ISO 639-1 codes.
|
||||||
|
expect(basemapLanguage('en')).toBe('en')
|
||||||
|
expect(basemapLanguage('de')).toBe('de')
|
||||||
|
expect(basemapLanguage('fr')).toBe('fr')
|
||||||
|
// TREK-specific overrides.
|
||||||
|
expect(basemapLanguage('br')).toBe('pt')
|
||||||
|
expect(basemapLanguage('gr')).toBe('el')
|
||||||
|
expect(basemapLanguage('zh')).toBe('zh-Hans')
|
||||||
|
expect(basemapLanguage('zhTw')).toBe('zh-Hant')
|
||||||
|
expect(basemapLanguage('zh-TW')).toBe('zh-Hant')
|
||||||
|
// Falls back to English when unset.
|
||||||
|
expect(basemapLanguage(undefined)).toBe('en')
|
||||||
|
expect(basemapLanguage('')).toBe('en')
|
||||||
|
})
|
||||||
|
})
|
||||||
@@ -0,0 +1,87 @@
|
|||||||
|
export type GlMapProvider = 'mapbox-gl' | 'maplibre-gl'
|
||||||
|
|
||||||
|
export interface GlStylePreset {
|
||||||
|
name: string
|
||||||
|
url: string
|
||||||
|
tags?: string[]
|
||||||
|
}
|
||||||
|
|
||||||
|
export const MAPBOX_DEFAULT_STYLE = 'mapbox://styles/mapbox/standard'
|
||||||
|
export const OPENFREEMAP_DEFAULT_STYLE = 'https://tiles.openfreemap.org/styles/liberty'
|
||||||
|
|
||||||
|
export const MAPBOX_STYLE_PRESETS: GlStylePreset[] = [
|
||||||
|
{ name: 'Mapbox Standard', url: MAPBOX_DEFAULT_STYLE, tags: ['3D', 'Apple-like'] },
|
||||||
|
{ name: 'Standard Satellite', url: 'mapbox://styles/mapbox/standard-satellite', tags: ['3D', 'Satellite'] },
|
||||||
|
{ name: 'Streets', url: 'mapbox://styles/mapbox/streets-v12', tags: ['3D', 'Classic'] },
|
||||||
|
{ name: 'Outdoors', url: 'mapbox://styles/mapbox/outdoors-v12', tags: ['3D', 'Terrain'] },
|
||||||
|
{ name: 'Light', url: 'mapbox://styles/mapbox/light-v11', tags: ['3D', 'Minimal'] },
|
||||||
|
{ name: 'Dark', url: 'mapbox://styles/mapbox/dark-v11', tags: ['3D', 'Dark'] },
|
||||||
|
{ name: 'Satellite', url: 'mapbox://styles/mapbox/satellite-v9', tags: ['3D', 'Satellite'] },
|
||||||
|
{ name: 'Satellite Streets', url: 'mapbox://styles/mapbox/satellite-streets-v12', tags: ['3D', 'Satellite'] },
|
||||||
|
{ name: 'Navigation Day', url: 'mapbox://styles/mapbox/navigation-day-v1', tags: ['3D', 'Apple-like'] },
|
||||||
|
{ name: 'Navigation Night', url: 'mapbox://styles/mapbox/navigation-night-v1', tags: ['3D', 'Dark'] },
|
||||||
|
]
|
||||||
|
|
||||||
|
export const OPENFREEMAP_STYLE_PRESETS: GlStylePreset[] = [
|
||||||
|
{ name: 'OpenFreeMap Liberty', url: OPENFREEMAP_DEFAULT_STYLE, tags: ['OpenFreeMap', '2D'] },
|
||||||
|
{ name: 'OpenFreeMap Bright', url: 'https://tiles.openfreemap.org/styles/bright', tags: ['OpenFreeMap', 'Classic'] },
|
||||||
|
{ name: 'OpenFreeMap Positron', url: 'https://tiles.openfreemap.org/styles/positron', tags: ['OpenFreeMap', 'Minimal'] },
|
||||||
|
]
|
||||||
|
|
||||||
|
export function getStylePresets(provider: GlMapProvider): GlStylePreset[] {
|
||||||
|
return provider === 'maplibre-gl' ? OPENFREEMAP_STYLE_PRESETS : MAPBOX_STYLE_PRESETS
|
||||||
|
}
|
||||||
|
|
||||||
|
export function defaultStyleForProvider(provider: GlMapProvider): string {
|
||||||
|
return provider === 'maplibre-gl' ? OPENFREEMAP_DEFAULT_STYLE : MAPBOX_DEFAULT_STYLE
|
||||||
|
}
|
||||||
|
|
||||||
|
export function isOpenFreeMapStyle(style?: string | null): boolean {
|
||||||
|
return (style || '').trim().startsWith('https://tiles.openfreemap.org/')
|
||||||
|
}
|
||||||
|
|
||||||
|
export function normalizeStyleForProvider(provider: GlMapProvider, style?: string | null): string {
|
||||||
|
const trimmed = (style || '').trim()
|
||||||
|
if (!trimmed) return defaultStyleForProvider(provider)
|
||||||
|
if (provider === 'maplibre-gl') {
|
||||||
|
return isOpenFreeMapStyle(trimmed) ? trimmed : OPENFREEMAP_DEFAULT_STYLE
|
||||||
|
}
|
||||||
|
return trimmed
|
||||||
|
}
|
||||||
|
|
||||||
|
/** The settings key that holds the style for a given GL provider. */
|
||||||
|
export function styleSettingKey(provider: GlMapProvider): 'mapbox_style' | 'maplibre_style' {
|
||||||
|
return provider === 'maplibre-gl' ? 'maplibre_style' : 'mapbox_style'
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Each GL provider keeps its style in its own slot (mapbox_style / maplibre_style), so
|
||||||
|
* switching providers never overwrites the other one's custom style. Picks and normalizes
|
||||||
|
* the style for the active provider.
|
||||||
|
*/
|
||||||
|
export function styleForActiveProvider(
|
||||||
|
provider: GlMapProvider,
|
||||||
|
mapboxStyle?: string | null,
|
||||||
|
maplibreStyle?: string | null,
|
||||||
|
): string {
|
||||||
|
return normalizeStyleForProvider(provider, provider === 'maplibre-gl' ? maplibreStyle : mapboxStyle)
|
||||||
|
}
|
||||||
|
|
||||||
|
// A few TREK UI language codes differ from what the GL basemap expects for its labels.
|
||||||
|
const BASEMAP_LANG_OVERRIDES: Record<string, string> = {
|
||||||
|
br: 'pt', // TREK 'br' = Brazilian Portuguese
|
||||||
|
gr: 'el', // TREK 'gr' = Greek
|
||||||
|
zh: 'zh-Hans',
|
||||||
|
zhTw: 'zh-Hant',
|
||||||
|
'zh-TW': 'zh-Hant',
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Maps a TREK UI language code to the label language the GL basemap expects. Used to pin
|
||||||
|
* Mapbox Standard's basemap labels to the user's language so they don't fall back to the
|
||||||
|
* browser/OS locale and stack multiple scripts per place (#1299).
|
||||||
|
*/
|
||||||
|
export function basemapLanguage(uiLang: string | undefined): string {
|
||||||
|
const code = (uiLang || 'en').trim()
|
||||||
|
return BASEMAP_LANG_OVERRIDES[code] ?? code
|
||||||
|
}
|
||||||
@@ -1,6 +1,13 @@
|
|||||||
import mapboxgl from 'mapbox-gl'
|
import type mapboxgl from 'mapbox-gl'
|
||||||
import type { GeoPosition } from '../../hooks/useGeolocation'
|
import type { GeoPosition } from '../../hooks/useGeolocation'
|
||||||
|
|
||||||
|
type MarkerConstructor = new (options?: { element?: HTMLElement; anchor?: string }) => {
|
||||||
|
setLngLat: (lngLat: mapboxgl.LngLatLike) => { addTo: (map: mapboxgl.Map) => unknown }
|
||||||
|
addTo: (map: mapboxgl.Map) => unknown
|
||||||
|
remove: () => void
|
||||||
|
getElement: () => HTMLElement
|
||||||
|
}
|
||||||
|
|
||||||
// Build the DOM element that backs the mapbox Marker. We animate the
|
// Build the DOM element that backs the mapbox Marker. We animate the
|
||||||
// heading cone via a CSS rotation so the DOM stays stable across updates
|
// heading cone via a CSS rotation so the DOM stays stable across updates
|
||||||
// and mapbox doesn't get confused about which element to position.
|
// and mapbox doesn't get confused about which element to position.
|
||||||
@@ -66,10 +73,10 @@ export interface LocationMarkerHandle {
|
|||||||
// mapbox map. Returns a handle the caller uses to push position updates
|
// mapbox map. Returns a handle the caller uses to push position updates
|
||||||
// and clean up. Keeps its own DOM element and GeoJSON source so it can
|
// and clean up. Keeps its own DOM element and GeoJSON source so it can
|
||||||
// coexist with the regular trip markers.
|
// coexist with the regular trip markers.
|
||||||
export function attachLocationMarker(map: mapboxgl.Map): LocationMarkerHandle {
|
export function attachLocationMarker(map: mapboxgl.Map, MarkerCtor: MarkerConstructor): LocationMarkerHandle {
|
||||||
ensurePulseStyle()
|
ensurePulseStyle()
|
||||||
const { root, cone } = buildLocationEl()
|
const { root, cone } = buildLocationEl()
|
||||||
const marker = new mapboxgl.Marker({ element: root, anchor: 'center' })
|
const marker = new MarkerCtor({ element: root, anchor: 'center' })
|
||||||
|
|
||||||
const ensureAccuracyLayer = () => {
|
const ensureAccuracyLayer = () => {
|
||||||
if (map.getSource('trek-location-accuracy')) return
|
if (map.getSource('trek-location-accuracy')) return
|
||||||
|
|||||||
@@ -8,7 +8,7 @@
|
|||||||
|
|
||||||
import { createElement } from 'react'
|
import { createElement } from 'react'
|
||||||
import { renderToStaticMarkup } from 'react-dom/server'
|
import { renderToStaticMarkup } from 'react-dom/server'
|
||||||
import mapboxgl from 'mapbox-gl'
|
import type mapboxgl from 'mapbox-gl'
|
||||||
import { Plane, Train, Ship, Car, Bus, Sailboat, Bike, CarTaxiFront, Route } from 'lucide-react'
|
import { Plane, Train, Ship, Car, Bus, Sailboat, Bike, CarTaxiFront, Route } from 'lucide-react'
|
||||||
import { escapeHtml } from '@trek/shared'
|
import { escapeHtml } from '@trek/shared'
|
||||||
import type { Reservation, ReservationEndpoint } from '../../types'
|
import type { Reservation, ReservationEndpoint } from '../../types'
|
||||||
@@ -220,18 +220,29 @@ export interface ReservationOverlayOptions {
|
|||||||
onEndpointClick?: (reservationId: number) => void
|
onEndpointClick?: (reservationId: number) => void
|
||||||
}
|
}
|
||||||
|
|
||||||
|
type GlMarker = {
|
||||||
|
setLngLat: (lngLat: mapboxgl.LngLatLike) => GlMarker
|
||||||
|
addTo: (map: mapboxgl.Map) => GlMarker
|
||||||
|
remove: () => void
|
||||||
|
getElement: () => HTMLElement
|
||||||
|
}
|
||||||
|
|
||||||
|
type MarkerConstructor = new (options?: { element?: HTMLElement; anchor?: string }) => GlMarker
|
||||||
|
|
||||||
export class ReservationMapboxOverlay {
|
export class ReservationMapboxOverlay {
|
||||||
private map: mapboxgl.Map
|
private map: mapboxgl.Map
|
||||||
private items: TransportItem[] = []
|
private items: TransportItem[] = []
|
||||||
private opts: ReservationOverlayOptions
|
private opts: ReservationOverlayOptions
|
||||||
private endpointMarkers: mapboxgl.Marker[] = []
|
private MarkerCtor: MarkerConstructor
|
||||||
private statsMarkers: { marker: mapboxgl.Marker; arc: [number, number][] }[] = []
|
private endpointMarkers: GlMarker[] = []
|
||||||
|
private statsMarkers: { marker: GlMarker; arc: [number, number][] }[] = []
|
||||||
private rerender: () => void
|
private rerender: () => void
|
||||||
private destroyed = false
|
private destroyed = false
|
||||||
|
|
||||||
constructor(map: mapboxgl.Map, opts: ReservationOverlayOptions) {
|
constructor(map: mapboxgl.Map, opts: ReservationOverlayOptions, MarkerCtor: MarkerConstructor) {
|
||||||
this.map = map
|
this.map = map
|
||||||
this.opts = opts
|
this.opts = opts
|
||||||
|
this.MarkerCtor = MarkerCtor
|
||||||
this.rerender = () => { if (!this.destroyed) this.render() }
|
this.rerender = () => { if (!this.destroyed) this.render() }
|
||||||
this.setupLayer()
|
this.setupLayer()
|
||||||
map.on('zoomend', this.rerender)
|
map.on('zoomend', this.rerender)
|
||||||
@@ -350,7 +361,7 @@ export class ReservationMapboxOverlay {
|
|||||||
this.opts.onEndpointClick?.(item.res.id)
|
this.opts.onEndpointClick?.(item.res.id)
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
const marker = new mapboxgl.Marker({ element: node, anchor: 'center' })
|
const marker = new this.MarkerCtor({ element: node, anchor: 'center' })
|
||||||
.setLngLat([ep.lng, ep.lat])
|
.setLngLat([ep.lng, ep.lat])
|
||||||
.addTo(map)
|
.addTo(map)
|
||||||
this.endpointMarkers.push(marker)
|
this.endpointMarkers.push(marker)
|
||||||
|
|||||||
@@ -84,6 +84,22 @@ const transportReservation = {
|
|||||||
metadata: JSON.stringify({ airline: 'Air Italia', flight_number: 'AI123', departure_airport: 'CDG', arrival_airport: 'FCO' }),
|
metadata: JSON.stringify({ airline: 'Air Italia', flight_number: 'AI123', departure_airport: 'CDG', arrival_airport: 'FCO' }),
|
||||||
} as any
|
} as any
|
||||||
|
|
||||||
|
const multiLegFlight = {
|
||||||
|
id: 401,
|
||||||
|
title: 'Flight to Tokyo',
|
||||||
|
type: 'flight',
|
||||||
|
day_id: 10,
|
||||||
|
reservation_time: '2025-06-01T08:00:00',
|
||||||
|
confirmation_number: 'XYZ789',
|
||||||
|
metadata: JSON.stringify({
|
||||||
|
legs: [
|
||||||
|
{ from: 'FRA', to: 'BER', airline: 'Lufthansa', flight_number: 'LH1' },
|
||||||
|
{ from: 'BER', to: 'HND', airline: 'Lufthansa', flight_number: 'LH2' },
|
||||||
|
],
|
||||||
|
departure_airport: 'FRA', arrival_airport: 'HND', airline: 'Lufthansa', flight_number: 'LH1',
|
||||||
|
}),
|
||||||
|
} as any
|
||||||
|
|
||||||
const richArgs = {
|
const richArgs = {
|
||||||
trip: { id: 10, title: 'Italy Trip', description: 'Summer adventure', cover_image: '/uploads/cover.jpg' } as any,
|
trip: { id: 10, title: 'Italy Trip', description: 'Summer adventure', cover_image: '/uploads/cover.jpg' } as any,
|
||||||
days: [dayWithPlaces],
|
days: [dayWithPlaces],
|
||||||
@@ -196,6 +212,16 @@ describe('downloadTripPDF', () => {
|
|||||||
const iframe = getIframe()
|
const iframe = getIframe()
|
||||||
expect(iframe!.srcdoc).toContain('Flight to Rome')
|
expect(iframe!.srcdoc).toContain('Flight to Rome')
|
||||||
expect(iframe!.srcdoc).toContain('ABC123')
|
expect(iframe!.srcdoc).toContain('ABC123')
|
||||||
|
// Single-leg flight keeps its full-route subtitle.
|
||||||
|
expect(iframe!.srcdoc).toContain('Air Italia · AI123 · CDG → FCO')
|
||||||
|
})
|
||||||
|
|
||||||
|
it('FE-COMP-TRIPPDF-013b: renders every flight number for a multi-leg flight', async () => {
|
||||||
|
await downloadTripPDF({ ...richArgs, reservations: [multiLegFlight] })
|
||||||
|
const iframe = getIframe()
|
||||||
|
// One subtitle line per leg, each with its own flight number and segment route.
|
||||||
|
expect(iframe!.srcdoc).toContain('Lufthansa · LH1 · FRA → BER')
|
||||||
|
expect(iframe!.srcdoc).toContain('Lufthansa · LH2 · BER → HND')
|
||||||
})
|
})
|
||||||
|
|
||||||
it('FE-COMP-TRIPPDF-014: renders cover image when trip has cover_image', async () => {
|
it('FE-COMP-TRIPPDF-014: renders cover image when trip has cover_image', async () => {
|
||||||
@@ -297,6 +323,28 @@ describe('downloadTripPDF', () => {
|
|||||||
expect(photoCalled).toBe(true)
|
expect(photoCalled).toBe(true)
|
||||||
})
|
})
|
||||||
|
|
||||||
|
it('FE-COMP-TRIPPDF-019b: fetches photos for OSM places via osm_id recovered from the places pool (#1130)', async () => {
|
||||||
|
let fetchedId: string | null = null
|
||||||
|
server.use(
|
||||||
|
http.get('/api/maps/place-photo/:placeId', ({ params }) => {
|
||||||
|
fetchedId = params.placeId as string
|
||||||
|
return HttpResponse.json({ photoUrl: 'https://example.com/osm.jpg' })
|
||||||
|
}),
|
||||||
|
)
|
||||||
|
// The assignment projection drops osm_id; the full place in `places` carries it.
|
||||||
|
const osmPlace = { ...placeWithDetails, id: 101, image_url: null, google_place_id: null, osm_id: 'node/240109189', lat: 41.89, lng: 12.49 }
|
||||||
|
const args = {
|
||||||
|
...richArgs,
|
||||||
|
places: [osmPlace],
|
||||||
|
assignments: {
|
||||||
|
'10': [{ ...assignmentForDay, id: 201, place_id: 101, place: { ...placeWithDetails, id: 101, image_url: null, google_place_id: null } }],
|
||||||
|
} as any,
|
||||||
|
}
|
||||||
|
await downloadTripPDF(args)
|
||||||
|
// osm_id is used as the photo key (not the coords fallback), proving the pool lookup works.
|
||||||
|
expect(fetchedId).toBe('node/240109189')
|
||||||
|
})
|
||||||
|
|
||||||
it('FE-COMP-TRIPPDF-020: renders empty day message when no items assigned', async () => {
|
it('FE-COMP-TRIPPDF-020: renders empty day message when no items assigned', async () => {
|
||||||
const args = {
|
const args = {
|
||||||
...minimalArgs,
|
...minimalArgs,
|
||||||
|
|||||||
@@ -6,6 +6,7 @@ import { accommodationsApi, mapsApi } from '../../api/client'
|
|||||||
import type { Trip, Day, Place, Category, AssignmentsMap, DayNote } from '../../types'
|
import type { Trip, Day, Place, Category, AssignmentsMap, DayNote } from '../../types'
|
||||||
import { isDayInAccommodationRange, getDayOrder } from '../../utils/dayOrder'
|
import { isDayInAccommodationRange, getDayOrder } from '../../utils/dayOrder'
|
||||||
import { splitReservationDateTime } from '../../utils/formatters'
|
import { splitReservationDateTime } from '../../utils/formatters'
|
||||||
|
import { getFlightLegs } from '../../utils/flightLegs'
|
||||||
|
|
||||||
function renderLucideIcon(icon:LucideIcon, props = {}) {
|
function renderLucideIcon(icon:LucideIcon, props = {}) {
|
||||||
if (!_renderToStaticMarkup) return ''
|
if (!_renderToStaticMarkup) return ''
|
||||||
@@ -96,21 +97,29 @@ function dayCost(assignments, dayId, locale) {
|
|||||||
return total > 0 ? `${total.toLocaleString(locale)} EUR` : null
|
return total > 0 ? `${total.toLocaleString(locale)} EUR` : null
|
||||||
}
|
}
|
||||||
|
|
||||||
// Pre-fetch Google Place photos for all assigned places
|
// Pre-fetch place photos for all assigned places.
|
||||||
async function fetchPlacePhotos(assignments: AssignmentsMap) {
|
// Assignment places are a server-side projection that drops osm_id, so we recover
|
||||||
|
// the full place from the trip's places pool and key the photo off the same id the
|
||||||
|
// app UI uses (google_place_id || osm_id || coords) — otherwise OSM/coords-only
|
||||||
|
// places fell back to category icons in the PDF even though they show photos in-app.
|
||||||
|
async function fetchPlacePhotos(assignments: AssignmentsMap, places: Place[]) {
|
||||||
const photoMap = {} // placeId → photoUrl
|
const photoMap = {} // placeId → photoUrl
|
||||||
|
// The assignment projection drops osm_id, so recover it from the full places pool.
|
||||||
|
const osmById = new Map((places || []).map(p => [p.id, p.osm_id]))
|
||||||
const allPlaces = Object.values(assignments).flatMap(a => a.map(x => x.place)).filter(Boolean)
|
const allPlaces = Object.values(assignments).flatMap(a => a.map(x => x.place)).filter(Boolean)
|
||||||
const unique = [...new Map(allPlaces.map(p => [p.id, p])).values()]
|
const unique = [...new Map(allPlaces.map(p => [p.id, p])).values()]
|
||||||
|
|
||||||
// Assignment places are a server-side projection that omits osm_id, so photo
|
const toFetch = unique
|
||||||
// pre-fetch keys off the google_place_id that the projection does carry.
|
.map(p => ({ p, osm_id: osmById.get(p.id) }))
|
||||||
const toFetch = unique.filter(p => !p.image_url && p.google_place_id)
|
.filter(({ p, osm_id }) => !p.image_url && (p.google_place_id || osm_id || (p.lat != null && p.lng != null)))
|
||||||
|
|
||||||
await Promise.allSettled(
|
await Promise.allSettled(
|
||||||
toFetch.map(async (place) => {
|
toFetch.map(async ({ p, osm_id }) => {
|
||||||
|
// Same key the app UI uses: google_place_id || osm_id || coords.
|
||||||
|
const photoId = p.google_place_id || osm_id || `coords:${p.lat}:${p.lng}`
|
||||||
try {
|
try {
|
||||||
const data = await mapsApi.placePhoto(place.google_place_id, place.lat, place.lng, place.name)
|
const data = await mapsApi.placePhoto(photoId, p.lat, p.lng, p.name)
|
||||||
if (data.photoUrl) photoMap[place.id] = data.photoUrl
|
if (data.photoUrl) photoMap[p.id] = data.photoUrl
|
||||||
} catch {}
|
} catch {}
|
||||||
})
|
})
|
||||||
)
|
)
|
||||||
@@ -140,8 +149,8 @@ export async function downloadTripPDF({ trip, days, places, assignments, categor
|
|||||||
//retrieve accommodations for the trip to display on the day sections and prefetch their photos if needed
|
//retrieve accommodations for the trip to display on the day sections and prefetch their photos if needed
|
||||||
const accommodations = await accommodationsApi.list(trip.id);
|
const accommodations = await accommodationsApi.list(trip.id);
|
||||||
|
|
||||||
// Pre-fetch place photos from Google
|
// Pre-fetch place photos (Google, OSM and coords-only places)
|
||||||
const photoMap = await fetchPlacePhotos(assignments)
|
const photoMap = await fetchPlacePhotos(assignments, places)
|
||||||
|
|
||||||
const totalAssigned = new Set(
|
const totalAssigned = new Set(
|
||||||
Object.values(assignments || {}).flatMap(a => a.map(x => x.place?.id)).filter(Boolean)
|
Object.values(assignments || {}).flatMap(a => a.map(x => x.place?.id)).filter(Boolean)
|
||||||
@@ -215,17 +224,30 @@ export async function downloadTripPDF({ trip, days, places, assignments, categor
|
|||||||
const icon = reservationIconSvg(r.type)
|
const icon = reservationIconSvg(r.type)
|
||||||
const color = RESERVATION_COLOR_MAP[r.type] || '#3b82f6'
|
const color = RESERVATION_COLOR_MAP[r.type] || '#3b82f6'
|
||||||
let subtitle = ''
|
let subtitle = ''
|
||||||
|
// Flights render one subtitle line per leg (see below); everything else is a single line.
|
||||||
|
let subtitleLines: string[] = []
|
||||||
if (r.type === 'flight') {
|
if (r.type === 'flight') {
|
||||||
// Full route over all waypoints (FRA → BER → HND), falling back to the
|
const legs = getFlightLegs(r)
|
||||||
// flat metadata pair for legacy single-leg flights without endpoints.
|
if (legs.length > 1) {
|
||||||
const stops = (r.endpoints || []).slice().sort((a, b) => (a.sequence ?? 0) - (b.sequence ?? 0)).map(e => e.code || e.name)
|
// Multi-leg: one line per leg so every flight number + segment route is shown.
|
||||||
const route = stops.length >= 2 ? stops.join(' → ') : (meta.departure_airport && meta.arrival_airport ? `${meta.departure_airport} → ${meta.arrival_airport}` : '')
|
subtitleLines = legs.map(l =>
|
||||||
subtitle = [meta.airline, meta.flight_number, route].filter(Boolean).join(' · ')
|
[l.airline, l.flight_number,
|
||||||
|
(l.from || l.to) ? [l.from, l.to].filter(Boolean).join(' → ') : '']
|
||||||
|
.filter(Boolean).join(' · '))
|
||||||
|
.filter(Boolean)
|
||||||
|
} else {
|
||||||
|
// Single-leg: full route over all waypoints (FRA → BER → HND), falling back to the
|
||||||
|
// flat metadata pair for legacy single-leg flights without endpoints.
|
||||||
|
const stops = (r.endpoints || []).slice().sort((a, b) => (a.sequence ?? 0) - (b.sequence ?? 0)).map(e => e.code || e.name)
|
||||||
|
const route = stops.length >= 2 ? stops.join(' → ') : (meta.departure_airport && meta.arrival_airport ? `${meta.departure_airport} → ${meta.arrival_airport}` : '')
|
||||||
|
subtitle = [meta.airline, meta.flight_number, route].filter(Boolean).join(' · ')
|
||||||
|
}
|
||||||
}
|
}
|
||||||
else if (r.type === 'train') subtitle = [meta.train_number, meta.platform ? `Gl. ${meta.platform}` : '', meta.seat ? `Seat ${meta.seat}` : ''].filter(Boolean).join(' · ')
|
else if (r.type === 'train') subtitle = [meta.train_number, meta.platform ? `Gl. ${meta.platform}` : '', meta.seat ? `Seat ${meta.seat}` : ''].filter(Boolean).join(' · ')
|
||||||
else if (r.type === 'restaurant') subtitle = [meta.party_size ? `${meta.party_size} guests` : ''].filter(Boolean).join(' · ')
|
else if (r.type === 'restaurant') subtitle = [meta.party_size ? `${meta.party_size} guests` : ''].filter(Boolean).join(' · ')
|
||||||
else if (r.type === 'event') subtitle = [meta.venue].filter(Boolean).join(' · ')
|
else if (r.type === 'event') subtitle = [meta.venue].filter(Boolean).join(' · ')
|
||||||
else if (r.type === 'tour') subtitle = [meta.operator].filter(Boolean).join(' · ')
|
else if (r.type === 'tour') subtitle = [meta.operator].filter(Boolean).join(' · ')
|
||||||
|
if (subtitleLines.length === 0 && subtitle) subtitleLines = [subtitle]
|
||||||
const locationLine = r.location || meta.location || ''
|
const locationLine = r.location || meta.location || ''
|
||||||
const phase = pdfGetSpanPhase(r, day.id)
|
const phase = pdfGetSpanPhase(r, day.id)
|
||||||
const spanLabel = pdfGetSpanLabel(r, phase)
|
const spanLabel = pdfGetSpanLabel(r, phase)
|
||||||
@@ -238,7 +260,7 @@ export async function downloadTripPDF({ trip, days, places, assignments, categor
|
|||||||
<span class="note-icon">${icon}</span>
|
<span class="note-icon">${icon}</span>
|
||||||
<div class="note-body">
|
<div class="note-body">
|
||||||
<div class="note-text" style="font-weight: 600;">${titleHtml}${time ? ` <span style="color:#6b7280;font-weight:400;font-size:10px;">${time}</span>` : ''}</div>
|
<div class="note-text" style="font-weight: 600;">${titleHtml}${time ? ` <span style="color:#6b7280;font-weight:400;font-size:10px;">${time}</span>` : ''}</div>
|
||||||
${subtitle ? `<div class="note-time">${escHtml(subtitle)}</div>` : ''}
|
${subtitleLines.filter(Boolean).map(s => `<div class="note-time">${escHtml(s)}</div>`).join('')}
|
||||||
${locationLine ? `<div class="note-time">${escHtml(locationLine)}</div>` : ''}
|
${locationLine ? `<div class="note-time">${escHtml(locationLine)}</div>` : ''}
|
||||||
${r.confirmation_number ? `<div class="note-time" style="font-size:9px;">Code: ${escHtml(r.confirmation_number)}</div>` : ''}
|
${r.confirmation_number ? `<div class="note-time" style="font-size:9px;">Code: ${escHtml(r.confirmation_number)}</div>` : ''}
|
||||||
</div>
|
</div>
|
||||||
|
|||||||
@@ -174,7 +174,9 @@ describe('PackingListPanel', () => {
|
|||||||
|
|
||||||
it('FE-COMP-PACKING-016: delete item button exists and triggers API call', async () => {
|
it('FE-COMP-PACKING-016: delete item button exists and triggers API call', async () => {
|
||||||
const user = userEvent.setup();
|
const user = userEvent.setup();
|
||||||
const item = buildPackingItem({ id: 99, name: 'To Remove', category: 'Test' });
|
// Uncategorized item: deleting it is a plain DELETE (a custom category's last
|
||||||
|
// item is instead converted to a placeholder — see FE-COMP-PACKING-070).
|
||||||
|
const item = buildPackingItem({ id: 99, name: 'To Remove', category: null });
|
||||||
let deleteCalled = false;
|
let deleteCalled = false;
|
||||||
server.use(
|
server.use(
|
||||||
http.delete('/api/trips/1/packing/99', () => {
|
http.delete('/api/trips/1/packing/99', () => {
|
||||||
@@ -1415,4 +1417,83 @@ describe('PackingListPanel', () => {
|
|||||||
expect(clickSpy).toHaveBeenCalled();
|
expect(clickSpy).toHaveBeenCalled();
|
||||||
clickSpy.mockRestore();
|
clickSpy.mockRestore();
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it('FE-COMP-PACKING-070: deleting the last item of a custom category converts the row to a placeholder so the category persists in place (#1289)', async () => {
|
||||||
|
const user = userEvent.setup();
|
||||||
|
const item = buildPackingItem({ id: 99, name: 'Tent', category: 'Camping Gear' });
|
||||||
|
// handleDeleteItem decides "last in category" from the rendered list.
|
||||||
|
seedStore(useTripStore, { packingItems: [item] });
|
||||||
|
let deleted = false;
|
||||||
|
let putBody: Record<string, unknown> | null = null;
|
||||||
|
server.use(
|
||||||
|
http.delete('/api/trips/1/packing/99', () => {
|
||||||
|
deleted = true;
|
||||||
|
return HttpResponse.json({ success: true });
|
||||||
|
}),
|
||||||
|
http.put('/api/trips/1/packing/99', async ({ request }) => {
|
||||||
|
putBody = await request.json() as Record<string, unknown>;
|
||||||
|
return HttpResponse.json({ item: buildPackingItem({ id: 99, name: '...', category: 'Camping Gear' }) });
|
||||||
|
})
|
||||||
|
);
|
||||||
|
render(<PackingListPanel tripId={1} items={[item]} />);
|
||||||
|
|
||||||
|
await user.click(screen.getByTitle('Delete'));
|
||||||
|
|
||||||
|
// The row is updated in place (same id) rather than deleted, so colour/position hold.
|
||||||
|
await waitFor(() => expect(putBody).toMatchObject({ name: '...' }));
|
||||||
|
expect(deleted).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('FE-COMP-PACKING-071: deleting the placeholder row deletes it, dismissing the empty category (#1289)', async () => {
|
||||||
|
const user = userEvent.setup();
|
||||||
|
const placeholder = buildPackingItem({ id: 5, name: '...', category: 'Camping Gear' });
|
||||||
|
seedStore(useTripStore, { packingItems: [placeholder] });
|
||||||
|
let deleted = false;
|
||||||
|
let converted = false;
|
||||||
|
server.use(
|
||||||
|
http.delete('/api/trips/1/packing/5', () => {
|
||||||
|
deleted = true;
|
||||||
|
return HttpResponse.json({ success: true });
|
||||||
|
}),
|
||||||
|
http.put('/api/trips/1/packing/5', () => {
|
||||||
|
converted = true;
|
||||||
|
return HttpResponse.json({ item: placeholder });
|
||||||
|
})
|
||||||
|
);
|
||||||
|
render(<PackingListPanel tripId={1} items={[placeholder]} />);
|
||||||
|
|
||||||
|
await user.click(screen.getByTitle('Delete'));
|
||||||
|
|
||||||
|
await waitFor(() => expect(deleted).toBe(true));
|
||||||
|
// It is the placeholder itself — it must be removed, not re-converted.
|
||||||
|
expect(converted).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('FE-COMP-PACKING-072: adding an item to an empty category reuses the placeholder row instead of appending (#1289)', async () => {
|
||||||
|
const user = userEvent.setup();
|
||||||
|
const placeholder = buildPackingItem({ id: 5, name: '...', category: 'Camping Gear' });
|
||||||
|
seedStore(useTripStore, { packingItems: [placeholder] });
|
||||||
|
let posted = false;
|
||||||
|
let putBody: Record<string, unknown> | null = null;
|
||||||
|
server.use(
|
||||||
|
http.post('/api/trips/1/packing', () => {
|
||||||
|
posted = true;
|
||||||
|
return HttpResponse.json({ item: buildPackingItem({ id: 6 }) });
|
||||||
|
}),
|
||||||
|
http.put('/api/trips/1/packing/5', async ({ request }) => {
|
||||||
|
putBody = await request.json() as Record<string, unknown>;
|
||||||
|
return HttpResponse.json({ item: buildPackingItem({ id: 5, name: 'Tent', category: 'Camping Gear' }) });
|
||||||
|
})
|
||||||
|
);
|
||||||
|
render(<PackingListPanel tripId={1} items={[placeholder]} />);
|
||||||
|
|
||||||
|
// Open the category's inline "Add item" and add a real entry.
|
||||||
|
await user.click(screen.getByText('Add item'));
|
||||||
|
const input = await screen.findByPlaceholderText('Item name...');
|
||||||
|
await user.type(input, 'Tent');
|
||||||
|
await user.keyboard('{Enter}');
|
||||||
|
|
||||||
|
await waitFor(() => expect(putBody).toMatchObject({ name: 'Tent' }));
|
||||||
|
expect(posted).toBe(false);
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -18,6 +18,7 @@ interface KategorieGruppeProps {
|
|||||||
allCategories: string[]
|
allCategories: string[]
|
||||||
onRename: (oldName: string, newName: string) => Promise<void>
|
onRename: (oldName: string, newName: string) => Promise<void>
|
||||||
onDeleteAll: (items: PackingItem[]) => Promise<void>
|
onDeleteAll: (items: PackingItem[]) => Promise<void>
|
||||||
|
onDeleteItem: (item: PackingItem) => Promise<void>
|
||||||
onAddItem: (category: string, name: string) => Promise<void>
|
onAddItem: (category: string, name: string) => Promise<void>
|
||||||
assignees: CategoryAssignee[]
|
assignees: CategoryAssignee[]
|
||||||
tripMembers: TripMember[]
|
tripMembers: TripMember[]
|
||||||
@@ -28,7 +29,7 @@ interface KategorieGruppeProps {
|
|||||||
canEdit?: boolean
|
canEdit?: boolean
|
||||||
}
|
}
|
||||||
|
|
||||||
export function KategorieGruppe({ kategorie, items, tripId, allCategories, onRename, onDeleteAll, onAddItem, assignees, tripMembers, onSetAssignees, bagTrackingEnabled, bags, onCreateBag, canEdit = true }: KategorieGruppeProps) {
|
export function KategorieGruppe({ kategorie, items, tripId, allCategories, onRename, onDeleteAll, onDeleteItem, onAddItem, assignees, tripMembers, onSetAssignees, bagTrackingEnabled, bags, onCreateBag, canEdit = true }: KategorieGruppeProps) {
|
||||||
const [offen, setOffen] = useState(true)
|
const [offen, setOffen] = useState(true)
|
||||||
const [editingName, setEditingName] = useState(false)
|
const [editingName, setEditingName] = useState(false)
|
||||||
const [editKatName, setEditKatName] = useState(kategorie)
|
const [editKatName, setEditKatName] = useState(kategorie)
|
||||||
@@ -231,7 +232,7 @@ export function KategorieGruppe({ kategorie, items, tripId, allCategories, onRen
|
|||||||
{offen && (
|
{offen && (
|
||||||
<div style={{ padding: '4px 4px 6px' }}>
|
<div style={{ padding: '4px 4px 6px' }}>
|
||||||
{items.map(item => (
|
{items.map(item => (
|
||||||
<ArtikelZeile key={item.id} item={item} tripId={tripId} categories={allCategories} onCategoryChange={() => {}} bagTrackingEnabled={bagTrackingEnabled} bags={bags} onCreateBag={onCreateBag} canEdit={canEdit} />
|
<ArtikelZeile key={item.id} item={item} tripId={tripId} categories={allCategories} onCategoryChange={() => {}} onDelete={onDeleteItem} bagTrackingEnabled={bagTrackingEnabled} bags={bags} onCreateBag={onCreateBag} canEdit={canEdit} />
|
||||||
))}
|
))}
|
||||||
{/* Inline add item */}
|
{/* Inline add item */}
|
||||||
{canEdit && (showAddItem ? (
|
{canEdit && (showAddItem ? (
|
||||||
|
|||||||
@@ -15,13 +15,14 @@ interface ArtikelZeileProps {
|
|||||||
tripId: number
|
tripId: number
|
||||||
categories: string[]
|
categories: string[]
|
||||||
onCategoryChange: () => void
|
onCategoryChange: () => void
|
||||||
|
onDelete?: (item: PackingItem) => Promise<void>
|
||||||
bagTrackingEnabled?: boolean
|
bagTrackingEnabled?: boolean
|
||||||
bags?: PackingBag[]
|
bags?: PackingBag[]
|
||||||
onCreateBag: (name: string) => Promise<PackingBag | undefined>
|
onCreateBag: (name: string) => Promise<PackingBag | undefined>
|
||||||
canEdit?: boolean
|
canEdit?: boolean
|
||||||
}
|
}
|
||||||
|
|
||||||
export function ArtikelZeile({ item, tripId, categories, onCategoryChange, bagTrackingEnabled, bags = [], onCreateBag, canEdit = true }: ArtikelZeileProps) {
|
export function ArtikelZeile({ item, tripId, categories, onCategoryChange, onDelete, bagTrackingEnabled, bags = [], onCreateBag, canEdit = true }: ArtikelZeileProps) {
|
||||||
const isPlaceholder = item.name === PACKING_PLACEHOLDER_NAME
|
const isPlaceholder = item.name === PACKING_PLACEHOLDER_NAME
|
||||||
const [editing, setEditing] = useState(false)
|
const [editing, setEditing] = useState(false)
|
||||||
const [editName, setEditName] = useState(isPlaceholder ? '' : item.name)
|
const [editName, setEditName] = useState(isPlaceholder ? '' : item.name)
|
||||||
@@ -43,6 +44,9 @@ export function ArtikelZeile({ item, tripId, categories, onCategoryChange, bagTr
|
|||||||
}
|
}
|
||||||
|
|
||||||
const handleDelete = async () => {
|
const handleDelete = async () => {
|
||||||
|
// The panel routes deletion through onDelete so an emptied custom category
|
||||||
|
// keeps its placeholder; fall back to a plain delete when used standalone.
|
||||||
|
if (onDelete) { await onDelete(item); return }
|
||||||
try { await deletePackingItem(tripId, item.id) }
|
try { await deletePackingItem(tripId, item.id) }
|
||||||
catch { toast.error(t('packing.toast.deleteError')) }
|
catch { toast.error(t('packing.toast.deleteError')) }
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -4,7 +4,7 @@ import { KategorieGruppe } from './PackingListPanelCategoryGroup'
|
|||||||
|
|
||||||
export function PackingList(S: PackingState) {
|
export function PackingList(S: PackingState) {
|
||||||
const {
|
const {
|
||||||
items, gruppiert, t, tripId, allCategories, handleRenameCategory, handleDeleteCategory,
|
items, gruppiert, t, tripId, allCategories, handleRenameCategory, handleDeleteCategory, handleDeleteItem,
|
||||||
handleAddItemToCategory, categoryAssignees, tripMembers, handleSetAssignees,
|
handleAddItemToCategory, categoryAssignees, tripMembers, handleSetAssignees,
|
||||||
bagTrackingEnabled, bags, handleCreateBagByName, canEdit,
|
bagTrackingEnabled, bags, handleCreateBagByName, canEdit,
|
||||||
} = S
|
} = S
|
||||||
@@ -31,6 +31,7 @@ export function PackingList(S: PackingState) {
|
|||||||
allCategories={allCategories}
|
allCategories={allCategories}
|
||||||
onRename={handleRenameCategory}
|
onRename={handleRenameCategory}
|
||||||
onDeleteAll={handleDeleteCategory}
|
onDeleteAll={handleDeleteCategory}
|
||||||
|
onDeleteItem={handleDeleteItem}
|
||||||
onAddItem={handleAddItemToCategory}
|
onAddItem={handleAddItemToCategory}
|
||||||
assignees={categoryAssignees[kat] || []}
|
assignees={categoryAssignees[kat] || []}
|
||||||
tripMembers={tripMembers}
|
tripMembers={tripMembers}
|
||||||
|
|||||||
@@ -8,7 +8,7 @@ import { useTranslation } from '../../i18n'
|
|||||||
import { packingApi, tripsApi } from '../../api/client'
|
import { packingApi, tripsApi } from '../../api/client'
|
||||||
import { useAddonStore } from '../../store/addonStore'
|
import { useAddonStore } from '../../store/addonStore'
|
||||||
import type { PackingItem, PackingBag } from '../../types'
|
import type { PackingItem, PackingBag } from '../../types'
|
||||||
import { BAG_COLORS } from './packingListPanel.constants'
|
import { BAG_COLORS, PACKING_PLACEHOLDER_NAME } from './packingListPanel.constants'
|
||||||
import { parseImportLines } from './packingListPanel.helpers'
|
import { parseImportLines } from './packingListPanel.helpers'
|
||||||
|
|
||||||
export interface TripMember {
|
export interface TripMember {
|
||||||
@@ -44,7 +44,7 @@ export function usePackingList({ tripId, items, openImportSignal = 0, clearCheck
|
|||||||
const [filter, setFilter] = useState('alle') // 'alle' | 'offen' | 'erledigt'
|
const [filter, setFilter] = useState('alle') // 'alle' | 'offen' | 'erledigt'
|
||||||
const [addingCategory, setAddingCategory] = useState(false)
|
const [addingCategory, setAddingCategory] = useState(false)
|
||||||
const [newCatName, setNewCatName] = useState('')
|
const [newCatName, setNewCatName] = useState('')
|
||||||
const { addPackingItem, updatePackingItem, deletePackingItem } = useTripStore()
|
const { addPackingItem, updatePackingItem, deletePackingItem, togglePackingItem } = useTripStore()
|
||||||
const can = useCanDo()
|
const can = useCanDo()
|
||||||
const trip = useTripStore((s) => s.trip)
|
const trip = useTripStore((s) => s.trip)
|
||||||
const canEdit = can('packing_edit', trip)
|
const canEdit = can('packing_edit', trip)
|
||||||
@@ -106,10 +106,45 @@ export function usePackingList({ tripId, items, openImportSignal = 0, clearCheck
|
|||||||
|
|
||||||
const handleAddItemToCategory = async (category: string, name: string) => {
|
const handleAddItemToCategory = async (category: string, name: string) => {
|
||||||
try {
|
try {
|
||||||
await addPackingItem(tripId, { name, category })
|
// Reuse the '...' placeholder slot when the category already has one, so a
|
||||||
|
// freshly-emptied category keeps its position (and therefore its colour)
|
||||||
|
// instead of the new item being appended to the end of the list.
|
||||||
|
const placeholder = useTripStore.getState().packingItems.find(
|
||||||
|
i => i.category === category && i.name === PACKING_PLACEHOLDER_NAME
|
||||||
|
)
|
||||||
|
if (placeholder) {
|
||||||
|
await updatePackingItem(tripId, placeholder.id, { name })
|
||||||
|
} else {
|
||||||
|
await addPackingItem(tripId, { name, category })
|
||||||
|
}
|
||||||
} catch { toast.error(t('packing.toast.addError')) }
|
} catch { toast.error(t('packing.toast.addError')) }
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Deleting an item from a row. When it is the last item of a user-created
|
||||||
|
// category, turn that row back into the '...' placeholder in place rather than
|
||||||
|
// deleting it (#1289). Updating the row keeps its id, list position and colour,
|
||||||
|
// so the category neither disappears nor jumps to the end. The default
|
||||||
|
// (uncategorized) group and the placeholder row itself are deleted normally —
|
||||||
|
// removing the placeholder is how an empty category is dismissed.
|
||||||
|
const handleDeleteItem = async (item: PackingItem) => {
|
||||||
|
const category = item.category
|
||||||
|
const isLastInCategory = !!category
|
||||||
|
&& item.name !== PACKING_PLACEHOLDER_NAME
|
||||||
|
&& !items.some(i => i.id !== item.id && i.category === category)
|
||||||
|
try {
|
||||||
|
if (isLastInCategory) {
|
||||||
|
if (item.checked) await togglePackingItem(tripId, item.id, false)
|
||||||
|
await updatePackingItem(tripId, item.id, {
|
||||||
|
name: PACKING_PLACEHOLDER_NAME, weight_grams: null, bag_id: null, quantity: 1,
|
||||||
|
})
|
||||||
|
} else {
|
||||||
|
await deletePackingItem(tripId, item.id)
|
||||||
|
}
|
||||||
|
} catch {
|
||||||
|
toast.error(t('packing.toast.deleteError'))
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
const handleAddNewCategory = async () => {
|
const handleAddNewCategory = async () => {
|
||||||
if (!newCatName.trim()) return
|
if (!newCatName.trim()) return
|
||||||
let catName = newCatName.trim()
|
let catName = newCatName.trim()
|
||||||
@@ -308,7 +343,7 @@ export function usePackingList({ tripId, items, openImportSignal = 0, clearCheck
|
|||||||
tripId, items, inlineHeader, t, canEdit, isAdmin, font,
|
tripId, items, inlineHeader, t, canEdit, isAdmin, font,
|
||||||
filter, setFilter, addingCategory, setAddingCategory, newCatName, setNewCatName,
|
filter, setFilter, addingCategory, setAddingCategory, newCatName, setNewCatName,
|
||||||
tripMembers, categoryAssignees, handleSetAssignees, allCategories, gruppiert, abgehakt, fortschritt,
|
tripMembers, categoryAssignees, handleSetAssignees, allCategories, gruppiert, abgehakt, fortschritt,
|
||||||
handleAddItemToCategory, handleAddNewCategory, handleRenameCategory, handleDeleteCategory, handleClearChecked,
|
handleAddItemToCategory, handleAddNewCategory, handleRenameCategory, handleDeleteCategory, handleDeleteItem, handleClearChecked,
|
||||||
bagTrackingEnabled, bags, newBagName, setNewBagName, showAddBag, setShowAddBag, showBagModal, setShowBagModal,
|
bagTrackingEnabled, bags, newBagName, setNewBagName, showAddBag, setShowAddBag, showBagModal, setShowBagModal,
|
||||||
handleCreateBag, handleCreateBagByName, handleDeleteBag, handleUpdateBag, handleSetBagMembers,
|
handleCreateBag, handleCreateBagByName, handleDeleteBag, handleUpdateBag, handleSetBagMembers,
|
||||||
availableTemplates, showTemplateDropdown, setShowTemplateDropdown, applyingTemplate,
|
availableTemplates, showTemplateDropdown, setShowTemplateDropdown, applyingTemplate,
|
||||||
|
|||||||
@@ -0,0 +1,61 @@
|
|||||||
|
import { Plus, Pencil, Trash2 } from 'lucide-react'
|
||||||
|
import { useTripStore } from '../../store/tripStore'
|
||||||
|
import { useSettingsStore } from '../../store/settingsStore'
|
||||||
|
import { useTranslation } from '../../i18n'
|
||||||
|
import { formatMoney } from '../../utils/formatters'
|
||||||
|
import { catMeta } from '../Budget/costsCategories'
|
||||||
|
import type { BudgetItem } from '../../types'
|
||||||
|
|
||||||
|
/**
|
||||||
|
* The Costs block inside a booking modal. Replaces the old inline price + budget
|
||||||
|
* category fields: when no expense is linked yet it offers a "create expense"
|
||||||
|
* button (the modal saves the booking first, then opens the full Costs editor);
|
||||||
|
* once linked it shows the expense with edit / remove actions.
|
||||||
|
*/
|
||||||
|
export function BookingCostsSection({ reservationId, onCreate, onEdit, onRemove }: {
|
||||||
|
reservationId: number | null
|
||||||
|
onCreate: () => void
|
||||||
|
onEdit: (item: BudgetItem) => void
|
||||||
|
onRemove: (item: BudgetItem) => void
|
||||||
|
}) {
|
||||||
|
const { t, locale } = useTranslation()
|
||||||
|
const budgetItems = useTripStore(s => s.budgetItems)
|
||||||
|
const trip = useTripStore(s => s.trip)
|
||||||
|
const displayCurrency = useSettingsStore(s => s.settings.default_currency)
|
||||||
|
const base = (displayCurrency || trip?.currency || 'EUR').toUpperCase()
|
||||||
|
const linked = reservationId ? budgetItems.find(i => i.reservation_id === reservationId) : null
|
||||||
|
|
||||||
|
const labelCls = 'block text-[11px] font-semibold uppercase tracking-[0.08em] text-content-faint mb-[6px]'
|
||||||
|
|
||||||
|
if (linked) {
|
||||||
|
const meta = catMeta(linked.category)
|
||||||
|
const Icon = meta.Icon
|
||||||
|
return (
|
||||||
|
<div>
|
||||||
|
<label className={labelCls}>{t('reservations.linkedExpense')}</label>
|
||||||
|
<div className="bg-surface-secondary border border-edge" style={{ display: 'flex', alignItems: 'center', gap: 10, padding: '10px 12px', borderRadius: 10 }}>
|
||||||
|
<span style={{ width: 26, height: 26, borderRadius: 7, display: 'grid', placeItems: 'center', background: meta.color + '22', color: meta.color, flexShrink: 0 }}><Icon size={14} /></span>
|
||||||
|
<div style={{ flex: 1, minWidth: 0 }}>
|
||||||
|
<div className="text-content" style={{ fontSize: 14, fontWeight: 600, overflow: 'hidden', textOverflow: 'ellipsis', whiteSpace: 'nowrap' }}>{linked.name}</div>
|
||||||
|
<div className="text-content-faint" style={{ fontSize: 12 }}>{t(meta.labelKey)}</div>
|
||||||
|
</div>
|
||||||
|
<span className="text-content" style={{ fontSize: 14, fontWeight: 700, flexShrink: 0 }}>{formatMoney(linked.total_price, linked.currency || base, locale)}</span>
|
||||||
|
<button type="button" onClick={() => onEdit(linked)} title={t('common.edit')} className="text-content-muted border border-edge bg-surface-card" style={{ display: 'inline-flex', padding: 7, borderRadius: 8, cursor: 'pointer' }}><Pencil size={13} /></button>
|
||||||
|
<button type="button" onClick={() => onRemove(linked)} title={t('reservations.removeExpense')} className="text-content-muted border border-edge bg-surface-card" style={{ display: 'inline-flex', padding: 7, borderRadius: 8, cursor: 'pointer' }}><Trash2 size={13} /></button>
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
return (
|
||||||
|
<div>
|
||||||
|
<label className={labelCls}>{t('reservations.costsLabel')}</label>
|
||||||
|
<button type="button" onClick={onCreate}
|
||||||
|
className="bg-surface-secondary border border-edge text-content"
|
||||||
|
style={{ width: '100%', display: 'flex', alignItems: 'center', justifyContent: 'center', gap: 8, padding: '11px 13px', borderRadius: 10, fontSize: 13.5, fontWeight: 600, cursor: 'pointer', fontFamily: 'inherit' }}>
|
||||||
|
<Plus size={15} /> {t('reservations.createExpense')}
|
||||||
|
</button>
|
||||||
|
<div className="text-content-faint" style={{ fontSize: 11, marginTop: 6 }}>{t('reservations.createExpenseHint')}</div>
|
||||||
|
</div>
|
||||||
|
)
|
||||||
|
}
|
||||||
@@ -0,0 +1,11 @@
|
|||||||
|
import type { BudgetItem } from '../../types'
|
||||||
|
|
||||||
|
/**
|
||||||
|
* A request from a booking modal to open the Costs expense editor — either to
|
||||||
|
* edit the already-linked expense, or to create a new one prefilled from the
|
||||||
|
* booking (the modal saves the booking first so `reservationId` is known).
|
||||||
|
*/
|
||||||
|
export interface BookingExpenseRequest {
|
||||||
|
editItem?: BudgetItem
|
||||||
|
prefill?: { reservationId?: number; name?: string; category?: string; amount?: number }
|
||||||
|
}
|
||||||
@@ -168,6 +168,34 @@ describe('DayPlanSidebar', () => {
|
|||||||
expect(screen.getByText('D2')).toBeInTheDocument()
|
expect(screen.getByText('D2')).toBeInTheDocument()
|
||||||
})
|
})
|
||||||
|
|
||||||
|
// ── #1330: route tools for a single optimizable place ───────────────────────
|
||||||
|
it('FE-PLANNER-DAYPLAN-005b: route tools show for one located place with a bookend hotel (#1330)', () => {
|
||||||
|
const place = buildPlace({ name: 'Louvre', lat: 48.86, lng: 2.34 })
|
||||||
|
const day = buildDay({ id: 10, date: '2025-06-01', title: 'Day 1' })
|
||||||
|
const day2 = buildDay({ id: 11, date: '2025-06-02', title: 'Day 2' })
|
||||||
|
const assignment = buildAssignment({ id: 99, day_id: 10, order_index: 0, place })
|
||||||
|
const accommodations = [{ id: 1, start_day_id: 10, end_day_id: 11, place_lat: 48.85, place_lng: 2.35 }]
|
||||||
|
render(<DayPlanSidebar {...makeDefaultProps({
|
||||||
|
days: [day, day2], places: [place], assignments: { '10': [assignment] },
|
||||||
|
accommodations: accommodations as any, selectedDayId: 10,
|
||||||
|
})} />)
|
||||||
|
// With accommodation optimization on, one located place is routable (hotel → place → hotel),
|
||||||
|
// so the route tools (here the Google Maps export button) must be visible.
|
||||||
|
expect(screen.getByRole('button', { name: 'Open in Google Maps' })).toBeInTheDocument()
|
||||||
|
})
|
||||||
|
|
||||||
|
it('FE-PLANNER-DAYPLAN-005c: route tools stay hidden for one place with no bookend hotel (#1330 guard)', () => {
|
||||||
|
const place = buildPlace({ name: 'Louvre', lat: 48.86, lng: 2.34 })
|
||||||
|
const day = buildDay({ id: 10, date: '2025-06-01', title: 'Day 1' })
|
||||||
|
const assignment = buildAssignment({ id: 99, day_id: 10, order_index: 0, place })
|
||||||
|
render(<DayPlanSidebar {...makeDefaultProps({
|
||||||
|
days: [day], places: [place], assignments: { '10': [assignment] },
|
||||||
|
accommodations: [], selectedDayId: 10,
|
||||||
|
})} />)
|
||||||
|
// No accommodation to bookend the lone place, so nothing routable — tools stay hidden.
|
||||||
|
expect(screen.queryByRole('button', { name: 'Open in Google Maps' })).not.toBeInTheDocument()
|
||||||
|
})
|
||||||
|
|
||||||
// ── Day expansion/collapse ──────────────────────────────────────────────
|
// ── Day expansion/collapse ──────────────────────────────────────────────
|
||||||
|
|
||||||
it('FE-PLANNER-DAYPLAN-006: days are expanded by default', () => {
|
it('FE-PLANNER-DAYPLAN-006: days are expanded by default', () => {
|
||||||
|
|||||||
@@ -5,7 +5,7 @@ declare global { interface Window { __dragData: DragDataPayload | null } }
|
|||||||
import React, { useState, useEffect, useLayoutEffect, useRef, useMemo } from 'react'
|
import React, { useState, useEffect, useLayoutEffect, useRef, useMemo } from 'react'
|
||||||
import { ChevronDown, ChevronRight, ChevronUp, Navigation, RotateCcw, ExternalLink, Clock, Pencil, GripVertical, Ticket, Plus, FileText, Trash2, Car, Lock, Hotel, Footprints, Route as RouteIcon } from 'lucide-react'
|
import { ChevronDown, ChevronRight, ChevronUp, Navigation, RotateCcw, ExternalLink, Clock, Pencil, GripVertical, Ticket, Plus, FileText, Trash2, Car, Lock, Hotel, Footprints, Route as RouteIcon } from 'lucide-react'
|
||||||
import { assignmentsApi, reservationsApi } from '../../api/client'
|
import { assignmentsApi, reservationsApi } from '../../api/client'
|
||||||
import { calculateRoute, calculateRouteWithLegs, optimizeRoute } from '../Map/RouteCalculator'
|
import { calculateRoute, calculateRouteWithLegs, optimizeRoute, generateGoogleMapsUrl } from '../Map/RouteCalculator'
|
||||||
import PlaceAvatar from '../shared/PlaceAvatar'
|
import PlaceAvatar from '../shared/PlaceAvatar'
|
||||||
import ConfirmDialog from '../shared/ConfirmDialog'
|
import ConfirmDialog from '../shared/ConfirmDialog'
|
||||||
import { useContextMenu, ContextMenu } from '../shared/ContextMenu'
|
import { useContextMenu, ContextMenu } from '../shared/ContextMenu'
|
||||||
@@ -18,16 +18,16 @@ import { useTripStore } from '../../store/tripStore'
|
|||||||
import { useCanDo } from '../../store/permissionsStore'
|
import { useCanDo } from '../../store/permissionsStore'
|
||||||
import { useSettingsStore } from '../../store/settingsStore'
|
import { useSettingsStore } from '../../store/settingsStore'
|
||||||
import { useTranslation } from '../../i18n'
|
import { useTranslation } from '../../i18n'
|
||||||
import { isDayInAccommodationRange, getAccommodationAnchors } from '../../utils/dayOrder'
|
import { isDayInAccommodationRange, getAccommodationAnchors, getDayBookendHotels } from '../../utils/dayOrder'
|
||||||
import {
|
import {
|
||||||
TRANSPORT_TYPES, parseTimeToMinutes, getSpanPhase, getDisplayTimeForDay,
|
TRANSPORT_TYPES, parseTimeToMinutes, getSpanPhase, getDisplayTimeForDay, getTransportRouteEndpoints,
|
||||||
getTransportForDay as _getTransportForDay, getMergedItems as _getMergedItems,
|
getTransportForDay as _getTransportForDay, getMergedItems as _getMergedItems,
|
||||||
type MergedItem,
|
type MergedItem,
|
||||||
} from '../../utils/dayMerge'
|
} from '../../utils/dayMerge'
|
||||||
import { formatDate, formatTime, dayTotalCost, splitReservationDateTime } from '../../utils/formatters'
|
import { formatDate, formatTime, dayTotalCost, splitReservationDateTime } from '../../utils/formatters'
|
||||||
import { useDayNotes } from '../../hooks/useDayNotes'
|
import { useDayNotes } from '../../hooks/useDayNotes'
|
||||||
import { RES_ICONS, getNoteIcon } from './DayPlanSidebar.constants'
|
import { RES_ICONS, getNoteIcon } from './DayPlanSidebar.constants'
|
||||||
import { RouteConnector } from './DayPlanSidebarRouteConnector'
|
import { RouteConnector, HotelRouteConnector } from './DayPlanSidebarRouteConnector'
|
||||||
import { MobileAddPlaceButton } from './DayPlanSidebarMobileAddPlaceButton'
|
import { MobileAddPlaceButton } from './DayPlanSidebarMobileAddPlaceButton'
|
||||||
import { DayPlanSidebarToolbar } from './DayPlanSidebarToolbar'
|
import { DayPlanSidebarToolbar } from './DayPlanSidebarToolbar'
|
||||||
import { DayPlanSidebarNoteModal } from './DayPlanSidebarNoteModal'
|
import { DayPlanSidebarNoteModal } from './DayPlanSidebarNoteModal'
|
||||||
@@ -35,6 +35,7 @@ import { DayPlanSidebarTimeConfirmModal } from './DayPlanSidebarTimeConfirmModal
|
|||||||
import { DayPlanSidebarTransportDetailModal } from './DayPlanSidebarTransportDetailModal'
|
import { DayPlanSidebarTransportDetailModal } from './DayPlanSidebarTransportDetailModal'
|
||||||
import { DayPlanSidebarFooter } from './DayPlanSidebarFooter'
|
import { DayPlanSidebarFooter } from './DayPlanSidebarFooter'
|
||||||
import type { Trip, Day, Place, Category, Assignment, Accommodation, Reservation, AssignmentsMap, RouteResult, RouteSegment, DayNote } from '../../types'
|
import type { Trip, Day, Place, Category, Assignment, Accommodation, Reservation, AssignmentsMap, RouteResult, RouteSegment, DayNote } from '../../types'
|
||||||
|
import { getGoogleMapsUrlForPlace } from './placeGoogleMaps'
|
||||||
|
|
||||||
interface DayPlanSidebarProps {
|
interface DayPlanSidebarProps {
|
||||||
tripId: number
|
tripId: number
|
||||||
@@ -152,6 +153,11 @@ function useDayPlanSidebar(props: DayPlanSidebarProps) {
|
|||||||
const [isCalculating, setIsCalculating] = useState(false)
|
const [isCalculating, setIsCalculating] = useState(false)
|
||||||
const [routeInfo, setRouteInfo] = useState(null)
|
const [routeInfo, setRouteInfo] = useState(null)
|
||||||
const [routeLegs, setRouteLegs] = useState<Record<number, RouteSegment>>({})
|
const [routeLegs, setRouteLegs] = useState<Record<number, RouteSegment>>({})
|
||||||
|
const [hotelLegs, setHotelLegs] = useState<{ top?: { seg: RouteSegment; name: string }; bottom?: { seg: RouteSegment; name: string } }>({})
|
||||||
|
const optimizeFromAccommodation = useSettingsStore(s => s.settings.optimize_from_accommodation)
|
||||||
|
// Recompute the hotel/route legs when the user flips km↔mi so the connector
|
||||||
|
// distances refresh instead of showing stale cached text (#1300).
|
||||||
|
const distanceUnit = useSettingsStore(s => s.settings.distance_unit)
|
||||||
const legsAbortRef = useRef<AbortController | null>(null)
|
const legsAbortRef = useRef<AbortController | null>(null)
|
||||||
const [draggingId, setDraggingId] = useState(null)
|
const [draggingId, setDraggingId] = useState(null)
|
||||||
const [lockedIds, setLockedIds] = useState(new Set())
|
const [lockedIds, setLockedIds] = useState(new Set())
|
||||||
@@ -379,12 +385,8 @@ function useDayPlanSidebar(props: DayPlanSidebarProps) {
|
|||||||
// the start place's assignment id. Shares RouteCalculator's cache with the map.
|
// the start place's assignment id. Shares RouteCalculator's cache with the map.
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
if (legsAbortRef.current) legsAbortRef.current.abort()
|
if (legsAbortRef.current) legsAbortRef.current.abort()
|
||||||
if (!selectedDayId || !routeShown) { setRouteLegs({}); return }
|
if (!selectedDayId || !routeShown) { setRouteLegs({}); setHotelLegs({}); return }
|
||||||
const merged = mergedItemsMap[selectedDayId] || []
|
const merged = mergedItemsMap[selectedDayId] || []
|
||||||
const epLoc = (r: any, role: 'from' | 'to'): { lat: number; lng: number } | null => {
|
|
||||||
const e = (r.endpoints || []).find((x: any) => x.role === role)
|
|
||||||
return e && e.lat != null && e.lng != null ? { lat: e.lat, lng: e.lng } : null
|
|
||||||
}
|
|
||||||
const runs: { id: number; lat: number; lng: number }[][] = []
|
const runs: { id: number; lat: number; lng: number }[][] = []
|
||||||
let cur: { id: number; lat: number; lng: number }[] = []
|
let cur: { id: number; lat: number; lng: number }[] = []
|
||||||
for (const it of merged) {
|
for (const it of merged) {
|
||||||
@@ -392,7 +394,7 @@ function useDayPlanSidebar(props: DayPlanSidebarProps) {
|
|||||||
cur.push({ id: it.data.id, lat: it.data.place.lat, lng: it.data.place.lng })
|
cur.push({ id: it.data.id, lat: it.data.place.lat, lng: it.data.place.lng })
|
||||||
} else if (it.type === 'transport') {
|
} else if (it.type === 'transport') {
|
||||||
const r = it.data
|
const r = it.data
|
||||||
const from = epLoc(r, 'from'), to = epLoc(r, 'to')
|
const { from, to } = getTransportRouteEndpoints(r, selectedDayId)
|
||||||
if (from || to) {
|
if (from || to) {
|
||||||
// Located transport: route to its departure point, break the run (the
|
// Located transport: route to its departure point, break the run (the
|
||||||
// flight/train itself isn't driven), and let its arrival start the next.
|
// flight/train itself isn't driven), and let its arrival start the next.
|
||||||
@@ -408,7 +410,37 @@ function useDayPlanSidebar(props: DayPlanSidebarProps) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
if (cur.length >= 2) runs.push(cur)
|
if (cur.length >= 2) runs.push(cur)
|
||||||
if (runs.length === 0) { setRouteLegs({}); return }
|
|
||||||
|
// Hotel bookend legs: the drive from the day's accommodation to the first located
|
||||||
|
// waypoint of the day (morning) and from the last one back to it (evening). Only when
|
||||||
|
// the "optimize from accommodation" setting is on and the day has a hotel.
|
||||||
|
const day = days.find(d => d.id === selectedDayId)
|
||||||
|
const bookends = day && optimizeFromAccommodation !== false
|
||||||
|
? getDayBookendHotels(day, days, accommodations)
|
||||||
|
: null
|
||||||
|
const startHotel = bookends?.morning
|
||||||
|
const endHotel = bookends?.evening
|
||||||
|
const hotelName = (a: Accommodation) => (a as any).place_name || (a as any).reservation_title || ''
|
||||||
|
// Waypoints include transport endpoints (a car return, a taxi/train arrival), so the hotel
|
||||||
|
// legs connect even when the day starts or ends with a booking rather than a place. Track
|
||||||
|
// whether each is a place so we can skip a hotel↔transport leg that isn't real: on a day-1
|
||||||
|
// arrival the check-in hotel never drove to the departure airport (#1321).
|
||||||
|
const wayPts: { lat: number; lng: number; isPlace: boolean }[] = []
|
||||||
|
for (const it of merged) {
|
||||||
|
if (it.type === 'place' && it.data.place?.lat && it.data.place?.lng) {
|
||||||
|
wayPts.push({ lat: it.data.place.lat, lng: it.data.place.lng, isPlace: true })
|
||||||
|
} else if (it.type === 'transport') {
|
||||||
|
const { from, to } = getTransportRouteEndpoints(it.data, selectedDayId)
|
||||||
|
if (from) wayPts.push({ lat: from.lat, lng: from.lng, isPlace: false })
|
||||||
|
if (to) wayPts.push({ lat: to.lat, lng: to.lng, isPlace: false })
|
||||||
|
}
|
||||||
|
}
|
||||||
|
const firstWay = wayPts[0]
|
||||||
|
const lastWay = wayPts[wayPts.length - 1]
|
||||||
|
const wantTop = !!(startHotel && firstWay && (firstWay.isPlace || bookends?.morningIsSleptHere))
|
||||||
|
const wantBottom = !!(endHotel && lastWay && (lastWay.isPlace || bookends?.eveningIsOvernight))
|
||||||
|
|
||||||
|
if (runs.length === 0 && !wantTop && !wantBottom) { setRouteLegs({}); setHotelLegs({}); return }
|
||||||
|
|
||||||
const controller = new AbortController()
|
const controller = new AbortController()
|
||||||
legsAbortRef.current = controller
|
legsAbortRef.current = controller
|
||||||
@@ -422,9 +454,27 @@ function useDayPlanSidebar(props: DayPlanSidebarProps) {
|
|||||||
if (err instanceof Error && err.name === 'AbortError') return
|
if (err instanceof Error && err.name === 'AbortError') return
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
if (!controller.signal.aborted) setRouteLegs(map)
|
|
||||||
|
// One extra cached OSRM call per bookend; shares RouteCalculator's cache.
|
||||||
|
const legBetween = async (a: { lat: number; lng: number }, b: { lat: number; lng: number }): Promise<RouteSegment | undefined> => {
|
||||||
|
try {
|
||||||
|
const r = await calculateRouteWithLegs([a, b], { signal: controller.signal, profile: routeProfile })
|
||||||
|
return r.legs[0]
|
||||||
|
} catch { return undefined }
|
||||||
|
}
|
||||||
|
const hotel: { top?: { seg: RouteSegment; name: string }; bottom?: { seg: RouteSegment; name: string } } = {}
|
||||||
|
if (wantTop) {
|
||||||
|
const seg = await legBetween({ lat: startHotel!.place_lat as number, lng: startHotel!.place_lng as number }, { lat: firstWay.lat, lng: firstWay.lng })
|
||||||
|
if (seg) hotel.top = { seg, name: hotelName(startHotel!) }
|
||||||
|
}
|
||||||
|
if (wantBottom) {
|
||||||
|
const seg = await legBetween({ lat: lastWay.lat, lng: lastWay.lng }, { lat: endHotel!.place_lat as number, lng: endHotel!.place_lng as number })
|
||||||
|
if (seg) hotel.bottom = { seg, name: hotelName(endHotel!) }
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!controller.signal.aborted) { setRouteLegs(map); setHotelLegs(hotel) }
|
||||||
})()
|
})()
|
||||||
}, [selectedDayId, routeShown, routeProfile, mergedItemsMap])
|
}, [selectedDayId, routeShown, routeProfile, mergedItemsMap, accommodations, days, optimizeFromAccommodation, distanceUnit])
|
||||||
|
|
||||||
const openAddNote = (dayId, e) => {
|
const openAddNote = (dayId, e) => {
|
||||||
e?.stopPropagation()
|
e?.stopPropagation()
|
||||||
@@ -938,6 +988,8 @@ function useDayPlanSidebar(props: DayPlanSidebarProps) {
|
|||||||
setRouteInfo,
|
setRouteInfo,
|
||||||
routeLegs,
|
routeLegs,
|
||||||
setRouteLegs,
|
setRouteLegs,
|
||||||
|
hotelLegs,
|
||||||
|
setHotelLegs,
|
||||||
legsAbortRef,
|
legsAbortRef,
|
||||||
draggingId,
|
draggingId,
|
||||||
setDraggingId,
|
setDraggingId,
|
||||||
@@ -1003,6 +1055,9 @@ function useDayPlanSidebar(props: DayPlanSidebarProps) {
|
|||||||
|
|
||||||
const DayPlanSidebar = React.memo(function DayPlanSidebar(props: DayPlanSidebarProps) {
|
const DayPlanSidebar = React.memo(function DayPlanSidebar(props: DayPlanSidebarProps) {
|
||||||
const S = useDayPlanSidebar(props)
|
const S = useDayPlanSidebar(props)
|
||||||
|
// Needed by the route-tools visibility gate in the render below (#1330); the hook
|
||||||
|
// keeps its own copy, so read it reactively here in the component scope too.
|
||||||
|
const optimizeFromAccommodation = useSettingsStore(s => s.settings.optimize_from_accommodation)
|
||||||
const {
|
const {
|
||||||
tripId,
|
tripId,
|
||||||
trip,
|
trip,
|
||||||
@@ -1085,6 +1140,8 @@ const DayPlanSidebar = React.memo(function DayPlanSidebar(props: DayPlanSidebarP
|
|||||||
setRouteInfo,
|
setRouteInfo,
|
||||||
routeLegs,
|
routeLegs,
|
||||||
setRouteLegs,
|
setRouteLegs,
|
||||||
|
hotelLegs,
|
||||||
|
setHotelLegs,
|
||||||
legsAbortRef,
|
legsAbortRef,
|
||||||
draggingId,
|
draggingId,
|
||||||
setDraggingId,
|
setDraggingId,
|
||||||
@@ -1186,6 +1243,16 @@ const DayPlanSidebar = React.memo(function DayPlanSidebar(props: DayPlanSidebarP
|
|||||||
const cost = dayTotalCost(day.id, assignments, currency)
|
const cost = dayTotalCost(day.id, assignments, currency)
|
||||||
const formattedDate = formatDate(day.date, locale)
|
const formattedDate = formatDate(day.date, locale)
|
||||||
const loc = da.find(a => a.place?.lat && a.place?.lng)
|
const loc = da.find(a => a.place?.lat && a.place?.lng)
|
||||||
|
// Route tools normally need 2+ stops, but a single located place is still
|
||||||
|
// routable when accommodation optimization can bookend it with a hotel
|
||||||
|
// (hotel → place → hotel, the same line the map draws) — otherwise the tools
|
||||||
|
// vanish on such a day (#1330). Purely additive to the 2+ case.
|
||||||
|
const routeBookends = optimizeFromAccommodation !== false ? getDayBookendHotels(day, days, accommodations) : null
|
||||||
|
const hasRouteBookend = !!(
|
||||||
|
(routeBookends?.morning?.place_lat != null && routeBookends?.morning?.place_lng != null) ||
|
||||||
|
(routeBookends?.evening?.place_lat != null && routeBookends?.evening?.place_lng != null)
|
||||||
|
)
|
||||||
|
const routeToolsRoutable = da.length >= 2 || (loc != null && hasRouteBookend)
|
||||||
const isDragTarget = dragOverDayId === day.id
|
const isDragTarget = dragOverDayId === day.id
|
||||||
const merged = mergedItemsMap[day.id] || []
|
const merged = mergedItemsMap[day.id] || []
|
||||||
const dayNoteUi = noteUi[day.id]
|
const dayNoteUi = noteUi[day.id]
|
||||||
@@ -1427,6 +1494,9 @@ const DayPlanSidebar = React.memo(function DayPlanSidebar(props: DayPlanSidebarP
|
|||||||
handleMergedDrop(day.id, 'note', Number(noteId), lastItem.type, lastItem.data.id, true)
|
handleMergedDrop(day.id, 'note', Number(noteId), lastItem.type, lastItem.data.id, true)
|
||||||
}}
|
}}
|
||||||
>
|
>
|
||||||
|
{isSelected && hotelLegs.top && (
|
||||||
|
<HotelRouteConnector seg={hotelLegs.top.seg} name={hotelLegs.top.name} profile={routeProfile} placement="top" />
|
||||||
|
)}
|
||||||
{merged.length === 0 && !dayNoteUi ? (
|
{merged.length === 0 && !dayNoteUi ? (
|
||||||
<div
|
<div
|
||||||
onDragOver={e => { e.preventDefault(); if (dragOverDayId !== day.id) setDragOverDayId(day.id) }}
|
onDragOver={e => { e.preventDefault(); if (dragOverDayId !== day.id) setDragOverDayId(day.id) }}
|
||||||
@@ -1547,14 +1617,17 @@ const DayPlanSidebar = React.memo(function DayPlanSidebar(props: DayPlanSidebarP
|
|||||||
}}
|
}}
|
||||||
onDragEnd={() => { setDraggingId(null); setDragOverDayId(null); setDropTargetKey(null); dragDataRef.current = null }}
|
onDragEnd={() => { setDraggingId(null); setDragOverDayId(null); setDropTargetKey(null); dragDataRef.current = null }}
|
||||||
onClick={() => { onPlaceClick(isPlaceSelected ? null : place.id, isPlaceSelected ? null : assignment.id); if (!isPlaceSelected) onSelectDay(day.id, true) }}
|
onClick={() => { onPlaceClick(isPlaceSelected ? null : place.id, isPlaceSelected ? null : assignment.id); if (!isPlaceSelected) onSelectDay(day.id, true) }}
|
||||||
onContextMenu={e => ctxMenu.open(e, [
|
onContextMenu={e => {
|
||||||
canEditDays && onEditPlace && { label: t('common.edit'), icon: Pencil, onClick: () => onEditPlace(place, assignment.id) },
|
const googleMapsUrl = getGoogleMapsUrlForPlace(place)
|
||||||
canEditDays && onRemoveAssignment && { label: t('planner.removeFromDay'), icon: Trash2, onClick: () => onRemoveAssignment(day.id, assignment.id) },
|
ctxMenu.open(e, [
|
||||||
place.website && { label: t('inspector.website'), icon: ExternalLink, onClick: () => window.open(place.website, '_blank') },
|
canEditDays && onEditPlace && { label: t('common.edit'), icon: Pencil, onClick: () => onEditPlace(place, assignment.id) },
|
||||||
(place.lat && place.lng) && { label: 'Google Maps', icon: Navigation, onClick: () => window.open(`https://www.google.com/maps/search/?api=1&query=${place.google_place_id ? encodeURIComponent(place.name) + '&query_place_id=' + place.google_place_id : place.lat + ',' + place.lng}`, '_blank') },
|
canEditDays && onRemoveAssignment && { label: t('planner.removeFromDay'), icon: Trash2, onClick: () => onRemoveAssignment(day.id, assignment.id) },
|
||||||
{ divider: true },
|
place.website && { label: t('inspector.website'), icon: ExternalLink, onClick: () => window.open(place.website, '_blank') },
|
||||||
canEditDays && onDeletePlace && { label: t('common.delete'), icon: Trash2, danger: true, onClick: () => onDeletePlace(place.id) },
|
googleMapsUrl && { label: 'Google Maps', icon: Navigation, onClick: () => window.open(googleMapsUrl, '_blank') },
|
||||||
])}
|
{ divider: true },
|
||||||
|
canEditDays && onDeletePlace && { label: t('common.delete'), icon: Trash2, danger: true, onClick: () => onDeletePlace(place.id) },
|
||||||
|
])
|
||||||
|
}}
|
||||||
onMouseEnter={e => {
|
onMouseEnter={e => {
|
||||||
if (!isPlaceSelected && !lockedIds.has(assignment.id))
|
if (!isPlaceSelected && !lockedIds.has(assignment.id))
|
||||||
e.currentTarget.style.background = 'var(--bg-hover)'
|
e.currentTarget.style.background = 'var(--bg-hover)'
|
||||||
@@ -2057,6 +2130,9 @@ const DayPlanSidebar = React.memo(function DayPlanSidebar(props: DayPlanSidebarP
|
|||||||
)
|
)
|
||||||
})
|
})
|
||||||
)}
|
)}
|
||||||
|
{isSelected && hotelLegs.bottom && (
|
||||||
|
<HotelRouteConnector seg={hotelLegs.bottom.seg} name={hotelLegs.bottom.name} profile={routeProfile} placement="bottom" />
|
||||||
|
)}
|
||||||
{/* Drop-Zone am Listenende — immer vorhanden als Drop-Target */}
|
{/* Drop-Zone am Listenende — immer vorhanden als Drop-Target */}
|
||||||
<div
|
<div
|
||||||
style={{ minHeight: 12, padding: '2px 8px' }}
|
style={{ minHeight: 12, padding: '2px 8px' }}
|
||||||
@@ -2100,8 +2176,8 @@ const DayPlanSidebar = React.memo(function DayPlanSidebar(props: DayPlanSidebarP
|
|||||||
)}
|
)}
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
{/* Routen-Werkzeuge (ausgewählter Tag, 2+ Orte) */}
|
{/* Routen-Werkzeuge (ausgewählter Tag, 2+ Orte — oder 1 Ort mit Hotel-Bookend, #1330) */}
|
||||||
{(isSelected || (showRouteToolsWhenExpanded && isExpanded)) && getDayAssignments(day.id).length >= 2 && (
|
{(isSelected || (showRouteToolsWhenExpanded && isExpanded)) && routeToolsRoutable && (
|
||||||
<div style={{ padding: '10px 16px 12px', borderTop: '1px solid var(--border-faint)', display: 'flex', flexDirection: 'column', gap: 7 }}>
|
<div style={{ padding: '10px 16px 12px', borderTop: '1px solid var(--border-faint)', display: 'flex', flexDirection: 'column', gap: 7 }}>
|
||||||
<div style={{ display: 'flex', gap: 6, alignItems: 'stretch' }}>
|
<div style={{ display: 'flex', gap: 6, alignItems: 'stretch' }}>
|
||||||
<button
|
<button
|
||||||
@@ -2117,6 +2193,28 @@ const DayPlanSidebar = React.memo(function DayPlanSidebar(props: DayPlanSidebarP
|
|||||||
<RouteIcon size={12} strokeWidth={2} />
|
<RouteIcon size={12} strokeWidth={2} />
|
||||||
{t('dayplan.route')}
|
{t('dayplan.route')}
|
||||||
</button>
|
</button>
|
||||||
|
{/* Open the day's stops as a route in Google Maps (planned order). #1255 */}
|
||||||
|
<button
|
||||||
|
onClick={() => {
|
||||||
|
const url = generateGoogleMapsUrl(getDayAssignments(day.id).map(a => a.place).filter(p => p?.lat != null && p?.lng != null) as { lat: number; lng: number }[])
|
||||||
|
if (url) window.open(url, '_blank', 'noopener,noreferrer')
|
||||||
|
}}
|
||||||
|
aria-label={t('planner.openGoogleMaps')}
|
||||||
|
title={t('planner.openGoogleMaps')}
|
||||||
|
className="bg-transparent text-content-secondary"
|
||||||
|
style={{
|
||||||
|
display: 'flex', alignItems: 'center', justifyContent: 'center',
|
||||||
|
padding: '6px 10px', borderRadius: 8, border: '1px solid var(--border-faint)',
|
||||||
|
cursor: 'pointer', fontFamily: 'inherit', flexShrink: 0,
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
<svg width="14" height="14" viewBox="0 0 48 48" fill="currentColor" aria-hidden="true">
|
||||||
|
<path d="M24 9.5c3.54 0 6.71 1.22 9.21 3.6l6.85-6.85C35.9 2.38 30.47 0 24 0 14.62 0 6.51 5.38 2.56 13.22l7.98 6.19C12.43 13.72 17.74 9.5 24 9.5z" />
|
||||||
|
<path d="M46.98 24.55c0-1.57-.15-3.09-.38-4.55H24v9.02h12.94c-.58 2.96-2.26 5.48-4.78 7.18l7.73 6c4.51-4.18 7.09-10.36 7.09-17.65z" />
|
||||||
|
<path d="M10.53 28.59c-.48-1.45-.76-2.99-.76-4.59s.27-3.14.76-4.59l-7.98-6.19C.92 16.46 0 20.12 0 24c0 3.88.92 7.54 2.56 10.78l7.97-6.19z" />
|
||||||
|
<path d="M24 48c6.48 0 11.93-2.13 15.89-5.81l-7.73-6c-2.15 1.45-4.92 2.3-8.16 2.3-6.26 0-11.57-4.22-13.47-9.91l-7.98 6.19C6.51 42.62 14.62 48 24 48z" />
|
||||||
|
</svg>
|
||||||
|
</button>
|
||||||
<button onClick={() => handleOptimize(day.id)} className="bg-surface-hover text-content-secondary" style={{
|
<button onClick={() => handleOptimize(day.id)} className="bg-surface-hover text-content-secondary" style={{
|
||||||
flex: 1, display: 'flex', alignItems: 'center', justifyContent: 'center', gap: 5,
|
flex: 1, display: 'flex', alignItems: 'center', justifyContent: 'center', gap: 5,
|
||||||
padding: '6px 0', fontSize: 11, fontWeight: 500, borderRadius: 8, border: 'none',
|
padding: '6px 0', fontSize: 11, fontWeight: 500, borderRadius: 8, border: 'none',
|
||||||
|
|||||||
@@ -1,4 +1,4 @@
|
|||||||
import { Car, Footprints } from 'lucide-react'
|
import { Car, Footprints, Hotel } from 'lucide-react'
|
||||||
import type { RouteSegment } from '../../types'
|
import type { RouteSegment } from '../../types'
|
||||||
|
|
||||||
/** Slim travel-time connector shown between two consecutive located stops in a day. */
|
/** Slim travel-time connector shown between two consecutive located stops in a day. */
|
||||||
@@ -19,3 +19,60 @@ export function RouteConnector({ seg, profile }: { seg: RouteSegment; profile: '
|
|||||||
</div>
|
</div>
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* The hotel's bookend legs for a day: a two-line connector naming the day's
|
||||||
|
* accommodation with the drive to/from it. Rendered above the first place (the
|
||||||
|
* morning departure from the hotel) and below the last place (the evening return),
|
||||||
|
* when the "optimize from accommodation" setting is on and the day has a hotel.
|
||||||
|
*/
|
||||||
|
export function HotelRouteConnector({
|
||||||
|
seg,
|
||||||
|
profile,
|
||||||
|
name,
|
||||||
|
placement,
|
||||||
|
}: {
|
||||||
|
seg: RouteSegment
|
||||||
|
profile: 'driving' | 'walking'
|
||||||
|
name: string
|
||||||
|
placement: 'top' | 'bottom'
|
||||||
|
}) {
|
||||||
|
const driving = profile === 'driving'
|
||||||
|
const Icon = driving ? Car : Footprints
|
||||||
|
const line = { flex: 1, height: 1, minHeight: 1, alignSelf: 'center', background: 'var(--border-primary)' }
|
||||||
|
const hotelRow = (
|
||||||
|
<div style={{ display: 'flex', alignItems: 'center', justifyContent: 'center', gap: 5, padding: '0 14px', minWidth: 0 }}>
|
||||||
|
<Hotel size={12} strokeWidth={1.8} style={{ flexShrink: 0, color: 'var(--text-muted)' }} />
|
||||||
|
<span style={{ fontSize: 11, fontWeight: 600, color: 'var(--text-muted)', overflow: 'hidden', textOverflow: 'ellipsis', whiteSpace: 'nowrap', lineHeight: 1.2 }}>
|
||||||
|
{name}
|
||||||
|
</span>
|
||||||
|
</div>
|
||||||
|
)
|
||||||
|
const travelRow = (
|
||||||
|
<div style={{ display: 'flex', alignItems: 'center', gap: 8, padding: '3px 14px', fontSize: 10.5, color: 'var(--text-faint)', lineHeight: 1.2 }}>
|
||||||
|
<div style={line} />
|
||||||
|
<div style={{ display: 'flex', alignItems: 'center', gap: 4, flexShrink: 0 }}>
|
||||||
|
<Icon size={11} strokeWidth={2} />
|
||||||
|
<span>{seg.durationText ?? (driving ? seg.drivingText : seg.walkingText)}</span>
|
||||||
|
<span style={{ opacity: 0.4 }}>·</span>
|
||||||
|
<span>{seg.distanceText}</span>
|
||||||
|
</div>
|
||||||
|
<div style={line} />
|
||||||
|
</div>
|
||||||
|
)
|
||||||
|
return (
|
||||||
|
<div style={{ display: 'flex', flexDirection: 'column', gap: 3, padding: placement === 'top' ? '2px 0 6px' : '6px 0 2px' }}>
|
||||||
|
{placement === 'top' ? (
|
||||||
|
<>
|
||||||
|
{hotelRow}
|
||||||
|
{travelRow}
|
||||||
|
</>
|
||||||
|
) : (
|
||||||
|
<>
|
||||||
|
{travelRow}
|
||||||
|
{hotelRow}
|
||||||
|
</>
|
||||||
|
)}
|
||||||
|
</div>
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|||||||
@@ -13,6 +13,7 @@ export interface PlaceFormData {
|
|||||||
// Populated from a maps-search pick (not part of the initial blank form).
|
// Populated from a maps-search pick (not part of the initial blank form).
|
||||||
phone?: string
|
phone?: string
|
||||||
google_place_id?: string
|
google_place_id?: string
|
||||||
|
google_ftid?: string
|
||||||
osm_id?: string
|
osm_id?: string
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -253,6 +253,101 @@ describe('PlaceFormModal', () => {
|
|||||||
delete window.__addToast;
|
delete window.__addToast;
|
||||||
});
|
});
|
||||||
|
|
||||||
|
// ── Autocomplete suggestion click (#1192) ─────────────────────────────────────
|
||||||
|
// Selecting a dropdown suggestion does a second `details` lookup which is fragile
|
||||||
|
// (details kill-switch, an overloaded OSM Overpass mirror, upstream errors). When
|
||||||
|
// it yields no usable place the modal must fall back to the reliable text search
|
||||||
|
// instead of dead-ending on "Place search failed".
|
||||||
|
|
||||||
|
async function openSuggestion(user: ReturnType<typeof userEvent.setup>) {
|
||||||
|
const searchInput = screen.getByPlaceholderText('Search places...');
|
||||||
|
await user.type(searchInput, 'Eiffel');
|
||||||
|
// Debounced autocomplete (300ms) then the dropdown renders the suggestion.
|
||||||
|
return screen.findByText('Paris, France');
|
||||||
|
}
|
||||||
|
|
||||||
|
it('FE-PLANNER-PLACEFORM-021b: suggestion click falls back to search when details fails', async () => {
|
||||||
|
const addToast = vi.fn();
|
||||||
|
window.__addToast = addToast;
|
||||||
|
const user = userEvent.setup();
|
||||||
|
server.use(
|
||||||
|
http.post('/api/maps/autocomplete', () =>
|
||||||
|
HttpResponse.json({
|
||||||
|
suggestions: [{ placeId: 'node:123', mainText: 'Eiffel Tower', secondaryText: 'Paris, France' }],
|
||||||
|
source: 'nominatim',
|
||||||
|
}),
|
||||||
|
),
|
||||||
|
// details rejects (e.g. proxy 504 from a hung Overpass mirror)
|
||||||
|
http.get('/api/maps/details/:placeId', () => HttpResponse.json({ error: 'boom' }, { status: 500 })),
|
||||||
|
http.post('/api/maps/search', () =>
|
||||||
|
HttpResponse.json({
|
||||||
|
places: [{ name: 'Eiffel Tower', address: 'Paris, France', lat: '48.8584', lng: '2.2945' }],
|
||||||
|
source: 'openstreetmap',
|
||||||
|
}),
|
||||||
|
),
|
||||||
|
);
|
||||||
|
|
||||||
|
render(<PlaceFormModal {...defaultProps} />);
|
||||||
|
const suggestion = await openSuggestion(user);
|
||||||
|
await user.click(suggestion);
|
||||||
|
|
||||||
|
// Form is populated from the search fallback, and no error toast is shown.
|
||||||
|
expect(await screen.findByDisplayValue('48.8584')).toBeInTheDocument();
|
||||||
|
expect(screen.getByDisplayValue('2.2945')).toBeInTheDocument();
|
||||||
|
expect(addToast).not.toHaveBeenCalledWith(expect.anything(), 'error', expect.anything());
|
||||||
|
delete window.__addToast;
|
||||||
|
});
|
||||||
|
|
||||||
|
it('FE-PLANNER-PLACEFORM-021c: suggestion click falls back when details is disabled (place: null)', async () => {
|
||||||
|
const user = userEvent.setup();
|
||||||
|
server.use(
|
||||||
|
http.post('/api/maps/autocomplete', () =>
|
||||||
|
HttpResponse.json({
|
||||||
|
suggestions: [{ placeId: 'node:123', mainText: 'Eiffel Tower', secondaryText: 'Paris, France' }],
|
||||||
|
source: 'nominatim',
|
||||||
|
}),
|
||||||
|
),
|
||||||
|
http.get('/api/maps/details/:placeId', () => HttpResponse.json({ place: null, disabled: true })),
|
||||||
|
http.post('/api/maps/search', () =>
|
||||||
|
HttpResponse.json({
|
||||||
|
places: [{ name: 'Eiffel Tower', address: 'Paris, France', lat: '48.8584', lng: '2.2945' }],
|
||||||
|
source: 'openstreetmap',
|
||||||
|
}),
|
||||||
|
),
|
||||||
|
);
|
||||||
|
|
||||||
|
render(<PlaceFormModal {...defaultProps} />);
|
||||||
|
const suggestion = await openSuggestion(user);
|
||||||
|
await user.click(suggestion);
|
||||||
|
|
||||||
|
expect(await screen.findByDisplayValue('48.8584')).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('FE-PLANNER-PLACEFORM-021d: suggestion click shows error only when the fallback also finds nothing', async () => {
|
||||||
|
const addToast = vi.fn();
|
||||||
|
window.__addToast = addToast;
|
||||||
|
const user = userEvent.setup();
|
||||||
|
server.use(
|
||||||
|
http.post('/api/maps/autocomplete', () =>
|
||||||
|
HttpResponse.json({
|
||||||
|
suggestions: [{ placeId: 'node:123', mainText: 'Eiffel Tower', secondaryText: 'Paris, France' }],
|
||||||
|
source: 'nominatim',
|
||||||
|
}),
|
||||||
|
),
|
||||||
|
http.get('/api/maps/details/:placeId', () => HttpResponse.json({ place: null, disabled: true })),
|
||||||
|
http.post('/api/maps/search', () => HttpResponse.json({ places: [], source: 'openstreetmap' })),
|
||||||
|
);
|
||||||
|
|
||||||
|
render(<PlaceFormModal {...defaultProps} />);
|
||||||
|
const suggestion = await openSuggestion(user);
|
||||||
|
await user.click(suggestion);
|
||||||
|
|
||||||
|
await waitFor(() => {
|
||||||
|
expect(addToast).toHaveBeenCalledWith('Place search failed.', 'error', undefined);
|
||||||
|
});
|
||||||
|
delete window.__addToast;
|
||||||
|
});
|
||||||
|
|
||||||
it('FE-PLANNER-PLACEFORM-022: hasMapsKey=false shows OSM active message', () => {
|
it('FE-PLANNER-PLACEFORM-022: hasMapsKey=false shows OSM active message', () => {
|
||||||
// hasMapsKey is false by default in beforeEach
|
// hasMapsKey is false by default in beforeEach
|
||||||
render(<PlaceFormModal {...defaultProps} />);
|
render(<PlaceFormModal {...defaultProps} />);
|
||||||
@@ -304,17 +399,38 @@ describe('PlaceFormModal', () => {
|
|||||||
expect(screen.queryByTestId('time-picker')).not.toBeInTheDocument();
|
expect(screen.queryByTestId('time-picker')).not.toBeInTheDocument();
|
||||||
});
|
});
|
||||||
|
|
||||||
it('FE-PLANNER-PLACEFORM-026: time section IS shown in edit mode', () => {
|
it('FE-PLANNER-PLACEFORM-026: time section is hidden in edit mode when no assignment is in context', () => {
|
||||||
|
// Times are per day-assignment; editing a pool place with no day in context
|
||||||
|
// (assignmentId null) hides the fields, which otherwise would not persist (#1247)
|
||||||
const place = buildPlace({ name: 'Test' });
|
const place = buildPlace({ name: 'Test' });
|
||||||
render(<PlaceFormModal {...defaultProps} place={place} assignmentId={null} />);
|
render(<PlaceFormModal {...defaultProps} place={place} assignmentId={null} />);
|
||||||
// Time pickers are rendered when editing
|
expect(screen.queryByTestId('time-picker')).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('FE-PLANNER-PLACEFORM-026b: time section IS shown when an assignment is in context', () => {
|
||||||
|
const place = buildPlace({ name: 'Test', place_time: '09:00', end_time: '10:00' });
|
||||||
|
const assignment = buildAssignment({ id: 10, day_id: 5, place });
|
||||||
|
render(<PlaceFormModal {...defaultProps} place={place} assignmentId={10} dayAssignments={[assignment]} />);
|
||||||
expect(screen.getAllByTestId('time-picker').length).toBeGreaterThanOrEqual(2);
|
expect(screen.getAllByTestId('time-picker').length).toBeGreaterThanOrEqual(2);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it('FE-PLANNER-PLACEFORM-026c: hydrates Start/End from the assignment when the pool place lacks times (#1247)', () => {
|
||||||
|
// The pool Place carries no times — they live on the day-assignment. Opening the
|
||||||
|
// editor with an assignmentId must hydrate the fields from assignment.place, not
|
||||||
|
// the (timeless) pool place that the Places panel passes in.
|
||||||
|
const poolPlace = buildPlace({ id: 7, name: 'Museum' });
|
||||||
|
const assignmentPlace = buildPlace({ id: 7, name: 'Museum', place_time: '20:20', end_time: '20:34' });
|
||||||
|
const assignment = buildAssignment({ id: 42, day_id: 3, place: assignmentPlace });
|
||||||
|
render(<PlaceFormModal {...defaultProps} place={poolPlace} assignmentId={42} dayAssignments={[assignment]} />);
|
||||||
|
expect(screen.getByDisplayValue('20:20')).toBeInTheDocument();
|
||||||
|
expect(screen.getByDisplayValue('20:34')).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
it('FE-PLANNER-PLACEFORM-027: end-before-start error disables submit', () => {
|
it('FE-PLANNER-PLACEFORM-027: end-before-start error disables submit', () => {
|
||||||
// Build a place with end_time before place_time
|
// Build an assignment whose place has end_time before place_time
|
||||||
const place = buildPlace({ name: 'Test', place_time: '14:00', end_time: '13:00' });
|
const place = buildPlace({ name: 'Test', place_time: '14:00', end_time: '13:00' });
|
||||||
render(<PlaceFormModal {...defaultProps} place={place} assignmentId={null} />);
|
const assignment = buildAssignment({ id: 11, day_id: 5, place });
|
||||||
|
render(<PlaceFormModal {...defaultProps} place={place} assignmentId={11} dayAssignments={[assignment]} />);
|
||||||
|
|
||||||
// hasTimeError = true → submit button disabled
|
// hasTimeError = true → submit button disabled
|
||||||
const submitBtn = screen.getByRole('button', { name: /^Update$/i });
|
const submitBtn = screen.getByRole('button', { name: /^Update$/i });
|
||||||
|
|||||||
@@ -92,6 +92,11 @@ function usePlaceFormModal(props: PlaceFormModalProps) {
|
|||||||
|
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
if (place) {
|
if (place) {
|
||||||
|
// Times are stored per day-assignment, not on the pool place. When an
|
||||||
|
// assignment is in context (itinerary edit, or a single-assignment pool
|
||||||
|
// edit) read the times off its embedded place; fall back to the place prop.
|
||||||
|
const assignment = assignmentId ? dayAssignments.find(a => a.id === assignmentId) : null
|
||||||
|
const timeSource = assignment?.place ?? place
|
||||||
setForm({
|
setForm({
|
||||||
name: place.name || '',
|
name: place.name || '',
|
||||||
description: place.description || '',
|
description: place.description || '',
|
||||||
@@ -99,8 +104,8 @@ function usePlaceFormModal(props: PlaceFormModalProps) {
|
|||||||
lat: place.lat != null ? String(place.lat) : '',
|
lat: place.lat != null ? String(place.lat) : '',
|
||||||
lng: place.lng != null ? String(place.lng) : '',
|
lng: place.lng != null ? String(place.lng) : '',
|
||||||
category_id: place.category_id != null ? String(place.category_id) : '',
|
category_id: place.category_id != null ? String(place.category_id) : '',
|
||||||
place_time: place.place_time || '',
|
place_time: timeSource.place_time || '',
|
||||||
end_time: place.end_time || '',
|
end_time: timeSource.end_time || '',
|
||||||
notes: place.notes || '',
|
notes: place.notes || '',
|
||||||
transport_mode: place.transport_mode || 'walking',
|
transport_mode: place.transport_mode || 'walking',
|
||||||
website: place.website || '',
|
website: place.website || '',
|
||||||
@@ -121,7 +126,10 @@ function usePlaceFormModal(props: PlaceFormModalProps) {
|
|||||||
}
|
}
|
||||||
setPendingFiles([])
|
setPendingFiles([])
|
||||||
setDuplicateWarning(null)
|
setDuplicateWarning(null)
|
||||||
}, [place, prefillCoords, isOpen])
|
// dayAssignments is a fresh array each render; read it at open-time only and
|
||||||
|
// re-run on identity changes (place/assignmentId/open), not on every render.
|
||||||
|
// eslint-disable-next-line react-hooks/exhaustive-deps
|
||||||
|
}, [place, prefillCoords, isOpen, assignmentId])
|
||||||
|
|
||||||
// Derive location bias bounding box from the trip's existing places
|
// Derive location bias bounding box from the trip's existing places
|
||||||
const places = useTripStore((s) => s.places)
|
const places = useTripStore((s) => s.places)
|
||||||
@@ -209,6 +217,7 @@ function usePlaceFormModal(props: PlaceFormModalProps) {
|
|||||||
address: resolved.address || prev.address,
|
address: resolved.address || prev.address,
|
||||||
lat: String(resolved.lat),
|
lat: String(resolved.lat),
|
||||||
lng: String(resolved.lng),
|
lng: String(resolved.lng),
|
||||||
|
google_ftid: resolved.google_ftid || prev.google_ftid,
|
||||||
}))
|
}))
|
||||||
setMapsResults([])
|
setMapsResults([])
|
||||||
setMapsSearch('')
|
setMapsSearch('')
|
||||||
@@ -233,6 +242,7 @@ function usePlaceFormModal(props: PlaceFormModalProps) {
|
|||||||
lat: result.lat || prev.lat,
|
lat: result.lat || prev.lat,
|
||||||
lng: result.lng || prev.lng,
|
lng: result.lng || prev.lng,
|
||||||
google_place_id: result.google_place_id || prev.google_place_id,
|
google_place_id: result.google_place_id || prev.google_place_id,
|
||||||
|
google_ftid: result.google_ftid || prev.google_ftid,
|
||||||
osm_id: result.osm_id || prev.osm_id,
|
osm_id: result.osm_id || prev.osm_id,
|
||||||
website: result.website || prev.website,
|
website: result.website || prev.website,
|
||||||
phone: result.phone || prev.phone,
|
phone: result.phone || prev.phone,
|
||||||
@@ -249,15 +259,34 @@ function usePlaceFormModal(props: PlaceFormModalProps) {
|
|||||||
setForm(prev => ({ ...prev, name: suggestion.mainText }))
|
setForm(prev => ({ ...prev, name: suggestion.mainText }))
|
||||||
setIsSearchingMaps(true)
|
setIsSearchingMaps(true)
|
||||||
try {
|
try {
|
||||||
const result = await mapsApi.details(suggestion.placeId, language)
|
// The details lookup is a fragile second hop — it can fail when the
|
||||||
if (result.place) {
|
// details kill-switch is off, when the OSM Overpass mirror is overloaded,
|
||||||
handleSelectMapsResult(result.place)
|
// or on any upstream error. Treat a missing/coordinate-less place as a
|
||||||
|
// miss and fall back to the reliable text-search path the search button
|
||||||
|
// uses (its results already carry coordinates), so dropdown items stay
|
||||||
|
// clickable instead of dead-ending on "Place search failed". (#1192)
|
||||||
|
let place: Record<string, unknown> | null = null
|
||||||
|
try {
|
||||||
|
const result = await mapsApi.details(suggestion.placeId, language)
|
||||||
|
if (result.place && result.place.lat != null && result.place.lng != null) {
|
||||||
|
place = result.place
|
||||||
|
}
|
||||||
|
} catch (err) {
|
||||||
|
console.error('Failed to fetch place details:', err)
|
||||||
|
}
|
||||||
|
if (!place) {
|
||||||
|
const query = [suggestion.mainText, suggestion.secondaryText].filter(Boolean).join(', ')
|
||||||
|
const search = await mapsApi.search(query, language)
|
||||||
|
place = search.places?.[0] ?? null
|
||||||
|
}
|
||||||
|
if (place) {
|
||||||
|
handleSelectMapsResult(place)
|
||||||
} else {
|
} else {
|
||||||
setMapsSearch(previousSearch)
|
setMapsSearch(previousSearch)
|
||||||
toast.error(t('places.mapsSearchError'))
|
toast.error(t('places.mapsSearchError'))
|
||||||
}
|
}
|
||||||
} catch (err) {
|
} catch (err) {
|
||||||
console.error('Failed to fetch place details:', err)
|
console.error('Place suggestion lookup failed:', err)
|
||||||
setMapsSearch(previousSearch)
|
setMapsSearch(previousSearch)
|
||||||
toast.error(getApiErrorMessage(err, t('places.mapsSearchError')))
|
toast.error(getApiErrorMessage(err, t('places.mapsSearchError')))
|
||||||
} finally {
|
} finally {
|
||||||
@@ -709,8 +738,11 @@ export default function PlaceFormModal(props: PlaceFormModalProps) {
|
|||||||
)}
|
)}
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
{/* Time — only shown when editing, not when creating */}
|
{/* Time is per day-assignment: only shown when a single assignment is in
|
||||||
{place && (
|
context (itinerary edit, or a single-assignment pool edit). Hidden when
|
||||||
|
creating, and for unassigned / multi-day pool edits where a single time
|
||||||
|
is ambiguous and wouldn't persist. */}
|
||||||
|
{place && assignmentId && (
|
||||||
<TimeSection
|
<TimeSection
|
||||||
form={form}
|
form={form}
|
||||||
handleChange={handleChange}
|
handleChange={handleChange}
|
||||||
|
|||||||
@@ -618,6 +618,22 @@ describe('PlaceInspector', () => {
|
|||||||
expect(mapsBtn).toBeTruthy();
|
expect(mapsBtn).toBeTruthy();
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it('FE-PLANNER-INSPECTOR-043b: Google Maps action uses google_ftid over coordinates', async () => {
|
||||||
|
const user = userEvent.setup();
|
||||||
|
const mapsUrl = "https://www.google.com/maps/place/?q=St.%20Jacobs%20Farmers'%20Market&ftid=0x882bf179e806d471:0x8591dde29c821a93";
|
||||||
|
const openSpy = vi.spyOn(window, 'open').mockImplementation(() => null);
|
||||||
|
render(<PlaceInspector {...defaultProps} place={buildPlace({
|
||||||
|
name: "St. Jacobs Farmers' Market",
|
||||||
|
lat: 43.5118527,
|
||||||
|
lng: -80.5542617,
|
||||||
|
google_ftid: '0x882bf179e806d471:0x8591dde29c821a93',
|
||||||
|
})} />);
|
||||||
|
const mapsBtn = screen.getAllByRole('button').find(btn => btn.textContent?.includes('Google Maps'))!;
|
||||||
|
await user.click(mapsBtn);
|
||||||
|
expect(openSpy).toHaveBeenCalledWith(mapsUrl, '_blank');
|
||||||
|
openSpy.mockRestore();
|
||||||
|
});
|
||||||
|
|
||||||
// ── No files section when no upload handler and no files ──────────────────
|
// ── No files section when no upload handler and no files ──────────────────
|
||||||
|
|
||||||
it('FE-PLANNER-INSPECTOR-044: files section hidden when no files and no onFileUpload', () => {
|
it('FE-PLANNER-INSPECTOR-044: files section hidden when no files and no onFileUpload', () => {
|
||||||
@@ -647,5 +663,42 @@ describe('PlaceInspector', () => {
|
|||||||
expect(screen.queryByText('Participants')).toBeNull();
|
expect(screen.queryByText('Participants')).toBeNull();
|
||||||
});
|
});
|
||||||
|
|
||||||
});
|
// ── Scroll / overflow (issue #1195) ──────────────────────────────────────
|
||||||
|
|
||||||
|
it('FE-PLANNER-INSPECTOR-046: content area is a bounded flex scroll region', () => {
|
||||||
|
const longText = 'Lorem ipsum dolor sit amet. '.repeat(200);
|
||||||
|
const p = buildPlace({ id: 200, description: longText, notes: longText } as any);
|
||||||
|
render(<PlaceInspector {...defaultProps} place={p} />);
|
||||||
|
const scroll = screen.getByTestId('inspector-scroll') as HTMLElement;
|
||||||
|
expect(scroll.style.overflowY).toBe('auto');
|
||||||
|
expect(scroll.style.minHeight).toBe('0px');
|
||||||
|
// flex must allow the region to shrink/grow within the capped card
|
||||||
|
expect(scroll.style.flex).not.toBe('');
|
||||||
|
expect(scroll.style.flex).not.toBe('0 0 auto');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('FE-PLANNER-INSPECTOR-047: long unbroken description wraps instead of clipping horizontally', () => {
|
||||||
|
const longWord = 'https://example.com/' + 'a'.repeat(300);
|
||||||
|
const p = buildPlace({ id: 201, description: longWord } as any);
|
||||||
|
const { container } = render(<PlaceInspector {...defaultProps} place={p} />);
|
||||||
|
const descDiv = container.querySelector('.collab-note-md') as HTMLElement;
|
||||||
|
expect(descDiv).toBeTruthy();
|
||||||
|
expect(descDiv.style.overflowWrap).toBe('anywhere');
|
||||||
|
expect(descDiv.style.wordBreak).toBe('break-word');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('FE-PLANNER-INSPECTOR-048: description/notes do not shrink so the card scrolls instead of clipping', () => {
|
||||||
|
const longText = 'Lorem ipsum dolor sit amet. '.repeat(200);
|
||||||
|
const p = buildPlace({ id: 202, description: longText, notes: longText } as any);
|
||||||
|
const { container } = render(<PlaceInspector {...defaultProps} place={p} />);
|
||||||
|
const notes = Array.from(container.querySelectorAll('.collab-note-md')) as HTMLElement[];
|
||||||
|
// Both description and notes containers must keep their natural height
|
||||||
|
// (flex-shrink: 0) — otherwise they compress inside the flex column and
|
||||||
|
// overflow:hidden clips the text with no scroll (issue #1195).
|
||||||
|
expect(notes.length).toBe(2);
|
||||||
|
for (const el of notes) {
|
||||||
|
expect(el.style.flexShrink).toBe('0');
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
});
|
||||||
|
|||||||
@@ -12,6 +12,8 @@ import { useToast } from '../shared/Toast'
|
|||||||
import { useTranslation } from '../../i18n'
|
import { useTranslation } from '../../i18n'
|
||||||
import type { Place, Category, Day, Assignment, Reservation, TripFile, AssignmentsMap } from '../../types'
|
import type { Place, Category, Day, Assignment, Reservation, TripFile, AssignmentsMap } from '../../types'
|
||||||
import { splitReservationDateTime, formatTime } from '../../utils/formatters'
|
import { splitReservationDateTime, formatTime } from '../../utils/formatters'
|
||||||
|
import { formatDistance, formatElevation } from '../../utils/units'
|
||||||
|
import { getGoogleMapsUrlForPlace } from './placeGoogleMaps'
|
||||||
|
|
||||||
const detailsCache = new Map()
|
const detailsCache = new Map()
|
||||||
|
|
||||||
@@ -122,6 +124,7 @@ export default function PlaceInspector({
|
|||||||
const { t, locale, language } = useTranslation()
|
const { t, locale, language } = useTranslation()
|
||||||
const toast = useToast()
|
const toast = useToast()
|
||||||
const timeFormat = useSettingsStore(s => s.settings.time_format) || '24h'
|
const timeFormat = useSettingsStore(s => s.settings.time_format) || '24h'
|
||||||
|
const distanceUnit = useSettingsStore(s => s.settings.distance_unit) || 'metric'
|
||||||
const [hoursExpanded, setHoursExpanded] = useState(false)
|
const [hoursExpanded, setHoursExpanded] = useState(false)
|
||||||
const [filesExpanded, setFilesExpanded] = useState(false)
|
const [filesExpanded, setFilesExpanded] = useState(false)
|
||||||
const [isUploading, setIsUploading] = useState(false)
|
const [isUploading, setIsUploading] = useState(false)
|
||||||
@@ -162,6 +165,11 @@ export default function PlaceInspector({
|
|||||||
|
|
||||||
const openingHours = googleDetails?.opening_hours || null
|
const openingHours = googleDetails?.opening_hours || null
|
||||||
const openNow = googleDetails?.open_now ?? null
|
const openNow = googleDetails?.open_now ?? null
|
||||||
|
// Prefer the place's stored ftid; if it has none yet, use the one just fetched from Google.
|
||||||
|
const googleMapsUrl = getGoogleMapsUrlForPlace(
|
||||||
|
place ? { ...place, google_ftid: place.google_ftid || googleDetails?.google_ftid || null } : null,
|
||||||
|
googleDetails?.google_maps_url,
|
||||||
|
)
|
||||||
const selectedDay = days?.find(d => d.id === selectedDayId)
|
const selectedDay = days?.find(d => d.id === selectedDayId)
|
||||||
const weekdayIndex = getWeekdayIndex(selectedDay?.date)
|
const weekdayIndex = getWeekdayIndex(selectedDay?.date)
|
||||||
|
|
||||||
@@ -217,7 +225,7 @@ export default function PlaceInspector({
|
|||||||
locale={locale} timeFormat={timeFormat} onClose={onClose} />
|
locale={locale} timeFormat={timeFormat} onClose={onClose} />
|
||||||
|
|
||||||
{/* Content — scrollable */}
|
{/* Content — scrollable */}
|
||||||
<div style={{ overflowY: 'auto', padding: '12px 16px', display: 'flex', flexDirection: 'column', gap: 10 }}>
|
<div data-testid="inspector-scroll" style={{ flex: '1 1 auto', minHeight: 0, overflowY: 'auto', WebkitOverflowScrolling: 'touch', overscrollBehavior: 'contain', padding: '12px 16px', display: 'flex', flexDirection: 'column', gap: 10 }}>
|
||||||
|
|
||||||
{/* Info-Chips — hidden on mobile, shown on desktop */}
|
{/* Info-Chips — hidden on mobile, shown on desktop */}
|
||||||
<div className="hidden sm:flex" style={{ flexWrap: 'wrap', gap: 6, alignItems: 'center' }}>
|
<div className="hidden sm:flex" style={{ flexWrap: 'wrap', gap: 6, alignItems: 'center' }}>
|
||||||
@@ -253,14 +261,14 @@ export default function PlaceInspector({
|
|||||||
|
|
||||||
{/* Description / Summary */}
|
{/* Description / Summary */}
|
||||||
{(place.description || googleDetails?.summary) && (
|
{(place.description || googleDetails?.summary) && (
|
||||||
<div className="collab-note-md bg-surface-hover text-content-muted" style={{ borderRadius: 10, overflow: 'hidden', fontSize: 12, lineHeight: '1.5', padding: '8px 12px' }}>
|
<div className="collab-note-md bg-surface-hover text-content-muted" style={{ borderRadius: 10, overflow: 'hidden', flexShrink: 0, fontSize: 12, lineHeight: '1.5', padding: '8px 12px', wordBreak: 'break-word', overflowWrap: 'anywhere' }}>
|
||||||
<Markdown remarkPlugins={[remarkGfm, remarkBreaks]}>{place.description || googleDetails?.summary || ''}</Markdown>
|
<Markdown remarkPlugins={[remarkGfm, remarkBreaks]}>{place.description || googleDetails?.summary || ''}</Markdown>
|
||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
|
|
||||||
{/* Notes */}
|
{/* Notes */}
|
||||||
{place.notes && (
|
{place.notes && (
|
||||||
<div className="collab-note-md bg-surface-hover text-content-muted" style={{ borderRadius: 10, overflow: 'hidden', fontSize: 12, lineHeight: '1.5', padding: '8px 12px', wordBreak: 'break-word', overflowWrap: 'anywhere' }}>
|
<div className="collab-note-md bg-surface-hover text-content-muted" style={{ borderRadius: 10, overflow: 'hidden', flexShrink: 0, fontSize: 12, lineHeight: '1.5', padding: '8px 12px', wordBreak: 'break-word', overflowWrap: 'anywhere' }}>
|
||||||
<Markdown remarkPlugins={[remarkGfm, remarkBreaks]}>{place.notes}</Markdown>
|
<Markdown remarkPlugins={[remarkGfm, remarkBreaks]}>{place.notes}</Markdown>
|
||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
@@ -274,12 +282,13 @@ export default function PlaceInspector({
|
|||||||
<PlaceExtras openingHours={openingHours} weekdayIndex={weekdayIndex} hoursExpanded={hoursExpanded}
|
<PlaceExtras openingHours={openingHours} weekdayIndex={weekdayIndex} hoursExpanded={hoursExpanded}
|
||||||
setHoursExpanded={setHoursExpanded} timeFormat={timeFormat} t={t} place={place} placeFiles={placeFiles}
|
setHoursExpanded={setHoursExpanded} timeFormat={timeFormat} t={t} place={place} placeFiles={placeFiles}
|
||||||
onFileUpload={onFileUpload} filesExpanded={filesExpanded} setFilesExpanded={setFilesExpanded}
|
onFileUpload={onFileUpload} filesExpanded={filesExpanded} setFilesExpanded={setFilesExpanded}
|
||||||
fileInputRef={fileInputRef} handleFileUpload={handleFileUpload} isUploading={isUploading} />
|
fileInputRef={fileInputRef} handleFileUpload={handleFileUpload} isUploading={isUploading}
|
||||||
|
distanceUnit={distanceUnit} />
|
||||||
|
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
{/* Footer actions */}
|
{/* Footer actions */}
|
||||||
<div className="border-t border-edge-faint" style={{ padding: '10px 16px', display: 'flex', gap: 6, alignItems: 'center', flexWrap: 'wrap' }}>
|
<div className="border-t border-edge-faint" style={{ padding: '10px 16px', display: 'flex', gap: 6, alignItems: 'center', flexWrap: 'wrap', flexShrink: 0 }}>
|
||||||
{selectedDayId && (
|
{selectedDayId && (
|
||||||
assignmentInDay ? (
|
assignmentInDay ? (
|
||||||
<ActionButton onClick={() => onRemoveAssignment(selectedDayId, assignmentInDay.id)} variant="ghost" icon={<Minus size={13} />}
|
<ActionButton onClick={() => onRemoveAssignment(selectedDayId, assignmentInDay.id)} variant="ghost" icon={<Minus size={13} />}
|
||||||
@@ -288,14 +297,10 @@ export default function PlaceInspector({
|
|||||||
<ActionButton onClick={() => onAssignToDay(place.id)} variant="primary" icon={<Plus size={13} />} label={t('inspector.addToDay')} />
|
<ActionButton onClick={() => onAssignToDay(place.id)} variant="primary" icon={<Plus size={13} />} label={t('inspector.addToDay')} />
|
||||||
)
|
)
|
||||||
)}
|
)}
|
||||||
{googleDetails?.google_maps_url && (
|
{googleMapsUrl && (
|
||||||
<ActionButton onClick={() => window.open(googleDetails.google_maps_url, '_blank')} variant="ghost" icon={<Navigation size={13} />}
|
<ActionButton onClick={() => window.open(googleMapsUrl, '_blank')} variant="ghost" icon={<Navigation size={13} />}
|
||||||
label={<span className="hidden sm:inline">{t('inspector.google')}</span>} />
|
label={<span className="hidden sm:inline">{t('inspector.google')}</span>} />
|
||||||
)}
|
)}
|
||||||
{!googleDetails?.google_maps_url && place.lat && place.lng && (
|
|
||||||
<ActionButton onClick={() => window.open(`https://www.google.com/maps/search/?api=1&query=${place.google_place_id ? encodeURIComponent(place.name) + '&query_place_id=' + place.google_place_id : place.lat + ',' + place.lng}`, '_blank')} variant="ghost" icon={<Navigation size={13} />}
|
|
||||||
label={<span className="hidden sm:inline">Google Maps</span>} />
|
|
||||||
)}
|
|
||||||
{(place.website || googleDetails?.website) && (
|
{(place.website || googleDetails?.website) && (
|
||||||
<ActionButton onClick={() => window.open(place.website || googleDetails?.website, '_blank')} variant="ghost" icon={<ExternalLink size={13} />}
|
<ActionButton onClick={() => window.open(place.website || googleDetails?.website, '_blank')} variant="ghost" icon={<ExternalLink size={13} />}
|
||||||
label={<span className="hidden sm:inline">{t('inspector.website')}</span>} />
|
label={<span className="hidden sm:inline">{t('inspector.website')}</span>} />
|
||||||
@@ -497,7 +502,7 @@ function ParticipantsBox({ tripMembers, participantIds, allJoined, onSetParticip
|
|||||||
function PlaceInspectorHeader({ openNow, place, category, t, editingName, nameInputRef, nameValue, setNameValue,
|
function PlaceInspectorHeader({ openNow, place, category, t, editingName, nameInputRef, nameValue, setNameValue,
|
||||||
commitNameEdit, handleNameKeyDown, startNameEdit, onUpdatePlace, locale, timeFormat, onClose }: any) {
|
commitNameEdit, handleNameKeyDown, startNameEdit, onUpdatePlace, locale, timeFormat, onClose }: any) {
|
||||||
return (
|
return (
|
||||||
<div style={{ display: 'flex', alignItems: 'center', gap: openNow !== null ? 26 : 14, padding: openNow !== null ? '18px 16px 14px 28px' : '18px 16px 14px', borderBottom: '1px solid var(--border-faint)' }}>
|
<div style={{ display: 'flex', alignItems: 'center', gap: openNow !== null ? 26 : 14, padding: openNow !== null ? '18px 16px 14px 28px' : '18px 16px 14px', borderBottom: '1px solid var(--border-faint)', flexShrink: 0 }}>
|
||||||
{/* Avatar with open/closed ring + tag */}
|
{/* Avatar with open/closed ring + tag */}
|
||||||
<div style={{ position: 'relative', flexShrink: 0, marginBottom: openNow !== null ? 8 : 0 }}>
|
<div style={{ position: 'relative', flexShrink: 0, marginBottom: openNow !== null ? 8 : 0 }}>
|
||||||
<div style={{
|
<div style={{
|
||||||
@@ -682,7 +687,7 @@ function PlaceReservationParticipants({ selectedAssignmentId, reservations, assi
|
|||||||
}
|
}
|
||||||
|
|
||||||
function PlaceExtras({ openingHours, weekdayIndex, hoursExpanded, setHoursExpanded, timeFormat, t, place,
|
function PlaceExtras({ openingHours, weekdayIndex, hoursExpanded, setHoursExpanded, timeFormat, t, place,
|
||||||
placeFiles, onFileUpload, filesExpanded, setFilesExpanded, fileInputRef, handleFileUpload, isUploading }: any) {
|
placeFiles, onFileUpload, filesExpanded, setFilesExpanded, fileInputRef, handleFileUpload, isUploading, distanceUnit }: any) {
|
||||||
return (
|
return (
|
||||||
<div className={`grid grid-cols-1 ${openingHours?.length > 0 ? 'sm:grid-cols-2' : ''} gap-2`}>
|
<div className={`grid grid-cols-1 ${openingHours?.length > 0 ? 'sm:grid-cols-2' : ''} gap-2`}>
|
||||||
{openingHours && openingHours.length > 0 && (
|
{openingHours && openingHours.length > 0 && (
|
||||||
@@ -775,20 +780,20 @@ function PlaceExtras({ openingHours, weekdayIndex, hoursExpanded, setHoursExpand
|
|||||||
<div style={{ display: 'flex', flexWrap: 'wrap', gap: 8 }}>
|
<div style={{ display: 'flex', flexWrap: 'wrap', gap: 8 }}>
|
||||||
<div className="text-content" style={{ display: 'flex', alignItems: 'center', gap: 4, fontSize: 12, fontWeight: 600 }}>
|
<div className="text-content" style={{ display: 'flex', alignItems: 'center', gap: 4, fontSize: 12, fontWeight: 600 }}>
|
||||||
<MapPin size={12} color="#3b82f6" />
|
<MapPin size={12} color="#3b82f6" />
|
||||||
{distKm < 1 ? `${Math.round(totalDist)} m` : `${distKm.toFixed(1)} km`}
|
{formatDistance(distKm, distanceUnit)}
|
||||||
</div>
|
</div>
|
||||||
{hasEle && (
|
{hasEle && (
|
||||||
<>
|
<>
|
||||||
<div className="text-content" style={{ display: 'flex', alignItems: 'center', gap: 4, fontSize: 12, fontWeight: 600 }}>
|
<div className="text-content" style={{ display: 'flex', alignItems: 'center', gap: 4, fontSize: 12, fontWeight: 600 }}>
|
||||||
<Mountain size={12} color="#22c55e" />
|
<Mountain size={12} color="#22c55e" />
|
||||||
{Math.round(maxEle)} m
|
{formatElevation(maxEle, distanceUnit)}
|
||||||
</div>
|
</div>
|
||||||
<div className="text-content" style={{ display: 'flex', alignItems: 'center', gap: 4, fontSize: 12, fontWeight: 600 }}>
|
<div className="text-content" style={{ display: 'flex', alignItems: 'center', gap: 4, fontSize: 12, fontWeight: 600 }}>
|
||||||
<Mountain size={12} color="#ef4444" />
|
<Mountain size={12} color="#ef4444" />
|
||||||
{Math.round(minEle)} m
|
{formatElevation(minEle, distanceUnit)}
|
||||||
</div>
|
</div>
|
||||||
<div className="text-content-muted" style={{ fontSize: 12 }}>
|
<div className="text-content-muted" style={{ fontSize: 12 }}>
|
||||||
↑{Math.round(totalUp)} m ↓{Math.round(totalDown)} m
|
↑{formatElevation(totalUp, distanceUnit)} ↓{formatElevation(totalDown, distanceUnit)}
|
||||||
</div>
|
</div>
|
||||||
</>
|
</>
|
||||||
)}
|
)}
|
||||||
|
|||||||
@@ -124,6 +124,40 @@ describe('PlacesSidebar', () => {
|
|||||||
expect(screen.getByText('Central Park')).toBeInTheDocument();
|
expect(screen.getByText('Central Park')).toBeInTheDocument();
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it('FE-COMP-PLACES-009a: selected visible place is scrolled into view', async () => {
|
||||||
|
const scrollIntoView = Element.prototype.scrollIntoView as unknown as ReturnType<typeof vi.fn>;
|
||||||
|
scrollIntoView.mockClear();
|
||||||
|
const places = [
|
||||||
|
buildPlace({ id: 10, name: 'First Place' }),
|
||||||
|
buildPlace({ id: 42, name: 'Map Click Target' }),
|
||||||
|
];
|
||||||
|
|
||||||
|
render(<PlacesSidebar {...defaultProps} places={places} selectedPlaceId={42} />);
|
||||||
|
|
||||||
|
const selectedRow = screen.getByText('Map Click Target').closest('[data-place-id="42"]');
|
||||||
|
expect(selectedRow).toHaveAttribute('aria-selected', 'true');
|
||||||
|
await waitFor(() => {
|
||||||
|
expect(scrollIntoView).toHaveBeenCalledWith({ behavior: 'smooth', block: 'center' });
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it('FE-COMP-PLACES-009b: selected place hidden by search is not scrolled', async () => {
|
||||||
|
const user = userEvent.setup();
|
||||||
|
const scrollIntoView = Element.prototype.scrollIntoView as unknown as ReturnType<typeof vi.fn>;
|
||||||
|
const places = [
|
||||||
|
buildPlace({ id: 10, name: 'Visible Cafe' }),
|
||||||
|
buildPlace({ id: 42, name: 'Hidden Museum' }),
|
||||||
|
];
|
||||||
|
const { rerender } = render(<PlacesSidebar {...defaultProps} places={places} selectedPlaceId={null} />);
|
||||||
|
|
||||||
|
await user.type(screen.getByPlaceholderText(/Search places/i), 'Visible');
|
||||||
|
scrollIntoView.mockClear();
|
||||||
|
rerender(<PlacesSidebar {...defaultProps} places={places} selectedPlaceId={42} />);
|
||||||
|
|
||||||
|
expect(screen.queryByText('Hidden Museum')).not.toBeInTheDocument();
|
||||||
|
expect(scrollIntoView).not.toHaveBeenCalled();
|
||||||
|
});
|
||||||
|
|
||||||
it('FE-COMP-PLACES-010: shows place count', () => {
|
it('FE-COMP-PLACES-010: shows place count', () => {
|
||||||
const places = [buildPlace({ name: 'P1' }), buildPlace({ name: 'P2' }), buildPlace({ name: 'P3' })];
|
const places = [buildPlace({ name: 'P1' }), buildPlace({ name: 'P2' }), buildPlace({ name: 'P3' })];
|
||||||
render(<PlacesSidebar {...defaultProps} places={places} />);
|
render(<PlacesSidebar {...defaultProps} places={places} />);
|
||||||
|
|||||||
@@ -5,7 +5,7 @@ export function PlacesList(S: SidebarState) {
|
|||||||
const {
|
const {
|
||||||
filtered, scrollContainerRef, onScrollTopChange, filter, t, canEditPlaces, onAddPlace,
|
filtered, scrollContainerRef, onScrollTopChange, filter, t, canEditPlaces, onAddPlace,
|
||||||
categories, selectedPlaceId, plannedIds, inDaySet, selectedIds, selectMode, selectedDayId,
|
categories, selectedPlaceId, plannedIds, inDaySet, selectedIds, selectMode, selectedDayId,
|
||||||
isMobile, onPlaceClick, openContextMenu, onAssignToDay, toggleSelected, setDayPickerPlace,
|
isMobile, onPlaceClick, openContextMenu, onAssignToDay, toggleSelected, setDayPickerPlace, registerPlaceRow,
|
||||||
} = S
|
} = S
|
||||||
return (
|
return (
|
||||||
<div className="trek-stagger" style={{ flex: 1, overflowY: 'auto', minHeight: 0 }} ref={scrollContainerRef} onScroll={(e) => onScrollTopChange?.((e.currentTarget as HTMLElement).scrollTop)}>
|
<div className="trek-stagger" style={{ flex: 1, overflowY: 'auto', minHeight: 0 }} ref={scrollContainerRef} onScroll={(e) => onScrollTopChange?.((e.currentTarget as HTMLElement).scrollTop)}>
|
||||||
@@ -44,6 +44,7 @@ export function PlacesList(S: SidebarState) {
|
|||||||
onAssignToDay={onAssignToDay}
|
onAssignToDay={onAssignToDay}
|
||||||
toggleSelected={toggleSelected}
|
toggleSelected={toggleSelected}
|
||||||
setDayPickerPlace={setDayPickerPlace}
|
setDayPickerPlace={setDayPickerPlace}
|
||||||
|
registerPlaceRow={registerPlaceRow}
|
||||||
/>
|
/>
|
||||||
)
|
)
|
||||||
})
|
})
|
||||||
|
|||||||
@@ -21,17 +21,21 @@ interface MemoPlaceRowProps {
|
|||||||
onAssignToDay: (placeId: number, dayId?: number) => void
|
onAssignToDay: (placeId: number, dayId?: number) => void
|
||||||
toggleSelected: (id: number) => void
|
toggleSelected: (id: number) => void
|
||||||
setDayPickerPlace: (place: any) => void
|
setDayPickerPlace: (place: any) => void
|
||||||
|
registerPlaceRow: (placeId: number, element: HTMLDivElement | null) => void
|
||||||
}
|
}
|
||||||
|
|
||||||
export const MemoPlaceRow = React.memo(function MemoPlaceRow({
|
export const MemoPlaceRow = React.memo(function MemoPlaceRow({
|
||||||
place, category: cat, isSelected, isPlanned, inDay, isChecked,
|
place, category: cat, isSelected, isPlanned, inDay, isChecked,
|
||||||
selectMode, selectedDayId, canEditPlaces, isMobile, t,
|
selectMode, selectedDayId, canEditPlaces, isMobile, t,
|
||||||
onPlaceClick, onContextMenu, onAssignToDay, toggleSelected, setDayPickerPlace,
|
onPlaceClick, onContextMenu, onAssignToDay, toggleSelected, setDayPickerPlace, registerPlaceRow,
|
||||||
}: MemoPlaceRowProps) {
|
}: MemoPlaceRowProps) {
|
||||||
const hasGeometry = Boolean(place.route_geometry)
|
const hasGeometry = Boolean(place.route_geometry)
|
||||||
return (
|
return (
|
||||||
<div
|
<div
|
||||||
key={place.id}
|
key={place.id}
|
||||||
|
ref={element => registerPlaceRow(place.id, element)}
|
||||||
|
aria-selected={isSelected}
|
||||||
|
data-place-id={place.id}
|
||||||
draggable={!selectMode}
|
draggable={!selectMode}
|
||||||
onDragStart={e => {
|
onDragStart={e => {
|
||||||
e.dataTransfer.setData('placeId', String(place.id))
|
e.dataTransfer.setData('placeId', String(place.id))
|
||||||
|
|||||||
@@ -343,56 +343,51 @@ describe('ReservationModal', () => {
|
|||||||
|
|
||||||
// ── Budget addon ─────────────────────────────────────────────────────────────
|
// ── Budget addon ─────────────────────────────────────────────────────────────
|
||||||
|
|
||||||
it('FE-PLANNER-RESMODAL-024: budget section visible when budget addon is enabled', () => {
|
it('FE-PLANNER-RESMODAL-024: costs section (create expense) visible when budget addon is enabled', () => {
|
||||||
seedStore(useAddonStore, {
|
seedStore(useAddonStore, {
|
||||||
addons: [{ id: 'budget', name: 'Budget', type: 'budget', icon: '', enabled: true }],
|
addons: [{ id: 'budget', name: 'Budget', type: 'budget', icon: '', enabled: true }],
|
||||||
loaded: true,
|
loaded: true,
|
||||||
});
|
});
|
||||||
render(<ReservationModal {...defaultProps} />);
|
render(<ReservationModal {...defaultProps} />);
|
||||||
expect(screen.getByText(/^Price$/i)).toBeInTheDocument();
|
expect(screen.getByRole('button', { name: /Create expense/i })).toBeInTheDocument();
|
||||||
expect(screen.getByText(/Budget category/i)).toBeInTheDocument();
|
|
||||||
});
|
});
|
||||||
|
|
||||||
it('FE-PLANNER-RESMODAL-025: budget price input accepts valid decimal', async () => {
|
it('FE-PLANNER-RESMODAL-025: create-expense saves the booking (no create_budget_entry) then opens the Costs editor', async () => {
|
||||||
seedStore(useAddonStore, {
|
seedStore(useAddonStore, {
|
||||||
addons: [{ id: 'budget', name: 'Budget', type: 'budget', icon: '', enabled: true }],
|
addons: [{ id: 'budget', name: 'Budget', type: 'budget', icon: '', enabled: true }],
|
||||||
loaded: true,
|
loaded: true,
|
||||||
});
|
});
|
||||||
render(<ReservationModal {...defaultProps} />);
|
const onSave = vi.fn().mockResolvedValue({ id: 55 });
|
||||||
const priceInput = screen.getByPlaceholderText('0.00');
|
const onOpenExpense = vi.fn();
|
||||||
await userEvent.type(priceInput, '99.99');
|
render(<ReservationModal {...defaultProps} onSave={onSave} onOpenExpense={onOpenExpense} />);
|
||||||
expect((priceInput as HTMLInputElement).value).toBe('99.99');
|
|
||||||
});
|
|
||||||
|
|
||||||
it('FE-PLANNER-RESMODAL-026: budget hint shown when price > 0', async () => {
|
|
||||||
seedStore(useAddonStore, {
|
|
||||||
addons: [{ id: 'budget', name: 'Budget', type: 'budget', icon: '', enabled: true }],
|
|
||||||
loaded: true,
|
|
||||||
});
|
|
||||||
render(<ReservationModal {...defaultProps} />);
|
|
||||||
const priceInput = screen.getByPlaceholderText('0.00');
|
|
||||||
await userEvent.type(priceInput, '50');
|
|
||||||
expect(screen.getByText(/budget entry will be created/i)).toBeInTheDocument();
|
|
||||||
});
|
|
||||||
|
|
||||||
it('FE-PLANNER-RESMODAL-027: budget fields included in onSave when price is set', async () => {
|
|
||||||
seedStore(useAddonStore, {
|
|
||||||
addons: [{ id: 'budget', name: 'Budget', type: 'budget', icon: '', enabled: true }],
|
|
||||||
loaded: true,
|
|
||||||
});
|
|
||||||
const onSave = vi.fn().mockResolvedValue(undefined);
|
|
||||||
render(<ReservationModal {...defaultProps} onSave={onSave} />);
|
|
||||||
|
|
||||||
await userEvent.type(screen.getByPlaceholderText(/e\.g\. Lufthansa/i), 'Hotel Paris');
|
await userEvent.type(screen.getByPlaceholderText(/e\.g\. Lufthansa/i), 'Hotel Paris');
|
||||||
await userEvent.type(screen.getByPlaceholderText('0.00'), '120');
|
await userEvent.click(screen.getByRole('button', { name: /Create expense/i }));
|
||||||
await userEvent.click(screen.getByRole('button', { name: /^Add$/i }));
|
|
||||||
|
|
||||||
await waitFor(() => expect(onSave).toHaveBeenCalled());
|
await waitFor(() => expect(onSave).toHaveBeenCalled());
|
||||||
expect(onSave).toHaveBeenCalledWith(
|
expect(onSave).not.toHaveBeenCalledWith(expect.objectContaining({ create_budget_entry: expect.anything() }));
|
||||||
expect.objectContaining({ create_budget_entry: expect.objectContaining({ total_price: 120 }) })
|
await waitFor(() =>
|
||||||
|
expect(onOpenExpense).toHaveBeenCalledWith(
|
||||||
|
expect.objectContaining({ prefill: expect.objectContaining({ reservationId: 55 }) })
|
||||||
|
)
|
||||||
);
|
);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it('FE-PLANNER-RESMODAL-026: linked expense summary shown for a booking with a linked cost', () => {
|
||||||
|
seedStore(useAddonStore, {
|
||||||
|
addons: [{ id: 'budget', name: 'Budget', type: 'budget', icon: '', enabled: true }],
|
||||||
|
loaded: true,
|
||||||
|
});
|
||||||
|
seedStore(useTripStore, {
|
||||||
|
trip: buildTrip({ id: 1 }),
|
||||||
|
budgetItems: [
|
||||||
|
{ id: 7, trip_id: 1, name: 'Hotel deposit', total_price: 120, currency: 'EUR', category: 'accommodation', reservation_id: 9, members: [], payers: [], persons: 1, expense_date: null, paid_by_user_id: null },
|
||||||
|
],
|
||||||
|
});
|
||||||
|
render(<ReservationModal {...defaultProps} reservation={buildReservation({ id: 9, type: 'hotel', title: 'Hotel Paris' })} />);
|
||||||
|
expect(screen.getByText('Hotel deposit')).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
// ── File upload ───────────────────────────────────────────────────────────────
|
// ── File upload ───────────────────────────────────────────────────────────────
|
||||||
|
|
||||||
it('FE-PLANNER-RESMODAL-028: pending file added for new reservation on file input change', async () => {
|
it('FE-PLANNER-RESMODAL-028: pending file added for new reservation on file input change', async () => {
|
||||||
@@ -599,22 +594,6 @@ describe('ReservationModal', () => {
|
|||||||
expect(filePickerItem).toBeInTheDocument();
|
expect(filePickerItem).toBeInTheDocument();
|
||||||
});
|
});
|
||||||
|
|
||||||
it('FE-PLANNER-RESMODAL-044: budget category dropdown options include existing categories', () => {
|
|
||||||
seedStore(useAddonStore, {
|
|
||||||
addons: [{ id: 'budget', name: 'Budget', type: 'budget', icon: '', enabled: true }],
|
|
||||||
loaded: true,
|
|
||||||
});
|
|
||||||
seedStore(useTripStore, {
|
|
||||||
trip: buildTrip({ id: 1 }),
|
|
||||||
budgetItems: [
|
|
||||||
{ id: 1, trip_id: 1, name: 'Flight ticket', total_price: 300, category: 'Transport', paid_by_user_id: null, persons: 1, members: [], expense_date: null },
|
|
||||||
],
|
|
||||||
});
|
|
||||||
render(<ReservationModal {...defaultProps} />);
|
|
||||||
// Budget section is visible
|
|
||||||
expect(screen.getByText(/Budget category/i)).toBeInTheDocument();
|
|
||||||
});
|
|
||||||
|
|
||||||
it('FE-PLANNER-RESMODAL-045: tour type shows time pickers', async () => {
|
it('FE-PLANNER-RESMODAL-045: tour type shows time pickers', async () => {
|
||||||
render(<ReservationModal {...defaultProps} />);
|
render(<ReservationModal {...defaultProps} />);
|
||||||
await userEvent.click(screen.getByRole('button', { name: /^Tour$/i }));
|
await userEvent.click(screen.getByRole('button', { name: /^Tour$/i }));
|
||||||
@@ -632,31 +611,6 @@ describe('ReservationModal', () => {
|
|||||||
await waitFor(() => expect(onSave).toHaveBeenCalledWith(expect.objectContaining({ type: 'other' })));
|
await waitFor(() => expect(onSave).toHaveBeenCalledWith(expect.objectContaining({ type: 'other' })));
|
||||||
});
|
});
|
||||||
|
|
||||||
it('FE-PLANNER-RESMODAL-047: clicking budget category select changes the value', async () => {
|
|
||||||
seedStore(useAddonStore, {
|
|
||||||
addons: [{ id: 'budget', name: 'Budget', type: 'budget', icon: '', enabled: true }],
|
|
||||||
loaded: true,
|
|
||||||
});
|
|
||||||
seedStore(useTripStore, {
|
|
||||||
trip: buildTrip({ id: 1 }),
|
|
||||||
budgetItems: [
|
|
||||||
{ id: 1, trip_id: 1, name: 'Ticket', total_price: 100, category: 'Transport', paid_by_user_id: null, persons: 1, members: [], expense_date: null },
|
|
||||||
],
|
|
||||||
});
|
|
||||||
render(<ReservationModal {...defaultProps} />);
|
|
||||||
|
|
||||||
// Open the budget category CustomSelect (shows placeholder "Auto (from booking type)")
|
|
||||||
const budgetCategoryBtn = screen.getByText(/Auto \(from booking type\)/i).closest('button')!;
|
|
||||||
await userEvent.click(budgetCategoryBtn);
|
|
||||||
|
|
||||||
// Click the "Transport" category option
|
|
||||||
await waitFor(() => expect(screen.getByText('Transport')).toBeInTheDocument());
|
|
||||||
await userEvent.click(screen.getByText('Transport'));
|
|
||||||
|
|
||||||
// The select should now show "Transport"
|
|
||||||
expect(screen.getByText('Transport')).toBeInTheDocument();
|
|
||||||
});
|
|
||||||
|
|
||||||
it('FE-PLANNER-RESMODAL-048: clicking attach file button triggers file input', async () => {
|
it('FE-PLANNER-RESMODAL-048: clicking attach file button triggers file input', async () => {
|
||||||
render(<ReservationModal {...defaultProps} />);
|
render(<ReservationModal {...defaultProps} />);
|
||||||
const attachBtn = screen.getByRole('button', { name: /Attach file/i });
|
const attachBtn = screen.getByRole('button', { name: /Attach file/i });
|
||||||
|
|||||||
@@ -11,7 +11,10 @@ import { useTranslation } from '../../i18n'
|
|||||||
import { CustomDatePicker } from '../shared/CustomDateTimePicker'
|
import { CustomDatePicker } from '../shared/CustomDateTimePicker'
|
||||||
import CustomTimePicker from '../shared/CustomTimePicker'
|
import CustomTimePicker from '../shared/CustomTimePicker'
|
||||||
import { openFile } from '../../utils/fileDownload'
|
import { openFile } from '../../utils/fileDownload'
|
||||||
import type { Day, Place, Reservation, TripFile, AssignmentsMap, Accommodation } from '../../types'
|
import type { Day, Place, Reservation, TripFile, AssignmentsMap, Accommodation, BudgetItem } from '../../types'
|
||||||
|
import { BookingCostsSection } from './BookingCostsSection'
|
||||||
|
import type { BookingExpenseRequest } from './BookingCostsSection.types'
|
||||||
|
import { typeToCostCategory } from '@trek/shared'
|
||||||
|
|
||||||
const TYPE_OPTIONS = [
|
const TYPE_OPTIONS = [
|
||||||
{ value: 'hotel', labelKey: 'reservations.type.hotel', Icon: Hotel },
|
{ value: 'hotel', labelKey: 'reservations.type.hotel', Icon: Hotel },
|
||||||
@@ -60,9 +63,10 @@ interface ReservationModalProps {
|
|||||||
onFileDelete: (fileId: number) => Promise<void>
|
onFileDelete: (fileId: number) => Promise<void>
|
||||||
accommodations?: Accommodation[]
|
accommodations?: Accommodation[]
|
||||||
defaultAssignmentId?: number | null
|
defaultAssignmentId?: number | null
|
||||||
|
onOpenExpense?: (req: BookingExpenseRequest) => void
|
||||||
}
|
}
|
||||||
|
|
||||||
export function ReservationModal({ isOpen, onClose, onSave, reservation, days, places, assignments, selectedDayId, files = [], onFileUpload, onFileDelete, accommodations = [], defaultAssignmentId = null }: ReservationModalProps) {
|
export function ReservationModal({ isOpen, onClose, onSave, reservation, days, places, assignments, selectedDayId, files = [], onFileUpload, onFileDelete, accommodations = [], defaultAssignmentId = null, onOpenExpense }: ReservationModalProps) {
|
||||||
const { id: tripId } = useParams<{ id: string }>()
|
const { id: tripId } = useParams<{ id: string }>()
|
||||||
const loadFiles = useTripStore(s => s.loadFiles)
|
const loadFiles = useTripStore(s => s.loadFiles)
|
||||||
const toast = useToast()
|
const toast = useToast()
|
||||||
@@ -70,18 +74,14 @@ export function ReservationModal({ isOpen, onClose, onSave, reservation, days, p
|
|||||||
const fileInputRef = useRef(null)
|
const fileInputRef = useRef(null)
|
||||||
|
|
||||||
const isBudgetEnabled = useAddonStore(s => s.isEnabled('budget'))
|
const isBudgetEnabled = useAddonStore(s => s.isEnabled('budget'))
|
||||||
const budgetItems = useTripStore(s => s.budgetItems)
|
const deleteBudgetItem = useTripStore(s => s.deleteBudgetItem)
|
||||||
const budgetCategories = useMemo(() => {
|
// Set right before submit when the user clicked create/edit expense (see TransportModal).
|
||||||
const cats = new Set<string>()
|
const expenseIntentRef = useRef<{ editItem?: BudgetItem; create?: boolean } | null>(null)
|
||||||
budgetItems.forEach(i => { if (i.category) cats.add(i.category) })
|
|
||||||
return Array.from(cats).sort()
|
|
||||||
}, [budgetItems])
|
|
||||||
|
|
||||||
const [form, setForm] = useState({
|
const [form, setForm] = useState({
|
||||||
title: '', type: 'other', status: 'pending',
|
title: '', type: 'other', status: 'pending',
|
||||||
reservation_time: '', reservation_end_time: '', end_date: '', location: '', confirmation_number: '',
|
reservation_time: '', reservation_end_time: '', end_date: '', location: '', confirmation_number: '',
|
||||||
notes: '', assignment_id: '' as string | number, accommodation_id: '' as string | number,
|
notes: '', assignment_id: '' as string | number, accommodation_id: '' as string | number,
|
||||||
price: '', budget_category: '',
|
|
||||||
meta_check_in_time: '', meta_check_in_end_time: '', meta_check_out_time: '',
|
meta_check_in_time: '', meta_check_in_end_time: '', meta_check_out_time: '',
|
||||||
hotel_place_id: '' as string | number, hotel_start_day: '' as string | number, hotel_end_day: '' as string | number,
|
hotel_place_id: '' as string | number, hotel_start_day: '' as string | number, hotel_end_day: '' as string | number,
|
||||||
})
|
})
|
||||||
@@ -127,15 +127,12 @@ export function ReservationModal({ isOpen, onClose, onSave, reservation, days, p
|
|||||||
hotel_place_id: (() => { const acc = accommodations.find(a => a.id == reservation.accommodation_id); return acc?.place_id || '' })(),
|
hotel_place_id: (() => { const acc = accommodations.find(a => a.id == reservation.accommodation_id); return acc?.place_id || '' })(),
|
||||||
hotel_start_day: (() => { const acc = accommodations.find(a => a.id == reservation.accommodation_id); return acc?.start_day_id || '' })(),
|
hotel_start_day: (() => { const acc = accommodations.find(a => a.id == reservation.accommodation_id); return acc?.start_day_id || '' })(),
|
||||||
hotel_end_day: (() => { const acc = accommodations.find(a => a.id == reservation.accommodation_id); return acc?.end_day_id || '' })(),
|
hotel_end_day: (() => { const acc = accommodations.find(a => a.id == reservation.accommodation_id); return acc?.end_day_id || '' })(),
|
||||||
price: meta.price || '',
|
|
||||||
budget_category: (meta.budget_category && budgetItems.some(i => i.category === meta.budget_category)) ? meta.budget_category : '',
|
|
||||||
})
|
})
|
||||||
} else {
|
} else {
|
||||||
setForm({
|
setForm({
|
||||||
title: '', type: 'other', status: 'pending',
|
title: '', type: 'other', status: 'pending',
|
||||||
reservation_time: '', reservation_end_time: '', end_date: '', location: '', confirmation_number: '',
|
reservation_time: '', reservation_end_time: '', end_date: '', location: '', confirmation_number: '',
|
||||||
notes: '', assignment_id: defaultAssignmentId ?? '', accommodation_id: '',
|
notes: '', assignment_id: defaultAssignmentId ?? '', accommodation_id: '',
|
||||||
price: '', budget_category: '',
|
|
||||||
meta_check_in_time: '', meta_check_in_end_time: '', meta_check_out_time: '',
|
meta_check_in_time: '', meta_check_in_end_time: '', meta_check_out_time: '',
|
||||||
hotel_place_id: '', hotel_start_day: '', hotel_end_day: '',
|
hotel_place_id: '', hotel_start_day: '', hotel_end_day: '',
|
||||||
})
|
})
|
||||||
@@ -167,8 +164,8 @@ export function ReservationModal({ isOpen, onClose, onSave, reservation, days, p
|
|||||||
return endFull <= startFull
|
return endFull <= startFull
|
||||||
})()
|
})()
|
||||||
|
|
||||||
const handleSubmit = async (e) => {
|
const handleSubmit = async (e?: { preventDefault?: () => void }) => {
|
||||||
e.preventDefault()
|
e?.preventDefault?.()
|
||||||
if (!form.title.trim()) return
|
if (!form.title.trim()) return
|
||||||
if (isEndBeforeStart) { toast.error(t('reservations.validation.endBeforeStart')); return }
|
if (isEndBeforeStart) { toast.error(t('reservations.validation.endBeforeStart')); return }
|
||||||
setIsSaving(true)
|
setIsSaving(true)
|
||||||
@@ -185,11 +182,6 @@ export function ReservationModal({ isOpen, onClose, onSave, reservation, days, p
|
|||||||
} else if (form.reservation_end_time && form.reservation_time) {
|
} else if (form.reservation_end_time && form.reservation_time) {
|
||||||
combinedEndTime = `${form.reservation_time.split('T')[0]}T${form.reservation_end_time}`
|
combinedEndTime = `${form.reservation_time.split('T')[0]}T${form.reservation_end_time}`
|
||||||
}
|
}
|
||||||
if (isBudgetEnabled) {
|
|
||||||
if (form.price) metadata.price = form.price
|
|
||||||
if (form.budget_category) metadata.budget_category = form.budget_category
|
|
||||||
}
|
|
||||||
|
|
||||||
const saveData: Record<string, any> & { title: string } = {
|
const saveData: Record<string, any> & { title: string } = {
|
||||||
title: form.title, type: form.type, status: form.status,
|
title: form.title, type: form.type, status: form.status,
|
||||||
reservation_time: form.type === 'hotel' ? null : (form.reservation_time || null),
|
reservation_time: form.type === 'hotel' ? null : (form.reservation_time || null),
|
||||||
@@ -202,11 +194,6 @@ export function ReservationModal({ isOpen, onClose, onSave, reservation, days, p
|
|||||||
endpoints: [],
|
endpoints: [],
|
||||||
needs_review: false,
|
needs_review: false,
|
||||||
}
|
}
|
||||||
if (isBudgetEnabled) {
|
|
||||||
saveData.create_budget_entry = form.price && parseFloat(form.price) > 0
|
|
||||||
? { total_price: parseFloat(form.price), category: form.budget_category || t(`reservations.type.${form.type}`) || 'Other' }
|
|
||||||
: { total_price: 0 }
|
|
||||||
}
|
|
||||||
if (form.type === 'hotel' && form.hotel_start_day && form.hotel_end_day) {
|
if (form.type === 'hotel' && form.hotel_start_day && form.hotel_end_day) {
|
||||||
saveData.create_accommodation = {
|
saveData.create_accommodation = {
|
||||||
place_id: form.hotel_place_id || null,
|
place_id: form.hotel_place_id || null,
|
||||||
@@ -228,11 +215,25 @@ export function ReservationModal({ isOpen, onClose, onSave, reservation, days, p
|
|||||||
await onFileUpload(fd)
|
await onFileUpload(fd)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
// Open the Costs editor for the saved booking when the user asked to
|
||||||
|
// create/edit its linked expense (gated on saved?.id).
|
||||||
|
const intent = expenseIntentRef.current
|
||||||
|
expenseIntentRef.current = null
|
||||||
|
if (intent && onOpenExpense && saved?.id) {
|
||||||
|
if (intent.editItem) onOpenExpense({ editItem: intent.editItem })
|
||||||
|
else onOpenExpense({ prefill: { reservationId: saved.id, name: form.title, category: typeToCostCategory(form.type) } })
|
||||||
|
}
|
||||||
} finally {
|
} finally {
|
||||||
setIsSaving(false)
|
setIsSaving(false)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
const handleCreateExpense = () => { expenseIntentRef.current = { create: true }; handleSubmit() }
|
||||||
|
const handleEditExpense = (item: BudgetItem) => { expenseIntentRef.current = { editItem: item }; handleSubmit() }
|
||||||
|
const handleRemoveExpense = async (item: BudgetItem) => {
|
||||||
|
try { await deleteBudgetItem(Number(tripId), item.id) } catch { toast.error(t('common.unknownError')) }
|
||||||
|
}
|
||||||
|
|
||||||
const handleFileChange = async (e) => {
|
const handleFileChange = async (e) => {
|
||||||
const file = (e.target as HTMLInputElement).files?.[0]
|
const file = (e.target as HTMLInputElement).files?.[0]
|
||||||
if (!file) return
|
if (!file) return
|
||||||
@@ -610,38 +611,14 @@ export function ReservationModal({ isOpen, onClose, onSave, reservation, days, p
|
|||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
{/* Price + Budget Category */}
|
{/* Costs — create / view the expense linked to this booking */}
|
||||||
{isBudgetEnabled && (
|
{isBudgetEnabled && (
|
||||||
<>
|
<BookingCostsSection
|
||||||
<div style={{ display: 'flex', gap: 8 }}>
|
reservationId={reservation?.id ?? null}
|
||||||
<div style={{ flex: 1, minWidth: 0 }}>
|
onCreate={handleCreateExpense}
|
||||||
<label className={labelClass}>{t('reservations.price')}</label>
|
onEdit={handleEditExpense}
|
||||||
<input type="text" inputMode="decimal" value={form.price}
|
onRemove={handleRemoveExpense}
|
||||||
onChange={e => { const v = e.target.value; if (v === '' || /^\d*[.,]?\d{0,2}$/.test(v)) set('price', v.replace(',', '.')) }}
|
/>
|
||||||
onPaste={e => { e.preventDefault(); let txt = e.clipboardData.getData('text').trim().replace(/[^\d.,-]/g, ''); const lc = txt.lastIndexOf(','), ld = txt.lastIndexOf('.'), dp = Math.max(lc, ld); if (dp > -1) { txt = txt.substring(0, dp).replace(/[.,]/g, '') + '.' + txt.substring(dp + 1) } else { txt = txt.replace(/[.,]/g, '') } set('price', txt) }}
|
|
||||||
placeholder="0.00"
|
|
||||||
className={inputClass} />
|
|
||||||
</div>
|
|
||||||
<div style={{ flex: 1, minWidth: 0 }}>
|
|
||||||
<label className={labelClass}>{t('reservations.budgetCategory')}</label>
|
|
||||||
<CustomSelect
|
|
||||||
value={form.budget_category}
|
|
||||||
onChange={v => set('budget_category', v)}
|
|
||||||
options={[
|
|
||||||
{ value: '', label: t('reservations.budgetCategoryAuto') },
|
|
||||||
...budgetCategories.map(c => ({ value: c, label: c })),
|
|
||||||
]}
|
|
||||||
placeholder={t('reservations.budgetCategoryAuto')}
|
|
||||||
size="sm"
|
|
||||||
/>
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
{form.price && parseFloat(form.price) > 0 && (
|
|
||||||
<div className="text-content-faint" style={{ fontSize: 11, marginTop: -4 }}>
|
|
||||||
{t('reservations.budgetHint')}
|
|
||||||
</div>
|
|
||||||
)}
|
|
||||||
</>
|
|
||||||
)}
|
)}
|
||||||
|
|
||||||
</form>
|
</form>
|
||||||
|
|||||||
@@ -132,34 +132,37 @@ describe('TransportModal', () => {
|
|||||||
|
|
||||||
// ── Budget addon ─────────────────────────────────────────────────────────────
|
// ── Budget addon ─────────────────────────────────────────────────────────────
|
||||||
|
|
||||||
it('FE-PLANNER-TRANSMODAL-011: budget section visible when addon is enabled', () => {
|
it('FE-PLANNER-TRANSMODAL-011: costs section (create expense) visible when budget addon is enabled', () => {
|
||||||
seedStore(useAddonStore, {
|
seedStore(useAddonStore, {
|
||||||
addons: [{ id: 'budget', name: 'Budget', type: 'budget', icon: '', enabled: true }],
|
addons: [{ id: 'budget', name: 'Budget', type: 'budget', icon: '', enabled: true }],
|
||||||
loaded: true,
|
loaded: true,
|
||||||
});
|
});
|
||||||
render(<TransportModal {...defaultProps} />);
|
render(<TransportModal {...defaultProps} />);
|
||||||
expect(screen.getByText(/^Price$/i)).toBeInTheDocument();
|
expect(screen.getByRole('button', { name: /Create expense/i })).toBeInTheDocument();
|
||||||
expect(screen.getByText(/Budget category/i)).toBeInTheDocument();
|
|
||||||
});
|
});
|
||||||
|
|
||||||
it('FE-PLANNER-TRANSMODAL-012: budget section not shown when addon is disabled', () => {
|
it('FE-PLANNER-TRANSMODAL-012: costs section not shown when budget addon is disabled', () => {
|
||||||
render(<TransportModal {...defaultProps} />);
|
render(<TransportModal {...defaultProps} />);
|
||||||
expect(screen.queryByPlaceholderText('0.00')).not.toBeInTheDocument();
|
expect(screen.queryByRole('button', { name: /Create expense/i })).not.toBeInTheDocument();
|
||||||
});
|
});
|
||||||
|
|
||||||
it('FE-PLANNER-TRANSMODAL-013: budget fields included in onSave when price is set', async () => {
|
it('FE-PLANNER-TRANSMODAL-013: create-expense saves the booking (no create_budget_entry) then opens the Costs editor', async () => {
|
||||||
seedStore(useAddonStore, {
|
seedStore(useAddonStore, {
|
||||||
addons: [{ id: 'budget', name: 'Budget', type: 'budget', icon: '', enabled: true }],
|
addons: [{ id: 'budget', name: 'Budget', type: 'budget', icon: '', enabled: true }],
|
||||||
loaded: true,
|
loaded: true,
|
||||||
});
|
});
|
||||||
const onSave = vi.fn().mockResolvedValue(undefined);
|
const onSave = vi.fn().mockResolvedValue({ id: 42 });
|
||||||
render(<TransportModal {...defaultProps} onSave={onSave} />);
|
const onOpenExpense = vi.fn();
|
||||||
|
render(<TransportModal {...defaultProps} onSave={onSave} onOpenExpense={onOpenExpense} />);
|
||||||
await userEvent.type(screen.getByPlaceholderText(/e\.g\. Lufthansa/i), 'ICE Train');
|
await userEvent.type(screen.getByPlaceholderText(/e\.g\. Lufthansa/i), 'ICE Train');
|
||||||
await userEvent.type(screen.getByPlaceholderText('0.00'), '85');
|
await userEvent.click(screen.getByRole('button', { name: /Create expense/i }));
|
||||||
await userEvent.click(screen.getByRole('button', { name: /^Add$/i }));
|
|
||||||
await waitFor(() => expect(onSave).toHaveBeenCalled());
|
await waitFor(() => expect(onSave).toHaveBeenCalled());
|
||||||
expect(onSave).toHaveBeenCalledWith(
|
// The legacy auto-budget mechanism is gone; the expense is created via the editor instead.
|
||||||
expect.objectContaining({ create_budget_entry: expect.objectContaining({ total_price: 85 }) })
|
expect(onSave).not.toHaveBeenCalledWith(expect.objectContaining({ create_budget_entry: expect.anything() }));
|
||||||
|
await waitFor(() =>
|
||||||
|
expect(onOpenExpense).toHaveBeenCalledWith(
|
||||||
|
expect.objectContaining({ prefill: expect.objectContaining({ reservationId: 42 }) })
|
||||||
|
)
|
||||||
);
|
);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|||||||
@@ -1,4 +1,4 @@
|
|||||||
import { useState, useEffect, useMemo, useRef } from 'react'
|
import { useState, useEffect, useRef } from 'react'
|
||||||
import { useParams } from 'react-router-dom'
|
import { useParams } from 'react-router-dom'
|
||||||
import { Plane, Train, Car, Ship, Bus, Sailboat, Bike, CarTaxiFront, Route, Paperclip, FileText, X, ExternalLink, Link2, Plus, Trash2 } from 'lucide-react'
|
import { Plane, Train, Car, Ship, Bus, Sailboat, Bike, CarTaxiFront, Route, Paperclip, FileText, X, ExternalLink, Link2, Plus, Trash2 } from 'lucide-react'
|
||||||
import Modal from '../shared/Modal'
|
import Modal from '../shared/Modal'
|
||||||
@@ -13,8 +13,11 @@ import { useAddonStore } from '../../store/addonStore'
|
|||||||
import { formatDate, splitReservationDateTime } from '../../utils/formatters'
|
import { formatDate, splitReservationDateTime } from '../../utils/formatters'
|
||||||
import { openFile } from '../../utils/fileDownload'
|
import { openFile } from '../../utils/fileDownload'
|
||||||
import apiClient from '../../api/client'
|
import apiClient from '../../api/client'
|
||||||
import type { Day, Reservation, ReservationEndpoint, TripFile } from '../../types'
|
import type { Day, Reservation, ReservationEndpoint, TripFile, BudgetItem } from '../../types'
|
||||||
import { parseReservationMetadata, orderedEndpoints } from '../../utils/flightLegs'
|
import { parseReservationMetadata, orderedEndpoints } from '../../utils/flightLegs'
|
||||||
|
import { BookingCostsSection } from './BookingCostsSection'
|
||||||
|
import type { BookingExpenseRequest } from './BookingCostsSection.types'
|
||||||
|
import { typeToCostCategory } from '@trek/shared'
|
||||||
|
|
||||||
const TRANSPORT_TYPES = ['flight', 'train', 'bus', 'car', 'taxi', 'bicycle', 'cruise', 'ferry', 'transport_other'] as const
|
const TRANSPORT_TYPES = ['flight', 'train', 'bus', 'car', 'taxi', 'bicycle', 'cruise', 'ferry', 'transport_other'] as const
|
||||||
type TransportType = typeof TRANSPORT_TYPES[number]
|
type TransportType = typeof TRANSPORT_TYPES[number]
|
||||||
@@ -105,8 +108,6 @@ const defaultForm = {
|
|||||||
arrival_time: '',
|
arrival_time: '',
|
||||||
confirmation_number: '',
|
confirmation_number: '',
|
||||||
notes: '',
|
notes: '',
|
||||||
price: '',
|
|
||||||
budget_category: '',
|
|
||||||
meta_airline: '',
|
meta_airline: '',
|
||||||
meta_flight_number: '',
|
meta_flight_number: '',
|
||||||
meta_train_number: '',
|
meta_train_number: '',
|
||||||
@@ -124,20 +125,20 @@ interface TransportModalProps {
|
|||||||
files?: TripFile[]
|
files?: TripFile[]
|
||||||
onFileUpload?: (fd: FormData) => Promise<unknown>
|
onFileUpload?: (fd: FormData) => Promise<unknown>
|
||||||
onFileDelete?: (fileId: number) => Promise<void>
|
onFileDelete?: (fileId: number) => Promise<void>
|
||||||
|
onOpenExpense?: (req: BookingExpenseRequest) => void
|
||||||
}
|
}
|
||||||
|
|
||||||
export function TransportModal({ isOpen, onClose, onSave, reservation, days, selectedDayId, files = [], onFileUpload, onFileDelete }: TransportModalProps) {
|
export function TransportModal({ isOpen, onClose, onSave, reservation, days, selectedDayId, files = [], onFileUpload, onFileDelete, onOpenExpense }: TransportModalProps) {
|
||||||
const { t, locale } = useTranslation()
|
const { t, locale } = useTranslation()
|
||||||
const toast = useToast()
|
const toast = useToast()
|
||||||
const isBudgetEnabled = useAddonStore(s => s.isEnabled('budget'))
|
const isBudgetEnabled = useAddonStore(s => s.isEnabled('budget'))
|
||||||
const budgetItems = useTripStore(s => s.budgetItems)
|
const budgetItems = useTripStore(s => s.budgetItems)
|
||||||
|
const deleteBudgetItem = useTripStore(s => s.deleteBudgetItem)
|
||||||
const loadFiles = useTripStore(s => s.loadFiles)
|
const loadFiles = useTripStore(s => s.loadFiles)
|
||||||
const budgetCategories = useMemo(() => {
|
|
||||||
const cats = new Set<string>()
|
|
||||||
budgetItems.forEach(i => { if (i.category) cats.add(i.category) })
|
|
||||||
return Array.from(cats).sort()
|
|
||||||
}, [budgetItems])
|
|
||||||
const { id: tripId } = useParams<{ id: string }>()
|
const { id: tripId } = useParams<{ id: string }>()
|
||||||
|
// Set right before submitting when the user clicked "create/edit expense", so
|
||||||
|
// the post-save handler knows to open the Costs editor for the saved booking.
|
||||||
|
const expenseIntentRef = useRef<{ editItem?: BudgetItem; create?: boolean } | null>(null)
|
||||||
const [form, setForm] = useState({ ...defaultForm })
|
const [form, setForm] = useState({ ...defaultForm })
|
||||||
const [isSaving, setIsSaving] = useState(false)
|
const [isSaving, setIsSaving] = useState(false)
|
||||||
const [fromPick, setFromPick] = useState<EndpointPick>({})
|
const [fromPick, setFromPick] = useState<EndpointPick>({})
|
||||||
@@ -177,8 +178,6 @@ export function TransportModal({ isOpen, onClose, onSave, reservation, days, sel
|
|||||||
meta_train_number: meta.train_number || '',
|
meta_train_number: meta.train_number || '',
|
||||||
meta_platform: meta.platform || '',
|
meta_platform: meta.platform || '',
|
||||||
meta_seat: meta.seat || '',
|
meta_seat: meta.seat || '',
|
||||||
price: meta.price || '',
|
|
||||||
budget_category: (meta.budget_category && budgetItems.some(i => i.category === meta.budget_category)) ? meta.budget_category : '',
|
|
||||||
})
|
})
|
||||||
if (type === 'flight') {
|
if (type === 'flight') {
|
||||||
const orderedEps = orderedEndpoints(reservation)
|
const orderedEps = orderedEndpoints(reservation)
|
||||||
@@ -229,8 +228,8 @@ export function TransportModal({ isOpen, onClose, onSave, reservation, days, sel
|
|||||||
|
|
||||||
const set = (field: string, value: any) => setForm(prev => ({ ...prev, [field]: value }))
|
const set = (field: string, value: any) => setForm(prev => ({ ...prev, [field]: value }))
|
||||||
|
|
||||||
const handleSubmit = async (e: React.FormEvent) => {
|
const handleSubmit = async (e?: React.FormEvent) => {
|
||||||
e.preventDefault()
|
e?.preventDefault()
|
||||||
if (!form.title.trim()) return
|
if (!form.title.trim()) return
|
||||||
setIsSaving(true)
|
setIsSaving(true)
|
||||||
try {
|
try {
|
||||||
@@ -289,11 +288,6 @@ export function TransportModal({ isOpen, onClose, onSave, reservation, days, sel
|
|||||||
if (form.meta_platform) metadata.platform = form.meta_platform
|
if (form.meta_platform) metadata.platform = form.meta_platform
|
||||||
if (form.meta_seat) metadata.seat = form.meta_seat
|
if (form.meta_seat) metadata.seat = form.meta_seat
|
||||||
}
|
}
|
||||||
if (isBudgetEnabled) {
|
|
||||||
if (form.price) metadata.price = form.price
|
|
||||||
if (form.budget_category) metadata.budget_category = form.budget_category
|
|
||||||
}
|
|
||||||
|
|
||||||
const startDate = startDay?.date ?? null
|
const startDate = startDay?.date ?? null
|
||||||
const endDate = (endDay ?? startDay)?.date ?? null
|
const endDate = (endDay ?? startDay)?.date ?? null
|
||||||
const endpoints: ReturnType<typeof endpointFromAirport>[] = []
|
const endpoints: ReturnType<typeof endpointFromAirport>[] = []
|
||||||
@@ -334,11 +328,6 @@ export function TransportModal({ isOpen, onClose, onSave, reservation, days, sel
|
|||||||
endpoints,
|
endpoints,
|
||||||
needs_review: false,
|
needs_review: false,
|
||||||
}
|
}
|
||||||
if (isBudgetEnabled) {
|
|
||||||
(payload as any).create_budget_entry = form.price && parseFloat(form.price) > 0
|
|
||||||
? { total_price: parseFloat(form.price), category: form.budget_category || t(`reservations.type.${form.type}`) || 'Other' }
|
|
||||||
: { total_price: 0 }
|
|
||||||
}
|
|
||||||
const saved = await onSave(payload)
|
const saved = await onSave(payload)
|
||||||
if (!reservation?.id && saved?.id && pendingFiles.length > 0 && onFileUpload) {
|
if (!reservation?.id && saved?.id && pendingFiles.length > 0 && onFileUpload) {
|
||||||
for (const file of pendingFiles) {
|
for (const file of pendingFiles) {
|
||||||
@@ -349,6 +338,14 @@ export function TransportModal({ isOpen, onClose, onSave, reservation, days, sel
|
|||||||
await onFileUpload(fd)
|
await onFileUpload(fd)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
// The user asked to create/edit the linked expense — open the Costs editor
|
||||||
|
// for the now-saved booking. Gated on saved?.id so a failed save doesn't.
|
||||||
|
const intent = expenseIntentRef.current
|
||||||
|
expenseIntentRef.current = null
|
||||||
|
if (intent && onOpenExpense && saved?.id) {
|
||||||
|
if (intent.editItem) onOpenExpense({ editItem: intent.editItem })
|
||||||
|
else onOpenExpense({ prefill: { reservationId: saved.id, name: form.title, category: typeToCostCategory(form.type) } })
|
||||||
|
}
|
||||||
} catch (err: unknown) {
|
} catch (err: unknown) {
|
||||||
toast.error(err instanceof Error ? err.message : t('common.unknownError'))
|
toast.error(err instanceof Error ? err.message : t('common.unknownError'))
|
||||||
} finally {
|
} finally {
|
||||||
@@ -356,6 +353,12 @@ export function TransportModal({ isOpen, onClose, onSave, reservation, days, sel
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
const handleCreateExpense = () => { expenseIntentRef.current = { create: true }; handleSubmit() }
|
||||||
|
const handleEditExpense = (item: BudgetItem) => { expenseIntentRef.current = { editItem: item }; handleSubmit() }
|
||||||
|
const handleRemoveExpense = async (item: BudgetItem) => {
|
||||||
|
try { await deleteBudgetItem(Number(tripId), item.id) } catch { toast.error(t('common.unknownError')) }
|
||||||
|
}
|
||||||
|
|
||||||
const handleFileChange = async (e: React.ChangeEvent<HTMLInputElement>) => {
|
const handleFileChange = async (e: React.ChangeEvent<HTMLInputElement>) => {
|
||||||
const file = e.target.files?.[0]
|
const file = e.target.files?.[0]
|
||||||
if (!file) return
|
if (!file) return
|
||||||
@@ -712,38 +715,14 @@ export function TransportModal({ isOpen, onClose, onSave, reservation, days, sel
|
|||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
{/* Price + Budget Category */}
|
{/* Costs — create / view the expense linked to this booking */}
|
||||||
{isBudgetEnabled && (
|
{isBudgetEnabled && (
|
||||||
<>
|
<BookingCostsSection
|
||||||
<div style={{ display: 'flex', gap: 8 }}>
|
reservationId={reservation?.id ?? null}
|
||||||
<div style={{ flex: 1, minWidth: 0 }}>
|
onCreate={handleCreateExpense}
|
||||||
<label className={labelClass}>{t('reservations.price')}</label>
|
onEdit={handleEditExpense}
|
||||||
<input type="text" inputMode="decimal" value={form.price}
|
onRemove={handleRemoveExpense}
|
||||||
onChange={e => { const v = e.target.value; if (v === '' || /^\d*[.,]?\d{0,2}$/.test(v)) set('price', v.replace(',', '.')) }}
|
/>
|
||||||
onPaste={e => { e.preventDefault(); let txt = e.clipboardData.getData('text').trim().replace(/[^\d.,-]/g, ''); const lc = txt.lastIndexOf(','), ld = txt.lastIndexOf('.'), dp = Math.max(lc, ld); if (dp > -1) { txt = txt.substring(0, dp).replace(/[.,]/g, '') + '.' + txt.substring(dp + 1) } else { txt = txt.replace(/[.,]/g, '') } set('price', txt) }}
|
|
||||||
placeholder="0.00"
|
|
||||||
className={inputClass} />
|
|
||||||
</div>
|
|
||||||
<div style={{ flex: 1, minWidth: 0 }}>
|
|
||||||
<label className={labelClass}>{t('reservations.budgetCategory')}</label>
|
|
||||||
<CustomSelect
|
|
||||||
value={form.budget_category}
|
|
||||||
onChange={v => set('budget_category', v)}
|
|
||||||
options={[
|
|
||||||
{ value: '', label: t('reservations.budgetCategoryAuto') },
|
|
||||||
...budgetCategories.map(c => ({ value: c, label: c })),
|
|
||||||
]}
|
|
||||||
placeholder={t('reservations.budgetCategoryAuto')}
|
|
||||||
size="sm"
|
|
||||||
/>
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
{form.price && parseFloat(form.price) > 0 && (
|
|
||||||
<div className="text-content-faint" style={{ fontSize: 11, marginTop: -4 }}>
|
|
||||||
{t('reservations.budgetHint')}
|
|
||||||
</div>
|
|
||||||
)}
|
|
||||||
</>
|
|
||||||
)}
|
)}
|
||||||
|
|
||||||
</form>
|
</form>
|
||||||
|
|||||||
@@ -0,0 +1,36 @@
|
|||||||
|
import { describe, it, expect } from 'vitest'
|
||||||
|
import { getGoogleMapsUrlForPlace } from './placeGoogleMaps'
|
||||||
|
|
||||||
|
const base = { name: 'Eiffel Tower', lat: 48.8584, lng: 2.2945, google_place_id: null, google_ftid: null } as any
|
||||||
|
|
||||||
|
describe('getGoogleMapsUrlForPlace', () => {
|
||||||
|
it('FE-PLACE-GMAPS-001: uses a valid ftid for a precise /place link', () => {
|
||||||
|
const url = getGoogleMapsUrlForPlace({ ...base, google_ftid: '0x47e66e2964e34e2d:0x8ddca9ee380ef7e0' })
|
||||||
|
expect(url).toBe('https://www.google.com/maps/place/?q=Eiffel%20Tower&ftid=0x47e66e2964e34e2d:0x8ddca9ee380ef7e0')
|
||||||
|
})
|
||||||
|
|
||||||
|
it('FE-PLACE-GMAPS-002: falls back to query_place_id when there is no ftid', () => {
|
||||||
|
const url = getGoogleMapsUrlForPlace({ ...base, google_place_id: 'ChIJ123' })
|
||||||
|
expect(url).toBe('https://www.google.com/maps/search/?api=1&query=Eiffel%20Tower&query_place_id=ChIJ123')
|
||||||
|
})
|
||||||
|
|
||||||
|
it('FE-PLACE-GMAPS-003: ignores a malformed/hostile ftid and falls through to the place id', () => {
|
||||||
|
const url = getGoogleMapsUrlForPlace({ ...base, google_ftid: '0xAB&q=evil', google_place_id: 'ChIJ123' })
|
||||||
|
expect(url).toBe('https://www.google.com/maps/search/?api=1&query=Eiffel%20Tower&query_place_id=ChIJ123')
|
||||||
|
})
|
||||||
|
|
||||||
|
it('FE-PLACE-GMAPS-004: uses the details URL when there is no ftid or place id', () => {
|
||||||
|
const url = getGoogleMapsUrlForPlace(base, 'https://maps.google.com/?cid=123')
|
||||||
|
expect(url).toBe('https://maps.google.com/?cid=123')
|
||||||
|
})
|
||||||
|
|
||||||
|
it('FE-PLACE-GMAPS-005: falls back to coordinates as a last resort', () => {
|
||||||
|
const url = getGoogleMapsUrlForPlace(base)
|
||||||
|
expect(url).toBe('https://www.google.com/maps/search/?api=1&query=48.8584,2.2945')
|
||||||
|
})
|
||||||
|
|
||||||
|
it('FE-PLACE-GMAPS-006: returns null for no place or no location', () => {
|
||||||
|
expect(getGoogleMapsUrlForPlace(null)).toBeNull()
|
||||||
|
expect(getGoogleMapsUrlForPlace({ ...base, lat: null, lng: null })).toBeNull()
|
||||||
|
})
|
||||||
|
})
|
||||||
@@ -0,0 +1,19 @@
|
|||||||
|
import type { AssignmentPlace, Place } from '../../types'
|
||||||
|
|
||||||
|
type PlaceLike = Pick<Place | AssignmentPlace, 'name' | 'lat' | 'lng' | 'google_place_id' | 'google_ftid'>
|
||||||
|
const GOOGLE_FTID_RE = /^0x[0-9a-f]+:0x[0-9a-f]+$/i
|
||||||
|
|
||||||
|
export function getGoogleMapsUrlForPlace(place: PlaceLike | null | undefined, detailsUrl?: string | null): string | null {
|
||||||
|
if (!place) return null
|
||||||
|
const ftid = place.google_ftid?.trim()
|
||||||
|
if (ftid && GOOGLE_FTID_RE.test(ftid)) {
|
||||||
|
return `https://www.google.com/maps/place/?q=${encodeURIComponent(place.name)}&ftid=${ftid}`
|
||||||
|
}
|
||||||
|
const placeId = place.google_place_id?.trim()
|
||||||
|
if (placeId) {
|
||||||
|
return `https://www.google.com/maps/search/?api=1&query=${encodeURIComponent(place.name)}&query_place_id=${encodeURIComponent(placeId)}`
|
||||||
|
}
|
||||||
|
if (detailsUrl) return detailsUrl
|
||||||
|
if (place.lat == null || place.lng == null) return null
|
||||||
|
return `https://www.google.com/maps/search/?api=1&query=${place.lat},${place.lng}`
|
||||||
|
}
|
||||||
@@ -9,6 +9,7 @@ import { useTripStore } from '../../store/tripStore'
|
|||||||
import { useCanDo } from '../../store/permissionsStore'
|
import { useCanDo } from '../../store/permissionsStore'
|
||||||
import { useAuthStore } from '../../store/authStore'
|
import { useAuthStore } from '../../store/authStore'
|
||||||
import type { Place, Category, Day, AssignmentsMap } from '../../types'
|
import type { Place, Category, Day, AssignmentsMap } from '../../types'
|
||||||
|
import { getGoogleMapsUrlForPlace } from './placeGoogleMaps'
|
||||||
|
|
||||||
export interface PlacesSidebarProps {
|
export interface PlacesSidebarProps {
|
||||||
tripId: number
|
tripId: number
|
||||||
@@ -59,6 +60,8 @@ export function usePlacesSidebar(props: PlacesSidebarProps) {
|
|||||||
const [sidebarDragOver, setSidebarDragOver] = useState(false)
|
const [sidebarDragOver, setSidebarDragOver] = useState(false)
|
||||||
const sidebarDragCounter = useRef(0)
|
const sidebarDragCounter = useRef(0)
|
||||||
const scrollContainerRef = useRef<HTMLDivElement | null>(null)
|
const scrollContainerRef = useRef<HTMLDivElement | null>(null)
|
||||||
|
const placeRowRefs = useRef(new Map<number, HTMLDivElement>())
|
||||||
|
const lastAutoScrolledPlaceIdRef = useRef<number | null>(null)
|
||||||
useLayoutEffect(() => {
|
useLayoutEffect(() => {
|
||||||
if (scrollContainerRef.current && initialScrollTop) {
|
if (scrollContainerRef.current && initialScrollTop) {
|
||||||
scrollContainerRef.current.scrollTop = initialScrollTop
|
scrollContainerRef.current.scrollTop = initialScrollTop
|
||||||
@@ -197,6 +200,28 @@ export function usePlacesSidebar(props: PlacesSidebarProps) {
|
|||||||
return true
|
return true
|
||||||
}), [places, filter, categoryFilters, search, plannedIds])
|
}), [places, filter, categoryFilters, search, plannedIds])
|
||||||
|
|
||||||
|
const registerPlaceRow = useCallback((placeId: number, element: HTMLDivElement | null) => {
|
||||||
|
if (element) {
|
||||||
|
placeRowRefs.current.set(placeId, element)
|
||||||
|
} else {
|
||||||
|
placeRowRefs.current.delete(placeId)
|
||||||
|
}
|
||||||
|
}, [])
|
||||||
|
|
||||||
|
useEffect(() => {
|
||||||
|
if (!props.selectedPlaceId) {
|
||||||
|
lastAutoScrolledPlaceIdRef.current = null
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if (lastAutoScrolledPlaceIdRef.current === props.selectedPlaceId) return
|
||||||
|
if (!filtered.some(place => place.id === props.selectedPlaceId)) return
|
||||||
|
|
||||||
|
const selectedRow = placeRowRefs.current.get(props.selectedPlaceId)
|
||||||
|
if (!selectedRow) return
|
||||||
|
selectedRow.scrollIntoView({ behavior: 'smooth', block: 'center' })
|
||||||
|
lastAutoScrolledPlaceIdRef.current = props.selectedPlaceId
|
||||||
|
}, [filtered, props.selectedPlaceId])
|
||||||
|
|
||||||
const isAssignedToSelectedDay = (placeId) =>
|
const isAssignedToSelectedDay = (placeId) =>
|
||||||
selectedDayId && (assignments[String(selectedDayId)] || []).some(a => a.place?.id === placeId)
|
selectedDayId && (assignments[String(selectedDayId)] || []).some(a => a.place?.id === placeId)
|
||||||
|
|
||||||
@@ -210,11 +235,12 @@ export function usePlacesSidebar(props: PlacesSidebarProps) {
|
|||||||
|
|
||||||
const openContextMenu = useCallback((e: React.MouseEvent, place: Place) => {
|
const openContextMenu = useCallback((e: React.MouseEvent, place: Place) => {
|
||||||
const selDayId = selectedDayIdRef.current
|
const selDayId = selectedDayIdRef.current
|
||||||
|
const googleMapsUrl = getGoogleMapsUrlForPlace(place)
|
||||||
ctxMenu.open(e, [
|
ctxMenu.open(e, [
|
||||||
canEditPlaces && { label: t('common.edit'), icon: Pencil, onClick: () => props.onEditPlace(place) },
|
canEditPlaces && { label: t('common.edit'), icon: Pencil, onClick: () => props.onEditPlace(place) },
|
||||||
selDayId && { label: t('planner.addToDay'), icon: CalendarDays, onClick: () => props.onAssignToDay(place.id, selDayId) },
|
selDayId && { label: t('planner.addToDay'), icon: CalendarDays, onClick: () => props.onAssignToDay(place.id, selDayId) },
|
||||||
place.website && { label: t('inspector.website'), icon: ExternalLink, onClick: () => window.open(place.website, '_blank') },
|
place.website && { label: t('inspector.website'), icon: ExternalLink, onClick: () => window.open(place.website, '_blank') },
|
||||||
(place.lat && place.lng) && { label: 'Google Maps', icon: Navigation, onClick: () => window.open(`https://www.google.com/maps/search/?api=1&query=${(place as any).google_place_id ? encodeURIComponent(place.name) + '&query_place_id=' + (place as any).google_place_id : place.lat + ',' + place.lng}`, '_blank') },
|
googleMapsUrl && { label: 'Google Maps', icon: Navigation, onClick: () => window.open(googleMapsUrl, '_blank') },
|
||||||
{ divider: true },
|
{ divider: true },
|
||||||
canEditPlaces && { label: t('common.delete'), icon: Trash2, danger: true, onClick: () => props.onDeletePlace(place.id) },
|
canEditPlaces && { label: t('common.delete'), icon: Trash2, danger: true, onClick: () => props.onDeletePlace(place.id) },
|
||||||
])
|
])
|
||||||
@@ -234,7 +260,7 @@ export function usePlacesSidebar(props: PlacesSidebarProps) {
|
|||||||
selectMode, setSelectMode, selectedIds, setSelectedIds, pendingDeleteIds, setPendingDeleteIds,
|
selectMode, setSelectMode, selectedIds, setSelectedIds, pendingDeleteIds, setPendingDeleteIds,
|
||||||
exitSelectMode, toggleSelected, toggleCategoryFilter, dayPickerPlace, setDayPickerPlace,
|
exitSelectMode, toggleSelected, toggleCategoryFilter, dayPickerPlace, setDayPickerPlace,
|
||||||
catDropOpen, setCatDropOpen, mobileShowDays, setMobileShowDays,
|
catDropOpen, setCatDropOpen, mobileShowDays, setMobileShowDays,
|
||||||
hasTracks, plannedIds, filtered, isAssignedToSelectedDay, inDaySet, openContextMenu,
|
hasTracks, plannedIds, filtered, registerPlaceRow, isAssignedToSelectedDay, inDaySet, openContextMenu,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -19,6 +19,7 @@ export default function AirTrailConnectionSection(): React.ReactElement {
|
|||||||
const [url, setUrl] = useState('')
|
const [url, setUrl] = useState('')
|
||||||
const [apiKey, setApiKey] = useState('')
|
const [apiKey, setApiKey] = useState('')
|
||||||
const [allowInsecureTls, setAllowInsecureTls] = useState(false)
|
const [allowInsecureTls, setAllowInsecureTls] = useState(false)
|
||||||
|
const [writeEnabled, setWriteEnabled] = useState(false)
|
||||||
const [connected, setConnected] = useState(false)
|
const [connected, setConnected] = useState(false)
|
||||||
const [loading, setLoading] = useState(true)
|
const [loading, setLoading] = useState(true)
|
||||||
const [saving, setSaving] = useState(false)
|
const [saving, setSaving] = useState(false)
|
||||||
@@ -30,6 +31,7 @@ export default function AirTrailConnectionSection(): React.ReactElement {
|
|||||||
.then(d => {
|
.then(d => {
|
||||||
setUrl(d.url || '')
|
setUrl(d.url || '')
|
||||||
setAllowInsecureTls(!!d.allowInsecureTls)
|
setAllowInsecureTls(!!d.allowInsecureTls)
|
||||||
|
setWriteEnabled(!!d.writeEnabled)
|
||||||
setConnected(!!d.connected)
|
setConnected(!!d.connected)
|
||||||
})
|
})
|
||||||
.catch(() => {})
|
.catch(() => {})
|
||||||
@@ -46,7 +48,7 @@ export default function AirTrailConnectionSection(): React.ReactElement {
|
|||||||
const handleSave = async () => {
|
const handleSave = async () => {
|
||||||
setSaving(true)
|
setSaving(true)
|
||||||
try {
|
try {
|
||||||
const d = await airtrailApi.saveSettings({ url: url.trim(), allowInsecureTls, ...keyPayload() })
|
const d = await airtrailApi.saveSettings({ url: url.trim(), allowInsecureTls, writeEnabled, ...keyPayload() })
|
||||||
const status = await airtrailApi.status().catch(() => ({ connected: false }))
|
const status = await airtrailApi.status().catch(() => ({ connected: false }))
|
||||||
setConnected(!!status.connected)
|
setConnected(!!status.connected)
|
||||||
setApiKey('')
|
setApiKey('')
|
||||||
@@ -107,6 +109,14 @@ export default function AirTrailConnectionSection(): React.ReactElement {
|
|||||||
<span className="text-sm font-medium text-slate-700">{t('settings.airtrail.allowInsecureTls')}</span>
|
<span className="text-sm font-medium text-slate-700">{t('settings.airtrail.allowInsecureTls')}</span>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
|
<div>
|
||||||
|
<div className="flex items-center gap-3">
|
||||||
|
<ToggleSwitch on={writeEnabled} onToggle={() => setWriteEnabled(v => !v)} />
|
||||||
|
<span className="text-sm font-medium text-slate-700">{t('settings.airtrail.writeBack')}</span>
|
||||||
|
</div>
|
||||||
|
<p className="mt-1 text-xs text-slate-500">{t('settings.airtrail.writeBackHint')}</p>
|
||||||
|
</div>
|
||||||
|
|
||||||
<div className="flex flex-wrap items-center gap-3">
|
<div className="flex flex-wrap items-center gap-3">
|
||||||
<button
|
<button
|
||||||
onClick={handleSave}
|
onClick={handleSave}
|
||||||
|
|||||||
@@ -150,6 +150,22 @@ describe('DisplaySettingsTab', () => {
|
|||||||
expect(updateSetting).toHaveBeenCalledWith('temperature_unit', 'fahrenheit');
|
expect(updateSetting).toHaveBeenCalledWith('temperature_unit', 'fahrenheit');
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it('FE-COMP-DISPLAY-028: metric distance button is active by default', () => {
|
||||||
|
seedStore(useSettingsStore, { settings: { temperature_unit: 'celsius' } });
|
||||||
|
render(<DisplaySettingsTab />);
|
||||||
|
const metricBtn = screen.getByText('km Metric').closest('button')!;
|
||||||
|
expect(metricBtn.style.border).toContain('var(--text-primary)');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('FE-COMP-DISPLAY-029: clicking imperial distance calls updateSetting with imperial', async () => {
|
||||||
|
const user = userEvent.setup();
|
||||||
|
const updateSetting = vi.fn().mockResolvedValue(undefined);
|
||||||
|
seedStore(useSettingsStore, { settings: buildSettings({ distance_unit: 'metric' }), updateSetting });
|
||||||
|
render(<DisplaySettingsTab />);
|
||||||
|
await user.click(screen.getByText('mi Imperial'));
|
||||||
|
expect(updateSetting).toHaveBeenCalledWith('distance_unit', 'imperial');
|
||||||
|
});
|
||||||
|
|
||||||
it('FE-COMP-DISPLAY-020: clicking 24h time format calls updateSetting with 24h', async () => {
|
it('FE-COMP-DISPLAY-020: clicking 24h time format calls updateSetting with 24h', async () => {
|
||||||
const user = userEvent.setup();
|
const user = userEvent.setup();
|
||||||
const updateSetting = vi.fn().mockResolvedValue(undefined);
|
const updateSetting = vi.fn().mockResolvedValue(undefined);
|
||||||
|
|||||||
@@ -6,12 +6,14 @@ import { useToast } from '../shared/Toast'
|
|||||||
import CustomSelect from '../shared/CustomSelect'
|
import CustomSelect from '../shared/CustomSelect'
|
||||||
import { CURRENCIES, SYMBOLS } from '../Budget/BudgetPanel.constants'
|
import { CURRENCIES, SYMBOLS } from '../Budget/BudgetPanel.constants'
|
||||||
import Section from './Section'
|
import Section from './Section'
|
||||||
|
import type { DistanceUnit } from '../../types'
|
||||||
|
|
||||||
export default function DisplaySettingsTab(): React.ReactElement {
|
export default function DisplaySettingsTab(): React.ReactElement {
|
||||||
const { settings, updateSetting } = useSettingsStore()
|
const { settings, updateSetting } = useSettingsStore()
|
||||||
const { t } = useTranslation()
|
const { t } = useTranslation()
|
||||||
const toast = useToast()
|
const toast = useToast()
|
||||||
const [tempUnit, setTempUnit] = useState<string>(settings.temperature_unit || 'celsius')
|
const [tempUnit, setTempUnit] = useState<string>(settings.temperature_unit || 'celsius')
|
||||||
|
const [distanceUnit, setDistanceUnit] = useState<DistanceUnit>(settings.distance_unit || 'metric')
|
||||||
const [langOpen, setLangOpen] = useState(false)
|
const [langOpen, setLangOpen] = useState(false)
|
||||||
const langDropdownRef = useRef<HTMLDivElement | null>(null)
|
const langDropdownRef = useRef<HTMLDivElement | null>(null)
|
||||||
|
|
||||||
@@ -28,6 +30,10 @@ export default function DisplaySettingsTab(): React.ReactElement {
|
|||||||
setTempUnit(settings.temperature_unit || 'celsius')
|
setTempUnit(settings.temperature_unit || 'celsius')
|
||||||
}, [settings.temperature_unit])
|
}, [settings.temperature_unit])
|
||||||
|
|
||||||
|
useEffect(() => {
|
||||||
|
setDistanceUnit(settings.distance_unit || 'metric')
|
||||||
|
}, [settings.distance_unit])
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<Section title={t('settings.display')} icon={Palette}>
|
<Section title={t('settings.display')} icon={Palette}>
|
||||||
{/* Display currency */}
|
{/* Display currency */}
|
||||||
@@ -200,6 +206,37 @@ export default function DisplaySettingsTab(): React.ReactElement {
|
|||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
|
{/* Distance */}
|
||||||
|
<div>
|
||||||
|
<label className="block text-sm font-medium mb-2 text-content-secondary">{t('settings.distance')}</label>
|
||||||
|
<div className="flex gap-3">
|
||||||
|
{([
|
||||||
|
{ value: 'metric', label: 'km Metric' },
|
||||||
|
{ value: 'imperial', label: 'mi Imperial' },
|
||||||
|
] as const).map(opt => (
|
||||||
|
<button
|
||||||
|
key={opt.value}
|
||||||
|
onClick={async () => {
|
||||||
|
setDistanceUnit(opt.value)
|
||||||
|
try { await updateSetting('distance_unit', opt.value) }
|
||||||
|
catch (e: unknown) { toast.error(e instanceof Error ? e.message : t('common.error')) }
|
||||||
|
}}
|
||||||
|
style={{
|
||||||
|
display: 'flex', alignItems: 'center', gap: 8,
|
||||||
|
padding: '10px 20px', borderRadius: 10, cursor: 'pointer',
|
||||||
|
fontFamily: 'inherit', fontSize: 14, fontWeight: 500,
|
||||||
|
border: distanceUnit === opt.value ? '2px solid var(--text-primary)' : '2px solid var(--border-primary)',
|
||||||
|
background: distanceUnit === opt.value ? 'var(--bg-hover)' : 'var(--bg-card)',
|
||||||
|
color: 'var(--text-primary)',
|
||||||
|
transition: 'all 0.15s',
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
{opt.label}
|
||||||
|
</button>
|
||||||
|
))}
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
|
||||||
{/* Time Format */}
|
{/* Time Format */}
|
||||||
<div>
|
<div>
|
||||||
<label className="block text-sm font-medium mb-2 text-content-secondary">{t('settings.timeFormat')}</label>
|
<label className="block text-sm font-medium mb-2 text-content-secondary">{t('settings.timeFormat')}</label>
|
||||||
|
|||||||
@@ -1,14 +1,22 @@
|
|||||||
import React, { useState, useEffect, useCallback, useMemo, useRef } from 'react'
|
import React, { useState, useEffect, useCallback, useMemo, useRef } from 'react'
|
||||||
import { Map, Save, Layers, Box, ChevronDown, Check } from 'lucide-react'
|
import { Map, Save, Layers, Box, ChevronDown, Check, Globe2 } from 'lucide-react'
|
||||||
import { useTranslation } from '../../i18n'
|
import { useTranslation } from '../../i18n'
|
||||||
import { useSettingsStore } from '../../store/settingsStore'
|
import { useSettingsStore } from '../../store/settingsStore'
|
||||||
import { useToast } from '../shared/Toast'
|
import { useToast } from '../shared/Toast'
|
||||||
import CustomSelect from '../shared/CustomSelect'
|
import CustomSelect from '../shared/CustomSelect'
|
||||||
import { MapView } from '../Map/MapView'
|
import { MapView } from '../Map/MapView'
|
||||||
import MapboxPreview from './MapboxPreview'
|
import GlMapPreview from './MapboxPreview'
|
||||||
import Section from './Section'
|
import Section from './Section'
|
||||||
import ToggleSwitch from './ToggleSwitch'
|
import ToggleSwitch from './ToggleSwitch'
|
||||||
import type { Place } from '../../types'
|
import type { Place } from '../../types'
|
||||||
|
import {
|
||||||
|
MAPBOX_DEFAULT_STYLE,
|
||||||
|
defaultStyleForProvider,
|
||||||
|
getStylePresets,
|
||||||
|
isOpenFreeMapStyle,
|
||||||
|
normalizeStyleForProvider,
|
||||||
|
type GlMapProvider,
|
||||||
|
} from '../Map/glProviders'
|
||||||
|
|
||||||
interface MapPreset {
|
interface MapPreset {
|
||||||
name: string
|
name: string
|
||||||
@@ -23,25 +31,6 @@ const MAP_PRESETS: MapPreset[] = [
|
|||||||
{ name: 'Stadia Smooth', url: 'https://tiles.stadiamaps.com/tiles/alidade_smooth/{z}/{x}/{y}{r}.png' },
|
{ name: 'Stadia Smooth', url: 'https://tiles.stadiamaps.com/tiles/alidade_smooth/{z}/{x}/{y}{r}.png' },
|
||||||
]
|
]
|
||||||
|
|
||||||
interface StylePreset {
|
|
||||||
name: string
|
|
||||||
url: string
|
|
||||||
tags: string[]
|
|
||||||
}
|
|
||||||
|
|
||||||
const MAPBOX_STYLE_PRESETS: StylePreset[] = [
|
|
||||||
{ name: 'Mapbox Standard', url: 'mapbox://styles/mapbox/standard', tags: ['3D', 'Apple-like'] },
|
|
||||||
{ name: 'Standard Satellite', url: 'mapbox://styles/mapbox/standard-satellite', tags: ['3D', 'Satellite'] },
|
|
||||||
{ name: 'Streets', url: 'mapbox://styles/mapbox/streets-v12', tags: ['3D', 'Classic'] },
|
|
||||||
{ name: 'Outdoors', url: 'mapbox://styles/mapbox/outdoors-v12', tags: ['3D', 'Terrain'] },
|
|
||||||
{ name: 'Light', url: 'mapbox://styles/mapbox/light-v11', tags: ['3D', 'Minimal'] },
|
|
||||||
{ name: 'Dark', url: 'mapbox://styles/mapbox/dark-v11', tags: ['3D', 'Dark'] },
|
|
||||||
{ name: 'Satellite', url: 'mapbox://styles/mapbox/satellite-v9', tags: ['3D', 'Satellite'] },
|
|
||||||
{ name: 'Satellite Streets', url: 'mapbox://styles/mapbox/satellite-streets-v12', tags: ['3D', 'Satellite'] },
|
|
||||||
{ name: 'Navigation Day', url: 'mapbox://styles/mapbox/navigation-day-v1', tags: ['3D', 'Apple-like'] },
|
|
||||||
{ name: 'Navigation Night', url: 'mapbox://styles/mapbox/navigation-night-v1', tags: ['3D', 'Dark'] },
|
|
||||||
]
|
|
||||||
|
|
||||||
// Tag → chip color mapping. Keeps the dropdown readable at a glance so a
|
// Tag → chip color mapping. Keeps the dropdown readable at a glance so a
|
||||||
// user scanning the list can spot 3D / Satellite / Apple-like styles.
|
// user scanning the list can spot 3D / Satellite / Apple-like styles.
|
||||||
const TAG_STYLES: Record<string, string> = {
|
const TAG_STYLES: Record<string, string> = {
|
||||||
@@ -59,6 +48,7 @@ const TAG_STYLES: Record<string, string> = {
|
|||||||
'Classic': 'bg-stone-100 text-stone-700 dark:bg-stone-800 dark:text-stone-300',
|
'Classic': 'bg-stone-100 text-stone-700 dark:bg-stone-800 dark:text-stone-300',
|
||||||
'Hybrid': 'bg-cyan-100 text-cyan-800 dark:bg-cyan-900/40 dark:text-cyan-300',
|
'Hybrid': 'bg-cyan-100 text-cyan-800 dark:bg-cyan-900/40 dark:text-cyan-300',
|
||||||
'No labels': 'bg-neutral-100 text-neutral-700 dark:bg-neutral-800 dark:text-neutral-300',
|
'No labels': 'bg-neutral-100 text-neutral-700 dark:bg-neutral-800 dark:text-neutral-300',
|
||||||
|
'OpenFreeMap': 'bg-green-100 text-green-800 dark:bg-green-900/40 dark:text-green-300',
|
||||||
}
|
}
|
||||||
|
|
||||||
function TagChip({ tag }: { tag: string }) {
|
function TagChip({ tag }: { tag: string }) {
|
||||||
@@ -70,10 +60,11 @@ function TagChip({ tag }: { tag: string }) {
|
|||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
function StyleDropdown({ value, onChange }: { value: string; onChange: (v: string) => void }) {
|
function StyleDropdown({ value, provider, onChange }: { value: string; provider: GlMapProvider; onChange: (v: string) => void }) {
|
||||||
const { t } = useTranslation()
|
const { t } = useTranslation()
|
||||||
const [open, setOpen] = useState(false)
|
const [open, setOpen] = useState(false)
|
||||||
const ref = useRef<HTMLDivElement>(null)
|
const ref = useRef<HTMLDivElement>(null)
|
||||||
|
const presets = getStylePresets(provider)
|
||||||
|
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
if (!open) return
|
if (!open) return
|
||||||
@@ -84,7 +75,10 @@ function StyleDropdown({ value, onChange }: { value: string; onChange: (v: strin
|
|||||||
return () => document.removeEventListener('mousedown', onDoc)
|
return () => document.removeEventListener('mousedown', onDoc)
|
||||||
}, [open])
|
}, [open])
|
||||||
|
|
||||||
const selected = MAPBOX_STYLE_PRESETS.find(p => p.url === value)
|
const selected = presets.find(p => p.url === value)
|
||||||
|
const placeholder = provider === 'maplibre-gl'
|
||||||
|
? t('settings.mapOpenFreeMapStylePlaceholder')
|
||||||
|
: t('settings.mapStylePlaceholder')
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<div ref={ref} className="relative">
|
<div ref={ref} className="relative">
|
||||||
@@ -95,11 +89,11 @@ function StyleDropdown({ value, onChange }: { value: string; onChange: (v: strin
|
|||||||
>
|
>
|
||||||
<span className="flex items-center gap-2 min-w-0">
|
<span className="flex items-center gap-2 min-w-0">
|
||||||
<span className="text-slate-900 dark:text-white truncate">
|
<span className="text-slate-900 dark:text-white truncate">
|
||||||
{selected ? selected.name : t('settings.mapStylePlaceholder')}
|
{selected ? selected.name : placeholder}
|
||||||
</span>
|
</span>
|
||||||
{selected && (
|
{selected && (
|
||||||
<span className="flex items-center gap-1 flex-shrink-0">
|
<span className="flex items-center gap-1 flex-shrink-0">
|
||||||
{selected.tags.map(t => <TagChip key={t} tag={t} />)}
|
{(selected.tags || []).map(t => <TagChip key={t} tag={t} />)}
|
||||||
</span>
|
</span>
|
||||||
)}
|
)}
|
||||||
</span>
|
</span>
|
||||||
@@ -107,7 +101,7 @@ function StyleDropdown({ value, onChange }: { value: string; onChange: (v: strin
|
|||||||
</button>
|
</button>
|
||||||
{open && (
|
{open && (
|
||||||
<div className="absolute z-20 mt-1 w-full max-h-80 overflow-auto rounded-lg border border-slate-200 dark:border-slate-700 bg-white dark:bg-slate-900 shadow-lg py-1">
|
<div className="absolute z-20 mt-1 w-full max-h-80 overflow-auto rounded-lg border border-slate-200 dark:border-slate-700 bg-white dark:bg-slate-900 shadow-lg py-1">
|
||||||
{MAPBOX_STYLE_PRESETS.map(preset => {
|
{presets.map(preset => {
|
||||||
const isActive = preset.url === value
|
const isActive = preset.url === value
|
||||||
return (
|
return (
|
||||||
<button
|
<button
|
||||||
@@ -118,7 +112,7 @@ function StyleDropdown({ value, onChange }: { value: string; onChange: (v: strin
|
|||||||
>
|
>
|
||||||
<span className="flex items-center gap-2 flex-wrap">
|
<span className="flex items-center gap-2 flex-wrap">
|
||||||
<span className="text-slate-900 dark:text-white font-medium">{preset.name}</span>
|
<span className="text-slate-900 dark:text-white font-medium">{preset.name}</span>
|
||||||
{preset.tags.map(t => <TagChip key={t} tag={t} />)}
|
{(preset.tags || []).map(t => <TagChip key={t} tag={t} />)}
|
||||||
</span>
|
</span>
|
||||||
{isActive && <Check size={14} className="flex-shrink-0 text-slate-900 dark:text-white" />}
|
{isActive && <Check size={14} className="flex-shrink-0 text-slate-900 dark:text-white" />}
|
||||||
</button>
|
</button>
|
||||||
@@ -130,17 +124,34 @@ function StyleDropdown({ value, onChange }: { value: string; onChange: (v: strin
|
|||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
type Provider = 'leaflet' | 'mapbox-gl'
|
type Provider = 'leaflet' | GlMapProvider
|
||||||
|
|
||||||
|
function normalizeProvider(value: unknown): Provider {
|
||||||
|
return value === 'mapbox-gl' || value === 'maplibre-gl' ? value : 'leaflet'
|
||||||
|
}
|
||||||
|
|
||||||
|
function styleForProvider(provider: Provider, style?: string | null): string {
|
||||||
|
if (provider === 'leaflet') return style || MAPBOX_DEFAULT_STYLE
|
||||||
|
if (provider === 'mapbox-gl' && isOpenFreeMapStyle(style)) return MAPBOX_DEFAULT_STYLE
|
||||||
|
return normalizeStyleForProvider(provider, style)
|
||||||
|
}
|
||||||
|
|
||||||
|
// Each GL provider has its own style slot, so toggling providers never clobbers the
|
||||||
|
// other one's style. Leaflet/Mapbox use mapbox_style; MapLibre uses maplibre_style.
|
||||||
|
function slotStyle(provider: Provider, s: { mapbox_style?: string; maplibre_style?: string }): string | undefined {
|
||||||
|
return provider === 'maplibre-gl' ? s.maplibre_style : s.mapbox_style
|
||||||
|
}
|
||||||
|
|
||||||
export default function MapSettingsTab(): React.ReactElement {
|
export default function MapSettingsTab(): React.ReactElement {
|
||||||
const { settings, updateSettings } = useSettingsStore()
|
const { settings, updateSettings } = useSettingsStore()
|
||||||
const { t } = useTranslation()
|
const { t } = useTranslation()
|
||||||
const toast = useToast()
|
const toast = useToast()
|
||||||
|
const initialProvider = normalizeProvider(settings.map_provider)
|
||||||
const [saving, setSaving] = useState(false)
|
const [saving, setSaving] = useState(false)
|
||||||
const [provider, setProvider] = useState<Provider>((settings.map_provider as Provider) || 'leaflet')
|
const [provider, setProvider] = useState<Provider>(initialProvider)
|
||||||
const [mapTileUrl, setMapTileUrl] = useState<string>(settings.map_tile_url || '')
|
const [mapTileUrl, setMapTileUrl] = useState<string>(settings.map_tile_url || '')
|
||||||
const [mapboxToken, setMapboxToken] = useState<string>(settings.mapbox_access_token || '')
|
const [mapboxToken, setMapboxToken] = useState<string>(settings.mapbox_access_token || '')
|
||||||
const [mapboxStyle, setMapboxStyle] = useState<string>(settings.mapbox_style || 'mapbox://styles/mapbox/standard')
|
const [mapboxStyle, setMapboxStyle] = useState<string>(styleForProvider(initialProvider, slotStyle(initialProvider, settings)))
|
||||||
const [mapbox3d, setMapbox3d] = useState<boolean>(settings.mapbox_3d_enabled !== false)
|
const [mapbox3d, setMapbox3d] = useState<boolean>(settings.mapbox_3d_enabled !== false)
|
||||||
const [mapboxQuality, setMapboxQuality] = useState<boolean>(settings.mapbox_quality_mode === true)
|
const [mapboxQuality, setMapboxQuality] = useState<boolean>(settings.mapbox_quality_mode === true)
|
||||||
const [defaultLat, setDefaultLat] = useState<number | string>(settings.default_lat || 48.8566)
|
const [defaultLat, setDefaultLat] = useState<number | string>(settings.default_lat || 48.8566)
|
||||||
@@ -148,10 +159,11 @@ export default function MapSettingsTab(): React.ReactElement {
|
|||||||
const [defaultZoom, setDefaultZoom] = useState<number | string>(settings.default_zoom || 10)
|
const [defaultZoom, setDefaultZoom] = useState<number | string>(settings.default_zoom || 10)
|
||||||
|
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
setProvider((settings.map_provider as Provider) || 'leaflet')
|
const nextProvider = normalizeProvider(settings.map_provider)
|
||||||
|
setProvider(nextProvider)
|
||||||
setMapTileUrl(settings.map_tile_url || '')
|
setMapTileUrl(settings.map_tile_url || '')
|
||||||
setMapboxToken(settings.mapbox_access_token || '')
|
setMapboxToken(settings.mapbox_access_token || '')
|
||||||
setMapboxStyle(settings.mapbox_style || 'mapbox://styles/mapbox/standard')
|
setMapboxStyle(styleForProvider(nextProvider, slotStyle(nextProvider, settings)))
|
||||||
setMapbox3d(settings.mapbox_3d_enabled !== false)
|
setMapbox3d(settings.mapbox_3d_enabled !== false)
|
||||||
setMapboxQuality(settings.mapbox_quality_mode === true)
|
setMapboxQuality(settings.mapbox_quality_mode === true)
|
||||||
setDefaultLat(settings.default_lat || 48.8566)
|
setDefaultLat(settings.default_lat || 48.8566)
|
||||||
@@ -186,11 +198,15 @@ export default function MapSettingsTab(): React.ReactElement {
|
|||||||
const saveMapSettings = async (): Promise<void> => {
|
const saveMapSettings = async (): Promise<void> => {
|
||||||
setSaving(true)
|
setSaving(true)
|
||||||
try {
|
try {
|
||||||
|
const glStyle = provider === 'leaflet' ? mapboxStyle : normalizeStyleForProvider(provider, mapboxStyle)
|
||||||
|
setMapboxStyle(glStyle)
|
||||||
|
// Save into the active provider's own slot so the other provider's style survives.
|
||||||
|
const stylePatch = provider === 'maplibre-gl' ? { maplibre_style: glStyle } : { mapbox_style: glStyle }
|
||||||
await updateSettings({
|
await updateSettings({
|
||||||
map_provider: provider,
|
map_provider: provider,
|
||||||
map_tile_url: mapTileUrl,
|
map_tile_url: mapTileUrl,
|
||||||
mapbox_access_token: mapboxToken,
|
mapbox_access_token: mapboxToken,
|
||||||
mapbox_style: mapboxStyle,
|
...stylePatch,
|
||||||
mapbox_3d_enabled: mapbox3d,
|
mapbox_3d_enabled: mapbox3d,
|
||||||
mapbox_quality_mode: mapboxQuality,
|
mapbox_quality_mode: mapboxQuality,
|
||||||
default_lat: parseFloat(String(defaultLat)),
|
default_lat: parseFloat(String(defaultLat)),
|
||||||
@@ -208,16 +224,20 @@ export default function MapSettingsTab(): React.ReactElement {
|
|||||||
// 3D is available on every style now — pure satellite uses the
|
// 3D is available on every style now — pure satellite uses the
|
||||||
// mapbox-streets-v8 tileset as a fallback building source.
|
// mapbox-streets-v8 tileset as a fallback building source.
|
||||||
const supports3d = true
|
const supports3d = true
|
||||||
|
const changeProvider = (nextProvider: Provider) => {
|
||||||
|
setProvider(nextProvider)
|
||||||
|
if (nextProvider !== 'leaflet') setMapboxStyle(styleForProvider(nextProvider, mapboxStyle))
|
||||||
|
}
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<Section title={t('settings.map')} icon={Map}>
|
<Section title={t('settings.map')} icon={Map}>
|
||||||
{/* Provider picker — big cards so the choice is obvious */}
|
{/* Provider picker — big cards so the choice is obvious */}
|
||||||
<div>
|
<div>
|
||||||
<label className="block text-sm font-medium text-slate-700 mb-2">{t('settings.mapProvider')}</label>
|
<label className="block text-sm font-medium text-slate-700 mb-2">{t('settings.mapProvider')}</label>
|
||||||
<div className="grid grid-cols-2 gap-2">
|
<div className="grid grid-cols-1 sm:grid-cols-3 gap-2">
|
||||||
<button
|
<button
|
||||||
type="button"
|
type="button"
|
||||||
onClick={() => setProvider('leaflet')}
|
onClick={() => changeProvider('leaflet')}
|
||||||
className={`flex items-start gap-3 p-3 rounded-lg border text-left transition-colors ${
|
className={`flex items-start gap-3 p-3 rounded-lg border text-left transition-colors ${
|
||||||
provider === 'leaflet'
|
provider === 'leaflet'
|
||||||
? 'border-slate-900 bg-slate-50 dark:bg-slate-800 dark:border-slate-200'
|
? 'border-slate-900 bg-slate-50 dark:bg-slate-800 dark:border-slate-200'
|
||||||
@@ -232,7 +252,7 @@ export default function MapSettingsTab(): React.ReactElement {
|
|||||||
</button>
|
</button>
|
||||||
<button
|
<button
|
||||||
type="button"
|
type="button"
|
||||||
onClick={() => setProvider('mapbox-gl')}
|
onClick={() => changeProvider('mapbox-gl')}
|
||||||
className={`relative flex items-start gap-3 p-3 rounded-lg border text-left transition-colors ${
|
className={`relative flex items-start gap-3 p-3 rounded-lg border text-left transition-colors ${
|
||||||
provider === 'mapbox-gl'
|
provider === 'mapbox-gl'
|
||||||
? 'border-slate-900 bg-slate-50 dark:bg-slate-800 dark:border-slate-200'
|
? 'border-slate-900 bg-slate-50 dark:bg-slate-800 dark:border-slate-200'
|
||||||
@@ -252,6 +272,24 @@ export default function MapSettingsTab(): React.ReactElement {
|
|||||||
{t('settings.mapExperimental')}
|
{t('settings.mapExperimental')}
|
||||||
</span>
|
</span>
|
||||||
</button>
|
</button>
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
onClick={() => changeProvider('maplibre-gl')}
|
||||||
|
className={`relative flex items-start gap-3 p-3 rounded-lg border text-left transition-colors ${
|
||||||
|
provider === 'maplibre-gl'
|
||||||
|
? 'border-slate-900 bg-slate-50 dark:bg-slate-800 dark:border-slate-200'
|
||||||
|
: 'border-slate-200 hover:border-slate-400 dark:border-slate-700'
|
||||||
|
}`}
|
||||||
|
>
|
||||||
|
<Globe2 size={18} className="mt-0.5 flex-shrink-0 text-slate-700 dark:text-slate-300" />
|
||||||
|
<div className="min-w-0">
|
||||||
|
<div className="text-sm font-medium text-slate-900 dark:text-white">
|
||||||
|
<span className="sm:hidden">MapLibre</span>
|
||||||
|
<span className="hidden sm:inline">MapLibre GL</span>
|
||||||
|
</div>
|
||||||
|
<div className="hidden sm:block text-xs text-slate-500 mt-0.5">{t('settings.mapMapLibreSubtitle')}</div>
|
||||||
|
</div>
|
||||||
|
</button>
|
||||||
</div>
|
</div>
|
||||||
<p className="text-xs text-slate-400 mt-2">
|
<p className="text-xs text-slate-400 mt-2">
|
||||||
{t('settings.mapProviderHint')}
|
{t('settings.mapProviderHint')}
|
||||||
@@ -281,9 +319,10 @@ export default function MapSettingsTab(): React.ReactElement {
|
|||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
|
|
||||||
{/* Mapbox GL settings */}
|
{/* GL settings */}
|
||||||
{provider === 'mapbox-gl' && (
|
{provider !== 'leaflet' && (
|
||||||
<div className="space-y-3">
|
<div className="space-y-3">
|
||||||
|
{provider === 'mapbox-gl' && (
|
||||||
<div>
|
<div>
|
||||||
<label className="block text-sm font-medium text-slate-700 mb-1.5">{t('settings.mapMapboxToken')}</label>
|
<label className="block text-sm font-medium text-slate-700 mb-1.5">{t('settings.mapMapboxToken')}</label>
|
||||||
<input
|
<input
|
||||||
@@ -300,24 +339,27 @@ export default function MapSettingsTab(): React.ReactElement {
|
|||||||
</a>
|
</a>
|
||||||
</p>
|
</p>
|
||||||
</div>
|
</div>
|
||||||
|
)}
|
||||||
|
|
||||||
<div>
|
<div>
|
||||||
<label className="block text-sm font-medium text-slate-700 mb-1.5">{t('settings.mapStyle')}</label>
|
<label className="block text-sm font-medium text-slate-700 mb-1.5">{t('settings.mapStyle')}</label>
|
||||||
<div className="mb-2">
|
<div className="mb-2">
|
||||||
<StyleDropdown value={mapboxStyle} onChange={setMapboxStyle} />
|
<StyleDropdown value={mapboxStyle} provider={provider} onChange={setMapboxStyle} />
|
||||||
</div>
|
</div>
|
||||||
<input
|
<input
|
||||||
type="text"
|
type="text"
|
||||||
value={mapboxStyle}
|
value={mapboxStyle}
|
||||||
onChange={(e) => setMapboxStyle(e.target.value)}
|
onChange={(e) => setMapboxStyle(e.target.value)}
|
||||||
placeholder="mapbox://styles/mapbox/standard"
|
placeholder={defaultStyleForProvider(provider)}
|
||||||
className="w-full px-3 py-2 border border-slate-300 rounded-lg text-sm font-mono focus:ring-2 focus:ring-slate-400 focus:border-transparent"
|
className="w-full px-3 py-2 border border-slate-300 rounded-lg text-sm font-mono focus:ring-2 focus:ring-slate-400 focus:border-transparent"
|
||||||
/>
|
/>
|
||||||
<p className="text-xs text-slate-400 mt-1">
|
<p className="text-xs text-slate-400 mt-1">
|
||||||
{t('settings.mapStyleHint')}
|
{provider === 'maplibre-gl' ? t('settings.mapOpenFreeMapStyleHint') : t('settings.mapStyleHint')}
|
||||||
</p>
|
</p>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
|
{provider === 'mapbox-gl' && (
|
||||||
|
<>
|
||||||
<div className={`flex items-start gap-3 p-3 rounded-lg border transition-colors ${
|
<div className={`flex items-start gap-3 p-3 rounded-lg border transition-colors ${
|
||||||
supports3d
|
supports3d
|
||||||
? 'border-slate-200 dark:border-slate-700'
|
? 'border-slate-200 dark:border-slate-700'
|
||||||
@@ -354,6 +396,8 @@ export default function MapSettingsTab(): React.ReactElement {
|
|||||||
<div className="text-xs text-slate-400 p-3 rounded-lg bg-slate-50 dark:bg-slate-800 border border-slate-200 dark:border-slate-700">
|
<div className="text-xs text-slate-400 p-3 rounded-lg bg-slate-50 dark:bg-slate-800 border border-slate-200 dark:border-slate-700">
|
||||||
<strong className="text-slate-600 dark:text-slate-300">{t('settings.mapTipLabel')}</strong> {t('settings.mapTip')}
|
<strong className="text-slate-600 dark:text-slate-300">{t('settings.mapTipLabel')}</strong> {t('settings.mapTip')}
|
||||||
</div>
|
</div>
|
||||||
|
</>
|
||||||
|
)}
|
||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
|
|
||||||
@@ -383,8 +427,9 @@ export default function MapSettingsTab(): React.ReactElement {
|
|||||||
|
|
||||||
<div>
|
<div>
|
||||||
<div style={{ position: 'relative', inset: 0, height: '200px', width: '100%' }}>
|
<div style={{ position: 'relative', inset: 0, height: '200px', width: '100%' }}>
|
||||||
{provider === 'mapbox-gl' ? (
|
{provider !== 'leaflet' ? (
|
||||||
<MapboxPreview
|
<GlMapPreview
|
||||||
|
provider={provider}
|
||||||
token={mapboxToken}
|
token={mapboxToken}
|
||||||
style={mapboxStyle}
|
style={mapboxStyle}
|
||||||
lat={parseFloat(String(defaultLat)) || 48.8566}
|
lat={parseFloat(String(defaultLat)) || 48.8566}
|
||||||
@@ -392,8 +437,8 @@ export default function MapSettingsTab(): React.ReactElement {
|
|||||||
// Zoom in close so the style's character (3D buildings,
|
// Zoom in close so the style's character (3D buildings,
|
||||||
// satellite texture, label density) is immediately visible.
|
// satellite texture, label density) is immediately visible.
|
||||||
zoom={Math.max(parseInt(String(defaultZoom)) || 10, 16)}
|
zoom={Math.max(parseInt(String(defaultZoom)) || 10, 16)}
|
||||||
enable3d={mapbox3d && supports3d}
|
enable3d={provider === 'mapbox-gl' && mapbox3d && supports3d}
|
||||||
quality={mapboxQuality}
|
quality={provider === 'mapbox-gl' && mapboxQuality}
|
||||||
onClick={(ll) => { setDefaultLat(ll.lat); setDefaultLng(ll.lng) }}
|
onClick={(ll) => { setDefaultLat(ll.lat); setDefaultLng(ll.lng) }}
|
||||||
/>
|
/>
|
||||||
) : (
|
) : (
|
||||||
|
|||||||
@@ -1,10 +1,14 @@
|
|||||||
import { useEffect, useRef } from 'react'
|
import { useEffect, useRef } from 'react'
|
||||||
import mapboxgl from 'mapbox-gl'
|
import mapboxgl from 'mapbox-gl'
|
||||||
|
import maplibregl from 'maplibre-gl'
|
||||||
import 'mapbox-gl/dist/mapbox-gl.css'
|
import 'mapbox-gl/dist/mapbox-gl.css'
|
||||||
|
import 'maplibre-gl/dist/maplibre-gl.css'
|
||||||
import { isStandardFamily, supportsCustom3d, addCustom3dBuildings, addTerrainAndSky } from '../Map/mapboxSetup'
|
import { isStandardFamily, supportsCustom3d, addCustom3dBuildings, addTerrainAndSky } from '../Map/mapboxSetup'
|
||||||
|
import { MAPBOX_DEFAULT_STYLE, normalizeStyleForProvider, type GlMapProvider } from '../Map/glProviders'
|
||||||
|
|
||||||
interface Props {
|
interface Props {
|
||||||
token: string
|
provider?: GlMapProvider
|
||||||
|
token?: string
|
||||||
style: string
|
style: string
|
||||||
lat: number
|
lat: number
|
||||||
lng: number
|
lng: number
|
||||||
@@ -14,37 +18,44 @@ interface Props {
|
|||||||
onClick?: (latlng: { lat: number; lng: number }) => void
|
onClick?: (latlng: { lat: number; lng: number }) => void
|
||||||
}
|
}
|
||||||
|
|
||||||
export default function MapboxPreview({ token, style, lat, lng, zoom, enable3d, quality = false, onClick }: Props) {
|
export default function GlMapPreview({ provider = 'mapbox-gl', token = '', style, lat, lng, zoom, enable3d, quality = false, onClick }: Props) {
|
||||||
const containerRef = useRef<HTMLDivElement>(null)
|
const containerRef = useRef<HTMLDivElement>(null)
|
||||||
const mapRef = useRef<mapboxgl.Map | null>(null)
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
||||||
|
const mapRef = useRef<any | null>(null)
|
||||||
const onClickRef = useRef(onClick)
|
const onClickRef = useRef(onClick)
|
||||||
onClickRef.current = onClick
|
onClickRef.current = onClick
|
||||||
|
const isMapLibre = provider === 'maplibre-gl'
|
||||||
|
const gl = (isMapLibre ? maplibregl : mapboxgl) as any
|
||||||
|
const glStyle = normalizeStyleForProvider(provider, style)
|
||||||
|
const enableMapbox3d = !isMapLibre && enable3d
|
||||||
|
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
if (!containerRef.current || !token) return
|
if (!containerRef.current || (!isMapLibre && !token)) return
|
||||||
mapboxgl.accessToken = token
|
if (!isMapLibre) mapboxgl.accessToken = token
|
||||||
|
|
||||||
const map = new mapboxgl.Map({
|
const mapOptions: Record<string, unknown> = {
|
||||||
container: containerRef.current,
|
container: containerRef.current,
|
||||||
style,
|
style: glStyle,
|
||||||
center: [lng, lat],
|
center: [lng, lat],
|
||||||
zoom,
|
zoom,
|
||||||
pitch: enable3d ? 45 : 0,
|
pitch: enableMapbox3d ? 45 : 0,
|
||||||
attributionControl: true,
|
attributionControl: true,
|
||||||
antialias: quality,
|
antialias: quality,
|
||||||
projection: quality ? 'globe' : 'mercator',
|
}
|
||||||
})
|
if (!isMapLibre) mapOptions.projection = quality ? 'globe' : 'mercator'
|
||||||
|
|
||||||
|
const map = new gl.Map(mapOptions as any)
|
||||||
mapRef.current = map
|
mapRef.current = map
|
||||||
|
|
||||||
map.on('load', () => {
|
map.on('load', () => {
|
||||||
if (enable3d) {
|
if (enableMapbox3d) {
|
||||||
if (!isStandardFamily(style)) addTerrainAndSky(map)
|
if (!isStandardFamily(glStyle)) addTerrainAndSky(map)
|
||||||
if (supportsCustom3d(style)) {
|
if (supportsCustom3d(glStyle)) {
|
||||||
const dark = document.documentElement.classList.contains('dark')
|
const dark = document.documentElement.classList.contains('dark')
|
||||||
addCustom3dBuildings(map, dark)
|
addCustom3dBuildings(map, dark)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
if (style === 'mapbox://styles/mapbox/standard') {
|
if (glStyle === MAPBOX_DEFAULT_STYLE) {
|
||||||
try { map.setTerrain(null) } catch { /* noop */ }
|
try { map.setTerrain(null) } catch { /* noop */ }
|
||||||
}
|
}
|
||||||
})
|
})
|
||||||
@@ -57,7 +68,7 @@ export default function MapboxPreview({ token, style, lat, lng, zoom, enable3d,
|
|||||||
try { map.remove() } catch { /* noop */ }
|
try { map.remove() } catch { /* noop */ }
|
||||||
mapRef.current = null
|
mapRef.current = null
|
||||||
}
|
}
|
||||||
}, [token, style, enable3d, quality])
|
}, [provider, token, glStyle, enableMapbox3d, quality])
|
||||||
|
|
||||||
// Recenter without rebuilding the map when lat/lng/zoom change externally
|
// Recenter without rebuilding the map when lat/lng/zoom change externally
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
@@ -65,7 +76,7 @@ export default function MapboxPreview({ token, style, lat, lng, zoom, enable3d,
|
|||||||
try { mapRef.current.jumpTo({ center: [lng, lat], zoom }) } catch { /* noop */ }
|
try { mapRef.current.jumpTo({ center: [lng, lat], zoom }) } catch { /* noop */ }
|
||||||
}, [lat, lng, zoom])
|
}, [lat, lng, zoom])
|
||||||
|
|
||||||
if (!token) {
|
if (!isMapLibre && !token) {
|
||||||
return (
|
return (
|
||||||
<div className="flex items-center justify-center h-full bg-slate-100 dark:bg-slate-800 text-xs text-slate-500 rounded-lg border border-slate-200 dark:border-slate-700">
|
<div className="flex items-center justify-center h-full bg-slate-100 dark:bg-slate-800 text-xs text-slate-500 rounded-lg border border-slate-200 dark:border-slate-700">
|
||||||
Enter a Mapbox access token to preview
|
Enter a Mapbox access token to preview
|
||||||
|
|||||||
@@ -21,6 +21,7 @@ interface CachedTripRow {
|
|||||||
export default function OfflineTab(): React.ReactElement {
|
export default function OfflineTab(): React.ReactElement {
|
||||||
const [rows, setRows] = useState<CachedTripRow[]>([])
|
const [rows, setRows] = useState<CachedTripRow[]>([])
|
||||||
const [pendingCount, setPendingCount] = useState(0)
|
const [pendingCount, setPendingCount] = useState(0)
|
||||||
|
const [failedCount, setFailedCount] = useState(0)
|
||||||
const [syncing, setSyncing] = useState(false)
|
const [syncing, setSyncing] = useState(false)
|
||||||
const [clearing, setClearing] = useState(false)
|
const [clearing, setClearing] = useState(false)
|
||||||
const [loading, setLoading] = useState(true)
|
const [loading, setLoading] = useState(true)
|
||||||
@@ -28,11 +29,13 @@ export default function OfflineTab(): React.ReactElement {
|
|||||||
const load = useCallback(async () => {
|
const load = useCallback(async () => {
|
||||||
setLoading(true)
|
setLoading(true)
|
||||||
try {
|
try {
|
||||||
const [metas, pending] = await Promise.all([
|
const [metas, pending, failed] = await Promise.all([
|
||||||
offlineDb.syncMeta.toArray(),
|
offlineDb.syncMeta.toArray(),
|
||||||
mutationQueue.pendingCount(),
|
mutationQueue.pendingCount(),
|
||||||
|
mutationQueue.failedCount(),
|
||||||
])
|
])
|
||||||
setPendingCount(pending)
|
setPendingCount(pending)
|
||||||
|
setFailedCount(failed)
|
||||||
|
|
||||||
const result: CachedTripRow[] = []
|
const result: CachedTripRow[] = []
|
||||||
for (const meta of metas) {
|
for (const meta of metas) {
|
||||||
@@ -85,6 +88,7 @@ export default function OfflineTab(): React.ReactElement {
|
|||||||
<div style={{ display: 'flex', gap: 12, flexWrap: 'wrap' }}>
|
<div style={{ display: 'flex', gap: 12, flexWrap: 'wrap' }}>
|
||||||
<Stat label="Cached trips" value={rows.length} />
|
<Stat label="Cached trips" value={rows.length} />
|
||||||
<Stat label="Pending changes" value={pendingCount} />
|
<Stat label="Pending changes" value={pendingCount} />
|
||||||
|
{failedCount > 0 && <Stat label="Failed changes" value={failedCount} danger />}
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
{/* Actions */}
|
{/* Actions */}
|
||||||
@@ -165,13 +169,14 @@ export default function OfflineTab(): React.ReactElement {
|
|||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
function Stat({ label, value }: { label: string; value: number }) {
|
function Stat({ label, value, danger }: { label: string; value: number; danger?: boolean }) {
|
||||||
return (
|
return (
|
||||||
<div className="border border-edge bg-surface-secondary" style={{
|
<div className="border border-edge bg-surface-secondary" style={{
|
||||||
padding: '8px 14px', borderRadius: 8,
|
padding: '8px 14px', borderRadius: 8,
|
||||||
minWidth: 100,
|
minWidth: 100,
|
||||||
}}>
|
}}>
|
||||||
<div className="text-content" style={{ fontSize: 20, fontWeight: 700 }}>{value}</div>
|
<div style={{ fontSize: 20, fontWeight: 700, color: danger ? '#ef4444' : undefined }}
|
||||||
|
className={danger ? undefined : 'text-content'}>{value}</div>
|
||||||
<div className="text-content-muted" style={{ fontSize: 11 }}>{label}</div>
|
<div className="text-content-muted" style={{ fontSize: 11 }}>{label}</div>
|
||||||
</div>
|
</div>
|
||||||
)
|
)
|
||||||
|
|||||||
@@ -1,8 +1,8 @@
|
|||||||
import React from 'react'
|
import React from 'react'
|
||||||
|
|
||||||
export default function ToggleSwitch({ on, onToggle }: { on: boolean; onToggle: () => void }) {
|
export default function ToggleSwitch({ on, onToggle, label }: { on: boolean; onToggle: () => void; label?: string }) {
|
||||||
return (
|
return (
|
||||||
<button type="button" onClick={onToggle}
|
<button type="button" onClick={onToggle} aria-pressed={on} aria-label={label}
|
||||||
style={{
|
style={{
|
||||||
position: 'relative', width: 44, height: 24, minWidth: 44, flexShrink: 0,
|
position: 'relative', width: 44, height: 24, minWidth: 44, flexShrink: 0,
|
||||||
borderRadius: 12, border: 'none', padding: 0, cursor: 'pointer',
|
borderRadius: 12, border: 'none', padding: 0, cursor: 'pointer',
|
||||||
|
|||||||
@@ -62,16 +62,17 @@ function CTALink({
|
|||||||
if (notice.cta.kind === 'nav') {
|
if (notice.cta.kind === 'nav') {
|
||||||
navigate(notice.cta.href);
|
navigate(notice.cta.href);
|
||||||
if (notice.dismissible) onDismiss();
|
if (notice.dismissible) onDismiss();
|
||||||
|
} else if (notice.cta.kind === 'link') {
|
||||||
|
window.open(notice.cta.href, '_blank', 'noopener,noreferrer');
|
||||||
} else {
|
} else {
|
||||||
runNoticeAction(notice.cta.actionId, { navigate });
|
runNoticeAction(notice.cta.actionId, { navigate });
|
||||||
const actionCta = notice.cta as { kind: 'action'; labelKey: string; actionId: string; dismissOnAction?: boolean };
|
if (notice.cta.dismissOnAction !== false) onDismiss();
|
||||||
if (actionCta.dismissOnAction !== false) onDismiss();
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
if (!notice.cta) return null;
|
if (!notice.cta) return null;
|
||||||
|
|
||||||
if (notice.cta.kind === 'nav') {
|
if (notice.cta.kind === 'nav' || notice.cta.kind === 'link') {
|
||||||
return (
|
return (
|
||||||
<a
|
<a
|
||||||
href={notice.cta.href}
|
href={notice.cta.href}
|
||||||
|
|||||||
@@ -1,10 +1,26 @@
|
|||||||
import React, { useEffect } from 'react';
|
import { useEffect, useState } from 'react';
|
||||||
import { useSystemNoticeStore } from '../../store/systemNoticeStore.js';
|
import { useSystemNoticeStore } from '../../store/systemNoticeStore.js';
|
||||||
import { ModalRenderer } from './SystemNoticeModal.js';
|
import { ModalRenderer } from './SystemNoticeModal.js';
|
||||||
import { BannerRenderer, ToastRenderer } from './SystemNoticeBanner.js';
|
import { BannerRenderer, ToastRenderer } from './SystemNoticeBanner.js';
|
||||||
|
|
||||||
|
// Mobile breakpoint matches the modal sheet's (max-width: 639px).
|
||||||
|
function useIsMobile() {
|
||||||
|
const [isMobile, setIsMobile] = useState(
|
||||||
|
() => typeof window !== 'undefined' && (window.matchMedia?.('(max-width: 639px)')?.matches ?? false)
|
||||||
|
);
|
||||||
|
useEffect(() => {
|
||||||
|
const mq = window.matchMedia?.('(max-width: 639px)');
|
||||||
|
if (!mq) return;
|
||||||
|
const handler = (e: MediaQueryListEvent) => setIsMobile(e.matches);
|
||||||
|
mq.addEventListener('change', handler);
|
||||||
|
return () => mq.removeEventListener('change', handler);
|
||||||
|
}, []);
|
||||||
|
return isMobile;
|
||||||
|
}
|
||||||
|
|
||||||
export function SystemNoticeHost() {
|
export function SystemNoticeHost() {
|
||||||
const { notices, loaded } = useSystemNoticeStore();
|
const { notices, loaded } = useSystemNoticeStore();
|
||||||
|
const isMobile = useIsMobile();
|
||||||
|
|
||||||
// Notices are fetched by authStore after login (see App.tsx / authStore modification).
|
// Notices are fetched by authStore after login (see App.tsx / authStore modification).
|
||||||
// Cold-session fetch (page reload with valid session) is triggered here:
|
// Cold-session fetch (page reload with valid session) is triggered here:
|
||||||
@@ -17,9 +33,12 @@ export function SystemNoticeHost() {
|
|||||||
|
|
||||||
if (!loaded) return null;
|
if (!loaded) return null;
|
||||||
|
|
||||||
const modals = notices.filter(n => n.display === 'modal');
|
// desktopOnly notices (e.g. the thank-you/support modal) are hidden on mobile.
|
||||||
const banners = notices.filter(n => n.display === 'banner');
|
const visible = isMobile ? notices.filter(n => !n.desktopOnly) : notices;
|
||||||
const toasts = notices.filter(n => n.display === 'toast');
|
|
||||||
|
const modals = visible.filter(n => n.display === 'modal');
|
||||||
|
const banners = visible.filter(n => n.display === 'banner');
|
||||||
|
const toasts = visible.filter(n => n.display === 'toast');
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<>
|
<>
|
||||||
|
|||||||
@@ -1,7 +1,7 @@
|
|||||||
import React, { useState, useEffect, useRef } from 'react';
|
import React, { useState, useEffect, useRef } from 'react';
|
||||||
import { flushSync } from 'react-dom';
|
import { flushSync } from 'react-dom';
|
||||||
import { useNavigate } from 'react-router-dom';
|
import { useNavigate } from 'react-router-dom';
|
||||||
import { Info, AlertTriangle, AlertOctagon, X, ChevronLeft, ChevronRight } from 'lucide-react';
|
import { Info, AlertTriangle, AlertOctagon, X, ChevronLeft, ChevronRight, Coffee } from 'lucide-react';
|
||||||
import * as LucideIcons from 'lucide-react';
|
import * as LucideIcons from 'lucide-react';
|
||||||
import remarkGfm from 'remark-gfm';
|
import remarkGfm from 'remark-gfm';
|
||||||
import rehypeSanitize from 'rehype-sanitize';
|
import rehypeSanitize from 'rehype-sanitize';
|
||||||
@@ -36,6 +36,33 @@ const SEVERITY_ACCENT: Record<string, string> = {
|
|||||||
critical: 'text-rose-600 dark:text-rose-400 bg-rose-50 dark:bg-rose-950',
|
critical: 'text-rose-600 dark:text-rose-400 bg-rose-50 dark:bg-rose-950',
|
||||||
};
|
};
|
||||||
|
|
||||||
|
// Real brand marks (simple-icons single-path logos) for the support buttons, so the
|
||||||
|
// Buy Me a Coffee / Ko-fi buttons carry their actual logo instead of a generic
|
||||||
|
// lucide glyph. Tinted via currentColor.
|
||||||
|
const BRAND_ICON_PATHS: Record<string, string> = {
|
||||||
|
buymeacoffee:
|
||||||
|
'M20.216 6.415l-.132-.666c-.119-.598-.388-1.163-1.001-1.379-.197-.069-.42-.098-.57-.241-.152-.143-.196-.366-.231-.572-.065-.378-.125-.756-.192-1.133-.057-.325-.102-.69-.25-.987-.195-.4-.597-.634-.996-.788a5.723 5.723 0 00-.626-.194c-1-.263-2.05-.36-3.077-.416a25.834 25.834 0 00-3.7.062c-.915.083-1.88.184-2.75.5-.318.116-.646.256-.888.501-.297.302-.393.77-.177 1.146.154.267.415.456.692.58.36.162.737.284 1.123.366 1.075.238 2.189.331 3.287.37 1.218.05 2.437.01 3.65-.118.299-.033.598-.073.896-.119.352-.054.578-.513.474-.834-.124-.383-.457-.531-.834-.473-.466.074-.96.108-1.382.146-1.177.08-2.358.082-3.536.006a22.228 22.228 0 01-1.157-.107c-.086-.01-.18-.025-.258-.036-.243-.036-.484-.08-.724-.13-.111-.027-.111-.185 0-.212h.005c.277-.06.557-.108.838-.147h.002c.131-.009.263-.032.394-.048a25.076 25.076 0 013.426-.12c.674.019 1.347.067 2.017.144l.228.031c.267.04.533.088.798.145.392.085.895.113 1.07.542.055.137.08.288.111.431l.319 1.484a.237.237 0 01-.199.284h-.003c-.037.006-.075.01-.112.015a36.704 36.704 0 01-4.743.295 37.059 37.059 0 01-4.699-.304c-.14-.017-.293-.042-.417-.06-.326-.048-.649-.108-.973-.161-.393-.065-.768-.032-1.123.161-.29.16-.527.404-.675.701-.154.316-.199.66-.267 1-.069.34-.176.707-.135 1.056.087.753.613 1.365 1.37 1.502a39.69 39.69 0 0011.343.376.483.483 0 01.535.53l-.071.697-1.018 9.907c-.041.41-.047.832-.125 1.237-.122.637-.553 1.028-1.182 1.171-.577.131-1.165.2-1.756.205-.656.004-1.31-.025-1.966-.022-.699.004-1.556-.06-2.095-.58-.475-.458-.54-1.174-.605-1.793l-.731-7.013-.322-3.094c-.037-.351-.286-.695-.678-.678-.336.015-.718.3-.678.679l.228 2.185.949 9.112c.147 1.344 1.174 2.068 2.446 2.272.742.12 1.503.144 2.257.156.966.016 1.942.053 2.892-.122 1.408-.258 2.465-1.198 2.616-2.657.34-3.332.683-6.663 1.024-9.995l.215-2.087a.484.484 0 01.39-.426c.402-.078.787-.212 1.074-.518.455-.488.546-1.124.385-1.766zm-1.478.772c-.145.137-.363.201-.578.233-2.416.359-4.866.54-7.308.46-1.748-.06-3.477-.254-5.207-.498-.17-.024-.353-.055-.47-.18-.22-.236-.111-.71-.054-.995.052-.26.152-.609.463-.646.484-.057 1.046.148 1.526.22.577.088 1.156.159 1.737.212 2.48.226 5.002.19 7.472-.14.45-.06.899-.13 1.345-.21.399-.072.84-.206 1.08.206.166.281.188.657.162.974a.544.544 0 01-.169.364zm-6.159 3.9c-.862.37-1.84.788-3.109.788a5.884 5.884 0 01-1.569-.217l.877 9.004c.065.78.717 1.38 1.5 1.38 0 0 1.243.065 1.658.065.447 0 1.786-.065 1.786-.065.783 0 1.434-.6 1.499-1.38l.94-9.95a3.996 3.996 0 00-1.322-.238c-.826 0-1.491.284-2.26.613z',
|
||||||
|
kofi:
|
||||||
|
'M11.351 2.715c-2.7 0-4.986.025-6.83.26C2.078 3.285 0 5.154 0 8.61c0 3.506.182 6.13 1.585 8.493 1.584 2.701 4.233 4.182 7.662 4.182h.83c4.209 0 6.494-2.234 7.637-4a9.5 9.5 0 0 0 1.091-2.338C21.792 14.688 24 12.22 24 9.208v-.415c0-3.247-2.13-5.507-5.792-5.87-1.558-.156-2.65-.208-6.857-.208m0 1.947c4.208 0 5.09.052 6.571.182 2.624.311 4.13 1.584 4.13 4v.39c0 2.156-1.792 3.844-3.87 3.844h-.935l-.156.649c-.208 1.013-.597 1.818-1.039 2.546-.909 1.428-2.545 3.064-5.922 3.064h-.805c-2.571 0-4.831-.883-6.078-3.195-1.09-2-1.298-4.155-1.298-7.506 0-2.181.857-3.402 3.012-3.714 1.533-.233 3.559-.26 6.39-.26m6.547 2.287c-.416 0-.65.234-.65.546v2.935c0 .311.234.545.65.545 1.324 0 2.051-.754 2.051-2s-.727-2.026-2.052-2.026m-10.39.182c-1.818 0-3.013 1.48-3.013 3.142 0 1.533.858 2.857 1.949 3.897.727.701 1.87 1.429 2.649 1.896a1.47 1.47 0 0 0 1.507 0c.78-.467 1.922-1.195 2.623-1.896 1.117-1.039 1.974-2.364 1.974-3.897 0-1.662-1.247-3.142-3.039-3.142-1.065 0-1.792.545-2.338 1.298-.493-.753-1.246-1.298-2.312-1.298',
|
||||||
|
};
|
||||||
|
|
||||||
|
function brandForHref(href?: string): string | null {
|
||||||
|
if (!href) return null;
|
||||||
|
if (href.includes('buymeacoffee')) return 'buymeacoffee';
|
||||||
|
if (href.includes('ko-fi.com') || href.includes('kofi')) return 'kofi';
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
function BrandIcon({ brand, size = 18, className }: { brand: string; size?: number; className?: string }) {
|
||||||
|
const d = BRAND_ICON_PATHS[brand];
|
||||||
|
if (!d) return null;
|
||||||
|
return (
|
||||||
|
<svg viewBox="0 0 24 24" width={size} height={size} fill="currentColor" className={className} aria-hidden="true">
|
||||||
|
<path d={d} />
|
||||||
|
</svg>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
interface Props {
|
interface Props {
|
||||||
notices: SystemNoticeDTO[];
|
notices: SystemNoticeDTO[];
|
||||||
}
|
}
|
||||||
@@ -46,12 +73,14 @@ interface ContentProps {
|
|||||||
title: string;
|
title: string;
|
||||||
body: string;
|
body: string;
|
||||||
ctaLabel: string | null;
|
ctaLabel: string | null;
|
||||||
|
secondaryCtaLabel: string | null;
|
||||||
titleId: string;
|
titleId: string;
|
||||||
bodyId: string;
|
bodyId: string;
|
||||||
isDark: boolean;
|
isDark: boolean;
|
||||||
onDismiss: () => void;
|
onDismiss: () => void;
|
||||||
onDismissAll: () => void;
|
onDismissAll: () => void;
|
||||||
onCTA: () => void;
|
onCTA: () => void;
|
||||||
|
onSecondaryCTA: () => void;
|
||||||
// Pager
|
// Pager
|
||||||
total: number;
|
total: number;
|
||||||
currentPage: number;
|
currentPage: number;
|
||||||
@@ -61,7 +90,7 @@ interface ContentProps {
|
|||||||
onGoto: (i: number) => void;
|
onGoto: (i: number) => void;
|
||||||
}
|
}
|
||||||
|
|
||||||
function NoticeContent({ notice, title, body, ctaLabel, titleId, bodyId, isDark, onDismiss, onDismissAll, onCTA, total, currentPage, canPage, onPrev, onNext, onGoto }: ContentProps) {
|
function NoticeContent({ notice, title, body, ctaLabel, secondaryCtaLabel, titleId, bodyId, isDark, onDismiss, onDismissAll, onCTA, onSecondaryCTA, total, currentPage, canPage, onPrev, onNext, onGoto }: ContentProps) {
|
||||||
const { t } = useTranslation();
|
const { t } = useTranslation();
|
||||||
const isLastPage = total <= 1 || currentPage === total - 1;
|
const isLastPage = total <= 1 || currentPage === total - 1;
|
||||||
|
|
||||||
@@ -70,6 +99,10 @@ function NoticeContent({ notice, title, body, ctaLabel, titleId, bodyId, isDark,
|
|||||||
? ((LucideIcons as Record<string, unknown>)[notice.icon] as React.ElementType) ?? DefaultIcon
|
? ((LucideIcons as Record<string, unknown>)[notice.icon] as React.ElementType) ?? DefaultIcon
|
||||||
: DefaultIcon;
|
: DefaultIcon;
|
||||||
|
|
||||||
|
// Real brand logo for each support button, detected from the link target.
|
||||||
|
const primaryBrand = notice.cta?.kind === 'link' ? brandForHref(notice.cta.href) : null;
|
||||||
|
const secondaryBrand = notice.secondaryCta?.kind === 'link' ? brandForHref(notice.secondaryCta.href) : null;
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<div className="flex flex-col relative" style={{ flex: '1 1 0', minHeight: '100%' }}>
|
<div className="flex flex-col relative" style={{ flex: '1 1 0', minHeight: '100%' }}>
|
||||||
{/* Dismiss X button — only on last page so users read all notices */}
|
{/* Dismiss X button — only on last page so users read all notices */}
|
||||||
@@ -104,17 +137,9 @@ function NoticeContent({ notice, title, body, ctaLabel, titleId, bodyId, isDark,
|
|||||||
|
|
||||||
{/* Special warm header for Heart icon (thank-you notice) */}
|
{/* Special warm header for Heart icon (thank-you notice) */}
|
||||||
{notice.icon === 'Heart' && !notice.media && (
|
{notice.icon === 'Heart' && !notice.media && (
|
||||||
<div className="relative overflow-hidden bg-gradient-to-br from-rose-500 via-pink-500 to-indigo-500 px-8 py-5 text-center">
|
<div className="relative overflow-hidden bg-gradient-to-br from-rose-500 via-pink-500 to-indigo-500 px-8 py-6 text-center">
|
||||||
<div className="absolute inset-0 opacity-10" style={{ backgroundImage: 'radial-gradient(circle at 20% 50%, white 1px, transparent 1px), radial-gradient(circle at 80% 20%, white 1px, transparent 1px), radial-gradient(circle at 60% 80%, white 1px, transparent 1px)', backgroundSize: '60px 60px, 80px 80px, 40px 40px' }} />
|
<div className="absolute inset-0 opacity-10" style={{ backgroundImage: 'radial-gradient(circle at 20% 50%, white 1px, transparent 1px), radial-gradient(circle at 80% 20%, white 1px, transparent 1px), radial-gradient(circle at 60% 80%, white 1px, transparent 1px)', backgroundSize: '60px 60px, 80px 80px, 40px 40px' }} />
|
||||||
<div className="relative flex items-center justify-center gap-3">
|
<h2 id={titleId} className="relative text-xl font-bold text-white leading-tight">{title}</h2>
|
||||||
<div className="w-10 h-10 rounded-full bg-white/20 backdrop-blur-sm flex items-center justify-center ring-2 ring-white/10">
|
|
||||||
<LucideIcon size={20} className="text-white" />
|
|
||||||
</div>
|
|
||||||
<div className="text-left">
|
|
||||||
<h2 id={titleId} className="text-lg font-bold text-white leading-tight">{title}</h2>
|
|
||||||
<p className="text-xs text-white/60 font-medium">TREK 3.0</p>
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
|
|
||||||
@@ -197,24 +222,27 @@ function NoticeContent({ notice, title, body, ctaLabel, titleId, bodyId, isDark,
|
|||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
|
|
||||||
{/* Highlights */}
|
{/* Highlights — compact pills */}
|
||||||
{notice.highlights && notice.highlights.length > 0 && (
|
{notice.highlights && notice.highlights.length > 0 && (
|
||||||
<ul className="mx-auto mb-4 space-y-2">
|
<div className="flex flex-wrap justify-center gap-2 mb-4">
|
||||||
{notice.highlights.map((h, i) => {
|
{notice.highlights.map((h, i) => {
|
||||||
const HIcon: React.ElementType | null = h.iconName
|
const HIcon: React.ElementType | null = h.iconName
|
||||||
? ((LucideIcons as Record<string, unknown>)[h.iconName] as React.ElementType) ?? null
|
? ((LucideIcons as Record<string, unknown>)[h.iconName] as React.ElementType) ?? null
|
||||||
: null;
|
: null;
|
||||||
return (
|
return (
|
||||||
<li key={i} className="flex items-center gap-2 text-sm text-slate-700 dark:text-slate-300">
|
<span
|
||||||
|
key={i}
|
||||||
|
className="inline-flex items-center gap-1.5 rounded-full bg-slate-100 dark:bg-slate-800 px-3 py-1 text-xs font-medium text-slate-700 dark:text-slate-300"
|
||||||
|
>
|
||||||
{HIcon
|
{HIcon
|
||||||
? <HIcon size={16} className="text-blue-500 shrink-0" />
|
? <HIcon size={13} className="text-indigo-500 dark:text-indigo-400 shrink-0" />
|
||||||
: <span className="text-blue-500 shrink-0">✓</span>
|
: <span className="text-indigo-500 shrink-0">✓</span>
|
||||||
}
|
}
|
||||||
{t(h.labelKey)}
|
{t(h.labelKey)}
|
||||||
</li>
|
</span>
|
||||||
);
|
);
|
||||||
})}
|
})}
|
||||||
</ul>
|
</div>
|
||||||
)}
|
)}
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
@@ -270,16 +298,37 @@ function NoticeContent({ notice, title, body, ctaLabel, titleId, bodyId, isDark,
|
|||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
|
|
||||||
{/* CTA + dismiss link */}
|
{/* CTA(s) + dismiss link */}
|
||||||
<div className="flex flex-col items-center gap-3">
|
<div className="flex flex-col items-center gap-3">
|
||||||
{ctaLabel && isLastPage ? (
|
{ctaLabel && isLastPage ? (
|
||||||
<button
|
<div className="flex w-full flex-col sm:flex-row gap-2.5">
|
||||||
id={`notice-cta-${notice.id}`}
|
<button
|
||||||
onClick={onCTA}
|
id={`notice-cta-${notice.id}`}
|
||||||
className="w-full h-11 rounded-lg bg-blue-600 hover:bg-blue-700 text-white font-medium transition-colors"
|
onClick={onCTA}
|
||||||
>
|
className={`flex-1 h-11 inline-flex items-center justify-center gap-2 rounded-lg font-semibold shadow-sm transition active:scale-[0.98] ${
|
||||||
{ctaLabel}
|
notice.cta?.kind === 'link'
|
||||||
</button>
|
? 'bg-[#FFDD00] text-[#0D0C22] hover:brightness-95'
|
||||||
|
: 'bg-blue-600 hover:bg-blue-700 text-white'
|
||||||
|
}`}
|
||||||
|
>
|
||||||
|
{primaryBrand ? <BrandIcon brand={primaryBrand} size={18} /> : (notice.cta?.kind === 'link' && <Coffee size={17} aria-hidden="true" />)}
|
||||||
|
{ctaLabel}
|
||||||
|
</button>
|
||||||
|
{secondaryCtaLabel && (
|
||||||
|
<button
|
||||||
|
id={`notice-cta2-${notice.id}`}
|
||||||
|
onClick={onSecondaryCTA}
|
||||||
|
className={`flex-1 h-11 inline-flex items-center justify-center gap-2 rounded-lg font-semibold shadow-sm transition active:scale-[0.98] ${
|
||||||
|
notice.secondaryCta?.kind === 'link'
|
||||||
|
? 'bg-[#FF5E5B] text-white hover:brightness-95'
|
||||||
|
: 'bg-blue-600 hover:bg-blue-700 text-white'
|
||||||
|
}`}
|
||||||
|
>
|
||||||
|
{secondaryBrand ? <BrandIcon brand={secondaryBrand} size={18} /> : (notice.secondaryCta?.kind === 'link' && <Coffee size={17} aria-hidden="true" />)}
|
||||||
|
{secondaryCtaLabel}
|
||||||
|
</button>
|
||||||
|
)}
|
||||||
|
</div>
|
||||||
) : (notice.dismissible || isLastPage) && (
|
) : (notice.dismissible || isLastPage) && (
|
||||||
<button
|
<button
|
||||||
id={`notice-cta-${notice.id}`}
|
id={`notice-cta-${notice.id}`}
|
||||||
@@ -289,14 +338,6 @@ function NoticeContent({ notice, title, body, ctaLabel, titleId, bodyId, isDark,
|
|||||||
{t('common.ok')}
|
{t('common.ok')}
|
||||||
</button>
|
</button>
|
||||||
)}
|
)}
|
||||||
{notice.dismissible && isLastPage && ctaLabel && (
|
|
||||||
<button
|
|
||||||
onClick={onDismiss}
|
|
||||||
className="text-sm text-slate-500 dark:text-slate-400 hover:text-slate-700 dark:hover:text-slate-200 transition-colors"
|
|
||||||
>
|
|
||||||
Not now
|
|
||||||
</button>
|
|
||||||
)}
|
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
@@ -510,21 +551,22 @@ function useSystemNoticeModal(notices: SystemNoticeDTO[]) {
|
|||||||
notices.forEach(n => dismiss(n.id));
|
notices.forEach(n => dismiss(n.id));
|
||||||
}
|
}
|
||||||
|
|
||||||
function handleCTA() {
|
function runCta(cta: SystemNoticeDTO['cta']) {
|
||||||
if (!notice) return;
|
if (!cta) { handleDismissAll(); return; }
|
||||||
if (!notice.cta) {
|
if (cta.kind === 'nav') {
|
||||||
handleDismissAll();
|
navigate(cta.href);
|
||||||
return;
|
if (notice?.dismissible !== false) handleDismissAll();
|
||||||
}
|
} else if (cta.kind === 'link') {
|
||||||
if (notice.cta.kind === 'nav') {
|
// External link (e.g. Buy Me a Coffee / Ko-fi): open in a new tab and leave the
|
||||||
navigate(notice.cta.href);
|
// notice open so the user can use the other button too.
|
||||||
if (notice.dismissible !== false) handleDismissAll();
|
window.open(cta.href, '_blank', 'noopener,noreferrer');
|
||||||
} else {
|
} else {
|
||||||
runNoticeAction(notice.cta.actionId, { navigate });
|
runNoticeAction(cta.actionId, { navigate });
|
||||||
const actionCta = notice.cta as { kind: 'action'; labelKey: string; actionId: string; dismissOnAction?: boolean };
|
if (cta.dismissOnAction !== false) handleDismissAll();
|
||||||
if (actionCta.dismissOnAction !== false) handleDismissAll();
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
function handleCTA() { runCta(notice?.cta); }
|
||||||
|
function handleSecondaryCTA() { runCta(notice?.secondaryCta); }
|
||||||
|
|
||||||
function animatedDismissAll() {
|
function animatedDismissAll() {
|
||||||
const sheet = sheetRef.current;
|
const sheet = sheetRef.current;
|
||||||
@@ -584,7 +626,7 @@ function useSystemNoticeModal(notices: SystemNoticeDTO[]) {
|
|||||||
notice, canPage, isLastPage, language, t, dur, ease,
|
notice, canPage, isLastPage, language, t, dur, ease,
|
||||||
touchStartX, touchStartY, dragLockRef, scrollTopAtTouchStart, isPageNavRef,
|
touchStartX, touchStartY, dragLockRef, scrollTopAtTouchStart, isPageNavRef,
|
||||||
stripRef, sheetRef, prevSlotRef, contentWrapperRef, nextSlotRef,
|
stripRef, sheetRef, prevSlotRef, contentWrapperRef, nextSlotRef,
|
||||||
announceIndex, handleDismiss, handleDismissAll, handleCTA, animatedDismissAll,
|
announceIndex, handleDismiss, handleDismissAll, handleCTA, handleSecondaryCTA, animatedDismissAll,
|
||||||
handlePrev, handleNext, handleGoto,
|
handlePrev, handleNext, handleGoto,
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
@@ -593,7 +635,7 @@ type NoticeState = ReturnType<typeof useSystemNoticeModal>;
|
|||||||
|
|
||||||
// Build the NoticeContent props for a given notice + pager slot index.
|
// Build the NoticeContent props for a given notice + pager slot index.
|
||||||
function makeContentProps(S: NoticeState, n: SystemNoticeDTO, slotIdx: number): ContentProps {
|
function makeContentProps(S: NoticeState, n: SystemNoticeDTO, slotIdx: number): ContentProps {
|
||||||
const { t, isDark, canPage, notices, handleDismiss, handleDismissAll, handleCTA, handlePrev, handleNext, handleGoto } = S;
|
const { t, isDark, canPage, notices, handleDismiss, handleDismissAll, handleCTA, handleSecondaryCTA, handlePrev, handleNext, handleGoto } = S;
|
||||||
const rawBody = t(n.bodyKey);
|
const rawBody = t(n.bodyKey);
|
||||||
const body = n.bodyParams
|
const body = n.bodyParams
|
||||||
? Object.entries(n.bodyParams).reduce(
|
? Object.entries(n.bodyParams).reduce(
|
||||||
@@ -606,12 +648,14 @@ function makeContentProps(S: NoticeState, n: SystemNoticeDTO, slotIdx: number):
|
|||||||
title: t(n.titleKey),
|
title: t(n.titleKey),
|
||||||
body,
|
body,
|
||||||
ctaLabel: n.cta ? t(n.cta.labelKey) : null,
|
ctaLabel: n.cta ? t(n.cta.labelKey) : null,
|
||||||
|
secondaryCtaLabel: n.secondaryCta ? t(n.secondaryCta.labelKey) : null,
|
||||||
titleId: `notice-title-${n.id}`,
|
titleId: `notice-title-${n.id}`,
|
||||||
bodyId: `notice-body-${n.id}`,
|
bodyId: `notice-body-${n.id}`,
|
||||||
isDark,
|
isDark,
|
||||||
onDismiss: handleDismiss,
|
onDismiss: handleDismiss,
|
||||||
onDismissAll: handleDismissAll,
|
onDismissAll: handleDismissAll,
|
||||||
onCTA: handleCTA,
|
onCTA: handleCTA,
|
||||||
|
onSecondaryCTA: handleSecondaryCTA,
|
||||||
total: notices.length,
|
total: notices.length,
|
||||||
currentPage: slotIdx,
|
currentPage: slotIdx,
|
||||||
canPage,
|
canPage,
|
||||||
|
|||||||
@@ -288,4 +288,26 @@ describe('TripFormModal', () => {
|
|||||||
await user.click(submitBtn.closest('button')!);
|
await user.click(submitBtn.closest('button')!);
|
||||||
await waitFor(() => expect(screen.getByText('Saving...')).toBeInTheDocument());
|
await waitFor(() => expect(screen.getByText('Saving...')).toBeInTheDocument());
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it('FE-COMP-TRIPFORM-029: clearing the day count leaves the field empty (no snap to 1)', () => {
|
||||||
|
render(<TripFormModal {...defaultProps} trip={null} />);
|
||||||
|
const dayInput = document.querySelector('input[max="365"]') as HTMLInputElement;
|
||||||
|
expect(dayInput).toBeInTheDocument();
|
||||||
|
expect(dayInput.value).toBe('7');
|
||||||
|
fireEvent.change(dayInput, { target: { value: '' } });
|
||||||
|
expect(dayInput.value).toBe('');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('FE-COMP-TRIPFORM-030: empty day count blocks submit with an error', async () => {
|
||||||
|
const user = userEvent.setup();
|
||||||
|
const onSave = vi.fn();
|
||||||
|
render(<TripFormModal {...defaultProps} trip={null} onSave={onSave} />);
|
||||||
|
await user.type(screen.getByPlaceholderText(/Summer in Japan/i), 'No-date Trip');
|
||||||
|
const dayInput = document.querySelector('input[max="365"]') as HTMLInputElement;
|
||||||
|
fireEvent.change(dayInput, { target: { value: '' } });
|
||||||
|
const submitBtn = screen.getAllByText('Create New Trip').find(el => el.closest('button'))!;
|
||||||
|
await user.click(submitBtn.closest('button')!);
|
||||||
|
await screen.findByText('Number of days is required');
|
||||||
|
expect(onSave).not.toHaveBeenCalled();
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -40,7 +40,7 @@ export default function TripFormModal({ isOpen, onClose, onSave, trip, onCoverUp
|
|||||||
start_date: '',
|
start_date: '',
|
||||||
end_date: '',
|
end_date: '',
|
||||||
reminder_days: 0 as number,
|
reminder_days: 0 as number,
|
||||||
day_count: 7,
|
day_count: 7 as number | '',
|
||||||
})
|
})
|
||||||
const [customReminder, setCustomReminder] = useState(false)
|
const [customReminder, setCustomReminder] = useState(false)
|
||||||
const [error, setError] = useState('')
|
const [error, setError] = useState('')
|
||||||
@@ -100,6 +100,12 @@ export default function TripFormModal({ isOpen, onClose, onSave, trip, onCoverUp
|
|||||||
if (formData.start_date && formData.end_date && new Date(formData.end_date) < new Date(formData.start_date)) {
|
if (formData.start_date && formData.end_date && new Date(formData.end_date) < new Date(formData.start_date)) {
|
||||||
setError(t('dashboard.endDateError')); return
|
setError(t('dashboard.endDateError')); return
|
||||||
}
|
}
|
||||||
|
if (!formData.start_date && !formData.end_date) {
|
||||||
|
const dc = Number(formData.day_count)
|
||||||
|
if (formData.day_count === '' || !Number.isInteger(dc) || dc < 1 || dc > 365) {
|
||||||
|
setError(t('dashboard.dayCountRequired')); return
|
||||||
|
}
|
||||||
|
}
|
||||||
setIsLoading(true)
|
setIsLoading(true)
|
||||||
try {
|
try {
|
||||||
const result = await onSave({
|
const result = await onSave({
|
||||||
@@ -108,7 +114,7 @@ export default function TripFormModal({ isOpen, onClose, onSave, trip, onCoverUp
|
|||||||
start_date: formData.start_date || null,
|
start_date: formData.start_date || null,
|
||||||
end_date: formData.end_date || null,
|
end_date: formData.end_date || null,
|
||||||
reminder_days: formData.reminder_days,
|
reminder_days: formData.reminder_days,
|
||||||
...(!formData.start_date && !formData.end_date ? { day_count: formData.day_count } : {}),
|
...(!formData.start_date && !formData.end_date ? { day_count: Number(formData.day_count) } : {}),
|
||||||
})
|
})
|
||||||
const createdTrip = result ? result.trip : undefined
|
const createdTrip = result ? result.trip : undefined
|
||||||
// Add selected members for newly created trips
|
// Add selected members for newly created trips
|
||||||
@@ -320,7 +326,12 @@ export default function TripFormModal({ isOpen, onClose, onSave, trip, onCoverUp
|
|||||||
{t('dashboard.dayCount')}
|
{t('dashboard.dayCount')}
|
||||||
</label>
|
</label>
|
||||||
<input type="number" min={1} max={365} value={formData.day_count}
|
<input type="number" min={1} max={365} value={formData.day_count}
|
||||||
onChange={e => update('day_count', Math.max(1, Math.min(365, Number(e.target.value) || 1)))}
|
onChange={e => {
|
||||||
|
const raw = e.target.value
|
||||||
|
if (raw === '') { update('day_count', ''); return }
|
||||||
|
const n = Math.floor(Number(raw))
|
||||||
|
if (Number.isFinite(n)) update('day_count', Math.min(365, Math.max(1, n)))
|
||||||
|
}}
|
||||||
className={inputCls} />
|
className={inputCls} />
|
||||||
<p className="text-xs text-slate-400 mt-1.5">{t('dashboard.dayCountHint')}</p>
|
<p className="text-xs text-slate-400 mt-1.5">{t('dashboard.dayCountHint')}</p>
|
||||||
</div>
|
</div>
|
||||||
|
|||||||
@@ -69,7 +69,7 @@ export default function VacayCalendar() {
|
|||||||
|
|
||||||
return (
|
return (
|
||||||
<div>
|
<div>
|
||||||
<div className="grid grid-cols-1 sm:grid-cols-2 lg:grid-cols-3 xl:grid-cols-4 gap-3 pb-14">
|
<div className="grid grid-cols-1 sm:grid-cols-2 lg:grid-cols-3 xl:grid-cols-4 gap-3" style={{ paddingBottom: 'calc(var(--bottom-nav-h, 0px) + 80px)' }}>
|
||||||
{Array.from({ length: 12 }, (_, i) => (
|
{Array.from({ length: 12 }, (_, i) => (
|
||||||
<VacayMonthCard
|
<VacayMonthCard
|
||||||
key={i}
|
key={i}
|
||||||
@@ -89,8 +89,8 @@ export default function VacayCalendar() {
|
|||||||
))}
|
))}
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
{/* Floating toolbar */}
|
{/* Floating toolbar — lift above the mobile bottom nav (z-60). On desktop --bottom-nav-h is 0px. */}
|
||||||
<div className="sticky bottom-3 sm:bottom-4 mt-3 sm:mt-4 flex items-center justify-center z-30 px-2">
|
<div className="sticky mt-3 sm:mt-4 flex items-center justify-center px-2" style={{ bottom: 'calc(var(--bottom-nav-h, 0px) + 12px)', zIndex: 61 }}>
|
||||||
<div className="flex items-center gap-1.5 sm:gap-2 px-2 sm:px-3 py-1.5 sm:py-2 rounded-xl border bg-surface-card border-edge" style={{ boxShadow: '0 8px 32px rgba(0,0,0,0.12)' }}>
|
<div className="flex items-center gap-1.5 sm:gap-2 px-2 sm:px-3 py-1.5 sm:py-2 rounded-xl border bg-surface-card border-edge" style={{ boxShadow: '0 8px 32px rgba(0,0,0,0.12)' }}>
|
||||||
<button
|
<button
|
||||||
onClick={() => setCompanyMode(false)}
|
onClick={() => setCompanyMode(false)}
|
||||||
|
|||||||
@@ -102,7 +102,9 @@ export function ToastContainer() {
|
|||||||
`}</style>
|
`}</style>
|
||||||
<div style={{
|
<div style={{
|
||||||
position: 'fixed', bottom: 24, left: '50%', transform: 'translateX(-50%)',
|
position: 'fixed', bottom: 24, left: '50%', transform: 'translateX(-50%)',
|
||||||
zIndex: 9999, display: 'flex', flexDirection: 'column-reverse', gap: 8,
|
// Above modal overlays (which sit around z-index 10000 with a backdrop-filter
|
||||||
|
// blur) so error toasts paint on top and stay legible instead of blurred behind.
|
||||||
|
zIndex: 100000, display: 'flex', flexDirection: 'column-reverse', gap: 8,
|
||||||
pointerEvents: 'none', maxWidth: 420, width: '100%', padding: '0 16px',
|
pointerEvents: 'none', maxWidth: 420, width: '100%', padding: '0 16px',
|
||||||
}}>
|
}}>
|
||||||
{toasts.map(toast => (
|
{toasts.map(toast => (
|
||||||
|
|||||||
+137
-3
@@ -27,6 +27,12 @@ export interface QueuedMutation {
|
|||||||
tempId?: number;
|
tempId?: number;
|
||||||
/** For DELETE mutations: the entity id to remove from Dexie on flush */
|
/** For DELETE mutations: the entity id to remove from Dexie on flush */
|
||||||
entityId?: number;
|
entityId?: number;
|
||||||
|
/**
|
||||||
|
* For PUT/DELETE enqueued offline against a still-unsynced (negative-id) entity:
|
||||||
|
* the temp id of the target. The url carries an `{id}` placeholder that the
|
||||||
|
* mutation queue rewrites to the real server id once the dependent CREATE flushes.
|
||||||
|
*/
|
||||||
|
tempEntityId?: number;
|
||||||
}
|
}
|
||||||
|
|
||||||
export interface SyncMeta {
|
export interface SyncMeta {
|
||||||
@@ -41,13 +47,48 @@ export interface SyncMeta {
|
|||||||
export interface BlobCacheEntry {
|
export interface BlobCacheEntry {
|
||||||
/** Relative URL, e.g. "/api/files/42/download" */
|
/** Relative URL, e.g. "/api/files/42/download" */
|
||||||
url: string;
|
url: string;
|
||||||
|
/**
|
||||||
|
* Trip this blob belongs to, so it is evicted together with the trip in
|
||||||
|
* clearTripData. Legacy rows cached before v3 carry the sentinel -1.
|
||||||
|
*/
|
||||||
|
tripId: number;
|
||||||
blob: Blob;
|
blob: Blob;
|
||||||
|
/** Byte size captured at insert time — Blob.size is not reliably preserved
|
||||||
|
* across IndexedDB round-trips, so the LRU budget reads this instead. */
|
||||||
|
bytes: number;
|
||||||
mime: string;
|
mime: string;
|
||||||
cachedAt: number;
|
cachedAt: number;
|
||||||
}
|
}
|
||||||
|
|
||||||
// ── Dexie class ────────────────────────────────────────────────────────────────
|
// ── Dexie class ────────────────────────────────────────────────────────────────
|
||||||
|
|
||||||
|
/**
|
||||||
|
* The offline DB is scoped per user so that one account can never read another
|
||||||
|
* account's cached data on a shared device. Anonymous (logged-out) state uses
|
||||||
|
* the base name; a logged-in user uses `trek-offline-u<userId>`.
|
||||||
|
*/
|
||||||
|
const ANON_DB_NAME = 'trek-offline';
|
||||||
|
|
||||||
|
function userDbName(userId: number | string): string {
|
||||||
|
return `trek-offline-u${userId}`;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Best-effort read of the persisted auth snapshot so the very first DB opened on
|
||||||
|
* app load (before loadUser resolves) is already the correct per-user one — the
|
||||||
|
* PWA can render cached data offline without leaking across users.
|
||||||
|
*/
|
||||||
|
function initialDbName(): string {
|
||||||
|
try {
|
||||||
|
const raw = typeof localStorage !== 'undefined' ? localStorage.getItem('trek_auth_snapshot') : null;
|
||||||
|
if (!raw) return ANON_DB_NAME;
|
||||||
|
const id = JSON.parse(raw)?.state?.user?.id;
|
||||||
|
return id != null ? userDbName(id) : ANON_DB_NAME;
|
||||||
|
} catch {
|
||||||
|
return ANON_DB_NAME;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
class TrekOfflineDb extends Dexie {
|
class TrekOfflineDb extends Dexie {
|
||||||
trips!: Table<Trip, number>;
|
trips!: Table<Trip, number>;
|
||||||
days!: Table<Day, number>;
|
days!: Table<Day, number>;
|
||||||
@@ -65,8 +106,8 @@ class TrekOfflineDb extends Dexie {
|
|||||||
syncMeta!: Table<SyncMeta, number>;
|
syncMeta!: Table<SyncMeta, number>;
|
||||||
blobCache!: Table<BlobCacheEntry, string>;
|
blobCache!: Table<BlobCacheEntry, string>;
|
||||||
|
|
||||||
constructor() {
|
constructor(name: string = ANON_DB_NAME) {
|
||||||
super('trek-offline');
|
super(name);
|
||||||
|
|
||||||
this.version(1).stores({
|
this.version(1).stores({
|
||||||
trips: 'id',
|
trips: 'id',
|
||||||
@@ -88,10 +129,67 @@ class TrekOfflineDb extends Dexie {
|
|||||||
tags: 'id',
|
tags: 'id',
|
||||||
categories: 'id',
|
categories: 'id',
|
||||||
});
|
});
|
||||||
|
|
||||||
|
// v3: scope the blob cache by trip so it can be evicted with the trip and
|
||||||
|
// bounded by an LRU budget (see enforceBlobBudget).
|
||||||
|
this.version(3).stores({
|
||||||
|
blobCache: 'url, cachedAt, tripId',
|
||||||
|
}).upgrade(async (tx) => {
|
||||||
|
await tx.table('blobCache').toCollection().modify((row: Partial<BlobCacheEntry>) => {
|
||||||
|
if (row.tripId == null) row.tripId = -1;
|
||||||
|
if (row.bytes == null) row.bytes = row.blob?.size ?? 0;
|
||||||
|
});
|
||||||
|
});
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
export const offlineDb = new TrekOfflineDb();
|
// The live instance is swapped on login/logout via reopenForUser/reopenAnonymous.
|
||||||
|
// A Proxy keeps the exported `offlineDb` binding stable for the ~19 modules that
|
||||||
|
// import it directly, while every access forwards to the current connection.
|
||||||
|
let _db = new TrekOfflineDb(initialDbName());
|
||||||
|
|
||||||
|
export const offlineDb = new Proxy({} as TrekOfflineDb, {
|
||||||
|
get(_target, prop) {
|
||||||
|
const value = (_db as unknown as Record<string | symbol, unknown>)[prop];
|
||||||
|
return typeof value === 'function' ? (value as (...args: unknown[]) => unknown).bind(_db) : value;
|
||||||
|
},
|
||||||
|
set(_target, prop, value) {
|
||||||
|
(_db as unknown as Record<string | symbol, unknown>)[prop] = value;
|
||||||
|
return true;
|
||||||
|
},
|
||||||
|
}) as TrekOfflineDb;
|
||||||
|
|
||||||
|
async function switchTo(name: string): Promise<void> {
|
||||||
|
if (_db.name === name) {
|
||||||
|
if (!_db.isOpen()) await _db.open();
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
if (_db.isOpen()) _db.close();
|
||||||
|
_db = new TrekOfflineDb(name);
|
||||||
|
await _db.open();
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Point the offline DB at a specific user's scoped database (call on login). */
|
||||||
|
export async function reopenForUser(userId: number | string): Promise<void> {
|
||||||
|
await switchTo(userDbName(userId));
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Point the offline DB at the anonymous database (call on logout). */
|
||||||
|
export async function reopenAnonymous(): Promise<void> {
|
||||||
|
await switchTo(ANON_DB_NAME);
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Delete the current user's scoped database entirely and return to the anonymous
|
||||||
|
* DB. Used on logout so no trace of the account's data remains on the device.
|
||||||
|
*/
|
||||||
|
export async function deleteCurrentUserDb(): Promise<void> {
|
||||||
|
if (_db.name !== ANON_DB_NAME) {
|
||||||
|
try { await _db.delete(); } catch { /* ignore — fall through to anon */ }
|
||||||
|
}
|
||||||
|
_db = new TrekOfflineDb(ANON_DB_NAME);
|
||||||
|
await _db.open();
|
||||||
|
}
|
||||||
|
|
||||||
// ── Bulk upsert helpers ────────────────────────────────────────────────────────
|
// ── Bulk upsert helpers ────────────────────────────────────────────────────────
|
||||||
|
|
||||||
@@ -166,6 +264,40 @@ export async function getCachedBlob(url: string): Promise<Blob | null> {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// ── Blob-cache budget ───────────────────────────────────────────────────────
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Upper bounds for the offline file-blob cache. Kept conservative so trip
|
||||||
|
* documents never starve the map-tile cache (sized at MAX_TILES in
|
||||||
|
* tilePrefetcher.ts) for the origin's storage quota.
|
||||||
|
*/
|
||||||
|
export const BLOB_CACHE_MAX_ENTRIES = 200;
|
||||||
|
export const BLOB_CACHE_MAX_BYTES = 100 * 1024 * 1024; // 100 MB
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Evict oldest-by-cachedAt blobs until the cache is under both the entry-count
|
||||||
|
* and byte budget. Call after inserting new blobs. LRU on insertion time, which
|
||||||
|
* is a reasonable proxy for access for write-once document blobs.
|
||||||
|
*/
|
||||||
|
export async function enforceBlobBudget(
|
||||||
|
maxCount = BLOB_CACHE_MAX_ENTRIES,
|
||||||
|
maxBytes = BLOB_CACHE_MAX_BYTES,
|
||||||
|
): Promise<void> {
|
||||||
|
const entries = await offlineDb.blobCache.orderBy('cachedAt').toArray();
|
||||||
|
let count = entries.length;
|
||||||
|
let totalBytes = entries.reduce((sum, e) => sum + (e.bytes ?? 0), 0);
|
||||||
|
if (count <= maxCount && totalBytes <= maxBytes) return;
|
||||||
|
|
||||||
|
const toDelete: string[] = [];
|
||||||
|
for (const e of entries) {
|
||||||
|
if (count <= maxCount && totalBytes <= maxBytes) break;
|
||||||
|
toDelete.push(e.url);
|
||||||
|
totalBytes -= e.bytes ?? 0;
|
||||||
|
count -= 1;
|
||||||
|
}
|
||||||
|
if (toDelete.length) await offlineDb.blobCache.bulkDelete(toDelete);
|
||||||
|
}
|
||||||
|
|
||||||
// ── Eviction / cleanup ────────────────────────────────────────────────────────
|
// ── Eviction / cleanup ────────────────────────────────────────────────────────
|
||||||
|
|
||||||
/** Delete all cached data for one trip (eviction or explicit clear). */
|
/** Delete all cached data for one trip (eviction or explicit clear). */
|
||||||
@@ -184,6 +316,7 @@ export async function clearTripData(tripId: number): Promise<void> {
|
|||||||
offlineDb.tripMembers,
|
offlineDb.tripMembers,
|
||||||
offlineDb.mutationQueue,
|
offlineDb.mutationQueue,
|
||||||
offlineDb.syncMeta,
|
offlineDb.syncMeta,
|
||||||
|
offlineDb.blobCache,
|
||||||
],
|
],
|
||||||
async () => {
|
async () => {
|
||||||
await offlineDb.days.where('trip_id').equals(tripId).delete();
|
await offlineDb.days.where('trip_id').equals(tripId).delete();
|
||||||
@@ -197,6 +330,7 @@ export async function clearTripData(tripId: number): Promise<void> {
|
|||||||
await offlineDb.tripMembers.where('tripId').equals(tripId).delete();
|
await offlineDb.tripMembers.where('tripId').equals(tripId).delete();
|
||||||
await offlineDb.mutationQueue.where('tripId').equals(tripId).delete();
|
await offlineDb.mutationQueue.where('tripId').equals(tripId).delete();
|
||||||
await offlineDb.syncMeta.where('tripId').equals(tripId).delete();
|
await offlineDb.syncMeta.where('tripId').equals(tripId).delete();
|
||||||
|
await offlineDb.blobCache.where('tripId').equals(tripId).delete();
|
||||||
},
|
},
|
||||||
);
|
);
|
||||||
// Remove the trip row itself outside the transaction since it's a separate table
|
// Remove the trip row itself outside the transaction since it's a separate table
|
||||||
|
|||||||
@@ -2,7 +2,7 @@ import { useCallback, useEffect, useState } from 'react'
|
|||||||
|
|
||||||
/**
|
/**
|
||||||
* Live FX rates for the Costs panel, used to convert every amount into the user's
|
* Live FX rates for the Costs panel, used to convert every amount into the user's
|
||||||
* display currency. Fetches exchangerate-api.com (no key, already CSP-allowlisted
|
* display currency. Fetches api.frankfurter.dev (no key, already CSP-allowlisted
|
||||||
* for the dashboard widget) for the given base and caches per base in memory +
|
* for the dashboard widget) for the given base and caches per base in memory +
|
||||||
* localStorage for a few hours. rates[X] = units of X per 1 base, so an amount in
|
* localStorage for a few hours. rates[X] = units of X per 1 base, so an amount in
|
||||||
* currency C converts to base as `amount / rates[C]`.
|
* currency C converts to base as `amount / rates[C]`.
|
||||||
@@ -33,14 +33,19 @@ export function useExchangeRates(base: string) {
|
|||||||
if (cached) setRates(cached.rates)
|
if (cached) setRates(cached.rates)
|
||||||
if (cached && Date.now() - cached.ts < TTL_MS) return
|
if (cached && Date.now() - cached.ts < TTL_MS) return
|
||||||
let cancelled = false
|
let cancelled = false
|
||||||
fetch(`https://api.exchangerate-api.com/v4/latest/${encodeURIComponent(upper)}`)
|
fetch(`https://api.frankfurter.dev/v2/rates?base=${encodeURIComponent(upper)}`)
|
||||||
.then(r => r.json())
|
.then(r => r.json())
|
||||||
.then((d: { rates?: Record<string, number> }) => {
|
.then((d: Array<{ quote?: string; rate?: number }>) => {
|
||||||
if (cancelled || !d?.rates) return
|
if (cancelled || !Array.isArray(d)) return
|
||||||
const entry = { rates: d.rates, ts: Date.now() }
|
// Frankfurter omits the base's own self-rate, so seed it with `base = 1`.
|
||||||
|
const rates: Record<string, number> = { [upper]: 1 }
|
||||||
|
for (const r of d) {
|
||||||
|
if (r && typeof r.quote === 'string' && typeof r.rate === 'number') rates[r.quote] = r.rate
|
||||||
|
}
|
||||||
|
const entry = { rates, ts: Date.now() }
|
||||||
mem.set(upper, entry)
|
mem.set(upper, entry)
|
||||||
try { localStorage.setItem('trek_fx_' + upper, JSON.stringify(entry)) } catch { /* ignore */ }
|
try { localStorage.setItem('trek_fx_' + upper, JSON.stringify(entry)) } catch { /* ignore */ }
|
||||||
setRates(d.rates)
|
setRates(rates)
|
||||||
})
|
})
|
||||||
.catch(() => { /* offline → keep cached/identity */ })
|
.catch(() => { /* offline → keep cached/identity */ })
|
||||||
return () => { cancelled = true }
|
return () => { cancelled = true }
|
||||||
|
|||||||
@@ -1,22 +1,33 @@
|
|||||||
import { useState, useCallback, useRef, useEffect, useMemo } from 'react'
|
import { useState, useCallback, useRef, useEffect, useMemo } from 'react'
|
||||||
import { useTripStore } from '../store/tripStore'
|
import { useTripStore } from '../store/tripStore'
|
||||||
import { calculateRouteWithLegs } from '../components/Map/RouteCalculator'
|
import { useSettingsStore } from '../store/settingsStore'
|
||||||
|
import { calculateRouteWithLegs, withHotelBookends } from '../components/Map/RouteCalculator'
|
||||||
|
import { getTransportRouteEndpoints } from '../utils/dayMerge'
|
||||||
|
import { getDayBookendHotels } from '../utils/dayOrder'
|
||||||
import type { TripStoreState } from '../store/tripStore'
|
import type { TripStoreState } from '../store/tripStore'
|
||||||
import type { RouteSegment, RouteResult } from '../types'
|
import type { RouteSegment, RouteResult, Accommodation } from '../types'
|
||||||
|
|
||||||
const TRANSPORT_TYPES = ['flight', 'train', 'bus', 'car', 'taxi', 'bicycle', 'cruise', 'ferry', 'transport_other']
|
const TRANSPORT_TYPES = ['flight', 'train', 'bus', 'car', 'taxi', 'bicycle', 'cruise', 'ferry', 'transport_other']
|
||||||
|
|
||||||
|
const NO_ACCOMMODATIONS: Accommodation[] = []
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Manages route calculation state for a selected day. Extracts geo-coded waypoints from
|
* Manages route calculation state for a selected day. Extracts geo-coded waypoints from
|
||||||
* day assignments, draws a straight-line route immediately, then upgrades it to real OSRM
|
* day assignments, draws a straight-line route immediately, then upgrades it to real OSRM
|
||||||
* road geometry with per-segment durations. Aborts in-flight requests when the day changes.
|
* road geometry with per-segment durations. Aborts in-flight requests when the day changes.
|
||||||
*/
|
*/
|
||||||
export function useRouteCalculation(tripStore: TripStoreState, selectedDayId: number | null, enabled: boolean = true, profile: 'driving' | 'walking' | 'cycling' = 'driving') {
|
export function useRouteCalculation(tripStore: TripStoreState, selectedDayId: number | null, enabled: boolean = true, profile: 'driving' | 'walking' | 'cycling' = 'driving', accommodations: Accommodation[] = NO_ACCOMMODATIONS) {
|
||||||
const [route, setRoute] = useState<[number, number][][] | null>(null)
|
const [route, setRoute] = useState<[number, number][][] | null>(null)
|
||||||
const [routeInfo, setRouteInfo] = useState<RouteResult | null>(null)
|
const [routeInfo, setRouteInfo] = useState<RouteResult | null>(null)
|
||||||
const [routeSegments, setRouteSegments] = useState<RouteSegment[]>([])
|
const [routeSegments, setRouteSegments] = useState<RouteSegment[]>([])
|
||||||
const routeAbortRef = useRef<AbortController | null>(null)
|
const routeAbortRef = useRef<AbortController | null>(null)
|
||||||
const reservationsForSignature = useTripStore((s) => s.reservations)
|
const reservationsForSignature = useTripStore((s) => s.reservations)
|
||||||
|
// Draw the day's accommodation bookend legs (hotel → first stop, last stop →
|
||||||
|
// hotel) unless the user turned the setting off — same gate as the sidebar.
|
||||||
|
const optimizeFromAccommodation = useSettingsStore((s) => s.settings.optimize_from_accommodation)
|
||||||
|
// Recompute when the user flips km↔mi so leg distances (formatted at compute time)
|
||||||
|
// refresh instead of showing stale cached text (#1300).
|
||||||
|
const distanceUnit = useSettingsStore((s) => s.settings.distance_unit)
|
||||||
|
|
||||||
const updateRouteForDay = useCallback(async (dayId: number | null) => {
|
const updateRouteForDay = useCallback(async (dayId: number | null) => {
|
||||||
if (routeAbortRef.current) routeAbortRef.current.abort()
|
if (routeAbortRef.current) routeAbortRef.current.abort()
|
||||||
@@ -53,12 +64,6 @@ export function useRouteCalculation(tripStore: TripStoreState, selectedDayId: nu
|
|||||||
return pos != null
|
return pos != null
|
||||||
})
|
})
|
||||||
|
|
||||||
// The departure/arrival coordinate of a transport, if its endpoints carry one.
|
|
||||||
const epLoc = (r: any, role: 'from' | 'to'): { lat: number; lng: number } | null => {
|
|
||||||
const e = (r.endpoints || []).find((x: any) => x.role === role)
|
|
||||||
return e && e.lat != null && e.lng != null ? { lat: e.lat, lng: e.lng } : null
|
|
||||||
}
|
|
||||||
|
|
||||||
// Build a unified list of places + transports sorted by effective position.
|
// Build a unified list of places + transports sorted by effective position.
|
||||||
type Entry =
|
type Entry =
|
||||||
| { kind: 'place'; lat: number; lng: number; pos: number }
|
| { kind: 'place'; lat: number; lng: number; pos: number }
|
||||||
@@ -67,12 +72,15 @@ export function useRouteCalculation(tripStore: TripStoreState, selectedDayId: nu
|
|||||||
...da.filter(a => a.place?.lat && a.place?.lng).map(a => ({
|
...da.filter(a => a.place?.lat && a.place?.lng).map(a => ({
|
||||||
kind: 'place' as const, lat: a.place.lat!, lng: a.place.lng!, pos: a.order_index,
|
kind: 'place' as const, lat: a.place.lat!, lng: a.place.lng!, pos: a.order_index,
|
||||||
})),
|
})),
|
||||||
...dayTransports.map(r => ({
|
...dayTransports.map(r => {
|
||||||
kind: 'transport' as const,
|
const { from, to } = getTransportRouteEndpoints(r, dayId)
|
||||||
from: epLoc(r, 'from'),
|
return {
|
||||||
to: epLoc(r, 'to'),
|
kind: 'transport' as const,
|
||||||
pos: (r.day_positions?.[dayId] ?? r.day_positions?.[String(dayId)] ?? r.day_plan_position) as number,
|
from,
|
||||||
})),
|
to,
|
||||||
|
pos: (r.day_positions?.[dayId] ?? r.day_positions?.[String(dayId)] ?? r.day_plan_position) as number,
|
||||||
|
}
|
||||||
|
}),
|
||||||
].sort((a, b) => a.pos - b.pos)
|
].sort((a, b) => a.pos - b.pos)
|
||||||
|
|
||||||
// Group located places into driving runs.
|
// Group located places into driving runs.
|
||||||
@@ -95,10 +103,55 @@ export function useRouteCalculation(tripStore: TripStoreState, selectedDayId: nu
|
|||||||
}
|
}
|
||||||
if (currentRun.length >= 2) runs.push(currentRun)
|
if (currentRun.length >= 2) runs.push(currentRun)
|
||||||
|
|
||||||
const straightLines = (): [number, number][][] =>
|
// Bookend the route with the day's accommodation: a hotel → first-stop run and
|
||||||
runs.map(r => r.map(p => [p.lat, p.lng] as [number, number]))
|
// a last-stop → hotel run, so the drawn line matches the sidebar's hotel legs.
|
||||||
|
// getDayBookendHotels returns the morning/evening hotel (they differ only on a
|
||||||
|
// transfer day) and already filters to accommodations that have coordinates.
|
||||||
|
const day = allDays.find(d => d.id === dayId)
|
||||||
|
const bookends = day && optimizeFromAccommodation !== false
|
||||||
|
? getDayBookendHotels(day, allDays, accommodations)
|
||||||
|
: null
|
||||||
|
const flatPts: { lat: number; lng: number }[] = []
|
||||||
|
for (const e of entries) {
|
||||||
|
if (e.kind === 'place') flatPts.push({ lat: e.lat, lng: e.lng })
|
||||||
|
else { if (e.from) flatPts.push(e.from); if (e.to) flatPts.push(e.to) }
|
||||||
|
}
|
||||||
|
const hotelPt = (a?: Accommodation) =>
|
||||||
|
a && a.place_lat != null && a.place_lng != null ? { lat: a.place_lat, lng: a.place_lng } : null
|
||||||
|
// Only draw a hotel bookend when the leg is real. A hotel → first-stop leg holds
|
||||||
|
// if the first stop is a place, or if you actually slept in that hotel last night;
|
||||||
|
// on a day-1 arrival the morning hotel is just a check-in fallback and the first
|
||||||
|
// waypoint is the transport's departure point, so [hotel → departure] is dropped
|
||||||
|
// (#1321). Symmetrically, [last-stop → hotel] is dropped when you leave on a transport
|
||||||
|
// in the evening and don't sleep in that hotel tonight.
|
||||||
|
const contributes = (e: Entry) => e.kind === 'place' || !!e.from || !!e.to
|
||||||
|
const firstStop = entries.find(contributes)
|
||||||
|
const lastStop = [...entries].reverse().find(contributes)
|
||||||
|
const drawMorning = firstStop?.kind === 'place' || !!bookends?.morningIsSleptHere
|
||||||
|
const drawEvening = lastStop?.kind === 'place' || !!bookends?.eveningIsOvernight
|
||||||
|
const runsWithHotel = withHotelBookends(
|
||||||
|
runs,
|
||||||
|
flatPts[0],
|
||||||
|
flatPts[flatPts.length - 1],
|
||||||
|
drawMorning ? hotelPt(bookends?.morning) : null,
|
||||||
|
drawEvening ? hotelPt(bookends?.evening) : null,
|
||||||
|
)
|
||||||
|
|
||||||
if (runs.length === 0) { setRoute(null); setRouteSegments([]); return }
|
// Transfer day with no activities: you check out of one accommodation and into
|
||||||
|
// another, so there are no waypoints for withHotelBookends to attach a leg to.
|
||||||
|
// Draw the hotel → hotel transfer directly. Gated on both bookends being real
|
||||||
|
// (drawMorning/drawEvening already exclude the #1321 arrival fallback) and the two
|
||||||
|
// hotels being distinct, so an ordinary same-hotel rest day still draws nothing.
|
||||||
|
if (runsWithHotel.length === 0 && drawMorning && drawEvening) {
|
||||||
|
const m = hotelPt(bookends?.morning)
|
||||||
|
const e = hotelPt(bookends?.evening)
|
||||||
|
if (m && e && (m.lat !== e.lat || m.lng !== e.lng)) runsWithHotel.push([m, e])
|
||||||
|
}
|
||||||
|
|
||||||
|
const straightLines = (): [number, number][][] =>
|
||||||
|
runsWithHotel.map(r => r.map(p => [p.lat, p.lng] as [number, number]))
|
||||||
|
|
||||||
|
if (runsWithHotel.length === 0) { setRoute(null); setRouteSegments([]); return }
|
||||||
|
|
||||||
// Draw straight lines immediately for snappiness, then upgrade to the real
|
// Draw straight lines immediately for snappiness, then upgrade to the real
|
||||||
// OSRM road geometry.
|
// OSRM road geometry.
|
||||||
@@ -109,7 +162,7 @@ export function useRouteCalculation(tripStore: TripStoreState, selectedDayId: nu
|
|||||||
try {
|
try {
|
||||||
const polylines: [number, number][][] = []
|
const polylines: [number, number][][] = []
|
||||||
const allLegs: RouteSegment[] = []
|
const allLegs: RouteSegment[] = []
|
||||||
for (const run of runs) {
|
for (const run of runsWithHotel) {
|
||||||
try {
|
try {
|
||||||
const r = await calculateRouteWithLegs(run, { signal: controller.signal, profile })
|
const r = await calculateRouteWithLegs(run, { signal: controller.signal, profile })
|
||||||
polylines.push(r.coordinates.length >= 2 ? r.coordinates : run.map(p => [p.lat, p.lng] as [number, number]))
|
polylines.push(r.coordinates.length >= 2 ? r.coordinates : run.map(p => [p.lat, p.lng] as [number, number]))
|
||||||
@@ -125,7 +178,7 @@ export function useRouteCalculation(tripStore: TripStoreState, selectedDayId: nu
|
|||||||
// Aborted (day changed) — newer call owns the state. Anything else: keep straight lines.
|
// Aborted (day changed) — newer call owns the state. Anything else: keep straight lines.
|
||||||
if (!(err instanceof Error) || err.name !== 'AbortError') setRouteSegments([])
|
if (!(err instanceof Error) || err.name !== 'AbortError') setRouteSegments([])
|
||||||
}
|
}
|
||||||
}, [enabled, profile])
|
}, [enabled, profile, accommodations, optimizeFromAccommodation, distanceUnit])
|
||||||
|
|
||||||
// Stable signature for transport reservations on the selected day — changes when a transport
|
// Stable signature for transport reservations on the selected day — changes when a transport
|
||||||
// is added, removed, or repositioned, ensuring route recalc fires even on transport-only reorders.
|
// is added, removed, or repositioned, ensuring route recalc fires even on transport-only reorders.
|
||||||
@@ -149,7 +202,7 @@ export function useRouteCalculation(tripStore: TripStoreState, selectedDayId: nu
|
|||||||
if (!selectedDayId) { setRoute(null); setRouteSegments([]); return }
|
if (!selectedDayId) { setRoute(null); setRouteSegments([]); return }
|
||||||
updateRouteForDay(selectedDayId)
|
updateRouteForDay(selectedDayId)
|
||||||
// eslint-disable-next-line react-hooks/exhaustive-deps
|
// eslint-disable-next-line react-hooks/exhaustive-deps
|
||||||
}, [selectedDayId, selectedDayAssignments, transportSignature, enabled, profile])
|
}, [selectedDayId, selectedDayAssignments, transportSignature, enabled, profile, accommodations, optimizeFromAccommodation, distanceUnit])
|
||||||
|
|
||||||
return { route, routeSegments, routeInfo, setRoute, setRouteInfo, updateRouteForDay }
|
return { route, routeSegments, routeInfo, setRoute, setRouteInfo, updateRouteForDay }
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -37,6 +37,7 @@ const localeLoaders: Record<SupportedLanguageCode, () => Promise<{ default: Tran
|
|||||||
ko: () => import('@trek/shared/i18n/ko'),
|
ko: () => import('@trek/shared/i18n/ko'),
|
||||||
uk: () => import('@trek/shared/i18n/uk'),
|
uk: () => import('@trek/shared/i18n/uk'),
|
||||||
gr: () => import('@trek/shared/i18n/gr'),
|
gr: () => import('@trek/shared/i18n/gr'),
|
||||||
|
sv: () => import('@trek/shared/i18n/sv'),
|
||||||
}
|
}
|
||||||
|
|
||||||
// Re-export pure helpers that live in shared so downstream consumers can import them
|
// Re-export pure helpers that live in shared so downstream consumers can import them
|
||||||
|
|||||||
@@ -35,17 +35,19 @@ body { height: 100%; overflow: auto; overscroll-behavior: none; -webkit-overflow
|
|||||||
color: var(--text-primary) !important;
|
color: var(--text-primary) !important;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* Mapbox GL hover popup — the name/category/address card on marker hover.
|
/* GL hover popup — the name/category/address card on marker hover.
|
||||||
Matches the Leaflet map's white hover tooltip. pointer-events:none so moving
|
Matches the Leaflet map's white hover tooltip. pointer-events:none so moving
|
||||||
onto the popup never steals the marker's mouseleave and causes flicker. */
|
onto the popup never steals the marker's mouseleave and causes flicker. */
|
||||||
.trek-map-popup { pointer-events: none; }
|
.trek-map-popup { pointer-events: none; }
|
||||||
.trek-map-popup .mapboxgl-popup-content {
|
.trek-map-popup .mapboxgl-popup-content,
|
||||||
|
.trek-map-popup .maplibregl-popup-content {
|
||||||
padding: 7px 10px;
|
padding: 7px 10px;
|
||||||
border-radius: 10px;
|
border-radius: 10px;
|
||||||
background: #fff;
|
background: #fff;
|
||||||
box-shadow: 0 2px 12px rgba(0, 0, 0, 0.16);
|
box-shadow: 0 2px 12px rgba(0, 0, 0, 0.16);
|
||||||
}
|
}
|
||||||
.trek-map-popup .mapboxgl-popup-tip {
|
.trek-map-popup .mapboxgl-popup-tip,
|
||||||
|
.trek-map-popup .maplibregl-popup-tip {
|
||||||
border-top-color: #fff;
|
border-top-color: #fff;
|
||||||
border-bottom-color: #fff;
|
border-bottom-color: #fff;
|
||||||
border-left-color: #fff;
|
border-left-color: #fff;
|
||||||
|
|||||||
@@ -15,8 +15,11 @@ import '@fontsource/geist-sans/500.css'
|
|||||||
import '@fontsource/geist-sans/600.css'
|
import '@fontsource/geist-sans/600.css'
|
||||||
import './index.css'
|
import './index.css'
|
||||||
import { startConnectivityProbe } from './sync/connectivity'
|
import { startConnectivityProbe } from './sync/connectivity'
|
||||||
|
import { requestPersistentStorage } from './sync/persistentStorage'
|
||||||
|
|
||||||
startConnectivityProbe()
|
startConnectivityProbe()
|
||||||
|
// Keep offline data (map tiles, file blobs, IndexedDB) exempt from eviction.
|
||||||
|
requestPersistentStorage()
|
||||||
|
|
||||||
ReactDOM.createRoot(document.getElementById('root')!).render(
|
ReactDOM.createRoot(document.getElementById('root')!).render(
|
||||||
<React.StrictMode>
|
<React.StrictMode>
|
||||||
|
|||||||
@@ -6,6 +6,7 @@ import CustomSelect from '../components/shared/CustomSelect'
|
|||||||
import { Globe, MapPin, Briefcase, Calendar, Flag, PanelLeftOpen, PanelLeftClose, X, Star, Plus, Trash2, Search } from 'lucide-react'
|
import { Globe, MapPin, Briefcase, Calendar, Flag, PanelLeftOpen, PanelLeftClose, X, Star, Plus, Trash2, Search } from 'lucide-react'
|
||||||
import type { TranslationFn } from '../types'
|
import type { TranslationFn } from '../types'
|
||||||
import { A2_TO_A3, countryCodeToFlag, type AtlasCountry, type AtlasStats, type AtlasData, type CountryDetail } from './atlas/atlasModel'
|
import { A2_TO_A3, countryCodeToFlag, type AtlasCountry, type AtlasStats, type AtlasData, type CountryDetail } from './atlas/atlasModel'
|
||||||
|
import { continentForCountry } from '@trek/shared'
|
||||||
import { useAtlas } from './atlas/useAtlas'
|
import { useAtlas } from './atlas/useAtlas'
|
||||||
import AtlasCountrySearch from './atlas/AtlasCountrySearch'
|
import AtlasCountrySearch from './atlas/AtlasCountrySearch'
|
||||||
import { useToast } from '../components/shared/Toast'
|
import { useToast } from '../components/shared/Toast'
|
||||||
@@ -212,7 +213,8 @@ export default function AtlasPage(): React.ReactElement {
|
|||||||
await apiClient.post(`/addons/atlas/country/${confirmAction.code}/mark`)
|
await apiClient.post(`/addons/atlas/country/${confirmAction.code}/mark`)
|
||||||
setData(prev => {
|
setData(prev => {
|
||||||
if (!prev || prev.countries.find(c => c.code === confirmAction.code)) return prev
|
if (!prev || prev.countries.find(c => c.code === confirmAction.code)) return prev
|
||||||
return { ...prev, countries: [...prev.countries, { code: confirmAction.code, placeCount: 0, tripCount: 0, firstVisit: null, lastVisit: null }], stats: { ...prev.stats, totalCountries: prev.stats.totalCountries + 1 } }
|
const cont = continentForCountry(confirmAction.code)
|
||||||
|
return { ...prev, countries: [...prev.countries, { code: confirmAction.code, placeCount: 0, tripCount: 0, firstVisit: null, lastVisit: null }], stats: { ...prev.stats, totalCountries: prev.stats.totalCountries + 1 }, continents: { ...prev.continents, [cont]: (prev.continents?.[cont] || 0) + 1 } }
|
||||||
})
|
})
|
||||||
} catch (err) {
|
} catch (err) {
|
||||||
toast.error(getApiErrorMessage(err, t('common.error')))
|
toast.error(getApiErrorMessage(err, t('common.error')))
|
||||||
@@ -260,7 +262,8 @@ export default function AtlasPage(): React.ReactElement {
|
|||||||
})
|
})
|
||||||
setData(prev => {
|
setData(prev => {
|
||||||
if (!prev || prev.countries.find(c => c.code === countryCode)) return prev
|
if (!prev || prev.countries.find(c => c.code === countryCode)) return prev
|
||||||
return { ...prev, countries: [...prev.countries, { code: countryCode, placeCount: 0, tripCount: 0, firstVisit: null, lastVisit: null }], stats: { ...prev.stats, totalCountries: prev.stats.totalCountries + 1 } }
|
const cont = continentForCountry(countryCode)
|
||||||
|
return { ...prev, countries: [...prev.countries, { code: countryCode, placeCount: 0, tripCount: 0, firstVisit: null, lastVisit: null }], stats: { ...prev.stats, totalCountries: prev.stats.totalCountries + 1 }, continents: { ...prev.continents, [cont]: (prev.continents?.[cont] || 0) + 1 } }
|
||||||
})
|
})
|
||||||
} catch (err) {
|
} catch (err) {
|
||||||
toast.error(getApiErrorMessage(err, t('common.error')))
|
toast.error(getApiErrorMessage(err, t('common.error')))
|
||||||
@@ -339,10 +342,12 @@ export default function AtlasPage(): React.ReactElement {
|
|||||||
if (!c || c.placeCount > 0 || c.tripCount > 0) return prev
|
if (!c || c.placeCount > 0 || c.tripCount > 0) return prev
|
||||||
const remainingRegions = (visitedRegions[countryCode] || []).filter(r => r.code !== rCode && r.manuallyMarked)
|
const remainingRegions = (visitedRegions[countryCode] || []).filter(r => r.code !== rCode && r.manuallyMarked)
|
||||||
if (remainingRegions.length > 0) return prev
|
if (remainingRegions.length > 0) return prev
|
||||||
|
const cont = continentForCountry(countryCode)
|
||||||
return {
|
return {
|
||||||
...prev,
|
...prev,
|
||||||
countries: prev.countries.filter(c => c.code !== countryCode),
|
countries: prev.countries.filter(c => c.code !== countryCode),
|
||||||
stats: { ...prev.stats, totalCountries: Math.max(0, prev.stats.totalCountries - 1) },
|
stats: { ...prev.stats, totalCountries: Math.max(0, prev.stats.totalCountries - 1) },
|
||||||
|
continents: { ...prev.continents, [cont]: Math.max(0, (prev.continents?.[cont] || 0) - 1) },
|
||||||
}
|
}
|
||||||
})
|
})
|
||||||
} catch (err) {
|
} catch (err) {
|
||||||
|
|||||||
@@ -4,9 +4,10 @@ import userEvent from '@testing-library/user-event';
|
|||||||
import { http, HttpResponse } from 'msw';
|
import { http, HttpResponse } from 'msw';
|
||||||
import { server } from '../../tests/helpers/msw/server';
|
import { server } from '../../tests/helpers/msw/server';
|
||||||
import { resetAllStores, seedStore } from '../../tests/helpers/store';
|
import { resetAllStores, seedStore } from '../../tests/helpers/store';
|
||||||
import { buildUser, buildAdmin, buildTrip } from '../../tests/helpers/factories';
|
import { buildUser, buildAdmin, buildTrip, buildSettings } from '../../tests/helpers/factories';
|
||||||
import { useAuthStore } from '../store/authStore';
|
import { useAuthStore } from '../store/authStore';
|
||||||
import { usePermissionsStore } from '../store/permissionsStore';
|
import { usePermissionsStore } from '../store/permissionsStore';
|
||||||
|
import { useSettingsStore } from '../store/settingsStore';
|
||||||
import DashboardPage from './DashboardPage';
|
import DashboardPage from './DashboardPage';
|
||||||
|
|
||||||
beforeEach(() => {
|
beforeEach(() => {
|
||||||
@@ -20,8 +21,11 @@ beforeEach(() => {
|
|||||||
} as any);
|
} as any);
|
||||||
// Intercept CurrencyWidget's external fetch so it resolves before teardown
|
// Intercept CurrencyWidget's external fetch so it resolves before teardown
|
||||||
server.use(
|
server.use(
|
||||||
http.get('https://api.exchangerate-api.com/v4/latest/:currency', () => {
|
http.get('https://api.frankfurter.dev/v2/rates', () => {
|
||||||
return HttpResponse.json({ rates: { USD: 1.08, EUR: 1, CHF: 0.97 } });
|
return HttpResponse.json([
|
||||||
|
{ date: '2026-06-16', base: 'EUR', quote: 'USD', rate: 1.08 },
|
||||||
|
{ date: '2026-06-16', base: 'EUR', quote: 'CHF', rate: 0.97 },
|
||||||
|
]);
|
||||||
}),
|
}),
|
||||||
);
|
);
|
||||||
});
|
});
|
||||||
@@ -795,10 +799,51 @@ describe('DashboardPage', () => {
|
|||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('FE-PAGE-DASH-033: Atlas distance respects distance unit setting', () => {
|
||||||
|
const distanceValue = (text: string) =>
|
||||||
|
screen.getByText((_, element) =>
|
||||||
|
element?.classList.contains('value') === true &&
|
||||||
|
element.textContent?.replace(/\s+/g, ' ').trim() === text
|
||||||
|
);
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
server.use(
|
||||||
|
http.get('/api/auth/travel-stats', () =>
|
||||||
|
HttpResponse.json({
|
||||||
|
totalTrips: 1,
|
||||||
|
totalDays: 1,
|
||||||
|
totalPlaces: 1,
|
||||||
|
totalDistanceKm: 10,
|
||||||
|
countries: [],
|
||||||
|
})
|
||||||
|
),
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('renders metric atlas distance as kilometers', async () => {
|
||||||
|
seedStore(useSettingsStore, { settings: buildSettings({ distance_unit: 'metric' }) });
|
||||||
|
|
||||||
|
render(<DashboardPage />);
|
||||||
|
|
||||||
|
await waitFor(() => {
|
||||||
|
expect(distanceValue('10 km')).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it('renders imperial atlas distance as miles', async () => {
|
||||||
|
seedStore(useSettingsStore, { settings: buildSettings({ distance_unit: 'imperial' }) });
|
||||||
|
|
||||||
|
render(<DashboardPage />);
|
||||||
|
|
||||||
|
await waitFor(() => {
|
||||||
|
expect(distanceValue('6.2 mi')).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
describe('FE-PAGE-DASH-032: Dark mode detection uses window.matchMedia', () => {
|
describe('FE-PAGE-DASH-032: Dark mode detection uses window.matchMedia', () => {
|
||||||
it('renders without error when dark_mode is set to auto', async () => {
|
it('renders without error when dark_mode is set to auto', async () => {
|
||||||
// Seed settings with dark_mode = 'auto' to exercise the matchMedia branch
|
// Seed settings with dark_mode = 'auto' to exercise the matchMedia branch
|
||||||
const { useSettingsStore } = await import('../store/settingsStore');
|
|
||||||
seedStore(useSettingsStore, {
|
seedStore(useSettingsStore, {
|
||||||
settings: {
|
settings: {
|
||||||
map_tile_url: '',
|
map_tile_url: '',
|
||||||
@@ -809,6 +854,7 @@ describe('DashboardPage', () => {
|
|||||||
default_currency: 'USD',
|
default_currency: 'USD',
|
||||||
language: 'en',
|
language: 'en',
|
||||||
temperature_unit: 'fahrenheit',
|
temperature_unit: 'fahrenheit',
|
||||||
|
distance_unit: 'metric',
|
||||||
time_format: '12h',
|
time_format: '12h',
|
||||||
show_place_description: false,
|
show_place_description: false,
|
||||||
blur_booking_codes: false,
|
blur_booking_codes: false,
|
||||||
@@ -828,4 +874,32 @@ describe('DashboardPage', () => {
|
|||||||
expect(screen.getByText(/my trips/i)).toBeInTheDocument();
|
expect(screen.getByText(/my trips/i)).toBeInTheDocument();
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('FE-PAGE-DASH-034: dashboard widgets persist to settings, not localStorage (#1311)', () => {
|
||||||
|
it('reads the timezone widget zones from the settings store', async () => {
|
||||||
|
// A zone that is NOT in the hardcoded default ([home, London, Tokyo]) — its presence
|
||||||
|
// proves the widget reads the stored preference rather than the old localStorage default.
|
||||||
|
seedStore(useSettingsStore, { settings: buildSettings({ dashboard_timezones: ['America/New_York'] }), isLoaded: true });
|
||||||
|
render(<DashboardPage />);
|
||||||
|
await waitFor(() => expect(screen.getByRole('button', { name: /add timezone/i })).toBeInTheDocument());
|
||||||
|
expect(screen.getByText('New York')).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('migrates the pre-3.1.3 localStorage prefs into settings and clears the legacy keys', async () => {
|
||||||
|
localStorage.setItem('trek_fx_from', 'CAD');
|
||||||
|
localStorage.setItem('trek_fx_to', 'CHF');
|
||||||
|
localStorage.setItem('trek_dashboard_tz', JSON.stringify(['America/New_York']));
|
||||||
|
seedStore(useSettingsStore, { settings: buildSettings(), isLoaded: true });
|
||||||
|
render(<DashboardPage />);
|
||||||
|
// The one-time migration runs on mount (settings already loaded) and removes the keys.
|
||||||
|
await waitFor(() => {
|
||||||
|
expect(localStorage.getItem('trek_fx_from')).toBeNull();
|
||||||
|
expect(localStorage.getItem('trek_dashboard_tz')).toBeNull();
|
||||||
|
});
|
||||||
|
const s = useSettingsStore.getState().settings;
|
||||||
|
expect(s.dashboard_fx_from).toBe('CAD');
|
||||||
|
expect(s.dashboard_fx_to).toBe('CHF');
|
||||||
|
expect(s.dashboard_timezones).toEqual(['America/New_York']);
|
||||||
|
});
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -18,6 +18,9 @@ import {
|
|||||||
Plane, Hotel, Utensils, Clock, RefreshCw, ArrowRightLeft, Calendar,
|
Plane, Hotel, Utensils, Clock, RefreshCw, ArrowRightLeft, Calendar,
|
||||||
LayoutGrid, List, Ticket, X,
|
LayoutGrid, List, Ticket, X,
|
||||||
} from 'lucide-react'
|
} from 'lucide-react'
|
||||||
|
import { formatTime, splitReservationDateTime } from '../utils/formatters'
|
||||||
|
import { convertDistance, getDistanceUnitLabel } from '../utils/units'
|
||||||
|
import { useSettingsStore } from '../store/settingsStore'
|
||||||
import '../styles/dashboard.css'
|
import '../styles/dashboard.css'
|
||||||
|
|
||||||
const GRADIENTS = [
|
const GRADIENTS = [
|
||||||
@@ -36,6 +39,7 @@ function tripGradient(id: number): string { return GRADIENTS[id % GRADIENTS.leng
|
|||||||
function splitDate(dateStr: string | null | undefined, locale: string): { d: string; m: string } | null {
|
function splitDate(dateStr: string | null | undefined, locale: string): { d: string; m: string } | null {
|
||||||
if (!dateStr) return null
|
if (!dateStr) return null
|
||||||
const date = new Date(dateStr + 'T00:00:00Z')
|
const date = new Date(dateStr + 'T00:00:00Z')
|
||||||
|
if (isNaN(date.getTime())) return null // malformed date — render a dash, never crash
|
||||||
return {
|
return {
|
||||||
d: date.toLocaleDateString(locale, { day: 'numeric', timeZone: 'UTC' }),
|
d: date.toLocaleDateString(locale, { day: 'numeric', timeZone: 'UTC' }),
|
||||||
m: date.toLocaleDateString(locale, { month: 'short', timeZone: 'UTC' }),
|
m: date.toLocaleDateString(locale, { month: 'short', timeZone: 'UTC' }),
|
||||||
@@ -81,6 +85,7 @@ export default function DashboardPage(): React.ReactElement {
|
|||||||
const {
|
const {
|
||||||
demoMode, locale, t, navigate,
|
demoMode, locale, t, navigate,
|
||||||
spotlight, heroBundle, stats, upcoming, gridTrips, isLoading,
|
spotlight, heroBundle, stats, upcoming, gridTrips, isLoading,
|
||||||
|
loadError, retryLoad,
|
||||||
tripFilter, setTripFilter, viewMode, toggleViewMode,
|
tripFilter, setTripFilter, viewMode, toggleViewMode,
|
||||||
showForm, setShowForm, editingTrip, setEditingTrip,
|
showForm, setShowForm, editingTrip, setEditingTrip,
|
||||||
deleteTrip, setDeleteTrip, copyTrip, setCopyTrip, setTrips,
|
deleteTrip, setDeleteTrip, copyTrip, setCopyTrip, setTrips,
|
||||||
@@ -99,6 +104,15 @@ export default function DashboardPage(): React.ReactElement {
|
|||||||
<MobileTopBar />
|
<MobileTopBar />
|
||||||
<main className="page">
|
<main className="page">
|
||||||
<div className="page-main">
|
<div className="page-main">
|
||||||
|
{loadError && (
|
||||||
|
<div className="dash-error" role="alert">
|
||||||
|
<span className="dash-error-txt">{t('dashboard.loadErrorBanner')}</span>
|
||||||
|
<button className="dash-error-retry" onClick={retryLoad}>
|
||||||
|
<RefreshCw size={15} />
|
||||||
|
{t('dashboard.retry')}
|
||||||
|
</button>
|
||||||
|
</div>
|
||||||
|
)}
|
||||||
{spotlight && (
|
{spotlight && (
|
||||||
<BoardingPassHero
|
<BoardingPassHero
|
||||||
trip={spotlight}
|
trip={spotlight}
|
||||||
@@ -129,6 +143,13 @@ export default function DashboardPage(): React.ReactElement {
|
|||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
|
{gridTrips.length === 0 && tripFilter === 'planned' && !isLoading && !loadError && (
|
||||||
|
<div className="trips-empty">
|
||||||
|
<h4>{t('dashboard.emptyTitle')}</h4>
|
||||||
|
<p>{t('dashboard.emptyText')}</p>
|
||||||
|
</div>
|
||||||
|
)}
|
||||||
|
|
||||||
<div className={`trips${viewMode === 'list' ? ' list-view' : ''}`}>
|
<div className={`trips${viewMode === 'list' ? ' list-view' : ''}`}>
|
||||||
{gridTrips.map(trip => (
|
{gridTrips.map(trip => (
|
||||||
<TripCard
|
<TripCard
|
||||||
@@ -338,12 +359,27 @@ function BoardingPassHero({ trip, bundle, locale, onOpen, onEdit, onCopy, onArch
|
|||||||
}
|
}
|
||||||
|
|
||||||
// ── Atlas / stats row ────────────────────────────────────────────────────────
|
// ── Atlas / stats row ────────────────────────────────────────────────────────
|
||||||
|
function formatCompactDistance(value: number): string {
|
||||||
|
const safeValue = Number.isFinite(value) ? Math.max(0, value) : 0
|
||||||
|
// String() keeps a '.' decimal regardless of locale (no "1,5k" in non-English UIs).
|
||||||
|
if (safeValue >= 1000) {
|
||||||
|
return `${String(Math.round(safeValue / 100) / 10)}k`
|
||||||
|
}
|
||||||
|
const rounded = Math.round(safeValue * 10) / 10
|
||||||
|
if (safeValue > 0 && rounded === 0) return '<0.1'
|
||||||
|
return String(rounded)
|
||||||
|
}
|
||||||
|
|
||||||
function AtlasStats({ stats }: { stats: TravelStats | null }): React.ReactElement {
|
function AtlasStats({ stats }: { stats: TravelStats | null }): React.ReactElement {
|
||||||
const { t } = useTranslation()
|
const { t } = useTranslation()
|
||||||
|
const distanceUnit = useSettingsStore(s => s.settings.distance_unit) || 'metric'
|
||||||
const countries = stats?.countries || []
|
const countries = stats?.countries || []
|
||||||
const distanceKm = stats?.totalDistanceKm || 0
|
const distanceKm = stats?.totalDistanceKm || 0
|
||||||
const distanceText = distanceKm >= 1000 ? `${(distanceKm / 1000).toFixed(1)}k` : String(distanceKm)
|
const distance = convertDistance(distanceKm, distanceUnit)
|
||||||
const equatorTimes = (distanceKm / 40075).toFixed(2)
|
const distanceText = formatCompactDistance(distance)
|
||||||
|
const equatorDistance = convertDistance(40075, distanceUnit)
|
||||||
|
const equatorTimes = (distance / equatorDistance).toFixed(2)
|
||||||
|
const distanceLabel = getDistanceUnitLabel(distanceUnit)
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<section className="atlas">
|
<section className="atlas">
|
||||||
@@ -381,7 +417,7 @@ function AtlasStats({ stats }: { stats: TravelStats | null }): React.ReactElemen
|
|||||||
|
|
||||||
<div className="atlas-card">
|
<div className="atlas-card">
|
||||||
<div className="label">{t('dashboard.atlas.distanceFlown')}</div>
|
<div className="label">{t('dashboard.atlas.distanceFlown')}</div>
|
||||||
<div className="value mono">{distanceText} <span className="unit">{t('dashboard.atlas.kmUnit')}</span></div>
|
<div className="value mono">{distanceText} <span className="unit">{distanceLabel}</span></div>
|
||||||
<div className="delta">{t('dashboard.atlas.aroundEquator', { count: equatorTimes })}</div>
|
<div className="delta">{t('dashboard.atlas.aroundEquator', { count: equatorTimes })}</div>
|
||||||
<svg className="spark" width="80" height="36" viewBox="0 0 80 36">
|
<svg className="spark" width="80" height="36" viewBox="0 0 80 36">
|
||||||
<circle cx="40" cy="18" r="14" fill="none" stroke="oklch(0.88 0.01 70)" strokeWidth="2" />
|
<circle cx="40" cy="18" r="14" fill="none" stroke="oklch(0.88 0.01 70)" strokeWidth="2" />
|
||||||
@@ -455,20 +491,41 @@ const FX_FALLBACK = ['EUR', 'USD', 'GBP', 'CHF', 'JPY', 'CAD', 'AUD', 'CNY', 'SE
|
|||||||
|
|
||||||
function CurrencyTool(): React.ReactElement {
|
function CurrencyTool(): React.ReactElement {
|
||||||
const { t } = useTranslation()
|
const { t } = useTranslation()
|
||||||
const [from, setFrom] = useState(() => localStorage.getItem('trek_fx_from') || 'EUR')
|
const isLoaded = useSettingsStore(s => s.isLoaded)
|
||||||
const [to, setTo] = useState(() => localStorage.getItem('trek_fx_to') || 'USD')
|
const updateSetting = useSettingsStore(s => s.updateSetting)
|
||||||
|
const from = useSettingsStore(s => s.settings.dashboard_fx_from) || 'EUR'
|
||||||
|
const to = useSettingsStore(s => s.settings.dashboard_fx_to) || 'USD'
|
||||||
|
const setFrom = (v: string) => { updateSetting('dashboard_fx_from', v).catch(() => {}) }
|
||||||
|
const setTo = (v: string) => { updateSetting('dashboard_fx_to', v).catch(() => {}) }
|
||||||
const [amount, setAmount] = useState('100')
|
const [amount, setAmount] = useState('100')
|
||||||
const [rates, setRates] = useState<Record<string, number> | null>(null)
|
const [rates, setRates] = useState<Record<string, number> | null>(null)
|
||||||
|
|
||||||
const fetchRate = React.useCallback(() => {
|
const fetchRate = React.useCallback(() => {
|
||||||
fetch(`https://api.exchangerate-api.com/v4/latest/${from}`)
|
fetch(`https://api.frankfurter.dev/v2/rates?base=${from}`)
|
||||||
.then(r => r.json())
|
.then(r => r.json())
|
||||||
.then(d => setRates(d.rates ?? null))
|
.then((d: Array<{ quote: string; rate: number }>) => {
|
||||||
|
if (!Array.isArray(d)) { setRates(null); return }
|
||||||
|
// Frankfurter omits the base's own self-rate; seed it so `from` stays selectable.
|
||||||
|
const map: Record<string, number> = { [from]: 1 }
|
||||||
|
for (const r of d) map[r.quote] = r.rate
|
||||||
|
setRates(map)
|
||||||
|
})
|
||||||
.catch(() => setRates(null))
|
.catch(() => setRates(null))
|
||||||
}, [from])
|
}, [from])
|
||||||
|
|
||||||
useEffect(() => { fetchRate() }, [fetchRate])
|
useEffect(() => { fetchRate() }, [fetchRate])
|
||||||
useEffect(() => { localStorage.setItem('trek_fx_from', from); localStorage.setItem('trek_fx_to', to) }, [from, to])
|
// One-time migration of the pre-3.1.3 localStorage values into the user's settings,
|
||||||
|
// so a (docker) upgrade no longer resets the widget (#1311).
|
||||||
|
useEffect(() => {
|
||||||
|
if (!isLoaded) return
|
||||||
|
const lf = localStorage.getItem('trek_fx_from')
|
||||||
|
const lt = localStorage.getItem('trek_fx_to')
|
||||||
|
if (!lf && !lt) return
|
||||||
|
if (lf) updateSetting('dashboard_fx_from', lf).catch(() => {})
|
||||||
|
if (lt) updateSetting('dashboard_fx_to', lt).catch(() => {})
|
||||||
|
localStorage.removeItem('trek_fx_from')
|
||||||
|
localStorage.removeItem('trek_fx_to')
|
||||||
|
}, [isLoaded, updateSetting])
|
||||||
|
|
||||||
const currencies = rates ? Object.keys(rates).sort() : FX_FALLBACK
|
const currencies = rates ? Object.keys(rates).sort() : FX_FALLBACK
|
||||||
const ccyOptions = currencies.map(c => ({ value: c, label: c }))
|
const ccyOptions = currencies.map(c => ({ value: c, label: c }))
|
||||||
@@ -523,13 +580,12 @@ function TimezoneTool({ locale }: { locale: string }): React.ReactElement {
|
|||||||
const { t } = useTranslation()
|
const { t } = useTranslation()
|
||||||
const home = Intl.DateTimeFormat().resolvedOptions().timeZone
|
const home = Intl.DateTimeFormat().resolvedOptions().timeZone
|
||||||
const [now, setNow] = useState(() => new Date())
|
const [now, setNow] = useState(() => new Date())
|
||||||
const [zones, setZones] = useState<string[]>(() => {
|
const isLoaded = useSettingsStore(s => s.isLoaded)
|
||||||
try {
|
const updateSetting = useSettingsStore(s => s.updateSetting)
|
||||||
const raw = localStorage.getItem('trek_dashboard_tz')
|
const stored = useSettingsStore(s => s.settings.dashboard_timezones)
|
||||||
if (raw) return JSON.parse(raw)
|
// Unset (never chosen) falls back to home + defaults; an explicit list is honoured.
|
||||||
} catch { /* ignore malformed storage */ }
|
const zones = stored ?? [home, ...DEFAULT_ZONES]
|
||||||
return [home, ...DEFAULT_ZONES]
|
const setZones = (next: string[]) => { updateSetting('dashboard_timezones', next).catch(() => {}) }
|
||||||
})
|
|
||||||
const [adding, setAdding] = useState(false)
|
const [adding, setAdding] = useState(false)
|
||||||
|
|
||||||
// A minute's resolution is plenty for clocks and keeps re-renders cheap.
|
// A minute's resolution is plenty for clocks and keeps re-renders cheap.
|
||||||
@@ -538,7 +594,18 @@ function TimezoneTool({ locale }: { locale: string }): React.ReactElement {
|
|||||||
return () => clearInterval(id)
|
return () => clearInterval(id)
|
||||||
}, [])
|
}, [])
|
||||||
|
|
||||||
useEffect(() => { localStorage.setItem('trek_dashboard_tz', JSON.stringify(zones)) }, [zones])
|
// One-time migration of the pre-3.1.3 localStorage value into the user's settings,
|
||||||
|
// so a (docker) upgrade no longer resets the widget (#1311).
|
||||||
|
useEffect(() => {
|
||||||
|
if (!isLoaded) return
|
||||||
|
const raw = localStorage.getItem('trek_dashboard_tz')
|
||||||
|
if (!raw) return
|
||||||
|
try {
|
||||||
|
const parsed = JSON.parse(raw)
|
||||||
|
if (Array.isArray(parsed)) updateSetting('dashboard_timezones', parsed).catch(() => {})
|
||||||
|
} catch { /* ignore malformed storage */ }
|
||||||
|
localStorage.removeItem('trek_dashboard_tz')
|
||||||
|
}, [isLoaded, updateSetting])
|
||||||
|
|
||||||
const allZones = React.useMemo<string[]>(() => {
|
const allZones = React.useMemo<string[]>(() => {
|
||||||
const supported = (Intl as unknown as { supportedValuesOf?: (k: string) => string[] }).supportedValuesOf
|
const supported = (Intl as unknown as { supportedValuesOf?: (k: string) => string[] }).supportedValuesOf
|
||||||
@@ -549,8 +616,8 @@ function TimezoneTool({ locale }: { locale: string }): React.ReactElement {
|
|||||||
.filter(z => !zones.includes(z))
|
.filter(z => !zones.includes(z))
|
||||||
.map(z => ({ value: z, label: z.replace(/_/g, ' '), searchLabel: z }))
|
.map(z => ({ value: z, label: z.replace(/_/g, ' '), searchLabel: z }))
|
||||||
|
|
||||||
const addZone = (tz: string) => { if (tz) setZones(prev => prev.includes(tz) ? prev : [...prev, tz]); setAdding(false) }
|
const addZone = (tz: string) => { if (tz && !zones.includes(tz)) setZones([...zones, tz]); setAdding(false) }
|
||||||
const removeZone = (tz: string) => setZones(prev => prev.filter(z => z !== tz))
|
const removeZone = (tz: string) => setZones(zones.filter(z => z !== tz))
|
||||||
|
|
||||||
const timeIn = (tz: string) => now.toLocaleTimeString(locale, { hour: '2-digit', minute: '2-digit', hour12: false, timeZone: tz })
|
const timeIn = (tz: string) => now.toLocaleTimeString(locale, { hour: '2-digit', minute: '2-digit', hour12: false, timeZone: tz })
|
||||||
const offsetLabel = (tz: string) => {
|
const offsetLabel = (tz: string) => {
|
||||||
@@ -596,6 +663,7 @@ function UpcomingTool({ items, locale, onOpen }: {
|
|||||||
items: UpcomingReservation[]; locale: string; onOpen: (tripId: number) => void
|
items: UpcomingReservation[]; locale: string; onOpen: (tripId: number) => void
|
||||||
}): React.ReactElement {
|
}): React.ReactElement {
|
||||||
const { t } = useTranslation()
|
const { t } = useTranslation()
|
||||||
|
const timeFormat = useSettingsStore(s => s.settings.time_format)
|
||||||
return (
|
return (
|
||||||
<div className="tool">
|
<div className="tool">
|
||||||
<div className="tool-head">
|
<div className="tool-head">
|
||||||
@@ -606,10 +674,13 @@ function UpcomingTool({ items, locale, onOpen }: {
|
|||||||
) : (
|
) : (
|
||||||
<div className="upc-list">
|
<div className="upc-list">
|
||||||
{items.map(r => {
|
{items.map(r => {
|
||||||
const when = r.reservation_time || (r.day_date ? r.day_date + 'T00:00:00' : null)
|
// Read the date/time straight from the stored string parts. Going through
|
||||||
const d = when ? new Date(when) : null
|
// new Date(...).toISOString() reinterprets the naive local time as UTC and
|
||||||
const dateStr = d ? splitDate(d.toISOString().slice(0, 10), locale) : null
|
// can roll the displayed day forward/back in non-UTC timezones.
|
||||||
const timeStr = r.reservation_time ? new Date(r.reservation_time).toLocaleTimeString(locale, { hour: '2-digit', minute: '2-digit' }) : null
|
const parsed = splitReservationDateTime(r.reservation_time)
|
||||||
|
const datePart = parsed.date || r.day_date || null
|
||||||
|
const dateStr = datePart ? splitDate(datePart, locale) : null
|
||||||
|
const timeStr = parsed.time ? formatTime(parsed.time, locale, timeFormat) : null
|
||||||
const typeClass = RES_TYPE_CLASS[r.type] || 'other'
|
const typeClass = RES_TYPE_CLASS[r.type] || 'other'
|
||||||
return (
|
return (
|
||||||
<div className="upc-item" key={r.id} onClick={() => onOpen(r.trip_id)}>
|
<div className="upc-item" key={r.id} onClick={() => onOpen(r.trip_id)}>
|
||||||
|
|||||||
@@ -103,6 +103,38 @@ describe('LoginPage', () => {
|
|||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('FE-PAGE-LOGIN-007: Remember me sends remember_me to the API', () => {
|
||||||
|
it('renders an off toggle and forwards remember_me: true when toggled on', async () => {
|
||||||
|
let capturedBody: Record<string, unknown> | null = null;
|
||||||
|
server.use(
|
||||||
|
http.post('/api/auth/login', async ({ request }) => {
|
||||||
|
capturedBody = (await request.json()) as Record<string, unknown>;
|
||||||
|
return HttpResponse.json({ user: { id: 1, username: 'test', email: 'test@example.com', role: 'user' } });
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
|
||||||
|
const user = userEvent.setup();
|
||||||
|
render(<LoginPage />);
|
||||||
|
|
||||||
|
await waitFor(() => {
|
||||||
|
expect(screen.getByPlaceholderText(EMAIL_PLACEHOLDER)).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
const toggle = screen.getByRole('button', { name: /remember me/i });
|
||||||
|
expect(toggle).toHaveAttribute('aria-pressed', 'false');
|
||||||
|
|
||||||
|
await user.type(screen.getByPlaceholderText(EMAIL_PLACEHOLDER), 'user@example.com');
|
||||||
|
await user.type(screen.getByPlaceholderText(PASSWORD_PLACEHOLDER), 'password123');
|
||||||
|
await user.click(toggle);
|
||||||
|
expect(toggle).toHaveAttribute('aria-pressed', 'true');
|
||||||
|
await user.click(screen.getByRole('button', { name: /sign in/i }));
|
||||||
|
|
||||||
|
await waitFor(() => {
|
||||||
|
expect(capturedBody).toEqual(expect.objectContaining({ remember_me: true }));
|
||||||
|
});
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
describe('FE-PAGE-LOGIN-005: Registration toggle visible', () => {
|
describe('FE-PAGE-LOGIN-005: Registration toggle visible', () => {
|
||||||
it('shows a Register button to switch to registration mode', async () => {
|
it('shows a Register button to switch to registration mode', async () => {
|
||||||
// Default appConfig has allow_registration: true, has_users: true
|
// Default appConfig has allow_registration: true, has_users: true
|
||||||
|
|||||||
@@ -2,6 +2,7 @@ import React from 'react'
|
|||||||
import { SUPPORTED_LANGUAGES, useTranslation } from '../i18n'
|
import { SUPPORTED_LANGUAGES, useTranslation } from '../i18n'
|
||||||
import { Plane, Eye, EyeOff, Mail, Lock, MapPin, Calendar, Package, User, Globe, Zap, Users, Wallet, Map, CheckSquare, BookMarked, FolderOpen, Route, Shield, KeyRound, ChevronDown, Fingerprint } from 'lucide-react'
|
import { Plane, Eye, EyeOff, Mail, Lock, MapPin, Calendar, Package, User, Globe, Zap, Users, Wallet, Map, CheckSquare, BookMarked, FolderOpen, Route, Shield, KeyRound, ChevronDown, Fingerprint } from 'lucide-react'
|
||||||
import { useLogin } from './login/useLogin'
|
import { useLogin } from './login/useLogin'
|
||||||
|
import ToggleSwitch from '../components/Settings/ToggleSwitch'
|
||||||
|
|
||||||
export default function LoginPage(): React.ReactElement {
|
export default function LoginPage(): React.ReactElement {
|
||||||
const { t, language } = useTranslation()
|
const { t, language } = useTranslation()
|
||||||
@@ -9,7 +10,7 @@ export default function LoginPage(): React.ReactElement {
|
|||||||
const {
|
const {
|
||||||
navigate,
|
navigate,
|
||||||
mode, setMode,
|
mode, setMode,
|
||||||
username, setUsername, email, setEmail, password, setPassword, showPassword, setShowPassword,
|
username, setUsername, email, setEmail, password, setPassword, rememberMe, setRememberMe, showPassword, setShowPassword,
|
||||||
isLoading, error, setError, appConfig, inviteToken,
|
isLoading, error, setError, appConfig, inviteToken,
|
||||||
langDropdownOpen, setLangDropdownOpen, setLanguageLocal,
|
langDropdownOpen, setLangDropdownOpen, setLanguageLocal,
|
||||||
showTakeoff, mfaStep, setMfaStep, mfaToken, setMfaToken, mfaCode, setMfaCode,
|
showTakeoff, mfaStep, setMfaStep, mfaToken, setMfaToken, mfaCode, setMfaCode,
|
||||||
@@ -572,7 +573,16 @@ export default function LoginPage(): React.ReactElement {
|
|||||||
</button>
|
</button>
|
||||||
</div>
|
</div>
|
||||||
{mode === 'login' && (
|
{mode === 'login' && (
|
||||||
<div style={{ textAlign: 'right', marginTop: 6 }}>
|
<div style={{ display: 'flex', alignItems: 'center', justifyContent: 'space-between', gap: 12, marginTop: 8 }}>
|
||||||
|
<div style={{ display: 'flex', alignItems: 'center', gap: 8 }}>
|
||||||
|
<ToggleSwitch on={rememberMe} onToggle={() => setRememberMe(!rememberMe)} label={t('login.rememberMe')} />
|
||||||
|
<span
|
||||||
|
onClick={() => setRememberMe(!rememberMe)}
|
||||||
|
style={{ cursor: 'pointer', color: '#374151', fontSize: 12.5, fontWeight: 500, userSelect: 'none' }}
|
||||||
|
>
|
||||||
|
{t('login.rememberMe')}
|
||||||
|
</span>
|
||||||
|
</div>
|
||||||
<button type="button" onClick={() => navigate('/forgot-password')} style={{
|
<button type="button" onClick={() => navigate('/forgot-password')} style={{
|
||||||
background: 'none', border: 'none', cursor: 'pointer', padding: 0,
|
background: 'none', border: 'none', cursor: 'pointer', padding: 0,
|
||||||
color: '#6b7280', fontSize: 12.5, fontWeight: 500, fontFamily: 'inherit',
|
color: '#6b7280', fontSize: 12.5, fontWeight: 500, fontFamily: 'inherit',
|
||||||
|
|||||||
@@ -3,7 +3,9 @@ import { render, screen, waitFor, fireEvent } from '../../tests/helpers/render';
|
|||||||
import { Routes, Route } from 'react-router-dom';
|
import { Routes, Route } from 'react-router-dom';
|
||||||
import { http, HttpResponse } from 'msw';
|
import { http, HttpResponse } from 'msw';
|
||||||
import { server } from '../../tests/helpers/msw/server';
|
import { server } from '../../tests/helpers/msw/server';
|
||||||
import { resetAllStores } from '../../tests/helpers/store';
|
import { resetAllStores, seedStore } from '../../tests/helpers/store';
|
||||||
|
import { buildSettings } from '../../tests/helpers/factories';
|
||||||
|
import { useSettingsStore } from '../store/settingsStore';
|
||||||
import SharedTripPage from './SharedTripPage';
|
import SharedTripPage from './SharedTripPage';
|
||||||
|
|
||||||
// Mock react-leaflet (SharedTripPage renders a map)
|
// Mock react-leaflet (SharedTripPage renders a map)
|
||||||
@@ -405,4 +407,106 @@ describe('SharedTripPage', () => {
|
|||||||
});
|
});
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('FE-PAGE-SHARED-017: Multi-leg flight shows each leg in the Day Plan', () => {
|
||||||
|
const day = { id: 101, trip_id: 1, day_number: 1, date: '2026-07-01', title: 'Day One', notes: null };
|
||||||
|
const multiLegFlight = {
|
||||||
|
id: 9, trip_id: 1, title: 'Flight', type: 'flight', status: 'confirmed',
|
||||||
|
day_id: 101, end_day_id: 101,
|
||||||
|
reservation_time: '2026-07-01T08:00:00', reservation_end_time: '2026-07-01T20:00:00',
|
||||||
|
metadata: JSON.stringify({
|
||||||
|
legs: [
|
||||||
|
{ from: 'FRA', to: 'BER', airline: 'Lufthansa', flight_number: 'LH1', dep_day_id: 101, dep_time: '08:00', arr_day_id: 101, arr_time: '09:00' },
|
||||||
|
{ from: 'BER', to: 'HND', airline: 'Lufthansa', flight_number: 'LH2', dep_day_id: 101, dep_time: '10:00', arr_day_id: 101, arr_time: '20:00' },
|
||||||
|
],
|
||||||
|
departure_airport: 'FRA', arrival_airport: 'HND', airline: 'Lufthansa', flight_number: 'LH1',
|
||||||
|
}),
|
||||||
|
};
|
||||||
|
|
||||||
|
function serveMultiLeg(token: string) {
|
||||||
|
server.use(
|
||||||
|
http.get('/api/shared/:token', ({ params }) => {
|
||||||
|
if (params.token !== token) return;
|
||||||
|
return HttpResponse.json({
|
||||||
|
trip: { id: 1, title: 'Shared Paris Trip', start_date: '2026-07-01', end_date: '2026-07-05' },
|
||||||
|
days: [day],
|
||||||
|
assignments: {},
|
||||||
|
dayNotes: {},
|
||||||
|
places: [],
|
||||||
|
reservations: [multiLegFlight],
|
||||||
|
accommodations: [],
|
||||||
|
packing: [],
|
||||||
|
budget: [],
|
||||||
|
categories: [],
|
||||||
|
permissions: { share_bookings: true, share_packing: false, share_budget: false, share_collab: false },
|
||||||
|
collab: [],
|
||||||
|
});
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
it('renders each leg with its own route, not the overall start/end', async () => {
|
||||||
|
serveMultiLeg('multileg-token');
|
||||||
|
renderSharedTrip('multileg-token');
|
||||||
|
|
||||||
|
await waitFor(() => {
|
||||||
|
expect(screen.getByText('Shared Paris Trip')).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
// Expand the day to reveal the timeline
|
||||||
|
fireEvent.click(screen.getByText('Day One'));
|
||||||
|
|
||||||
|
await waitFor(() => {
|
||||||
|
expect(screen.getByText(/FRA → BER/)).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
// Second leg shows its OWN route + flight number (the bug showed the overall route here)
|
||||||
|
expect(screen.getByText(/BER → HND/)).toBeInTheDocument();
|
||||||
|
expect(screen.getByText(/LH2/)).toBeInTheDocument();
|
||||||
|
// The overall start→end must NOT appear on any leg
|
||||||
|
expect(screen.queryByText(/FRA → HND/)).toBeNull();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('lists each leg flight number in the Bookings tab', async () => {
|
||||||
|
serveMultiLeg('multileg-bookings-token');
|
||||||
|
renderSharedTrip('multileg-bookings-token');
|
||||||
|
|
||||||
|
await waitFor(() => {
|
||||||
|
expect(screen.getByText('Shared Paris Trip')).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
fireEvent.click(screen.getByRole('button', { name: /bookings/i }));
|
||||||
|
|
||||||
|
await waitFor(() => {
|
||||||
|
expect(screen.getByText(/LH1/)).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
expect(screen.getByText(/LH2/)).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('FE-PAGE-SHARED-018: untitled day uses the translated day label (#1296)', () => {
|
||||||
|
it('renders the day-number label via i18n (German), not a hardcoded English string', async () => {
|
||||||
|
seedStore(useSettingsStore, { settings: buildSettings({ language: 'de' }) });
|
||||||
|
const day = { id: 101, trip_id: 1, day_number: 1, date: '2026-07-01', title: null, notes: null };
|
||||||
|
server.use(
|
||||||
|
http.get('/api/shared/:token', () => HttpResponse.json({
|
||||||
|
trip: { id: 1, title: 'Shared Paris Trip', start_date: '2026-07-01', end_date: '2026-07-05' },
|
||||||
|
days: [day],
|
||||||
|
assignments: {},
|
||||||
|
dayNotes: {},
|
||||||
|
places: [],
|
||||||
|
reservations: [],
|
||||||
|
accommodations: [],
|
||||||
|
packing: [],
|
||||||
|
budget: [],
|
||||||
|
categories: [],
|
||||||
|
permissions: { share_bookings: false, share_packing: false, share_budget: false, share_collab: false },
|
||||||
|
collab: [],
|
||||||
|
})),
|
||||||
|
);
|
||||||
|
renderSharedTrip('test-token');
|
||||||
|
// The untitled day shows the German label "Tag 1", proving the hardcoded English
|
||||||
|
// "Day 1" was replaced by the i18n key t('dayplan.dayN').
|
||||||
|
await waitFor(() => expect(screen.getByText('Tag 1')).toBeInTheDocument());
|
||||||
|
});
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -11,6 +11,7 @@ import { renderToStaticMarkup } from 'react-dom/server'
|
|||||||
import { Clock, MapPin, FileText, Train, Plane, Bus, Car, Ship, Ticket, Hotel, Map, Luggage, Wallet, MessageCircle } from 'lucide-react'
|
import { Clock, MapPin, FileText, Train, Plane, Bus, Car, Ship, Ticket, Hotel, Map, Luggage, Wallet, MessageCircle } from 'lucide-react'
|
||||||
import { isDayInAccommodationRange } from '../utils/dayOrder'
|
import { isDayInAccommodationRange } from '../utils/dayOrder'
|
||||||
import { getTransportForDay, getMergedItems } from '../utils/dayMerge'
|
import { getTransportForDay, getMergedItems } from '../utils/dayMerge'
|
||||||
|
import { getFlightLegs } from '../utils/flightLegs'
|
||||||
import { splitReservationDateTime } from '../utils/formatters'
|
import { splitReservationDateTime } from '../utils/formatters'
|
||||||
|
|
||||||
const TRANSPORT_ICONS = { flight: Plane, train: Train, bus: Bus, car: Car, cruise: Ship }
|
const TRANSPORT_ICONS = { flight: Plane, train: Train, bus: Bus, car: Car, cruise: Ship }
|
||||||
@@ -195,7 +196,7 @@ export default function SharedTripPage() {
|
|||||||
style={{ padding: '12px 16px', cursor: 'pointer', display: 'flex', alignItems: 'center', gap: 10 }}>
|
style={{ padding: '12px 16px', cursor: 'pointer', display: 'flex', alignItems: 'center', gap: 10 }}>
|
||||||
<div className={selectedDay === day.id ? 'bg-[#111827] text-white' : 'bg-[#f3f4f6] text-[#6b7280]'} style={{ width: 28, height: 28, borderRadius: '50%', display: 'flex', alignItems: 'center', justifyContent: 'center', fontSize: 12, fontWeight: 700, flexShrink: 0 }}>{di + 1}</div>
|
<div className={selectedDay === day.id ? 'bg-[#111827] text-white' : 'bg-[#f3f4f6] text-[#6b7280]'} style={{ width: 28, height: 28, borderRadius: '50%', display: 'flex', alignItems: 'center', justifyContent: 'center', fontSize: 12, fontWeight: 700, flexShrink: 0 }}>{di + 1}</div>
|
||||||
<div style={{ flex: 1 }}>
|
<div style={{ flex: 1 }}>
|
||||||
<div className="text-[#111827]" style={{ fontSize: 14, fontWeight: 600 }}>{day.title || `Day ${day.day_number}`}</div>
|
<div className="text-[#111827]" style={{ fontSize: 14, fontWeight: 600 }}>{day.title || t('dayplan.dayN', { n: day.day_number })}</div>
|
||||||
{day.date && <div className="text-[#9ca3af]" style={{ fontSize: 11, marginTop: 1 }}>{new Date(day.date + 'T00:00:00Z').toLocaleDateString(locale, { weekday: 'short', day: 'numeric', month: 'short', timeZone: 'UTC' })}</div>}
|
{day.date && <div className="text-[#9ca3af]" style={{ fontSize: 11, marginTop: 1 }}>{new Date(day.date + 'T00:00:00Z').toLocaleDateString(locale, { weekday: 'short', day: 'numeric', month: 'short', timeZone: 'UTC' })}</div>}
|
||||||
</div>
|
</div>
|
||||||
{dayAccs.map((acc: any) => (
|
{dayAccs.map((acc: any) => (
|
||||||
@@ -214,16 +215,24 @@ export default function SharedTripPage() {
|
|||||||
const TIcon = TRANSPORT_ICONS[r.type] || Ticket
|
const TIcon = TRANSPORT_ICONS[r.type] || Ticket
|
||||||
const meta = typeof r.metadata === 'string' ? JSON.parse(r.metadata || '{}') : (r.metadata || {})
|
const meta = typeof r.metadata === 'string' ? JSON.parse(r.metadata || '{}') : (r.metadata || {})
|
||||||
const time = splitReservationDateTime(r.reservation_time).time ?? ''
|
const time = splitReservationDateTime(r.reservation_time).time ?? ''
|
||||||
|
const endTime = splitReservationDateTime(r.reservation_end_time).time ?? ''
|
||||||
let sub = ''
|
let sub = ''
|
||||||
if (r.type === 'flight') sub = [meta.airline, meta.flight_number, meta.departure_airport && meta.arrival_airport ? `${meta.departure_airport} → ${meta.arrival_airport}` : ''].filter(Boolean).join(' · ')
|
if (r.type === 'flight') {
|
||||||
|
if (r.__leg) {
|
||||||
|
// One leg of a multi-leg flight — show this segment's own route/flight number.
|
||||||
|
sub = [r.__leg.airline, r.__leg.flight_number, (r.__leg.from || r.__leg.to) ? [r.__leg.from, r.__leg.to].filter(Boolean).join(' → ') : ''].filter(Boolean).join(' · ')
|
||||||
|
} else {
|
||||||
|
sub = [meta.airline, meta.flight_number, meta.departure_airport && meta.arrival_airport ? `${meta.departure_airport} → ${meta.arrival_airport}` : ''].filter(Boolean).join(' · ')
|
||||||
|
}
|
||||||
|
}
|
||||||
else if (r.type === 'train') sub = [meta.train_number, meta.platform ? `Gl. ${meta.platform}` : ''].filter(Boolean).join(' · ')
|
else if (r.type === 'train') sub = [meta.train_number, meta.platform ? `Gl. ${meta.platform}` : ''].filter(Boolean).join(' · ')
|
||||||
return (
|
return (
|
||||||
<div key={`t-${r.id}`} className="bg-[rgba(59,130,246,0.06)]" style={{ display: 'flex', alignItems: 'center', gap: 8, padding: '6px 8px', borderRadius: 6, border: '1px solid rgba(59,130,246,0.15)' }}>
|
<div key={r.__leg ? `t-${r.id}-leg${r.__leg.index}` : `t-${r.id}`} className="bg-[rgba(59,130,246,0.06)]" style={{ display: 'flex', alignItems: 'center', gap: 8, padding: '6px 8px', borderRadius: 6, border: '1px solid rgba(59,130,246,0.15)' }}>
|
||||||
<div className="bg-[rgba(59,130,246,0.12)]" style={{ width: 24, height: 24, borderRadius: '50%', display: 'flex', alignItems: 'center', justifyContent: 'center', flexShrink: 0 }}>
|
<div className="bg-[rgba(59,130,246,0.12)]" style={{ width: 24, height: 24, borderRadius: '50%', display: 'flex', alignItems: 'center', justifyContent: 'center', flexShrink: 0 }}>
|
||||||
<TIcon size={12} color="#3b82f6" />
|
<TIcon size={12} color="#3b82f6" />
|
||||||
</div>
|
</div>
|
||||||
<div style={{ flex: 1, minWidth: 0 }}>
|
<div style={{ flex: 1, minWidth: 0 }}>
|
||||||
<div className="text-[#111827]" style={{ fontSize: 12, fontWeight: 500 }}>{r.title}{time ? ` · ${time}` : ''}</div>
|
<div className="text-[#111827]" style={{ fontSize: 12, fontWeight: 500 }}>{r.title}{time ? ` · ${time}${endTime ? `–${endTime}` : ''}` : ''}</div>
|
||||||
{sub && <div className="text-[#6b7280]" style={{ fontSize: 10 }}>{sub}</div>}
|
{sub && <div className="text-[#6b7280]" style={{ fontSize: 10 }}>{sub}</div>}
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
@@ -284,7 +293,11 @@ export default function SharedTripPage() {
|
|||||||
{date && <span>{date}</span>}
|
{date && <span>{date}</span>}
|
||||||
{time && <span>{time}</span>}
|
{time && <span>{time}</span>}
|
||||||
{r.location && <span>{r.location}</span>}
|
{r.location && <span>{r.location}</span>}
|
||||||
{meta.airline && <span>{meta.airline} {meta.flight_number || ''}</span>}
|
{r.type === 'flight'
|
||||||
|
? getFlightLegs(r).map((leg, i) => (
|
||||||
|
<span key={i}>{[leg.airline, leg.flight_number, (leg.from || leg.to) ? [leg.from, leg.to].filter(Boolean).join(' → ') : ''].filter(Boolean).join(' ')}</span>
|
||||||
|
))
|
||||||
|
: meta.airline && <span>{meta.airline} {meta.flight_number || ''}</span>}
|
||||||
{meta.train_number && <span>{meta.train_number}</span>}
|
{meta.train_number && <span>{meta.train_number}</span>}
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
|
|||||||
@@ -1160,10 +1160,13 @@ describe('TripPlannerPage', () => {
|
|||||||
});
|
});
|
||||||
|
|
||||||
describe('FE-PAGE-PLANNER-041: handleSaveReservation edit path covers update reservation', () => {
|
describe('FE-PAGE-PLANNER-041: handleSaveReservation edit path covers update reservation', () => {
|
||||||
it('calls onEdit then onSave on ReservationModal to exercise the edit-reservation handler', async () => {
|
it('does not force a day_id on edit so the server keeps/derives it (#1237)', async () => {
|
||||||
vi.useFakeTimers();
|
vi.useFakeTimers();
|
||||||
|
|
||||||
seedTripStore({ id: 42 });
|
seedTripStore({ id: 42 });
|
||||||
|
// Capture the update payload — tripActions is a snapshot of the store at mount.
|
||||||
|
const updateReservationSpy = vi.fn().mockResolvedValue({ id: 1, day_id: 7 });
|
||||||
|
seedStore(useTripStore, { updateReservation: updateReservationSpy } as any);
|
||||||
|
|
||||||
renderPlannerPage(42);
|
renderPlannerPage(42);
|
||||||
|
|
||||||
@@ -1179,20 +1182,24 @@ describe('TripPlannerPage', () => {
|
|||||||
expect(screen.getByTestId('reservations-panel')).toBeInTheDocument();
|
expect(screen.getByTestId('reservations-panel')).toBeInTheDocument();
|
||||||
});
|
});
|
||||||
|
|
||||||
// Set editingReservation via captured onEdit prop (inline lambda in JSX)
|
// Edit a reservation that lives on day 7 (no day is selected — Book tab).
|
||||||
const fakeReservation = { id: 1, trip_id: 42, name: 'Test', type: 'restaurant', status: 'confirmed' };
|
const fakeReservation = { id: 1, trip_id: 42, name: 'Test', type: 'other', status: 'confirmed', day_id: 7 };
|
||||||
await act(async () => {
|
await act(async () => {
|
||||||
capturedReservationsPanelProps.current.onEdit?.(fakeReservation);
|
capturedReservationsPanelProps.current.onEdit?.(fakeReservation);
|
||||||
});
|
});
|
||||||
|
|
||||||
// Call onSave — now takes edit path (editingReservation is set)
|
|
||||||
await act(async () => {
|
await act(async () => {
|
||||||
await capturedReservationModalProps.current.onSave?.({
|
await capturedReservationModalProps.current.onSave?.({
|
||||||
name: 'Updated Booking',
|
name: 'Updated Booking',
|
||||||
type: 'restaurant',
|
type: 'tour',
|
||||||
status: 'confirmed',
|
status: 'confirmed',
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
// The client must NOT send a day_id (no forcing to the selected day, no
|
||||||
|
// stale value) — the server keeps/derives it from the booking's date.
|
||||||
|
expect(updateReservationSpy).toHaveBeenCalled();
|
||||||
|
expect(updateReservationSpy.mock.calls[0][2]).not.toHaveProperty('day_id');
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|||||||
@@ -5,7 +5,7 @@ import { useTripStore } from '../store/tripStore'
|
|||||||
import { useCanDo } from '../store/permissionsStore'
|
import { useCanDo } from '../store/permissionsStore'
|
||||||
import { useSettingsStore } from '../store/settingsStore'
|
import { useSettingsStore } from '../store/settingsStore'
|
||||||
import { MapViewAuto as MapView } from '../components/Map/MapViewAuto'
|
import { MapViewAuto as MapView } from '../components/Map/MapViewAuto'
|
||||||
import { MapCompassPill } from '../components/Map/MapCompassPill'
|
import { MapCompassPill, type CompassMap } from '../components/Map/MapCompassPill'
|
||||||
import { getCached, fetchPhoto } from '../services/photoService'
|
import { getCached, fetchPhoto } from '../services/photoService'
|
||||||
import DayPlanSidebar from '../components/Planner/DayPlanSidebar'
|
import DayPlanSidebar from '../components/Planner/DayPlanSidebar'
|
||||||
import PlacesSidebar from '../components/Planner/PlacesSidebar'
|
import PlacesSidebar from '../components/Planner/PlacesSidebar'
|
||||||
@@ -25,7 +25,9 @@ import PackingListPanel from '../components/Packing/PackingListPanel'
|
|||||||
import ApplyTemplateButton from '../components/Packing/ApplyTemplateButton'
|
import ApplyTemplateButton from '../components/Packing/ApplyTemplateButton'
|
||||||
import TodoListPanel from '../components/Todo/TodoListPanel'
|
import TodoListPanel from '../components/Todo/TodoListPanel'
|
||||||
import FileManager from '../components/Files/FileManager'
|
import FileManager from '../components/Files/FileManager'
|
||||||
import CostsPanel from '../components/Budget/CostsPanel'
|
import CostsPanel, { ExpenseModal, type ExpensePrefill } from '../components/Budget/CostsPanel'
|
||||||
|
import type { BookingExpenseRequest } from '../components/Planner/BookingCostsSection.types'
|
||||||
|
import type { BudgetItem } from '../types'
|
||||||
import CollabPanel from '../components/Collab/CollabPanel'
|
import CollabPanel from '../components/Collab/CollabPanel'
|
||||||
import Navbar from '../components/Layout/Navbar'
|
import Navbar from '../components/Layout/Navbar'
|
||||||
import { useToast } from '../components/shared/Toast'
|
import { useToast } from '../components/shared/Toast'
|
||||||
@@ -201,7 +203,7 @@ export default function TripPlannerPage(): React.ReactElement | null {
|
|||||||
expandedDayIds, setExpandedDayIds, mapPlaces,
|
expandedDayIds, setExpandedDayIds, mapPlaces,
|
||||||
route, routeSegments, routeInfo, setRoute, setRouteInfo, updateRouteForDay,
|
route, routeSegments, routeInfo, setRoute, setRouteInfo, updateRouteForDay,
|
||||||
handleSelectDay, handlePlaceClick, handleMarkerClick, handleMapClick, handleMapContextMenu, openAddPlaceFromPoi,
|
handleSelectDay, handlePlaceClick, handleMarkerClick, handleMapClick, handleMapContextMenu, openAddPlaceFromPoi,
|
||||||
handleSavePlace, handleDeletePlace, confirmDeletePlace, confirmDeletePlaces,
|
handleSavePlace, openPlaceEditor, handleDeletePlace, confirmDeletePlace, confirmDeletePlaces,
|
||||||
handleAssignToDay, handleRemoveAssignment, handleReorder, handleReorderDays, handleAddDay, handleUpdateDayTitle,
|
handleAssignToDay, handleRemoveAssignment, handleReorder, handleReorderDays, handleAddDay, handleUpdateDayTitle,
|
||||||
handleSaveReservation, handleSaveTransport, handleDeleteReservation,
|
handleSaveReservation, handleSaveTransport, handleDeleteReservation,
|
||||||
selectedPlace, dayOrderMap, dayPlaces,
|
selectedPlace, dayOrderMap, dayPlaces,
|
||||||
@@ -209,9 +211,21 @@ export default function TripPlannerPage(): React.ReactElement | null {
|
|||||||
} = useTripPlanner()
|
} = useTripPlanner()
|
||||||
|
|
||||||
const poi = usePoiExplore()
|
const poi = usePoiExplore()
|
||||||
const [glMap, setGlMap] = useState<import('mapbox-gl').Map | null>(null)
|
const [glMap, setGlMap] = useState<CompassMap | null>(null)
|
||||||
const poiPillEnabled = useSettingsStore(s => s.settings.map_poi_pill_enabled) !== false
|
const poiPillEnabled = useSettingsStore(s => s.settings.map_poi_pill_enabled) !== false
|
||||||
|
|
||||||
|
// Costs expense editor opened from a booking modal (save-then-open). Lives at the
|
||||||
|
// page level so it has tripMembers / base currency / current user available.
|
||||||
|
const meId = useAuthStore(s => s.user?.id ?? -1)
|
||||||
|
const displayCurrency = useSettingsStore(s => s.settings.default_currency)
|
||||||
|
const costsBase = (displayCurrency || trip?.currency || 'EUR').toUpperCase()
|
||||||
|
const loadBudgetItems = useTripStore(s => s.loadBudgetItems)
|
||||||
|
const [bookingExpense, setBookingExpense] = useState<{ editing: BudgetItem | null; prefill?: ExpensePrefill } | null>(null)
|
||||||
|
const openBookingExpense = (req: BookingExpenseRequest) => {
|
||||||
|
if (req.editItem) setBookingExpense({ editing: req.editItem })
|
||||||
|
else if (req.prefill) setBookingExpense({ editing: null, prefill: req.prefill })
|
||||||
|
}
|
||||||
|
|
||||||
if (isLoading || !splashDone) {
|
if (isLoading || !splashDone) {
|
||||||
return (
|
return (
|
||||||
<div className="bg-surface" style={{
|
<div className="bg-surface" style={{
|
||||||
@@ -451,7 +465,7 @@ export default function TripPlannerPage(): React.ReactElement | null {
|
|||||||
onPlaceClick={handlePlaceClick}
|
onPlaceClick={handlePlaceClick}
|
||||||
onAddPlace={() => { setEditingPlace(null); setShowPlaceForm(true) }}
|
onAddPlace={() => { setEditingPlace(null); setShowPlaceForm(true) }}
|
||||||
onAssignToDay={handleAssignToDay}
|
onAssignToDay={handleAssignToDay}
|
||||||
onEditPlace={(place) => { setEditingPlace(place); setEditingAssignmentId(null); setShowPlaceForm(true) }}
|
onEditPlace={(place) => openPlaceEditor(place)}
|
||||||
onDeletePlace={(placeId) => handleDeletePlace(placeId)}
|
onDeletePlace={(placeId) => handleDeletePlace(placeId)}
|
||||||
onBulkDeletePlaces={(ids) => setDeletePlaceIds(ids)}
|
onBulkDeletePlaces={(ids) => setDeletePlaceIds(ids)}
|
||||||
onCategoryFilterChange={setMapCategoryFilter}
|
onCategoryFilterChange={setMapCategoryFilter}
|
||||||
@@ -517,17 +531,7 @@ export default function TripPlannerPage(): React.ReactElement | null {
|
|||||||
assignments={assignments}
|
assignments={assignments}
|
||||||
reservations={reservations}
|
reservations={reservations}
|
||||||
onClose={() => setSelectedPlaceId(null)}
|
onClose={() => setSelectedPlaceId(null)}
|
||||||
onEdit={() => {
|
onEdit={() => openPlaceEditor(selectedPlace, selectedAssignmentId)}
|
||||||
if (selectedAssignmentId) {
|
|
||||||
const assignmentObj = Object.values(assignments).flat().find(a => a.id === selectedAssignmentId)
|
|
||||||
const placeWithAssignmentTimes = assignmentObj?.place ? { ...selectedPlace, place_time: assignmentObj.place.place_time, end_time: assignmentObj.place.end_time } : selectedPlace
|
|
||||||
setEditingPlace(placeWithAssignmentTimes)
|
|
||||||
} else {
|
|
||||||
setEditingPlace(selectedPlace)
|
|
||||||
}
|
|
||||||
setEditingAssignmentId(selectedAssignmentId || null)
|
|
||||||
setShowPlaceForm(true)
|
|
||||||
}}
|
|
||||||
onDelete={() => handleDeletePlace(selectedPlace.id)}
|
onDelete={() => handleDeletePlace(selectedPlace.id)}
|
||||||
onAssignToDay={handleAssignToDay}
|
onAssignToDay={handleAssignToDay}
|
||||||
onRemoveAssignment={handleRemoveAssignment}
|
onRemoveAssignment={handleRemoveAssignment}
|
||||||
@@ -565,18 +569,7 @@ export default function TripPlannerPage(): React.ReactElement | null {
|
|||||||
assignments={assignments}
|
assignments={assignments}
|
||||||
reservations={reservations}
|
reservations={reservations}
|
||||||
onClose={() => setSelectedPlaceId(null)}
|
onClose={() => setSelectedPlaceId(null)}
|
||||||
onEdit={() => {
|
onEdit={() => { openPlaceEditor(selectedPlace, selectedAssignmentId); setSelectedPlaceId(null) }}
|
||||||
if (selectedAssignmentId) {
|
|
||||||
const assignmentObj = Object.values(assignments).flat().find(a => a.id === selectedAssignmentId)
|
|
||||||
const placeWithAssignmentTimes = assignmentObj?.place ? { ...selectedPlace, place_time: assignmentObj.place.place_time, end_time: assignmentObj.place.end_time } : selectedPlace
|
|
||||||
setEditingPlace(placeWithAssignmentTimes)
|
|
||||||
} else {
|
|
||||||
setEditingPlace(selectedPlace)
|
|
||||||
}
|
|
||||||
setEditingAssignmentId(selectedAssignmentId || null)
|
|
||||||
setShowPlaceForm(true)
|
|
||||||
setSelectedPlaceId(null)
|
|
||||||
}}
|
|
||||||
onDelete={() => { handleDeletePlace(selectedPlace.id); setSelectedPlaceId(null) }}
|
onDelete={() => { handleDeletePlace(selectedPlace.id); setSelectedPlaceId(null) }}
|
||||||
onAssignToDay={handleAssignToDay}
|
onAssignToDay={handleAssignToDay}
|
||||||
onRemoveAssignment={handleRemoveAssignment}
|
onRemoveAssignment={handleRemoveAssignment}
|
||||||
@@ -617,7 +610,7 @@ export default function TripPlannerPage(): React.ReactElement | null {
|
|||||||
<div style={{ flex: 1, overflow: 'auto' }}>
|
<div style={{ flex: 1, overflow: 'auto' }}>
|
||||||
{mobileSidebarOpen === 'left'
|
{mobileSidebarOpen === 'left'
|
||||||
? <DayPlanSidebar tripId={tripId} trip={trip} days={days} places={places} categories={categories} assignments={assignments} selectedDayId={selectedDayId} selectedPlaceId={selectedPlaceId} selectedAssignmentId={selectedAssignmentId} onSelectDay={(id) => { handleSelectDay(id); setMobileSidebarOpen(null) }} onPlaceClick={(placeId, assignmentId) => { handlePlaceClick(placeId, assignmentId) }} onReorder={handleReorder} onReorderDays={handleReorderDays} onAddDay={handleAddDay} onUpdateDayTitle={handleUpdateDayTitle} onAssignToDay={handleAssignToDay} onRouteCalculated={(r) => { if (r) { setRoute([r.coordinates]); setRouteInfo(r) } }} reservations={reservations} visibleConnectionIds={visibleConnections} onToggleConnection={toggleConnection} onAddReservation={(dayId) => { setEditingReservation(null); tripActions.setSelectedDay(dayId); setShowReservationModal(true); setMobileSidebarOpen(null) }} onAddTransport={can('day_edit', trip) ? (dayId) => { setTransportModalDayId(dayId); setEditingTransport(null); setShowTransportModal(true); setMobileSidebarOpen(null) } : undefined} onAddPlace={() => { setEditingPlace(null); setShowPlaceForm(true); setMobileSidebarOpen(null) }} onDayDetail={(day) => { setShowDayDetail(day); setSelectedPlaceId(null); selectAssignment(null) }} onRemoveAssignment={handleRemoveAssignment} onEditPlace={(place, assignmentId) => { setEditingPlace(place); setEditingAssignmentId(assignmentId || null); setShowPlaceForm(true); setMobileSidebarOpen(null) }} onDeletePlace={(placeId) => handleDeletePlace(placeId)} accommodations={tripAccommodations} routeShown={routeShown} routeProfile={routeProfile} onToggleRoute={() => setRouteShown(v => !v)} onSetRouteProfile={setRouteProfile} onNavigateToFiles={() => { setMobileSidebarOpen(null); handleTabChange('dateien') }} onExpandedDaysChange={setExpandedDayIds} pushUndo={pushUndo} canUndo={canUndo} lastActionLabel={lastActionLabel} onUndo={handleUndo} onEditTransport={can('day_edit', trip) ? (reservation) => { setEditingTransport(reservation); setTransportModalDayId(reservation.day_id ?? null); setShowTransportModal(true); setMobileSidebarOpen(null) } : undefined} onEditReservation={can('reservation_edit', trip) ? (r) => { setEditingReservation(r); setShowReservationModal(true); setMobileSidebarOpen(null) } : undefined} initialScrollTop={mobilePlanScrollTopRef.current} onScrollTopChange={(top) => { mobilePlanScrollTopRef.current = top }} showRouteToolsWhenExpanded />
|
? <DayPlanSidebar tripId={tripId} trip={trip} days={days} places={places} categories={categories} assignments={assignments} selectedDayId={selectedDayId} selectedPlaceId={selectedPlaceId} selectedAssignmentId={selectedAssignmentId} onSelectDay={(id) => { handleSelectDay(id); setMobileSidebarOpen(null) }} onPlaceClick={(placeId, assignmentId) => { handlePlaceClick(placeId, assignmentId) }} onReorder={handleReorder} onReorderDays={handleReorderDays} onAddDay={handleAddDay} onUpdateDayTitle={handleUpdateDayTitle} onAssignToDay={handleAssignToDay} onRouteCalculated={(r) => { if (r) { setRoute([r.coordinates]); setRouteInfo(r) } }} reservations={reservations} visibleConnectionIds={visibleConnections} onToggleConnection={toggleConnection} onAddReservation={(dayId) => { setEditingReservation(null); tripActions.setSelectedDay(dayId); setShowReservationModal(true); setMobileSidebarOpen(null) }} onAddTransport={can('day_edit', trip) ? (dayId) => { setTransportModalDayId(dayId); setEditingTransport(null); setShowTransportModal(true); setMobileSidebarOpen(null) } : undefined} onAddPlace={() => { setEditingPlace(null); setShowPlaceForm(true); setMobileSidebarOpen(null) }} onDayDetail={(day) => { setShowDayDetail(day); setSelectedPlaceId(null); selectAssignment(null) }} onRemoveAssignment={handleRemoveAssignment} onEditPlace={(place, assignmentId) => { setEditingPlace(place); setEditingAssignmentId(assignmentId || null); setShowPlaceForm(true); setMobileSidebarOpen(null) }} onDeletePlace={(placeId) => handleDeletePlace(placeId)} accommodations={tripAccommodations} routeShown={routeShown} routeProfile={routeProfile} onToggleRoute={() => setRouteShown(v => !v)} onSetRouteProfile={setRouteProfile} onNavigateToFiles={() => { setMobileSidebarOpen(null); handleTabChange('dateien') }} onExpandedDaysChange={setExpandedDayIds} pushUndo={pushUndo} canUndo={canUndo} lastActionLabel={lastActionLabel} onUndo={handleUndo} onEditTransport={can('day_edit', trip) ? (reservation) => { setEditingTransport(reservation); setTransportModalDayId(reservation.day_id ?? null); setShowTransportModal(true); setMobileSidebarOpen(null) } : undefined} onEditReservation={can('reservation_edit', trip) ? (r) => { setEditingReservation(r); setShowReservationModal(true); setMobileSidebarOpen(null) } : undefined} initialScrollTop={mobilePlanScrollTopRef.current} onScrollTopChange={(top) => { mobilePlanScrollTopRef.current = top }} showRouteToolsWhenExpanded />
|
||||||
: <PlacesSidebar tripId={tripId} places={places} categories={categories} assignments={assignments} selectedDayId={selectedDayId} selectedPlaceId={selectedPlaceId} onPlaceClick={(placeId) => { handlePlaceClick(placeId); setMobileSidebarOpen(null) }} onAddPlace={() => { setEditingPlace(null); setShowPlaceForm(true); setMobileSidebarOpen(null) }} onAssignToDay={handleAssignToDay} onEditPlace={(place) => { setEditingPlace(place); setEditingAssignmentId(null); setShowPlaceForm(true); setMobileSidebarOpen(null) }} onDeletePlace={(placeId) => handleDeletePlace(placeId)} onBulkDeletePlaces={(ids) => setDeletePlaceIds(ids)} onBulkDeleteConfirm={(ids) => confirmDeletePlaces(ids)} days={days} isMobile onCategoryFilterChange={setMapCategoryFilter} onPlacesFilterChange={setMapPlacesFilter} pushUndo={pushUndo} initialScrollTop={mobilePlacesScrollTopRef.current} onScrollTopChange={(top) => { mobilePlacesScrollTopRef.current = top }} />
|
: <PlacesSidebar tripId={tripId} places={places} categories={categories} assignments={assignments} selectedDayId={selectedDayId} selectedPlaceId={selectedPlaceId} onPlaceClick={(placeId) => { handlePlaceClick(placeId); setMobileSidebarOpen(null) }} onAddPlace={() => { setEditingPlace(null); setShowPlaceForm(true); setMobileSidebarOpen(null) }} onAssignToDay={handleAssignToDay} onEditPlace={(place) => { openPlaceEditor(place); setMobileSidebarOpen(null) }} onDeletePlace={(placeId) => handleDeletePlace(placeId)} onBulkDeletePlaces={(ids) => setDeletePlaceIds(ids)} onBulkDeleteConfirm={(ids) => confirmDeletePlaces(ids)} days={days} isMobile onCategoryFilterChange={setMapCategoryFilter} onPlacesFilterChange={setMapPlacesFilter} pushUndo={pushUndo} initialScrollTop={mobilePlacesScrollTopRef.current} onScrollTopChange={(top) => { mobilePlacesScrollTopRef.current = top }} />
|
||||||
}
|
}
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
@@ -636,6 +629,8 @@ export default function TripPlannerPage(): React.ReactElement | null {
|
|||||||
assignments={assignments}
|
assignments={assignments}
|
||||||
files={files}
|
files={files}
|
||||||
onAdd={() => { setEditingTransport(null); setShowTransportModal(true) }}
|
onAdd={() => { setEditingTransport(null); setShowTransportModal(true) }}
|
||||||
|
onImport={() => setShowBookingImport(true)}
|
||||||
|
bookingImportAvailable={bookingImportAvailable}
|
||||||
onAirTrailImport={() => setShowAirTrailImport(true)}
|
onAirTrailImport={() => setShowAirTrailImport(true)}
|
||||||
airTrailAvailable={airTrailAvailable}
|
airTrailAvailable={airTrailAvailable}
|
||||||
onEdit={(r) => { setEditingTransport(r); setShowTransportModal(true) }}
|
onEdit={(r) => { setEditingTransport(r); setShowTransportModal(true) }}
|
||||||
@@ -701,11 +696,23 @@ export default function TripPlannerPage(): React.ReactElement | null {
|
|||||||
)}
|
)}
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
<PlaceFormModal isOpen={showPlaceForm} onClose={() => { setShowPlaceForm(false); setEditingPlace(null); setEditingAssignmentId(null); setPrefillCoords(null) }} onSave={handleSavePlace} place={editingPlace} prefillCoords={prefillCoords} assignmentId={editingAssignmentId} dayAssignments={editingAssignmentId ? Object.values(assignments).flat() : []} tripId={tripId} categories={categories} onCategoryCreated={cat => tripActions.addCategory?.(cat)} />
|
<PlaceFormModal isOpen={showPlaceForm} onClose={() => { setShowPlaceForm(false); setEditingPlace(null); setEditingAssignmentId(null); setPrefillCoords(null) }} onSave={handleSavePlace} place={editingPlace} prefillCoords={prefillCoords} assignmentId={editingAssignmentId} dayAssignments={editingPlace ? Object.values(assignments).flat() : []} tripId={tripId} categories={categories} onCategoryCreated={cat => tripActions.addCategory?.(cat)} />
|
||||||
<TripFormModal isOpen={showTripForm} onClose={() => setShowTripForm(false)} onSave={async (data) => { await tripActions.updateTrip(tripId, data); toast.success(t('trip.toast.tripUpdated')) }} trip={trip} />
|
<TripFormModal isOpen={showTripForm} onClose={() => setShowTripForm(false)} onSave={async (data) => { await tripActions.updateTrip(tripId, data); toast.success(t('trip.toast.tripUpdated')) }} trip={trip} />
|
||||||
<TripMembersModal isOpen={showMembersModal} onClose={() => setShowMembersModal(false)} tripId={tripId} tripTitle={trip?.title} />
|
<TripMembersModal isOpen={showMembersModal} onClose={() => setShowMembersModal(false)} tripId={tripId} tripTitle={trip?.title} />
|
||||||
<ReservationModal isOpen={showReservationModal} onClose={() => { setShowReservationModal(false); setEditingReservation(null); setBookingForAssignmentId(null) }} onSave={handleSaveReservation} reservation={editingReservation} days={days} places={places} assignments={assignments} selectedDayId={selectedDayId} files={files} onFileUpload={canUploadFiles ? (fd) => tripActions.addFile(tripId, fd) : undefined} onFileDelete={(id) => tripActions.deleteFile(tripId, id)} accommodations={tripAccommodations} defaultAssignmentId={bookingForAssignmentId} />
|
<ReservationModal isOpen={showReservationModal} onClose={() => { setShowReservationModal(false); setEditingReservation(null); setBookingForAssignmentId(null) }} onSave={handleSaveReservation} reservation={editingReservation} days={days} places={places} assignments={assignments} selectedDayId={selectedDayId} files={files} onFileUpload={canUploadFiles ? (fd) => tripActions.addFile(tripId, fd) : undefined} onFileDelete={(id) => tripActions.deleteFile(tripId, id)} accommodations={tripAccommodations} defaultAssignmentId={bookingForAssignmentId} onOpenExpense={openBookingExpense} />
|
||||||
{showTransportModal && <TransportModal isOpen={showTransportModal} onClose={() => { setShowTransportModal(false); setEditingTransport(null); setTransportModalDayId(null) }} onSave={handleSaveTransport} reservation={editingTransport} days={days} selectedDayId={transportModalDayId} files={files} onFileUpload={canUploadFiles ? (fd) => tripActions.addFile(tripId, fd) : undefined} onFileDelete={(id) => tripActions.deleteFile(tripId, id)} />}
|
{showTransportModal && <TransportModal isOpen={showTransportModal} onClose={() => { setShowTransportModal(false); setEditingTransport(null); setTransportModalDayId(null) }} onSave={handleSaveTransport} reservation={editingTransport} days={days} selectedDayId={transportModalDayId} files={files} onFileUpload={canUploadFiles ? (fd) => tripActions.addFile(tripId, fd) : undefined} onFileDelete={(id) => tripActions.deleteFile(tripId, id)} onOpenExpense={openBookingExpense} />}
|
||||||
|
{bookingExpense && (
|
||||||
|
<ExpenseModal
|
||||||
|
tripId={tripId}
|
||||||
|
base={costsBase}
|
||||||
|
people={tripMembers}
|
||||||
|
me={meId}
|
||||||
|
editing={bookingExpense.editing}
|
||||||
|
prefill={bookingExpense.prefill}
|
||||||
|
onClose={() => setBookingExpense(null)}
|
||||||
|
onSaved={() => { setBookingExpense(null); loadBudgetItems(tripId) }}
|
||||||
|
/>
|
||||||
|
)}
|
||||||
<BookingImportModal isOpen={showBookingImport} onClose={() => setShowBookingImport(false)} tripId={tripId} pushUndo={pushUndo} />
|
<BookingImportModal isOpen={showBookingImport} onClose={() => setShowBookingImport(false)} tripId={tripId} pushUndo={pushUndo} />
|
||||||
<AirTrailImportModal isOpen={showAirTrailImport} onClose={() => setShowAirTrailImport(false)} tripId={tripId} pushUndo={pushUndo} />
|
<AirTrailImportModal isOpen={showAirTrailImport} onClose={() => setShowAirTrailImport(false)} tripId={tripId} pushUndo={pushUndo} />
|
||||||
<ConfirmDialog
|
<ConfirmDialog
|
||||||
|
|||||||
@@ -229,12 +229,24 @@ export default function AdminUserModals({ admin, t }: AdminUserModalsProps): Rea
|
|||||||
|
|
||||||
<div style={{ padding: '20px 24px' }}>
|
<div style={{ padding: '20px 24px' }}>
|
||||||
<p className="text-gray-700 dark:text-gray-300" style={{ fontSize: 13, lineHeight: 1.6, margin: 0 }}>
|
<p className="text-gray-700 dark:text-gray-300" style={{ fontSize: 13, lineHeight: 1.6, margin: 0 }}>
|
||||||
{t('admin.update.dockerText').replace('{version}', `v${updateInfo?.latest ?? ''}`)}
|
{(updateInfo?.is_docker === false ? t('admin.update.nonDockerText') : t('admin.update.dockerText')).replace('{version}', `v${updateInfo?.latest ?? ''}`)}
|
||||||
</p>
|
</p>
|
||||||
|
|
||||||
<div style={{ marginTop: 14, padding: '12px 14px', borderRadius: 10, fontSize: 12, lineHeight: 1.8, fontFamily: 'monospace', whiteSpace: 'pre-wrap', wordBreak: 'break-all' }}
|
{updateInfo?.is_docker === false ? (
|
||||||
className="bg-gray-900 dark:bg-gray-950 text-gray-100 border border-gray-700"
|
<a
|
||||||
>
|
href="https://github.com/mauriceboe/TREK/wiki/Updating"
|
||||||
|
target="_blank"
|
||||||
|
rel="noopener noreferrer"
|
||||||
|
style={{ marginTop: 14, padding: '12px 14px', borderRadius: 10, fontSize: 13, lineHeight: 1.5, display: 'flex', alignItems: 'center', gap: 8, textDecoration: 'none' }}
|
||||||
|
className="bg-gray-50 dark:bg-gray-900 text-gray-700 dark:text-gray-200 border border-gray-200 dark:border-gray-700 hover:bg-gray-100 dark:hover:bg-gray-800"
|
||||||
|
>
|
||||||
|
<ExternalLink className="w-4 h-4 flex-shrink-0" />
|
||||||
|
<span className="font-semibold underline">{t('admin.update.wikiLink')}</span>
|
||||||
|
</a>
|
||||||
|
) : (
|
||||||
|
<div style={{ marginTop: 14, padding: '12px 14px', borderRadius: 10, fontSize: 12, lineHeight: 1.8, fontFamily: 'monospace', whiteSpace: 'pre-wrap', wordBreak: 'break-all' }}
|
||||||
|
className="bg-gray-900 dark:bg-gray-950 text-gray-100 border border-gray-700"
|
||||||
|
>
|
||||||
{`docker pull mauriceboe/trek:latest
|
{`docker pull mauriceboe/trek:latest
|
||||||
docker stop trek && docker rm trek
|
docker stop trek && docker rm trek
|
||||||
docker run -d --name trek \\
|
docker run -d --name trek \\
|
||||||
@@ -243,7 +255,8 @@ docker run -d --name trek \\
|
|||||||
-v /opt/trek/uploads:/app/uploads \\
|
-v /opt/trek/uploads:/app/uploads \\
|
||||||
--restart unless-stopped \\
|
--restart unless-stopped \\
|
||||||
mauriceboe/trek:latest`}
|
mauriceboe/trek:latest`}
|
||||||
</div>
|
</div>
|
||||||
|
)}
|
||||||
|
|
||||||
<div style={{ marginTop: 10, padding: '10px 12px', borderRadius: 10, fontSize: 12, lineHeight: 1.5 }}
|
<div style={{ marginTop: 10, padding: '10px 12px', borderRadius: 10, fontSize: 12, lineHeight: 1.5 }}
|
||||||
className="bg-emerald-50 dark:bg-emerald-900/30 text-emerald-700 dark:text-emerald-300 border border-emerald-200 dark:border-emerald-800"
|
className="bg-emerald-50 dark:bg-emerald-900/30 text-emerald-700 dark:text-emerald-300 border border-emerald-200 dark:border-emerald-800"
|
||||||
|
|||||||
@@ -6,6 +6,7 @@ import apiClient, { mapsApi } from '../../api/client'
|
|||||||
import L from 'leaflet'
|
import L from 'leaflet'
|
||||||
import type { GeoJsonFeatureCollection } from '../../types'
|
import type { GeoJsonFeatureCollection } from '../../types'
|
||||||
import { A2_TO_A3, type AtlasData, type CountryDetail, type BucketItem } from './atlasModel'
|
import { A2_TO_A3, type AtlasData, type CountryDetail, type BucketItem } from './atlasModel'
|
||||||
|
import { continentForCountry } from '@trek/shared'
|
||||||
|
|
||||||
function useCountryNames(language: string): (code: string) => string {
|
function useCountryNames(language: string): (code: string) => string {
|
||||||
const [resolver, setResolver] = useState<(code: string) => string>(() => (code: string) => code)
|
const [resolver, setResolver] = useState<(code: string) => string>(() => (code: string) => code)
|
||||||
@@ -133,9 +134,12 @@ export function useAtlas() {
|
|||||||
}, [])
|
}, [])
|
||||||
|
|
||||||
// Load country-border GeoJSON from our API (geoBoundaries, served server-side —
|
// Load country-border GeoJSON from our API (geoBoundaries, served server-side —
|
||||||
// no third-party fetch from the browser).
|
// no third-party fetch from the browser). Even gzipped the payload is a few MB, so
|
||||||
|
// it gets a longer timeout than the global 8s default to survive slow links and
|
||||||
|
// reverse-proxy / Cloudflare-Tunnel setups instead of aborting and leaving the map
|
||||||
|
// with no countries (#1254).
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
apiClient.get('/addons/atlas/countries/geo')
|
apiClient.get('/addons/atlas/countries/geo', { timeout: 30000 })
|
||||||
.then(res => {
|
.then(res => {
|
||||||
const geo = res.data
|
const geo = res.data
|
||||||
// Dynamically build A2→A3 mapping from GeoJSON
|
// Dynamically build A2→A3 mapping from GeoJSON
|
||||||
@@ -340,7 +344,10 @@ export function useAtlas() {
|
|||||||
</div>
|
</div>
|
||||||
</div>`
|
</div>`
|
||||||
layer.bindTooltip(tooltipHtml, {
|
layer.bindTooltip(tooltipHtml, {
|
||||||
sticky: false, permanent: false, className: 'atlas-tooltip', direction: 'top', offset: [0, -10], opacity: 1
|
// sticky so the tooltip tracks the cursor; non-sticky anchors it at the feature's
|
||||||
|
// bounds centre, which for countries with overseas territories (e.g. France) lands
|
||||||
|
// far out in the ocean instead of over the area being hovered.
|
||||||
|
sticky: true, permanent: false, className: 'atlas-tooltip', direction: 'top', offset: [0, -10], opacity: 1
|
||||||
})
|
})
|
||||||
layer.on('click', () => {
|
layer.on('click', () => {
|
||||||
if (c.placeCount === 0 && c.tripCount === 0) {
|
if (c.placeCount === 0 && c.tripCount === 0) {
|
||||||
@@ -363,7 +370,7 @@ export function useAtlas() {
|
|||||||
country_layer_by_a2_ref.current[countryCode] = layer
|
country_layer_by_a2_ref.current[countryCode] = layer
|
||||||
const name = feature.properties?.NAME || feature.properties?.ADMIN || resolveName(countryCode)
|
const name = feature.properties?.NAME || feature.properties?.ADMIN || resolveName(countryCode)
|
||||||
layer.bindTooltip(`<div style="font-size:12px;font-weight:600">${name}</div>`, {
|
layer.bindTooltip(`<div style="font-size:12px;font-weight:600">${name}</div>`, {
|
||||||
sticky: false, className: 'atlas-tooltip', direction: 'top', offset: [0, -10], opacity: 1
|
sticky: true, className: 'atlas-tooltip', direction: 'top', offset: [0, -10], opacity: 1
|
||||||
})
|
})
|
||||||
layer.on('click', () => handleMarkCountry(countryCode, name))
|
layer.on('click', () => handleMarkCountry(countryCode, name))
|
||||||
layer.on('mouseover', (e) => {
|
layer.on('mouseover', (e) => {
|
||||||
@@ -552,6 +559,20 @@ export function useAtlas() {
|
|||||||
} catch (e ) {
|
} catch (e ) {
|
||||||
console.error('Error fitting bounds', e)
|
console.error('Error fitting bounds', e)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Mirror the map-click behaviour so an already-visited country can be removed
|
||||||
|
// straight from search. Tiny countries (Vatican City, Singapore) are hard to
|
||||||
|
// hit on the map, so search was the only way in — but it always opened the
|
||||||
|
// "Mark / Bucket" dialog with no Remove option.
|
||||||
|
const visited = data?.countries.find(c => c.code === country_code)
|
||||||
|
if (visited) {
|
||||||
|
if (visited.placeCount === 0 && visited.tripCount === 0) {
|
||||||
|
handleUnmarkCountry(country_code)
|
||||||
|
} else {
|
||||||
|
loadCountryDetailRef.current(country_code)
|
||||||
|
}
|
||||||
|
return
|
||||||
|
}
|
||||||
setConfirmAction({ type: 'choose', code: country_code, name: country_label })
|
setConfirmAction({ type: 'choose', code: country_code, name: country_label })
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -565,10 +586,12 @@ export function useAtlas() {
|
|||||||
apiClient.post(`/addons/atlas/country/${code}/mark`).catch(() => {})
|
apiClient.post(`/addons/atlas/country/${code}/mark`).catch(() => {})
|
||||||
setData(prev => {
|
setData(prev => {
|
||||||
if (!prev || prev.countries.find(c => c.code === code)) return prev
|
if (!prev || prev.countries.find(c => c.code === code)) return prev
|
||||||
|
const cont = continentForCountry(code)
|
||||||
return {
|
return {
|
||||||
...prev,
|
...prev,
|
||||||
countries: [...prev.countries, { code, placeCount: 0, tripCount: 0, firstVisit: null, lastVisit: null }],
|
countries: [...prev.countries, { code, placeCount: 0, tripCount: 0, firstVisit: null, lastVisit: null }],
|
||||||
stats: { ...prev.stats, totalCountries: prev.stats.totalCountries + 1 },
|
stats: { ...prev.stats, totalCountries: prev.stats.totalCountries + 1 },
|
||||||
|
continents: { ...prev.continents, [cont]: (prev.continents?.[cont] || 0) + 1 },
|
||||||
}
|
}
|
||||||
})
|
})
|
||||||
} else {
|
} else {
|
||||||
@@ -579,10 +602,12 @@ export function useAtlas() {
|
|||||||
if (!prev) return prev
|
if (!prev) return prev
|
||||||
const c = prev.countries.find(c => c.code === code)
|
const c = prev.countries.find(c => c.code === code)
|
||||||
if (!c || c.placeCount > 0 || c.tripCount > 0) return prev
|
if (!c || c.placeCount > 0 || c.tripCount > 0) return prev
|
||||||
|
const cont = continentForCountry(code)
|
||||||
return {
|
return {
|
||||||
...prev,
|
...prev,
|
||||||
countries: prev.countries.filter(c => c.code !== code),
|
countries: prev.countries.filter(c => c.code !== code),
|
||||||
stats: { ...prev.stats, totalCountries: Math.max(0, prev.stats.totalCountries - 1) },
|
stats: { ...prev.stats, totalCountries: Math.max(0, prev.stats.totalCountries - 1) },
|
||||||
|
continents: { ...prev.continents, [cont]: Math.max(0, (prev.continents?.[cont] || 0) - 1) },
|
||||||
}
|
}
|
||||||
})
|
})
|
||||||
setVisitedRegions(prev => {
|
setVisitedRegions(prev => {
|
||||||
|
|||||||
@@ -33,6 +33,7 @@ export function useDashboard() {
|
|||||||
const [deleteTrip, setDeleteTrip] = useState<DashboardTrip | null>(null)
|
const [deleteTrip, setDeleteTrip] = useState<DashboardTrip | null>(null)
|
||||||
const [copyTrip, setCopyTrip] = useState<DashboardTrip | null>(null)
|
const [copyTrip, setCopyTrip] = useState<DashboardTrip | null>(null)
|
||||||
const [tripFilter, setTripFilter] = useState<'planned' | 'archive' | 'completed'>('planned')
|
const [tripFilter, setTripFilter] = useState<'planned' | 'archive' | 'completed'>('planned')
|
||||||
|
const [loadError, setLoadError] = useState<boolean>(false)
|
||||||
|
|
||||||
const [stats, setStats] = useState<TravelStats | null>(null)
|
const [stats, setStats] = useState<TravelStats | null>(null)
|
||||||
const [upcoming, setUpcoming] = useState<UpcomingReservation[]>([])
|
const [upcoming, setUpcoming] = useState<UpcomingReservation[]>([])
|
||||||
@@ -42,7 +43,7 @@ export function useDashboard() {
|
|||||||
const [searchParams, setSearchParams] = useSearchParams()
|
const [searchParams, setSearchParams] = useSearchParams()
|
||||||
const toast = useToast()
|
const toast = useToast()
|
||||||
const { t, locale } = useTranslation()
|
const { t, locale } = useTranslation()
|
||||||
const { demoMode } = useAuthStore()
|
const { demoMode, authCheckFailed, loadUser } = useAuthStore()
|
||||||
|
|
||||||
const toggleViewMode = () => {
|
const toggleViewMode = () => {
|
||||||
setViewMode(prev => {
|
setViewMode(prev => {
|
||||||
@@ -74,13 +75,22 @@ export function useDashboard() {
|
|||||||
const { trips, archivedTrips } = await tripRepo.list()
|
const { trips, archivedTrips } = await tripRepo.list()
|
||||||
setTrips(sortTrips(trips))
|
setTrips(sortTrips(trips))
|
||||||
setArchivedTrips(sortTrips(archivedTrips))
|
setArchivedTrips(sortTrips(archivedTrips))
|
||||||
|
setLoadError(false)
|
||||||
} catch {
|
} catch {
|
||||||
|
setLoadError(true)
|
||||||
toast.error(t('dashboard.toast.loadError'))
|
toast.error(t('dashboard.toast.loadError'))
|
||||||
} finally {
|
} finally {
|
||||||
setIsLoading(false)
|
setIsLoading(false)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Re-run both the trip fetch and the auth check so a recovered backend clears
|
||||||
|
// the error banner (loadUser resets authCheckFailed on success). #1283
|
||||||
|
const retryLoad = () => {
|
||||||
|
loadUser({ silent: true })
|
||||||
|
loadTrips()
|
||||||
|
}
|
||||||
|
|
||||||
const today = new Date().toISOString().split('T')[0]
|
const today = new Date().toISOString().split('T')[0]
|
||||||
const spotlight = trips.find(t => t.start_date && t.end_date && t.start_date <= today && t.end_date >= today)
|
const spotlight = trips.find(t => t.start_date && t.end_date && t.start_date <= today && t.end_date >= today)
|
||||||
|| trips.find(t => t.start_date && t.start_date >= today)
|
|| trips.find(t => t.start_date && t.start_date >= today)
|
||||||
@@ -177,6 +187,7 @@ export function useDashboard() {
|
|||||||
demoMode, locale, t, navigate,
|
demoMode, locale, t, navigate,
|
||||||
// data + derived
|
// data + derived
|
||||||
spotlight, heroBundle, stats, upcoming, gridTrips, isLoading,
|
spotlight, heroBundle, stats, upcoming, gridTrips, isLoading,
|
||||||
|
loadError: loadError || authCheckFailed, retryLoad,
|
||||||
// ui state
|
// ui state
|
||||||
tripFilter, setTripFilter, viewMode, toggleViewMode,
|
tripFilter, setTripFilter, viewMode, toggleViewMode,
|
||||||
showForm, setShowForm, editingTrip, setEditingTrip,
|
showForm, setShowForm, editingTrip, setEditingTrip,
|
||||||
|
|||||||
@@ -37,6 +37,7 @@ export function useLogin() {
|
|||||||
const [username, setUsername] = useState<string>('')
|
const [username, setUsername] = useState<string>('')
|
||||||
const [email, setEmail] = useState<string>('')
|
const [email, setEmail] = useState<string>('')
|
||||||
const [password, setPassword] = useState<string>('')
|
const [password, setPassword] = useState<string>('')
|
||||||
|
const [rememberMe, setRememberMe] = useState<boolean>(false)
|
||||||
const [showPassword, setShowPassword] = useState<boolean>(false)
|
const [showPassword, setShowPassword] = useState<boolean>(false)
|
||||||
const [isLoading, setIsLoading] = useState<boolean>(false)
|
const [isLoading, setIsLoading] = useState<boolean>(false)
|
||||||
const [error, setError] = useState<string>('')
|
const [error, setError] = useState<string>('')
|
||||||
@@ -242,7 +243,7 @@ export function useLogin() {
|
|||||||
setIsLoading(false)
|
setIsLoading(false)
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
const mfaResult = await completeMfaLogin(mfaToken, mfaCode)
|
const mfaResult = await completeMfaLogin(mfaToken, mfaCode, rememberMe)
|
||||||
if ('user' in mfaResult && mfaResult.user?.must_change_password) {
|
if ('user' in mfaResult && mfaResult.user?.must_change_password) {
|
||||||
setSavedLoginPassword(password)
|
setSavedLoginPassword(password)
|
||||||
setPasswordChangeStep(true)
|
setPasswordChangeStep(true)
|
||||||
@@ -258,7 +259,7 @@ export function useLogin() {
|
|||||||
if (password.length < 8) { setError(t('login.passwordMinLength')); setIsLoading(false); return }
|
if (password.length < 8) { setError(t('login.passwordMinLength')); setIsLoading(false); return }
|
||||||
await register(username, email, password, inviteToken || undefined)
|
await register(username, email, password, inviteToken || undefined)
|
||||||
} else {
|
} else {
|
||||||
const result = await login(email, password)
|
const result = await login(email, password, rememberMe)
|
||||||
if ('mfa_required' in result && result.mfa_required && 'mfa_token' in result) {
|
if ('mfa_required' in result && result.mfa_required && 'mfa_token' in result) {
|
||||||
setMfaToken(result.mfa_token)
|
setMfaToken(result.mfa_token)
|
||||||
setMfaStep(true)
|
setMfaStep(true)
|
||||||
@@ -289,7 +290,7 @@ export function useLogin() {
|
|||||||
return {
|
return {
|
||||||
navigate,
|
navigate,
|
||||||
mode, setMode,
|
mode, setMode,
|
||||||
username, setUsername, email, setEmail, password, setPassword, showPassword, setShowPassword,
|
username, setUsername, email, setEmail, password, setPassword, rememberMe, setRememberMe, showPassword, setShowPassword,
|
||||||
isLoading, error, setError, appConfig, inviteToken,
|
isLoading, error, setError, appConfig, inviteToken,
|
||||||
langDropdownOpen, setLangDropdownOpen, setLanguageLocal,
|
langDropdownOpen, setLangDropdownOpen, setLanguageLocal,
|
||||||
showTakeoff, mfaStep, setMfaStep, mfaToken, setMfaToken, mfaCode, setMfaCode,
|
showTakeoff, mfaStep, setMfaStep, mfaToken, setMfaToken, mfaCode, setMfaCode,
|
||||||
|
|||||||
@@ -0,0 +1,25 @@
|
|||||||
|
import { describe, it, expect } from 'vitest'
|
||||||
|
import { resolvePoolAssignmentId } from './tripPlannerModel'
|
||||||
|
import { buildAssignment, buildPlace } from '../../../tests/helpers/factories'
|
||||||
|
|
||||||
|
describe('resolvePoolAssignmentId', () => {
|
||||||
|
it('returns the lone assignment id when the place is assigned to exactly one day', () => {
|
||||||
|
const place = buildPlace({ id: 7 })
|
||||||
|
const assignment = buildAssignment({ id: 42, day_id: 3, place })
|
||||||
|
const assignments = { 3: [assignment], 4: [buildAssignment({ id: 99, day_id: 4 })] }
|
||||||
|
expect(resolvePoolAssignmentId(assignments, 7)).toBe(42)
|
||||||
|
})
|
||||||
|
|
||||||
|
it('returns null when the place is not assigned to any day', () => {
|
||||||
|
const assignments = { 3: [buildAssignment({ id: 99, day_id: 3 })] }
|
||||||
|
expect(resolvePoolAssignmentId(assignments, 7)).toBeNull()
|
||||||
|
})
|
||||||
|
|
||||||
|
it('returns null when the place is assigned to multiple days (ambiguous time)', () => {
|
||||||
|
const assignments = {
|
||||||
|
3: [buildAssignment({ id: 1, day_id: 3, place: buildPlace({ id: 7 }) })],
|
||||||
|
4: [buildAssignment({ id: 2, day_id: 4, place: buildPlace({ id: 7 }) })],
|
||||||
|
}
|
||||||
|
expect(resolvePoolAssignmentId(assignments, 7)).toBeNull()
|
||||||
|
})
|
||||||
|
})
|
||||||
@@ -0,0 +1,24 @@
|
|||||||
|
/**
|
||||||
|
* Trip planner pure helpers — React/IO-free logic shared by the data hook
|
||||||
|
* (useTripPlanner) and kept here so it can be unit-tested in isolation. Part of
|
||||||
|
* the FE "page = wiring container + data hook" convention (see PATTERN.md).
|
||||||
|
*/
|
||||||
|
|
||||||
|
import type { Assignment } from '../../types'
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Resolve the day-assignment to use when a place is edited from the Places pool,
|
||||||
|
* where no day is in context. Times live per day-assignment (#1247), so we can
|
||||||
|
* only hydrate/persist a place's time when it is assigned to exactly one day.
|
||||||
|
* Returns that assignment's id, or null when the place has 0 or 2+ assignments
|
||||||
|
* (ambiguous — the modal then hides the time fields).
|
||||||
|
*/
|
||||||
|
export function resolvePoolAssignmentId(
|
||||||
|
assignments: Record<string | number, Assignment[]>,
|
||||||
|
placeId: number,
|
||||||
|
): number | null {
|
||||||
|
const matches = Object.values(assignments)
|
||||||
|
.flat()
|
||||||
|
.filter((a) => a.place?.id === placeId)
|
||||||
|
return matches.length === 1 ? matches[0].id : null
|
||||||
|
}
|
||||||
@@ -18,6 +18,7 @@ import { usePlaceSelection } from '../../hooks/usePlaceSelection'
|
|||||||
import { usePlannerHistory } from '../../hooks/usePlannerHistory'
|
import { usePlannerHistory } from '../../hooks/usePlannerHistory'
|
||||||
import { useAirtrailConnection } from '../../hooks/useAirtrailConnection'
|
import { useAirtrailConnection } from '../../hooks/useAirtrailConnection'
|
||||||
import type { Accommodation, TripMember, Day, Place, Reservation } from '../../types'
|
import type { Accommodation, TripMember, Day, Place, Reservation } from '../../types'
|
||||||
|
import { resolvePoolAssignmentId } from './tripPlannerModel'
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Trip planner page logic — the big one. Owns the trip store wiring, addon
|
* Trip planner page logic — the big one. Owns the trip store wiring, addon
|
||||||
@@ -221,11 +222,12 @@ export function useTripPlanner() {
|
|||||||
}
|
}
|
||||||
}, [isLoading, places])
|
}, [isLoading, places])
|
||||||
|
|
||||||
// Load trip + files (needed for place inspector file section)
|
// Load the trip. loadTrip hydrates every trip-scoped slice (days, places,
|
||||||
|
// packing, todo, budget, reservations, files) so offline hydration is uniform
|
||||||
|
// and there's no cross-trip bleed; members/accommodations load alongside.
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
if (tripId) {
|
if (tripId) {
|
||||||
tripActions.loadTrip(tripId).catch(() => { toast.error(t('trip.toast.loadError')); navigate('/dashboard') })
|
tripActions.loadTrip(tripId).catch(() => { toast.error(t('trip.toast.loadError')); navigate('/dashboard') })
|
||||||
tripActions.loadFiles(tripId)
|
|
||||||
loadAccommodations()
|
loadAccommodations()
|
||||||
if (!navigator.onLine) {
|
if (!navigator.onLine) {
|
||||||
offlineDb.tripMembers.where('tripId').equals(Number(tripId)).toArray()
|
offlineDb.tripMembers.where('tripId').equals(Number(tripId)).toArray()
|
||||||
@@ -240,13 +242,6 @@ export function useTripPlanner() {
|
|||||||
}
|
}
|
||||||
}, [tripId])
|
}, [tripId])
|
||||||
|
|
||||||
useEffect(() => {
|
|
||||||
if (tripId) {
|
|
||||||
tripActions.loadReservations(tripId)
|
|
||||||
tripActions.loadBudgetItems?.(tripId)
|
|
||||||
}
|
|
||||||
}, [tripId])
|
|
||||||
|
|
||||||
useTripWebSocket(tripId)
|
useTripWebSocket(tripId)
|
||||||
|
|
||||||
const [mapCategoryFilter, setMapCategoryFilter] = useState<Set<string>>(new Set())
|
const [mapCategoryFilter, setMapCategoryFilter] = useState<Set<string>>(new Set())
|
||||||
@@ -294,7 +289,7 @@ export function useTripPlanner() {
|
|||||||
})
|
})
|
||||||
}, [places, mapCategoryFilter, mapPlacesFilter, assignments, expandedDayIds])
|
}, [places, mapCategoryFilter, mapPlacesFilter, assignments, expandedDayIds])
|
||||||
|
|
||||||
const { route, routeSegments, routeInfo, setRoute, setRouteInfo, updateRouteForDay } = useRouteCalculation({ assignments } as any, selectedDayId, routeShown, routeProfile)
|
const { route, routeSegments, routeInfo, setRoute, setRouteInfo, updateRouteForDay } = useRouteCalculation({ assignments } as any, selectedDayId, routeShown, routeProfile, tripAccommodations)
|
||||||
|
|
||||||
const handleSelectDay = useCallback((dayId: number | null, skipFit?: boolean) => {
|
const handleSelectDay = useCallback((dayId: number | null, skipFit?: boolean) => {
|
||||||
const changed = dayId !== selectedDayId
|
const changed = dayId !== selectedDayId
|
||||||
@@ -429,6 +424,16 @@ export function useTripPlanner() {
|
|||||||
}
|
}
|
||||||
}, [editingPlace, editingAssignmentId, tripId, toast, pushUndo])
|
}, [editingPlace, editingAssignmentId, tripId, toast, pushUndo])
|
||||||
|
|
||||||
|
// Open the place editor from any entry point (Places pool, inspector, map).
|
||||||
|
// Times live per day-assignment, so when no day is in context resolve the
|
||||||
|
// place's lone assignment to hydrate & persist its times; with 0 or 2+
|
||||||
|
// assignments the time is ambiguous and the modal hides the fields (#1247).
|
||||||
|
const openPlaceEditor = useCallback((place: Place, preferredAssignmentId: number | null = null) => {
|
||||||
|
setEditingPlace(place)
|
||||||
|
setEditingAssignmentId(preferredAssignmentId ?? resolvePoolAssignmentId(assignments, place.id))
|
||||||
|
setShowPlaceForm(true)
|
||||||
|
}, [assignments])
|
||||||
|
|
||||||
const handleDeletePlace = useCallback((placeId) => {
|
const handleDeletePlace = useCallback((placeId) => {
|
||||||
setDeletePlaceId(placeId)
|
setDeletePlaceId(placeId)
|
||||||
}, [])
|
}, [])
|
||||||
@@ -574,7 +579,12 @@ export function useTripPlanner() {
|
|||||||
const handleSaveReservation = async (data: Record<string, string | number | null> & { title: string }) => {
|
const handleSaveReservation = async (data: Record<string, string | number | null> & { title: string }) => {
|
||||||
try {
|
try {
|
||||||
if (editingReservation) {
|
if (editingReservation) {
|
||||||
const r = await tripActions.updateReservation(tripId, editingReservation.id, { ...data, day_id: selectedDayId || null })
|
// Don't force a day here. The old code pinned it to the (often empty)
|
||||||
|
// selected day, which dropped the booking out of the Plan; preserving the
|
||||||
|
// old day_id instead left it stale when the date changed. Omitting it lets
|
||||||
|
// the server derive the day from the booking's date, or keep the current
|
||||||
|
// one when there is no date.
|
||||||
|
const r = await tripActions.updateReservation(tripId, editingReservation.id, data)
|
||||||
toast.success(t('trip.toast.reservationUpdated'))
|
toast.success(t('trip.toast.reservationUpdated'))
|
||||||
setShowReservationModal(false)
|
setShowReservationModal(false)
|
||||||
setEditingReservation(null)
|
setEditingReservation(null)
|
||||||
@@ -691,7 +701,7 @@ export function useTripPlanner() {
|
|||||||
expandedDayIds, setExpandedDayIds, mapPlaces,
|
expandedDayIds, setExpandedDayIds, mapPlaces,
|
||||||
route, routeSegments, routeInfo, setRoute, setRouteInfo, updateRouteForDay,
|
route, routeSegments, routeInfo, setRoute, setRouteInfo, updateRouteForDay,
|
||||||
handleSelectDay, handlePlaceClick, handleMarkerClick, handleMapClick, handleMapContextMenu, openAddPlaceFromPoi,
|
handleSelectDay, handlePlaceClick, handleMarkerClick, handleMapClick, handleMapContextMenu, openAddPlaceFromPoi,
|
||||||
handleSavePlace, handleDeletePlace, confirmDeletePlace, confirmDeletePlaces,
|
handleSavePlace, openPlaceEditor, handleDeletePlace, confirmDeletePlace, confirmDeletePlaces,
|
||||||
handleAssignToDay, handleRemoveAssignment, handleReorder, handleReorderDays, handleAddDay, handleUpdateDayTitle,
|
handleAssignToDay, handleRemoveAssignment, handleReorder, handleReorderDays, handleAddDay, handleUpdateDayTitle,
|
||||||
handleSaveReservation, handleSaveTransport, handleDeleteReservation,
|
handleSaveReservation, handleSaveTransport, handleDeleteReservation,
|
||||||
selectedPlace, dayOrderMap, dayPlaces,
|
selectedPlace, dayOrderMap, dayPlaces,
|
||||||
|
|||||||
@@ -1,16 +1,20 @@
|
|||||||
import { accommodationsApi } from '../api/client'
|
import { accommodationsApi } from '../api/client'
|
||||||
import { offlineDb, upsertAccommodations } from '../db/offlineDb'
|
import { offlineDb, upsertAccommodations } from '../db/offlineDb'
|
||||||
|
import { onlineThenCache } from './withOfflineFallback'
|
||||||
import type { Accommodation } from '../types'
|
import type { Accommodation } from '../types'
|
||||||
|
|
||||||
export const accommodationRepo = {
|
export const accommodationRepo = {
|
||||||
async list(tripId: number | string): Promise<{ accommodations: Accommodation[] }> {
|
async list(tripId: number | string): Promise<{ accommodations: Accommodation[] }> {
|
||||||
if (!navigator.onLine) {
|
return onlineThenCache(
|
||||||
const accommodations = await offlineDb.accommodations
|
async () => {
|
||||||
.where('trip_id').equals(Number(tripId)).toArray()
|
const result = await accommodationsApi.list(tripId)
|
||||||
return { accommodations }
|
upsertAccommodations(result.accommodations || []).catch(() => {})
|
||||||
}
|
return result
|
||||||
const result = await accommodationsApi.list(tripId)
|
},
|
||||||
upsertAccommodations(result.accommodations || []).catch(() => {})
|
async () => ({
|
||||||
return result
|
accommodations: await offlineDb.accommodations
|
||||||
|
.where('trip_id').equals(Number(tripId)).toArray(),
|
||||||
|
}),
|
||||||
|
)
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,18 +1,20 @@
|
|||||||
import { budgetApi } from '../api/client'
|
import { budgetApi } from '../api/client'
|
||||||
import { offlineDb, upsertBudgetItems } from '../db/offlineDb'
|
import { offlineDb, upsertBudgetItems } from '../db/offlineDb'
|
||||||
|
import { onlineThenCache } from './withOfflineFallback'
|
||||||
import type { BudgetItem } from '../types'
|
import type { BudgetItem } from '../types'
|
||||||
|
|
||||||
export const budgetRepo = {
|
export const budgetRepo = {
|
||||||
async list(tripId: number | string): Promise<{ items: BudgetItem[] }> {
|
async list(tripId: number | string): Promise<{ items: BudgetItem[] }> {
|
||||||
if (!navigator.onLine) {
|
return onlineThenCache(
|
||||||
const cached = await offlineDb.budgetItems
|
async () => {
|
||||||
.where('trip_id')
|
const result = await budgetApi.list(tripId)
|
||||||
.equals(Number(tripId))
|
upsertBudgetItems(result.items)
|
||||||
.toArray()
|
return result
|
||||||
return { items: cached }
|
},
|
||||||
}
|
async () => ({
|
||||||
const result = await budgetApi.list(tripId)
|
items: await offlineDb.budgetItems
|
||||||
upsertBudgetItems(result.items)
|
.where('trip_id').equals(Number(tripId)).toArray(),
|
||||||
return result
|
}),
|
||||||
|
)
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
|
|||||||
+14
-10
@@ -1,18 +1,22 @@
|
|||||||
import { daysApi } from '../api/client'
|
import { daysApi } from '../api/client'
|
||||||
import { offlineDb, upsertDays } from '../db/offlineDb'
|
import { offlineDb, upsertDays } from '../db/offlineDb'
|
||||||
|
import { onlineThenCache } from './withOfflineFallback'
|
||||||
import type { Day } from '../types'
|
import type { Day } from '../types'
|
||||||
|
|
||||||
export const dayRepo = {
|
export const dayRepo = {
|
||||||
async list(tripId: number | string): Promise<{ days: Day[] }> {
|
async list(tripId: number | string): Promise<{ days: Day[] }> {
|
||||||
if (!navigator.onLine) {
|
return onlineThenCache(
|
||||||
const cached = await offlineDb.days
|
async () => {
|
||||||
.where('trip_id')
|
const result = await daysApi.list(tripId)
|
||||||
.equals(Number(tripId))
|
upsertDays(result.days)
|
||||||
.sortBy('day_number' as keyof Day)
|
return result
|
||||||
return { days: cached as Day[] }
|
},
|
||||||
}
|
async () => ({
|
||||||
const result = await daysApi.list(tripId)
|
days: (await offlineDb.days
|
||||||
upsertDays(result.days)
|
.where('trip_id')
|
||||||
return result
|
.equals(Number(tripId))
|
||||||
|
.sortBy('day_number' as keyof Day)) as Day[],
|
||||||
|
}),
|
||||||
|
)
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
|
|||||||
+12
-10
@@ -1,18 +1,20 @@
|
|||||||
import { filesApi } from '../api/client'
|
import { filesApi } from '../api/client'
|
||||||
import { offlineDb, upsertTripFiles } from '../db/offlineDb'
|
import { offlineDb, upsertTripFiles } from '../db/offlineDb'
|
||||||
|
import { onlineThenCache } from './withOfflineFallback'
|
||||||
import type { TripFile } from '../types'
|
import type { TripFile } from '../types'
|
||||||
|
|
||||||
export const fileRepo = {
|
export const fileRepo = {
|
||||||
async list(tripId: number | string): Promise<{ files: TripFile[] }> {
|
async list(tripId: number | string): Promise<{ files: TripFile[] }> {
|
||||||
if (!navigator.onLine) {
|
return onlineThenCache(
|
||||||
const cached = await offlineDb.tripFiles
|
async () => {
|
||||||
.where('trip_id')
|
const result = await filesApi.list(tripId)
|
||||||
.equals(Number(tripId))
|
upsertTripFiles(result.files)
|
||||||
.toArray()
|
return result
|
||||||
return { files: cached }
|
},
|
||||||
}
|
async () => ({
|
||||||
const result = await filesApi.list(tripId)
|
files: await offlineDb.tripFiles
|
||||||
upsertTripFiles(result.files)
|
.where('trip_id').equals(Number(tripId)).toArray(),
|
||||||
return result
|
}),
|
||||||
|
)
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
|
|||||||
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user