mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-06-29 10:11:46 +00:00
Maurice
0b2780ead2
The Places API googleMapsUri is a cid-style URL with no ftid, so the search/getPlaceDetails fixtures had stored a fabricated ftid. Switch them to real cid URLs and assert google_ftid is null — the precise query_place_id link still fixes the wrong-spot bug — and document the behaviour on googleFtidFromMapsUrl. - add a direct googleFtidFromMapsUrl test: extracts a real /place ftid, returns null for a cid URL, rejects malformed/hostile values - add placeGoogleMaps.test.ts covering the whole fallback chain (ftid -> place_id -> details URL -> coords) and the hostile-ftid rejection - PlaceInspector: use a freshly-fetched ftid when the place hasn't stored one
37 lines
1.8 KiB
TypeScript
37 lines
1.8 KiB
TypeScript
import { describe, it, expect } from 'vitest'
|
|
import { getGoogleMapsUrlForPlace } from './placeGoogleMaps'
|
|
|
|
const base = { name: 'Eiffel Tower', lat: 48.8584, lng: 2.2945, google_place_id: null, google_ftid: null } as any
|
|
|
|
describe('getGoogleMapsUrlForPlace', () => {
|
|
it('FE-PLACE-GMAPS-001: uses a valid ftid for a precise /place link', () => {
|
|
const url = getGoogleMapsUrlForPlace({ ...base, google_ftid: '0x47e66e2964e34e2d:0x8ddca9ee380ef7e0' })
|
|
expect(url).toBe('https://www.google.com/maps/place/?q=Eiffel%20Tower&ftid=0x47e66e2964e34e2d:0x8ddca9ee380ef7e0')
|
|
})
|
|
|
|
it('FE-PLACE-GMAPS-002: falls back to query_place_id when there is no ftid', () => {
|
|
const url = getGoogleMapsUrlForPlace({ ...base, google_place_id: 'ChIJ123' })
|
|
expect(url).toBe('https://www.google.com/maps/search/?api=1&query=Eiffel%20Tower&query_place_id=ChIJ123')
|
|
})
|
|
|
|
it('FE-PLACE-GMAPS-003: ignores a malformed/hostile ftid and falls through to the place id', () => {
|
|
const url = getGoogleMapsUrlForPlace({ ...base, google_ftid: '0xAB&q=evil', google_place_id: 'ChIJ123' })
|
|
expect(url).toBe('https://www.google.com/maps/search/?api=1&query=Eiffel%20Tower&query_place_id=ChIJ123')
|
|
})
|
|
|
|
it('FE-PLACE-GMAPS-004: uses the details URL when there is no ftid or place id', () => {
|
|
const url = getGoogleMapsUrlForPlace(base, 'https://maps.google.com/?cid=123')
|
|
expect(url).toBe('https://maps.google.com/?cid=123')
|
|
})
|
|
|
|
it('FE-PLACE-GMAPS-005: falls back to coordinates as a last resort', () => {
|
|
const url = getGoogleMapsUrlForPlace(base)
|
|
expect(url).toBe('https://www.google.com/maps/search/?api=1&query=48.8584,2.2945')
|
|
})
|
|
|
|
it('FE-PLACE-GMAPS-006: returns null for no place or no location', () => {
|
|
expect(getGoogleMapsUrlForPlace(null)).toBeNull()
|
|
expect(getGoogleMapsUrlForPlace({ ...base, lat: null, lng: null })).toBeNull()
|
|
})
|
|
})
|