Files
TREK/server/tests/unit/scripts/size-lint.test.ts
T
Maurice 809ec386fc ci(server): fail lint:size and lint:boundaries on stale baseline entries
Both server ratchets only logged an entry the tree had moved past. A
file that shrank could grow back to its old size entry unseen, a
deleted file left its allowance to the next file at its path, and a
boundary violation that was fixed stayed allowed until someone ran
--update. The client ratchets now fail on such entries, so the server
ones do the same.

lint:size fails on an entry above its file's size or for a file that is
gone, and lint:boundaries on an entry that no longer occurs; both tell
to run --update, which still only lowers or drops. Both baselines match
the tree today.
2026-10-08 14:11:54 +02:00

166 lines
6.9 KiB
TypeScript

/**
* scripts/size-lint.mjs is the CI gate that keeps a server source file from
* growing past 1000 lines (or past its baseline entry). A gate nobody tests
* passes forever once it breaks, so this runs the real script as a child
* process against throwaway server roots (--dir) and proves both that it
* fails on a violation and that it refuses to run on a broken setup instead
* of passing silently.
*/
import { execFileSync } from 'node:child_process';
import { mkdirSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from 'node:fs';
import { tmpdir } from 'node:os';
import path from 'node:path';
import { afterEach, describe, expect, it } from 'vitest';
const SCRIPT = path.join(__dirname, '../../../scripts/size-lint.mjs');
interface ExecError {
status: number | null;
stdout: string;
stderr: string;
}
const roots: string[] = [];
function serverRoot(files: Record<string, string>, baseline: unknown = {}): string {
// null writes no baseline file at all.
const dir = mkdtempSync(path.join(tmpdir(), 'trek-size-lint-'));
roots.push(dir);
mkdirSync(path.join(dir, 'src'), { recursive: true });
mkdirSync(path.join(dir, 'scripts'), { recursive: true });
for (const [file, text] of Object.entries(files)) {
mkdirSync(path.dirname(path.join(dir, file)), { recursive: true });
writeFileSync(path.join(dir, file), text);
}
if (baseline !== null) {
writeFileSync(
path.join(dir, 'scripts/size-baseline.json'),
typeof baseline === 'string' ? baseline : JSON.stringify(baseline),
);
}
return dir;
}
function run(dir: string, ...args: string[]): { status: number | null; out: string } {
try {
const stdout = execFileSync(process.execPath, [SCRIPT, `--dir=${dir}`, ...args], {
encoding: 'utf8',
stdio: ['ignore', 'pipe', 'pipe'],
});
return { status: 0, out: stdout };
} catch (err) {
const { status, stdout, stderr } = err as ExecError;
return { status, out: `${stdout}${stderr}` };
}
}
const lines = (n: number, width = 10) => `${'x'.repeat(width)}\n`.repeat(n);
afterEach(() => {
for (const dir of roots.splice(0)) rmSync(dir, { recursive: true, force: true });
});
describe('size-lint.mjs', () => {
it('SIZE-001: passes when every file is at or under the limit', () => {
const dir = serverRoot({ 'src/a.ts': lines(1000), 'scripts/b.mjs': lines(10) });
const { status, out } = run(dir);
expect(status).toBe(0);
expect(out).toContain('size: 2 file(s), 0 over 1000 lines');
});
it('SIZE-002: fails on a new file past the limit', () => {
const dir = serverRoot({ 'src/nest/big/big.service.ts': lines(1001) });
const { status, out } = run(dir);
expect(status).toBe(1);
expect(out).toContain('FAIL src/nest/big/big.service.ts: 1001 lines, the limit is 1000.');
});
it('SIZE-003: fails when a baselined file grows past its entry, passes at it', () => {
expect(run(serverRoot({ 'src/a.ts': lines(1201) }, { 'src/a.ts': 1200 })).status).toBe(1);
expect(run(serverRoot({ 'src/a.ts': lines(1200) }, { 'src/a.ts': 1200 })).status).toBe(0);
});
it('SIZE-010: fails an entry above its file, or for a file that is gone, until --update lowers it', () => {
const shrunk = run(serverRoot({ 'src/a.ts': lines(1100) }, { 'src/a.ts': 1200 }));
expect(shrunk.status).toBe(1);
expect(shrunk.out).toContain(
'FAIL src/a.ts is held at 1200 in scripts/size-baseline.json, but it has 1100 lines now.',
);
expect(shrunk.out).toContain('npm run lint:size -- --update');
// Back under the limit, the entry would let it grow past the limit again.
expect(run(serverRoot({ 'src/a.ts': lines(900) }, { 'src/a.ts': 1200 })).status).toBe(1);
// A deleted file would hand its allowance to the next file at its path.
const gone = run(serverRoot({ 'src/b.ts': lines(1) }, { 'src/a.ts': 1200 }));
expect(gone.status).toBe(1);
expect(gone.out).toContain('FAIL src/a.ts is held at 1200 in scripts/size-baseline.json, but the file is gone.');
const dir = serverRoot({ 'src/a.ts': lines(1100) }, { 'src/a.ts': 1200, 'src/gone.ts': 1300 });
expect(run(dir, '--update').status).toBe(0);
expect(run(dir).status).toBe(0);
});
it('SIZE-004: counts a long line once per 120 columns, so joining lines buys nothing', () => {
// 400 lines of 300 columns read like 1200 lines.
const { status, out } = run(serverRoot({ 'src/dense.ts': lines(400, 300) }));
expect(status).toBe(1);
expect(out).toContain('src/dense.ts: 1200 lines');
// Exactly 120 columns is still one line.
expect(run(serverRoot({ 'src/edge.ts': lines(1000, 120) })).status).toBe(0);
});
it('SIZE-005: a CRLF checkout counts the same as an LF one', () => {
const crlf = lines(1001).replace(/\n/g, '\r\n');
const { out } = run(serverRoot({ 'src/a.ts': crlf }));
expect(out).toContain('src/a.ts: 1001 lines');
});
it('SIZE-006: skips tests and non-source files, walks scripts/ as well as src/', () => {
const dir = serverRoot({
'src/a.test.ts': lines(2000),
'src/notes.md': lines(2000),
'scripts/tool.mjs': lines(1001),
});
const { status, out } = run(dir);
expect(status).toBe(1);
expect(out).toContain('scripts/tool.mjs');
expect(out).not.toContain('a.test.ts');
});
it('SIZE-007: fails closed on a missing, unparsable or malformed baseline', () => {
const missing = serverRoot({ 'src/a.ts': lines(1) }, null);
expect(run(missing).status).toBe(1);
expect(run(missing).out).toContain('size-baseline.json cannot be read');
expect(run(serverRoot({ 'src/a.ts': lines(1) }, '{ not json')).status).toBe(1);
expect(run(serverRoot({ 'src/a.ts': lines(1) }, '[]')).status).toBe(1);
// An entry at or under the limit, or not a whole number, is a hand edit gone wrong.
expect(run(serverRoot({ 'src/a.ts': lines(1) }, { 'src/a.ts': 900 })).status).toBe(1);
expect(run(serverRoot({ 'src/a.ts': lines(1) }, { 'src/a.ts': '1200' })).status).toBe(1);
});
it('SIZE-008: fails closed when a scanned root is missing', () => {
const dir = serverRoot({ 'src/a.ts': lines(1) });
rmSync(path.join(dir, 'src'), { recursive: true });
const { status, out } = run(dir);
expect(status).toBe(1);
expect(out).toContain('src/ does not exist');
});
it('SIZE-009: --update only lowers, drops files back under the limit, and never adds one', () => {
const dir = serverRoot(
{
'src/shrunk.ts': lines(1100),
'src/fixed.ts': lines(50),
'src/grown.ts': lines(1500),
'src/new.ts': lines(1300),
},
{ 'src/shrunk.ts': 1200, 'src/fixed.ts': 1300, 'src/grown.ts': 1400, 'src/gone.ts': 1100 },
);
const { status } = run(dir, '--update');
const baseline: unknown = JSON.parse(readFileSync(path.join(dir, 'scripts/size-baseline.json'), 'utf8'));
expect(baseline).toEqual({ 'src/grown.ts': 1400, 'src/shrunk.ts': 1100 });
// The grown file and the new one still fail after the update.
expect(status).toBe(1);
});
});