mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-10-21 22:46:32 +00:00
Maurice
8bd831238d
The lease heartbeat and settle failures, the log sink and rotation fallbacks, the runtime env getters, the public API summary edges, the admin-only permission level and the WebSocket handler rejection had no spec, which took six domains under their coverage floor.
84 lines
3.9 KiB
TypeScript
84 lines
3.9 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest';
|
|
import type { TrekWsPayload, TrekWsUserEventName } from '@trek/shared';
|
|
|
|
const { broadcast, broadcastToUser, getOnlineUserIds } = vi.hoisted(() => ({
|
|
broadcast: vi.fn(),
|
|
broadcastToUser: vi.fn(),
|
|
getOnlineUserIds: vi.fn(),
|
|
}));
|
|
vi.mock('../../../src/websocket', () => ({ broadcast, broadcastToUser, getOnlineUserIds }));
|
|
|
|
import { RealtimeService } from '../../../src/nest/realtime/realtime.service';
|
|
|
|
const svc = new RealtimeService();
|
|
|
|
/**
|
|
* These cases exercise argument pass-through, not payload shape, so they hand
|
|
* the facade only the fields their assertions read. The registry contract asks
|
|
* for more (`vacay:invite` for a `from`, `notification:new` for a
|
|
* `notification`); filling that in would put data into the recorded call that
|
|
* nothing here checks, so the shortcut is named instead of padded out.
|
|
*/
|
|
function partialUserPayload<E extends TrekWsUserEventName>(
|
|
payload: { type: E } & Partial<TrekWsPayload<E>>,
|
|
): { type: E } & TrekWsPayload<E> {
|
|
return payload as { type: E } & TrekWsPayload<E>;
|
|
}
|
|
|
|
beforeEach(() => vi.clearAllMocks());
|
|
|
|
describe('RealtimeService', () => {
|
|
it('broadcast delegates every argument to the websocket module untouched', () => {
|
|
svc.broadcast('7', 'place:created', { place: { id: 1 } }, '42', 9);
|
|
expect(broadcast).toHaveBeenCalledTimes(1);
|
|
expect(broadcast).toHaveBeenCalledWith('7', 'place:created', { place: { id: 1 } }, '42', 9);
|
|
});
|
|
|
|
it('broadcast preserves the caller argument arity exactly (no undefined padding)', () => {
|
|
// The excludeSid truthiness quirk and onlyUserId `!= null` check live in
|
|
// websocket.ts — the facade must not normalize, default, or pad anything
|
|
// on the way through: existing suites assert exact 3/4/5-arg call shapes.
|
|
svc.broadcast(7, 'day:updated', { day: null });
|
|
expect(broadcast.mock.calls[0]).toEqual([7, 'day:updated', { day: null }]);
|
|
svc.broadcast(7, 'day:updated', { day: null }, undefined);
|
|
expect(broadcast.mock.calls[1]).toEqual([7, 'day:updated', { day: null }, undefined]);
|
|
expect(broadcast.mock.calls[1].length).toBe(4);
|
|
});
|
|
|
|
it('broadcastToUser delegates every argument untouched', () => {
|
|
const payload = partialUserPayload({ type: 'vacay:invite', planId: 3 });
|
|
svc.broadcastToUser(5, payload, '11');
|
|
expect(broadcastToUser).toHaveBeenCalledTimes(1);
|
|
expect(broadcastToUser).toHaveBeenCalledWith(5, payload, '11');
|
|
// Same object reference — the facade must not clone or re-envelope.
|
|
expect(broadcastToUser.mock.calls[0][1]).toBe(payload);
|
|
});
|
|
|
|
it('per-file vi.mock of src/websocket flows through the facade (call-time delegation)', () => {
|
|
// The 106 existing suites mock src/websocket by path and assert on those
|
|
// mocks; this pins that a facade constructed before/after the mock still
|
|
// routes through the mocked module functions rather than captured bindings.
|
|
const late = new RealtimeService();
|
|
late.broadcast('1', 'todo:created', { item: {} }, undefined);
|
|
late.broadcastToUser(2, partialUserPayload({ type: 'notification:new' }));
|
|
expect(broadcast).toHaveBeenCalledWith('1', 'todo:created', { item: {} }, undefined);
|
|
expect(broadcastToUser).toHaveBeenCalledWith(2, { type: 'notification:new' });
|
|
});
|
|
|
|
it('RTSVC-005: getOnlineUserIds hands back the live set from the websocket module, read at call time', () => {
|
|
const online = new Set([3, 8]);
|
|
getOnlineUserIds.mockReturnValueOnce(online);
|
|
expect(svc.getOnlineUserIds()).toBe(online);
|
|
getOnlineUserIds.mockReturnValueOnce(new Set());
|
|
expect(svc.getOnlineUserIds().size).toBe(0);
|
|
expect(getOnlineUserIds).toHaveBeenCalledTimes(2);
|
|
});
|
|
|
|
it('RTSVC-006: getOnlineUserIds is not guarded, so a failure reaches the caller instead of reading as nobody online', () => {
|
|
getOnlineUserIds.mockImplementationOnce(() => {
|
|
throw new Error('socket server not ready');
|
|
});
|
|
expect(() => svc.getOnlineUserIds()).toThrow('socket server not ready');
|
|
});
|
|
});
|