mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-11-20 19:16:08 +00:00
a77705984e
With TREK_DB_URL set, TREK now boots on Postgres; without it nothing changes. - The database engine contract gains open, close, reopen and the schema bootstrap; DatabaseLifecycle delegates to the engine resolveEngine() picks. - An empty Postgres database gets server/assets/postgres/baseline.sql (generated from the entities by gen:pg-baseline, with the reference rows the migrations up to its cut insert: tour types, provider catalogues, addons, app settings) and every migration up to its cut recorded as executed, in one transaction. A database holding tables without TREK's history is refused before anything is written; a migrated one runs the newer-database refusal and its pending migrations, which refuse without a copy unless TREK_DB_PRE_MIGRATE_SNAPSHOT=false. - INTEGER columns are bigint on Postgres (SQLite's INTEGER is 64-bit: an epoch-millisecond column overflowed int4), and the engine's driver reads bigint and numeric back as numbers, refusing values past 2^53. - The two SQLite triggers are ported to PL/pgSQL; check:pg-baseline fails while a SQLite trigger has no port, and while the baseline drifts from the entities before a later migration freezes it. - Backups and restores on Postgres refuse until they can dump and load one. - Migration helpers read the catalog per engine (dialect/catalog.ts), and the email case index no longer needs group_concat. - CI runs check:pg-baseline and boots the image on postgres:17 twice.
96 lines
4.3 KiB
TypeScript
96 lines
4.3 KiB
TypeScript
/**
|
|
* How the entities' schema is written in Postgres
|
|
* (src/db/engine/postgres/schema-adjust.ts): SQLite-only defaults, TEXT timestamps, the
|
|
* NOCASE collation, and splitting the generated DDL so one refused statement
|
|
* does not take the rest with it.
|
|
*/
|
|
import {
|
|
adjustColumns,
|
|
NOCASE_COLLATION_SQL,
|
|
PG_NOW_TEXT_DEFAULT,
|
|
portableDefault,
|
|
POSTGRES_TRIGGERS,
|
|
splitStatements,
|
|
type ColumnMeta,
|
|
} from '../../../../../src/db/engine/postgres/schema-adjust';
|
|
|
|
import { describe, expect, it } from 'vitest';
|
|
|
|
class DbTimestampType {}
|
|
class TextType {}
|
|
|
|
describe('pg-probe schema', () => {
|
|
it('PGPROBE-040: maps the SQLite clock defaults and leaves every other default alone', () => {
|
|
expect(PG_NOW_TEXT_DEFAULT).toBe("to_char((CURRENT_TIMESTAMP AT TIME ZONE 'UTC'), 'YYYY-MM-DD HH24:MI:SS')");
|
|
expect(portableDefault('CURRENT_TIMESTAMP')).toBe(PG_NOW_TEXT_DEFAULT);
|
|
expect(portableDefault("(datetime('now'))")).toBe(PG_NOW_TEXT_DEFAULT);
|
|
expect(portableDefault("datetime( 'now' )")).toBe(PG_NOW_TEXT_DEFAULT);
|
|
expect(portableDefault("(strftime('%s','now'))")).toBe('CAST(EXTRACT(EPOCH FROM CURRENT_TIMESTAMP) AS bigint)');
|
|
for (const kept of ['0', '1', 'NULL', "'none'", "'#10b981'", "'{}'"]) expect(portableDefault(kept)).toBe(kept);
|
|
});
|
|
|
|
it('PGPROBE-041: makes timestamp columns text, rewrites defaults and the NOCASE collation, and names what it changed', () => {
|
|
const columns: ColumnMeta[] = [
|
|
{
|
|
name: 'created_at',
|
|
customType: new DbTimestampType(),
|
|
columnTypes: ['timestamptz'],
|
|
defaultRaw: 'CURRENT_TIMESTAMP',
|
|
},
|
|
{ name: 'title', customType: new TextType(), columnTypes: ['text'], defaultRaw: "'x'" },
|
|
{ name: 'stamp', columnTypes: ['int'], defaultRaw: "(strftime('%s','now'))" },
|
|
{ name: 'region', columnTypes: ['text'], collation: 'NOCASE' },
|
|
{ name: 'body', columnTypes: ['text'] },
|
|
];
|
|
expect(adjustColumns(columns)).toEqual(['created_at', 'stamp', 'region']);
|
|
expect(columns[0]).toMatchObject({ columnTypes: ['text'], defaultRaw: PG_NOW_TEXT_DEFAULT });
|
|
expect(columns[1]).toMatchObject({ columnTypes: ['text'], defaultRaw: "'x'" });
|
|
expect(columns[2]).toMatchObject({
|
|
columnTypes: ['bigint'],
|
|
defaultRaw: 'CAST(EXTRACT(EPOCH FROM CURRENT_TIMESTAMP) AS bigint)',
|
|
});
|
|
expect(columns[3]).toMatchObject({ collation: 'nocase' });
|
|
expect(NOCASE_COLLATION_SQL).toContain('CREATE COLLATION IF NOT EXISTS nocase');
|
|
});
|
|
|
|
it('PGPROBE-043: an integer column is bigint, as wide as SQLite INTEGER (epoch milliseconds overflow integer)', () => {
|
|
const columns: ColumnMeta[] = [
|
|
{ name: 'id', columnTypes: ['integer'] },
|
|
{ name: 'next_run_at', columnTypes: ['int'] },
|
|
{ name: 'enabled', columnTypes: ['boolean'] },
|
|
{ name: 'note', columnTypes: ['text'] },
|
|
];
|
|
expect(adjustColumns(columns)).toEqual(['id', 'next_run_at']);
|
|
expect(columns.map((column) => column.columnTypes)).toEqual([['bigint'], ['bigint'], ['boolean'], ['text']]);
|
|
});
|
|
|
|
it('PGPROBE-042: splits DDL on semicolons outside quotes and drops session settings', () => {
|
|
const ddl = [
|
|
"set names 'utf8';",
|
|
'create table "a" ("id" serial primary key, "note" text default \'a;b\');',
|
|
'create index "a_x" on "a" ("note") where "note" <> \';\';',
|
|
'',
|
|
'create table "b ;" ("id" int)',
|
|
].join('\n');
|
|
expect(splitStatements(ddl)).toEqual([
|
|
'create table "a" ("id" serial primary key, "note" text default \'a;b\')',
|
|
'create index "a_x" on "a" ("note") where "note" <> \';\'',
|
|
'create table "b ;" ("id" int)',
|
|
]);
|
|
expect(splitStatements(' ; ; ')).toEqual([]);
|
|
});
|
|
|
|
it('PGPROBE-044: a $$ body stays one statement, semicolons and all, and every trigger port splits into its two', () => {
|
|
const fn =
|
|
"CREATE FUNCTION f() RETURNS trigger LANGUAGE plpgsql AS $$\nBEGIN\n UPDATE t SET x = ';';\n RETURN NEW;\nEND\n$$";
|
|
expect(splitStatements(`${fn};\nCREATE TRIGGER g AFTER UPDATE ON t FOR EACH ROW EXECUTE FUNCTION f();`)).toEqual([
|
|
fn,
|
|
'CREATE TRIGGER g AFTER UPDATE ON t FOR EACH ROW EXECUTE FUNCTION f()',
|
|
]);
|
|
for (const [name, statements] of Object.entries(POSTGRES_TRIGGERS)) {
|
|
expect(splitStatements(statements.join(';\n')), name).toEqual([...statements]);
|
|
expect(statements.at(-1), name).toContain(`CREATE TRIGGER ${name} `);
|
|
}
|
|
});
|
|
});
|