mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-10-19 13:36:48 +00:00
Maurice
2a88b0c711
Security that ships from the install itself, no self-hoster setup: - Egress SSRF/rebinding backstop: the net.Socket connect guard now RESOLVES the destination and refuses private/loopback/link-local/metadata/CGNAT/ULA addresses, pinning the resolved IP (a declared host that re-resolves to an internal address is blocked). Pure policy in egress-policy.ts + tests. TREK_PLUGIN_ALLOW_PRIVATE_EGRESS=on opts back into internal targets. - RSS memory reaper: the supervisor now kills a child that blows a real RSS ceiling (TREK_PLUGIN_MAX_RSS_MB, default 300) — --max-old-space-size only bounds the V8 heap, so Buffers could OOM the box under it. - Hash-chained capability audit log (migration 159): every core-data / broadcast call is recorded at the RPC boundary with the host-bound acting user and a per-plugin hash chain, so wide grants stay attributable + tamper-evident. Admin endpoint GET /api/admin/plugins/:id/audit. - Drop allow-popups from the plugin frame (sandbox + CSP): window.open ignores connect-src, so it was an egress/phishing bypass. Server suite 207 green, client + migration reconciliation green.
88 lines
3.5 KiB
TypeScript
88 lines
3.5 KiB
TypeScript
/**
|
|
* The sandboxed plugin frame server (#plugins, M3): serves a plugin's client/
|
|
* assets with a locked-down per-frame CSP and a strict path guard, only when the
|
|
* plugin is active and the runtime is enabled.
|
|
*/
|
|
import { describe, it, expect, beforeAll, afterAll, vi } from 'vitest';
|
|
import fs from 'node:fs';
|
|
import os from 'node:os';
|
|
import path from 'node:path';
|
|
|
|
const { pluginsEnabledMock } = vi.hoisted(() => ({ pluginsEnabledMock: vi.fn(() => true) }));
|
|
vi.mock('../../../src/nest/plugins/kill-switch', () => ({ pluginsEnabled: pluginsEnabledMock }));
|
|
|
|
import { PluginFrameController } from '../../../src/nest/plugins/plugin-frame.controller';
|
|
import type { PluginRuntimeService } from '../../../src/nest/plugins/plugin-runtime.service';
|
|
|
|
let codeRoot: string;
|
|
beforeAll(() => {
|
|
codeRoot = fs.mkdtempSync(path.join(os.tmpdir(), 'trekplug-frame-'));
|
|
process.env.TREK_PLUGINS_DIR = codeRoot;
|
|
const dir = path.join(codeRoot, 'widget', 'client');
|
|
fs.mkdirSync(dir, { recursive: true });
|
|
fs.writeFileSync(path.join(dir, 'index.html'), '<!doctype html><body>hi</body>');
|
|
});
|
|
afterAll(() => {
|
|
delete process.env.TREK_PLUGINS_DIR;
|
|
fs.rmSync(codeRoot, { recursive: true, force: true });
|
|
});
|
|
|
|
function fakeRes() {
|
|
const res = {
|
|
statusCode: 0,
|
|
headers: {} as Record<string, string>,
|
|
sent: undefined as unknown,
|
|
filePath: undefined as string | undefined,
|
|
status(c: number) { res.statusCode = c; return res; },
|
|
setHeader(k: string, v: string) { res.headers[k] = v; },
|
|
send(b: unknown) { res.sent = b; return res; },
|
|
sendFile(p: string) { res.filePath = p; res.statusCode ||= 200; },
|
|
};
|
|
return res;
|
|
}
|
|
const req = (p: string) => ({ params: { path: p } }) as never;
|
|
|
|
function runtime(active = true, hosts: string[] = []): PluginRuntimeService {
|
|
return { isActive: vi.fn(() => active), outboundHostsOf: vi.fn(() => hosts) } as unknown as PluginRuntimeService;
|
|
}
|
|
|
|
describe('PluginFrameController', () => {
|
|
it('serves index.html with the opaque-frame CSP + sandbox', () => {
|
|
const res = fakeRes();
|
|
new PluginFrameController(runtime(true, ['api.weather.com'])).serve('widget', req(''), res as never);
|
|
expect(res.filePath).toContain(path.join('widget', 'client', 'index.html'));
|
|
const csp = res.headers['Content-Security-Policy'];
|
|
expect(csp).toContain("default-src 'none'");
|
|
expect(csp).toContain('sandbox allow-scripts allow-forms');
|
|
expect(csp).not.toContain('allow-popups');
|
|
expect(csp).not.toContain('allow-same-origin');
|
|
expect(csp).toContain('connect-src \'self\' https://api.weather.com');
|
|
expect(res.headers['X-Content-Type-Options']).toBe('nosniff');
|
|
});
|
|
|
|
it('404 when the plugin is inactive', () => {
|
|
const res = fakeRes();
|
|
new PluginFrameController(runtime(false)).serve('widget', req(''), res as never);
|
|
expect(res.statusCode).toBe(404);
|
|
});
|
|
|
|
it('404 when the runtime is disabled', () => {
|
|
pluginsEnabledMock.mockReturnValueOnce(false);
|
|
const res = fakeRes();
|
|
new PluginFrameController(runtime(true)).serve('widget', req(''), res as never);
|
|
expect(res.statusCode).toBe(404);
|
|
});
|
|
|
|
it('403 on a path-traversal attempt', () => {
|
|
const res = fakeRes();
|
|
new PluginFrameController(runtime(true)).serve('widget', req('../../../etc/passwd'), res as never);
|
|
expect(res.statusCode).toBe(403);
|
|
});
|
|
|
|
it('404 for a missing file', () => {
|
|
const res = fakeRes();
|
|
new PluginFrameController(runtime(true)).serve('widget', req('missing.js'), res as never);
|
|
expect(res.statusCode).toBe(404);
|
|
});
|
|
});
|