mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-06-19 13:21:46 +00:00
jubnl
028e3e0a84
The nightly cleanup deleted idempotency keys older than 24h. The TREK client replays queued mutations with their X-Idempotency-Key on reconnect, so a device offline longer than a day had its keys GC'd before it returned — the replayed POST was then treated as new and created a duplicate. - raise the TTL to 30 days (DEFAULT_IDEMPOTENCY_TTL_SECONDS), overridable via IDEMPOTENCY_TTL_SECONDS - extract purgeExpiredIdempotencyKeys(now, ttl, db) (mirrors cleanupOldBackups) with an injectable db, and have the cron job call it - tests: 30-day default eviction, 25-day key retained (was dropped at 24h), env override H7 (exactly-once across the lost-response window) is deferred: a correct fix must store the response in the same DB transaction as the entity write. Doing it in the generic interceptor (reserve-before-handler) cannot store the real response body for the crash case, which would break the client's temp->real id remapping on replay (mutationQueue.flush relies on the entity in the body). It needs a per-service change and is tracked separately.
59 lines
2.2 KiB
TypeScript
59 lines
2.2 KiB
TypeScript
/**
|
|
* Idempotency key TTL cleanup (H6).
|
|
*
|
|
* The TREK client replays queued mutations with their X-Idempotency-Key on
|
|
* reconnect, so the server must keep keys long enough to cover a realistic
|
|
* offline window — otherwise a key GC'd before the device returns lets the
|
|
* replay create a duplicate. The TTL was raised from 24h to 30d (overridable).
|
|
*/
|
|
import { describe, it, expect, beforeEach, afterEach } from 'vitest';
|
|
import { db } from '../../src/db/database';
|
|
import { purgeExpiredIdempotencyKeys } from '../../src/scheduler';
|
|
|
|
const DAY = 24 * 60 * 60;
|
|
const NOW = 2_000_000_000_000; // fixed ms so the test is deterministic
|
|
const NOW_SEC = Math.floor(NOW / 1000);
|
|
|
|
function insertKey(key: string, ageSeconds: number): void {
|
|
db.prepare(
|
|
`INSERT INTO idempotency_keys (key, user_id, method, path, status_code, response_body, created_at)
|
|
VALUES (?, 1, 'POST', '/x', 200, '{}', ?)`,
|
|
).run(key, NOW_SEC - ageSeconds);
|
|
}
|
|
|
|
beforeEach(() => {
|
|
db.pragma('foreign_keys = OFF'); // fixtures reference a user we don't seed here
|
|
db.prepare('DELETE FROM idempotency_keys').run();
|
|
});
|
|
|
|
afterEach(() => {
|
|
db.prepare('DELETE FROM idempotency_keys').run();
|
|
db.pragma('foreign_keys = ON');
|
|
delete process.env.IDEMPOTENCY_TTL_SECONDS;
|
|
});
|
|
|
|
describe('purgeExpiredIdempotencyKeys', () => {
|
|
it('removes keys older than the 30-day default, keeps recent ones', () => {
|
|
insertKey('old', 31 * DAY);
|
|
insertKey('fresh', 5 * DAY);
|
|
|
|
const removed = purgeExpiredIdempotencyKeys(NOW, undefined, db);
|
|
|
|
expect(removed).toBe(1);
|
|
const keys = db.prepare('SELECT key FROM idempotency_keys').all().map((r: { key: string }) => r.key);
|
|
expect(keys).toEqual(['fresh']);
|
|
});
|
|
|
|
it('keeps a 25-day-old key that the old 24h TTL would have dropped', () => {
|
|
insertKey('offline-trip', 25 * DAY);
|
|
expect(purgeExpiredIdempotencyKeys(NOW, undefined, db)).toBe(0);
|
|
expect(db.prepare('SELECT COUNT(*) c FROM idempotency_keys').get()).toMatchObject({ c: 1 });
|
|
});
|
|
|
|
it('respects the IDEMPOTENCY_TTL_SECONDS override', () => {
|
|
process.env.IDEMPOTENCY_TTL_SECONDS = String(DAY);
|
|
insertKey('twoDays', 2 * DAY);
|
|
expect(purgeExpiredIdempotencyKeys(NOW, undefined, db)).toBe(1);
|
|
});
|
|
});
|