mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-10-19 05:26:47 +00:00
Maurice
44eff7177e
Settings -> General -> Startup: start on the dashboard (unchanged default) or straight in the active trip, on a tab of your choice. Three clicks and three loads less for someone entering expenses while actually travelling, which is where the request came from. The redirect sits on '/' because that is what a shortcut, a bookmark and the installed PWA all launch (manifest start_url). /dashboard keeps working as itself - redirecting there too would leave no way back to it. The preference is mirrored into localStorage, the way the language and the theme snapshot already are, so the first paint can decide without waiting on GET /api/settings. That keeps the default launch exactly as fast as before: only someone who asked for the trip pays for the lookup, and if it fails or they have no trip they get the dashboard. Right after login the store already holds the real settings, so those win there. Login stops hardcoding /dashboard as its fallback and hands the decision to the same place, so there is one answer to "where does TREK open".
83 lines
3.3 KiB
TypeScript
83 lines
3.3 KiB
TypeScript
// FE-UTIL-START-001 to FE-UTIL-START-009
|
|
import { describe, it, expect, beforeEach, vi, afterEach } from 'vitest'
|
|
import {
|
|
readStartDestination,
|
|
rememberStartDestination,
|
|
forgetStartDestination,
|
|
tripStartPath,
|
|
DEFAULT_START_PAGE,
|
|
DEFAULT_START_TRIP_TAB,
|
|
} from '../../../src/utils/startDestination'
|
|
|
|
beforeEach(() => {
|
|
localStorage.clear()
|
|
})
|
|
|
|
afterEach(() => {
|
|
vi.restoreAllMocks()
|
|
})
|
|
|
|
describe('readStartDestination', () => {
|
|
it('FE-UTIL-START-001: falls back to the dashboard when nothing was ever mirrored', () => {
|
|
expect(readStartDestination()).toEqual({ page: DEFAULT_START_PAGE, tab: DEFAULT_START_TRIP_TAB })
|
|
})
|
|
|
|
it('FE-UTIL-START-002: returns what was mirrored', () => {
|
|
rememberStartDestination({ start_page: 'active_trip', start_trip_tab: 'finanzplan' })
|
|
expect(readStartDestination()).toEqual({ page: 'active_trip', tab: 'finanzplan' })
|
|
})
|
|
|
|
// A value a user (or an older/newer build) could have written by hand must not
|
|
// become a route we then navigate to.
|
|
it('FE-UTIL-START-003: ignores values that are not a known page or tab', () => {
|
|
localStorage.setItem('trek_start_page', 'somewhere_else')
|
|
localStorage.setItem('trek_start_trip_tab', '../../etc/passwd')
|
|
expect(readStartDestination()).toEqual({ page: DEFAULT_START_PAGE, tab: DEFAULT_START_TRIP_TAB })
|
|
})
|
|
|
|
it('FE-UTIL-START-004: survives a browser that refuses storage access', () => {
|
|
vi.spyOn(Storage.prototype, 'getItem').mockImplementation(() => {
|
|
throw new Error('SecurityError')
|
|
})
|
|
expect(readStartDestination()).toEqual({ page: DEFAULT_START_PAGE, tab: DEFAULT_START_TRIP_TAB })
|
|
})
|
|
})
|
|
|
|
describe('rememberStartDestination', () => {
|
|
it('FE-UTIL-START-005: only touches the keys present in the patch', () => {
|
|
rememberStartDestination({ start_page: 'active_trip', start_trip_tab: 'dateien' })
|
|
rememberStartDestination({ start_trip_tab: 'buchungen' })
|
|
expect(readStartDestination()).toEqual({ page: 'active_trip', tab: 'buchungen' })
|
|
})
|
|
|
|
it('FE-UTIL-START-006: clears a key that comes back invalid instead of keeping a stale one', () => {
|
|
rememberStartDestination({ start_page: 'active_trip' })
|
|
rememberStartDestination({ start_page: undefined })
|
|
expect(localStorage.getItem('trek_start_page')).toBeNull()
|
|
})
|
|
|
|
it('FE-UTIL-START-007: swallows a quota error rather than failing the settings save', () => {
|
|
vi.spyOn(Storage.prototype, 'setItem').mockImplementation(() => {
|
|
throw new Error('QuotaExceededError')
|
|
})
|
|
expect(() => rememberStartDestination({ start_page: 'active_trip' })).not.toThrow()
|
|
})
|
|
})
|
|
|
|
describe('forgetStartDestination', () => {
|
|
it('FE-UTIL-START-008: leaves the next account on this browser with the default', () => {
|
|
rememberStartDestination({ start_page: 'active_trip', start_trip_tab: 'finanzplan' })
|
|
forgetStartDestination()
|
|
expect(readStartDestination()).toEqual({ page: DEFAULT_START_PAGE, tab: DEFAULT_START_TRIP_TAB })
|
|
})
|
|
})
|
|
|
|
describe('tripStartPath', () => {
|
|
it('FE-UTIL-START-009: always spells the tab out, and never a tab that does not exist', () => {
|
|
// Explicit even for 'plan', or the last session's tab would decide instead.
|
|
expect(tripStartPath(7, 'plan')).toBe('/trips/7?tab=plan')
|
|
expect(tripStartPath(7, 'finanzplan')).toBe('/trips/7?tab=finanzplan')
|
|
expect(tripStartPath(7, 'nonsense')).toBe('/trips/7?tab=plan')
|
|
})
|
|
})
|