mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-10-19 13:36:48 +00:00
d4a1601855
Twelve admin packing-template routes sat on AdminController and reached
PackingService through eleven pass-through methods on AdminService that did
nothing but forward and cast. PackingService already owns all three template
tables, so the routes move to AdminPackingTemplatesController next to it and the
pass-through block is gone. AdminService no longer injects PackingService at all.
The three places flags were raw app_settings SQL on AdminService, sitting beside
bag-tracking and collab-features which it already delegated to AddonsService.
They move to AddonsService, which owns every other flag, and AdminController now
calls it directly rather than through delegating methods.
The toggle ROUTES stay on AdminController, which is a departure from the plan and
worth stating: an admin-gated controller in AddonsModule makes that module import
AuthModule, and PluginGuardsModule imports AddonsModule precisely because it is a
leaf — Nest refused to build the graph. Same for the addon CRUD, whose PUT
cascades into PluginRuntimeService. Both notes are in the code.
Paths, response shapes, the {error,status} envelope, the create-201 split and
every audit action are unchanged.
109 lines
5.1 KiB
TypeScript
109 lines
5.1 KiB
TypeScript
/**
|
|
* The admin packing-template CRUD, after it moved off AdminController into the packing
|
|
* domain that owns the three template tables. Same paths, same {error,status}
|
|
* envelope, same create-201 split, same audit actions — these cases came over from
|
|
* admin.controller.test.ts with the routes.
|
|
*/
|
|
import { describe, it, expect, vi, beforeEach } from 'vitest';
|
|
import { HttpException } from '@nestjs/common';
|
|
import { AdminPackingTemplatesController } from '../../../src/nest/packing/admin-packing-templates.controller';
|
|
import { PackingModule } from '../../../src/nest/packing/packing.module';
|
|
import type { PackingService } from '../../../src/nest/packing/packing.service';
|
|
import type { AuditService } from '../../../src/nest/audit/audit.service';
|
|
import type { User } from '../../../src/types';
|
|
import { expectRegisteredController } from '../../helpers/module-providers';
|
|
|
|
const user = { id: 1, role: 'admin' } as User;
|
|
const req = { headers: {}, socket: {} } as never;
|
|
const writeAudit = vi.fn();
|
|
|
|
function controller(over: Partial<PackingService> = {}) {
|
|
const packing = {
|
|
listPackingTemplates: vi.fn(() => [{ id: 1 }]),
|
|
getPackingTemplate: vi.fn(() => ({ template: { id: 1 } })),
|
|
createPackingTemplate: vi.fn(() => ({ template: { id: 9 } })),
|
|
updatePackingTemplate: vi.fn(() => ({ template: { id: 1 } })),
|
|
deletePackingTemplate: vi.fn(() => ({ name: 'Beach' })),
|
|
createTemplateCategory: vi.fn(() => ({ category: { id: 2 } })),
|
|
updateTemplateCategory: vi.fn(() => ({ category: { id: 2 } })),
|
|
deleteTemplateCategory: vi.fn(() => ({ ok: true })),
|
|
createTemplateItem: vi.fn(() => ({ item: { id: 3 } })),
|
|
updateTemplateItem: vi.fn(() => ({ item: { id: 3 } })),
|
|
deleteTemplateItem: vi.fn(() => ({ ok: true })),
|
|
...over,
|
|
} as unknown as PackingService;
|
|
return { c: new AdminPackingTemplatesController(packing, { writeAudit } as unknown as AuditService), packing };
|
|
}
|
|
|
|
const thrown = (run: () => unknown) => {
|
|
try {
|
|
run();
|
|
return null;
|
|
} catch (e) {
|
|
return e instanceof HttpException ? { status: e.getStatus(), body: e.getResponse() } : e;
|
|
}
|
|
};
|
|
|
|
describe('AdminPackingTemplatesController', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
});
|
|
|
|
it('PACKTPL-001 list wraps the service result in the { templates } envelope', () => {
|
|
expect(controller().c.list()).toEqual({ templates: [{ id: 1 }] });
|
|
});
|
|
|
|
it('PACKTPL-002 a service {error,status} becomes that HTTP status, not a 200 body', () => {
|
|
const { c } = controller({ getPackingTemplate: vi.fn(() => ({ error: 'not found', status: 404 })) } as Partial<PackingService>);
|
|
expect(thrown(() => c.get('9'))).toEqual({ status: 404, body: { error: 'not found' } });
|
|
});
|
|
|
|
it('PACKTPL-003 an error without a status defaults to 400', () => {
|
|
const { c } = controller({ createTemplateCategory: vi.fn(() => ({ error: 'name required' })) } as Partial<PackingService>);
|
|
expect(thrown(() => c.createCategory('1', { name: '' }))).toEqual({ status: 400, body: { error: 'name required' } });
|
|
});
|
|
|
|
it('PACKTPL-004 create audits with the new template id', () => {
|
|
const { c, packing } = controller();
|
|
expect(c.create(user, { name: 'Beach' }, req)).toEqual({ template: { id: 9 } });
|
|
expect(packing.createPackingTemplate).toHaveBeenCalledWith('Beach', 1);
|
|
expect(writeAudit).toHaveBeenCalledWith(
|
|
expect.objectContaining({ action: 'admin.packing_template_create', resource: '9', details: { name: 'Beach' } }),
|
|
);
|
|
});
|
|
|
|
it('PACKTPL-005 delete audits the removed name and answers { success: true }', () => {
|
|
const { c } = controller();
|
|
expect(c.remove(user, '1', req)).toEqual({ success: true });
|
|
expect(writeAudit).toHaveBeenCalledWith(
|
|
expect.objectContaining({ action: 'admin.packing_template_delete', resource: '1', details: { name: 'Beach' } }),
|
|
);
|
|
});
|
|
|
|
it('PACKTPL-006 the nested category and item routes forward their ids in order', () => {
|
|
const { c, packing } = controller();
|
|
c.createCategory('1', { name: 'Clothes' });
|
|
expect(packing.createTemplateCategory).toHaveBeenCalledWith('1', 'Clothes');
|
|
c.updateCategory('1', '2', { name: 'Warm' });
|
|
expect(packing.updateTemplateCategory).toHaveBeenCalledWith('1', '2', { name: 'Warm' });
|
|
expect(c.deleteCategory('1', '2')).toEqual({ success: true });
|
|
c.createItem('1', '2', { name: 'Socks' });
|
|
expect(packing.createTemplateItem).toHaveBeenCalledWith('1', '2', 'Socks');
|
|
c.updateItem('1', '3', { name: 'Wool socks' });
|
|
expect(packing.updateTemplateItem).toHaveBeenCalledWith('1', '3', { name: 'Wool socks' });
|
|
expect(c.deleteItem('1', '3')).toEqual({ success: true });
|
|
});
|
|
|
|
it('PACKTPL-007 the delete routes answer { success: true } rather than the service payload', () => {
|
|
// The client branches on `success`; leaking the raw service result here would be a
|
|
// silent shape change for every caller.
|
|
const { c } = controller();
|
|
expect(c.deleteCategory('1', '2')).toEqual({ success: true });
|
|
expect(c.deleteItem('1', '3')).toEqual({ success: true });
|
|
});
|
|
|
|
it('PACKTPL-008 the class is listed in its module controllers', () => {
|
|
expectRegisteredController(PackingModule, AdminPackingTemplatesController);
|
|
});
|
|
});
|