mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-10-19 05:26:47 +00:00
Maurice
8dca372c47
Both only ran on a developer's machine, and both had stopped telling the truth. The end-to-end flows now run in CI in Chromium and in WebKit (the iPad and iPhone cases need the engine every iOS browser uses), with the browsers cached on the lockfile and the traces uploaded when a flow fails. A second job builds the client and fails when one chunk carries both map engines. Making them pass meant fixing what had rotted. The setup closed every first-run notice but the release notes, whose X is called Close, so the notes covered the dashboard and every flow after login timed out on a click. The iPad case still expected undraggable place rows; tablets drag on purpose since #1616, behind the long-press bridge, so it now checks what #1432 is about, a swipe that scrolls and raises no drop overlay, with locators for the scroller and the Plan tab that match today's markup. The iPhone case read the body scroll lock through window.scrollBy, which moves an overflow: hidden viewport in every engine; it now reads the lock where it takes effect and checks the page keeps its place.
48 lines
2.4 KiB
TypeScript
48 lines
2.4 KiB
TypeScript
import type { Page } from '@playwright/test'
|
|
|
|
/**
|
|
* Dismiss the system-notice modal(s) (SystemNoticeHost), which greet a freshly
|
|
* seeded user on first load and cover the dashboard — the backdrop swallows
|
|
* clicks aimed at anything underneath, `.add-trip-card` included.
|
|
*
|
|
* The host renders asynchronously (after the notices fetch), so wait for the
|
|
* notice dialog before deciding there is nothing to clear. Every lookup is
|
|
* scoped INSIDE the dialog — an unscoped /next/i can match dashboard buttons
|
|
* (carousel arrows) and satisfy the wait before the modal even mounts.
|
|
*
|
|
* A notice closes one of three ways depending on its shape:
|
|
* - CTA-bearing notices (e.g. the thank-you/support modal) only offer the
|
|
* X button (`aria-label="Dismiss"`), shown on the last page.
|
|
* - CTA-less notices show an "OK" button that pages forward and dismisses on
|
|
* the last page.
|
|
* - The release notes (ReleaseNoticeModal), shown again after every update,
|
|
* close through their X (`aria-label="Close"`).
|
|
* Multi-page notices are paged through via the pager's Next button first.
|
|
* Dismissal is persisted server-side per user, so clearing once keeps it
|
|
* cleared for every later spec in the run (shared test DB).
|
|
*/
|
|
export async function dismissSystemNotices(page: Page, appearTimeoutMs = 3_000): Promise<void> {
|
|
const dialog = page.getByRole('dialog').first()
|
|
await dialog.waitFor({ state: 'visible', timeout: appearTimeoutMs }).catch(() => {})
|
|
|
|
// Clear up to a handful of queued notices.
|
|
for (let notice = 0; notice < 4 && (await dialog.isVisible().catch(() => false)); notice++) {
|
|
const next = dialog.getByRole('button', { name: /next/i })
|
|
for (let i = 0; i < 8 && (await next.isVisible().catch(() => false)); i++) {
|
|
if (!(await next.isEnabled().catch(() => false))) break
|
|
await next.click()
|
|
}
|
|
const dismiss = dialog.getByRole('button', { name: 'Dismiss', exact: true })
|
|
const ok = dialog.getByRole('button', { name: 'OK', exact: true })
|
|
const close = dialog.getByRole('button', { name: 'Close', exact: true })
|
|
if (await dismiss.isVisible().catch(() => false)) await dismiss.click()
|
|
else if (await ok.isVisible().catch(() => false)) await ok.click()
|
|
else if (await close.isVisible().catch(() => false)) await close.click()
|
|
else break
|
|
// Exit animation + the next queued notice mounting.
|
|
await page.waitForTimeout(400)
|
|
}
|
|
|
|
await dialog.waitFor({ state: 'detached', timeout: 5_000 }).catch(() => {})
|
|
}
|