k1nq/TREK
1
0
Fork 0
mirror of https://github.com/mauriceboe/TREK.git synced 2026-10-19 13:36:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(server): plan 4 — dedupe overlapping listPlanDays/isTrackInTrip parity blocks

Browse Source 
235f03665 landed two versions of the same DaysRepository.listPlanDays and
PlacesRepository.isTrackInTrip parity coverage side by side (a merge
artifact from concurrent work on the same carry item). Keeps one block per
method, drops the duplicate describe/it blocks and their colliding test ids.
This commit is contained in:
jubnl
2026-09-24 07:04:15 +02:00
parent 235f036657
commit cb66ff33d3
2 changed files with 0 additions and 108 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/tests/unit/db/repositories/Days.repository.test.ts
-41
View File
@@ -352,47 +352,6 @@ describe('DaysRepository.listForPublicApi (Plan 4 Task 1, public-api.service.ts:
const trip = createTrip(testDb, user.id);
expect(await days.listForPublicApi(trip.id)).toEqual([]);
});
it('DAYREPO-029 (rule 19): title/notes SET (not just the default NULL) still matches the legacy row, key for key', async () => {
const { user } = createUser(testDb);
const trip = createTrip(testDb, user.id);
const day = createDay(testDb, trip.id, { date: '2026-06-03', title: 'Departure' });
testDb.prepare('UPDATE days SET notes = ? WHERE id = ?').run('Pack early', day.id);
const legacy = testDb.prepare('SELECT id, day_number, date, title, notes FROM days WHERE trip_id = ? ORDER BY day_number ASC').all(trip.id);
const rows = await days.listForPublicApi(trip.id);
expect(rows).toEqual(legacy);
expect(rows).toEqual([{ id: day.id, day_number: day.day_number, date: '2026-06-03', title: 'Departure', notes: 'Pack early' }]);
});
});
describe('DaysRepository.listPlanDays (Plan 4 Task 8b-2, RPL1 — roadtrip-plan.service.ts::context)', () => {
it('DAYREPO-030: id/day_number/date/title/default_transport_mode, ordered by day_number, both NULL and SET nullable columns', async () => {
const { user } = createUser(testDb);
const trip = createTrip(testDb, user.id);
const other = createTrip(testDb, user.id);
const day2 = createDay(testDb, trip.id, { day_number: 2, date: '2026-06-02', title: 'Day two' });
testDb.prepare("UPDATE days SET default_transport_mode = ? WHERE id = ?").run('cycling', day2.id);
const day1 = createDay(testDb, trip.id, { day_number: 1 }); // date/title/default_transport_mode all NULL
createDay(testDb, other.id, { day_number: 1 });
const legacy = testDb
.prepare('SELECT id, day_number, date, title, default_transport_mode FROM days WHERE trip_id = ? ORDER BY day_number')
.all(trip.id);
const rows = await days.listPlanDays(trip.id);
expect(rows).toEqual(legacy);
expect(rows).toEqual([
{ id: day1.id, day_number: 1, date: null, title: null, default_transport_mode: null },
{ id: day2.id, day_number: 2, date: '2026-06-02', title: 'Day two', default_transport_mode: 'cycling' },
]);
});
it('DAYREPO-031: empty array for a trip with no days', async () => {
const { user } = createUser(testDb);
const trip = createTrip(testDb, user.id);
expect(await days.listPlanDays(trip.id)).toEqual([]);
});
});
// ─────────────────────────────────────────────────────────────────────────────
server/tests/unit/db/repositories/Places.repository.test.ts
-67
View File
@@ -1255,73 +1255,6 @@ describe('PlacesRepository.listAssignedForPublicApi (Plan 4 Task 1, public-api.s
const trip = createTrip(testDb, user.id);
expect(await places.listAssignedForPublicApi(trip.id)).toEqual([]);
});
it('PLACEREPO-032 (rule 19): matches the legacy JOIN run raw, every nullable projected column both NULL and SET', async () => {
const { user } = createUser(testDb);
const trip = createTrip(testDb, user.id);
const category = createCategory(testDb, { name: 'Landmark' });
const day = createDay(testDb, trip.id);
const sparse = createPlace(testDb, trip.id, { name: 'Sparse' });
testDb.prepare(
'UPDATE places SET address = NULL, lat = NULL, lng = NULL, place_time = NULL, end_time = NULL, duration_minutes = NULL, notes = NULL, transport_mode = NULL, category_id = NULL WHERE id = ?',
).run(sparse.id);
const full = createPlace(testDb, trip.id, { name: 'Full', lat: 10.5, lng: 20.5, category_id: category.id });
testDb.prepare(
"UPDATE places SET address = ?, place_time = ?, end_time = ?, duration_minutes = ?, notes = ?, transport_mode = ? WHERE id = ?",
).run('123 Main St', '09:00', '10:00', 60, 'Bring a jacket', 'walking', full.id);
createDayAssignment(testDb, day.id, sparse.id, { order_index: 0 });
createDayAssignment(testDb, day.id, full.id, { order_index: 1 });
const legacy = testDb.prepare(`
SELECT da.day_id, p.name, p.address, p.lat, p.lng, p.place_time, p.end_time, p.duration_minutes, p.notes, p.transport_mode, c.name as category
FROM day_assignments da JOIN places p ON p.id = da.place_id LEFT JOIN categories c ON c.id = p.category_id
WHERE p.trip_id = ? AND da.accommodation_id IS NULL
ORDER BY da.day_id ASC, da.order_index ASC`).all(trip.id);
const rows = await places.listAssignedForPublicApi(trip.id);
expect(rows).toEqual(legacy);
expect(rows).toEqual([
{ day_id: day.id, name: 'Sparse', address: null, lat: null, lng: null, place_time: null, end_time: null, duration_minutes: null, notes: null, transport_mode: null, category: null },
{ day_id: day.id, name: 'Full', address: '123 Main St', lat: 10.5, lng: 20.5, place_time: '09:00', end_time: '10:00', duration_minutes: 60, notes: 'Bring a jacket', transport_mode: 'walking', category: 'Landmark' },
]);
});
});
describe('PlacesRepository.isTrackInTrip (Plan 4 Task 8b-2, RT13 — RoadtripService.trackExists)', () => {
it('PLACEREPO-033: true only when route_geometry is set AND non-empty AND the place belongs to the trip', async () => {
const { user } = createUser(testDb);
const trip = createTrip(testDb, user.id);
const other = createTrip(testDb, user.id);
const withTrack = createPlace(testDb, trip.id, { name: 'Has track' });
testDb.prepare('UPDATE places SET route_geometry = ? WHERE id = ?').run('{"type":"LineString"}', withTrack.id);
const nullGeometry = createPlace(testDb, trip.id, { name: 'Null geometry' });
const emptyGeometry = createPlace(testDb, trip.id, { name: 'Empty geometry' });
testDb.prepare("UPDATE places SET route_geometry = '' WHERE id = ?").run(emptyGeometry.id);
const foreignTrack = createPlace(testDb, other.id, { name: 'Foreign track' });
testDb.prepare('UPDATE places SET route_geometry = ? WHERE id = ?').run('{"type":"LineString"}', foreignTrack.id);
const legacy = (id: number) =>
testDb.prepare("SELECT id FROM places WHERE id = ? AND trip_id = ? AND route_geometry IS NOT NULL AND route_geometry != ''").get(id, trip.id);
expect(await places.isTrackInTrip(withTrack.id, trip.id)).toBe(true);
expect(!!legacy(withTrack.id)).toBe(true);
expect(await places.isTrackInTrip(nullGeometry.id, trip.id)).toBe(false);
expect(!!legacy(nullGeometry.id)).toBe(false);
expect(await places.isTrackInTrip(emptyGeometry.id, trip.id)).toBe(false);
expect(!!legacy(emptyGeometry.id)).toBe(false);
// Belongs to a different trip — the trip_id predicate excludes it even though its geometry is set.
expect(await places.isTrackInTrip(foreignTrack.id, trip.id)).toBe(false);
expect(!!legacy(foreignTrack.id)).toBe(false);
});
it('PLACEREPO-034: an unknown place id is false', async () => {
const { user } = createUser(testDb);
const trip = createTrip(testDb, user.id);
expect(await places.isTrackInTrip(999999, trip.id)).toBe(false);
});
});
// ─────────────────────────────────────────────────────────────────────────────