k1nq/TREK
1
0
Fork 0
mirror of https://github.com/mauriceboe/TREK.git synced 2026-10-18 21:16:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(email): link notification preferences to settings tab

Browse Source 
- Make the “Manage preferences” text in notification emails clickable.
- Link directly to `/settings?tab=notifications`.
- Preserve the localized link text and existing email styling.
- Add a regression test for the generated preferences URL.
This commit is contained in:
Luffy
2026-09-28 17:40:45 +08:00
committed by Maurice
parent c93cf2bce9
commit c7793a6017
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/src/nest/notifications/mailer/email-html.ts
+2 -1
View File
@@ -41,6 +41,7 @@ export function buildEmailHtml(
const s = I18N[lang] || I18N.en;
const appUrl = getAppUrl();
const ctaHref = escapeHtml(navigateTarget ? `${appUrl}${navigateTarget}` : appUrl || '');
const manageHref = escapeHtml(`${appUrl}/settings?tab=notifications`);
const safeSubject = escapeHtml(subject);
const safeBody = rawBody ? body : escapeHtml(body);
@@ -73,7 +74,7 @@ export function buildEmailHtml(
}
<!-- Footer -->
<tr><td style="padding: 20px 32px; background: #f9fafb; border-top: 1px solid #f3f4f6; text-align: center;">
<p style="margin: 0 0 8px; font-size: 11px; color: #9ca3af; line-height: 1.5;">${s.footer}<br>${s.manage}</p>
<p style="margin: 0 0 8px; font-size: 11px; color: #9ca3af; line-height: 1.5;">${s.footer}<br><a href="${manageHref}" style="color: #9ca3af; text-decoration: underline;">${s.manage}</a></p>
<p style="margin: 0; font-size: 10px; color: #d1d5db;">${s.madeWith} <span style="color: #ef4444;">&hearts;</span> by Maurice &middot; <a href="https://github.com/liketrek/TREK" style="color: #9ca3af; text-decoration: none;">GitHub</a></p>
</td></tr>
</table>
server/tests/unit/nest/notification-transports.test.ts
+7
View File
@@ -221,6 +221,13 @@ describe('buildEmailHtml', () => {
expect(html).toContain('notifications enabled in TREK');
});
it('links notification preferences to the notifications settings tab', () => {
const html = buildEmailHtml('Subject', 'Body', 'en');
expect(html).toMatch(
/<a href="https?:\/\/[^"]+\/settings\?tab=notifications"[^>]*>Manage preferences in Settings<\/a>/,
);
});
it('uses German i18n strings for lang=de', () => {
const html = buildEmailHtml('Subject', 'Body', 'de');
expect(html).toContain('TREK aktiviert');