fix(tours): the checklist keeps to its tour, its state and its focus

A decision answered after another tour was opened no longer replaces that
tour's checklist. A decision made offline on a checklist already older than
the route stays marked as such, and once online a bench from a write made
offline waits for the queue to replay, then takes in the server's. While
the checklist reads again it stays in view, locked, so a panel open on the
map keeps its note. A saved tour turned into a paddle tour asks to be saved
first, a vanished obstacle stays among the rows, Next follows the list
order and keeps the focus in the panel, a note closes only once saved, the
earlier choice in review is named for screen readers too, planning a
portage is offered to editors only, and the map card scrolls within the
screen. A tooltip of several lines breaks at them. A page test waits for
the tours row instead of reading it at once.
This commit is contained in:
Maurice
2026-10-17 02:07:22 +00:00
parent 2a4b71b3d9
commit a7f5a114e6
15 changed files with 404 additions and 89 deletions
@@ -188,7 +188,7 @@ describe('focusPointsOf', () => {
});
describe('checklistRows', () => {
it('PCM-014: lists the obstacles and the own portages and locks in route order, the earlier decisions apart', () => {
it('PCM-014: lists the obstacles and the own portages and locks in route order, then the vanished ones, the earlier decisions apart', () => {
const weir = obstacleEntry();
const rapids = obstacleEntry({
key: 'node/2',
@@ -200,9 +200,10 @@ describe('checklistRows', () => {
});
const dam = obstacleEntry({ key: 'node/3', refs: ['node/3'], kind: 'dam', along_m: 2600 });
const gone = earlierEntry();
const offRoute = earlierEntry({ key: 'node/10', refs: ['node/10'], status: 'off_route' });
const portage = ownPortage();
const lock = ownPortage({ kind: 'lock', index: 2, from_m: 2000, to_m: 2000, covers: [] });
const check = obstacleCheck({ entries: [dam, weir, gone, rapids], own: [lock, portage] });
const check = obstacleCheck({ entries: [dam, weir, gone, offRoute, rapids], own: [lock, portage] });
expect(checklistRows(check)).toEqual({
rows: [
@@ -211,8 +212,9 @@ describe('checklistRows', () => {
{ type: 'obstacle', entry: weir },
{ type: 'own', own: lock },
{ type: 'obstacle', entry: dam },
{ type: 'obstacle', entry: gone },
],
earlier: [gone],
earlier: [offRoute],
});
});
@@ -261,3 +263,13 @@ describe('nextPendingEntry', () => {
expect(nextPendingEntry(obstacleCheck({ entries: [first] }), first)).toBeNull();
});
});
describe('nextPendingEntry at one metre', () => {
it('PCM-019: two pending entries at the same metre follow each other in list order', () => {
const first = obstacleEntry({ key: 'node/1', along_m: 1200 });
const second = obstacleEntry({ key: 'node/2', refs: ['node/2'], along_m: 1200 });
const check = obstacleCheck({ entries: [first, second] });
expect(nextPendingEntry(check, first)?.key).toBe('node/2');
expect(nextPendingEntry(check, second)).toBeNull();
});
});