k1nq/TREK
1
0
Fork 0
mirror of https://github.com/mauriceboe/TREK.git synced 2026-10-18 21:16:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(shared): tighten WS payload schemas after the MCP drift fixes

Browse Source 
assignment:moved requires newDayId again; assignment:reordered and
day:deleted drop their drift-union variants now that every emitter
sends the canonical shape.
This commit is contained in:
jubnl
2026-07-29 00:34:58 +02:00
parent 23486f841f
commit a3c2cfa4b2
2 changed files with 6 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
shared/src/realtime/events.schema.spec.ts
-3
View File
@@ -113,9 +113,6 @@ const FIXTURES: Record<TrekWsEventName, Record<string, unknown>> = {
/** Divergent shapes emitted for the same event today (see DRIFT notes in the registry). */
const DRIFT_VARIANTS: Partial<Record<TrekWsEventName, Record<string, unknown>[]>> = {
'assignment:moved': [{ assignment: { id: 9, day_id: 4 }, oldDayId: 2 }],
'assignment:reordered': [{ dayId: 2, assignmentIds: [3, 1, 2] }],
'day:deleted': [{ id: 2 }],
'day:reordered': [{ day: { id: 2 } }],
'budget:reordered': [{ orderedCategories: ['food', 'transport'] }],
'reservation:created': [{}],
shared/src/realtime/events.schema.ts
+6 -11
View File
@@ -65,17 +65,15 @@ export const TREK_WS_EVENTS = {
'assignment:created': { scope: 'trip', payload: z.object({ assignment: entity }) },
'assignment:updated': { scope: 'trip', payload: z.object({ assignment: entity }) },
'assignment:deleted': { scope: 'trip', payload: z.object({ assignmentId: id, dayId: id }) },
// DRIFT: REST sends { assignment, oldDayId, newDayId }; the MCP tool omits
// newDayId (assignments.mcp.ts) — the client keys a day map on `undefined`.
// (MCP drift fixed 2026-07-29: move_assignment now includes newDayId and
// reorder_day_assignments sends orderedIds, matching REST.)
'assignment:moved': {
scope: 'trip',
payload: z.object({ assignment: entity, oldDayId: id, newDayId: id.optional() }),
payload: z.object({ assignment: entity, oldDayId: id, newDayId: id }),
},
// DRIFT: REST sends { dayId, orderedIds }; the MCP tool sends
// { dayId, assignmentIds } — the client only reads orderedIds.
'assignment:reordered': {
scope: 'trip',
payload: z.union([z.object({ dayId: id, orderedIds: idList }), z.object({ dayId: id, assignmentIds: idList })]),
payload: z.object({ dayId: id, orderedIds: idList }),
},
'assignment:participants': {
scope: 'trip',
@@ -85,11 +83,8 @@ export const TREK_WS_EVENTS = {
// ── Days ─────────────────────────────────────────────────────────────────
'day:created': { scope: 'trip', payload: z.object({ day: entity }) },
'day:updated': { scope: 'trip', payload: z.object({ day: entity }) },
// DRIFT: REST + plugins send { dayId }; the MCP tool sends { id }.
'day:deleted': {
scope: 'trip',
payload: z.union([z.object({ dayId: id }), z.object({ id })]),
},
// (MCP drift fixed 2026-07-29: delete_day now sends { dayId }, matching REST.)
'day:deleted': { scope: 'trip', payload: z.object({ dayId: id }) },
// Two legitimate shapes: a plain reorder sends { orderedIds }; the
// insert-at-position create path re-uses the event with { day }.
'day:reordered': {