k1nq/TREK
1
0
Fork 0
mirror of https://github.com/mauriceboe/TREK.git synced 2026-10-18 21:16:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(place-import): the Naver pager declares its page result, so the moved reader passes the strict ratchet

Browse Source 
The reader left places.service with four strictNullChecks errors that a new
file may not carry. Declaring fetchPage's result as a page or a list import
error lets the 'error' check narrow it; the places and maps entries drop off
the strict baseline.
This commit is contained in:
Maurice
2026-10-10 14:25:08 +02:00
parent c859cf3624
commit 912b8ff96b
2 changed files with 18 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/scripts/strict-baseline.json
-2
View File
@@ -76,7 +76,6 @@
"src/nest/journey/journey.dto.ts": 2,
"src/nest/journey/journey.mcp.ts": 1,
"src/nest/llm-parse/mime-email.ts": 1,
"src/nest/maps/maps.service.ts": 1,
"src/nest/maps/providers/amap.provider.ts": 1,
"src/nest/mcp-transport/mcp-transport.service.ts": 4,
"src/nest/memories/immich.controller.ts": 1,
@@ -92,7 +91,6 @@
"src/nest/packing/packing.mcp.ts": 1,
"src/nest/places/places.controller.ts": 2,
"src/nest/places/places.mcp.ts": 5,
"src/nest/places/places.service.ts": 4,
"src/nest/platform/discovery-metadata.service.ts": 3,
"src/nest/plugins/host/plugin-jobs.ts": 1,
"src/nest/plugins/host/rpc/host-surface.rpc.ts": 8,
server/src/nest/place-import/providers/naver-list.provider.ts
+18 -10
View File
@@ -8,10 +8,10 @@
* iteration. Every refusal is the exact message and status the import route
* has always answered.
*/
import { Injectable } from '@nestjs/common';
import { checkSsrf, safeFetchFollow, SsrfBlockedError } from '../../../utils/ssrfGuard';
import { LIST_USER_AGENT, MAX_LIST_RESPONSE_BYTES } from './google-list.provider';
import type { ListImportError, ListRead, NaverListPlace } from '../place-import.types';
import { LIST_USER_AGENT, MAX_LIST_RESPONSE_BYTES } from './google-list.provider';
import { Injectable } from '@nestjs/common';
/** Bookmarks asked for per page. */
const PAGE_SIZE = 20;
@@ -35,7 +35,11 @@ export class NaverListProvider {
// Redirects are followed manually so each hop is re-validated against the
// SSRF guard (a short link could otherwise 302 to an internal address).
let parsedUrl: URL;
try { parsedUrl = new URL(url); } catch { return { error: 'Invalid URL', status: 400 }; }
try {
parsedUrl = new URL(url);
} catch {
return { error: 'Invalid URL', status: 400 };
}
if (parsedUrl.hostname === 'naver.me') {
try {
const redirectRes = await safeFetchFollow(url, { signal: AbortSignal.timeout(10000) });
@@ -52,7 +56,7 @@ export class NaverListProvider {
return { error: 'Could not extract folder ID from URL. Please use a shared Naver Maps list link.', status: 400 };
}
const fetchPage = async (start: number) => {
const fetchPage = async (start: number): Promise<{ data: NaverPage } | ListImportError> => {
const apiUrl = `https://pages.map.naver.com/save-pages/api/maps-bookmark/v3/shares/${encodeURIComponent(folderId)}/bookmarks?placeInfo=true&start=${start}&limit=${limit}&sort=lastUseTime&mcids=ALL&createIdNo=true`;
const apiRes = await fetch(apiUrl, {
headers: {
@@ -94,9 +98,10 @@ export class NaverListProvider {
}
const listName = firstPage.data.folder?.name || 'Naver Maps List';
const totalCount = typeof firstPage.data.folder?.bookmarkCount === 'number'
? firstPage.data.folder.bookmarkCount
: (firstPage.data.bookmarkList?.length || 0);
const totalCount =
typeof firstPage.data.folder?.bookmarkCount === 'number'
? firstPage.data.folder.bookmarkCount
: firstPage.data.bookmarkList?.length || 0;
const allItems: Record<string, unknown>[] = [...(firstPage.data.bookmarkList || [])];
for (let start = limit; start < totalCount; start += limit) {
@@ -117,9 +122,12 @@ export class NaverListProvider {
for (const item of allItems) {
const lat = Number(item?.py);
const lng = Number(item?.px);
const name = typeof item?.name === 'string' && item.name.trim()
? item.name.trim()
: (typeof item?.displayName === 'string' ? item.displayName.trim() : '');
const name =
typeof item?.name === 'string' && item.name.trim()
? item.name.trim()
: typeof item?.displayName === 'string'
? item.displayName.trim()
: '';
const note = typeof item?.memo === 'string' && item.memo.trim() ? item.memo.trim() : null;
const address = typeof item?.address === 'string' && item.address.trim() ? item.address.trim() : null;