test(server): give e2e harness DBs the app_settings table the storage registry reads at boot

server/tests/e2e/assignments.e2e.test.ts

@@ -38,6 +38,9 @@ const { db } = vi.hoisted(() => {
     UNIQUE(assignment_id, user_id));`);
   tmp.exec(`CREATE TABLE tags (id INTEGER PRIMARY KEY AUTOINCREMENT, name TEXT, color TEXT, created_at TEXT);`);
   tmp.exec(`CREATE TABLE place_tags (place_id INTEGER NOT NULL, tag_id INTEGER NOT NULL);`);
+  // StorageRegistryService (behind StorageModule, now in this module chain) reads
+  // this at onModuleInit.
+  tmp.exec('CREATE TABLE app_settings (key TEXT PRIMARY KEY, value TEXT);');
   return { db: tmp };
 });
 

server/tests/e2e/backup.e2e.test.ts

@@ -23,6 +23,9 @@ const { db } = vi.hoisted(() => {
   tmp.exec(`CREATE TABLE audit_log (
     id INTEGER PRIMARY KEY AUTOINCREMENT, created_at DATETIME DEFAULT CURRENT_TIMESTAMP,
     user_id INTEGER, action TEXT NOT NULL, resource TEXT, details TEXT, ip TEXT);`);
+  // StorageRegistryService (behind StorageModule, now in this module chain) reads
+  // this at onModuleInit.
+  tmp.exec('CREATE TABLE app_settings (key TEXT PRIMARY KEY, value TEXT);');
   return { db: tmp };
 });
 

server/tests/e2e/collab.e2e.test.ts

@@ -50,6 +50,9 @@ const { db } = vi.hoisted(() => {
   tmp.exec(`CREATE TABLE trip_files (id INTEGER PRIMARY KEY AUTOINCREMENT, trip_id INTEGER NOT NULL,
     note_id INTEGER, filename TEXT NOT NULL, original_name TEXT NOT NULL, file_size INTEGER,
     mime_type TEXT, created_at DATETIME DEFAULT CURRENT_TIMESTAMP);`);
+  // StorageRegistryService (behind StorageModule, now in this module chain) reads
+  // this at onModuleInit.
+  tmp.exec('CREATE TABLE app_settings (key TEXT PRIMARY KEY, value TEXT);');
   return { db: tmp };
 });
 

server/tests/e2e/days.e2e.test.ts

@@ -54,6 +54,9 @@ const { db } = vi.hoisted(() => {
     metadata TEXT, created_at DATETIME DEFAULT CURRENT_TIMESTAMP);`);
   tmp.exec(`CREATE TABLE reservation_endpoints (id INTEGER PRIMARY KEY AUTOINCREMENT, reservation_id INTEGER NOT NULL,
     local_date TEXT);`);
+  // StorageRegistryService (behind StorageModule, now in this module chain) reads
+  // this at onModuleInit.
+  tmp.exec('CREATE TABLE app_settings (key TEXT PRIMARY KEY, value TEXT);');
   return { db: tmp };
 });
 

server/tests/e2e/feeds.e2e.test.ts

@@ -31,6 +31,9 @@ const { db } = vi.hoisted(() => {
   tmp.exec(`CREATE TABLE trips (id INTEGER PRIMARY KEY AUTOINCREMENT, user_id INTEGER NOT NULL,
     title TEXT, is_archived INTEGER NOT NULL DEFAULT 0, start_date TEXT, end_date TEXT, feed_token TEXT);`);
   tmp.exec(`CREATE TABLE trip_members (trip_id INTEGER NOT NULL, user_id INTEGER NOT NULL);`);
+  // StorageRegistryService (behind StorageModule, now in this module chain) reads
+  // this at onModuleInit.
+  tmp.exec('CREATE TABLE app_settings (key TEXT PRIMARY KEY, value TEXT);');
   return { db: tmp };
 });
 

server/tests/e2e/files.e2e.test.ts

@@ -37,6 +37,9 @@ const { db } = vi.hoisted(() => {
   tmp.exec('CREATE TABLE places (id INTEGER PRIMARY KEY AUTOINCREMENT, trip_id INTEGER);');
   tmp.exec('CREATE TABLE days (id INTEGER PRIMARY KEY AUTOINCREMENT, trip_id INTEGER);');
   tmp.exec('CREATE TABLE day_assignments (id INTEGER PRIMARY KEY AUTOINCREMENT, day_id INTEGER);');
+  // StorageRegistryService (behind StorageModule, now in this module chain) reads
+  // this at onModuleInit.
+  tmp.exec('CREATE TABLE app_settings (key TEXT PRIMARY KEY, value TEXT);');
   return { db: tmp };
 });
 

server/tests/e2e/journey.e2e.test.ts

@@ -20,6 +20,9 @@ const { db } = vi.hoisted(() => {
   tmp.exec('PRAGMA journal_mode = WAL');
   tmp.exec(`CREATE TABLE users (id INTEGER PRIMARY KEY AUTOINCREMENT, username TEXT NOT NULL,
     email TEXT NOT NULL UNIQUE, role TEXT NOT NULL DEFAULT 'user', password_version INTEGER NOT NULL DEFAULT 0);`);
+  // StorageRegistryService (behind StorageModule, now in this module chain) reads
+  // this at onModuleInit.
+  tmp.exec('CREATE TABLE app_settings (key TEXT PRIMARY KEY, value TEXT);');
   return { db: tmp };
 });
 

server/tests/e2e/memories.e2e.test.ts

@@ -23,6 +23,9 @@ const { db } = vi.hoisted(() => {
   tmp.exec('PRAGMA journal_mode = WAL');
   tmp.exec(`CREATE TABLE users (id INTEGER PRIMARY KEY AUTOINCREMENT, username TEXT NOT NULL,
     email TEXT NOT NULL UNIQUE, role TEXT NOT NULL DEFAULT 'user', password_version INTEGER NOT NULL DEFAULT 0);`);
+  // StorageRegistryService (behind StorageModule, now in this module chain) reads
+  // this at onModuleInit.
+  tmp.exec('CREATE TABLE app_settings (key TEXT PRIMARY KEY, value TEXT);');
   return { db: tmp };
 });
 

server/tests/e2e/notifications.e2e.test.ts

@@ -44,6 +44,9 @@ const { db } = vi.hoisted(() => {
     is_read INTEGER DEFAULT 0,
     created_at DATETIME DEFAULT CURRENT_TIMESTAMP
   );`);
+  // StorageRegistryService (behind StorageModule, now in this module chain) reads
+  // this at onModuleInit.
+  tmp.exec('CREATE TABLE app_settings (key TEXT PRIMARY KEY, value TEXT);');
   return { db: tmp };
 });
 

server/tests/e2e/oidc.e2e.test.ts

@@ -22,11 +22,15 @@ vi.mock('../../src/app-config', async (importOriginal) => {
 const { db } = vi.hoisted(() => {
   // eslint-disable-next-line @typescript-eslint/no-require-imports
   const Database = require('better-sqlite3');
-  // Bare :memory: db — nothing in these flows queries it (the db-touching
-  // OidcService methods and the toggles are stubbed on the container
-  // instances below), the container just needs a connection to construct the
-  // oidc/auth/permissions/atlas providers.
-  return { db: new Database(':memory:') };
+  const tmp = new Database(':memory:');
+  // Otherwise-bare :memory: db — nothing in these flows queries it (the
+  // db-touching OidcService methods and the toggles are stubbed on the
+  // container instances below), the container just needs a connection to
+  // construct the oidc/auth/permissions/atlas providers. app_settings is the
+  // one real exception: StorageRegistryService (behind AuthModule →
+  // StorageModule) reads it at onModuleInit.
+  tmp.exec('CREATE TABLE app_settings (key TEXT PRIMARY KEY, value TEXT);');
+  return { db: tmp };
 });
 vi.mock('../../src/db/database', () => ({
   db,

server/tests/e2e/packing.e2e.test.ts

@@ -91,6 +91,9 @@ const { db } = vi.hoisted(() => {
     name TEXT NOT NULL,
     sort_order INTEGER NOT NULL DEFAULT 0
   );`);
+  // StorageRegistryService (behind StorageModule, now in this module chain) reads
+  // this at onModuleInit.
+  tmp.exec('CREATE TABLE app_settings (key TEXT PRIMARY KEY, value TEXT);');
   return { db: tmp };
 });
 

server/tests/e2e/places.e2e.test.ts

@@ -50,6 +50,9 @@ const { db } = vi.hoisted(() => {
   // Deleting a place takes its linked expense with it (#1298).
   tmp.exec(`CREATE TABLE budget_items (id INTEGER PRIMARY KEY AUTOINCREMENT, trip_id INTEGER NOT NULL,
     name TEXT, total_price REAL DEFAULT 0, place_id INTEGER, reservation_id INTEGER);`);
+  // StorageRegistryService (behind StorageModule, now in this module chain) reads
+  // this at onModuleInit.
+  tmp.exec('CREATE TABLE app_settings (key TEXT PRIMARY KEY, value TEXT);');
   return { db: tmp };
 });
 

server/tests/e2e/tags.e2e.test.ts

@@ -26,6 +26,9 @@ const { db } = vi.hoisted(() => {
     color TEXT DEFAULT '#10b981',
     created_at DATETIME DEFAULT CURRENT_TIMESTAMP
   );`);
+  // StorageRegistryService (behind StorageModule, now in this module chain) reads
+  // this at onModuleInit.
+  tmp.exec('CREATE TABLE app_settings (key TEXT PRIMARY KEY, value TEXT);');
   return { db: tmp };
 });
 

server/tests/e2e/todo.e2e.test.ts

@@ -43,6 +43,9 @@ const { db } = vi.hoisted(() => {
     user_id INTEGER NOT NULL,
     UNIQUE(trip_id, category_name, user_id)
   );`);
+  // StorageRegistryService (behind StorageModule, now in this module chain) reads
+  // this at onModuleInit.
+  tmp.exec('CREATE TABLE app_settings (key TEXT PRIMARY KEY, value TEXT);');
   return { db: tmp };
 });
 

server/tests/e2e/transit.e2e.test.ts

@@ -18,6 +18,9 @@ const { db } = vi.hoisted(() => {
   tmp.exec('PRAGMA journal_mode = WAL');
   tmp.exec(`CREATE TABLE users (id INTEGER PRIMARY KEY AUTOINCREMENT, username TEXT NOT NULL,
     email TEXT NOT NULL UNIQUE, role TEXT NOT NULL DEFAULT 'user', password_version INTEGER NOT NULL DEFAULT 0);`);
+  // StorageRegistryService (behind StorageModule, now in this module chain) reads
+  // this at onModuleInit.
+  tmp.exec('CREATE TABLE app_settings (key TEXT PRIMARY KEY, value TEXT);');
   return { db: tmp };
 });
 vi.mock('../../src/db/database', () => ({ db, closeDb: () => {}, reinitialize: () => {} }));

server/tests/e2e/trips.e2e.test.ts

@@ -96,6 +96,9 @@ const { db } = vi.hoisted(() => {
   tmp.exec(`CREATE TABLE audit_log (
     id INTEGER PRIMARY KEY AUTOINCREMENT, created_at DATETIME DEFAULT CURRENT_TIMESTAMP,
     user_id INTEGER, action TEXT NOT NULL, resource TEXT, details TEXT, ip TEXT);`);
+  // StorageRegistryService (behind StorageModule, now in this module chain) reads
+  // this at onModuleInit.
+  tmp.exec('CREATE TABLE app_settings (key TEXT PRIMARY KEY, value TEXT);');
   return { db: tmp };
 });
 

server/tests/e2e/vacay.e2e.test.ts

@@ -64,6 +64,9 @@ const { db } = vi.hoisted(() => {
     user_id INTEGER PRIMARY KEY REFERENCES users(id) ON DELETE CASCADE,
     year_type TEXT NOT NULL DEFAULT 'calendar', year_start_month INTEGER NOT NULL DEFAULT 1,
     year_start_day INTEGER NOT NULL DEFAULT 1, hire_date TEXT);`);
+  // StorageRegistryService (behind StorageModule, now in this module chain) reads
+  // this at onModuleInit.
+  tmp.exec('CREATE TABLE app_settings (key TEXT PRIMARY KEY, value TEXT);');
   return { db: tmp };
 });