fix(db): match a stay's bookings by the stored '<id>.0' text, as SQLite did

Reading the TEXT column as an integer also matched '14', ' 14' and '14abc',
which the legacy REAL-bound compare never did (AC37/AC40). Comparing with the
'<id>.0' text the services store keeps that contract on both engines.
This commit is contained in:
Maurice
2026-11-17 15:15:48 +01:00
parent 6a9c1c287f
commit 59f0c206bf
2 changed files with 12 additions and 10 deletions
@@ -609,7 +609,7 @@ export class ReservationsRepository extends TrekRepository<Reservations> {
.else(concatKysely(platform, eb, { value: date }, { expression: substringKysely(platform, eb, 'reservation_time', 11) }))
.end(),
}))
.where((eb) => reservationStayIs(this.getEntityManager().getPlatform(), eb, 'accommodation_id', accommodation_id))
.where((eb) => reservationStayIs(eb, 'accommodation_id', accommodation_id))
.where('type', '=', 'hotel')
.execute();
}
@@ -715,7 +715,7 @@ export class ReservationsRepository extends TrekRepository<Reservations> {
const rows = await this.kysely<ReservationsByAccommodationKyselyDB>()
.selectFrom('reservations')
.select(['id', 'metadata'])
.where((eb) => reservationStayIs(this.getEntityManager().getPlatform(), eb, 'accommodation_id', accommodation_id))
.where((eb) => reservationStayIs(eb, 'accommodation_id', accommodation_id))
.execute();
return rows as { id: number; metadata: string | null }[];
}
@@ -759,7 +759,7 @@ export class ReservationsRepository extends TrekRepository<Reservations> {
const rows = await this.kysely<ReservationsByAccommodationKyselyDB>()
.selectFrom('reservations')
.select(['id'])
.where((eb) => reservationStayIs(this.getEntityManager().getPlatform(), eb, 'accommodation_id', accommodation_id))
.where((eb) => reservationStayIs(eb, 'accommodation_id', accommodation_id))
.execute();
return rows as { id: number }[];
}
@@ -1,4 +1,5 @@
import { castIntegerKysely, integerTextEqualsKysely } from '../../dialect/kysely-functions';
import { legacyBoundIntegerText } from '../../../nest/common/row-id';
import { integerTextEqualsKysely } from '../../dialect/kysely-functions';
import type { Platform } from '@mikro-orm/core';
import type { ExpressionBuilder, ExpressionWrapper, SqlBool, StringReference } from 'kysely';
@@ -24,16 +25,17 @@ export function accommodationIdMatches<DB, TB extends keyof DB>(
/**
* A reservation booked against the stay `stayId`, the filter form of
* {@link accommodationIdMatches}: the TEXT column read as an integer, so the
* stored `'14.0'` matches 14 on Postgres too. Compared as written (`= 14`),
* Postgres binds the number as the text `'14'` and finds no row at all, which
* no error reports.
* {@link accommodationIdMatches}, held to the legacy compare: SQLite bound the
* id as a REAL, so only the stored `'<id>.0'` shape ever matched, never `'14'`,
* `' 14'` or `'14abc'` (Reservations.repository.test.ts AC37/AC40). Comparing
* the column with that same text keeps that on both engines. Compared with a
* bare number instead, Postgres binds it as the text `'14'` and finds no row
* at all, which no error reports.
*/
export function reservationStayIs<DB, TB extends keyof DB>(
platform: Platform,
eb: ExpressionBuilder<DB, TB>,
accommodationId: StringReference<DB, TB>,
stayId: number,
): ExpressionWrapper<DB, TB, SqlBool> {
return eb(castIntegerKysely(platform, eb, accommodationId), '=', stayId);
return eb(accommodationId, '=', legacyBoundIntegerText(stayId));
}