k1nq/TREK
1
0
Fork 0
mirror of https://github.com/mauriceboe/TREK.git synced 2026-10-18 21:16:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(admin): the phone addon list shows the Collab and AI Parsing icons

Browse Source 
On the phone admin addon list, the Collab and AI Parsing tiles showed
the generic puzzle piece, while the desktop shows the people and
sparkles icons for them.

Cause: the addons table stores 'Users' for collab and 'Sparkles' for
llm_parsing, and the phone's ICON_MAP had no entry for either, so both
fell back to Puzzle. The desktop map gained them earlier; the phone map
was never updated.

Fix: the phone ICON_MAP now carries Users and Sparkles, like the
desktop one.

Red test: FE-MOB-AADD-036 (new, MAdminAddonManager.test.tsx) failed
with "expect(received).toBeInTheDocument(): received value must be an
HTMLElement or an SVGElement" for svg.lucide-users.

No existing assertion changed.
This commit is contained in:
Maurice
2026-10-09 17:39:19 +02:00
parent 8dd8635b87
commit 55ccb903d1
2 changed files with 20 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/src/mobile/screens/admin/MAdminAddonManager.tsx
+4 -2
View File
@@ -3,7 +3,7 @@ import { useTranslation } from '../../../i18n'
import { useSettingsStore } from '../../../store/settingsStore'
import {
Puzzle, ListChecks, Wallet, FileText, CalendarDays, Globe, Briefcase, Image, Terminal, Link2, Compass, BookOpen,
Sparkles, Luggage, Plane, Server, Cloud, Bookmark, Check, Loader2,
Sparkles, Luggage, Plane, Server, Cloud, Bookmark, Users, Check, Loader2,
} from 'lucide-react'
import DawarichIcon from '../../../components/shared/DawarichIcon'
import AirTrailIcon from '../../../components/shared/AirTrailIcon'
@@ -24,8 +24,10 @@ import { useLlmParsingConfig } from '../../../components/Admin/addons/useLlmPars
import { ImmichIcon, SynologyIcon } from '../../../components/Admin/addons/PhotoProviderIcons'
import { MAdminButton, MAdminCard, MAdminField, MAdminInput, MAdminSecretInput } from './MAdminUi'
// Keys are the `icon` column from the addons table; anything unknown falls back to
// Puzzle. Users/Sparkles cover collab and llm_parsing, as on the desktop.
const ICON_MAP = {
ListChecks, Wallet, FileText, CalendarDays, Puzzle, Globe, Briefcase, Image, Terminal, Link2, Compass, BookOpen, Plane, Bookmark,
ListChecks, Wallet, FileText, CalendarDays, Puzzle, Globe, Briefcase, Image, Terminal, Link2, Compass, BookOpen, Plane, Bookmark, Users, Sparkles,
Dawarich: DawarichIcon,
}
client/tests/unit/mobile/admin/MAdminAddonManager.test.tsx
+16 -1
View File
@@ -1,4 +1,4 @@
// FE-MOB-AADD-001 to FE-MOB-AADD-035
// FE-MOB-AADD-001 to FE-MOB-AADD-036
import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
import userEvent from '@testing-library/user-event';
import { delay, http, HttpResponse } from 'msw';
@@ -742,4 +742,19 @@ describe('MAdminAddonManager', () => {
await user.type(screen.getByDisplayValue('sk-secret'), '-rotated');
expect(screen.getByDisplayValue('sk-secret-rotated')).toBeInTheDocument();
});
it('FE-MOB-AADD-036: collab and AI parsing show their own icons, not the puzzle fallback', async () => {
server.use(
addonsRoute([
buildAddon({ id: 'collab', name: 'Collab', icon: 'Users', enabled: true }),
buildAddon({ id: 'llm_parsing', name: 'AI Parsing', icon: 'Sparkles', type: 'integration', enabled: false }),
]),
);
render(<MAdminAddonManager />);
await screen.findByRole('switch', { name: 'Collab' });
expect(document.querySelector('svg.lucide-users')).toBeInTheDocument();
expect(document.querySelector('svg.lucide-sparkles')).toBeInTheDocument();
expect(document.querySelector('svg.lucide-puzzle')).not.toBeInTheDocument();
});
});