k1nq/TREK
1
0
Fork 0
mirror of https://github.com/mauriceboe/TREK.git synced 2026-06-19 13:21:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(i18n): standardize ellipsis to three dots (...) for consistency

Browse Source 
Revert common.loading and common.saving from Unicode ellipsis (…) back to
three dots (...) to match the rest of the project (e.g. "Optional caption...").
Update 4 test files that were incorrectly using the Unicode ellipsis character.
This commit is contained in:
Isaias Tavares
2026-04-12 17:41:14 -03:00
parent af789b7f7c
commit 137c6ff9dd
5 changed files with 24 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/src/components/Admin/AuditLogPanel.test.tsx
+1 -1
View File
@@ -47,7 +47,7 @@ describe('AuditLogPanel', () => {
}),
);
render(<AuditLogPanel serverTimezone="UTC" />);
expect(screen.getByText('Loading…')).toBeInTheDocument();
expect(screen.getByText('Loading...')).toBeInTheDocument();
expect(document.querySelector('table')).not.toBeInTheDocument();
});
client/src/components/Admin/GitHubPanel.test.tsx
+2 -2
View File
@@ -55,7 +55,7 @@ describe('GitHubPanel', () => {
it('FE-ADMIN-GH-002: all support links have correct href and target=_blank', async () => {
render(<GitHubPanel />);
await waitFor(() => expect(screen.queryByText('Loading…')).not.toBeInTheDocument());
await waitFor(() => expect(screen.queryByText('Loading...')).not.toBeInTheDocument());
const kofi = screen.getByText('Ko-fi').closest('a')!;
expect(kofi).toHaveAttribute('href', 'https://ko-fi.com/mauriceboe');
@@ -272,7 +272,7 @@ describe('GitHubPanel', () => {
it('FE-ADMIN-GH-016: support card hover effects fire without error', async () => {
render(<GitHubPanel />);
await waitFor(() => expect(screen.queryByText('Loading…')).not.toBeInTheDocument());
await waitFor(() => expect(screen.queryByText('Loading...')).not.toBeInTheDocument());
const kofiLink = screen.getByText('Ko-fi').closest('a')!;
fireEvent.mouseEnter(kofiLink);
client/src/components/Settings/NotificationsTab.test.tsx
+18 -18
View File
@@ -35,14 +35,14 @@ describe('NotificationsTab', () => {
http.get('/api/notifications/preferences', () => new Promise(() => {})),
);
render(<NotificationsTab />);
expect(screen.getByText('Loading…')).toBeInTheDocument();
expect(screen.getByText('Loading...')).toBeInTheDocument();
});
it('FE-COMP-NOTIFICATIONS-002: renders the matrix after preferences load', async () => {
render(<NotificationsTab />);
// The event label is translated; fallback is the key itself
await waitFor(() => {
expect(screen.queryByText('Loading…')).not.toBeInTheDocument();
expect(screen.queryByText('Loading...')).not.toBeInTheDocument();
});
// Should render a toggle (ToggleSwitch renders a button)
const toggles = await screen.findAllByRole('button');
@@ -52,7 +52,7 @@ describe('NotificationsTab', () => {
it('FE-COMP-NOTIFICATIONS-003: renders channel header labels', async () => {
render(<NotificationsTab />);
await waitFor(() => {
expect(screen.queryByText('Loading…')).not.toBeInTheDocument();
expect(screen.queryByText('Loading...')).not.toBeInTheDocument();
});
// inapp channel header should appear (either translated or raw key)
const headers = screen.getAllByText(/inapp|in.?app/i);
@@ -72,7 +72,7 @@ describe('NotificationsTab', () => {
);
render(<NotificationsTab />);
await waitFor(() => {
expect(screen.queryByText('Loading…')).not.toBeInTheDocument();
expect(screen.queryByText('Loading...')).not.toBeInTheDocument();
});
// Should show noChannels message (translated or key)
const noChannelEl = await screen.findByText(/no.*channel|noChannels/i);
@@ -97,7 +97,7 @@ describe('NotificationsTab', () => {
);
render(<NotificationsTab />);
await waitFor(() => {
expect(screen.queryByText('Loading…')).not.toBeInTheDocument();
expect(screen.queryByText('Loading...')).not.toBeInTheDocument();
});
// A dash should appear for non-implemented combos
const dashes = await screen.findAllByText('—');
@@ -116,7 +116,7 @@ describe('NotificationsTab', () => {
render(<NotificationsTab />);
await waitFor(() => {
expect(screen.queryByText('Loading…')).not.toBeInTheDocument();
expect(screen.queryByText('Loading...')).not.toBeInTheDocument();
});
// minimalMatrix has inapp:true and email:false for trip_invite
@@ -144,7 +144,7 @@ describe('NotificationsTab', () => {
render(<NotificationsTab />);
await waitFor(() => {
expect(screen.queryByText('Loading…')).not.toBeInTheDocument();
expect(screen.queryByText('Loading...')).not.toBeInTheDocument();
});
// Find the inapp toggle for trip_invite — it starts as "on"
@@ -156,8 +156,8 @@ describe('NotificationsTab', () => {
// After the error, the toggle should revert back (still rendered in the DOM)
await waitFor(() => {
expect(screen.queryByText('Loading…')).not.toBeInTheDocument();
expect(screen.queryByText('Saving…')).not.toBeInTheDocument();
expect(screen.queryByText('Loading...')).not.toBeInTheDocument();
expect(screen.queryByText('Saving...')).not.toBeInTheDocument();
});
// The toggle should still be present (not removed on error)
@@ -178,20 +178,20 @@ describe('NotificationsTab', () => {
render(<NotificationsTab />);
await waitFor(() => {
expect(screen.queryByText('Loading…')).not.toBeInTheDocument();
expect(screen.queryByText('Loading...')).not.toBeInTheDocument();
});
const toggleButtons = await screen.findAllByRole('button');
await user.click(toggleButtons[0]);
await waitFor(() => {
expect(screen.getByText('Saving…')).toBeInTheDocument();
expect(screen.getByText('Saving...')).toBeInTheDocument();
});
resolveRequest();
await waitFor(() => {
expect(screen.queryByText('Saving…')).not.toBeInTheDocument();
expect(screen.queryByText('Saving...')).not.toBeInTheDocument();
});
});
@@ -209,7 +209,7 @@ describe('NotificationsTab', () => {
render(<NotificationsTab />);
await waitFor(() => {
expect(screen.queryByText('Loading…')).not.toBeInTheDocument();
expect(screen.queryByText('Loading...')).not.toBeInTheDocument();
});
// Webhook URL input should be present
@@ -238,7 +238,7 @@ describe('NotificationsTab', () => {
render(<NotificationsTab />);
await waitFor(() => {
expect(screen.queryByText('Loading…')).not.toBeInTheDocument();
expect(screen.queryByText('Loading...')).not.toBeInTheDocument();
});
const input = await screen.findByRole('textbox');
@@ -265,7 +265,7 @@ describe('NotificationsTab', () => {
render(<NotificationsTab />);
await waitFor(() => {
expect(screen.queryByText('Loading…')).not.toBeInTheDocument();
expect(screen.queryByText('Loading...')).not.toBeInTheDocument();
});
const input = await screen.findByRole('textbox');
@@ -297,7 +297,7 @@ describe('NotificationsTab', () => {
render(<NotificationsTab />);
await waitFor(() => {
expect(screen.queryByText('Loading…')).not.toBeInTheDocument();
expect(screen.queryByText('Loading...')).not.toBeInTheDocument();
});
await screen.findByRole('textbox');
@@ -330,7 +330,7 @@ describe('NotificationsTab', () => {
);
await waitFor(() => {
expect(screen.queryByText('Loading…')).not.toBeInTheDocument();
expect(screen.queryByText('Loading...')).not.toBeInTheDocument();
});
const input = await screen.findByRole('textbox');
@@ -371,7 +371,7 @@ describe('NotificationsTab', () => {
);
await waitFor(() => {
expect(screen.queryByText('Loading…')).not.toBeInTheDocument();
expect(screen.queryByText('Loading...')).not.toBeInTheDocument();
});
const input = await screen.findByRole('textbox');
client/src/components/Trips/TripFormModal.test.tsx
+1 -1
View File
@@ -284,6 +284,6 @@ describe('TripFormModal', () => {
const submitBtns = screen.getAllByText('Create New Trip');
const submitBtn = submitBtns.find(el => el.closest('button'))!;
await user.click(submitBtn.closest('button')!);
await waitFor(() => expect(screen.getByText('Saving…')).toBeInTheDocument());
await waitFor(() => expect(screen.getByText('Saving...')).toBeInTheDocument());
});
});
client/src/i18n/translations/en.ts
+2 -2
View File
@@ -5,7 +5,7 @@ const en: Record<string, string | { name: string; category: string }[]> = {
'common.delete': 'Delete',
'common.edit': 'Edit',
'common.add': 'Add',
'common.loading': 'Loading…',
'common.loading': 'Loading...',
'common.import': 'Import',
'common.error': 'Error',
'common.unknownError': 'Unknown error',
@@ -27,7 +27,7 @@ const en: Record<string, string | { name: string; category: string }[]> = {
'common.name': 'Name',
'common.email': 'Email',
'common.password': 'Password',
'common.saving': 'Saving…',
'common.saving': 'Saving...',
'common.justNow': 'just now',
'common.hoursAgo': '{count}h ago',
'common.daysAgo': '{count}d ago',