revert(places): keep the Tracks choice out of the pool while Tours is on, as B4A decided

This commit is contained in:
Maurice
2026-10-26 14:26:09 +01:00
parent 313198ba63
commit 094426debb
2 changed files with 4 additions and 12 deletions
@@ -48,17 +48,13 @@ afterEach(() => {
});
describe('places pool helpers', () => {
it('FE-PLANNER-POOL-001: the Tracks choice needs a track that is no tour while tours are on (#2810)', () => {
it('FE-PLANNER-POOL-001: the Tracks choice needs a track and stays away while tours are on', () => {
const track = buildPlace({ route_geometry: '[[1,2],[3,4]]' });
const tour = buildPlace({ route_geometry: '[[1,2],[3,4]]' });
tour.tour_place_id = tour.id;
const pin = buildPlace();
expect(poolHasTracks([pin], false)).toBe(false);
expect(poolHasTracks([pin, track], false)).toBe(true);
expect(poolHasTracks([pin, track], undefined)).toBe(true);
expect(poolHasTracks([pin, tour], true)).toBe(false);
expect(poolHasTracks([pin, tour], false)).toBe(true);
expect(poolHasTracks([pin, tour, track], true)).toBe(true);
expect(poolHasTracks([pin, track], true)).toBe(false);
});
it('FE-PLANNER-POOL-002: the show choices list all, unplanned and planned, then tracks when there are some', () => {
@@ -12,13 +12,9 @@ export type PlacesFilter = 'all' | 'unplanned' | 'planned' | 'tracks';
type Translate = ReturnType<typeof useTranslation>['t'];
/**
* Whether the "Tracks" choice belongs in the pool: a place with a line that is
* no tour. While tours are on a tour lists under Tours, but a track imported
* before them (4.x) is a plain place and stays here (#2810).
*/
/** Whether the "Tracks" choice belongs in the pool: never while tours are on, since tracks are tours then. */
export function poolHasTracks(places: Place[], toursEnabled: boolean | undefined): boolean {
return places.some((p) => p.route_geometry && !(toursEnabled && p.tour_place_id === p.id));
return !toursEnabled && places.some((p) => p.route_geometry);
}
/** The "show" choices; tracks only once a place has one. */