k1nq/TREK
1
0
Fork 0
mirror of https://github.com/mauriceboe/TREK.git synced 2026-06-20 22:01:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(mcp): remove all file tools and remove ability to delete notifications

Browse Source
This commit is contained in:
jubnl
2026-04-09 18:17:31 +02:00
parent 63784d86a3
commit 059a0a24c5
5 changed files with 1 additions and 796 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/src/mcp/tools.ts
-3
View File
@@ -1,6 +1,5 @@
import { McpServer } from '@modelcontextprotocol/sdk/server/mcp';
import { registerTodoTools } from './tools/todos';
import { registerFileTools } from './tools/files';
import { registerAssignmentTools } from './tools/assignments';
import { registerReservationTools } from './tools/reservations';
import { registerTagTools } from './tools/tags';
@@ -41,8 +40,6 @@ export function registerTools(server: McpServer, userId: number): void {
registerCollabTools(server, userId);
registerFileTools(server, userId);
registerVacayTools(server, userId);
registerTodoTools(server, userId);
server/src/mcp/tools/files.ts
-231
View File
@@ -1,231 +0,0 @@
import { McpServer } from '@modelcontextprotocol/sdk/server/mcp';
import { z } from 'zod';
import { canAccessTrip } from '../../db/database';
import { isDemoUser } from '../../services/authService';
import {
listFiles, getFileById, getDeletedFile, updateFile, toggleStarred,
softDeleteFile, restoreFile, permanentDeleteFile, emptyTrash,
createFileLink, deleteFileLink, getFileLinks,
} from '../../services/fileService';
import {
safeBroadcast, TOOL_ANNOTATIONS_READONLY, TOOL_ANNOTATIONS_WRITE,
TOOL_ANNOTATIONS_DELETE,
demoDenied, noAccess, ok,
} from './_shared';
export function registerFileTools(server: McpServer, userId: number): void {
// --- FILES ---
server.registerTool(
'list_files',
{
description: 'List trip files. By default returns active files; set showTrash=true to list the trash instead.',
inputSchema: {
tripId: z.number().int().positive(),
showTrash: z.boolean().optional().default(false).describe('List trash instead of active files'),
},
annotations: TOOL_ANNOTATIONS_READONLY,
},
async ({ tripId, showTrash }) => {
if (!canAccessTrip(tripId, userId)) return noAccess();
const files = listFiles(tripId, showTrash ?? false);
return ok({ files });
}
);
server.registerTool(
'update_file_metadata',
{
description: 'Update a file\'s metadata: description, linked place, or linked reservation.',
inputSchema: {
tripId: z.number().int().positive(),
fileId: z.number().int().positive(),
description: z.string().max(1000).nullable().optional(),
place_id: z.number().int().positive().nullable().optional().describe('Link to a place; null to unlink'),
reservation_id: z.number().int().positive().nullable().optional().describe('Link to a reservation; null to unlink'),
},
annotations: TOOL_ANNOTATIONS_WRITE,
},
async ({ tripId, fileId, description, place_id, reservation_id }) => {
if (isDemoUser(userId)) return demoDenied();
if (!canAccessTrip(tripId, userId)) return noAccess();
const file = getFileById(fileId, tripId);
if (!file) return { content: [{ type: 'text' as const, text: 'File not found.' }], isError: true };
const updated = updateFile(fileId, file, {
description: description !== undefined ? (description ?? undefined) : undefined,
place_id: place_id !== undefined ? (place_id !== null ? String(place_id) : null) : undefined,
reservation_id: reservation_id !== undefined ? (reservation_id !== null ? String(reservation_id) : null) : undefined,
});
safeBroadcast(tripId, 'file:updated', { file: updated });
return ok({ file: updated });
}
);
server.registerTool(
'toggle_file_star',
{
description: 'Toggle the starred status of a file (starred files appear at the top).',
inputSchema: {
tripId: z.number().int().positive(),
fileId: z.number().int().positive(),
},
annotations: TOOL_ANNOTATIONS_WRITE,
},
async ({ tripId, fileId }) => {
if (isDemoUser(userId)) return demoDenied();
if (!canAccessTrip(tripId, userId)) return noAccess();
const file = getFileById(fileId, tripId);
if (!file) return { content: [{ type: 'text' as const, text: 'File not found.' }], isError: true };
const updated = toggleStarred(fileId, file.starred);
safeBroadcast(tripId, 'file:updated', { file: updated });
return ok({ file: updated });
}
);
server.registerTool(
'trash_file',
{
description: 'Move a file to trash (soft delete). Recoverable with restore_file.',
inputSchema: {
tripId: z.number().int().positive(),
fileId: z.number().int().positive(),
},
annotations: TOOL_ANNOTATIONS_DELETE,
},
async ({ tripId, fileId }) => {
if (isDemoUser(userId)) return demoDenied();
if (!canAccessTrip(tripId, userId)) return noAccess();
const file = getFileById(fileId, tripId);
if (!file) return { content: [{ type: 'text' as const, text: 'File not found.' }], isError: true };
softDeleteFile(fileId);
safeBroadcast(tripId, 'file:deleted', { fileId });
return ok({ success: true });
}
);
server.registerTool(
'restore_file',
{
description: 'Restore a file from trash back to the active file list.',
inputSchema: {
tripId: z.number().int().positive(),
fileId: z.number().int().positive(),
},
annotations: TOOL_ANNOTATIONS_WRITE,
},
async ({ tripId, fileId }) => {
if (isDemoUser(userId)) return demoDenied();
if (!canAccessTrip(tripId, userId)) return noAccess();
const file = getDeletedFile(fileId, tripId);
if (!file) return { content: [{ type: 'text' as const, text: 'File not found in trash.' }], isError: true };
const restored = restoreFile(fileId);
safeBroadcast(tripId, 'file:created', { file: restored });
return ok({ file: restored });
}
);
server.registerTool(
'permanent_delete_file',
{
description: 'Permanently delete a file from trash. This cannot be undone — the file is removed from disk.',
inputSchema: {
tripId: z.number().int().positive(),
fileId: z.number().int().positive(),
},
annotations: TOOL_ANNOTATIONS_DELETE,
},
async ({ tripId, fileId }) => {
if (isDemoUser(userId)) return demoDenied();
if (!canAccessTrip(tripId, userId)) return noAccess();
const file = getDeletedFile(fileId, tripId);
if (!file) return { content: [{ type: 'text' as const, text: 'File not found in trash.' }], isError: true };
permanentDeleteFile(file);
safeBroadcast(tripId, 'file:deleted', { fileId });
return ok({ success: true });
}
);
server.registerTool(
'empty_trash',
{
description: 'Permanently delete all files in the trash for a trip. Cannot be undone.',
inputSchema: {
tripId: z.number().int().positive(),
},
annotations: TOOL_ANNOTATIONS_DELETE,
},
async ({ tripId }) => {
if (isDemoUser(userId)) return demoDenied();
if (!canAccessTrip(tripId, userId)) return noAccess();
const deleted = emptyTrash(tripId);
return ok({ success: true, deleted });
}
);
server.registerTool(
'link_file',
{
description: 'Link a file to a place, reservation, or assignment. The file must belong to the trip.',
inputSchema: {
tripId: z.number().int().positive(),
fileId: z.number().int().positive(),
place_id: z.number().int().positive().optional(),
reservation_id: z.number().int().positive().optional(),
assignment_id: z.number().int().positive().optional(),
},
annotations: TOOL_ANNOTATIONS_WRITE,
},
async ({ tripId, fileId, place_id, reservation_id, assignment_id }) => {
if (isDemoUser(userId)) return demoDenied();
if (!canAccessTrip(tripId, userId)) return noAccess();
const file = getFileById(fileId, tripId);
if (!file) return { content: [{ type: 'text' as const, text: 'File not found.' }], isError: true };
const links = createFileLink(fileId, {
place_id: place_id ? String(place_id) : null,
reservation_id: reservation_id ? String(reservation_id) : null,
assignment_id: assignment_id ? String(assignment_id) : null,
});
return ok({ success: true, links });
}
);
server.registerTool(
'unlink_file',
{
description: 'Remove a specific link between a file and a place/reservation/assignment. Use list_file_links to get the link ID.',
inputSchema: {
tripId: z.number().int().positive(),
fileId: z.number().int().positive(),
linkId: z.number().int().positive().describe('ID of the file link to remove'),
},
annotations: TOOL_ANNOTATIONS_DELETE,
},
async ({ tripId, fileId, linkId }) => {
if (isDemoUser(userId)) return demoDenied();
if (!canAccessTrip(tripId, userId)) return noAccess();
const file = getFileById(fileId, tripId);
if (!file) return { content: [{ type: 'text' as const, text: 'File not found.' }], isError: true };
deleteFileLink(linkId, fileId);
return ok({ success: true });
}
);
server.registerTool(
'list_file_links',
{
description: 'List all entity links for a file (places, reservations, assignments it is attached to).',
inputSchema: {
tripId: z.number().int().positive(),
fileId: z.number().int().positive(),
},
annotations: TOOL_ANNOTATIONS_READONLY,
},
async ({ tripId, fileId }) => {
if (!canAccessTrip(tripId, userId)) return noAccess();
const file = getFileById(fileId, tripId);
if (!file) return { content: [{ type: 'text' as const, text: 'File not found.' }], isError: true };
const links = getFileLinks(fileId);
return ok({ links });
}
);
}
server/src/mcp/tools/notifications.ts
+1 -51
View File
@@ -4,8 +4,7 @@ import { isDemoUser } from '../../services/authService';
import {
getNotifications, getUnreadCount,
markRead as markNotificationRead, markUnread as markNotificationUnread,
markAllRead, deleteNotification, deleteAll as deleteAllNotifications,
respondToBoolean,
markAllRead,
} from '../../services/inAppNotifications';
import {
TOOL_ANNOTATIONS_READONLY, TOOL_ANNOTATIONS_WRITE,
@@ -93,53 +92,4 @@ export function registerNotificationTools(server: McpServer, userId: number): vo
return ok({ success: true, count });
}
);
server.registerTool(
'delete_notification',
{
description: 'Delete a single in-app notification.',
inputSchema: {
notificationId: z.number().int().positive(),
},
annotations: TOOL_ANNOTATIONS_DELETE,
},
async ({ notificationId }) => {
if (isDemoUser(userId)) return demoDenied();
const success = deleteNotification(notificationId, userId);
if (!success) return { content: [{ type: 'text' as const, text: 'Notification not found.' }], isError: true };
return ok({ success: true });
}
);
server.registerTool(
'delete_all_notifications',
{
description: "Delete all in-app notifications for the current user.",
inputSchema: {},
annotations: TOOL_ANNOTATIONS_DELETE,
},
async () => {
if (isDemoUser(userId)) return demoDenied();
const count = deleteAllNotifications(userId);
return ok({ success: true, count });
}
);
server.registerTool(
'respond_to_notification',
{
description: 'Respond to a boolean (yes/no) notification such as a trip invite or poll.',
inputSchema: {
notificationId: z.number().int().positive(),
response: z.enum(['positive', 'negative']),
},
annotations: TOOL_ANNOTATIONS_NON_IDEMPOTENT,
},
async ({ notificationId, response }) => {
if (isDemoUser(userId)) return demoDenied();
const result = await respondToBoolean(notificationId, userId, response);
if (!result.success) return { content: [{ type: 'text' as const, text: result.error ?? 'Failed to respond.' }], isError: true };
return ok({ notification: result.notification });
}
);
}