From 059a0a24c59ad122aaa06e8d62c79b19737c2a93 Mon Sep 17 00:00:00 2001 From: jubnl Date: Thu, 9 Apr 2026 18:17:31 +0200 Subject: [PATCH] fix(mcp): remove all file tools and remove ability to delete notifications --- server/src/mcp/tools.ts | 3 - server/src/mcp/tools/files.ts | 231 --------- server/src/mcp/tools/notifications.ts | 52 +- server/tests/unit/mcp/tools-files.test.ts | 456 ------------------ .../unit/mcp/tools-notifications.test.ts | 55 --- 5 files changed, 1 insertion(+), 796 deletions(-) delete mode 100644 server/src/mcp/tools/files.ts delete mode 100644 server/tests/unit/mcp/tools-files.test.ts diff --git a/server/src/mcp/tools.ts b/server/src/mcp/tools.ts index 4df78dc2..776b4011 100644 --- a/server/src/mcp/tools.ts +++ b/server/src/mcp/tools.ts @@ -1,6 +1,5 @@ import { McpServer } from '@modelcontextprotocol/sdk/server/mcp'; import { registerTodoTools } from './tools/todos'; -import { registerFileTools } from './tools/files'; import { registerAssignmentTools } from './tools/assignments'; import { registerReservationTools } from './tools/reservations'; import { registerTagTools } from './tools/tags'; @@ -41,8 +40,6 @@ export function registerTools(server: McpServer, userId: number): void { registerCollabTools(server, userId); - registerFileTools(server, userId); - registerVacayTools(server, userId); registerTodoTools(server, userId); diff --git a/server/src/mcp/tools/files.ts b/server/src/mcp/tools/files.ts deleted file mode 100644 index e99eb5fa..00000000 --- a/server/src/mcp/tools/files.ts +++ /dev/null @@ -1,231 +0,0 @@ -import { McpServer } from '@modelcontextprotocol/sdk/server/mcp'; -import { z } from 'zod'; -import { canAccessTrip } from '../../db/database'; -import { isDemoUser } from '../../services/authService'; -import { - listFiles, getFileById, getDeletedFile, updateFile, toggleStarred, - softDeleteFile, restoreFile, permanentDeleteFile, emptyTrash, - createFileLink, deleteFileLink, getFileLinks, -} from '../../services/fileService'; -import { - safeBroadcast, TOOL_ANNOTATIONS_READONLY, TOOL_ANNOTATIONS_WRITE, - TOOL_ANNOTATIONS_DELETE, - demoDenied, noAccess, ok, -} from './_shared'; - -export function registerFileTools(server: McpServer, userId: number): void { - // --- FILES --- - - server.registerTool( - 'list_files', - { - description: 'List trip files. By default returns active files; set showTrash=true to list the trash instead.', - inputSchema: { - tripId: z.number().int().positive(), - showTrash: z.boolean().optional().default(false).describe('List trash instead of active files'), - }, - annotations: TOOL_ANNOTATIONS_READONLY, - }, - async ({ tripId, showTrash }) => { - if (!canAccessTrip(tripId, userId)) return noAccess(); - const files = listFiles(tripId, showTrash ?? false); - return ok({ files }); - } - ); - - server.registerTool( - 'update_file_metadata', - { - description: 'Update a file\'s metadata: description, linked place, or linked reservation.', - inputSchema: { - tripId: z.number().int().positive(), - fileId: z.number().int().positive(), - description: z.string().max(1000).nullable().optional(), - place_id: z.number().int().positive().nullable().optional().describe('Link to a place; null to unlink'), - reservation_id: z.number().int().positive().nullable().optional().describe('Link to a reservation; null to unlink'), - }, - annotations: TOOL_ANNOTATIONS_WRITE, - }, - async ({ tripId, fileId, description, place_id, reservation_id }) => { - if (isDemoUser(userId)) return demoDenied(); - if (!canAccessTrip(tripId, userId)) return noAccess(); - const file = getFileById(fileId, tripId); - if (!file) return { content: [{ type: 'text' as const, text: 'File not found.' }], isError: true }; - const updated = updateFile(fileId, file, { - description: description !== undefined ? (description ?? undefined) : undefined, - place_id: place_id !== undefined ? (place_id !== null ? String(place_id) : null) : undefined, - reservation_id: reservation_id !== undefined ? (reservation_id !== null ? String(reservation_id) : null) : undefined, - }); - safeBroadcast(tripId, 'file:updated', { file: updated }); - return ok({ file: updated }); - } - ); - - server.registerTool( - 'toggle_file_star', - { - description: 'Toggle the starred status of a file (starred files appear at the top).', - inputSchema: { - tripId: z.number().int().positive(), - fileId: z.number().int().positive(), - }, - annotations: TOOL_ANNOTATIONS_WRITE, - }, - async ({ tripId, fileId }) => { - if (isDemoUser(userId)) return demoDenied(); - if (!canAccessTrip(tripId, userId)) return noAccess(); - const file = getFileById(fileId, tripId); - if (!file) return { content: [{ type: 'text' as const, text: 'File not found.' }], isError: true }; - const updated = toggleStarred(fileId, file.starred); - safeBroadcast(tripId, 'file:updated', { file: updated }); - return ok({ file: updated }); - } - ); - - server.registerTool( - 'trash_file', - { - description: 'Move a file to trash (soft delete). Recoverable with restore_file.', - inputSchema: { - tripId: z.number().int().positive(), - fileId: z.number().int().positive(), - }, - annotations: TOOL_ANNOTATIONS_DELETE, - }, - async ({ tripId, fileId }) => { - if (isDemoUser(userId)) return demoDenied(); - if (!canAccessTrip(tripId, userId)) return noAccess(); - const file = getFileById(fileId, tripId); - if (!file) return { content: [{ type: 'text' as const, text: 'File not found.' }], isError: true }; - softDeleteFile(fileId); - safeBroadcast(tripId, 'file:deleted', { fileId }); - return ok({ success: true }); - } - ); - - server.registerTool( - 'restore_file', - { - description: 'Restore a file from trash back to the active file list.', - inputSchema: { - tripId: z.number().int().positive(), - fileId: z.number().int().positive(), - }, - annotations: TOOL_ANNOTATIONS_WRITE, - }, - async ({ tripId, fileId }) => { - if (isDemoUser(userId)) return demoDenied(); - if (!canAccessTrip(tripId, userId)) return noAccess(); - const file = getDeletedFile(fileId, tripId); - if (!file) return { content: [{ type: 'text' as const, text: 'File not found in trash.' }], isError: true }; - const restored = restoreFile(fileId); - safeBroadcast(tripId, 'file:created', { file: restored }); - return ok({ file: restored }); - } - ); - - server.registerTool( - 'permanent_delete_file', - { - description: 'Permanently delete a file from trash. This cannot be undone — the file is removed from disk.', - inputSchema: { - tripId: z.number().int().positive(), - fileId: z.number().int().positive(), - }, - annotations: TOOL_ANNOTATIONS_DELETE, - }, - async ({ tripId, fileId }) => { - if (isDemoUser(userId)) return demoDenied(); - if (!canAccessTrip(tripId, userId)) return noAccess(); - const file = getDeletedFile(fileId, tripId); - if (!file) return { content: [{ type: 'text' as const, text: 'File not found in trash.' }], isError: true }; - permanentDeleteFile(file); - safeBroadcast(tripId, 'file:deleted', { fileId }); - return ok({ success: true }); - } - ); - - server.registerTool( - 'empty_trash', - { - description: 'Permanently delete all files in the trash for a trip. Cannot be undone.', - inputSchema: { - tripId: z.number().int().positive(), - }, - annotations: TOOL_ANNOTATIONS_DELETE, - }, - async ({ tripId }) => { - if (isDemoUser(userId)) return demoDenied(); - if (!canAccessTrip(tripId, userId)) return noAccess(); - const deleted = emptyTrash(tripId); - return ok({ success: true, deleted }); - } - ); - - server.registerTool( - 'link_file', - { - description: 'Link a file to a place, reservation, or assignment. The file must belong to the trip.', - inputSchema: { - tripId: z.number().int().positive(), - fileId: z.number().int().positive(), - place_id: z.number().int().positive().optional(), - reservation_id: z.number().int().positive().optional(), - assignment_id: z.number().int().positive().optional(), - }, - annotations: TOOL_ANNOTATIONS_WRITE, - }, - async ({ tripId, fileId, place_id, reservation_id, assignment_id }) => { - if (isDemoUser(userId)) return demoDenied(); - if (!canAccessTrip(tripId, userId)) return noAccess(); - const file = getFileById(fileId, tripId); - if (!file) return { content: [{ type: 'text' as const, text: 'File not found.' }], isError: true }; - const links = createFileLink(fileId, { - place_id: place_id ? String(place_id) : null, - reservation_id: reservation_id ? String(reservation_id) : null, - assignment_id: assignment_id ? String(assignment_id) : null, - }); - return ok({ success: true, links }); - } - ); - - server.registerTool( - 'unlink_file', - { - description: 'Remove a specific link between a file and a place/reservation/assignment. Use list_file_links to get the link ID.', - inputSchema: { - tripId: z.number().int().positive(), - fileId: z.number().int().positive(), - linkId: z.number().int().positive().describe('ID of the file link to remove'), - }, - annotations: TOOL_ANNOTATIONS_DELETE, - }, - async ({ tripId, fileId, linkId }) => { - if (isDemoUser(userId)) return demoDenied(); - if (!canAccessTrip(tripId, userId)) return noAccess(); - const file = getFileById(fileId, tripId); - if (!file) return { content: [{ type: 'text' as const, text: 'File not found.' }], isError: true }; - deleteFileLink(linkId, fileId); - return ok({ success: true }); - } - ); - - server.registerTool( - 'list_file_links', - { - description: 'List all entity links for a file (places, reservations, assignments it is attached to).', - inputSchema: { - tripId: z.number().int().positive(), - fileId: z.number().int().positive(), - }, - annotations: TOOL_ANNOTATIONS_READONLY, - }, - async ({ tripId, fileId }) => { - if (!canAccessTrip(tripId, userId)) return noAccess(); - const file = getFileById(fileId, tripId); - if (!file) return { content: [{ type: 'text' as const, text: 'File not found.' }], isError: true }; - const links = getFileLinks(fileId); - return ok({ links }); - } - ); -} diff --git a/server/src/mcp/tools/notifications.ts b/server/src/mcp/tools/notifications.ts index 4b848737..6c8b731e 100644 --- a/server/src/mcp/tools/notifications.ts +++ b/server/src/mcp/tools/notifications.ts @@ -4,8 +4,7 @@ import { isDemoUser } from '../../services/authService'; import { getNotifications, getUnreadCount, markRead as markNotificationRead, markUnread as markNotificationUnread, - markAllRead, deleteNotification, deleteAll as deleteAllNotifications, - respondToBoolean, + markAllRead, } from '../../services/inAppNotifications'; import { TOOL_ANNOTATIONS_READONLY, TOOL_ANNOTATIONS_WRITE, @@ -93,53 +92,4 @@ export function registerNotificationTools(server: McpServer, userId: number): vo return ok({ success: true, count }); } ); - - server.registerTool( - 'delete_notification', - { - description: 'Delete a single in-app notification.', - inputSchema: { - notificationId: z.number().int().positive(), - }, - annotations: TOOL_ANNOTATIONS_DELETE, - }, - async ({ notificationId }) => { - if (isDemoUser(userId)) return demoDenied(); - const success = deleteNotification(notificationId, userId); - if (!success) return { content: [{ type: 'text' as const, text: 'Notification not found.' }], isError: true }; - return ok({ success: true }); - } - ); - - server.registerTool( - 'delete_all_notifications', - { - description: "Delete all in-app notifications for the current user.", - inputSchema: {}, - annotations: TOOL_ANNOTATIONS_DELETE, - }, - async () => { - if (isDemoUser(userId)) return demoDenied(); - const count = deleteAllNotifications(userId); - return ok({ success: true, count }); - } - ); - - server.registerTool( - 'respond_to_notification', - { - description: 'Respond to a boolean (yes/no) notification such as a trip invite or poll.', - inputSchema: { - notificationId: z.number().int().positive(), - response: z.enum(['positive', 'negative']), - }, - annotations: TOOL_ANNOTATIONS_NON_IDEMPOTENT, - }, - async ({ notificationId, response }) => { - if (isDemoUser(userId)) return demoDenied(); - const result = await respondToBoolean(notificationId, userId, response); - if (!result.success) return { content: [{ type: 'text' as const, text: result.error ?? 'Failed to respond.' }], isError: true }; - return ok({ notification: result.notification }); - } - ); } diff --git a/server/tests/unit/mcp/tools-files.test.ts b/server/tests/unit/mcp/tools-files.test.ts deleted file mode 100644 index 5cdc46f5..00000000 --- a/server/tests/unit/mcp/tools-files.test.ts +++ /dev/null @@ -1,456 +0,0 @@ -/** - * Unit tests for MCP file tools: - * list_files, update_file_metadata, toggle_file_star, trash_file, restore_file, - * permanent_delete_file, empty_trash, link_file, unlink_file, list_file_links. - * Note: actual file-system deletion is not tested (files don't exist on disk in tests). - */ -import { describe, it, expect, vi, beforeAll, beforeEach, afterAll } from 'vitest'; - -const { testDb, dbMock } = vi.hoisted(() => { - const Database = require('better-sqlite3'); - const db = new Database(':memory:'); - db.exec('PRAGMA journal_mode = WAL'); - db.exec('PRAGMA foreign_keys = ON'); - db.exec('PRAGMA busy_timeout = 5000'); - const mock = { - db, - closeDb: () => {}, - reinitialize: () => {}, - getPlaceWithTags: () => null, - canAccessTrip: (tripId: any, userId: number) => - db.prepare(`SELECT t.id, t.user_id FROM trips t LEFT JOIN trip_members m ON m.trip_id = t.id AND m.user_id = ? WHERE t.id = ? AND (t.user_id = ? OR m.user_id IS NOT NULL)`).get(userId, tripId, userId), - isOwner: (tripId: any, userId: number) => - !!db.prepare('SELECT id FROM trips WHERE id = ? AND user_id = ?').get(tripId, userId), - }; - return { testDb: db, dbMock: mock }; -}); - -vi.mock('../../../src/db/database', () => dbMock); -vi.mock('../../../src/config', () => ({ - JWT_SECRET: 'test-jwt-secret-for-trek-testing-only', - ENCRYPTION_KEY: 'a1b2c3d4e5f6a7b8c9d0e1f2a3b4c5d6a7b8c9d0e1f2a3b4c5d6a7b8c9d0e1f2', - updateJwtSecret: () => {}, -})); - -const { broadcastMock } = vi.hoisted(() => ({ broadcastMock: vi.fn() })); -vi.mock('../../../src/websocket', () => ({ broadcast: broadcastMock })); - -import { createTables } from '../../../src/db/schema'; -import { runMigrations } from '../../../src/db/migrations'; -import { resetTestDb } from '../../helpers/test-db'; -import { createUser, createTrip } from '../../helpers/factories'; -import { createMcpHarness, parseToolResult, type McpHarness } from '../../helpers/mcp-harness'; - -beforeAll(() => { - createTables(testDb); - runMigrations(testDb); -}); - -beforeEach(() => { - resetTestDb(testDb); - broadcastMock.mockClear(); - delete process.env.DEMO_MODE; -}); - -afterAll(() => { - testDb.close(); -}); - -async function withHarness(userId: number, fn: (h: McpHarness) => Promise) { - const h = await createMcpHarness({ userId, withResources: false }); - try { await fn(h); } finally { await h.cleanup(); } -} - -/** Helper: insert a fake file row directly (no actual file on disk needed) */ -function createFileRow(tripId: number, overrides: Partial<{ - filename: string; original_name: string; deleted_at: string | null; starred: number -}> = {}) { - const result = testDb.prepare(` - INSERT INTO trip_files (trip_id, filename, original_name, file_size, mime_type) - VALUES (?, ?, ?, ?, ?) - `).run( - tripId, - overrides.filename ?? `test-${Date.now()}.txt`, - overrides.original_name ?? 'test.txt', - 1024, - 'text/plain' - ); - const id = result.lastInsertRowid as number; - if (overrides.starred !== undefined) { - testDb.prepare('UPDATE trip_files SET starred = ? WHERE id = ?').run(overrides.starred, id); - } - if (overrides.deleted_at !== undefined) { - testDb.prepare('UPDATE trip_files SET deleted_at = ? WHERE id = ?').run(overrides.deleted_at, id); - } - return testDb.prepare('SELECT * FROM trip_files WHERE id = ?').get(id) as any; -} - -// --------------------------------------------------------------------------- -// list_files -// --------------------------------------------------------------------------- - -describe('Tool: list_files', () => { - it('returns empty list for a new trip', async () => { - const { user } = createUser(testDb); - const trip = createTrip(testDb, user.id); - await withHarness(user.id, async (h) => { - const result = await h.client.callTool({ name: 'list_files', arguments: { tripId: trip.id } }); - const data = parseToolResult(result) as any; - expect(data.files).toEqual([]); - }); - }); - - it('returns active files', async () => { - const { user } = createUser(testDb); - const trip = createTrip(testDb, user.id); - createFileRow(trip.id, { original_name: 'doc.pdf' }); - await withHarness(user.id, async (h) => { - const result = await h.client.callTool({ name: 'list_files', arguments: { tripId: trip.id } }); - const data = parseToolResult(result) as any; - expect(data.files).toHaveLength(1); - }); - }); - - it('returns trash when showTrash=true', async () => { - const { user } = createUser(testDb); - const trip = createTrip(testDb, user.id); - createFileRow(trip.id, { deleted_at: new Date().toISOString() }); - await withHarness(user.id, async (h) => { - const result = await h.client.callTool({ name: 'list_files', arguments: { tripId: trip.id, showTrash: true } }); - const data = parseToolResult(result) as any; - expect(data.files).toHaveLength(1); - }); - }); - - it('returns access denied for non-member', async () => { - const { user } = createUser(testDb); - const { user: other } = createUser(testDb); - const trip = createTrip(testDb, other.id); - await withHarness(user.id, async (h) => { - const result = await h.client.callTool({ name: 'list_files', arguments: { tripId: trip.id } }); - expect(result.isError).toBe(true); - }); - }); -}); - -// --------------------------------------------------------------------------- -// update_file_metadata -// --------------------------------------------------------------------------- - -describe('Tool: update_file_metadata', () => { - it('updates file description', async () => { - const { user } = createUser(testDb); - const trip = createTrip(testDb, user.id); - const file = createFileRow(trip.id); - await withHarness(user.id, async (h) => { - const result = await h.client.callTool({ - name: 'update_file_metadata', - arguments: { tripId: trip.id, fileId: file.id, description: 'My document' }, - }); - const data = parseToolResult(result) as any; - expect(data.file.description).toBe('My document'); - }); - }); - - it('broadcasts file:updated event', async () => { - const { user } = createUser(testDb); - const trip = createTrip(testDb, user.id); - const file = createFileRow(trip.id); - await withHarness(user.id, async (h) => { - await h.client.callTool({ - name: 'update_file_metadata', - arguments: { tripId: trip.id, fileId: file.id, description: 'Updated' }, - }); - expect(broadcastMock).toHaveBeenCalledWith(trip.id, 'file:updated', expect.any(Object)); - }); - }); - - it('returns error for file not found', async () => { - const { user } = createUser(testDb); - const trip = createTrip(testDb, user.id); - await withHarness(user.id, async (h) => { - const result = await h.client.callTool({ - name: 'update_file_metadata', - arguments: { tripId: trip.id, fileId: 99999, description: 'X' }, - }); - expect(result.isError).toBe(true); - }); - }); - - it('blocks demo user', async () => { - process.env.DEMO_MODE = 'true'; - const { user } = createUser(testDb, { email: 'demo@nomad.app' }); - const trip = createTrip(testDb, user.id); - const file = createFileRow(trip.id); - await withHarness(user.id, async (h) => { - const result = await h.client.callTool({ - name: 'update_file_metadata', - arguments: { tripId: trip.id, fileId: file.id, description: 'X' }, - }); - expect(result.isError).toBe(true); - }); - }); -}); - -// --------------------------------------------------------------------------- -// toggle_file_star -// --------------------------------------------------------------------------- - -describe('Tool: toggle_file_star', () => { - it('stars an unstarred file', async () => { - const { user } = createUser(testDb); - const trip = createTrip(testDb, user.id); - const file = createFileRow(trip.id, { starred: 0 }); - await withHarness(user.id, async (h) => { - const result = await h.client.callTool({ name: 'toggle_file_star', arguments: { tripId: trip.id, fileId: file.id } }); - const data = parseToolResult(result) as any; - expect(data.file.starred).toBe(1); - }); - }); - - it('unstars a starred file', async () => { - const { user } = createUser(testDb); - const trip = createTrip(testDb, user.id); - const file = createFileRow(trip.id, { starred: 1 }); - await withHarness(user.id, async (h) => { - const result = await h.client.callTool({ name: 'toggle_file_star', arguments: { tripId: trip.id, fileId: file.id } }); - const data = parseToolResult(result) as any; - expect(data.file.starred).toBe(0); - }); - }); - - it('broadcasts file:updated event', async () => { - const { user } = createUser(testDb); - const trip = createTrip(testDb, user.id); - const file = createFileRow(trip.id); - await withHarness(user.id, async (h) => { - await h.client.callTool({ name: 'toggle_file_star', arguments: { tripId: trip.id, fileId: file.id } }); - expect(broadcastMock).toHaveBeenCalledWith(trip.id, 'file:updated', expect.any(Object)); - }); - }); - - it('returns error for file not found', async () => { - const { user } = createUser(testDb); - const trip = createTrip(testDb, user.id); - await withHarness(user.id, async (h) => { - const result = await h.client.callTool({ name: 'toggle_file_star', arguments: { tripId: trip.id, fileId: 99999 } }); - expect(result.isError).toBe(true); - }); - }); -}); - -// --------------------------------------------------------------------------- -// trash_file -// --------------------------------------------------------------------------- - -describe('Tool: trash_file', () => { - it('soft-deletes a file', async () => { - const { user } = createUser(testDb); - const trip = createTrip(testDb, user.id); - const file = createFileRow(trip.id); - await withHarness(user.id, async (h) => { - const result = await h.client.callTool({ name: 'trash_file', arguments: { tripId: trip.id, fileId: file.id } }); - const data = parseToolResult(result) as any; - expect(data.success).toBe(true); - const dbFile = testDb.prepare('SELECT deleted_at FROM trip_files WHERE id = ?').get(file.id) as any; - expect(dbFile.deleted_at).toBeTruthy(); - }); - }); - - it('broadcasts file:deleted event', async () => { - const { user } = createUser(testDb); - const trip = createTrip(testDb, user.id); - const file = createFileRow(trip.id); - await withHarness(user.id, async (h) => { - await h.client.callTool({ name: 'trash_file', arguments: { tripId: trip.id, fileId: file.id } }); - expect(broadcastMock).toHaveBeenCalledWith(trip.id, 'file:deleted', expect.any(Object)); - }); - }); - - it('returns error for file not found', async () => { - const { user } = createUser(testDb); - const trip = createTrip(testDb, user.id); - await withHarness(user.id, async (h) => { - const result = await h.client.callTool({ name: 'trash_file', arguments: { tripId: trip.id, fileId: 99999 } }); - expect(result.isError).toBe(true); - }); - }); -}); - -// --------------------------------------------------------------------------- -// restore_file -// --------------------------------------------------------------------------- - -describe('Tool: restore_file', () => { - it('restores a trashed file', async () => { - const { user } = createUser(testDb); - const trip = createTrip(testDb, user.id); - const file = createFileRow(trip.id, { deleted_at: new Date().toISOString() }); - await withHarness(user.id, async (h) => { - const result = await h.client.callTool({ name: 'restore_file', arguments: { tripId: trip.id, fileId: file.id } }); - const data = parseToolResult(result) as any; - expect(data.file).toBeTruthy(); - const dbFile = testDb.prepare('SELECT deleted_at FROM trip_files WHERE id = ?').get(file.id) as any; - expect(dbFile.deleted_at).toBeNull(); - }); - }); - - it('broadcasts file:created event on restore', async () => { - const { user } = createUser(testDb); - const trip = createTrip(testDb, user.id); - const file = createFileRow(trip.id, { deleted_at: new Date().toISOString() }); - await withHarness(user.id, async (h) => { - await h.client.callTool({ name: 'restore_file', arguments: { tripId: trip.id, fileId: file.id } }); - expect(broadcastMock).toHaveBeenCalledWith(trip.id, 'file:created', expect.any(Object)); - }); - }); - - it('returns error for file not in trash', async () => { - const { user } = createUser(testDb); - const trip = createTrip(testDb, user.id); - const file = createFileRow(trip.id); // not in trash - await withHarness(user.id, async (h) => { - const result = await h.client.callTool({ name: 'restore_file', arguments: { tripId: trip.id, fileId: file.id } }); - expect(result.isError).toBe(true); - }); - }); -}); - -// --------------------------------------------------------------------------- -// permanent_delete_file -// --------------------------------------------------------------------------- - -describe('Tool: permanent_delete_file', () => { - it('permanently removes a trashed file', async () => { - const { user } = createUser(testDb); - const trip = createTrip(testDb, user.id); - const file = createFileRow(trip.id, { deleted_at: new Date().toISOString() }); - await withHarness(user.id, async (h) => { - const result = await h.client.callTool({ name: 'permanent_delete_file', arguments: { tripId: trip.id, fileId: file.id } }); - const data = parseToolResult(result) as any; - expect(data.success).toBe(true); - expect(testDb.prepare('SELECT id FROM trip_files WHERE id = ?').get(file.id)).toBeUndefined(); - }); - }); - - it('returns error for file not in trash', async () => { - const { user } = createUser(testDb); - const trip = createTrip(testDb, user.id); - const file = createFileRow(trip.id); // active file - await withHarness(user.id, async (h) => { - const result = await h.client.callTool({ name: 'permanent_delete_file', arguments: { tripId: trip.id, fileId: file.id } }); - expect(result.isError).toBe(true); - }); - }); -}); - -// --------------------------------------------------------------------------- -// empty_trash -// --------------------------------------------------------------------------- - -describe('Tool: empty_trash', () => { - it('deletes all trashed files', async () => { - const { user } = createUser(testDb); - const trip = createTrip(testDb, user.id); - createFileRow(trip.id, { deleted_at: new Date().toISOString() }); - createFileRow(trip.id, { deleted_at: new Date().toISOString() }); - await withHarness(user.id, async (h) => { - const result = await h.client.callTool({ name: 'empty_trash', arguments: { tripId: trip.id } }); - const data = parseToolResult(result) as any; - expect(data.success).toBe(true); - expect(data.deleted).toBe(2); - }); - }); - - it('returns 0 when trash is already empty', async () => { - const { user } = createUser(testDb); - const trip = createTrip(testDb, user.id); - await withHarness(user.id, async (h) => { - const result = await h.client.callTool({ name: 'empty_trash', arguments: { tripId: trip.id } }); - const data = parseToolResult(result) as any; - expect(data.deleted).toBe(0); - }); - }); -}); - -// --------------------------------------------------------------------------- -// link_file / unlink_file / list_file_links -// --------------------------------------------------------------------------- - -describe('Tool: link_file', () => { - it('creates a link to a place', async () => { - const { user } = createUser(testDb); - const trip = createTrip(testDb, user.id); - const file = createFileRow(trip.id); - // Insert a fake place - const placeResult = testDb.prepare("INSERT INTO places (trip_id, name) VALUES (?, 'Test Place')").run(trip.id); - const placeId = placeResult.lastInsertRowid as number; - await withHarness(user.id, async (h) => { - const result = await h.client.callTool({ - name: 'link_file', - arguments: { tripId: trip.id, fileId: file.id, place_id: placeId }, - }); - const data = parseToolResult(result) as any; - expect(data.success).toBe(true); - expect(Array.isArray(data.links)).toBe(true); - }); - }); - - it('returns error for file not found', async () => { - const { user } = createUser(testDb); - const trip = createTrip(testDb, user.id); - await withHarness(user.id, async (h) => { - const result = await h.client.callTool({ name: 'link_file', arguments: { tripId: trip.id, fileId: 99999, place_id: 1 } }); - expect(result.isError).toBe(true); - }); - }); -}); - -describe('Tool: unlink_file', () => { - it('removes a file link', async () => { - const { user } = createUser(testDb); - const trip = createTrip(testDb, user.id); - const file = createFileRow(trip.id); - // Insert a real place then a link - const placeRes = testDb.prepare("INSERT INTO places (trip_id, name) VALUES (?, 'P')").run(trip.id); - const placeId = placeRes.lastInsertRowid as number; - const linkResult = testDb.prepare( - 'INSERT INTO file_links (file_id, place_id) VALUES (?, ?)' - ).run(file.id, placeId); - const linkId = linkResult.lastInsertRowid as number; - await withHarness(user.id, async (h) => { - const result = await h.client.callTool({ name: 'unlink_file', arguments: { tripId: trip.id, fileId: file.id, linkId } }); - const data = parseToolResult(result) as any; - expect(data.success).toBe(true); - expect(testDb.prepare('SELECT id FROM file_links WHERE id = ?').get(linkId)).toBeUndefined(); - }); - }); -}); - -describe('Tool: list_file_links', () => { - it('returns links for a file', async () => { - const { user } = createUser(testDb); - const trip = createTrip(testDb, user.id); - const file = createFileRow(trip.id); - // Insert a real place then a link - const placeRes = testDb.prepare("INSERT INTO places (trip_id, name) VALUES (?, 'P')").run(trip.id); - const placeId = placeRes.lastInsertRowid as number; - testDb.prepare('INSERT INTO file_links (file_id, place_id) VALUES (?, ?)').run(file.id, placeId); - await withHarness(user.id, async (h) => { - const result = await h.client.callTool({ name: 'list_file_links', arguments: { tripId: trip.id, fileId: file.id } }); - const data = parseToolResult(result) as any; - expect(data.links).toHaveLength(1); - }); - }); - - it('returns empty array for file with no links', async () => { - const { user } = createUser(testDb); - const trip = createTrip(testDb, user.id); - const file = createFileRow(trip.id); - await withHarness(user.id, async (h) => { - const result = await h.client.callTool({ name: 'list_file_links', arguments: { tripId: trip.id, fileId: file.id } }); - const data = parseToolResult(result) as any; - expect(data.links).toHaveLength(0); - }); - }); -}); diff --git a/server/tests/unit/mcp/tools-notifications.test.ts b/server/tests/unit/mcp/tools-notifications.test.ts index ede39cde..bf44b3d8 100644 --- a/server/tests/unit/mcp/tools-notifications.test.ts +++ b/server/tests/unit/mcp/tools-notifications.test.ts @@ -255,61 +255,6 @@ describe('Tool: mark_all_notifications_read', () => { }); }); -// --------------------------------------------------------------------------- -// delete_notification -// --------------------------------------------------------------------------- - -describe('Tool: delete_notification', () => { - it('removes the notification row and returns success', async () => { - const { user } = createUser(testDb); - const notif = createNotification(testDb, user.id) as any; - await withHarness(user.id, async (h) => { - const result = await h.client.callTool({ - name: 'delete_notification', - arguments: { notificationId: notif.id }, - }); - const data = parseToolResult(result) as any; - expect(data.success).toBe(true); - expect(testDb.prepare('SELECT id FROM notifications WHERE id = ?').get(notif.id)).toBeUndefined(); - }); - }); - - it('returns isError for non-existent notification', async () => { - const { user } = createUser(testDb); - await withHarness(user.id, async (h) => { - const result = await h.client.callTool({ - name: 'delete_notification', - arguments: { notificationId: 99999 }, - }); - expect(result.isError).toBe(true); - }); - }); -}); - -// --------------------------------------------------------------------------- -// delete_all_notifications -// --------------------------------------------------------------------------- - -describe('Tool: delete_all_notifications', () => { - it('clears all notifications for user and returns count', async () => { - const { user } = createUser(testDb); - const { user: other } = createUser(testDb); - createNotification(testDb, user.id); - createNotification(testDb, user.id); - createNotification(testDb, other.id); // should not be deleted - await withHarness(user.id, async (h) => { - const result = await h.client.callTool({ name: 'delete_all_notifications', arguments: {} }); - const data = parseToolResult(result) as any; - expect(data.success).toBe(true); - expect(data.count).toBe(2); - const remaining = (testDb.prepare('SELECT COUNT(*) as c FROM notifications WHERE recipient_id = ?').get(user.id) as any).c; - expect(remaining).toBe(0); - const otherRemaining = (testDb.prepare('SELECT COUNT(*) as c FROM notifications WHERE recipient_id = ?').get(other.id) as any).c; - expect(otherRemaining).toBe(1); - }); - }); -}); - // --------------------------------------------------------------------------- // Resource: trek://notifications/in-app // ---------------------------------------------------------------------------