TREK/server/tests/unit/db/repositories/PhotoProviderFields.repository.test.ts

import { afterAll, beforeAll, beforeEach, describe, expect, it } from 'vitest';
import { createSnapshotTestDb } from '../../../helpers/db-mock';
import { resetTestDb } from '../../../helpers/test-db';
import { createTestOrm, type TestOrm } from '../../../helpers/test-orm';
import { PhotoProviderFields } from '../../../../src/db/entities/PhotoProviderFields.entity';
import { PhotoProviders } from '../../../../src/db/entities/PhotoProviders.entity';
import { deleteRows, insertRow } from '../../../helpers/factories/rows';
import type { PhotoProviderFieldsRepository } from '../../../../src/db/repositories/PhotoProviderFields.repository';

const testDb = createSnapshotTestDb();
let t: TestOrm;
let fields: PhotoProviderFieldsRepository;

beforeAll(async () => {
  t = await createTestOrm(testDb);
  fields = t.repo(PhotoProviderFields);
});
beforeEach(async () => {
  resetTestDb(testDb);
  await deleteRows(t, PhotoProviderFields);
  await deleteRows(t, PhotoProviders);
  t.clear();
});
afterAll(async () => {
  await t.close();
  testDb.close();
});

async function insertProvider(id: string): Promise<void> {
  await insertRow(t, PhotoProviders, { id, name: id, icon: 'Image', enabled: 1, sort_order: 0 });
}

async function insertField(row: {
  provider_id: string;
  field_key: string;
  label: string;
  input_type?: string;
  placeholder?: string | null;
  hint?: string | null;
  required?: 0 | 1;
  secret?: 0 | 1;
  settings_key?: string | null;
  payload_key?: string | null;
  sort_order?: number;
}): Promise<void> {
  await insertRow(t, PhotoProviderFields, {
    provider: row.provider_id,
    field_key: row.field_key,
    label: row.label,
    input_type: row.input_type ?? 'text',
    placeholder: row.placeholder ?? null,
    hint: row.hint ?? null,
    required: row.required ?? 0,
    secret: row.secret ?? 0,
    settings_key: row.settings_key ?? null,
    payload_key: row.payload_key ?? null,
    sort_order: row.sort_order ?? 0,
  });
}

describe('PhotoProviderFieldsRepository.listAllOrdered', () => {
  it('ADDONSPPFREPO-001: returns every field, ordered by sort_order then id, across all providers', async () => {
    await insertProvider('immich');
    await insertProvider('synology');
    await insertField({ provider_id: 'synology', field_key: 'url', label: 'URL', sort_order: 1 });
    await insertField({ provider_id: 'immich', field_key: 'url', label: 'URL', sort_order: 0 });
    await insertField({ provider_id: 'immich', field_key: 'token', label: 'Token', sort_order: 0 });

    const rows = await fields.listAllOrdered();
    // Two rows share sort_order 0 — insertion order (ascending id) breaks the tie.
    expect(rows.map((r) => [r.provider_id, r.field_key])).toEqual([
      ['immich', 'url'],
      ['immich', 'token'],
      ['synology', 'url'],
    ]);
  });

  it('ADDONSPPFREPO-002: the provider_id twin reads back from find(), same as trip_id on Days', async () => {
    await insertProvider('immich');
    await insertField({ provider_id: 'immich', field_key: 'url', label: 'URL' });
    const [row] = await fields.listAllOrdered();
    expect(row.provider_id).toBe('immich');
  });

  it('ADDONSPPFREPO-003: required/secret come back as the raw stored integer, matching the entity type (not a coerced boolean)', async () => {
    await insertProvider('immich');
    await insertField({ provider_id: 'immich', field_key: 'token', label: 'Token', required: 1, secret: 1 });
    const [row] = await fields.listAllOrdered();
    expect(row.required).toBe(1);
    expect(row.secret).toBe(1);
    expect(typeof row.required).toBe('number');
  });

  it('ADDONSPPFREPO-004: nullable columns (placeholder, hint, settings_key, payload_key) come back null when unset', async () => {
    await insertProvider('immich');
    await insertField({ provider_id: 'immich', field_key: 'k', label: 'L' });
    const [row] = await fields.listAllOrdered();
    expect(row.placeholder).toBeNull();
    expect(row.hint).toBeNull();
    expect(row.settings_key).toBeNull();
    expect(row.payload_key).toBeNull();
  });

  it('ADDONSPPFREPO-005: an empty table returns an empty array', async () => {
    expect(await fields.listAllOrdered()).toEqual([]);
  });
});

describe('PhotoProviderFieldsRepository.listAllOrderedForAdminShelf', () => {
  // Plan 3i Task 4 fix wave: `listAllOrderedForAdminShelf` used to project a
  // bare `'provider_id'` — the `persist(false)` shadow of the `provider`
  // relation — which MikroORM's `fields` selector never hydrates (same trap
  // `RoadtripDayBoundariesRepository` and `TripPhotosRepository` document).
  // Every row came back with `provider_id: undefined`, so `listAddons`
  // grouped every photo provider's fields under `undefined` and every
  // provider answered `fields: []`. Full-key parity against AD28's legacy
  // `SELECT provider_id, field_key, label, input_type, placeholder,
  // required, secret, settings_key, payload_key, sort_order FROM
  // photo_provider_fields ORDER BY sort_order, id` pins every column, not
  // just `provider_id`, so a future narrowed-projection regression on any
  // other column fails here too.
  it('AD28: returns the full legacy row shape, ordered by sort_order then id, across all providers', async () => {
    await insertProvider('immich');
    await insertProvider('synology');
    await insertField({ provider_id: 'synology', field_key: 'url', label: 'Server URL', input_type: 'text', placeholder: 'https://photos.example.com', hint: 'ignored: not in the AD28 shape', required: 1, secret: 0, settings_key: 'synology_url', payload_key: 'url', sort_order: 1 });
    await insertField({ provider_id: 'immich', field_key: 'url', label: 'Server URL', input_type: 'text', placeholder: 'https://immich.example.com', required: 1, secret: 0, settings_key: 'immich_url', payload_key: 'url', sort_order: 0 });
    await insertField({ provider_id: 'immich', field_key: 'api_key', label: 'API Key', input_type: 'password', required: 1, secret: 1, settings_key: 'immich_api_key', payload_key: 'apiKey', sort_order: 1 });

    const rows = await fields.listAllOrderedForAdminShelf();
    // sort_order 0 first; the sort_order-1 tie breaks by id (insertion order:
    // synology's url row was inserted before immich's api_key row).
    expect(rows).toEqual([
      { provider_id: 'immich', field_key: 'url', label: 'Server URL', input_type: 'text', placeholder: 'https://immich.example.com', required: 1, secret: 0, settings_key: 'immich_url', payload_key: 'url', sort_order: 0 },
      { provider_id: 'synology', field_key: 'url', label: 'Server URL', input_type: 'text', placeholder: 'https://photos.example.com', required: 1, secret: 0, settings_key: 'synology_url', payload_key: 'url', sort_order: 1 },
      { provider_id: 'immich', field_key: 'api_key', label: 'API Key', input_type: 'password', placeholder: null, required: 1, secret: 1, settings_key: 'immich_api_key', payload_key: 'apiKey', sort_order: 1 },
    ]);
  });

  it('AD28: an empty table returns an empty array', async () => {
    expect(await fields.listAllOrderedForAdminShelf()).toEqual([]);
  });
});