mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-10-18 21:16:47 +00:00
Maurice
fb363f22c8
Measured on 128 places out of a real trip to Japan, all saved through the old search. Index alone: 51.6 percent inside the top five. Index and OpenStreetMap alternating: 72.7 percent. Two cleverer orderings were tried first and both lost. A score threshold cannot separate the cases at all: at 0.75 it catches 19 of 62 misses and throws away 6 of 66 hits. Promoting results whose name matches what was typed is worse than it sounds, because "Hase Station" shares a word with "Hase-dera" while OpenStreetMap answers in the local language and returns the right temple under a name that shares nothing: that rule put seven weak index matches ahead of the correct answer, which landed at position eight. Alternating puts it at position two. So the merge does not rank. Each source keeps its own ordering and they take turns, index first. An exact business match still opens the list; a landmark Overture does not carry is second rather than eleventh.
84 lines
3.9 KiB
TypeScript
84 lines
3.9 KiB
TypeScript
/**
|
|
* MAPS-MERGE-001..008 — showing the index's answer and OpenStreetMap's together.
|
|
*
|
|
* Why this exists, in numbers. 128 places out of a real trip to Japan, all
|
|
* saved through the old search, replayed against the index: 51.6 percent came
|
|
* back inside the top five. For most of the rest the index returned the shops
|
|
* AROUND the landmark instead of nothing, which is worse than nothing, because
|
|
* ten plausible wrong answers look like an answer and the user never learns the
|
|
* temple was one query away in OpenStreetMap.
|
|
*/
|
|
import { describe, it, expect } from 'vitest';
|
|
import { mergeSearchResults } from '../../../src/nest/maps/maps.helpers';
|
|
|
|
const p = (name: string, lat: number, lng: number, source: string) => ({
|
|
name,
|
|
lat,
|
|
lng,
|
|
source,
|
|
osm_id: `${source}:${name}`,
|
|
});
|
|
|
|
describe('mergeSearchResults', () => {
|
|
it('MAPS-MERGE-001: puts the landmark second, not eleventh', () => {
|
|
// The Hase-dera case. The index has the shops around the temple and not the
|
|
// temple; OpenStreetMap has the temple, under its Japanese name.
|
|
const index = Array.from({ length: 10 }, (_, i) =>
|
|
p(`Shop ${i}`, 35.31 + i / 1000, 139.53, 'trek-places'),
|
|
);
|
|
const osm = [p('長谷寺', 35.3125, 139.5335, 'openstreetmap')];
|
|
const out = mergeSearchResults(index, osm);
|
|
expect(out[1].name).toBe('長谷寺');
|
|
});
|
|
|
|
it('MAPS-MERGE-002: leaves a good index match at the top', () => {
|
|
const index = [p("L'Osteria Rostock", 54.0879, 12.1408, 'trek-places')];
|
|
const osm = [p('Steinstrasse', 54.09, 12.15, 'openstreetmap')];
|
|
expect(mergeSearchResults(index, osm)[0].name).toBe("L'Osteria Rostock");
|
|
});
|
|
|
|
it('MAPS-MERGE-003: keeps one copy of a place both sources know', () => {
|
|
// The index's copy, because that is the one carrying a stable id, contact
|
|
// details and hours.
|
|
const index = [p("L'Osteria", 54.0879, 12.1408, 'trek-places')];
|
|
const osm = [p("L'Osteria", 54.08792, 12.14082, 'openstreetmap')];
|
|
const out = mergeSearchResults(index, osm);
|
|
expect(out).toHaveLength(1);
|
|
expect(out[0].source).toBe('trek-places');
|
|
});
|
|
|
|
it('MAPS-MERGE-004: two neighbouring shops both survive', () => {
|
|
// 60 m is the dedupe distance, and the names have to agree as well: a
|
|
// temple and the coffee shop at its gate are closer than that.
|
|
const index = [p('Bakery A', 54.0879, 12.1408, 'trek-places')];
|
|
const osm = [p('Bakery B', 54.0889, 12.1408, 'openstreetmap')];
|
|
expect(mergeSearchResults(index, osm)).toHaveLength(2);
|
|
});
|
|
|
|
it('MAPS-MERGE-005: a source that answered nothing changes nothing', () => {
|
|
const index = [p("L'Osteria", 54.0879, 12.1408, 'trek-places')];
|
|
expect(mergeSearchResults(index, [])).toEqual(index);
|
|
expect(mergeSearchResults([], index)).toEqual(index);
|
|
});
|
|
|
|
it('MAPS-MERGE-006: alternates, index first, and keeps each order intact', () => {
|
|
const index = [p('I1', 1, 1, 'trek-places'), p('I2', 2, 2, 'trek-places')];
|
|
const osm = [p('O1', 3, 3, 'openstreetmap'), p('O2', 4, 4, 'openstreetmap')];
|
|
expect(mergeSearchResults(index, osm).map((r) => r.name)).toEqual(['I1', 'O1', 'I2', 'O2']);
|
|
});
|
|
|
|
it('MAPS-MERGE-007: honours the cap without cutting mid-pair', () => {
|
|
const many = Array.from({ length: 12 }, (_, i) => p(`Place ${i}`, 50 + i, 10 + i, 'trek-places'));
|
|
const other = Array.from({ length: 12 }, (_, i) => p(`Other ${i}`, 20 + i, 30 + i, 'openstreetmap'));
|
|
expect(mergeSearchResults(many, other, 5)).toHaveLength(5);
|
|
});
|
|
|
|
it('MAPS-MERGE-008: a result without coordinates is kept, not deduped away', () => {
|
|
// Nominatim occasionally answers with an unparseable coordinate. Dropping
|
|
// the row would lose a result; treating it as "not near anything" keeps it.
|
|
const index = [p('A', 54, 12, 'trek-places')];
|
|
const osm = [{ name: 'B', lat: null, lng: null, source: 'openstreetmap' }];
|
|
expect(mergeSearchResults(index, osm)).toHaveLength(2);
|
|
});
|
|
});
|