mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-10-22 15:06:32 +00:00
Maurice
aacc7f2c8d
"Open packing list" switched to the Lists tab but left it on whichever sub-tab was open last, so someone who had been in the to-dos landed there. It now picks the packing side first, and a Lists tab already on screen follows the choice; storage that is blocked no longer throws either. With the Packing addon off, "Remove link" let go of the link on one click, and the link cannot be made again until Packing is back on. It now opens the tour's packing dialog with only the dimmed link and the Remove link and Cancel buttons, so nothing changes without a second, deliberate click.
87 lines
4.1 KiB
TypeScript
87 lines
4.1 KiB
TypeScript
import { act, renderHook } from '@testing-library/react';
|
|
import { describe, expect, it, vi } from 'vitest';
|
|
|
|
import { rememberListsSubTab, useListsSubTab } from './useListsSubTab';
|
|
|
|
// FE-HOOK-LISTSTAB-001 to FE-HOOK-LISTSTAB-006
|
|
|
|
describe('useListsSubTab', () => {
|
|
it('FE-HOOK-LISTSTAB-001: opens on packing when nothing is stored for the trip', () => {
|
|
const { result } = renderHook(() => useListsSubTab(7));
|
|
expect(result.current[0]).toBe('packing');
|
|
});
|
|
|
|
it('FE-HOOK-LISTSTAB-002: reopens the sub-tab stored for that trip, not another one', () => {
|
|
sessionStorage.setItem('trip-lists-subtab-7', 'todo');
|
|
sessionStorage.setItem('trip-lists-subtab-8', 'packing');
|
|
expect(renderHook(() => useListsSubTab(7)).result.current[0]).toBe('todo');
|
|
expect(renderHook(() => useListsSubTab(8)).result.current[0]).toBe('packing');
|
|
expect(renderHook(() => useListsSubTab(7, { onlyKnownTabs: true })).result.current[0]).toBe('todo');
|
|
});
|
|
|
|
it('FE-HOOK-LISTSTAB-003: the desktop takes whatever is stored, the phone only a tab it knows', () => {
|
|
sessionStorage.setItem('trip-lists-subtab-7', 'files');
|
|
expect(renderHook(() => useListsSubTab(7)).result.current[0]).toBe('files');
|
|
expect(renderHook(() => useListsSubTab(7, { onlyKnownTabs: true })).result.current[0]).toBe('packing');
|
|
});
|
|
|
|
it('FE-HOOK-LISTSTAB-004: an empty stored value falls back to packing on both', () => {
|
|
sessionStorage.setItem('trip-lists-subtab-7', '');
|
|
expect(renderHook(() => useListsSubTab(7)).result.current[0]).toBe('packing');
|
|
expect(renderHook(() => useListsSubTab(7, { onlyKnownTabs: true })).result.current[0]).toBe('packing');
|
|
});
|
|
|
|
it('FE-HOOK-LISTSTAB-005: switching shows the new tab and stores it under the trip key', () => {
|
|
const { result } = renderHook(() => useListsSubTab(7, { onlyKnownTabs: true }));
|
|
act(() => result.current[1]('todo'));
|
|
expect(result.current[0]).toBe('todo');
|
|
expect(sessionStorage.getItem('trip-lists-subtab-7')).toBe('todo');
|
|
act(() => result.current[1]('packing'));
|
|
expect(result.current[0]).toBe('packing');
|
|
expect(sessionStorage.getItem('trip-lists-subtab-7')).toBe('packing');
|
|
});
|
|
|
|
it('FE-HOOK-LISTSTAB-006: a choice made on one surface is what the other opens with', () => {
|
|
const desktop = renderHook(() => useListsSubTab(3));
|
|
act(() => desktop.result.current[1]('todo'));
|
|
expect(renderHook(() => useListsSubTab(3, { onlyKnownTabs: true })).result.current[0]).toBe('todo');
|
|
});
|
|
});
|
|
|
|
// FE-HOOK-LISTSTAB-007 to FE-HOOK-LISTSTAB-009: picking the sub-tab from outside the Lists tab.
|
|
describe('rememberListsSubTab', () => {
|
|
it('FE-HOOK-LISTSTAB-007: the Lists tab opens on the sub-tab picked before it was on screen', () => {
|
|
sessionStorage.setItem('trip-lists-subtab-7', 'todo');
|
|
rememberListsSubTab(7, 'packing');
|
|
expect(renderHook(() => useListsSubTab(7)).result.current[0]).toBe('packing');
|
|
});
|
|
|
|
it('FE-HOOK-LISTSTAB-008: a Lists tab already on screen follows, one for another trip does not', () => {
|
|
sessionStorage.setItem('trip-lists-subtab-7', 'todo');
|
|
sessionStorage.setItem('trip-lists-subtab-8', 'todo');
|
|
const same = renderHook(() => useListsSubTab(7));
|
|
const other = renderHook(() => useListsSubTab(8));
|
|
act(() => rememberListsSubTab(7, 'packing'));
|
|
expect(same.result.current[0]).toBe('packing');
|
|
expect(other.result.current[0]).toBe('todo');
|
|
same.unmount();
|
|
act(() => rememberListsSubTab(7, 'todo'));
|
|
expect(sessionStorage.getItem('trip-lists-subtab-7')).toBe('todo');
|
|
});
|
|
|
|
it('FE-HOOK-LISTSTAB-009: blocked storage still switches the tab on screen and does not throw', () => {
|
|
const { result } = renderHook(() => useListsSubTab(7));
|
|
const setItem = vi.spyOn(Storage.prototype, 'setItem').mockImplementation(() => {
|
|
throw new Error('blocked');
|
|
});
|
|
const getItem = vi.spyOn(Storage.prototype, 'getItem').mockImplementation(() => {
|
|
throw new Error('blocked');
|
|
});
|
|
act(() => rememberListsSubTab(7, 'todo'));
|
|
expect(result.current[0]).toBe('todo');
|
|
expect(renderHook(() => useListsSubTab(9)).result.current[0]).toBe('packing');
|
|
setItem.mockRestore();
|
|
getItem.mockRestore();
|
|
});
|
|
});
|