Files
TREK/server/tests/unit/nest/booking-import/kitineraryMapper.test.ts
T
Maurice 724c88c201 style: format server and shared with prettier
A mechanical prettier --write over server/src, server/tests, server/scripts
and shared/src with the workspaces' .prettierrc; nothing but layout and
import order changes, and every file keeps the same set of imports. shared
is formatted throughout and its format baseline is empty. The server
baseline keeps the 35 files that Prettier would grow past their lint:size
limit (they need a split first, which is not a formatting change), and the
generated entity files stay as their generator writes them.
2026-10-10 21:23:37 +02:00

226 lines
8.5 KiB
TypeScript

import { mapReservations } from '../../../../src/nest/booking-import/kitinerary-mapper';
import { describe, it, expect } from 'vitest';
const airport = (iata: string, lat: number, lng: number) => ({
iataCode: iata,
name: iata,
geo: { latitude: lat, longitude: lng },
});
const flight = (pnr: string, dep: any, arr: any, depTime: string, arrTime: string, flightNumber: string) => ({
'@type': 'FlightReservation',
reservationNumber: pnr,
reservationFor: {
departureAirport: dep,
arrivalAirport: arr,
departureTime: depTime,
arrivalTime: arrTime,
airline: { name: 'Lufthansa', iataCode: 'LH' },
flightNumber,
},
});
const FRA = airport('FRA', 50.04, 8.57);
const BER = airport('BER', 52.36, 13.5);
const HND = airport('HND', 35.55, 139.78);
describe('kitinerary mapper — multi-leg flight grouping', () => {
it('groups two connecting same-PNR legs into one multi-leg booking', () => {
const { items } = mapReservations(
[
flight('ABC123', FRA, BER, '2026-06-11T10:00:00', '2026-06-11T12:00:00', 'LH 100'),
flight('ABC123', BER, HND, '2026-06-11T14:30:00', '2026-06-11T23:30:00', 'LH 200'),
] as any,
'test.json',
);
expect(items).toHaveLength(1);
const booking = items[0];
expect(booking.type).toBe('flight');
expect(booking.endpoints).toHaveLength(3);
expect(booking.endpoints!.map((e) => e.role)).toEqual(['from', 'stop', 'to']);
expect(booking.endpoints!.map((e) => e.sequence)).toEqual([0, 1, 2]);
const meta = booking.metadata as any;
expect(meta.legs).toHaveLength(2);
expect(meta.legs[0]).toMatchObject({ from: 'FRA', to: 'BER', flight_number: 'LH 100' });
expect(meta.legs[1]).toMatchObject({ from: 'BER', to: 'HND', flight_number: 'LH 200' });
expect(meta.departure_airport).toBe('FRA');
expect(meta.arrival_airport).toBe('HND');
expect(booking.reservation_time).toContain('10:00');
expect(booking.reservation_end_time).toContain('23:30');
});
it('keeps a round trip (same PNR, multi-day gap) as two separate bookings', () => {
const { items } = mapReservations(
[
flight('RT999', FRA, HND, '2026-06-11T10:00:00', '2026-06-11T20:00:00', 'LH 700'),
flight('RT999', HND, FRA, '2026-06-20T10:00:00', '2026-06-20T18:00:00', 'LH 701'),
] as any,
'test.json',
);
expect(items).toHaveLength(2);
expect((items[0].metadata as any).legs).toBeUndefined();
expect((items[1].metadata as any).legs).toBeUndefined();
});
it('leaves a single flight unchanged (two endpoints, no legs array)', () => {
const { items } = mapReservations(
[flight('S1', FRA, BER, '2026-06-11T10:00:00', '2026-06-11T12:00:00', 'LH 1')] as any,
'test.json',
);
expect(items).toHaveLength(1);
expect(items[0].endpoints).toHaveLength(2);
expect((items[0].metadata as any).legs).toBeUndefined();
});
});
describe('kitinerary mapper — printed 12-hour clocks (#2094)', () => {
it('reads a PM arrival as the afternoon instead of slicing the meridiem off', () => {
// Before the fix the endpoint carried '01:11', because splitIso sliced
// characters 11..16 out of '2026-06-11T01:11 PM'. The hour survived and the
// arrival landed twelve hours early.
const { items } = mapReservations(
[flight('PM1', FRA, BER, '2026-06-11T09:51 am', '2026-06-11T01:11 pm', 'LH 300')] as any,
'meridiem.json',
);
expect(items).toHaveLength(1);
const [dep, arr] = items[0].endpoints!;
expect(dep.local_time).toBe('09:51');
expect(arr.local_time).toBe('13:11');
expect(items[0].reservation_time).toBe('2026-06-11T09:51:00');
expect(items[0].reservation_end_time).toBe('2026-06-11T13:11:00');
});
it('leaves a 24-hour document byte for byte where it was', () => {
const { items } = mapReservations(
[flight('H24', FRA, BER, '2026-06-11T10:00:00', '2026-06-11T12:00:00', 'LH 400')] as any,
'plain.json',
);
expect(items[0].reservation_time).toBe('2026-06-11T10:00:00');
expect(items[0].endpoints![1].local_time).toBe('12:00');
});
it('keeps two legs apart that a NaN comparison used to merge', () => {
// sameConnection does `new Date(value).getTime()`, which is NaN for a
// printed meridiem, and both of its comparisons are false against NaN, so
// the guard fell through and merged unrelated legs into one booking.
const { items } = mapReservations(
[
flight('SAME', FRA, BER, '2026-06-11T09:00 am', '2026-06-11T10:00 am', 'LH 500'),
flight('SAME', HND, FRA, '2026-06-18T09:00 am', '2026-06-18T05:00 pm', 'LH 600'),
] as any,
'two-legs.json',
);
expect(items).toHaveLength(2);
});
});
/**
* A recognised @type whose mapper cannot build an item used to leave nothing
* behind: no item, no warning, no log. With a single node in the file the
* service's own "no reservations found" never fired either, so a hotel voucher
* the model had read correctly but namelessly came back as an empty preview,
* indistinguishable from a document holding no booking at all (#2375).
*/
describe('kitinerary mapper — a recognised type that cannot be mapped (#2375)', () => {
it('warns instead of dropping a lodging whose reservationFor carries no name', () => {
const { items, warnings } = mapReservations(
[{ '@type': 'LodgingReservation', reservationNumber: 'HMTRSX', reservationFor: {} }] as any,
'airbnb.pdf',
);
expect(items).toHaveLength(0);
expect(warnings).toEqual(['Incomplete LodgingReservation in airbnb.pdf[0] (no name in reservationFor) — skipped']);
});
it('warns for a flight that carries no reservationFor at all', () => {
const { items, warnings } = mapReservations(
[{ '@type': 'FlightReservation', reservationNumber: 'ABC123' }] as any,
'ticket.eml',
);
expect(items).toHaveLength(0);
expect(warnings).toEqual(['Incomplete FlightReservation in ticket.eml[0] (no reservationFor) — skipped']);
});
it('names the type it could not map, TouristAttractionVisit included', () => {
const { warnings } = mapReservations(
[{ '@type': 'TouristAttractionVisit', reservationFor: {} }] as any,
'museum.pdf',
);
expect(warnings[0]).toBe(
'Incomplete TouristAttractionVisit in museum.pdf[0] (no name in reservationFor) — skipped',
);
});
it('keeps the bookings it could map and warns only about the weak one', () => {
const { items, warnings } = mapReservations(
[
flight('MIX1', FRA, BER, '2026-06-11T10:00:00', '2026-06-11T12:00:00', 'LH 800'),
{ '@type': 'LodgingReservation', reservationFor: {} },
] as any,
'trip.eml',
);
expect(items).toHaveLength(1);
expect(warnings).toHaveLength(1);
expect(warnings[0]).toContain('trip.eml[1]');
});
it('still warns exactly once for an unknown type', () => {
const { items, warnings } = mapReservations(
[{ '@type': 'RocketLaunchReservation', reservationFor: { name: 'Starbase' } }] as any,
'mars.eml',
);
expect(items).toHaveLength(0);
expect(warnings).toEqual(['Unknown type "RocketLaunchReservation" in mars.eml[0] — skipped']);
});
});
/**
* The node a schema-bound provider writes once `reservationFor` has declared
* fields: the venue inside it, times and price at the root, as the prompt asks.
* Synthetic data in the shape of a Booking.com print (#2477).
*/
describe('kitinerary mapper: a prompt-shaped AI lodging (#2477)', () => {
it('maps a LodgingReservation with reservationFor.name to one hotel with its stay and price', () => {
const { items, warnings } = mapReservations(
[
{
'@type': 'LodgingReservation',
checkinTime: '2026-09-06T13:00:00',
checkoutTime: '2026-09-07T11:00:00',
price: 89.35,
priceCurrency: 'EUR',
reservationFor: {
name: 'Harbour View Inn',
address: 'Example Road 1, 1000 Sample Town',
telephone: '+00 000 000 000',
},
},
] as Parameters<typeof mapReservations>[0],
'Bestätigung_1.pdf',
);
expect(warnings).toEqual([]);
expect(items).toHaveLength(1);
expect(items[0]).toMatchObject({
type: 'hotel',
title: 'Harbour View Inn',
location: 'Example Road 1, 1000 Sample Town',
_venue: { name: 'Harbour View Inn', phone: '+00 000 000 000' },
_accommodation: { check_in: '2026-09-06T13:00', check_out: '2026-09-07T11:00' },
metadata: { check_in_time: '13:00', check_out_time: '11:00', price: 89.35, priceCurrency: 'EUR' },
source: { fileName: 'Bestätigung_1.pdf', index: 0 },
});
});
});