Files
TREK/client/tests/unit/slices/todoSlice.test.ts
T
Maurice 5dbcc4af40 fix(todo): tasks added, ticked, edited, reordered or deleted offline wait in the queue and sync once the connection is back
Every task write went straight to the API, so offline a new task failed with
"Network Error" and was lost, and a tick flipped back. Tasks now go through
todoRepo and the mutation queue like packing items: a temporary row at the
end of the list offline, the edits and the delete of it wait for its real id,
and an online write to a task that still has an older one queued joins the
queue behind it, since task writes carry no version token. A reorder offline
is queued without the tasks that have no server id yet. Desktop and phone
both write through the store, so both are covered.

Refs #2601
2026-10-12 18:24:18 +02:00

183 lines
6.8 KiB
TypeScript

import { describe, it, expect, beforeEach, vi } from 'vitest';
import { http, HttpResponse } from 'msw';
import { useTripStore } from '../../../src/store/tripStore';
import { resetAllStores, seedStore } from '../../helpers/store';
import { buildTodoItem } from '../../helpers/factories';
import { server } from '../../helpers/msw/server';
vi.mock('../../../src/api/websocket', () => ({
connect: vi.fn(),
disconnect: vi.fn(),
getSocketId: vi.fn(() => null),
joinTrip: vi.fn(),
leaveTrip: vi.fn(),
addListener: vi.fn(),
removeListener: vi.fn(),
setRefetchCallback: vi.fn(),
setPreReconnectHook: vi.fn(),
}));
beforeEach(() => {
resetAllStores();
});
describe('todoSlice', () => {
describe('addTodoItem', () => {
it('FE-TODO-001: addTodoItem calls API and appends item to todoItems', async () => {
const existing = buildTodoItem({ trip_id: 1 });
seedStore(useTripStore, { todoItems: [existing] });
const result = await useTripStore.getState().addTodoItem(1, { name: 'Buy sunscreen', priority: 1 });
expect(result.name).toBe('Buy sunscreen');
const items = useTripStore.getState().todoItems;
expect(items).toHaveLength(2);
});
it('FE-TODO-002: addTodoItem on failure throws', async () => {
server.use(
http.post('/api/trips/1/todo', () =>
HttpResponse.json({ message: 'Error' }, { status: 500 })
),
);
await expect(
useTripStore.getState().addTodoItem(1, { name: 'Fail' })
).rejects.toThrow();
});
});
describe('updateTodoItem', () => {
it('FE-TODO-003: updateTodoItem replaces item and preserves priority field', async () => {
const item = buildTodoItem({ id: 10, trip_id: 1, name: 'Old', priority: 2, sort_order: 5 });
seedStore(useTripStore, { todoItems: [item] });
server.use(
http.put('/api/trips/1/todo/10', async ({ request }) => {
const body = await request.json() as Record<string, unknown>;
return HttpResponse.json({ item: { ...item, ...body } });
}),
);
const result = await useTripStore.getState().updateTodoItem(1, 10, { name: 'Updated', priority: 2 });
expect(result.name).toBe('Updated');
expect(result.priority).toBe(2);
expect(useTripStore.getState().todoItems[0].name).toBe('Updated');
expect(useTripStore.getState().todoItems[0].priority).toBe(2);
});
});
describe('deleteTodoItem', () => {
it('FE-TODO-004: deleteTodoItem optimistically removes item, rollback on failure', async () => {
const item = buildTodoItem({ id: 10, trip_id: 1 });
seedStore(useTripStore, { todoItems: [item] });
server.use(
http.delete('/api/trips/1/todo/10', () =>
HttpResponse.json({ message: 'Error' }, { status: 500 })
),
);
await expect(useTripStore.getState().deleteTodoItem(1, 10)).rejects.toThrow();
expect(useTripStore.getState().todoItems).toHaveLength(1);
expect(useTripStore.getState().todoItems[0].id).toBe(10);
});
it('FE-TODO-004b: deleteTodoItem success removes item from array', async () => {
const item1 = buildTodoItem({ id: 10, trip_id: 1 });
const item2 = buildTodoItem({ id: 20, trip_id: 1 });
seedStore(useTripStore, { todoItems: [item1, item2] });
await useTripStore.getState().deleteTodoItem(1, 10);
const items = useTripStore.getState().todoItems;
expect(items).toHaveLength(1);
expect(items[0].id).toBe(20);
});
});
describe('toggleTodoItem', () => {
it('FE-TODO-005: toggleTodoItem sets checked optimistically to 1', async () => {
const item = buildTodoItem({ id: 10, trip_id: 1, checked: 0 });
seedStore(useTripStore, { todoItems: [item] });
server.use(
http.put('/api/trips/1/todo/10', async ({ request }) => {
const body = await request.json() as Record<string, unknown>;
return HttpResponse.json({ item: { ...item, ...body } });
}),
);
await useTripStore.getState().toggleTodoItem(1, 10, true);
expect(useTripStore.getState().todoItems[0].checked).toBe(1);
});
it('FE-TODO-006: toggleTodoItem rolls back checked on API failure (silent)', async () => {
const item = buildTodoItem({ id: 10, trip_id: 1, checked: 0 });
seedStore(useTripStore, { todoItems: [item] });
server.use(
http.put('/api/trips/1/todo/10', () =>
HttpResponse.json({ message: 'Error' }, { status: 500 })
),
);
// Does NOT throw
await useTripStore.getState().toggleTodoItem(1, 10, true);
expect(useTripStore.getState().todoItems[0].checked).toBe(0);
});
it('FE-TODO-007: toggleTodoItem preserves sort_order field', async () => {
const item = buildTodoItem({ id: 10, trip_id: 1, checked: 0, sort_order: 3 });
seedStore(useTripStore, { todoItems: [item] });
server.use(
http.put('/api/trips/1/todo/10', async ({ request }) => {
const body = await request.json() as Record<string, unknown>;
return HttpResponse.json({ item: { ...item, ...body } });
}),
);
await useTripStore.getState().toggleTodoItem(1, 10, true);
expect(useTripStore.getState().todoItems[0].sort_order).toBe(3);
});
});
});
describe('todoSlice offline (#2601)', () => {
const setOnline = (v: boolean) =>
Object.defineProperty(navigator, 'onLine', { value: v, writable: true, configurable: true });
it('FE-TODO-008: offline a task is added, ticked, edited, reordered and deleted without an error', async () => {
const { clearAll, offlineDb } = await import('../../../src/db/offlineDb');
await clearAll();
const synced = buildTodoItem({ id: 10, trip_id: 1, sort_order: 0 });
await offlineDb.todoItems.put(synced);
seedStore(useTripStore, { todoItems: [synced] });
setOnline(false);
try {
const added = await useTripStore.getState().addTodoItem(1, { name: 'Offline task' });
expect(added.id).toBeLessThan(0);
expect(useTripStore.getState().todoItems.map(i => i.name)).toEqual([synced.name, 'Offline task']);
await useTripStore.getState().toggleTodoItem(1, added.id, true);
await useTripStore.getState().updateTodoItem(1, added.id, { name: 'Offline task, renamed' });
expect(useTripStore.getState().todoItems[1]).toMatchObject({ name: 'Offline task, renamed', checked: 1 });
await useTripStore.getState().reorderTodoItems(1, [added.id, 10]);
expect(useTripStore.getState().todoItems.map(i => i.id)).toEqual([added.id, 10]);
await useTripStore.getState().deleteTodoItem(1, added.id);
expect(useTripStore.getState().todoItems.map(i => i.id)).toEqual([10]);
expect((await offlineDb.mutationQueue.orderBy('createdAt').toArray()).map(m => m.method)).toEqual(['POST', 'PUT', 'PUT', 'PUT', 'DELETE']);
} finally {
setOnline(true);
}
});
});