mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-10-19 13:36:48 +00:00
Maurice
55f14c6a70
Four separate defects sat behind "offline mode is broken". The app shell. On the first online launch after a version bump, App.tsx deleted EVERY Cache Storage bucket and unregistered EVERY service worker, then reloaded. That is exactly wrong for a Workbox autoUpdate build, which swaps its precache atomically on install and never leaves an empty one. Between the purge and the completion of a fresh 22 MB precache the origin had no shell at all; anyone who closed the app or lost signal inside that window could no longer start the PWA offline. It also threw away the map tiles and documents the user had downloaded on purpose. It now asks the worker to fetch the new build and reloads once it has taken over. The version marker also moves inside the guarded path, because it was written after the purge and outside its try: a throwing setItem left the caches gone, the marker unwritten and the reload unreached, repeating on every launch. The reported version is validated before it reaches this device's storage and before it is compared against the stored marker, so a value that is not a release tag can neither be persisted nor start an update on every launch. The session. loadUser's offline branch kept the persisted session but never called onAuthSuccess, the only caller of setAuthed(true), and the mutation queue's flush, syncAll and prepareForOffline are all gated on it. A session that launched without network could therefore never sync again for the rest of its life, even after the signal returned: the offline settings buttons spun and returned instantly having done nothing, and queued edits never uploaded. It also left reads pointed at the anonymous database instead of the user's own. The date rule. A trip is only cached when it has not ended, and one that ended over a week ago is actively evicted. The per-trip switch was an opt-out list, so ticking a finished trip changed nothing at all. For anyone whose trips are all in the past, "Download for offline use" stored none of them, reported success, and the cache stayed at zero. Switching a trip on now pins it, which overrides both the skip and the eviction, and the switch shows the honest position rather than promising storage that never happens. What the screen says. A sync that never started (already running, offline, signed out) was indistinguishable from one that stored everything: the progress bar painted full and a green "Ready for offline use" appeared over a run of nothing. Both syncs now report why they stopped and the screen says so. A rejected Dexie read no longer renders as "No trips cached yet", and the clear button stays reachable when the database holds data that no bookkeeping row points at. A run that rejects outright says so too: the trip list it starts from is a plain fetch, so a network blip took the whole thing down and left the last progress frame on screen looking like a finished download. The 401-with-HTML branch in the API client now confirms a reachable proxy before tearing the worker down, since several of TREK's own routes answer 401 with a text/html body. Both settings shells move onto one shared hook rather than growing the same logic twice, and the tile prefetch caps its depth when the browser refused persistent storage. Opaque tiles are billed at about 7 MB each, and an origin that is not exempt from eviction loses its whole bucket, precached shell included, which Workbox then never refills because sw.js has not changed. Closes #2228
54 lines
1.8 KiB
TypeScript
54 lines
1.8 KiB
TypeScript
/**
|
|
* Ask the browser for persistent storage so our offline data — prefetched map
|
|
* tiles, cached file blobs, the IndexedDB caches — is exempt from eviction under
|
|
* storage pressure. Without this the browser may purge tiles right when a
|
|
* traveler goes offline and needs them (audit H8 / M6).
|
|
*
|
|
* Best-effort and idempotent: returns whether persistence is (now) granted.
|
|
*/
|
|
|
|
/**
|
|
* Last known answer, so callers that have to size a download against it do not
|
|
* each re-ask. `null` until the request at app init has resolved.
|
|
*
|
|
* The answer matters: a browser that refuses persistence evicts this origin's
|
|
* WHOLE bucket under pressure (the Workbox precache with it), and since sw.js
|
|
* is byte-identical between releases, Workbox never re-installs and never
|
|
* refills what was evicted. The PWA then cannot start offline at all, and
|
|
* reinstalling does not help because it does not clear or restore site data
|
|
* (#2228).
|
|
*/
|
|
let _persisted: boolean | null = null
|
|
|
|
export async function requestPersistentStorage(): Promise<boolean> {
|
|
try {
|
|
if (typeof navigator === 'undefined' || !navigator.storage?.persist) {
|
|
_persisted = false
|
|
return false
|
|
}
|
|
// Already persisted? Avoid re-prompting where the API distinguishes.
|
|
if (navigator.storage.persisted && (await navigator.storage.persisted())) {
|
|
_persisted = true
|
|
return true
|
|
}
|
|
_persisted = await navigator.storage.persist()
|
|
return _persisted
|
|
} catch {
|
|
_persisted = false
|
|
return false
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Whether this origin's storage is exempt from eviction. Treats "not asked yet"
|
|
* as not granted, so a caller sizing a download errs on the small side.
|
|
*/
|
|
export function isStoragePersisted(): boolean {
|
|
return _persisted === true
|
|
}
|
|
|
|
/** Test helper: forget the cached answer. */
|
|
export function _resetPersistentStorage(): void {
|
|
_persisted = null
|
|
}
|