Files
TREK/client/src/components/Collections/CopyToTripModal.test.tsx
T
Maurice bee500880e fix(i18n): every language says one file and five files its own way
Finishes the plural work the previous wip commit started. t() picks a
count string's form by the language's own Intl.PluralRules, and every
locale now spells out the forms its language reaches with whole
numbers, about 160 count strings in all: one, few and many in Russian,
Ukrainian and Polish, one and few in Czech and Slovak, five forms in
Arabic, one in the others, none in Japanese, Korean, Chinese, Thai,
Vietnamese and Indonesian. Each language was translated and then
reviewed on its own. English no longer reads "1 files", "1 updates
available" or "photo(s)".

Count labels shown next to a number now take that number too: the
atlas and admin statistics, the trip cards, journey and shared trip
pills, packing templates, receipts, storage usage, the Studio export
note. A heading that shared its key with a counted label keeps a key of
its own (the boarding pass heading, the Bookings tab), so languages that
put a noun after a number in the singular keep a plural heading. The
plugin hosts chip passed its count through .replace() after t() and
never got a form; three toasts sent the count as text. Mail and push
texts for shared photos and suppressed storage failures pick their form
in code through pluralForm.

A whole number sent as text counts too, which is how in-app
notification params arrive, and the plural rule follows the language of
the strings on screen while another one still loads.

The parity check knows which forms each language needs and refuses
missing and impossible ones. It also reads keys that contain a colon
now: it skipped them, which hid 58 missing plugin permission texts in
Catalan and 35 in Vietnamese, both translated. The client parity test
covers every language of the registry instead of a hand-kept list of 19,
and the placeholder spec lets a form spell its number out only where
its category is that one number. Brazilian Portuguese error screens
were in Breton, and an Arabic dashboard label held Hebrew text.
2026-10-08 00:01:59 +00:00

221 lines
9.7 KiB
TypeScript
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
// FE-COMP-COPYTRIP-001 to FE-COMP-COPYTRIP-016
import React from 'react';
import { afterEach, beforeEach } from 'vitest';
import { render, screen, fireEvent, waitFor, within } from '../../../tests/helpers/render';
import userEvent from '@testing-library/user-event';
import { tripsApi } from '../../api/client';
import { useTranslation } from '../../i18n/TranslationContext';
import CopyToTripModal from './CopyToTripModal';
type ModalProps = Omit<React.ComponentProps<typeof CopyToTripModal>, 't'>;
type CopyResult = { copied: number; skipped: { id: number; name: string }[] };
function Harness(props: ModalProps): React.ReactElement {
const { t } = useTranslation();
return <CopyToTripModal {...props} t={t} />;
}
const TRIPS = [
{ id: 1, title: 'Rome 2026', start_date: '2026-04-02', end_date: '2026-04-09', cover_image: '/uploads/covers/rome.jpg' },
{ id: 2, title: 'Tokyo', start_date: null, end_date: null, cover_image: null },
];
let addToast: ReturnType<typeof vi.fn>;
function renderModal(overrides: Partial<ModalProps> = {}) {
const props: ModalProps = {
isOpen: true,
onClose: vi.fn(),
placeIds: [7],
onCopy: vi.fn(async () => ({ copied: 1, skipped: [] })),
...overrides,
};
render(<Harness {...props} />);
return props;
}
beforeEach(() => {
addToast = vi.fn();
window.__addToast = addToast as unknown as typeof window.__addToast;
vi.spyOn(tripsApi, 'list').mockResolvedValue({ trips: TRIPS });
});
afterEach(() => {
vi.restoreAllMocks();
delete window.__addToast;
});
describe('CopyToTripModal', () => {
it('FE-COMP-COPYTRIP-001: lists the user trips with their date range once loaded', async () => {
renderModal();
expect(await screen.findByText('Rome 2026')).toBeInTheDocument();
const rome = screen.getByRole('button', { name: /Rome 2026/ });
expect(within(rome).getByText(/Apr 2 – .*Apr 9/)).toBeInTheDocument();
// A trip without dates renders no date row at all.
const tokyo = screen.getByRole('button', { name: /Tokyo/ });
expect(tokyo.querySelector('.lucide-calendar-days')).toBeNull();
});
it('FE-COMP-COPYTRIP-015: a trips response landing after the modal closed is dropped', async () => {
const closed = <Harness isOpen onClose={vi.fn()} placeIds={[7]} onCopy={vi.fn(async () => ({ copied: 0, skipped: [] }))} />;
let resolve!: (v: { trips: typeof TRIPS }) => void;
const spy = vi.spyOn(tripsApi, 'list').mockReturnValue(new Promise(r => { resolve = r; }));
render(closed).unmount();
resolve({ trips: TRIPS });
await Promise.resolve();
expect(screen.queryByText('Rome 2026')).not.toBeInTheDocument();
// Same for a rejection — no "no trips" state is written into an unmounted tree.
let reject!: (e: Error) => void;
spy.mockReturnValue(new Promise((_, r) => { reject = r; }));
render(closed).unmount();
reject(new Error('offline'));
await Promise.resolve();
expect(screen.queryByText('No trips yet')).not.toBeInTheDocument();
});
it('FE-COMP-COPYTRIP-016: a trip without a title still renders and stays filterable', async () => {
vi.spyOn(tripsApi, 'list').mockResolvedValue({ trips: [{ id: 8, title: null }, ...TRIPS] });
renderModal();
await screen.findByText('Rome 2026');
fireEvent.change(screen.getByPlaceholderText('Search trips'), { target: { value: 'rome' } });
expect(screen.getByText('Rome 2026')).toBeInTheDocument();
expect(screen.getAllByRole('button', { name: /Rome 2026|Tokyo/ })).toHaveLength(1);
});
it('FE-COMP-COPYTRIP-014: a one-sided date range falls back to the single date it has', async () => {
vi.spyOn(tripsApi, 'list').mockResolvedValue({
trips: [
{ id: 3, title: 'Open ended', start_date: '2026-04-02', end_date: null },
{ id: 4, title: 'Return only', start_date: null, end_date: '2026-04-09' },
],
});
renderModal();
await screen.findByText('Open ended');
expect(within(screen.getByRole('button', { name: /Open ended/ })).getByText(/Apr 2/)).toBeInTheDocument();
expect(within(screen.getByRole('button', { name: /Return only/ })).getByText(/Apr 9/)).toBeInTheDocument();
});
it('FE-COMP-COPYTRIP-002: a cover image replaces the pin placeholder', async () => {
renderModal();
await screen.findByText('Rome 2026');
const rome = screen.getByRole('button', { name: /Rome 2026/ });
expect(rome.querySelector('img')).toHaveAttribute('src', '/uploads/covers/rome.jpg');
expect(screen.getByRole('button', { name: /Tokyo/ }).querySelector('.lucide-map-pin')).not.toBeNull();
});
it('FE-COMP-COPYTRIP-003: the title is singular for one place and counted for a bulk copy', async () => {
const { unmount } = render(<Harness {...{ isOpen: true, onClose: vi.fn(), placeIds: [7], onCopy: vi.fn(async () => ({ copied: 1, skipped: [] })) }} />);
expect(await screen.findByRole('heading', { name: 'Copy to trip' })).toBeInTheDocument();
unmount();
renderModal({ placeIds: [7, 8, 9] });
expect(await screen.findByRole('heading', { name: 'Copy 3 to trip' })).toBeInTheDocument();
});
it('FE-COMP-COPYTRIP-004: shows the spinner until the trips arrive', async () => {
let resolve!: (v: { trips: typeof TRIPS }) => void;
vi.spyOn(tripsApi, 'list').mockReturnValue(new Promise(r => { resolve = r; }));
renderModal();
expect(document.querySelector('.animate-spin')).not.toBeNull();
resolve({ trips: TRIPS });
expect(await screen.findByText('Rome 2026')).toBeInTheDocument();
});
it('FE-COMP-COPYTRIP-005: an empty or failing trips response shows the no-trips copy', async () => {
vi.spyOn(tripsApi, 'list').mockResolvedValue({});
const { unmount } = render(<Harness {...{ isOpen: true, onClose: vi.fn(), placeIds: [7], onCopy: vi.fn(async () => ({ copied: 0, skipped: [] })) }} />);
expect(await screen.findByText('No trips yet')).toBeInTheDocument();
unmount();
vi.spyOn(tripsApi, 'list').mockRejectedValue(new Error('offline'));
renderModal();
expect(await screen.findByText('No trips yet')).toBeInTheDocument();
});
it('FE-COMP-COPYTRIP-006: requests nothing and renders nothing while closed', () => {
const spy = vi.spyOn(tripsApi, 'list').mockResolvedValue({ trips: TRIPS });
renderModal({ isOpen: false });
expect(spy).not.toHaveBeenCalled();
expect(screen.queryByRole('heading', { name: /Copy/ })).not.toBeInTheDocument();
});
it('FE-COMP-COPYTRIP-007: the search box filters trips by title, case-insensitively', async () => {
renderModal();
const search = await screen.findByPlaceholderText('Search trips');
fireEvent.change(search, { target: { value: 'rome' } });
expect(screen.getByText('Rome 2026')).toBeInTheDocument();
expect(screen.queryByText('Tokyo')).not.toBeInTheDocument();
fireEvent.change(search, { target: { value: 'nope' } });
expect(screen.getByText('No trips yet')).toBeInTheDocument();
});
it('FE-COMP-COPYTRIP-008: picking a trip copies, reports the count and closes', async () => {
const onCopy = vi.fn(async (): Promise<CopyResult> => ({ copied: 2, skipped: [] }));
const props = renderModal({ onCopy });
fireEvent.click(await screen.findByText('Rome 2026'));
await waitFor(() => expect(props.onClose).toHaveBeenCalled());
expect(onCopy).toHaveBeenCalledWith(1);
expect(addToast).toHaveBeenCalledWith('Copied 2 places', 'success', undefined);
});
it('FE-COMP-COPYTRIP-009: server-side duplicates are reported alongside the copied count', async () => {
const onCopy = vi.fn(async (): Promise<CopyResult> => ({ copied: 1, skipped: [{ id: 9, name: 'Colosseum' }] }));
renderModal({ onCopy });
fireEvent.click(await screen.findByText('Rome 2026'));
await waitFor(() => expect(addToast).toHaveBeenCalledWith('Skipped 1 duplicate', 'info', undefined));
expect(addToast).toHaveBeenCalledWith('Copied 1 place', 'success', undefined);
});
it('FE-COMP-COPYTRIP-010: a no-op copy says so instead of staying silent', async () => {
const onCopy = vi.fn(async (): Promise<CopyResult> => ({ copied: 0, skipped: [] }));
renderModal({ onCopy });
fireEvent.click(await screen.findByText('Rome 2026'));
await waitFor(() => expect(addToast).toHaveBeenCalledWith('Nothing to copy', 'info', undefined));
expect(addToast).toHaveBeenCalledTimes(1);
});
it('FE-COMP-COPYTRIP-011: a failed copy surfaces the server message and keeps the modal open', async () => {
const onCopy = vi.fn((): Promise<CopyResult> => Promise.reject({ response: { data: { error: 'Trip is locked' } } }));
const props = renderModal({ onCopy });
fireEvent.click(await screen.findByText('Rome 2026'));
await waitFor(() => expect(addToast).toHaveBeenCalledWith('Trip is locked', 'error', undefined));
expect(props.onClose).not.toHaveBeenCalled();
});
it('FE-COMP-COPYTRIP-012: a second click while a copy is running is ignored', async () => {
let resolve!: (v: CopyResult) => void;
const onCopy = vi.fn(() => new Promise<CopyResult>(r => { resolve = r; }));
const props = renderModal({ onCopy });
fireEvent.click(await screen.findByText('Rome 2026'));
fireEvent.click(screen.getByText('Tokyo'));
expect(onCopy).toHaveBeenCalledTimes(1);
expect(screen.getByRole('button', { name: /Rome 2026/ })).toBeDisabled();
resolve({ copied: 1, skipped: [] });
await waitFor(() => expect(props.onClose).toHaveBeenCalled());
});
it('FE-COMP-COPYTRIP-013: an empty selection never reaches the copy handler and Escape closes', async () => {
const user = userEvent.setup();
const props = renderModal({ placeIds: [] });
fireEvent.click(await screen.findByText('Rome 2026'));
expect(props.onCopy).not.toHaveBeenCalled();
await user.keyboard('{Escape}');
expect(props.onClose).toHaveBeenCalledTimes(1);
});
});