Files
TREK/client/tests/unit/studio/mapScope.test.ts
T
Maurice eae8480728 feat(studio): follow-ups from using Studio on a real journey (#1984)
* feat(studio): widen the document, and stop a save from losing it

The schema gains what the elements coming after it need: an icon element, a
badge that can be restyled rather than only placed, a date and a pair of
coordinates on a text binding, and the map's route, pin and road settings.

Widening it turned up two ways a book could fail to come back.

The mood badge writes its code into the document, and the schema said that
code was exactly two characters, from a first draft where it was a country.
The real codes are words, so every save was rejected and the read that
followed parsed to an empty document: seventeen spreads in, nothing out.
Widened to what the badge actually writes, and normalizeBookDocument now
drops the elements it cannot read rather than the whole book, so one bad
element costs a picture frame instead of a year of work.

The other was the body limit. The parser allowed 100kb for everything, and a
book with a routed map measures past that, so the save came back 413 and the
editor sat on "not saved" with no way forward. Book writes get their own
parser at 8mb; everything else keeps the limit it had.

* feat(studio): a date, a pair of coordinates and an icon library

Three things that had to be drawn by hand before.

A journal entry knows when it happened and where, and neither could be put
on a page: you read the date off the entry and typed it into a text box,
where it then stayed while the entry moved. Both are chips now, next to the
title and the story, and both follow their entry the way the others do.
The formatting lives in one place so the chip, the template and the resolver
cannot drift by a character — coordinates in degrees or decimals, the date
in the reader's language.

The icons are the whole Lucide set, searchable, placed as a real element
with its own colour and stroke rather than as a character in a font. The
stroke is deliberately not called strokeWidth: three separate places rescale
a field of that name by page width, and an icon whose line thins as the book
grows is not what anyone asked for.

And the badges finally have their settings. A mood or weather badge could be
placed and then only moved: the icon's colour was fixed, the icon could not
be turned off, and there was no way to keep the icon and drop the words. All
three are switches now, with the colour following the badge unless you say
otherwise.

* fix(studio): let a placed entry field follow its journal entry again

The inspector says a bound field follows the journal entry and that editing
it here breaks the link. The first half was not true: nothing ever re-read
the entry, so renaming a title in Journey left the old words on the page for
good, and the same went for every other bound field.

The resolver runs where the journey is loaded and re-reads the fields that
still point at an entry. What it will not do is as important as what it
does. A field somebody has typed over stays typed over, an entry that is
gone leaves its element alone rather than blanking it, and an entry that
answers with nothing never wipes what is already on the page.

Formatted fields — the date, the coordinates — are only re-read when the
format itself changed, which is what keeps this from quietly rewriting
books that already exist: an entry whose date was placed as a heading and
then set in capitals keeps its capitals. Checked against the real
database before it shipped, where the first version overwrote three of them.

* feat(studio): start a new book empty, with six layouts to choose from

A new journey opened onto a book that had already been laid out, which is
the wrong first move: it decides the shape of somebody's book before they
have seen it, and undoing it means deleting pages one at a time. A new book
starts empty now, and the auto layout runs when it is asked to.

The layouts themselves went from two to six, so choosing one is a real
choice: what was there covered a photo-heavy spread and a text-heavy one and
nothing in between.

* fix(studio): hyphenate the export the way the editor does, and set the bleed

Two things the press sees and the editor did not.

A paragraph broke in different places in the PDF than on screen. The print
document is written from scratch and never carried a language, so the
browser hyphenated the editor's German and the export's nothing-in-
particular. It takes the page's own language now. The wait for the sheet to
be ready also covers the images inside SVG, with a ceiling, so a map that is
slow to draw does not print half-finished.

And the bleed and the safe margin are typeable. Both were baked into every
page preset at what a photo-book vendor usually asks for, 3mm and 5mm, with
no control anywhere. That is fine until a printer asks for 5 and 10, at
which point the book cannot be made here at all: the export carries the wrong
bleed and the crop marks sit in the wrong place, which nobody finds until
the guillotine has run.

* feat(studio): rebuild the inspector

The panel on the right had grown by accretion: every element type had added
its own controls in whatever shape suited it that day, so the same idea —
a colour, a size, a toggle — looked different depending on what you had
selected, and long panels were a wall of unlabelled fields.

It is one set of controls now, used by every element: foldable sections, a
line that holds a label and its control, radio choices, checkboxes, the
app's own toggle, and a number field that holds a draft so typing "500" is
not read as "5", clamped and written back under the cursor. Duplicated
controls were merged rather than deleted; nothing an element could do before
it cannot do now.

The head carries the element's identity and its actions, so what you have
selected is readable without counting fields, and the sections have room to
breathe: what was there was correct and unreadable.

* feat(studio): a route map worth printing

The map in a book was a straight grey line between grey dots on a tile that
was chosen for a screen. At print size those tiles are read at roughly four
times the resolution they were fetched for, which is why it looked soft next
to everything around it.

The imagery comes from sources that hold up on paper: NASA's shaded relief
and EOX's cloudless Sentinel-2, both licensed for it, picked at a zoom that
matches the printer rather than the screen. Tiles are fetched at twice the
density where the source offers it, and the seam between them scales with
the tile instead of sitting at a fixed fraction of a millimetre, which under
editor zoom fell below one device pixel and showed as white threads.

The route is drawn rather than plotted. A leg that was never recorded bows,
by an amount that grows with its length and turns away from the pole, and it
dashes, because an inferred line should not claim to be a track — a recorded
track never bows. Both strokes are laid down in two passes, casing then core,
so the line stays legible over dark sea and bright desert alike. Legs can
follow roads instead, routed leg by leg with the geometry thinned before it
is stored, which is the setting a road trip wants and the one a flight
cannot have.

Stops carry their own first photograph, cut to a circle by a stencil that
exists — the first one was written into a defs block that only appears on a
map clipped to a coastline, so on an ordinary map it clipped nothing and the
photographs sat square on the page. A stop with no photograph of its own is
numbered rather than handed one from elsewhere in the journey: a marker at
one place showing a picture taken at another is a caption that lies.

Whatever the frame, the whole route is inside it. The window takes the
frame's aspect, so the fit and the imagery agree instead of one containing
what the other covers, and a map dragged narrow no longer cuts off its end.
Each linked trip can carry its own map, and a map notices a photograph added
to a stop afterwards rather than having to be placed again.

* i18n(journey): the new Studio strings, in all 23 locales

* test(journey): pin the coverage the map work brought with it

The journey domain measures higher than its floor after this round, so the
floor follows it up. Only journey moved; the generator's suggestion would
have taken memories' functions down a point, and a ratchet that can fall is
not a ratchet.

* test(studio): cover the thinning that keeps a road route saveable

The one path in roadRoute nothing exercised, and the one that matters most:
a router answers a long drive with thousands of points at a precision no
press can resolve, and all of it goes into the document. Keeping a leg whole
is what pushed a real book past the body limit.

Both ends have to survive so the line still meets its stops, and the spacing
has to stay even, because cutting a run out of the middle would straighten
exactly the bends somebody wanted to see.
2026-08-20 15:43:27 +02:00

153 lines
5.7 KiB
TypeScript

import { describe, it, expect } from 'vitest'
import type { BookElement, JourneyStats } from '@trek/shared'
import { isStale, refreshPatch, routeFor } from '../../../src/components/Studio/travelRefresh'
/**
* A map of one trip, out of a journey made of several (#1973).
*
* A journey is a collection of trips, and printing two of them as one route
* draws a line from the last stop of the first to the first stop of the second.
* On a journey that went to Iceland in June and Portugal in September that leg
* is the longest line on the page and nobody travelled it.
*
* The scope is stored on the element rather than worked out at draw time,
* because the stops are frozen into it when it is placed. These cases pin the
* part that would otherwise rot quietly: bringing a map up to date has to keep
* the scope, or a map of Iceland turns back into a map of everywhere the first
* time somebody clicks refresh.
*/
const ICELAND = 11
const PORTUGAL = 22
const stats: JourneyStats = {
journeyId: 5,
distance: 4_000_000,
days: 21,
steps: 6,
photos: 40,
places: 12,
furthest: 3_000_000,
countries: [
{ code: 'IS', name: 'Iceland', places: 2, firstVisit: '2026-06-02' },
{ code: 'PT', name: 'Portugal', places: 2, firstVisit: '2026-09-04' },
],
points: [
{ lat: 64.14, lng: -21.94, label: 'Reykjavík', date: '2026-06-02', country: 'IS', tripId: ICELAND, photoId: null },
{ lat: 65.68, lng: -18.12, label: 'Akureyri', date: '2026-06-06', country: 'IS', tripId: ICELAND, photoId: null },
{ lat: 38.72, lng: -9.14, label: 'Lisboa', date: '2026-09-04', country: 'PT', tripId: PORTUGAL, photoId: null },
{ lat: 41.15, lng: -8.61, label: 'Porto', date: '2026-09-08', country: 'PT', tripId: PORTUGAL, photoId: null },
],
trips: [
{ id: ICELAND, title: 'Iceland', start: '2026-06-02', end: '2026-06-14', points: 2 },
{ id: PORTUGAL, title: 'Portugal', start: '2026-09-04', end: '2026-09-12', points: 2 },
],
start: '2026-06-02',
end: '2026-09-12',
}
const map = (over: Record<string, unknown> = {}): BookElement => ({
id: 'mp1', kind: 'map', frame: { x: 10, y: 10, w: 180, h: 140 },
rotation: 0, opacity: 1, locked: false,
font: 'sans', color: '#1a1a1a', accent: '#c2410c', textScale: 1, weight: 400, stale: false,
style: 'minimal', source: 'vector', tileUrl: '', attribution: '', zoom: null, clip: 'rect',
showLand: true, showRoute: true, showPins: true, showLabels: false,
countries: ['IS', 'PT'],
points: stats.points.map(p => ({ lat: p.lat, lng: p.lng, label: p.label })),
path: [],
fitPadding: 0.18,
fitToCountries: true,
tripId: null,
...over,
} as unknown as BookElement)
describe('which stops a map is of', () => {
it('is the whole journey when no trip is named', () => {
expect(routeFor(stats, null)).toHaveLength(4)
})
it('is one trip when one is', () => {
const route = routeFor(stats, ICELAND)
expect(route.map(p => p.label)).toEqual(['Reykjavík', 'Akureyri'])
})
it('is empty for a trip with nothing on the route, rather than everything', () => {
expect(routeFor(stats, 999)).toEqual([])
})
})
describe('bringing a map up to date', () => {
it('keeps a journey map showing the journey', () => {
const patch = refreshPatch(map(), stats) as { points: unknown[]; countries: string[] }
expect(patch.points).toHaveLength(4)
expect(patch.countries).toEqual(['IS', 'PT'])
})
/*
* The case this test exists for: refresh used to read `stats.points` flat,
* so one click turned a map of Iceland back into a map of both trips.
*/
it('keeps a trip map showing that trip', () => {
const el = map({
tripId: ICELAND,
countries: ['IS'],
points: [{ lat: 64.14, lng: -21.94, label: 'Reykjavík' }],
})
const patch = refreshPatch(el, stats) as { points: { label: string }[]; countries: string[] }
expect(patch.points.map(p => p.label)).toEqual(['Reykjavík', 'Akureyri'])
expect(patch.countries).toEqual(['IS'])
})
it('notices a trip map is behind, against its own trip rather than the journey', () => {
const behind = map({
tripId: ICELAND,
points: [{ lat: 64.14, lng: -21.94, label: 'Reykjavík' }],
})
expect(isStale(behind, stats)).toBe(true)
const current = map({
tripId: ICELAND,
points: [
{ lat: 64.14, lng: -21.94, label: 'Reykjavík' },
{ lat: 65.68, lng: -18.12, label: 'Akureyri' },
],
})
expect(isStale(current, stats)).toBe(false)
})
it('does not call a journey map stale merely because a trip map would be', () => {
expect(isStale(map(), stats)).toBe(false)
})
/*
* A marker draws the entry's own first photograph, so adding one to an entry
* changes the map without moving a single stop. The shape test — same number
* of stops, same two ends — cannot see that, and until it did the only way to
* get the picture onto the page was to delete the map and place it again.
*/
it('notices a photograph added to a stop, though nothing moved', () => {
const el = map({
points: stats.points.map(p => ({ lat: p.lat, lng: p.lng, label: p.label, photoId: null })),
})
expect(isStale(el, stats)).toBe(false)
const withPhoto: JourneyStats = {
...stats,
points: stats.points.map((p, i) => (i === 1 ? { ...p, photoId: 42 } : p)),
}
expect(isStale(el, withPhoto)).toBe(true)
const patch = refreshPatch(el, withPhoto) as { points: { photoId: number | null }[] }
expect(patch.points[1].photoId).toBe(42)
})
it('notices one taken away again', () => {
const el = map({
points: stats.points.map((p, i) => ({
lat: p.lat, lng: p.lng, label: p.label, photoId: i === 0 ? 7 : null,
})),
})
expect(isStale(el, stats)).toBe(true)
})
})