Files
TREK/client/src/components/Settings/NotificationsTab.tsx
T
Maurice 12962480d5 fix(settings): notification settings show an error when they cannot load
When the notification preferences failed to load, the matrix on both the
desktop tab and the phone screen stayed on its loading line for good and
nothing told the user anything went wrong. A failed load of the webhook and
ntfy settings was just as silent and left empty fields that looked like
nothing was saved.

Both loads in useNotificationSettings ended in .catch(() => {}) and had no
cancelled flag. Each failure now shows the common error toast, a failed
preferences load sets loadFailed so both views replace the loading line
with the error text, and both loads ignore a response that arrives after
the screen is gone.

Regression test FE-COMP-NOTIFSETTINGS-010 (useNotificationSettings.test.ts)
was red on the old code: "expected "vi.fn()" to be called 2 times, but got
0 times". FE-COMP-NOTIFSETTINGS-011 covers the cancelled flag and
FE-COMP-NOTIFICATIONS-032 the desktop view.

Changed assertions:
- MSettingsNotifications.test.tsx FE-MOB-SETNOTIF-002: a failed load used
  to expect the "Loading..." line to stay; it now expects "Error" and no
  loading line.
2026-10-09 19:00:46 +02:00

237 lines
11 KiB
TypeScript

import React from 'react'
import { Link } from 'react-router'
import { Bell, Lock, Plug, Send, Webhook } from 'lucide-react'
import { WEB_PUSH_CHANNEL_ID } from '@trek/shared'
import { useTranslation } from '../../i18n'
import ToggleSwitch from './ToggleSwitch'
import Section from './Section'
import WebPushCard from './WebPushCard'
import { EVENT_LABEL_KEYS, channelLabel, isLockedCell } from './notificationLabels'
import { useNotificationSettings } from './useNotificationSettings'
import { Tooltip } from '../shared/Tooltip'
import { fs } from '../shared/DialogShell'
import { EditorField, GRID_2, INPUT } from '../shared/dialogParts'
import { SettingsCard, SettingsHint, StatusPill, SETTINGS_BUTTON, SETTINGS_BUTTON_DANGER, SETTINGS_BUTTON_PRIMARY } from './settingsKit'
export default function NotificationsTab(): React.ReactElement {
const { t } = useTranslation()
const {
matrix, loadFailed, saving, visibleChannels, hasChannel, pluginChannels, toggle, testChannel, channelTesting,
webhookUrl, setWebhookUrl, webhookIsSet, webhookSaving, webhookTesting, saveWebhookUrl, testWebhookUrl,
ntfyTopic, setNtfyTopic, ntfyServer, setNtfyServer, ntfyToken, setNtfyToken, ntfyTokenIsSet,
ntfySaving, ntfyTesting, saveNtfySettings, clearNtfyToken, testNtfySettings,
} = useNotificationSettings()
const renderMatrix = () => {
if (!matrix) return loadFailed ? <SettingsHint>{t('common.error')}</SettingsHint> : <MatrixSkeleton label={t('common.loading')} />
if (visibleChannels.length === 0) {
return <SettingsHint>{t('settings.notificationPreferences.noChannels')}</SettingsHint>
}
// The event column takes what is left; every channel gets the same narrow
// column, so the switches line up under their headers.
const columns = `minmax(0, 1fr) ${visibleChannels.map(() => '72px').join(' ')}`
return (
<div className="overflow-x-auto rounded-[12px] border border-edge-faint bg-surface-card">
<div className="min-w-fit divide-y divide-edge-faint">
{/* Header row */}
<div className="grid items-center gap-1 bg-surface-secondary px-3.5 py-2.5" style={{ gridTemplateColumns: columns }}>
<span />
{visibleChannels.map(ch => (
<Tooltip key={ch.id} label={t('settings.notificationPreferences.notConfigured')} disabled={ch.configured}>
<span
className={`line-clamp-2 break-words text-center font-geist font-bold uppercase leading-tight tracking-[.08em] ${ch.configured ? 'text-content-faint' : 'text-warning'}`}
style={fs(10)}
>
{channelLabel(ch, t)}
</span>
</Tooltip>
))}
</div>
{/* Event rows */}
{matrix.event_types.map(eventType => {
const implementedForEvent = matrix.implemented_combos[eventType] ?? []
const relevantChannels = visibleChannels.filter(ch => implementedForEvent.includes(ch.id))
if (relevantChannels.length === 0) return null
return (
<div key={eventType} className="grid items-center gap-1 px-3.5 py-3" style={{ gridTemplateColumns: columns }}>
<span className="min-w-0 pe-2 font-medium text-content" style={fs(13, 'body')}>
{t(EVENT_LABEL_KEYS[eventType]) || eventType}
</span>
{visibleChannels.map(ch => {
if (!implementedForEvent.includes(ch.id)) {
return <span key={ch.id} className="text-center text-content-faint" style={fs(13, 'body')}>—</span>
}
const isOn = matrix.preferences[eventType]?.[ch.id] ?? true
// Switched off for everyone by the admin (#1536): the same footprint as
// the switch, so the grid keeps its columns, and a lock that says why.
if (isLockedCell(matrix.locked, eventType, ch.id)) {
return (
<div key={ch.id} className="flex justify-center">
<Tooltip label={t('settings.notificationPreferences.lockedByAdmin')}>
<span role="img" aria-label={t('settings.notificationPreferences.lockedByAdmin')} data-locked
className="inline-flex h-6 w-11 items-center justify-center rounded-full bg-surface-tertiary text-content-faint">
<Lock size={12} />
</span>
</Tooltip>
</div>
)
}
return (
<div key={ch.id} className="flex justify-center">
<ToggleSwitch on={isOn} onToggle={() => toggle(eventType, ch.id)} />
</div>
)
})}
</div>
)
})}
</div>
</div>
)
}
const webhookTestDisabled = (!webhookUrl && !webhookIsSet) || webhookTesting
// The channel cards only make sense once there is a matrix to send through.
const ready = !!matrix && visibleChannels.length > 0
return (
<div>
<Section
title={t('settings.notifications')}
icon={Bell}
badge={saving ? <StatusPill>{t('common.saving')}</StatusPill> : undefined}
>
{renderMatrix()}
</Section>
{ready && hasChannel('webhook') && (
<SettingsCard icon={Webhook} title={t('settings.webhookUrl.label')} hint={t('settings.webhookUrl.hint')}>
<div className="flex flex-wrap items-center gap-2">
<input
id="notifications-webhook-url"
type="text"
value={webhookUrl}
onChange={e => setWebhookUrl(e.target.value)}
placeholder={webhookIsSet ? '••••••••' : t('settings.webhookUrl.placeholder')}
aria-label={t('settings.webhookUrl.label')}
className={`${INPUT} min-w-[220px] flex-1`}
/>
<button type="button" onClick={testWebhookUrl} disabled={webhookTestDisabled} className={SETTINGS_BUTTON} style={fs(13, 'body')}>
{t('settings.webhookUrl.test')}
</button>
<button type="button" onClick={saveWebhookUrl} disabled={webhookSaving} className={SETTINGS_BUTTON_PRIMARY} style={fs(13, 'body')}>
{t('common.save')}
</button>
</div>
</SettingsCard>
)}
{ready && hasChannel('ntfy') && (
<SettingsCard icon={Send} title={t('settings.notificationPreferences.ntfy')} hint={t('settings.ntfyUrl.hint')}>
<div className={GRID_2}>
<EditorField label={t('settings.ntfyUrl.topicLabel')} htmlFor="notifications-ntfy-topic">
<input
id="notifications-ntfy-topic"
type="text"
value={ntfyTopic}
onChange={e => setNtfyTopic(e.target.value)}
placeholder={t('settings.ntfyUrl.topicPlaceholder')}
className={INPUT}
/>
</EditorField>
<EditorField label={t('settings.ntfyUrl.serverLabel')} htmlFor="notifications-ntfy-server">
<input
id="notifications-ntfy-server"
type="text"
value={ntfyServer}
onChange={e => setNtfyServer(e.target.value)}
placeholder={matrix?.defaults?.ntfyServer || t('settings.ntfyUrl.serverPlaceholder')}
className={INPUT}
/>
</EditorField>
</div>
<EditorField label={t('settings.ntfyUrl.tokenLabel')} htmlFor="notifications-ntfy-token" hint={t('settings.ntfyUrl.tokenHint')}>
<div className="flex items-center gap-2">
<input
id="notifications-ntfy-token"
type="password"
value={ntfyToken}
onChange={e => setNtfyToken(e.target.value)}
placeholder={ntfyTokenIsSet ? '••••••••' : ''}
className={`${INPUT} flex-1`}
/>
{ntfyTokenIsSet && (
<button type="button" onClick={clearNtfyToken} className={SETTINGS_BUTTON_DANGER} style={fs(13, 'body')}>
{t('common.clear')}
</button>
)}
</div>
</EditorField>
<div className="flex flex-wrap items-center justify-end gap-2">
<button type="button" onClick={testNtfySettings} disabled={!ntfyTopic || ntfyTesting} className={SETTINGS_BUTTON} style={fs(13, 'body')}>
{t('settings.ntfyUrl.test')}
</button>
<button type="button" onClick={saveNtfySettings} disabled={ntfySaving} className={SETTINGS_BUTTON_PRIMARY} style={fs(13, 'body')}>
{t('common.save')}
</button>
</div>
</SettingsCard>
)}
{/* Per device rather than per account: the matrix above picks the events,
this card decides whether this browser is one of the places they go. */}
{ready && hasChannel(WEB_PUSH_CHANNEL_ID) && <WebPushCard />}
{ready && pluginChannels.map(ch => (
<SettingsCard
key={ch.id}
icon={Plug}
title={channelLabel(ch, t)}
hint={ch.configured
? t('settings.notificationPreferences.pluginConfigured')
: t('settings.notificationPreferences.notConfigured')}
action={
<>
{/* Unconfigured is the common case on first use — send them to where the
credentials actually live rather than just naming the place. */}
{!ch.configured && ch.settingsPath && (
<Link to={ch.settingsPath} className={`${SETTINGS_BUTTON_PRIMARY} no-underline`} style={fs(13, 'body')}>
{t('settings.notificationPreferences.configure')}
</Link>
)}
<button type="button"
onClick={() => testChannel(ch)}
disabled={!ch.configured || channelTesting === ch.id}
className={SETTINGS_BUTTON}
style={fs(13, 'body')}
>
{t('settings.notificationPreferences.sendTest')}
</button>
</>
}
/>
))}
</div>
)
}
/** A calm placeholder for the matrix while the preferences load. */
function MatrixSkeleton({ label }: { label: string }) {
return (
<div className="flex flex-col gap-2" aria-busy="true">
<SettingsHint>{label}</SettingsHint>
<div className="divide-y divide-edge-faint overflow-hidden rounded-[12px] border border-edge-faint bg-surface-card">
{[0, 1, 2].map(i => (
<div key={i} className="flex items-center gap-4 px-3.5 py-3">
<span className="h-3 flex-1 animate-pulse rounded-full bg-surface-tertiary" />
<span className="h-6 w-11 animate-pulse rounded-full bg-surface-tertiary" />
</div>
))}
</div>
</div>
)
}