Files
TREK/client/tests/unit/mobile/trip/MPlanTimeline.test.tsx
T
Maurice 2a2dfec247 fix(mobile): large screen polish for the dashboard, the trip dock, transports, the stay chip and the journey strip
- Dashboard: crossing the split size keeps every widget in the same parent
  (the columns dissolve into one ordered stack below it), so the currency
  converter is not remounted and keeps its amount and rates.
- Trip dock: More is marked with the main dock's ring while one of its
  sections (chat, notes, links, polls, files) is on show or it is open,
  instead of the filled circle of a tab.
- Transport cards: the status button is a flex box, so its dot shows when
  the card may be edited.
- Day header: the stay chip's name keeps its own direction, so a Latin name
  in an Arabic header is cut at its end.
- Journey: a folded Duo on its side (about 540px high) gets the compact
  cards, so the map keeps its room.
- Rail: a test pins settings and administration marking their own entry.
2026-11-07 23:31:54 +00:00

855 lines
38 KiB
TypeScript

import { beforeEach, describe, expect, it, vi } from 'vitest'
import { fireEvent, render, screen, waitFor, within } from '../../../helpers/render'
import { buildPlanner, buildShell } from '../../../helpers/mobileTrip'
import type { PluginDaySchedule } from '../../../../src/components/Plugins/PluginDaySchedule'
import type { MPlanTimelineController } from '../../../../src/mobile/screens/trip/plan/useMPlanTimeline'
import type { MTripShellApi, TripPlanner } from '../../../../src/mobile/screens/trip/MTripShell'
import type { PlanRow, TransitMeta, TransportEntry } from '../../../../src/mobile/screens/trip/plan/planTimelineModel'
import type { MergedItem } from '../../../../src/utils/dayMerge'
import type { Assignment, Day, DayNote, Place, RouteSegment } from '../../../../src/types'
import MPlanTimeline from '../../../../src/mobile/screens/trip/plan/MPlanTimeline'
import { resetAllStores, seedStore } from '../../../helpers/store'
import { useSettingsStore } from '../../../../src/store/settingsStore'
// FE-MOB-PLTL-001 to FE-MOB-PLTL-049
const mocks = vi.hoisted(() => ({
tl: {} as Record<string, unknown>,
schedule: {} as PluginDaySchedule,
}))
vi.mock('../../../../src/mobile/screens/trip/plan/useMPlanTimeline', () => ({
useMPlanTimeline: () => mocks.tl,
}))
vi.mock('../../../../src/components/Plugins/PluginDaySchedule', async importOriginal => {
const actual = await importOriginal<typeof import('../../../../src/components/Plugins/PluginDaySchedule')>()
return { ...actual, usePluginDaySchedule: () => mocks.schedule }
})
const DAY = { id: 2, trip_id: 1, day_number: 2, date: '2026-05-02', title: 'Tokyo → Kyoto' } as unknown as Day
const MUSEUM = {
id: 11, day_id: 2, place_id: 101, order_index: 0,
place: { id: 101, name: 'Museum', place_time: '09:30', address: 'Museum Rd 1', lat: 35.71, lng: 139.79 },
} as unknown as Assignment
const PARK = {
id: 12, day_id: 2, place_id: 102, order_index: 1,
place: { id: 102, name: 'Ueno Park', lat: 35.72, lng: 139.77 },
} as unknown as Assignment
const NOTE = {
id: 41, day_id: 2, text: 'Buy museum tickets', time: '08:00', icon: 'Ticket', sort_order: 0,
} as unknown as DayNote
const FLIGHT = {
id: 21, type: 'flight', title: 'LH 714 to Tokyo', day_id: 2,
reservation_time: '2026-05-02T08:15',
} as unknown as TransportEntry
const TRANSIT_RES = {
id: 22, type: 'transit', title: 'Shibuya → Asakusa', day_id: 2,
reservation_time: '2026-05-02T10:05',
} as unknown as TransportEntry
const TRANSIT: TransitMeta = {
legs: [{
mode: 'SUBWAY', line: 'G', line_color: '#FF9500', duration: 900,
from: { name: 'Shibuya Sta.' }, to: { name: 'Asakusa Sta.' },
}],
}
const SEG: RouteSegment = {
mid: [35.7, 139.7], from: [35.71, 139.79], to: [35.72, 139.77],
distance: 2100, duration: 600,
walkingText: '26 min', drivingText: '7 min', distanceText: '2.1 km',
}
const M_PLACE: MergedItem = { type: 'place', sortKey: 0, data: MUSEUM }
const M_FLIGHT: MergedItem = { type: 'transport', sortKey: 1, data: FLIGHT }
const M_TRANSIT: MergedItem = { type: 'transport', sortKey: 2, data: TRANSIT_RES }
const M_NOTE: MergedItem = { type: 'note', sortKey: 3, data: NOTE }
const M_PLACE2: MergedItem = { type: 'place', sortKey: 4, data: PARK }
const MERGED = [M_PLACE, M_FLIGHT, M_TRANSIT, M_NOTE, M_PLACE2]
const ROWS: PlanRow[] = [
{ key: 'pl-11', kind: 'place', item: M_PLACE, assignment: MUSEUM, linkedReservations: [] },
{ key: 'conn-pl-11', kind: 'conn', seg: SEG, assignmentId: 11 },
{ key: 'tr-21', kind: 'transport', item: M_FLIGHT, res: FLIGHT },
{ key: 'tr-22', kind: 'transit', item: M_TRANSIT, res: TRANSIT_RES, transit: TRANSIT },
{ key: 'note-41', kind: 'note', item: M_NOTE, note: NOTE },
{ key: 'pl-12', kind: 'place', item: M_PLACE2, assignment: PARK, linkedReservations: [] },
{ key: 'conn-orphan', kind: 'conn', seg: { ...SEG, mode: 'walking' } },
]
const EMPTY_SCHEDULE: PluginDaySchedule = {
byAssignment: {}, byReservation: {}, byPosition: {}, minutesByDay: {},
}
function buildTl(over: Record<string, unknown> = {}): MPlanTimelineController {
return {
day: DAY,
rows: ROWS,
merged: MERGED,
hotelLegs: { top: null, bottom: null },
hotelChips: [],
weather: null,
weatherTemp: null,
weatherPlaceName: null,
upNext: { assignment: MUSEUM, minutesUntil: 45 },
language: 'en',
timeFormat: '24h',
openTransitKeys: new Set<string>(),
toggleTransit: vi.fn(),
moveRow: vi.fn(),
removeAssignment: vi.fn(),
editAssignment: vi.fn(),
editTransport: vi.fn(),
openTransitJourney: vi.fn(),
addPlace: vi.fn(),
addBooking: vi.fn(),
addTransport: vi.fn(),
optimize: vi.fn(async () => undefined),
canExportRoute: true,
exportGoogleMaps: vi.fn(),
exportCoMaps: vi.fn(),
routeTargets: [
{ id: 'google', label: 'Google Maps', url: 'https://www.google.com/maps/dir/1,2/3,4' },
{ id: 'comaps', label: 'CoMaps', url: 'https://comaps.at/route?x' },
{ id: 'waze', label: 'Waze', url: 'https://waze.com/ul?ll=1,2&navigate=yes', firstStopOnly: true },
],
renameDay: vi.fn(),
fullPlaceOf: vi.fn(() => undefined as Place | undefined),
routeModeOptions: [
{ key: 'driving', label: 'Driving' },
{ key: 'walking', label: 'Walking' },
{ key: 'plugin:ev/fastest', label: 'EV fastest' },
],
setLegMode: vi.fn(),
transitLegFor: vi.fn(() => null),
planTransitLeg: vi.fn(),
journeyLate: vi.fn(() => null),
tourOverrun: vi.fn(() => null),
...over,
} as unknown as MPlanTimelineController
}
/** The scrollable timeline card — its inline top offset encodes the layout mode. */
const card = (container: HTMLElement) => container.querySelector('.overflow-y-auto') as HTMLElement
function renderTimeline(
tlOver: Record<string, unknown> = {},
plannerOver: Partial<TripPlanner> = {},
shellOver: Partial<MTripShellApi> = {},
) {
mocks.tl = buildTl(tlOver) as unknown as Record<string, unknown>
const planner = buildPlanner(plannerOver)
const shell = buildShell(shellOver)
return { planner, shell, ...render(<MPlanTimeline planner={planner} shell={shell} />) }
}
describe('MPlanTimeline', () => {
beforeEach(() => {
resetAllStores()
mocks.schedule = EMPTY_SCHEDULE
})
describe('go mode — up next card', () => {
it('FE-MOB-PLTL-001: shows the next stop with its time, subtitle and countdown', () => {
renderTimeline()
expect(screen.getByText('mobileTrip.upNext')).toBeInTheDocument()
expect(screen.getByText('mobileTrip.inCountdown:transit.min:45')).toBeInTheDocument()
expect(screen.getAllByText('Museum').length).toBeGreaterThan(0)
expect(screen.getAllByText('09:30').length).toBeGreaterThan(0)
expect(screen.getAllByText('Museum Rd 1').length).toBeGreaterThan(0)
})
it('FE-MOB-PLTL-002: tapping the card selects the place and its assignment', () => {
const { planner } = renderTimeline()
fireEvent.click(screen.getByText('mobileTrip.upNext'))
expect(planner.handlePlaceClick).toHaveBeenCalledWith(101, 11)
})
it('FE-MOB-PLTL-003: hides the countdown, time chip and subtitle when the stop has none', () => {
const bare = { ...MUSEUM, place: { id: 101, name: 'Museum' } } as unknown as Assignment
renderTimeline({ upNext: { assignment: bare, minutesUntil: null }, rows: [], merged: [] })
expect(screen.queryByText(/mobileTrip.inCountdown/)).not.toBeInTheDocument()
expect(screen.queryByText('09:30')).not.toBeInTheDocument()
expect(screen.queryByText('Museum Rd 1')).not.toBeInTheDocument()
})
it('FE-MOB-PLTL-004: the timeline follows the up-next card in one column, and starts at the top without one', () => {
const { container, unmount } = renderTimeline()
// The card flows under the up-next card at a fixed gap, whatever its height,
// rather than at an offset that assumed an address line (a gap without one).
// The card is a frame around the scroller, so a row's fade at the edge leaves the frame whole.
const upNext = screen.getByText('mobileTrip.upNext').closest('button') as HTMLElement
const frame = card(container).parentElement as HTMLElement
expect(upNext.nextElementSibling).toBe(frame)
expect(frame).toHaveClass('overflow-hidden', 'rounded-[22px]')
expect(card(container)).toHaveClass('overflow-y-auto')
expect(frame.parentElement).toHaveClass('flex-col', 'gap-3')
// On a wide window the column ends where the rail does.
expect(frame.parentElement).toHaveClass('wide:bottom-[calc(env(safe-area-inset-bottom,0px)+12px)]')
expect(card(container).style.top).toBe('')
unmount()
const empty = renderTimeline({ upNext: null, rows: [], merged: [] })
expect(screen.queryByText('mobileTrip.upNext')).not.toBeInTheDocument()
expect(card(empty.container).parentElement?.previousElementSibling).toBeNull()
})
})
describe('timeline header', () => {
it('FE-MOB-PLTL-005: renders the accommodation chips and the weather chip', () => {
renderTimeline({
hotelChips: [
{ key: 'out-1', variant: 'checkout', name: 'Hotel Sacher', time: '11:00:00' },
{ key: 'in-2', variant: 'checkin', name: 'Ryokan Kyoto', time: '15:00:00' },
{ key: 'stay-3', variant: 'stay', name: 'Capsule Tokyo', time: null },
],
weather: { main: 'Rain', temp: 17 },
weatherTemp: 17,
})
// The name gives way with an ellipsis; the time after it stays, with no dot between.
const sacher = screen.getByText('Hotel Sacher')
expect(sacher).toHaveClass('truncate', 'min-w-0')
// In an Arabic header a Latin name keeps its own direction, so the ellipsis lands at its end.
expect(sacher).toHaveAttribute('dir', 'auto')
expect(sacher.closest('button')).toHaveTextContent('Hotel Sacher11:00')
expect(sacher.closest('button')).toHaveClass('shrink')
expect(screen.getByText('Ryokan Kyoto').closest('button')).toHaveTextContent('Ryokan Kyoto15:00')
expect(screen.getByText('Capsule Tokyo')).toBeInTheDocument()
expect(screen.getByText('17°')).toBeInTheDocument()
})
it('FE-MOB-PLTL-005b: the weather chip names its anchor place in the accessible label (#2167)', () => {
renderTimeline({
weather: { main: 'Rain', temp: 17 },
weatherTemp: 17,
weatherPlaceName: 'Shibuya',
})
// echoT renders t('day.weatherFor', { name }) as 'day.weatherFor:Shibuya'.
expect(screen.getByRole('button', { name: 'day.overview · day.weatherFor:Shibuya' })).toBeInTheDocument()
expect(screen.getByTitle('Shibuya')).toBeInTheDocument()
})
it('FE-MOB-PLTL-006: a stay chip opens the overview of its booking, not the editor (#2210)', () => {
const { shell } = renderTimeline(
{ hotelChips: [{ key: 'in-3', variant: 'checkin', name: 'Capsule Tokyo', time: '15:00:00', accId: 3, placeId: 301 }] },
{ reservations: [{ id: 44, type: 'hotel', accommodation_id: 3 }] as unknown as TripPlanner['reservations'] },
)
fireEvent.click(screen.getByRole('button', { name: 'day.checkIn · Capsule Tokyo · 15:00' }))
expect(shell.openSheet).toHaveBeenCalledWith('transport', { reservationId: 44 })
})
it('FE-MOB-PLTL-006d: a stay with neither booking nor place opens the editor for members who may edit days', () => {
const { shell } = renderTimeline({
hotelChips: [{ key: 'in-3', variant: 'checkin', name: 'Capsule Tokyo', time: '15:00:00', accId: 3, placeId: null }],
})
fireEvent.click(screen.getByRole('button', { name: 'day.checkIn · Capsule Tokyo · 15:00' }))
expect(shell.openSheet).toHaveBeenCalledWith('accommodation', { dayId: 2, accId: 3, from: 'timeline' })
})
it('FE-MOB-PLTL-006b: without day_edit the chip opens the hotel place instead', () => {
const { planner, shell } = renderTimeline(
{ hotelChips: [{ key: 'stay-3', variant: 'stay', name: 'Capsule Tokyo', time: null, accId: 3, placeId: 301 }] },
{ can: vi.fn(() => false) },
)
fireEvent.click(screen.getByRole('button', { name: 'mobileTrip.stay · Capsule Tokyo' }))
expect(planner.handlePlaceClick).toHaveBeenCalledWith(301)
expect(shell.openSheet).not.toHaveBeenCalled()
})
it('FE-MOB-PLTL-006c: a stay without a place still leads a read-only member to the day sheet', () => {
const { planner, shell } = renderTimeline(
{ hotelChips: [{ key: 'out-3', variant: 'checkout', name: 'Capsule Tokyo', time: '11:00', accId: 3, placeId: null }] },
{ can: vi.fn(() => false) },
)
fireEvent.click(screen.getByRole('button', { name: 'day.checkOut · Capsule Tokyo · 11:00' }))
expect(shell.openSheet).toHaveBeenCalledWith('day', { dayId: 2 })
expect(planner.handlePlaceClick).not.toHaveBeenCalled()
})
it('FE-MOB-PLTL-007: still renders, with the day pill, without chips or weather (#2004)', () => {
const { container } = renderTimeline()
// The pill is the only way into the day sheet, so it may not depend on the
// day happening to have an accommodation or a weather reading.
expect(container.querySelector('.border-b')).not.toBeNull()
expect(screen.getByRole('button', { name: 'day.overview' })).toBeInTheDocument()
})
it('FE-MOB-PLTL-008: draws the hotel bookend legs above and below the rows', () => {
renderTimeline({
hotelLegs: {
top: { seg: SEG, name: 'Hotel Sacher' },
bottom: { seg: SEG, name: 'Ryokan Kyoto' },
},
})
expect(screen.getByText('Hotel Sacher')).toBeInTheDocument()
expect(screen.getByText('Ryokan Kyoto')).toBeInTheDocument()
})
})
describe('rows', () => {
it('FE-MOB-PLTL-009: renders one row per kind', () => {
renderTimeline()
expect(screen.getAllByText('Museum').length).toBeGreaterThan(0)
expect(screen.getByText('Ueno Park')).toBeInTheDocument()
expect(screen.getByText('LH 714 to Tokyo')).toBeInTheDocument()
expect(screen.getByText('Shibuya → Asakusa')).toBeInTheDocument()
expect(screen.getByText('Buy museum tickets')).toBeInTheDocument()
expect(screen.getByText('7 min')).toBeInTheDocument()
})
it('FE-MOB-PLTL-010: a place row selects its place', () => {
const { planner } = renderTimeline()
fireEvent.click(screen.getByText('Ueno Park'))
expect(planner.handlePlaceClick).toHaveBeenCalledWith(102, 12)
})
it('FE-MOB-PLTL-011: a place row without a place still reports the assignment', () => {
const orphan = { id: 13, day_id: 2, place_id: 103, order_index: 2, place: null } as unknown as Assignment
const rows: PlanRow[] = [{ key: 'pl-13', kind: 'place', item: M_PLACE, assignment: orphan, linkedReservations: [] }]
const { planner, container } = renderTimeline({ rows })
fireEvent.click(container.querySelector('.cursor-pointer.items-center') as HTMLElement)
expect(planner.handlePlaceClick).toHaveBeenCalledWith(null, 13)
})
it('FE-MOB-PLTL-012: a transport row opens the transport sheet in go mode', () => {
const { shell } = renderTimeline()
fireEvent.click(screen.getByText('LH 714 to Tokyo'))
expect(shell.openSheet).toHaveBeenCalledWith('transport', { reservationId: 21 })
})
it('FE-MOB-PLTL-013: a transport row opens the editor in edit mode', () => {
const { shell } = renderTimeline({}, {}, { mode: 'edit' })
fireEvent.click(screen.getByText('LH 714 to Tokyo'))
expect(mocks.tl.editTransport).toHaveBeenCalledWith(FLIGHT)
expect(shell.openSheet).not.toHaveBeenCalledWith('transport', { reservationId: 21 })
})
it('FE-MOB-PLTL-014: a transit row toggles by its row key and renders its legs when open', () => {
const { unmount } = renderTimeline()
fireEvent.click(screen.getByText('Shibuya → Asakusa'))
expect(mocks.tl.toggleTransit).toHaveBeenCalledWith('tr-22')
expect(screen.queryByText('Shibuya Sta. → Asakusa Sta.')).not.toBeInTheDocument()
unmount()
renderTimeline({ openTransitKeys: new Set(['tr-22']) })
expect(screen.getByText('Shibuya Sta. → Asakusa Sta.')).toBeInTheDocument()
expect(screen.getByText('transit.min:15')).toBeInTheDocument()
})
it('FE-MOB-PLTL-014b: a transit row says when it now arrives after the next city walk starts (CW-08)', () => {
renderTimeline({ journeyLate: vi.fn(() => ({ walk: 'Harbour', time: '13:00' })) })
expect(mocks.tl.journeyLate).toHaveBeenCalledWith(expect.objectContaining({ type: 'transport' }))
expect(screen.getByTestId('transit-walk-late')).toBeInTheDocument()
})
it('FE-MOB-PLTL-015: a note row opens the note sheet with its note in edit mode', () => {
const { shell } = renderTimeline({}, {}, { mode: 'edit' })
fireEvent.click(screen.getByText('Buy museum tickets'))
expect(shell.openSheet).toHaveBeenCalledWith('note', { dayId: 2, note: NOTE })
})
it('FE-MOB-PLTL-016: the reorder arrows move the merged item they belong to', () => {
renderTimeline({}, {}, { mode: 'edit' })
const ups = screen.getAllByLabelText('dayplan.moveUp')
const downs = screen.getAllByLabelText('dayplan.moveDown')
// one stack per reorderable row: place, transport, transit, note, place
expect(ups).toHaveLength(5)
expect(ups[0]).toBeDisabled()
expect(downs[4]).toBeDisabled()
fireEvent.click(downs[0])
fireEvent.click(ups[4])
expect(mocks.tl.moveRow).toHaveBeenNthCalledWith(1, M_PLACE, 'down')
expect(mocks.tl.moveRow).toHaveBeenNthCalledWith(2, M_PLACE2, 'up')
})
})
describe('Tours read-only timeline integration', () => {
const tour = { ...MUSEUM, id: 91, place_id: 901,
place: { ...MUSEUM.place, id: 901, name: 'Assigned Tour' }, tour_place_id: 901 } as Assignment
const item: MergedItem = { type: 'place', sortKey: 0, data: tour }
const row: PlanRow = { key: 'pl-91', kind: 'place', item, assignment: tour, linkedReservations: [], invalidTour: true }
it('shows one localized invalid-endpoint warning and selects the Tour through the shared Place path', () => {
const { planner } = renderTimeline({ rows: [row], merged: [item], upNext: null }, { toursEnabled: true, tours: [] })
expect(screen.getAllByText('tours.dayRoute.endpointUnknown')).toHaveLength(1)
fireEvent.click(screen.getByText('Assigned Tour'))
expect(planner.handlePlaceClick).toHaveBeenCalledWith(901, 91)
expect(screen.queryByRole('dialog')).not.toBeInTheDocument()
expect(screen.queryByText('tour-planner')).not.toBeInTheDocument()
})
it('does not show the warning for valid status or with Tours disabled', () => {
const validRow: PlanRow = { ...row, invalidTour: false }
const first = renderTimeline({ rows: [validRow], merged: [item], upNext: null }, { toursEnabled: true, tours: [] })
expect(screen.queryByText('tours.dayRoute.endpointUnknown')).not.toBeInTheDocument()
first.unmount()
renderTimeline({ rows: [row], merged: [item], upNext: null }, { toursEnabled: false })
expect(screen.queryByText('tours.dayRoute.endpointUnknown')).not.toBeInTheDocument()
})
it('TIME-02-020: a tour row says when its end runs into the next timed item, read from the shared timeline logic', () => {
const validRow: PlanRow = { ...row, invalidTour: false }
const tourOverrun = vi.fn(() => ({ name: 'Lunch', time: '12:00', end: '13:00' }))
renderTimeline({ rows: [validRow], merged: [item], upNext: null, tourOverrun }, { toursEnabled: true, tours: [] })
expect(tourOverrun).toHaveBeenCalledWith(item)
expect(screen.getByTestId('tour-day-overrun')).toBeInTheDocument()
})
})
describe('per-segment travel mode', () => {
/** The timeline only offers the mode menu in edit mode, where many buttons exist. */
const renderEditing = () => renderTimeline({}, {}, { mode: 'edit' })
const connector = () => screen.getByText('7 min').closest('button') as HTMLElement
it('FE-MOB-PLTL-017: a connector with an origin assignment opens the mode menu', () => {
renderEditing()
fireEvent.click(connector())
expect(screen.getByText('Driving')).toBeInTheDocument()
expect(screen.getByText('Walking')).toBeInTheDocument()
expect(screen.getByText('EV fastest')).toBeInTheDocument()
expect(screen.getByText('dayplan.transportMode.useDefault')).toBeInTheDocument()
})
it('FE-MOB-PLTL-018: picking a mode sets it on the origin assignment', () => {
renderEditing()
fireEvent.click(connector())
fireEvent.click(screen.getByText('Walking'))
expect(mocks.tl.setLegMode).toHaveBeenCalledWith(11, 'walking')
})
it('FE-MOB-PLTL-019: the default entry clears the override', () => {
renderEditing()
fireEvent.click(connector())
fireEvent.click(screen.getByText('dayplan.transportMode.useDefault'))
expect(mocks.tl.setLegMode).toHaveBeenCalledWith(11, null)
})
it('FE-MOB-PLTL-046: a leg with a transit search behind it offers Public transit and opens it (#2398)', () => {
const leg = { from: { name: 'Museum', lat: 35.71, lng: 139.79 }, to: { name: 'Ueno Park', lat: 35.72, lng: 139.77 }, time: '09:30' }
renderTimeline({ transitLegFor: vi.fn(() => leg) }, {}, { mode: 'edit' })
fireEvent.click(connector())
expect(mocks.tl.transitLegFor).toHaveBeenCalledWith(SEG)
fireEvent.click(screen.getByText('transit.title'))
expect(mocks.tl.planTransitLeg).toHaveBeenCalledWith(leg, 11)
expect(mocks.tl.setLegMode).not.toHaveBeenCalled()
})
it('FE-MOB-PLTL-047: without a transit search for the leg the menu keeps to the road profiles', () => {
renderEditing()
fireEvent.click(connector())
expect(screen.getByText('Driving')).toBeInTheDocument()
expect(screen.queryByText('transit.title')).not.toBeInTheDocument()
})
it('FE-MOB-PLTL-020: read-only members get no tappable connectors', () => {
renderTimeline({}, { can: vi.fn(() => false) }, { mode: 'edit' })
expect(screen.getByText('7 min').closest('button')).toBeNull()
})
it('FE-MOB-PLTL-020b: go mode keeps the connectors read-only even with edit rights', () => {
renderTimeline()
expect(screen.getByText('7 min').closest('button')).toBeNull()
})
})
describe('plugin day schedule', () => {
it('FE-MOB-PLTL-021: slots contributions under their anchors and at the day edges', () => {
mocks.schedule = {
byAssignment: { 2: { 11: [{ pluginId: 'ev', id: 'a1', dayId: 2, assignmentId: 11, minutes: 35, label: 'Charging stop', tone: 'success' }] } },
byReservation: {
2: {
21: [{ pluginId: 'ev', id: 'r1', dayId: 2, reservationId: 21, minutes: 45, label: 'Security', tone: 'warn' }],
22: [{ pluginId: 'ev', id: 'r2', dayId: 2, reservationId: 22, label: 'Ticket check', tone: 'default' }],
},
},
byPosition: {
2: {
start: [{ pluginId: 'ev', id: 's1', dayId: 2, position: 'start', minutes: 10, label: 'Morning prep', tone: 'default' }],
end: [{ pluginId: 'ev', id: 'e1', dayId: 2, position: 'end', minutes: 20, label: 'Evening wrap', tone: 'danger' }],
},
},
minutesByDay: { 2: 110 },
}
renderTimeline()
expect(screen.getByText('Charging stop')).toBeInTheDocument()
expect(screen.getByText('Security')).toBeInTheDocument()
expect(screen.getByText('Ticket check')).toBeInTheDocument()
expect(screen.getByText('Morning prep')).toBeInTheDocument()
expect(screen.getByText('Evening wrap')).toBeInTheDocument()
})
it('FE-MOB-PLTL-022: contributes nothing while no day is selected', () => {
mocks.schedule = {
byAssignment: { 2: { 11: [{ pluginId: 'ev', id: 'a1', dayId: 2, assignmentId: 11, minutes: 35, label: 'Charging stop', tone: 'success' }] } },
byReservation: {},
byPosition: { 2: { start: [{ pluginId: 'ev', id: 's1', dayId: 2, position: 'start', label: 'Morning prep', tone: 'default' }], end: [] } },
minutesByDay: { 2: 35 },
}
const rows: PlanRow[] = [{ key: 'pl-11', kind: 'place', item: M_PLACE, assignment: MUSEUM, linkedReservations: [] }]
renderTimeline({ day: undefined, rows })
expect(screen.queryByText('Charging stop')).not.toBeInTheDocument()
expect(screen.queryByText('Morning prep')).not.toBeInTheDocument()
})
})
describe('empty day', () => {
it('FE-MOB-PLTL-023: shows the mascot empty state in go mode', () => {
const { container } = renderTimeline({ rows: [], merged: [], upNext: null })
expect(screen.getByText('dayplan.emptyDay')).toBeInTheDocument()
expect(container.querySelector('.trek--guide')).toBeTruthy()
})
it('FE-MOB-PLTL-024: replaces it with the action grid in edit mode', () => {
renderTimeline({ rows: [], merged: [], upNext: null }, {}, { mode: 'edit' })
expect(screen.queryByText('dayplan.emptyDay')).not.toBeInTheDocument()
expect(screen.getByText('mobileTrip.addPlaceShort')).toBeInTheDocument()
})
})
describe('edit mode', () => {
it('FE-MOB-PLTL-025: reserves the header space and hides the up-next card', () => {
const { container } = renderTimeline({}, {}, { mode: 'edit' })
expect(screen.queryByText('mobileTrip.upNext')).not.toBeInTheDocument()
// The edit header takes the up-next card's place, the timeline right under it.
expect(card(container).parentElement?.previousElementSibling).toContainElement(screen.getByLabelText('mobileTrip.renameDay'))
})
it('FE-MOB-PLTL-026: splits the day title into city pills', () => {
renderTimeline({}, {}, { mode: 'edit' })
expect(screen.getByText('Tokyo')).toBeInTheDocument()
expect(screen.getByText('Kyoto')).toBeInTheDocument()
})
it('FE-MOB-PLTL-027: falls back to the day number when the day has no title', () => {
renderTimeline({ day: { ...DAY, title: null } }, {}, { mode: 'edit' })
expect(screen.getByText('planner.dayN:2')).toBeInTheDocument()
// …and the day pill next to it stays icon-only so the name is not doubled.
expect(screen.getByRole('button', { name: 'day.overview' })).toHaveTextContent('')
})
it('FE-MOB-PLTL-028: the pencil renames the day and Enter commits the change', () => {
renderTimeline({}, {}, { mode: 'edit' })
fireEvent.click(screen.getByLabelText('mobileTrip.renameDay'))
const input = screen.getByPlaceholderText('mobileTrip.dayTitlePlaceholder') as HTMLInputElement
expect(input.value).toBe('Tokyo → Kyoto')
fireEvent.change(input, { target: { value: 'Osaka' } })
fireEvent.keyDown(input, { key: 'Enter' })
expect(mocks.tl.renameDay).toHaveBeenCalledWith('Osaka')
// committing closes the field again — the pills come back from the store
expect(screen.queryByPlaceholderText('mobileTrip.dayTitlePlaceholder')).not.toBeInTheDocument()
expect(screen.getByText('Tokyo')).toBeInTheDocument()
})
it('FE-MOB-PLTL-029: Escape leaves the title untouched', () => {
renderTimeline({}, {}, { mode: 'edit' })
fireEvent.click(screen.getByLabelText('mobileTrip.renameDay'))
const input = screen.getByPlaceholderText('mobileTrip.dayTitlePlaceholder')
fireEvent.change(input, { target: { value: 'Osaka' } })
fireEvent.keyDown(input, { key: 'Escape' })
expect(mocks.tl.renameDay).not.toHaveBeenCalled()
expect(screen.getByText('Tokyo')).toBeInTheDocument()
})
it('FE-MOB-PLTL-030: blurring an unchanged draft does not rename', () => {
renderTimeline({}, {}, { mode: 'edit' })
fireEvent.click(screen.getByLabelText('mobileTrip.renameDay'))
fireEvent.blur(screen.getByPlaceholderText('mobileTrip.dayTitlePlaceholder'))
expect(mocks.tl.renameDay).not.toHaveBeenCalled()
})
it('FE-MOB-PLTL-031: the calendar button opens the day reorder sheet', () => {
const { shell } = renderTimeline({}, {}, { mode: 'edit' })
fireEvent.click(screen.getByLabelText('dayplan.reorderDays'))
expect(shell.openSheet).toHaveBeenCalledWith('days')
})
it('FE-MOB-PLTL-032: undo is disabled until there is something to undo', () => {
const { unmount } = renderTimeline({}, {}, { mode: 'edit' })
expect(screen.getByText('undo.button').closest('button')).toBeDisabled()
unmount()
const { planner } = renderTimeline(
{}, { canUndo: true, lastActionLabel: 'undo.reorder' }, { mode: 'edit' },
)
const button = screen.getByText('undo.button').closest('button') as HTMLButtonElement
expect(button).toHaveAttribute('title', 'undo.tooltip:undo.reorder')
fireEvent.click(button)
expect(planner.handleUndo).toHaveBeenCalledTimes(1)
})
it('FE-MOB-PLTL-033: every action tile fires its planner action', () => {
const { shell } = renderTimeline({}, {}, { mode: 'edit' })
fireEvent.click(screen.getByText('mobileTrip.addPlaceShort'))
fireEvent.click(screen.getByText('mobileTrip.addNoteShort'))
fireEvent.click(screen.getByText('mobileTrip.addBookingShort'))
fireEvent.click(screen.getByText('mobileTrip.addTransportShort'))
fireEvent.click(screen.getByText('dayplan.optimize'))
expect(mocks.tl.addPlace).toHaveBeenCalledTimes(1)
expect(shell.openSheet).toHaveBeenCalledWith('note', { dayId: 2 })
expect(mocks.tl.addBooking).toHaveBeenCalledTimes(1)
expect(mocks.tl.addTransport).toHaveBeenCalledTimes(1)
expect(mocks.tl.optimize).toHaveBeenCalledTimes(1)
})
it('FE-MOB-PLTL-033b: one Maps tile asks which app gets the day, and the pick opens it', async () => {
const open = vi.spyOn(window, 'open').mockReturnValue(null)
renderTimeline({}, {}, { mode: 'edit' })
fireEvent.click(screen.getByText('mobileTrip.maps'))
const sheet = await screen.findByRole('dialog', { name: 'mobileTrip.openRouteIn' })
// The app that only takes one place says so.
expect(within(sheet).getByText('mobileTrip.firstStopOnly')).toBeInTheDocument()
fireEvent.click(within(sheet).getByText('Google Maps'))
expect(open).toHaveBeenCalledWith('https://www.google.com/maps/dir/1,2/3,4', '_blank', 'noopener,noreferrer')
open.mockRestore()
})
it('FE-MOB-PLTL-033c: with a preferred map app set, the Maps tile opens it straight away (#2423)', () => {
const open = vi.spyOn(window, 'open').mockReturnValue(null)
seedStore(useSettingsStore, { settings: { preferred_nav_app: 'comaps' } })
renderTimeline({}, {}, { mode: 'edit' })
fireEvent.click(screen.getByText('mobileTrip.maps'))
expect(open).toHaveBeenCalledWith('https://comaps.at/route?x', '_blank', 'noopener,noreferrer')
expect(screen.queryByRole('dialog', { name: 'mobileTrip.openRouteIn' })).not.toBeInTheDocument()
open.mockRestore()
})
it('FE-MOB-PLTL-049: a day with no route to hand over offers no Maps tile (#2476)', () => {
// A moving day whose only content is the flight: the export would be a drive
// from one hotel to the other, so the tile is left out, not left dead.
renderTimeline({ canExportRoute: false }, {}, { mode: 'edit' })
expect(screen.queryByText('mobileTrip.maps')).not.toBeInTheDocument()
expect(screen.getByText('dayplan.optimize')).toBeInTheDocument()
})
it('FE-MOB-PLTL-034: the note tile is inert while no day is selected', () => {
const { shell } = renderTimeline({ day: undefined, rows: [], merged: [] }, {}, { mode: 'edit' })
fireEvent.click(screen.getByText('mobileTrip.addNoteShort'))
expect(shell.openSheet).not.toHaveBeenCalled()
})
it('FE-MOB-PLTL-038: renaming starts from an empty draft while no day is loaded', () => {
renderTimeline({ day: undefined, rows: [], merged: [] }, {}, { mode: 'edit' })
fireEvent.click(screen.getByLabelText('mobileTrip.renameDay'))
const input = screen.getByPlaceholderText('mobileTrip.dayTitlePlaceholder') as HTMLInputElement
expect(input.value).toBe('')
fireEvent.change(input, { target: { value: 'Nara' } })
fireEvent.blur(input)
expect(mocks.tl.renameDay).toHaveBeenCalledWith('Nara')
})
it('FE-MOB-PLTL-035: read-only members never enter edit mode', () => {
renderTimeline({}, { can: vi.fn(() => false) }, { mode: 'edit' })
expect(screen.queryByText('mobileTrip.addPlaceShort')).not.toBeInTheDocument()
expect(screen.getByText('mobileTrip.upNext')).toBeInTheDocument()
})
it('FE-MOB-PLTL-036: place rows expose edit and remove in edit mode', () => {
renderTimeline({}, {}, { mode: 'edit' })
const edits = screen.getAllByLabelText('common.edit')
fireEvent.click(edits[0])
fireEvent.click(screen.getAllByLabelText('planner.removeFromDay')[0])
expect(mocks.tl.editAssignment).toHaveBeenCalledWith(MUSEUM)
expect(mocks.tl.removeAssignment).toHaveBeenCalledWith(MUSEUM)
})
it('FE-MOB-PLTL-048: without place_edit a place row keeps remove and reorder but loses its edit circle (#2446)', () => {
renderTimeline({}, { can: vi.fn((action: string) => action !== 'place_edit') as TripPlanner['can'] }, { mode: 'edit' })
// the place row keeps its remove circle and loses the edit one; the
// transport and note rows keep theirs, editing those is a day right
const row = screen.getByText('Museum').closest('[role="button"]') as HTMLElement
expect(within(row).getByLabelText('planner.removeFromDay')).toBeInTheDocument()
expect(within(row).queryByLabelText('common.edit')).not.toBeInTheDocument()
fireEvent.click(within(row).getByLabelText('planner.removeFromDay'))
expect(mocks.tl.removeAssignment).toHaveBeenCalledWith(MUSEUM)
expect(mocks.tl.editAssignment).not.toHaveBeenCalled()
})
it('FE-MOB-PLTL-037: the transit row opens the journey view from its edit circle', () => {
renderTimeline({}, {}, { mode: 'edit' })
const transitCard = screen.getByText('Shibuya → Asakusa').closest('.mt-1\\.5') as HTMLElement
fireEvent.click(within(transitCard).getByLabelText('common.edit'))
expect(mocks.tl.openTransitJourney).toHaveBeenCalledWith(TRANSIT_RES)
})
})
describe('day pager (#2051)', () => {
const DAYS = [
{ id: 1, trip_id: 1, day_number: 1 }, DAY, { id: 3, trip_id: 1, day_number: 3 },
] as unknown as Day[]
const strip = (container: HTMLElement) => container.querySelector('[data-day-pager]') as HTMLElement
const pages = (container: HTMLElement) => Array.from(strip(container).children) as HTMLElement[]
const current = (container: HTMLElement) => strip(container).querySelector('[data-page-active]') as HTMLElement
/** The strip comes to rest with the page of `dayId` filling it. jsdom has no
* layout, so the rects say where each page sits. */
function land(container: HTMLElement, dayId: number) {
const s = strip(container)
s.getBoundingClientRect = () => ({ left: 0 }) as DOMRect
for (const page of pages(container)) {
page.getBoundingClientRect = () => ({ left: page.dataset.dayId === String(dayId) ? 0 : 400 }) as DOMRect
}
fireEvent(s, new Event('scrollend'))
}
it('FE-MOB-PLTL-039: landing on the next page selects that day without re-framing the map', () => {
const { container, planner } = renderTimeline({}, { days: DAYS, selectedDayId: 2 })
land(container, 3)
// skipFit must be true: the map stays mounted under the timeline, and
// re-fitting it here would move it somewhere nobody asked for.
expect(planner.handleSelectDay).toHaveBeenCalledWith(3, true)
})
it('FE-MOB-PLTL-040: draws the neighbours as inert pages around the live current day', () => {
const { container } = renderTimeline({}, { days: DAYS, selectedDayId: 2 })
expect(pages(container).map(p => p.dataset.dayId)).toEqual(['1', '2', '3'])
expect(current(container).dataset.dayId).toBe('2')
for (const page of pages(container).filter(p => p !== current(container))) {
expect(page).toHaveAttribute('inert')
expect(page).toHaveAttribute('aria-hidden', 'true')
}
})
it('FE-MOB-PLTL-041: the live region is present and silent until a swipe lands', () => {
const { container } = renderTimeline({}, { days: DAYS, selectedDayId: 2 })
const live = container.querySelector('[role="status"]') as HTMLElement
expect(live).toHaveAttribute('aria-live', 'polite')
expect(live).toHaveAttribute('aria-atomic', 'true')
expect(live).toHaveTextContent('')
})
it('FE-MOB-PLTL-042: a landed swipe announces the day it reached', async () => {
const { container } = renderTimeline({}, { days: DAYS, selectedDayId: 2 })
land(container, 3)
await waitFor(() => expect(container.querySelector('[role="status"]'))
.toHaveTextContent('mobileTrip.dayAnnounce:3,3'))
})
it('FE-MOB-PLTL-043: edit mode keeps the pager, and only the current day arms the long-press reorder', () => {
const { container, planner } = renderTimeline({}, { days: DAYS, selectedDayId: 2 }, { mode: 'edit' })
const armed = Array.from(container.querySelectorAll('.overflow-y-auto')).filter(c => c.hasAttribute('data-touch-drag'))
expect(armed).toHaveLength(1)
expect(armed[0]).toBe(card(current(container)))
land(container, 1)
expect(planner.handleSelectDay).toHaveBeenCalledWith(1, true)
})
it('FE-MOB-PLTL-044: a plain tap on a place row of the current day still opens it', () => {
const { container, planner } = renderTimeline({}, { days: DAYS, selectedDayId: 2 })
fireEvent.click(within(current(container)).getByText('Ueno Park'))
expect(planner.handlePlaceClick).toHaveBeenCalledWith(102, 12)
})
it('FE-MOB-PLTL-045: an open leg menu holds the strip still, and nothing narrows touch-action', () => {
const { container } = renderTimeline({}, { days: DAYS, selectedDayId: 2 }, { mode: 'edit' })
expect(strip(container)).toHaveClass('overflow-x-auto')
// touch-action intersects down the tree, so a pan-y here would take the
// header strip's own horizontal pan with it.
expect(strip(container).style.touchAction).toBe('')
expect(card(current(container)).style.touchAction).toBe('')
fireEvent.click(within(current(container)).getByText('7 min').closest('button') as HTMLElement)
expect(strip(container)).toHaveClass('overflow-x-hidden')
})
})
})