mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-10-19 13:36:48 +00:00
Maurice
6fe5009c20
Review feedback on #2038: the root already has a script that does all of this, so the five jobs and the artifact shuffling between them were doing by hand what `npm run test:cov` does on its own. It ends with `--prefix plugin-sdk`, so all four packages are covered, and each writes its lcov to <pkg>/coverage/ — exactly where sonar.javascript.lcov.reportPaths looks. 131 lines become 28. Three things the plain root sequence still needs on a runner, kept as their own steps so the reason stays visible: - plugin-sdk is not a root workspace (workspaces = client, server, shared), so the root npm ci never reaches it and it needs its own. - The lockfile was generated on Windows and omits @swc/core's Linux optional binary, so the server's SWC transform cannot load. test.yml carries the same step for the same reason. - Only shared is built, not the root `build`. server and client run their suites from source through vitest, so building them adds a tsc pass and a full vite bundle that nothing here reads. The cost is wall-clock. The first run of the parallel version took 16 minutes, with client (11) and server (9) overlapping; sequentially that is closer to 25. Nobody waits on this job, so the simpler file is the better trade — but it is a trade, not a free win.