mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-11-20 02:56:10 +00:00
6f4dfc486f
- The client tools are looked for newest first, from 18 down: a client handles every server up to its own major and refuses a newer one. A dump or a restore now refuses a client older than the server up front, naming both versions, and the boot refuses a server outside PostgreSQL 14 to 18. - sslrootcert=system is used only by a client from libpq 16 on; an older client is refused with a message that names sslrootcert and the bin dir. - The restore's CVE-2025-8714 table covers 18. - A restore refuses a role that is a superuser or may run programs or write files on the database host, since the archive's SQL runs as that role; the boot warns about such a role. - pg_restore's script is streamed to its work file and stopped once it passes BACKUP_MAX_DECOMPRESSED_MB, so a small dump can no longer expand without limit on the data volume. - A failed tool's error keeps only the summarized stderr; its cause names the exit code and signal instead of carrying the process error, whose message and stderr quoted row data into the log. - The migration history is looked for in the current schema, where the tables and the backups are, so a role whose search_path is not public boots a second time.
52 lines
2.4 KiB
TypeScript
52 lines
2.4 KiB
TypeScript
import { run } from './pg-process';
|
|
|
|
/**
|
|
* The client-tool versions a restore accepts (CVE-2025-8714). A script from a
|
|
* dump an admin uploaded is run by psql, which would also run a psql
|
|
* meta-command (`\!` runs a shell command) smuggled into an object name. A
|
|
* fixed pg_restore opens the script with `\restrict <random key>`, and a fixed
|
|
* psql then refuses every meta-command until the matching `\unrestrict`.
|
|
*
|
|
* RESTRICT_SINCE holds, per major, the first minor that carries the fix, for
|
|
* every major TREK supports (14 to 18; 18 has it from 18.0). Every major after
|
|
* the last one listed has it from its first release.
|
|
*/
|
|
const RESTRICT_SINCE: Readonly<Partial<Record<number, number>>> = { 14: 19, 15: 14, 16: 10, 17: 6, 18: 0 };
|
|
const LAST_MAJOR_WITHOUT_IT = Math.max(...Object.keys(RESTRICT_SINCE).map(Number));
|
|
|
|
/** Whether `version` (`pg_restore (PostgreSQL) 17.11 (Debian …)`) carries the fix. */
|
|
export function hasRestrictFix(version: string): boolean {
|
|
const match = /\(PostgreSQL\) (\d+)\.(\d+)/.exec(version);
|
|
if (!match) return false;
|
|
const major = Number(match[1]);
|
|
const minor = Number(match[2]);
|
|
if (major > LAST_MAJOR_WITHOUT_IT) return true;
|
|
const firstFixedMinor = RESTRICT_SINCE[major];
|
|
return firstFixedMinor !== undefined && minor >= firstFixedMinor;
|
|
}
|
|
|
|
/** The minimum versions as the error names them, newest major first: "18.0, 17.6, 16.10, 15.14 or 14.19". */
|
|
function minimumVersionsText(): string {
|
|
const floors = Object.keys(RESTRICT_SINCE)
|
|
.map(Number)
|
|
.sort((a, b) => b - a)
|
|
.map((major) => `${major}.${RESTRICT_SINCE[major]}`);
|
|
const last = floors.pop() ?? '';
|
|
return floors.length > 0 ? `${floors.join(', ')} or ${last}` : last;
|
|
}
|
|
|
|
/**
|
|
* Refuses the restore when pg_restore or psql predates the fix. The tools'
|
|
* own versions are checked, not the script, whose text the dump controls.
|
|
*/
|
|
export async function refuseToolsWithoutRestrict(binDir: string | undefined): Promise<void> {
|
|
const tools = ['pg_restore', 'psql'] as const;
|
|
const versions = await Promise.all(tools.map((tool) => run(tool, binDir, ['--version'], {})));
|
|
const stale = tools.findIndex((_, i) => !hasRestrictFix(versions[i]));
|
|
if (stale < 0) return;
|
|
throw new Error(
|
|
`${tools[stale]} is too old to restore safely (${versions[stale].trim()}): it must be at least ${minimumVersionsText()} ` +
|
|
'(the Docker image has 18). Upgrade the PostgreSQL client tools or point TREK_DB_PG_BIN_DIR at newer ones.',
|
|
);
|
|
}
|