mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-10-23 07:26:30 +00:00
6d6efddc4e
- list_budget_items lists a trip's expenses with their ids, payers and splits, page by page so no page is cut down on its way to a model; get_budget_per_person answers who paid and owes what. Both in a new budget-items.mcp.ts, checked like their REST twins. - get_wind_forecast reads the hourly wind, gusts and direction of a day. - get_journey_tracks lists a journey's GPX tracks; the line for drawing rides under a key the provider never receives. - The Dawarich wishlist scan and the countries the recordings suggest become tools, with their confirming writes, in DawarichAtlasMcp in the Atlas group; the shared time window check refuses alike on REST and MCP, and the model never sees when the user was last seen in a city. - The journal's map, tracks and recorded days load with the journey group instead of riding in the core of every step. - The prompt points at list_budget_items for expense ids (the trip summary never carried them) and names the shares and the wind tools; each new read has its own live step.
168 lines
7.2 KiB
TypeScript
168 lines
7.2 KiB
TypeScript
/**
|
|
* Weather module e2e — exercises the migrated /api/weather endpoints through the
|
|
* real JwtAuthGuard against a temp SQLite db (seeded via the shared harness).
|
|
* The weather service is mocked so no real Open-Meteo calls happen.
|
|
*/
|
|
import type { McpContext } from '../../src/nest-mcp';
|
|
import { DomainError } from '../../src/nest/common/domain-error';
|
|
import { TrekExceptionFilter } from '../../src/nest/common/trek-exception.filter';
|
|
import { ZodValidationPipe } from '../../src/nest/common/zod-validation.pipe';
|
|
import { WeatherMcp } from '../../src/nest/weather/weather.mcp';
|
|
import { WeatherModule } from '../../src/nest/weather/weather.module';
|
|
import { WIND_UNAVAILABLE_MESSAGE, WindService } from '../../src/nest/weather/wind.service';
|
|
import { createTestMikroOrmModule } from '../helpers/test-orm';
|
|
import { TestUnitOfWorkModule } from '../helpers/test-uow';
|
|
import { createTempDb, seedUser, sessionCookie } from './harness';
|
|
import { Test } from '@nestjs/testing';
|
|
|
|
import cookieParser from 'cookie-parser';
|
|
import type { Server } from 'http';
|
|
import request from 'supertest';
|
|
import { describe, it, expect, beforeAll, afterAll, vi } from 'vitest';
|
|
|
|
const { db } = vi.hoisted(() => {
|
|
// eslint-disable-next-line @typescript-eslint/no-require-imports
|
|
const Database = require('better-sqlite3');
|
|
const tmp = new Database(':memory:');
|
|
tmp.exec('PRAGMA journal_mode = WAL');
|
|
tmp.exec(`CREATE TABLE users (id INTEGER PRIMARY KEY AUTOINCREMENT, username TEXT NOT NULL,
|
|
email TEXT NOT NULL UNIQUE, role TEXT NOT NULL DEFAULT 'user', password_version INTEGER NOT NULL DEFAULT 0);`);
|
|
return { db: tmp };
|
|
});
|
|
|
|
vi.mock('../../src/db/database', () => ({ db, closeDb: () => {}, reinitialize: () => {} }));
|
|
|
|
const { mockGet, mockGetDetailed } = vi.hoisted(() => ({ mockGet: vi.fn(), mockGetDetailed: vi.fn() }));
|
|
vi.mock('../../src/nest/weather/weather.impl', async (importActual) => {
|
|
const actual = await importActual<typeof import('../../src/nest/weather/weather.impl')>();
|
|
return { ...actual, getWeather: mockGet, getDetailedWeather: mockGetDetailed };
|
|
});
|
|
|
|
describe('Weather e2e (real auth guard + temp SQLite)', () => {
|
|
let server: Server;
|
|
let app: Awaited<ReturnType<typeof build>>;
|
|
|
|
async function build() {
|
|
// JwtAuthGuard (Plan 3b Task 1) injects EntityManager — needs
|
|
// MikroOrmModule.forRoot in the graph, same as every other e2e harness
|
|
// guarding a route with it; this suite's minimal hand-rolled `users`
|
|
// table already carries the five columns
|
|
// `findByIdWithPasswordVersion` selects.
|
|
const moduleRef = await Test.createTestingModule({
|
|
imports: [await TestUnitOfWorkModule.forRoot(db), await createTestMikroOrmModule(db), WeatherModule],
|
|
}).compile();
|
|
const nest = moduleRef.createNestApplication();
|
|
nest.use(cookieParser());
|
|
nest.useGlobalFilters(new TrekExceptionFilter());
|
|
// Mirror the production APP_PIPE: the wind route's DTO query is coerced as under buildApp().
|
|
nest.useGlobalPipes(new ZodValidationPipe());
|
|
await nest.init();
|
|
return nest;
|
|
}
|
|
|
|
beforeAll(async () => {
|
|
seedUser(db as never, { id: 1 });
|
|
app = await build();
|
|
server = app.getHttpServer();
|
|
mockGet.mockResolvedValue({ temp: 21, main: 'Clear', description: 'Klar', type: 'current' });
|
|
mockGetDetailed.mockResolvedValue({ temp: 20, main: 'Rain', description: 'Regen', type: 'forecast', hourly: [] });
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await app.close();
|
|
});
|
|
|
|
it('401 { error, code } without a session cookie', async () => {
|
|
const res = await request(server).get('/api/weather').query({ lat: '1', lng: '2' });
|
|
expect(res.status).toBe(401);
|
|
expect(res.body).toEqual({ error: 'Access token required', code: 'AUTH_REQUIRED' });
|
|
});
|
|
|
|
it('401 with an invalid token', async () => {
|
|
const res = await request(server)
|
|
.get('/api/weather')
|
|
.set('Cookie', 'trek_session=not-a-jwt')
|
|
.query({ lat: '1', lng: '2' });
|
|
expect(res.status).toBe(401);
|
|
expect(res.body).toEqual({ error: 'Invalid or expired token', code: 'AUTH_REQUIRED' });
|
|
});
|
|
|
|
it('400 when authenticated but lat/lng missing', async () => {
|
|
const res = await request(server).get('/api/weather').set('Cookie', sessionCookie(1)).query({ lng: '2' });
|
|
expect(res.status).toBe(400);
|
|
expect(res.body).toEqual({ error: 'Latitude and longitude are required' });
|
|
});
|
|
|
|
it('200 with a valid session cookie', async () => {
|
|
const res = await request(server)
|
|
.get('/api/weather')
|
|
.set('Cookie', sessionCookie(1))
|
|
.query({ lat: '52.5', lng: '13.4' });
|
|
expect(res.status).toBe(200);
|
|
expect(res.body).toMatchObject({ temp: 21, main: 'Clear', type: 'current' });
|
|
});
|
|
|
|
it('200 on /detailed with a valid session cookie', async () => {
|
|
const res = await request(server)
|
|
.get('/api/weather/detailed')
|
|
.set('Cookie', sessionCookie(1))
|
|
.query({ lat: '1', lng: '2', date: '2026-07-01' });
|
|
expect(res.status).toBe(200);
|
|
expect(res.body).toMatchObject({ type: 'forecast' });
|
|
});
|
|
|
|
// ── Wind: GET /wind and get_wind_forecast ask the one service alike ───────
|
|
|
|
const WIND = {
|
|
status: 'forecast' as const,
|
|
date: '2026-07-01',
|
|
lat: 38.7,
|
|
lng: -9.1,
|
|
timezone: 'Europe/Lisbon',
|
|
source: 'Open-Meteo' as const,
|
|
fetched_at: '2026-06-30T08:00:00.000Z',
|
|
horizon_days: 16,
|
|
hours: [{ hour: 14, speed_kmh: 22, gusts_kmh: 38, direction_deg: 320 }],
|
|
day: { speed_max_kmh: 22, gusts_max_kmh: 38, direction_dominant_deg: 320 },
|
|
};
|
|
const asMcp = { userId: 1 } as McpContext;
|
|
|
|
it('WEATHER-E2E-001: the wind route and get_wind_forecast answer the same forecast for the same query', async () => {
|
|
const forecast = vi.spyOn(app.get(WindService), 'forecast').mockResolvedValue(WIND);
|
|
|
|
const res = await request(server)
|
|
.get('/api/weather/wind')
|
|
.set('Cookie', sessionCookie(1))
|
|
.query({ lat: '38.7', lng: '-9.1', date: '2026-07-01' });
|
|
expect(res.status).toBe(200);
|
|
expect(res.body).toEqual(WIND);
|
|
|
|
const tool = await app.get(WeatherMcp).getWindForecast({ lat: 38.7, lng: -9.1, date: '2026-07-01' }, asMcp);
|
|
expect(JSON.parse(tool.content[0]?.text ?? '')).toEqual({ wind: WIND });
|
|
expect(forecast.mock.calls).toEqual([
|
|
[{ lat: 38.7, lng: -9.1, date: '2026-07-01' }],
|
|
[{ lat: 38.7, lng: -9.1, date: '2026-07-01' }],
|
|
]);
|
|
forecast.mockRestore();
|
|
});
|
|
|
|
it('WEATHER-E2E-002: a failed source is the 502 sentence on the route and the same sentence as a refusal over MCP', async () => {
|
|
const failure = new DomainError(502, WIND_UNAVAILABLE_MESSAGE, {
|
|
code: 'wind_unavailable',
|
|
details: { code: 'wind_unavailable' },
|
|
});
|
|
const forecast = vi.spyOn(app.get(WindService), 'forecast').mockRejectedValue(failure);
|
|
|
|
const res = await request(server)
|
|
.get('/api/weather/wind')
|
|
.set('Cookie', sessionCookie(1))
|
|
.query({ lat: '38.7', lng: '-9.1', date: '2026-07-01' });
|
|
expect(res.status).toBe(502);
|
|
expect(res.body).toEqual({ error: WIND_UNAVAILABLE_MESSAGE, code: 'wind_unavailable' });
|
|
|
|
const tool = await app.get(WeatherMcp).getWindForecast({ lat: 38.7, lng: -9.1, date: '2026-07-01' }, asMcp);
|
|
expect(tool).toEqual({ content: [{ type: 'text', text: WIND_UNAVAILABLE_MESSAGE }], isError: true });
|
|
forecast.mockRestore();
|
|
});
|
|
});
|