mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-06-19 21:31:46 +00:00
b4922322ae
Add new integration test files covering previously untested routes: - categories.test.ts — GET /api/categories - oidc.test.ts — full OIDC login flow (callback, state, errors) - settings.test.ts — GET/PUT /api/settings, bulk save - tags.test.ts — CRUD for trip tags - todo.test.ts — todo items CRUD and reorder Add new unit test files covering service-layer logic: - adminService.test.ts — user/invite management, packing templates, OIDC settings - atlasService.test.ts — atlas search and place enrichment - authServiceDb.test.ts — DB-backed auth helpers (login, register, MFA) - backupService.test.ts — export/import/restore logic - categoryService.test.ts — category CRUD - dayService.test.ts — day management and accommodation helpers - mapsService.test.ts — route/directions helpers - oidcService.test.ts — OIDC state, auth code, role resolution, user upsert - packingService.test.ts — packing item/bag/template operations - placeService.test.ts — place CRUD and tag attachment - settingsService.test.ts — settings get/set/bulk - tagService.test.ts — tag CRUD - todoService.test.ts — todo CRUD and reorder - tripService.test.ts — trip CRUD, member management, archiving - vacayService.test.ts — vacay integration helpers - tripAccess.test.ts (middleware) — requireTripAccess middleware Expand existing integration and unit test files with additional cases across admin, atlas, auth, backup, collab, days, files, maps, memories (Immich/Synology), notifications, places, reservations, share, vacay, weather, auth middleware, ephemeral tokens, notification preferences, permissions, SSRF guard, and WebSocket connection tests. Update test helpers (factories.ts, test-db.ts) with new factory functions and seed data required by the expanded suite. Fix minor issues in server/src/routes/reservations.ts and server/src/services/atlasService.ts surfaced by new test coverage. Update sonar-project.properties to reflect new coverage thresholds.
533 lines
21 KiB
TypeScript
533 lines
21 KiB
TypeScript
/**
|
|
* Vacay integration tests.
|
|
* Covers VACAY-001 to VACAY-025.
|
|
*/
|
|
import { describe, it, expect, vi, beforeAll, beforeEach, afterAll } from 'vitest';
|
|
import request from 'supertest';
|
|
import type { Application } from 'express';
|
|
|
|
const { testDb, dbMock } = vi.hoisted(() => {
|
|
const Database = require('better-sqlite3');
|
|
const db = new Database(':memory:');
|
|
db.exec('PRAGMA journal_mode = WAL');
|
|
db.exec('PRAGMA foreign_keys = ON');
|
|
db.exec('PRAGMA busy_timeout = 5000');
|
|
const mock = {
|
|
db,
|
|
closeDb: () => {},
|
|
reinitialize: () => {},
|
|
getPlaceWithTags: (placeId: number) => {
|
|
const place: any = db.prepare(`SELECT p.*, c.name as category_name, c.color as category_color, c.icon as category_icon FROM places p LEFT JOIN categories c ON p.category_id = c.id WHERE p.id = ?`).get(placeId);
|
|
if (!place) return null;
|
|
const tags = db.prepare(`SELECT t.* FROM tags t JOIN place_tags pt ON t.id = pt.tag_id WHERE pt.place_id = ?`).all(placeId);
|
|
return { ...place, category: place.category_id ? { id: place.category_id, name: place.category_name, color: place.category_color, icon: place.category_icon } : null, tags };
|
|
},
|
|
canAccessTrip: (tripId: any, userId: number) =>
|
|
db.prepare(`SELECT t.id, t.user_id FROM trips t LEFT JOIN trip_members m ON m.trip_id = t.id AND m.user_id = ? WHERE t.id = ? AND (t.user_id = ? OR m.user_id IS NOT NULL)`).get(userId, tripId, userId),
|
|
isOwner: (tripId: any, userId: number) =>
|
|
!!db.prepare('SELECT id FROM trips WHERE id = ? AND user_id = ?').get(tripId, userId),
|
|
};
|
|
return { testDb: db, dbMock: mock };
|
|
});
|
|
|
|
vi.mock('../../src/db/database', () => dbMock);
|
|
vi.mock('../../src/config', () => ({
|
|
JWT_SECRET: 'test-jwt-secret-for-trek-testing-only',
|
|
ENCRYPTION_KEY: 'a1b2c3d4e5f6a7b8c9d0e1f2a3b4c5d6a7b8c9d0e1f2a3b4c5d6a7b8c9d0e1f2',
|
|
updateJwtSecret: () => {},
|
|
}));
|
|
|
|
// Prevent real HTTP calls (holiday API etc.)
|
|
vi.stubGlobal('fetch', vi.fn().mockResolvedValue({
|
|
ok: true,
|
|
json: () => Promise.resolve([
|
|
{ date: '2025-01-01', name: 'New Year\'s Day', countryCode: 'DE' },
|
|
]),
|
|
}));
|
|
|
|
// Mock vacayService.getCountries to avoid real HTTP call to nager.at
|
|
vi.mock('../../src/services/vacayService', async () => {
|
|
const actual = await vi.importActual<typeof import('../../src/services/vacayService')>('../../src/services/vacayService');
|
|
return {
|
|
...actual,
|
|
getCountries: vi.fn().mockResolvedValue({
|
|
data: [{ countryCode: 'DE', name: 'Germany' }, { countryCode: 'FR', name: 'France' }],
|
|
}),
|
|
};
|
|
});
|
|
|
|
import { createApp } from '../../src/app';
|
|
import { createTables } from '../../src/db/schema';
|
|
import { runMigrations } from '../../src/db/migrations';
|
|
import { resetTestDb } from '../helpers/test-db';
|
|
import { createUser } from '../helpers/factories';
|
|
import { authCookie } from '../helpers/auth';
|
|
import { loginAttempts, mfaAttempts } from '../../src/routes/auth';
|
|
|
|
const app: Application = createApp();
|
|
|
|
beforeAll(() => {
|
|
createTables(testDb);
|
|
runMigrations(testDb);
|
|
});
|
|
|
|
beforeEach(() => {
|
|
resetTestDb(testDb);
|
|
loginAttempts.clear();
|
|
mfaAttempts.clear();
|
|
});
|
|
|
|
afterAll(() => {
|
|
testDb.close();
|
|
vi.unstubAllGlobals();
|
|
});
|
|
|
|
describe('Vacay plan', () => {
|
|
it('VACAY-001 — GET /api/addons/vacay/plan auto-creates plan on first access', async () => {
|
|
const { user } = createUser(testDb);
|
|
|
|
const res = await request(app)
|
|
.get('/api/addons/vacay/plan')
|
|
.set('Cookie', authCookie(user.id));
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.plan).toBeDefined();
|
|
expect(res.body.plan.owner_id).toBe(user.id);
|
|
});
|
|
|
|
it('VACAY-001 — second GET returns same plan (no duplicate creation)', async () => {
|
|
const { user } = createUser(testDb);
|
|
|
|
await request(app).get('/api/addons/vacay/plan').set('Cookie', authCookie(user.id));
|
|
const res = await request(app).get('/api/addons/vacay/plan').set('Cookie', authCookie(user.id));
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.plan).toBeDefined();
|
|
});
|
|
|
|
it('VACAY-002 — PUT /api/addons/vacay/plan updates plan settings', async () => {
|
|
const { user } = createUser(testDb);
|
|
|
|
// Ensure plan exists
|
|
await request(app).get('/api/addons/vacay/plan').set('Cookie', authCookie(user.id));
|
|
|
|
const res = await request(app)
|
|
.put('/api/addons/vacay/plan')
|
|
.set('Cookie', authCookie(user.id))
|
|
.send({ vacation_days: 30, carry_over_days: 5 });
|
|
expect(res.status).toBe(200);
|
|
});
|
|
});
|
|
|
|
describe('Vacay years', () => {
|
|
it('VACAY-007 — POST /api/addons/vacay/years adds a year to the plan', async () => {
|
|
const { user } = createUser(testDb);
|
|
await request(app).get('/api/addons/vacay/plan').set('Cookie', authCookie(user.id));
|
|
|
|
const res = await request(app)
|
|
.post('/api/addons/vacay/years')
|
|
.set('Cookie', authCookie(user.id))
|
|
.send({ year: 2025 });
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.years).toBeDefined();
|
|
});
|
|
|
|
it('VACAY-025 — GET /api/addons/vacay/years lists years in plan', async () => {
|
|
const { user } = createUser(testDb);
|
|
await request(app).get('/api/addons/vacay/plan').set('Cookie', authCookie(user.id));
|
|
await request(app).post('/api/addons/vacay/years').set('Cookie', authCookie(user.id)).send({ year: 2025 });
|
|
|
|
const res = await request(app)
|
|
.get('/api/addons/vacay/years')
|
|
.set('Cookie', authCookie(user.id));
|
|
expect(res.status).toBe(200);
|
|
expect(Array.isArray(res.body.years)).toBe(true);
|
|
expect(res.body.years.length).toBeGreaterThanOrEqual(1);
|
|
});
|
|
|
|
it('VACAY-008 — DELETE /api/addons/vacay/years/:year removes year', async () => {
|
|
const { user } = createUser(testDb);
|
|
await request(app).get('/api/addons/vacay/plan').set('Cookie', authCookie(user.id));
|
|
await request(app).post('/api/addons/vacay/years').set('Cookie', authCookie(user.id)).send({ year: 2026 });
|
|
|
|
const res = await request(app)
|
|
.delete('/api/addons/vacay/years/2026')
|
|
.set('Cookie', authCookie(user.id));
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.years).toBeDefined();
|
|
});
|
|
|
|
it('VACAY-011 — PUT /api/addons/vacay/stats/:year updates allowance', async () => {
|
|
const { user } = createUser(testDb);
|
|
await request(app).get('/api/addons/vacay/plan').set('Cookie', authCookie(user.id));
|
|
await request(app).post('/api/addons/vacay/years').set('Cookie', authCookie(user.id)).send({ year: 2025 });
|
|
|
|
const res = await request(app)
|
|
.put('/api/addons/vacay/stats/2025')
|
|
.set('Cookie', authCookie(user.id))
|
|
.send({ vacation_days: 28 });
|
|
expect(res.status).toBe(200);
|
|
});
|
|
});
|
|
|
|
describe('Vacay entries', () => {
|
|
it('VACAY-003 — POST /api/addons/vacay/entries/toggle marks a day as vacation', async () => {
|
|
const { user } = createUser(testDb);
|
|
await request(app).get('/api/addons/vacay/plan').set('Cookie', authCookie(user.id));
|
|
await request(app).post('/api/addons/vacay/years').set('Cookie', authCookie(user.id)).send({ year: 2025 });
|
|
|
|
const res = await request(app)
|
|
.post('/api/addons/vacay/entries/toggle')
|
|
.set('Cookie', authCookie(user.id))
|
|
.send({ date: '2025-06-16', year: 2025, type: 'vacation' });
|
|
expect(res.status).toBe(200);
|
|
});
|
|
|
|
it('VACAY-004 — POST /api/addons/vacay/entries/toggle on weekend is allowed (no server-side weekend blocking)', async () => {
|
|
const { user } = createUser(testDb);
|
|
await request(app).get('/api/addons/vacay/plan').set('Cookie', authCookie(user.id));
|
|
await request(app).post('/api/addons/vacay/years').set('Cookie', authCookie(user.id)).send({ year: 2025 });
|
|
|
|
// 2025-06-21 is a Saturday — server does not block weekends; client-side only
|
|
const res = await request(app)
|
|
.post('/api/addons/vacay/entries/toggle')
|
|
.set('Cookie', authCookie(user.id))
|
|
.send({ date: '2025-06-21', year: 2025, type: 'vacation' });
|
|
expect(res.status).toBe(200);
|
|
});
|
|
|
|
it('VACAY-006 — GET /api/addons/vacay/entries/:year returns vacation entries', async () => {
|
|
const { user } = createUser(testDb);
|
|
await request(app).get('/api/addons/vacay/plan').set('Cookie', authCookie(user.id));
|
|
await request(app).post('/api/addons/vacay/years').set('Cookie', authCookie(user.id)).send({ year: 2025 });
|
|
|
|
const res = await request(app)
|
|
.get('/api/addons/vacay/entries/2025')
|
|
.set('Cookie', authCookie(user.id));
|
|
expect(res.status).toBe(200);
|
|
expect(Array.isArray(res.body.entries)).toBe(true);
|
|
});
|
|
|
|
it('VACAY-009 — GET /api/addons/vacay/stats/:year returns stats for year', async () => {
|
|
const { user } = createUser(testDb);
|
|
await request(app).get('/api/addons/vacay/plan').set('Cookie', authCookie(user.id));
|
|
await request(app).post('/api/addons/vacay/years').set('Cookie', authCookie(user.id)).send({ year: 2025 });
|
|
|
|
const res = await request(app)
|
|
.get('/api/addons/vacay/stats/2025')
|
|
.set('Cookie', authCookie(user.id));
|
|
expect(res.status).toBe(200);
|
|
expect(res.body).toHaveProperty('stats');
|
|
});
|
|
});
|
|
|
|
describe('Vacay color', () => {
|
|
it('VACAY-024 — PUT /api/addons/vacay/color sets user color in plan', async () => {
|
|
const { user } = createUser(testDb);
|
|
await request(app).get('/api/addons/vacay/plan').set('Cookie', authCookie(user.id));
|
|
|
|
const res = await request(app)
|
|
.put('/api/addons/vacay/color')
|
|
.set('Cookie', authCookie(user.id))
|
|
.send({ color: '#3b82f6' });
|
|
expect(res.status).toBe(200);
|
|
});
|
|
});
|
|
|
|
describe('Vacay invite flow', () => {
|
|
it('VACAY-022 — cannot invite yourself', async () => {
|
|
const { user } = createUser(testDb);
|
|
await request(app).get('/api/addons/vacay/plan').set('Cookie', authCookie(user.id));
|
|
|
|
const res = await request(app)
|
|
.post('/api/addons/vacay/invite')
|
|
.set('Cookie', authCookie(user.id))
|
|
.send({ user_id: user.id });
|
|
expect(res.status).toBe(400);
|
|
});
|
|
|
|
it('VACAY-016 — send invite to another user', async () => {
|
|
const { user: owner } = createUser(testDb);
|
|
const { user: invitee } = createUser(testDb);
|
|
await request(app).get('/api/addons/vacay/plan').set('Cookie', authCookie(owner.id));
|
|
|
|
const res = await request(app)
|
|
.post('/api/addons/vacay/invite')
|
|
.set('Cookie', authCookie(owner.id))
|
|
.send({ user_id: invitee.id });
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.success).toBe(true);
|
|
});
|
|
|
|
it('VACAY-023 — GET /api/addons/vacay/available-users returns users who can be invited', async () => {
|
|
const { user } = createUser(testDb);
|
|
await request(app).get('/api/addons/vacay/plan').set('Cookie', authCookie(user.id));
|
|
|
|
const res = await request(app)
|
|
.get('/api/addons/vacay/available-users')
|
|
.set('Cookie', authCookie(user.id));
|
|
expect(res.status).toBe(200);
|
|
expect(Array.isArray(res.body.users)).toBe(true);
|
|
});
|
|
});
|
|
|
|
describe('Vacay holidays', () => {
|
|
it('VACAY-014 — GET /api/addons/vacay/holidays/countries returns available countries', async () => {
|
|
const { user } = createUser(testDb);
|
|
|
|
const res = await request(app)
|
|
.get('/api/addons/vacay/holidays/countries')
|
|
.set('Cookie', authCookie(user.id));
|
|
expect(res.status).toBe(200);
|
|
expect(Array.isArray(res.body)).toBe(true);
|
|
});
|
|
|
|
it('VACAY-012 — POST /api/addons/vacay/plan/holiday-calendars adds a holiday calendar', async () => {
|
|
const { user } = createUser(testDb);
|
|
await request(app).get('/api/addons/vacay/plan').set('Cookie', authCookie(user.id));
|
|
|
|
const res = await request(app)
|
|
.post('/api/addons/vacay/plan/holiday-calendars')
|
|
.set('Cookie', authCookie(user.id))
|
|
.send({ region: 'DE', label: 'Germany Holidays' });
|
|
expect(res.status).toBe(200);
|
|
});
|
|
});
|
|
|
|
describe('Vacay dissolve plan', () => {
|
|
it('VACAY-020 — POST /api/addons/vacay/dissolve removes user from plan', async () => {
|
|
const { user } = createUser(testDb);
|
|
await request(app).get('/api/addons/vacay/plan').set('Cookie', authCookie(user.id));
|
|
|
|
const res = await request(app)
|
|
.post('/api/addons/vacay/dissolve')
|
|
.set('Cookie', authCookie(user.id));
|
|
expect(res.status).toBe(200);
|
|
});
|
|
});
|
|
|
|
describe('Vacay holiday calendar CRUD', () => {
|
|
it('VACAY-026 — PUT /plan/holiday-calendars/:id updates an existing calendar', async () => {
|
|
const { user } = createUser(testDb);
|
|
await request(app).get('/api/addons/vacay/plan').set('Cookie', authCookie(user.id));
|
|
|
|
// Create a calendar first
|
|
const createRes = await request(app)
|
|
.post('/api/addons/vacay/plan/holiday-calendars')
|
|
.set('Cookie', authCookie(user.id))
|
|
.send({ region: 'US', label: 'US Holidays' });
|
|
expect(createRes.status).toBe(200);
|
|
const calId = createRes.body.plan?.holiday_calendars?.at(-1)?.id
|
|
?? (testDb.prepare('SELECT id FROM vacay_holiday_calendars ORDER BY id DESC LIMIT 1').get() as any)?.id;
|
|
|
|
const res = await request(app)
|
|
.put(`/api/addons/vacay/plan/holiday-calendars/${calId}`)
|
|
.set('Cookie', authCookie(user.id))
|
|
.send({ label: 'Updated Label', color: '#ff0000' });
|
|
expect(res.status).toBe(200);
|
|
});
|
|
|
|
it('VACAY-027 — DELETE /plan/holiday-calendars/:id removes the calendar', async () => {
|
|
const { user } = createUser(testDb);
|
|
await request(app).get('/api/addons/vacay/plan').set('Cookie', authCookie(user.id));
|
|
|
|
const createRes = await request(app)
|
|
.post('/api/addons/vacay/plan/holiday-calendars')
|
|
.set('Cookie', authCookie(user.id))
|
|
.send({ region: 'FR', label: 'French Holidays' });
|
|
expect(createRes.status).toBe(200);
|
|
const calId = (testDb.prepare('SELECT id FROM vacay_holiday_calendars ORDER BY id DESC LIMIT 1').get() as any)?.id;
|
|
|
|
const res = await request(app)
|
|
.delete(`/api/addons/vacay/plan/holiday-calendars/${calId}`)
|
|
.set('Cookie', authCookie(user.id));
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.success).toBe(true);
|
|
});
|
|
|
|
it('VACAY-027b — DELETE /plan/holiday-calendars/:id non-existent returns 404', async () => {
|
|
const { user } = createUser(testDb);
|
|
await request(app).get('/api/addons/vacay/plan').set('Cookie', authCookie(user.id));
|
|
|
|
const res = await request(app)
|
|
.delete('/api/addons/vacay/plan/holiday-calendars/99999')
|
|
.set('Cookie', authCookie(user.id));
|
|
expect(res.status).toBe(404);
|
|
});
|
|
});
|
|
|
|
describe('Vacay invite full flow', () => {
|
|
it('VACAY-028 — POST /invite/accept joins the invitee to the owner plan', async () => {
|
|
const { user: owner } = createUser(testDb);
|
|
const { user: invitee } = createUser(testDb);
|
|
|
|
// Owner creates plan
|
|
const planRes = await request(app).get('/api/addons/vacay/plan').set('Cookie', authCookie(owner.id));
|
|
const planId = planRes.body.plan.id;
|
|
|
|
// Owner invites invitee
|
|
await request(app)
|
|
.post('/api/addons/vacay/invite')
|
|
.set('Cookie', authCookie(owner.id))
|
|
.send({ user_id: invitee.id });
|
|
|
|
// Invitee accepts
|
|
const res = await request(app)
|
|
.post('/api/addons/vacay/invite/accept')
|
|
.set('Cookie', authCookie(invitee.id))
|
|
.send({ plan_id: planId });
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.success).toBe(true);
|
|
});
|
|
|
|
it('VACAY-029 — POST /invite/decline removes the pending invite', async () => {
|
|
const { user: owner } = createUser(testDb);
|
|
const { user: invitee } = createUser(testDb);
|
|
|
|
const planRes = await request(app).get('/api/addons/vacay/plan').set('Cookie', authCookie(owner.id));
|
|
const planId = planRes.body.plan.id;
|
|
|
|
await request(app)
|
|
.post('/api/addons/vacay/invite')
|
|
.set('Cookie', authCookie(owner.id))
|
|
.send({ user_id: invitee.id });
|
|
|
|
const res = await request(app)
|
|
.post('/api/addons/vacay/invite/decline')
|
|
.set('Cookie', authCookie(invitee.id))
|
|
.send({ plan_id: planId });
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.success).toBe(true);
|
|
});
|
|
|
|
it('VACAY-030 — POST /invite/cancel removes the pending invite from owner side', async () => {
|
|
const { user: owner } = createUser(testDb);
|
|
const { user: invitee } = createUser(testDb);
|
|
|
|
await request(app).get('/api/addons/vacay/plan').set('Cookie', authCookie(owner.id));
|
|
|
|
await request(app)
|
|
.post('/api/addons/vacay/invite')
|
|
.set('Cookie', authCookie(owner.id))
|
|
.send({ user_id: invitee.id });
|
|
|
|
const res = await request(app)
|
|
.post('/api/addons/vacay/invite/cancel')
|
|
.set('Cookie', authCookie(owner.id))
|
|
.send({ user_id: invitee.id });
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.success).toBe(true);
|
|
});
|
|
});
|
|
|
|
describe('Vacay company holidays', () => {
|
|
it('VACAY-032 — POST /entries/company-holiday toggles a company holiday', async () => {
|
|
const { user } = createUser(testDb);
|
|
await request(app).get('/api/addons/vacay/plan').set('Cookie', authCookie(user.id));
|
|
await request(app).post('/api/addons/vacay/years').set('Cookie', authCookie(user.id)).send({ year: 2025 });
|
|
|
|
const res = await request(app)
|
|
.post('/api/addons/vacay/entries/company-holiday')
|
|
.set('Cookie', authCookie(user.id))
|
|
.send({ date: '2025-12-25', note: 'Christmas' });
|
|
expect(res.status).toBe(200);
|
|
});
|
|
|
|
it('VACAY-033 — POST /entries/toggle with target_user_id not in plan returns 403', async () => {
|
|
const { user: owner } = createUser(testDb);
|
|
const { user: outsider } = createUser(testDb);
|
|
await request(app).get('/api/addons/vacay/plan').set('Cookie', authCookie(owner.id));
|
|
await request(app).post('/api/addons/vacay/years').set('Cookie', authCookie(owner.id)).send({ year: 2025 });
|
|
|
|
const res = await request(app)
|
|
.post('/api/addons/vacay/entries/toggle')
|
|
.set('Cookie', authCookie(owner.id))
|
|
.send({ date: '2025-07-14', target_user_id: outsider.id });
|
|
expect(res.status).toBe(403);
|
|
});
|
|
});
|
|
|
|
describe('Vacay stats restrictions', () => {
|
|
it('VACAY-034 — PUT /stats/:year for user not in plan returns 403', async () => {
|
|
const { user: owner } = createUser(testDb);
|
|
const { user: outsider } = createUser(testDb);
|
|
await request(app).get('/api/addons/vacay/plan').set('Cookie', authCookie(owner.id));
|
|
await request(app).post('/api/addons/vacay/years').set('Cookie', authCookie(owner.id)).send({ year: 2025 });
|
|
|
|
const res = await request(app)
|
|
.put('/api/addons/vacay/stats/2025')
|
|
.set('Cookie', authCookie(owner.id))
|
|
.send({ vacation_days: 25, target_user_id: outsider.id });
|
|
expect(res.status).toBe(403);
|
|
});
|
|
});
|
|
|
|
describe('Vacay holidays error path', () => {
|
|
it('VACAY-035 — GET /holidays/:year/:country returns 502 when external API fetch fails', async () => {
|
|
const { user } = createUser(testDb);
|
|
// Use an unusual country/year to avoid cache hits from other tests
|
|
vi.mocked(global.fetch as any).mockRejectedValueOnce(new Error('Network error'));
|
|
|
|
const res = await request(app)
|
|
.get('/api/addons/vacay/holidays/2099/ZZ')
|
|
.set('Cookie', authCookie(user.id));
|
|
expect(res.status).toBe(502);
|
|
});
|
|
});
|
|
|
|
describe('Vacay color restriction', () => {
|
|
it('VACAY-036 — PUT /color with target_user_id not in plan returns 403', async () => {
|
|
const { user: owner } = createUser(testDb);
|
|
const { user: outsider } = createUser(testDb);
|
|
await request(app).get('/api/addons/vacay/plan').set('Cookie', authCookie(owner.id));
|
|
|
|
const res = await request(app)
|
|
.put('/api/addons/vacay/color')
|
|
.set('Cookie', authCookie(owner.id))
|
|
.send({ color: '#ff0000', target_user_id: outsider.id });
|
|
expect(res.status).toBe(403);
|
|
});
|
|
});
|
|
|
|
describe('Vacay holidays success path', () => {
|
|
it('VACAY-037 — GET /holidays/:year/:country returns data when fetch succeeds', async () => {
|
|
const { user } = createUser(testDb);
|
|
// Use unique year/country to avoid cache from other tests
|
|
vi.mocked(global.fetch as any).mockResolvedValueOnce({
|
|
ok: true,
|
|
json: () => Promise.resolve([{ date: '2025-05-01', name: 'Labour Day', countryCode: 'AT' }]),
|
|
});
|
|
|
|
const res = await request(app)
|
|
.get('/api/addons/vacay/holidays/2025/AT')
|
|
.set('Cookie', authCookie(user.id));
|
|
expect(res.status).toBe(200);
|
|
});
|
|
});
|
|
|
|
describe('Vacay toggle entry for plan member', () => {
|
|
it('VACAY-038 — POST /entries/toggle with target_user_id in plan toggles their entry', async () => {
|
|
const { user: owner } = createUser(testDb);
|
|
const { user: invitee } = createUser(testDb);
|
|
|
|
const planRes = await request(app).get('/api/addons/vacay/plan').set('Cookie', authCookie(owner.id));
|
|
const planId = planRes.body.plan.id;
|
|
await request(app).post('/api/addons/vacay/years').set('Cookie', authCookie(owner.id)).send({ year: 2025 });
|
|
|
|
// Invite and accept so invitee is in the plan
|
|
await request(app)
|
|
.post('/api/addons/vacay/invite')
|
|
.set('Cookie', authCookie(owner.id))
|
|
.send({ user_id: invitee.id });
|
|
await request(app)
|
|
.post('/api/addons/vacay/invite/accept')
|
|
.set('Cookie', authCookie(invitee.id))
|
|
.send({ plan_id: planId });
|
|
|
|
// Owner toggles an entry for the invitee (who is now in the plan)
|
|
const res = await request(app)
|
|
.post('/api/addons/vacay/entries/toggle')
|
|
.set('Cookie', authCookie(owner.id))
|
|
.send({ date: '2025-06-10', target_user_id: invitee.id });
|
|
expect(res.status).toBe(200);
|
|
});
|
|
});
|