mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-10-18 21:16:47 +00:00
Maurice
6cf5760383
Nine fire-and-forget sends reached notifications.bridge through
import('...').then(({ send }) => ...). The laziness was working around a
module cycle that no longer exists, and it cost twice: it hid the edge from
the module graph, and it handed each send a NotificationsService built
outside the container rather than the container's own.
The sweep needed a method rather than a grep. tests/ sits outside
tsconfig's include, so a service that gains a constructor parameter does not
break its hand-wired call sites at compile time — the argument arrives as
undefined and throws inside the send. Adding tests to a throwaway tsconfig
and diffing the errors before and after named all 46 sites exactly. The same
config reports 288 pre-existing errors in the suites, almost all deliberate
partial constructions in the harnesses, which is why tests/ is not in the
build's include; that cleanup is its own piece of work and is written down
in the nest README.
notifications.instance.ts holds the out-of-container instance, apart from
notifications.bridge.ts on purpose: several suites replace the bridge
wholesale with vi.mock(..., () => ({ send })), and a sibling bridge taking
its instance from there would break under those mocks.
The suites that assert on a send now hand their spy to the injected service.
The reservations e2e overrides the provider, because its app resolves the
real one out of its own container and never saw the module mock.
25 lines
1.2 KiB
TypeScript
25 lines
1.2 KiB
TypeScript
import { Module } from '@nestjs/common';
|
|
import { PackingController } from './packing.controller';
|
|
import { AdminPackingTemplatesController } from './admin-packing-templates.controller';
|
|
import { PackingMcp } from './packing.mcp';
|
|
import { PackingService } from './packing.service';
|
|
import { PackingRpc } from './packing.rpc';
|
|
import { PluginGuardsModule } from '../plugins/host/plugin-guards.module';
|
|
import { RealtimeModule } from '../realtime/realtime.module';
|
|
import { PermissionsModule } from '../permissions/permissions.module';
|
|
import { AuditModule } from '../audit/audit.module';
|
|
import { AuthModule } from '../auth/auth.module';
|
|
import { AddonsModule } from '../addons/addons.module';
|
|
import { NotificationsModule } from '../notifications/notifications.module';
|
|
|
|
/** Packing domain (S2 — Phase 2 trip sub-domain). Registered in AppModule.
|
|
* Exports PackingService for in-container consumers (TripsService bundle,
|
|
* PackingRpc). */
|
|
@Module({
|
|
imports: [NotificationsModule, PermissionsModule, AuthModule, RealtimeModule, PluginGuardsModule, AddonsModule, AuditModule],
|
|
controllers: [PackingController, AdminPackingTemplatesController],
|
|
providers: [PackingService, PackingMcp, PackingRpc],
|
|
exports: [PackingService],
|
|
})
|
|
export class PackingModule {}
|