mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-10-19 05:26:47 +00:00
Maurice
6680bc7c74
PluginsModule was 21 controllers, 24 domain imports and 10 providers in one class, which made it the hub most of the Nest graph ran through: AdminModule imported it for a single cascade-disable call and inherited all of it. It is now PluginsRuntimeModule (supervisor, capability router, hook contracts), PluginContributionsModule (the 14 read-only hook controllers, moved to contributions/), PluginOAuthModule (the credential leaf, moved to oauth/) and a composition root that keeps the install and delivery controllers. AdminModule imports the runtime alone. The three plugin files that reached for the db singleton alongside the injected DatabaseService no longer do. plugin-host-state and signature-status take the connection from the caller, and the three per-user settings functions that were bare exports 'so the RPC host wiring can call them directly' are now PluginUserSettingsService - the host wiring is providers, so it injects them. Coverage moves from one repo-wide 80% to a per-domain ratchet. The single number let a well-covered domain subsidise a thin one: booking-import sits at 50% and integrations at 20%, and the aggregate still cleared the bar, so either could have lost another ten points unnoticed. Each domain now carries its own measured floor, regenerated by scripts/coverage-thresholds.mjs. Two test-side findings on the way: expect(undefined).toContain(SomeClass) PASSES in this vitest version - it only throws for a string needle. Every '<X> is listed in its module providers' guard was written that way, so all twelve of them silently stopped guarding the moment their class moved. They go through expectRegisteredProvider now, which asserts the array shape first. The atlas region test paid for the one-off decompression of the multi-MB admin1 bundle inside its own 5s budget, which is why it failed under load and passed alone. The bundle is warmed in beforeAll instead.
45 lines
2.0 KiB
TypeScript
45 lines
2.0 KiB
TypeScript
import { Module } from '@nestjs/common';
|
|
import { PluginsController } from './plugins.controller';
|
|
import { PluginsFeedController } from './plugins-feed.controller';
|
|
import { PluginsProxyController } from './plugins-proxy.controller';
|
|
import { PluginFrameController } from './plugin-frame.controller';
|
|
import { PluginActivityController } from './plugin-activity.controller';
|
|
import { PluginUserSettingsController } from './plugin-user-settings.controller';
|
|
import { PluginsRuntimeModule } from './plugins-runtime.module';
|
|
import { PluginOAuthModule } from './oauth/plugin-oauth.module';
|
|
import { PluginContributionsModule } from './contributions/plugin-contributions.module';
|
|
|
|
/**
|
|
* Plugin system (#plugins), composition root.
|
|
*
|
|
* It used to be one module with 21 controllers, 24 domain imports and 10 providers,
|
|
* which made it the hub almost the whole Nest graph ran through — AdminModule
|
|
* imported it for one method and inherited all of that. It is now three pieces plus
|
|
* this one:
|
|
*
|
|
* - `PluginsRuntimeModule` — supervisor, capability router, hook contracts. The half
|
|
* with the domain imports, and the only half AdminModule needs.
|
|
* - `PluginContributionsModule` — the 14 read-only hook controllers.
|
|
* - `PluginOAuthModule` — the outbound-OAuth leaf.
|
|
*
|
|
* What is left here is the CRUD and delivery surface: install/activate/configure, the
|
|
* feed the client reads, the proxy to a child's HTTP routes, and the sandboxed frame
|
|
* that serves page and widget assets.
|
|
*/
|
|
@Module({
|
|
imports: [PluginsRuntimeModule, PluginOAuthModule, PluginContributionsModule],
|
|
controllers: [
|
|
PluginsController,
|
|
PluginsFeedController,
|
|
PluginsProxyController,
|
|
PluginFrameController,
|
|
PluginUserSettingsController,
|
|
PluginActivityController,
|
|
],
|
|
// Re-exported so AppModule keeps working unchanged. A consumer that only needs the
|
|
// runtime imports PluginsRuntimeModule directly instead — that is the point of the
|
|
// split.
|
|
exports: [PluginsRuntimeModule],
|
|
})
|
|
export class PluginsModule {}
|