mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-11-22 21:11:14 +00:00
c10a698b9f
A saved place reopened for editing has no community version in its key, so the answer the tab kept the first time stayed until the tab closed: a picture another installation contributed since never showed. Kept answers now carry when they were fetched and are asked again after ten minutes, the same span the server keeps an empty answer. The key version moves to 5 so open tabs drop what they kept in the old shape.
82 lines
3.7 KiB
TypeScript
82 lines
3.7 KiB
TypeScript
// FE-PLANNER-ENRICHCACHE-001 to FE-PLANNER-ENRICHCACHE-007: the session cache the editor's
|
|
// details column and the view's photo gallery share, so a place is asked about once.
|
|
import type { MapsPlaceEnrichmentResult } from '@trek/shared';
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
|
|
|
|
import {
|
|
__clearEnrichmentCacheForTests,
|
|
cacheKeyFor,
|
|
readCachedEnrichment,
|
|
storeEnrichment,
|
|
type PlaceDetailsSelection,
|
|
} from './placeEnrichment';
|
|
|
|
const SELECTION: PlaceDetailsSelection = { placeId: 'way:1', lat: 50.9, lng: 6.96, name: 'Museum Ludwig' };
|
|
const RESULT = { photos: [], facts: [], description: null } as unknown as MapsPlaceEnrichmentResult;
|
|
|
|
beforeEach(() => {
|
|
sessionStorage.clear();
|
|
__clearEnrichmentCacheForTests();
|
|
});
|
|
|
|
afterEach(() => {
|
|
vi.restoreAllMocks();
|
|
});
|
|
|
|
describe('placeEnrichment', () => {
|
|
it('FE-PLANNER-ENRICHCACHE-001: the key names the version, the place (or its coordinates) and the language', () => {
|
|
expect(cacheKeyFor(SELECTION, 'de')).toBe('enrich_v5_way:1_de');
|
|
expect(cacheKeyFor({ lat: 1.5, lng: 2, name: 'Pin' }, 'en')).toBe('enrich_v5_coords:1.5:2_en');
|
|
});
|
|
|
|
it('FE-PLANNER-ENRICHCACHE-006: a place of the index served with another community version is another answer', () => {
|
|
const gers = { placeId: 'gers:abc', lat: 1, lng: 2, name: 'Cafe', details: { community_version: 3 } };
|
|
expect(cacheKeyFor(gers, 'de')).toBe('enrich_v5_gers:abc_c3_de');
|
|
expect(cacheKeyFor({ ...gers, details: { community_version: 4 } }, 'de')).not.toBe(cacheKeyFor(gers, 'de'));
|
|
expect(cacheKeyFor({ ...gers, details: {} }, 'de')).toBe('enrich_v5_gers:abc_de');
|
|
});
|
|
|
|
it('FE-PLANNER-ENRICHCACHE-002: nothing is cached before it is stored, then both caches hold it', () => {
|
|
expect(readCachedEnrichment(SELECTION, 'de')).toBeUndefined();
|
|
storeEnrichment(SELECTION, 'de', RESULT);
|
|
expect(readCachedEnrichment(SELECTION, 'de')).toBe(RESULT);
|
|
expect(JSON.parse(sessionStorage.getItem('enrich_v5_way:1_de') ?? '').value).toEqual(RESULT);
|
|
// Another language is another answer.
|
|
expect(readCachedEnrichment(SELECTION, 'en')).toBeUndefined();
|
|
});
|
|
|
|
it('FE-PLANNER-ENRICHCACHE-003: an answer kept in the session outlives the in-memory cache', () => {
|
|
storeEnrichment(SELECTION, 'de', RESULT);
|
|
__clearEnrichmentCacheForTests();
|
|
expect(readCachedEnrichment(SELECTION, 'de')).toEqual(RESULT);
|
|
// Taken back into memory: the session is not read a second time.
|
|
sessionStorage.clear();
|
|
expect(readCachedEnrichment(SELECTION, 'de')).toEqual(RESULT);
|
|
});
|
|
|
|
it('FE-PLANNER-ENRICHCACHE-004: a broken session entry reads as nothing cached', () => {
|
|
sessionStorage.setItem(cacheKeyFor(SELECTION, 'de'), '{not json');
|
|
expect(readCachedEnrichment(SELECTION, 'de')).toBeUndefined();
|
|
});
|
|
|
|
it('FE-PLANNER-ENRICHCACHE-005: a full or blocked session storage still keeps the answer in memory', () => {
|
|
vi.spyOn(Storage.prototype, 'setItem').mockImplementation(() => {
|
|
throw new Error('QuotaExceededError');
|
|
});
|
|
expect(() => storeEnrichment(SELECTION, 'de', RESULT)).not.toThrow();
|
|
expect(readCachedEnrichment(SELECTION, 'de')).toBe(RESULT);
|
|
});
|
|
|
|
it('FE-PLANNER-ENRICHCACHE-007: an answer is reused for ten minutes, then asked again', () => {
|
|
const now = vi.spyOn(Date, 'now').mockReturnValue(1_000_000);
|
|
storeEnrichment(SELECTION, 'de', RESULT);
|
|
now.mockReturnValue(1_000_000 + 9 * 60 * 1000);
|
|
expect(readCachedEnrichment(SELECTION, 'de')).toBe(RESULT);
|
|
now.mockReturnValue(1_000_000 + 10 * 60 * 1000);
|
|
expect(readCachedEnrichment(SELECTION, 'de')).toBeUndefined();
|
|
// Gone from the session too: a reload does not bring it back.
|
|
__clearEnrichmentCacheForTests();
|
|
expect(readCachedEnrichment(SELECTION, 'de')).toBeUndefined();
|
|
});
|
|
});
|