mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-06-19 13:21:46 +00:00
7a314a92b1
- Create server/src/utils/ssrfGuard.ts with checkSsrf() and createPinnedAgent()
- Resolves DNS before allowing outbound requests to catch hostnames that
map to private IPs (closes the TOCTOU gap in the old inline checks)
- Always blocks loopback (127.x, ::1) and link-local/metadata (169.254.x)
- RFC-1918, CGNAT (100.64/10), and IPv6 ULA ranges blocked by default;
opt-in via ALLOW_INTERNAL_NETWORK=true for self-hosters running Immich
on a local network
- createPinnedAgent() pins node-fetch to the validated IP, preventing
DNS rebinding between the check and the actual connection
- Replace isValidImmichUrl() (hostname-string check, no DNS resolution)
with checkSsrf(); make PUT /integrations/immich/settings async
- Audit log entry (immich.private_ip_configured) written when a user
saves an Immich URL that resolves to a private IP
- Response includes a warning field surfaced as a toast in the UI
- Replace ~20 lines of duplicated inline SSRF logic in the link-preview
handler with a single checkSsrf() call + pinned agent
- Document ALLOW_INTERNAL_NETWORK in README, docker-compose.yml,
server/.env.example, chart/values.yaml, chart/templates/configmap.yaml,
and chart/README.md
169 lines
6.2 KiB
TypeScript
169 lines
6.2 KiB
TypeScript
import { Request } from 'express';
|
|
import { db } from '../db/database';
|
|
import fs from 'fs';
|
|
import path from 'path';
|
|
|
|
const LOG_LEVEL = (process.env.LOG_LEVEL || 'info').toLowerCase();
|
|
const MAX_LOG_SIZE = 10 * 1024 * 1024; // 10 MB
|
|
const MAX_LOG_FILES = 5;
|
|
|
|
const C = {
|
|
blue: '\x1b[34m',
|
|
cyan: '\x1b[36m',
|
|
red: '\x1b[31m',
|
|
yellow: '\x1b[33m',
|
|
reset: '\x1b[0m',
|
|
};
|
|
|
|
// ── File logger with rotation ─────────────────────────────────────────────
|
|
|
|
const logsDir = path.join(process.cwd(), 'data/logs');
|
|
try { fs.mkdirSync(logsDir, { recursive: true }); } catch {}
|
|
const logFilePath = path.join(logsDir, 'trek.log');
|
|
|
|
function rotateIfNeeded(): void {
|
|
try {
|
|
if (!fs.existsSync(logFilePath)) return;
|
|
const stat = fs.statSync(logFilePath);
|
|
if (stat.size < MAX_LOG_SIZE) return;
|
|
|
|
for (let i = MAX_LOG_FILES - 1; i >= 1; i--) {
|
|
const src = i === 1 ? logFilePath : `${logFilePath}.${i - 1}`;
|
|
const dst = `${logFilePath}.${i}`;
|
|
if (fs.existsSync(src)) fs.renameSync(src, dst);
|
|
}
|
|
} catch {}
|
|
}
|
|
|
|
function writeToFile(line: string): void {
|
|
try {
|
|
rotateIfNeeded();
|
|
fs.appendFileSync(logFilePath, line + '\n');
|
|
} catch {}
|
|
}
|
|
|
|
// ── Public log helpers ────────────────────────────────────────────────────
|
|
|
|
function formatTs(): string {
|
|
const tz = process.env.TZ || 'UTC';
|
|
return new Date().toLocaleString('sv-SE', { timeZone: tz }).replace(' ', 'T');
|
|
}
|
|
|
|
function logInfo(msg: string): void {
|
|
const ts = formatTs();
|
|
console.log(`${C.blue}[INFO]${C.reset} ${ts} ${msg}`);
|
|
writeToFile(`[INFO] ${ts} ${msg}`);
|
|
}
|
|
|
|
function logDebug(msg: string): void {
|
|
if (LOG_LEVEL !== 'debug') return;
|
|
const ts = formatTs();
|
|
console.log(`${C.cyan}[DEBUG]${C.reset} ${ts} ${msg}`);
|
|
writeToFile(`[DEBUG] ${ts} ${msg}`);
|
|
}
|
|
|
|
function logError(msg: string): void {
|
|
const ts = formatTs();
|
|
console.error(`${C.red}[ERROR]${C.reset} ${ts} ${msg}`);
|
|
writeToFile(`[ERROR] ${ts} ${msg}`);
|
|
}
|
|
|
|
function logWarn(msg: string): void {
|
|
const ts = formatTs();
|
|
console.warn(`${C.yellow}[WARN]${C.reset} ${ts} ${msg}`);
|
|
writeToFile(`[WARN] ${ts} ${msg}`);
|
|
}
|
|
|
|
// ── IP + audit ────────────────────────────────────────────────────────────
|
|
|
|
export function getClientIp(req: Request): string | null {
|
|
const xff = req.headers['x-forwarded-for'];
|
|
if (typeof xff === 'string') {
|
|
const first = xff.split(',')[0]?.trim();
|
|
return first || null;
|
|
}
|
|
if (Array.isArray(xff) && xff[0]) return String(xff[0]).trim() || null;
|
|
return req.socket?.remoteAddress || null;
|
|
}
|
|
|
|
function resolveUserEmail(userId: number | null): string {
|
|
if (!userId) return 'anonymous';
|
|
try {
|
|
const row = db.prepare('SELECT email FROM users WHERE id = ?').get(userId) as { email: string } | undefined;
|
|
return row?.email || `uid:${userId}`;
|
|
} catch { return `uid:${userId}`; }
|
|
}
|
|
|
|
const ACTION_LABELS: Record<string, string> = {
|
|
'user.register': 'registered',
|
|
'user.login': 'logged in',
|
|
'user.login_failed': 'login failed',
|
|
'user.password_change': 'changed password',
|
|
'user.account_delete': 'deleted account',
|
|
'user.mfa_enable': 'enabled MFA',
|
|
'user.mfa_disable': 'disabled MFA',
|
|
'settings.app_update': 'updated settings',
|
|
'trip.create': 'created trip',
|
|
'trip.delete': 'deleted trip',
|
|
'admin.user_role_change': 'changed user role',
|
|
'admin.user_delete': 'deleted user',
|
|
'admin.invite_create': 'created invite',
|
|
'immich.private_ip_configured': 'configured Immich with private IP',
|
|
};
|
|
|
|
/** Best-effort; never throws — failures are logged only. */
|
|
export function writeAudit(entry: {
|
|
userId: number | null;
|
|
action: string;
|
|
resource?: string | null;
|
|
details?: Record<string, unknown>;
|
|
debugDetails?: Record<string, unknown>;
|
|
ip?: string | null;
|
|
}): void {
|
|
try {
|
|
const detailsJson = entry.details && Object.keys(entry.details).length > 0 ? JSON.stringify(entry.details) : null;
|
|
db.prepare(
|
|
`INSERT INTO audit_log (user_id, action, resource, details, ip) VALUES (?, ?, ?, ?, ?)`
|
|
).run(entry.userId, entry.action, entry.resource ?? null, detailsJson, entry.ip ?? null);
|
|
|
|
const email = resolveUserEmail(entry.userId);
|
|
const label = ACTION_LABELS[entry.action] || entry.action;
|
|
const brief = buildInfoSummary(entry.action, entry.details);
|
|
logInfo(`${email} ${label}${brief} ip=${entry.ip || '-'}`);
|
|
|
|
if (entry.debugDetails && Object.keys(entry.debugDetails).length > 0) {
|
|
logDebug(`AUDIT ${entry.action} userId=${entry.userId} ${JSON.stringify(entry.debugDetails)}`);
|
|
} else if (detailsJson) {
|
|
logDebug(`AUDIT ${entry.action} userId=${entry.userId} ${detailsJson}`);
|
|
}
|
|
} catch (e) {
|
|
logError(`Audit write failed: ${e instanceof Error ? e.message : e}`);
|
|
}
|
|
}
|
|
|
|
function buildInfoSummary(action: string, details?: Record<string, unknown>): string {
|
|
if (!details || Object.keys(details).length === 0) return '';
|
|
if (action === 'trip.create') return ` "${details.title}"`;
|
|
if (action === 'trip.delete') return ` tripId=${details.tripId}`;
|
|
if (action === 'user.register') return ` ${details.email}`;
|
|
if (action === 'user.login') return '';
|
|
if (action === 'user.login_failed') return ` reason=${details.reason}`;
|
|
if (action === 'settings.app_update') {
|
|
const parts: string[] = [];
|
|
if (details.notification_channel) parts.push(`channel=${details.notification_channel}`);
|
|
if (details.smtp_settings_updated) parts.push('smtp');
|
|
if (details.notification_events_updated) parts.push('events');
|
|
if (details.webhook_url_updated) parts.push('webhook_url');
|
|
if (details.allowed_file_types_updated) parts.push('file_types');
|
|
if (details.allow_registration !== undefined) parts.push(`registration=${details.allow_registration}`);
|
|
if (details.require_mfa !== undefined) parts.push(`mfa=${details.require_mfa}`);
|
|
return parts.length ? ` (${parts.join(', ')})` : '';
|
|
}
|
|
if (action === 'immich.private_ip_configured') {
|
|
return details.resolved_ip ? ` url=${details.immich_url} ip=${details.resolved_ip}` : '';
|
|
}
|
|
return '';
|
|
}
|
|
|
|
export { LOG_LEVEL, logInfo, logDebug, logError, logWarn };
|