mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-06-19 13:21:46 +00:00
jubnl
b4922322ae
Add new integration test files covering previously untested routes: - categories.test.ts — GET /api/categories - oidc.test.ts — full OIDC login flow (callback, state, errors) - settings.test.ts — GET/PUT /api/settings, bulk save - tags.test.ts — CRUD for trip tags - todo.test.ts — todo items CRUD and reorder Add new unit test files covering service-layer logic: - adminService.test.ts — user/invite management, packing templates, OIDC settings - atlasService.test.ts — atlas search and place enrichment - authServiceDb.test.ts — DB-backed auth helpers (login, register, MFA) - backupService.test.ts — export/import/restore logic - categoryService.test.ts — category CRUD - dayService.test.ts — day management and accommodation helpers - mapsService.test.ts — route/directions helpers - oidcService.test.ts — OIDC state, auth code, role resolution, user upsert - packingService.test.ts — packing item/bag/template operations - placeService.test.ts — place CRUD and tag attachment - settingsService.test.ts — settings get/set/bulk - tagService.test.ts — tag CRUD - todoService.test.ts — todo CRUD and reorder - tripService.test.ts — trip CRUD, member management, archiving - vacayService.test.ts — vacay integration helpers - tripAccess.test.ts (middleware) — requireTripAccess middleware Expand existing integration and unit test files with additional cases across admin, atlas, auth, backup, collab, days, files, maps, memories (Immich/Synology), notifications, places, reservations, share, vacay, weather, auth middleware, ephemeral tokens, notification preferences, permissions, SSRF guard, and WebSocket connection tests. Update test helpers (factories.ts, test-db.ts) with new factory functions and seed data required by the expanded suite. Fix minor issues in server/src/routes/reservations.ts and server/src/services/atlasService.ts surfaced by new test coverage. Update sonar-project.properties to reflect new coverage thresholds.
322 lines
11 KiB
TypeScript
322 lines
11 KiB
TypeScript
/**
|
|
* Todo integration tests — TODO-001 through TODO-012.
|
|
* Covers all endpoints at /api/trips/:tripId/todo.
|
|
*/
|
|
import { describe, it, expect, vi, beforeAll, beforeEach, afterAll } from 'vitest';
|
|
import request from 'supertest';
|
|
import type { Application } from 'express';
|
|
|
|
const { testDb, dbMock } = vi.hoisted(() => {
|
|
const Database = require('better-sqlite3');
|
|
const db = new Database(':memory:');
|
|
db.exec('PRAGMA journal_mode = WAL');
|
|
db.exec('PRAGMA foreign_keys = ON');
|
|
db.exec('PRAGMA busy_timeout = 5000');
|
|
const mock = {
|
|
db,
|
|
closeDb: () => {},
|
|
reinitialize: () => {},
|
|
getPlaceWithTags: () => null,
|
|
canAccessTrip: (tripId: any, userId: number) =>
|
|
db.prepare(`SELECT t.id, t.user_id FROM trips t LEFT JOIN trip_members m ON m.trip_id = t.id AND m.user_id = ? WHERE t.id = ? AND (t.user_id = ? OR m.user_id IS NOT NULL)`).get(userId, tripId, userId),
|
|
isOwner: (tripId: any, userId: number) =>
|
|
!!db.prepare('SELECT id FROM trips WHERE id = ? AND user_id = ?').get(tripId, userId),
|
|
};
|
|
return { testDb: db, dbMock: mock };
|
|
});
|
|
|
|
vi.mock('../../src/db/database', () => dbMock);
|
|
vi.mock('../../src/config', () => ({
|
|
JWT_SECRET: 'test-jwt-secret-for-trek-testing-only',
|
|
ENCRYPTION_KEY: 'a1b2c3d4e5f6a7b8c9d0e1f2a3b4c5d6a7b8c9d0e1f2a3b4c5d6a7b8c9d0e1f2',
|
|
updateJwtSecret: () => {},
|
|
}));
|
|
|
|
import { createApp } from '../../src/app';
|
|
import { createTables } from '../../src/db/schema';
|
|
import { runMigrations } from '../../src/db/migrations';
|
|
import { resetTestDb } from '../helpers/test-db';
|
|
import { createUser, createTrip, addTripMember } from '../helpers/factories';
|
|
import { authCookie } from '../helpers/auth';
|
|
import { loginAttempts, mfaAttempts } from '../../src/routes/auth';
|
|
import { invalidatePermissionsCache } from '../../src/services/permissions';
|
|
|
|
const app: Application = createApp();
|
|
|
|
beforeAll(() => {
|
|
createTables(testDb);
|
|
runMigrations(testDb);
|
|
});
|
|
|
|
beforeEach(() => {
|
|
resetTestDb(testDb);
|
|
loginAttempts.clear();
|
|
mfaAttempts.clear();
|
|
invalidatePermissionsCache();
|
|
});
|
|
|
|
afterAll(() => {
|
|
testDb.close();
|
|
});
|
|
|
|
describe('Todo items', () => {
|
|
it('TODO-001: GET /api/trips/:id/todo returns empty items for a new trip', async () => {
|
|
const { user } = createUser(testDb);
|
|
const trip = createTrip(testDb, user.id);
|
|
const res = await request(app)
|
|
.get(`/api/trips/${trip.id}/todo`)
|
|
.set('Cookie', authCookie(user.id));
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.items).toEqual([]);
|
|
});
|
|
|
|
it('TODO-002: POST /api/trips/:id/todo creates a todo with title only', async () => {
|
|
const { user } = createUser(testDb);
|
|
const trip = createTrip(testDb, user.id);
|
|
const res = await request(app)
|
|
.post(`/api/trips/${trip.id}/todo`)
|
|
.set('Cookie', authCookie(user.id))
|
|
.send({ name: 'Book hotel' });
|
|
expect(res.status).toBe(201);
|
|
expect(res.body.item).toMatchObject({ name: 'Book hotel', checked: 0, trip_id: trip.id });
|
|
expect(res.body.item.id).toBeDefined();
|
|
});
|
|
|
|
it('TODO-003: POST /api/trips/:id/todo creates a todo with all optional fields', async () => {
|
|
const { user } = createUser(testDb);
|
|
const trip = createTrip(testDb, user.id);
|
|
const res = await request(app)
|
|
.post(`/api/trips/${trip.id}/todo`)
|
|
.set('Cookie', authCookie(user.id))
|
|
.send({
|
|
name: 'Pack suitcase',
|
|
category: 'Preparation',
|
|
description: 'Pack everything for the trip',
|
|
priority: 2,
|
|
});
|
|
expect(res.status).toBe(201);
|
|
expect(res.body.item).toMatchObject({
|
|
name: 'Pack suitcase',
|
|
category: 'Preparation',
|
|
description: 'Pack everything for the trip',
|
|
priority: 2,
|
|
});
|
|
});
|
|
|
|
it('TODO-004: POST /api/trips/:id/todo - missing name returns 400', async () => {
|
|
const { user } = createUser(testDb);
|
|
const trip = createTrip(testDb, user.id);
|
|
const res = await request(app)
|
|
.post(`/api/trips/${trip.id}/todo`)
|
|
.set('Cookie', authCookie(user.id))
|
|
.send({ category: 'Test' });
|
|
expect(res.status).toBe(400);
|
|
expect(res.body.error).toBeDefined();
|
|
});
|
|
|
|
it('TODO-005: PUT /api/trips/:id/todo/:todoId toggles checked status', async () => {
|
|
const { user } = createUser(testDb);
|
|
const trip = createTrip(testDb, user.id);
|
|
const createRes = await request(app)
|
|
.post(`/api/trips/${trip.id}/todo`)
|
|
.set('Cookie', authCookie(user.id))
|
|
.send({ name: 'Visit museum' });
|
|
const itemId = createRes.body.item.id;
|
|
|
|
// Toggle to checked
|
|
const res = await request(app)
|
|
.put(`/api/trips/${trip.id}/todo/${itemId}`)
|
|
.set('Cookie', authCookie(user.id))
|
|
.send({ checked: 1 });
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.item.checked).toBe(1);
|
|
|
|
// Toggle back to unchecked
|
|
const res2 = await request(app)
|
|
.put(`/api/trips/${trip.id}/todo/${itemId}`)
|
|
.set('Cookie', authCookie(user.id))
|
|
.send({ checked: 0 });
|
|
expect(res2.status).toBe(200);
|
|
expect(res2.body.item.checked).toBe(0);
|
|
});
|
|
|
|
it('TODO-006: PUT /api/trips/:id/todo/:todoId updates category', async () => {
|
|
const { user } = createUser(testDb);
|
|
const trip = createTrip(testDb, user.id);
|
|
const createRes = await request(app)
|
|
.post(`/api/trips/${trip.id}/todo`)
|
|
.set('Cookie', authCookie(user.id))
|
|
.send({ name: 'Buy souvenirs' });
|
|
const itemId = createRes.body.item.id;
|
|
|
|
const res = await request(app)
|
|
.put(`/api/trips/${trip.id}/todo/${itemId}`)
|
|
.set('Cookie', authCookie(user.id))
|
|
.send({ category: 'Shopping' });
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.item.category).toBe('Shopping');
|
|
});
|
|
|
|
it('TODO-007: DELETE /api/trips/:id/todo/:todoId deletes a todo', async () => {
|
|
const { user } = createUser(testDb);
|
|
const trip = createTrip(testDb, user.id);
|
|
const createRes = await request(app)
|
|
.post(`/api/trips/${trip.id}/todo`)
|
|
.set('Cookie', authCookie(user.id))
|
|
.send({ name: 'To Delete' });
|
|
const itemId = createRes.body.item.id;
|
|
|
|
const res = await request(app)
|
|
.delete(`/api/trips/${trip.id}/todo/${itemId}`)
|
|
.set('Cookie', authCookie(user.id));
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.success).toBe(true);
|
|
|
|
// Verify gone from list
|
|
const listRes = await request(app)
|
|
.get(`/api/trips/${trip.id}/todo`)
|
|
.set('Cookie', authCookie(user.id));
|
|
expect(listRes.body.items).toHaveLength(0);
|
|
});
|
|
|
|
it('TODO-008: PUT /api/trips/:id/todo/reorder reorders items', async () => {
|
|
const { user } = createUser(testDb);
|
|
const trip = createTrip(testDb, user.id);
|
|
|
|
// Create 3 items
|
|
const r1 = await request(app)
|
|
.post(`/api/trips/${trip.id}/todo`)
|
|
.set('Cookie', authCookie(user.id))
|
|
.send({ name: 'First' });
|
|
const r2 = await request(app)
|
|
.post(`/api/trips/${trip.id}/todo`)
|
|
.set('Cookie', authCookie(user.id))
|
|
.send({ name: 'Second' });
|
|
const r3 = await request(app)
|
|
.post(`/api/trips/${trip.id}/todo`)
|
|
.set('Cookie', authCookie(user.id))
|
|
.send({ name: 'Third' });
|
|
|
|
const id1 = r1.body.item.id;
|
|
const id2 = r2.body.item.id;
|
|
const id3 = r3.body.item.id;
|
|
|
|
// Reverse the order
|
|
const res = await request(app)
|
|
.put(`/api/trips/${trip.id}/todo/reorder`)
|
|
.set('Cookie', authCookie(user.id))
|
|
.send({ orderedIds: [id3, id2, id1] });
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.success).toBe(true);
|
|
|
|
// Verify the new order in the DB
|
|
const items = testDb.prepare('SELECT id, sort_order FROM todo_items WHERE trip_id = ? ORDER BY sort_order').all(trip.id) as any[];
|
|
expect(items[0].id).toBe(id3);
|
|
expect(items[1].id).toBe(id2);
|
|
expect(items[2].id).toBe(id1);
|
|
});
|
|
|
|
it('TODO-009: Non-member accessing trip returns 404', async () => {
|
|
const { user: owner } = createUser(testDb);
|
|
const { user: stranger } = createUser(testDb);
|
|
const trip = createTrip(testDb, owner.id);
|
|
|
|
const res = await request(app)
|
|
.get(`/api/trips/${trip.id}/todo`)
|
|
.set('Cookie', authCookie(stranger.id));
|
|
expect(res.status).toBe(404);
|
|
});
|
|
|
|
it('TODO-010: Trip member can read and create todos', async () => {
|
|
const { user: owner } = createUser(testDb);
|
|
const { user: member } = createUser(testDb);
|
|
const trip = createTrip(testDb, owner.id);
|
|
addTripMember(testDb, trip.id, member.id);
|
|
|
|
// Member can read
|
|
const getRes = await request(app)
|
|
.get(`/api/trips/${trip.id}/todo`)
|
|
.set('Cookie', authCookie(member.id));
|
|
expect(getRes.status).toBe(200);
|
|
|
|
// Member can create
|
|
const postRes = await request(app)
|
|
.post(`/api/trips/${trip.id}/todo`)
|
|
.set('Cookie', authCookie(member.id))
|
|
.send({ name: 'Member task' });
|
|
expect(postRes.status).toBe(201);
|
|
});
|
|
|
|
it('TODO-011: PUT /api/trips/:id/todo/:todoId - non-existent item returns 404', async () => {
|
|
const { user } = createUser(testDb);
|
|
const trip = createTrip(testDb, user.id);
|
|
const res = await request(app)
|
|
.put(`/api/trips/${trip.id}/todo/99999`)
|
|
.set('Cookie', authCookie(user.id))
|
|
.send({ name: 'Ghost' });
|
|
expect(res.status).toBe(404);
|
|
});
|
|
|
|
it('TODO-012: GET /api/trips/:id/todo - unauthenticated returns 401', async () => {
|
|
const { user } = createUser(testDb);
|
|
const trip = createTrip(testDb, user.id);
|
|
const res = await request(app).get(`/api/trips/${trip.id}/todo`);
|
|
expect(res.status).toBe(401);
|
|
});
|
|
});
|
|
|
|
describe('Todo category assignees', () => {
|
|
it('TODO-013: GET /api/trips/:id/todo/category-assignees returns empty object for new trip', async () => {
|
|
const { user } = createUser(testDb);
|
|
const trip = createTrip(testDb, user.id);
|
|
const res = await request(app)
|
|
.get(`/api/trips/${trip.id}/todo/category-assignees`)
|
|
.set('Cookie', authCookie(user.id));
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.assignees).toEqual({});
|
|
});
|
|
|
|
it('TODO-014: PUT /api/trips/:id/todo/category-assignees/:name sets assignees', async () => {
|
|
const { user: owner } = createUser(testDb);
|
|
const { user: member } = createUser(testDb);
|
|
const trip = createTrip(testDb, owner.id);
|
|
addTripMember(testDb, trip.id, member.id);
|
|
|
|
const res = await request(app)
|
|
.put(`/api/trips/${trip.id}/todo/category-assignees/Shopping`)
|
|
.set('Cookie', authCookie(owner.id))
|
|
.send({ user_ids: [owner.id, member.id] });
|
|
expect(res.status).toBe(200);
|
|
expect(Array.isArray(res.body.assignees)).toBe(true);
|
|
expect(res.body.assignees).toHaveLength(2);
|
|
|
|
// Verify via GET
|
|
const getRes = await request(app)
|
|
.get(`/api/trips/${trip.id}/todo/category-assignees`)
|
|
.set('Cookie', authCookie(owner.id));
|
|
expect(getRes.body.assignees.Shopping).toBeDefined();
|
|
expect(getRes.body.assignees.Shopping).toHaveLength(2);
|
|
});
|
|
|
|
it('TODO-015: PUT category-assignees with empty array clears assignees', async () => {
|
|
const { user: owner } = createUser(testDb);
|
|
const { user: member } = createUser(testDb);
|
|
const trip = createTrip(testDb, owner.id);
|
|
addTripMember(testDb, trip.id, member.id);
|
|
|
|
// Set assignees
|
|
await request(app)
|
|
.put(`/api/trips/${trip.id}/todo/category-assignees/Shopping`)
|
|
.set('Cookie', authCookie(owner.id))
|
|
.send({ user_ids: [owner.id] });
|
|
|
|
// Clear them
|
|
const res = await request(app)
|
|
.put(`/api/trips/${trip.id}/todo/category-assignees/Shopping`)
|
|
.set('Cookie', authCookie(owner.id))
|
|
.send({ user_ids: [] });
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.assignees).toHaveLength(0);
|
|
});
|
|
});
|