mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-11-22 13:10:29 +00:00
eaab7dc4e4
The create and update answers, the reservation:updated broadcast and the MCP reservation tools all hand back the single booking read, and that read never loaded reservation_day_positions. The day list puts a booking moved on a day by that slot before its time, and the client replaces the booking with the answer, so a booking moved on a day jumped back to its time after every edit until the next reload. The read now attaches day_positions in the shape the trip list already sends. Refs #2631
89 lines
3.7 KiB
TypeScript
89 lines
3.7 KiB
TypeScript
/**
|
|
* ReservationDayPositionsRepository — parity test (Plan 3d Task 7 whole-plan
|
|
* review, item 9/"missing parity tests": this repository had no standalone
|
|
* test file). ONE seeded world, one `toEqual(<legacy raw>)` test for the
|
|
* read method (RS19); RS31 (`upsertScoped`, a write) already has coverage
|
|
* through `reservations.service.test.ts`'s `updatePositions` cases.
|
|
*/
|
|
import { ReservationDayPositions } from '../../../../src/db/entities/ReservationDayPositions.entity';
|
|
import type { ReservationDayPositionsRepository } from '../../../../src/db/repositories/ReservationDayPositions.repository';
|
|
import { createSnapshotTestDb } from '../../../helpers/db-mock';
|
|
import { createDay, createReservation, createTrip, createUser } from '../../../helpers/factories';
|
|
import { insertRow } from '../../../helpers/factories/rows';
|
|
import { resetTestDb } from '../../../helpers/test-db';
|
|
import { createTestOrm, type TestOrm } from '../../../helpers/test-orm';
|
|
|
|
import { afterAll, beforeAll, beforeEach, describe, expect, it } from 'vitest';
|
|
|
|
const testDb = createSnapshotTestDb();
|
|
let t: TestOrm;
|
|
let repo: ReservationDayPositionsRepository;
|
|
|
|
beforeAll(async () => {
|
|
t = await createTestOrm(testDb);
|
|
repo = t.repo(ReservationDayPositions);
|
|
});
|
|
beforeEach(() => {
|
|
resetTestDb(testDb);
|
|
t.clear();
|
|
});
|
|
afterAll(async () => {
|
|
await t.close();
|
|
testDb.close();
|
|
});
|
|
|
|
describe('ReservationDayPositionsRepository — fully seeded world', () => {
|
|
const seed = async () => {
|
|
const { user } = createUser(testDb);
|
|
const trip = createTrip(testDb, user.id);
|
|
const day1 = createDay(testDb, trip.id);
|
|
const day2 = createDay(testDb, trip.id);
|
|
const multiDay = createReservation(testDb, trip.id, { title: 'Rental car', type: 'car' });
|
|
await insertRow(t, ReservationDayPositions, { reservation: multiDay.id, day: day1.id, position: 0 });
|
|
await insertRow(t, ReservationDayPositions, { reservation: multiDay.id, day: day2.id, position: 1 });
|
|
|
|
const otherTrip = createTrip(testDb, user.id);
|
|
const otherDay = createDay(testDb, otherTrip.id);
|
|
const foreignRes = createReservation(testDb, otherTrip.id, { title: 'Foreign rental', type: 'car' });
|
|
await insertRow(t, ReservationDayPositions, { reservation: foreignRes.id, day: otherDay.id, position: 0 });
|
|
|
|
return { trip, otherTrip, multiDay, day1, day2 };
|
|
};
|
|
|
|
it('RS19 listForTrip — matches the legacy JOIN statement, scoped by trip, both persist(false) mirror columns present', async () => {
|
|
const { trip, multiDay, day1, day2 } = await seed();
|
|
// test-sql-allow: the legacy statement is the oracle the repository read is held to.
|
|
const legacy = testDb
|
|
.prepare(
|
|
`
|
|
SELECT rdp.reservation_id, rdp.day_id, rdp.position FROM reservation_day_positions rdp
|
|
JOIN reservations r ON rdp.reservation_id = r.id WHERE r.trip_id = ?`,
|
|
)
|
|
.all(trip.id);
|
|
const typed = await repo.listForTrip(trip.id);
|
|
expect(typed).toEqual(legacy);
|
|
expect(typed.map((r) => [r.reservation_id, r.day_id, r.position]).sort()).toEqual(
|
|
[
|
|
[multiDay.id, day1.id, 0],
|
|
[multiDay.id, day2.id, 1],
|
|
].sort(),
|
|
);
|
|
});
|
|
|
|
it('RS19 listForTrip — an empty trip returns an empty array, not a throw', async () => {
|
|
const { user } = createUser(testDb);
|
|
const trip = createTrip(testDb, user.id);
|
|
expect(await repo.listForTrip(trip.id)).toEqual([]);
|
|
});
|
|
|
|
it('listForReservation — the slots of one booking per day, none of another booking', async () => {
|
|
const { multiDay, day1, day2 } = await seed();
|
|
const rows = await repo.listForReservation(multiDay.id);
|
|
expect(rows.map((r) => [r.day_id, r.position]).sort()).toEqual([
|
|
[day1.id, 0],
|
|
[day2.id, 1],
|
|
]);
|
|
expect(await repo.listForReservation(999999)).toEqual([]);
|
|
});
|
|
});
|