mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-06-19 21:31:46 +00:00
jubnl
5bcadb3cc6
- Fix SEC-005: rewrite path traversal test to upload a real file, inject traversal filename into DB, and assert the download does not succeed - Fix SEC-007: rename misleading test description to reflect it tests rejection of an invalid token, not acceptance of a valid one - Delete health.test.ts: all 3 tests were exact duplicates of auth.test.ts and misc.test.ts - Remove duplicate describe blocks from misc.test.ts: Categories endpoint (duplicate of categories.test.ts) and App config (duplicate of auth.test.ts) - Remove TRIP-016 from trips.test.ts: weaker duplicate of TRIP-007 (no body assertion) - Remove API Keys describe block from profile.test.ts: canonical copy lives in security.test.ts where it belongs - Remove avatarUrl describe block from budgetService.test.ts: identical tests already exist in authService.test.ts; drop now-unused import - Add DB verification to ASSIGN-007 and PACK-006 reorder tests: query day_assignments / packing_items after PUT reorder to confirm order changed - Strengthen BUDGET-007/008/009: add member/payer setup and assert concrete values (total_paid, per-user balance, flow direction and amount) - Remove 6 pointless Map-semantics tests from inAppNotificationActions.test.ts; keep only the two built-in registration checks - Remove 5 passthrough tests from queryHelpers.test.ts; keep the 4 tests that cover actual flat-to-nested transformation logic
93 lines
3.1 KiB
TypeScript
93 lines
3.1 KiB
TypeScript
import { describe, it, expect, vi } from 'vitest';
|
|
|
|
vi.mock('../../../src/db/database', () => ({
|
|
db: { prepare: () => ({ all: () => [], get: vi.fn() }) },
|
|
}));
|
|
|
|
import { formatAssignmentWithPlace } from '../../../src/services/queryHelpers';
|
|
import type { AssignmentRow, Tag, Participant } from '../../../src/types';
|
|
|
|
function makeRow(overrides: Partial<AssignmentRow> = {}): AssignmentRow {
|
|
return {
|
|
id: 1,
|
|
day_id: 10,
|
|
place_id: 100,
|
|
order_index: 0,
|
|
notes: 'assignment note',
|
|
created_at: '2024-01-01T00:00:00Z',
|
|
place_name: 'Eiffel Tower',
|
|
place_description: 'Famous landmark',
|
|
lat: 48.8584,
|
|
lng: 2.2945,
|
|
address: 'Champ de Mars, Paris',
|
|
category_id: 5,
|
|
category_name: 'Sightseeing',
|
|
category_color: '#3b82f6',
|
|
category_icon: 'landmark',
|
|
price: 25.0,
|
|
place_currency: 'EUR',
|
|
place_time: '10:00',
|
|
end_time: '12:00',
|
|
duration_minutes: 120,
|
|
place_notes: 'Bring tickets',
|
|
image_url: 'https://example.com/img.jpg',
|
|
transport_mode: 'walk',
|
|
google_place_id: 'ChIJLU7jZClu5kcR4PcOOO6p3I0',
|
|
website: 'https://eiffel-tower.com',
|
|
phone: '+33 1 2345 6789',
|
|
...overrides,
|
|
} as AssignmentRow;
|
|
}
|
|
|
|
const sampleTags: Partial<Tag>[] = [
|
|
{ id: 1, name: 'Must-see', color: '#ef4444' },
|
|
];
|
|
|
|
const sampleParticipants: Participant[] = [
|
|
{ user_id: 42, username: 'alice', avatar: null },
|
|
];
|
|
|
|
describe('formatAssignmentWithPlace', () => {
|
|
it('nests place fields correctly from flat row', () => {
|
|
const result = formatAssignmentWithPlace(makeRow(), [], []);
|
|
const { place } = result;
|
|
expect(place.id).toBe(100);
|
|
expect(place.name).toBe('Eiffel Tower');
|
|
expect(place.description).toBe('Famous landmark');
|
|
expect(place.lat).toBe(48.8584);
|
|
expect(place.lng).toBe(2.2945);
|
|
expect(place.address).toBe('Champ de Mars, Paris');
|
|
expect(place.price).toBe(25.0);
|
|
expect(place.currency).toBe('EUR');
|
|
expect(place.place_time).toBe('10:00');
|
|
expect(place.end_time).toBe('12:00');
|
|
expect(place.duration_minutes).toBe(120);
|
|
expect(place.notes).toBe('Bring tickets');
|
|
expect(place.image_url).toBe('https://example.com/img.jpg');
|
|
expect(place.transport_mode).toBe('walk');
|
|
expect(place.google_place_id).toBe('ChIJLU7jZClu5kcR4PcOOO6p3I0');
|
|
expect(place.website).toBe('https://eiffel-tower.com');
|
|
expect(place.phone).toBe('+33 1 2345 6789');
|
|
});
|
|
|
|
it('constructs place.category object when category_id is present', () => {
|
|
const result = formatAssignmentWithPlace(makeRow(), [], []);
|
|
expect(result.place.category).toEqual({
|
|
id: 5,
|
|
name: 'Sightseeing',
|
|
color: '#3b82f6',
|
|
icon: 'landmark',
|
|
});
|
|
});
|
|
|
|
it('sets place.category to null when category_id is null', () => {
|
|
const result = formatAssignmentWithPlace(makeRow({ category_id: null as any }), [], []);
|
|
expect(result.place.category).toBeNull();
|
|
});
|
|
|
|
it('sets place.category to null when category_id is 0 (falsy)', () => {
|
|
const result = formatAssignmentWithPlace(makeRow({ category_id: 0 as any }), [], []);
|
|
expect(result.place.category).toBeNull();
|
|
});
|
|
});
|