mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-11-14 00:01:03 +00:00
1ea72dca97
NODE_ENV="production " passed the boot check but matched none of the
exact production comparisons, so the web UI was never served and every
page answered {"error":"Cannot GET /"}, while the banner showed a clean
"production". The boot import now trims these three variables in
process.env before anything else reads them, so Express, the plugin
children and readEnv() agree, and reports each change as a process
warning. Casing stays as it was. A padded "test" is only reported, so an
instance cannot switch to an in-memory database after an update. The
banner prints NODE_ENV as set instead of lowercasing it.
Refs #2565
135 lines
5.4 KiB
TypeScript
135 lines
5.4 KiB
TypeScript
import { deriveAll, type AppEnv, type RawEnv } from './derive';
|
|
import { envSchema } from './env.schema';
|
|
|
|
export type { AppEnv, RawEnv };
|
|
|
|
/**
|
|
* Live typed view of the environment. Re-derives from the CURRENT process.env
|
|
* on every call — never cache the result across requests: the test suite (and
|
|
* the admin demo tooling) mutates process.env at runtime and depends on the
|
|
* next read observing the change. Derivation is a handful of string coercions,
|
|
* not a Zod parse; validation happens once at boot via validateEnvAtBoot().
|
|
*/
|
|
export function readEnv(): AppEnv {
|
|
return deriveAll(process.env as RawEnv);
|
|
}
|
|
|
|
/**
|
|
* Variables whose value never goes into the boot report, even when it is the
|
|
* malformed one: the report lands in container logs, and a key that is merely
|
|
* mistyped is still a real key. The name and the problem are enough to fix it.
|
|
*/
|
|
export const SECRET_ENV_KEYS: ReadonlySet<string> = new Set([
|
|
'ENCRYPTION_KEY',
|
|
'OIDC_CLIENT_SECRET',
|
|
'SMTP_PASS',
|
|
'VAPID_PRIVATE_KEY',
|
|
'UNSPLASH_ACCESS_KEY',
|
|
'ADMIN_PASSWORD',
|
|
'PLACES_API_KEY',
|
|
'AMAP_API_KEY',
|
|
'AMAP_API_SECRET',
|
|
'MAPBOX_ACCESS_TOKEN',
|
|
'CARTO_API_KEY',
|
|
'DEMO_ADMIN_PASS',
|
|
]);
|
|
|
|
/** How a variable's value appears in the boot report. */
|
|
function reportedValue(key: string, value: string | undefined): string {
|
|
return SECRET_ENV_KEYS.has(key) ? '***' : JSON.stringify(value);
|
|
}
|
|
|
|
/**
|
|
* Variables whose surrounding whitespace is stripped once at boot. The schema
|
|
* already validates them trimmed, but every reader compares the raw string:
|
|
* NODE_ENV="production " served no web UI at all (#2565), LOG_LEVEL="debug "
|
|
* fell back to info, DEFAULT_LANGUAGE="de " to English. Deliberately a short
|
|
* list, not every variable: a secret may carry its spaces on purpose.
|
|
*/
|
|
const TRIMMED_AT_BOOT = ['NODE_ENV', 'LOG_LEVEL', 'DEFAULT_LANGUAGE'] as const;
|
|
|
|
/**
|
|
* Strips the whitespace a .env line or a compose file left around the values in
|
|
* TRIMMED_AT_BOOT and writes the result back, so Express (`app.get('env')`),
|
|
* the plugin child processes and any library reading NODE_ENV itself see the
|
|
* same value as readEnv(). Casing is left alone. Each change is reported, since
|
|
* the banner cannot show a trailing space.
|
|
*
|
|
* NODE_ENV="test " is the one exception: trimmed it would switch a running
|
|
* instance onto an in-memory database without crons, so it is only reported.
|
|
*/
|
|
export function normalizeEnvAtBoot(raw: RawEnv = process.env as RawEnv): void {
|
|
for (const key of TRIMMED_AT_BOOT) {
|
|
const value = raw[key];
|
|
if (value === undefined) continue;
|
|
const trimmed = value.trim();
|
|
if (trimmed === value) continue;
|
|
if (key === 'NODE_ENV' && trimmed === 'test') {
|
|
bootWarning(`${key}=${JSON.stringify(value)} has surrounding whitespace and is not treated as "test".`);
|
|
continue;
|
|
}
|
|
raw[key] = trimmed;
|
|
bootWarning(`${key}=${JSON.stringify(value)} has surrounding whitespace, using ${JSON.stringify(trimmed)}.`);
|
|
}
|
|
}
|
|
|
|
/** Runs before the file logger exists, so it goes to stderr as a process warning. */
|
|
function bootWarning(message: string): void {
|
|
process.emitWarning(message, { code: 'TREK_ENV_WHITESPACE' });
|
|
}
|
|
|
|
/**
|
|
* Fail-fast startup validation: a variable that is PRESENT but malformed aborts
|
|
* boot with an aggregated report; unset/blank variables always pass (their
|
|
* documented defaults apply). Called once from the production entrypoint (see
|
|
* boot-validate.ts, imported by index.ts right after dotenv) — deliberately NOT
|
|
* wired into buildApp() or ConfigModule, so tests booting apps with a minimal
|
|
* env are unaffected.
|
|
*/
|
|
export function validateEnvAtBoot(raw: RawEnv = process.env as RawEnv): void {
|
|
const result = envSchema.safeParse(raw);
|
|
const lines = result.success
|
|
? []
|
|
: result.error.issues.map((issue) => {
|
|
const key = String(issue.path[0]);
|
|
return ` - ${key}=${reportedValue(key, raw[key])}: ${issue.message}`;
|
|
});
|
|
lines.push(...managedPreconditions(raw));
|
|
if (lines.length === 0) return;
|
|
console.error(`Invalid environment configuration:\n${lines.join('\n')}`);
|
|
throw new Error(
|
|
`Invalid environment configuration (${lines.length} problem${lines.length === 1 ? '' : 's'}). ` +
|
|
'Fix the variables listed above, or unset them to use their defaults.',
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Cross-field rules that only apply to a centrally administered install.
|
|
*
|
|
* These are not schema problems — every value here is individually valid, and
|
|
* blank always means "use the default" everywhere else in this file. They are
|
|
* combinations that would boot happily and be wrong, which is the case the
|
|
* schema cannot express and the one worth refusing (fail closed, see
|
|
* server/CLAUDE.md).
|
|
*
|
|
* Deliberately unreachable for a self-hoster: without TREK_MANAGED the list is
|
|
* empty and nothing changes.
|
|
*/
|
|
function managedPreconditions(raw: RawEnv): string[] {
|
|
if (deriveAll(raw).managed.enabled !== true) return [];
|
|
const problems: string[] = [];
|
|
|
|
// Without it the key is a file in the data volume, and backupService bundles
|
|
// that file into every archive it builds. The archive is downloadable by any
|
|
// instance admin, so the at-rest encryption would come with its own key in the
|
|
// same zip. Provisioning sets this; forgetting it is silent otherwise.
|
|
if (!raw.ENCRYPTION_KEY) {
|
|
problems.push(
|
|
' - ENCRYPTION_KEY is unset: required with TREK_MANAGED, because otherwise the ' +
|
|
'at-rest key lives in the data volume and is bundled into every backup download.',
|
|
);
|
|
}
|
|
|
|
return problems;
|
|
}
|