mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-10-18 21:16:47 +00:00
Maurice
9deedb80ea
Saving an expense twice while its receipt is also attached to a place and a booking hit the new unique index on (file, expense): the row kept from the first save was skipped, the next spare link row was adopted into a duplicate pair, and the constraint threw inside the transaction. The whole edit rolled back with a 500, every time, so that expense could never be changed again. The adopt now skips a link the expense already holds, and a receipt named twice in one save is linked once. The offline place cache was keyed on the place id alone while it is owned and evicted per trip, so two trips over the same city took each other's rows: the second write claimed them, switching the second trip off deleted them for both, and the first trip's fingerprint still matched so nothing ever refilled them. Offline search then answered nothing for a trip whose switch read "on". Each trip keeps its own copies now, and the upgrade clears the fingerprints so the next sync refills what the rebuild dropped. The chat composer minted its object URLs inside a state updater, which React runs twice in development, so one picked image drew two thumbnails and removing one left a preview for a picture that would not be sent. File and URL are one record now and every mutator commits a finished list. import_google_maps_route wrote up to thirty places and their day assignments under trips:write, which does not imply the places:write that create_place is gated on, and it was the one non-admin write tool with no demo gate and the only tool in the repo with no annotations. All three corrected.
96 lines
3.4 KiB
TypeScript
96 lines
3.4 KiB
TypeScript
/**
|
|
* FE-CHATIMG-001..006 — the pictures pinned to a chat message before it is sent.
|
|
*
|
|
* The reason this file exists: the hook used to create object URLs and enqueue
|
|
* the preview state from inside a `setFiles` updater. React invokes an updater
|
|
* an extra time in development, so one picked image produced two preview URLs
|
|
* against one file, the composer strip drew two thumbnails for one attachment,
|
|
* and removing one of them left a preview for a picture that would not be sent.
|
|
* `renderHook` under StrictMode is what reproduces it.
|
|
*/
|
|
import { describe, it, expect, beforeEach, vi } from 'vitest'
|
|
import { StrictMode } from 'react'
|
|
import { act, renderHook } from '@testing-library/react'
|
|
import { useChatImages, MAX_CHAT_IMAGES } from './useChatImages'
|
|
|
|
let nextUrl = 0
|
|
const revoked: string[] = []
|
|
|
|
beforeEach(() => {
|
|
nextUrl = 0
|
|
revoked.length = 0
|
|
vi.stubGlobal('URL', {
|
|
...URL,
|
|
createObjectURL: vi.fn(() => `blob:mock/${++nextUrl}`),
|
|
revokeObjectURL: vi.fn((url: string) => { revoked.push(url) }),
|
|
})
|
|
})
|
|
|
|
const img = (name: string, size = 1024) =>
|
|
new File([new Uint8Array(size)], name, { type: 'image/png' })
|
|
|
|
const strict = () => renderHook(() => useChatImages(), { wrapper: StrictMode })
|
|
|
|
describe('useChatImages', () => {
|
|
it('FE-CHATIMG-001: one picked image is one file and one preview, in StrictMode', () => {
|
|
const { result } = strict()
|
|
|
|
act(() => { result.current.add([img('a.png')]) })
|
|
|
|
expect(result.current.files).toHaveLength(1)
|
|
expect(result.current.previews).toHaveLength(1)
|
|
expect(result.current.previews[0]).toBe('blob:mock/1')
|
|
})
|
|
|
|
it('FE-CHATIMG-002: removing the only image empties both lists and revokes its URL', () => {
|
|
const { result } = strict()
|
|
act(() => { result.current.add([img('a.png')]) })
|
|
|
|
act(() => { result.current.remove(0) })
|
|
|
|
expect(result.current.files).toEqual([])
|
|
expect(result.current.previews).toEqual([])
|
|
expect(revoked).toEqual(['blob:mock/1'])
|
|
})
|
|
|
|
it('FE-CHATIMG-003: files and previews stay in step across several adds', () => {
|
|
const { result } = strict()
|
|
|
|
act(() => { result.current.add([img('a.png')]) })
|
|
act(() => { result.current.add([img('b.png'), img('c.png')]) })
|
|
|
|
expect(result.current.files.map(f => f.name)).toEqual(['a.png', 'b.png', 'c.png'])
|
|
expect(result.current.previews).toEqual(['blob:mock/1', 'blob:mock/2', 'blob:mock/3'])
|
|
})
|
|
|
|
it('FE-CHATIMG-004: a rejected type is reported and nothing is pinned for it', () => {
|
|
const { result } = strict()
|
|
let ok = true
|
|
|
|
act(() => { ok = result.current.add([new File(['x'], 'notes.pdf', { type: 'application/pdf' })]) })
|
|
|
|
expect(ok).toBe(false)
|
|
expect(result.current.files).toEqual([])
|
|
expect(result.current.previews).toEqual([])
|
|
})
|
|
|
|
it('FE-CHATIMG-005: the cap holds and no URL is minted for what it turns away', () => {
|
|
const { result } = strict()
|
|
|
|
act(() => { result.current.add(Array.from({ length: MAX_CHAT_IMAGES + 2 }, (_, i) => img(`${i}.png`))) })
|
|
|
|
expect(result.current.files).toHaveLength(MAX_CHAT_IMAGES)
|
|
expect(result.current.previews).toHaveLength(MAX_CHAT_IMAGES)
|
|
})
|
|
|
|
it('FE-CHATIMG-006: clear revokes every URL it handed out', () => {
|
|
const { result } = strict()
|
|
act(() => { result.current.add([img('a.png'), img('b.png')]) })
|
|
|
|
act(() => { result.current.clear() })
|
|
|
|
expect(result.current.files).toEqual([])
|
|
expect(revoked.sort()).toEqual(['blob:mock/1', 'blob:mock/2'])
|
|
})
|
|
})
|