With "Connect the days" and "A colour per day" on, the drive from one day's last stop to the next day's first stop was coloured as the day it left. A stop reached after midnight was handled the same way: the line into it kept the colour of the day it came from. The road trip panel counts both drives toward the arriving day (its distance includes them, and the setting's hint says connecting drives count toward the arrival day). So the map showed the drive under one day while the panel counted it under the other. This also happened with daily travel times set to end the day at the last place, whenever the schedule could not be kept (a drive longer than the window) and the days were drawn as stored. assembleRoadtrip now puts every line drawn into a day under that day's number, the day whose figures count it, and still marks it as a join, so the one-day stage view still leaves it off. Every map takes its day colours from this list: desktop Leaflet and Mapbox GL, the phone map and its stage view. The client tests that pinned the old colouring and the old join order now expect the new ones. Closes #3123
@trek/shared
Single source of truth for TREK's API contracts, expressed as Zod schemas and consumed by both the server (request validation + inferred DTO types) and the client (typed requests/responses).
This package is part of the incremental NestJS + React 19 migration (see the "Brownfield Rewrite" board). It is intentionally dormant until modules start importing it — adding it changes nothing for users.
Rules
- One folder per domain:
src/<domain>/<domain>.schema.ts(+.spec.ts). - Domain-agnostic building blocks live in
src/common/. - A route is only considered migrated once its contract lives here.
- Schemas are the source of truth; server DTOs and client types are inferred from them
(
z.infer<typeof schema>), never hand-duplicated.
Consumption (dev)
Both apps resolve @trek/shared to this package's TypeScript source:
- Server (
tsx): viapathsinserver/tsconfig.json. - Client (
vite): viaresolve.aliasinclient/vite.config.ts(+pathsfor the type-checker).
Production packaging (Docker / workspace wiring) is introduced in card F2, when the server first depends on this package at runtime. Until then prod builds are untouched.
Not yet here
The canonical error envelope is finalised in card F5 (it must match TREK's current Express error responses byte-for-byte), so it is deliberately not invented in F1.