mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-11-20 11:06:06 +00:00
31859651d7
Every help screen checked against the v5 redesign. Tours is documented for the first time, as a screen of its own with twelve screens under it, and notifications get help of their own. All pictures are taken again on a realistic demo trip, with short loops where a still cannot show the motion. The English is plain and every language is written naturally rather than word for word. The switcher shows two levels at most, a screen's overview lists its sub-screens as cards above its guides, each wiki page is linked once, and the help sidebar is wider. Fixes found along the way: Save to Collection keeps a tour's route, a track dropped on the places column opens the Tours import, tour Share on desktop, the unsaved tour draft lives on the account, a route click no longer adds an end point, Trip places leaves the trip's tours out, Escape closes a stage's day menu, confirms before destructive deletes, DWD warnings sharing one id kept apart, a booking's date moves with it, and smaller fixes across notifications, bookings, the day plan, stays, Atlas, Collections, Vacay and the admin screens.
51 lines
2.2 KiB
TypeScript
51 lines
2.2 KiB
TypeScript
import { isEffectivelyOffline } from '../sync/networkMode'
|
|
|
|
/**
|
|
* True when an error means the request never reached the server — a network-level
|
|
* failure (offline, captive portal, proxy auth wall, dropped connection, CORS).
|
|
* Axios sets `response` only when the server actually replied; its absence (on an
|
|
* Axios error) means we never got one. A real HTTP error (4xx/5xx) HAS a response
|
|
* and must NOT be treated as a network failure — the server spoke, so the caller
|
|
* needs to see it. Non-Axios errors are surfaced too.
|
|
*/
|
|
export function isNetworkError(err: unknown): boolean {
|
|
const e = err as { isAxiosError?: boolean; response?: unknown } | null
|
|
return !!e && e.isAxiosError === true && e.response == null
|
|
}
|
|
|
|
/**
|
|
* Read-through cache pattern shared by every repo's read methods.
|
|
*
|
|
* Reads degrade to the local Dexie cache in two situations:
|
|
* 1. The browser reports it is offline (`navigator.onLine` false) — skip the
|
|
* doomed request entirely.
|
|
* 2. The browser *thinks* it is online but the request fails at the network
|
|
* level — a lying `navigator.onLine` on a captive portal, a dropped
|
|
* connection (H2). Rather than surfacing that (which blanks the trip even
|
|
* though a good cached copy exists), we fall back to the cache.
|
|
*
|
|
* We gate on the effective offline state (real `navigator.onLine` OR the user's
|
|
* force-offline override), NOT the connectivity probe: the probe is a coarse
|
|
* global flag, and a single failed health check would otherwise force every read
|
|
* to the (possibly empty) cache even when the request itself would succeed. The
|
|
* network-error catch below covers the captive-portal case the probe was meant to.
|
|
*
|
|
* A genuine HTTP error (404/403/500 — the server responded) is NOT swallowed: it
|
|
* is rethrown so callers can set error state, navigate away, etc.
|
|
*
|
|
* Writes must NOT use this — they go through the mutation queue so failures are
|
|
* surfaced and retried, not silently swallowed.
|
|
*/
|
|
export async function onlineThenCache<T>(
|
|
onlineFn: () => Promise<T>,
|
|
cacheFn: () => Promise<T>,
|
|
): Promise<T> {
|
|
if (isEffectivelyOffline()) return cacheFn()
|
|
try {
|
|
return await onlineFn()
|
|
} catch (err) {
|
|
if (isNetworkError(err)) return cacheFn()
|
|
throw err
|
|
}
|
|
}
|