mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-11-21 19:40:34 +00:00
3f38621024
A trip can now turn a trip addon (lists, costs, documents, collab, road trip, tours) on or off for itself, whatever the instance switch says. No row in the new trip_addon_overrides table means the trip follows the instance; a row is the owner's choice. Going back to the instance setting deletes the row, and no addon data is touched either way. - GET/PUT /api/trips/:tripId/addons[/:addonId] (every member reads, the owner writes) and the MCP tools get_trip_addons and set_trip_addon, on the shared tripAddons contract; tripAddons:changed tells the members. - Every trip-scoped addon surface asks the trip: REST through TripAddonGuard, MCP through a per-call gate on the named or pinned trip, plugin RPC and events, the share link, the offline bundle, reminders, doc sync, the assistant (tools, keep_attached_file), booking costs, the trip summary prompt, and the cross-trip tour reads (library, Atlas stats, collection save). - Routes without a trip open while the addon is on in any of the user's trips. Switching an addon on that the instance has off ends the members' MCP sessions so they reconnect with its tools. - A copied trip takes its owner's choices along. Behaviour changes: an anonymous call to an addon route that is off now gets 401 instead of 404, and with an instance switch off the packing, todo and files plugin RPC methods, the files MCP tools, todo reminder mails, core plugin events, plugin view contributions, the share link's lists, costs and chat sections and the offline bundle's lists follow it.
62 lines
2.7 KiB
TypeScript
62 lines
2.7 KiB
TypeScript
/**
|
|
* PEVADDON-001..004: the plugin event sink with the trip's addons in front.
|
|
*
|
|
* A trip that has an addon off shows none of its rows, so a subscribed plugin
|
|
* gets none of that family's events either; every other event goes out at once.
|
|
*/
|
|
import type { AddonsService } from '../../../src/nest/addons/addons.service';
|
|
import { tripAddonOfEvent, tripEventSink } from '../../../src/nest/plugins/plugin-event-addons';
|
|
|
|
import { describe, it, expect, vi } from 'vitest';
|
|
|
|
/** Lets the sink's pending addon read settle. */
|
|
const settle = () => new Promise((resolve) => setTimeout(resolve, 0));
|
|
|
|
describe('the plugin event sink per trip', () => {
|
|
it('PEVADDON-001: an event names its trip addon by family; a trip event names none', () => {
|
|
expect(tripAddonOfEvent('budget:created')).toBe('budget');
|
|
expect(tripAddonOfEvent('packing:updated')).toBe('packing');
|
|
expect(tripAddonOfEvent('todo:deleted')).toBe('packing');
|
|
expect(tripAddonOfEvent('file:created')).toBe('documents');
|
|
expect(tripAddonOfEvent('collab:message:created')).toBe('collab');
|
|
expect(tripAddonOfEvent('roadtripVia:created')).toBe('roadtrip');
|
|
expect(tripAddonOfEvent('tours:updated')).toBe('tours');
|
|
expect(tripAddonOfEvent('place:created')).toBeNull();
|
|
expect(tripAddonOfEvent('toString:x')).toBeNull();
|
|
});
|
|
|
|
it('PEVADDON-002: an event of no addon goes out at once, without asking', () => {
|
|
const deliver = vi.fn();
|
|
const addons = { isEnabledForTrip: vi.fn() } as unknown as AddonsService;
|
|
tripEventSink(addons, undefined, deliver)(5, 'place:created', undefined);
|
|
expect(deliver).toHaveBeenCalledWith(5, 'place:created', undefined);
|
|
expect(addons.isEnabledForTrip).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it('PEVADDON-003: an addon event goes out only for a trip that has the addon on', async () => {
|
|
const deliver = vi.fn();
|
|
const addons = {
|
|
isEnabledForTrip: vi.fn(async (tripId: number, id: string) => !(tripId === 5 && id === 'budget')),
|
|
} as unknown as AddonsService;
|
|
const sink = tripEventSink(addons, undefined, deliver);
|
|
sink(5, 'budget:created', undefined);
|
|
sink(6, 'budget:created', undefined);
|
|
sink(5, 'packing:created', undefined);
|
|
await settle();
|
|
expect(deliver.mock.calls.map(([tripId, event]) => `${tripId} ${event}`)).toEqual([
|
|
'6 budget:created',
|
|
'5 packing:created',
|
|
]);
|
|
});
|
|
|
|
it('PEVADDON-004: an addon that cannot be read sends nothing', async () => {
|
|
const deliver = vi.fn();
|
|
const addons = {
|
|
isEnabledForTrip: vi.fn(async () => Promise.reject(new Error('db gone'))),
|
|
} as unknown as AddonsService;
|
|
tripEventSink(addons, undefined, deliver)(5, 'file:created', undefined);
|
|
await settle();
|
|
expect(deliver).not.toHaveBeenCalled();
|
|
});
|
|
});
|