mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-11-20 11:06:06 +00:00
fd1942afab
Rename the workflow to CI and name every job "<Area> <what>[ i/n]" with ids in kebab-case, in area order. Fold i18n parity, shared coverage and the plugin SDK into Shared tests, split the client gates into Client types and Client checks (with the bundle), and merge the image and chart jobs into Docker and Helm with per-area step conditions. Server and client tests run in ten slices, the Postgres lane in three per major, and e2e in two slices inside the digest-pinned Playwright container. A local setup action restores node_modules and shared/dist from exact cache keys and falls back to npm ci and the shared build. The node_modules key covers the lockfile and every workspace package.json, so npm ci still refuses a package.json out of step with the lockfile. Only pushes to dev and main save, the npm download cache included, and only a full install saves that one. The plugin SDK installs and runs before the root install so it resolves only its own dependencies. Timeouts drop to 15/10/5 minutes. The workflow tests now check the name form, the Playwright tag against the lockfile, scan's needs, timeouts, the cache keys and saves, and that installs go through the setup action; .github/actions/ counts like test.yml in changed-areas.
71 lines
2.4 KiB
YAML
71 lines
2.4 KiB
YAML
name: Lint & Prettier
|
|
on:
|
|
pull_request:
|
|
branches: [main, dev]
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
lint:
|
|
runs-on: ubuntu-24.04
|
|
timeout-minutes: 45
|
|
permissions:
|
|
pull-requests: write
|
|
steps:
|
|
- uses: actions/checkout@v6
|
|
- uses: actions/setup-node@v6
|
|
with:
|
|
node-version-file: .nvmrc
|
|
cache: npm
|
|
cache-dependency-path: package-lock.json
|
|
|
|
# shared's ESLint and Prettier plugins are its own devDependencies, and
|
|
# the format ratchet in scripts/lib/ resolves prettier from the root, so
|
|
# shared plus the root is the whole tree these checks read. npm ci
|
|
# installs exactly what the lockfile says, where npm install could
|
|
# resolve anew.
|
|
- name: Install dependencies
|
|
run: npm ci --workspace shared --include-workspace-root
|
|
|
|
- name: Run lint & format check
|
|
# Both are check-only: lint used to run eslint --fix, which rewrote the
|
|
# files before format:check looked at them, so neither could fail on
|
|
# formatting. lint:format holds every file outside
|
|
# scripts/format-baseline.json to Prettier; the list only shrinks.
|
|
id: checks
|
|
continue-on-error: true
|
|
run: |
|
|
cd shared
|
|
npm run lint
|
|
npm run lint:format
|
|
|
|
- name: Comment on PR if checks failed
|
|
if: steps.checks.outcome == 'failure'
|
|
uses: actions/github-script@v9
|
|
with:
|
|
script: |
|
|
await github.rest.issues.createComment({
|
|
owner: context.repo.owner,
|
|
repo: context.repo.repo,
|
|
issue_number: context.issue.number,
|
|
body: [
|
|
'## ❌ Lint & Prettier check failed',
|
|
'',
|
|
'Please fix the issues locally by running the following commands inside the `shared` package:',
|
|
'',
|
|
'```bash',
|
|
'cd shared',
|
|
'npm run lint:fix',
|
|
'npx prettier --write <file> # each file lint:format names',
|
|
'npm run lint:format -- --update # when a listed file is formatted now',
|
|
'```',
|
|
'',
|
|
'Then commit and push the changes.',
|
|
].join('\n'),
|
|
});
|
|
|
|
- name: Fail the job if checks failed
|
|
if: steps.checks.outcome == 'failure'
|
|
run: exit 1 |