mirror of
https://github.com/mauriceboe/TREK.git
synced 2026-10-18 21:16:47 +00:00
Maurice
6680bc7c74
PluginsModule was 21 controllers, 24 domain imports and 10 providers in one class, which made it the hub most of the Nest graph ran through: AdminModule imported it for a single cascade-disable call and inherited all of it. It is now PluginsRuntimeModule (supervisor, capability router, hook contracts), PluginContributionsModule (the 14 read-only hook controllers, moved to contributions/), PluginOAuthModule (the credential leaf, moved to oauth/) and a composition root that keeps the install and delivery controllers. AdminModule imports the runtime alone. The three plugin files that reached for the db singleton alongside the injected DatabaseService no longer do. plugin-host-state and signature-status take the connection from the caller, and the three per-user settings functions that were bare exports 'so the RPC host wiring can call them directly' are now PluginUserSettingsService - the host wiring is providers, so it injects them. Coverage moves from one repo-wide 80% to a per-domain ratchet. The single number let a well-covered domain subsidise a thin one: booking-import sits at 50% and integrations at 20%, and the aggregate still cleared the bar, so either could have lost another ten points unnoticed. Each domain now carries its own measured floor, regenerated by scripts/coverage-thresholds.mjs. Two test-side findings on the way: expect(undefined).toContain(SomeClass) PASSES in this vitest version - it only throws for a string needle. Every '<X> is listed in its module providers' guard was written that way, so all twelve of them silently stopped guarding the moment their class moved. They go through expectRegisteredProvider now, which asserts the array shape first. The atlas region test paid for the one-off decompression of the multi-MB admin1 bundle inside its own 5s budget, which is why it failed under load and passed alone. The bundle is warmed in beforeAll instead.
77 lines
3.7 KiB
TypeScript
77 lines
3.7 KiB
TypeScript
/**
|
|
* PluginOAuthController (#plugins): the host-brokered OAuth endpoints. Thin — the
|
|
* broker logic is in PluginOAuthService (separately tested); here we prove the gates
|
|
* (runtime off / no user / inactive plugin) and that the callback always redirects to
|
|
* an in-app path with the right status, never leaking an error.
|
|
*/
|
|
import { describe, it, expect, vi, beforeEach } from 'vitest';
|
|
|
|
const { pluginsEnabled, getMock } = vi.hoisted(() => ({
|
|
pluginsEnabled: vi.fn(() => true),
|
|
getMock: vi.fn(() => ({ 1: 1 })), // plugin is active by default
|
|
}));
|
|
vi.mock('../../../src/nest/plugins/kill-switch', () => ({ pluginsEnabled }));
|
|
vi.mock('../../../src/db/database', () => ({ db: { prepare: () => ({ get: getMock }) } }));
|
|
import { db as dbConn } from '../../../src/db/database';
|
|
import { DatabaseService } from '../../../src/nest/database/database.service';
|
|
|
|
import { PluginOAuthController } from '../../../src/nest/plugins/oauth/plugin-oauth.controller';
|
|
import type { PluginOAuthService } from '../../../src/nest/plugins/oauth/plugin-oauth.service';
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
const req = (id?: number) => ({ user: id === undefined ? undefined : { id } }) as any;
|
|
function fakeRes() {
|
|
const res = { redirectedTo: '' as string, redirect(loc: string) { res.redirectedTo = loc; return res; } };
|
|
return res;
|
|
}
|
|
function ctrl(over: Partial<PluginOAuthService> = {}) {
|
|
const svc = {
|
|
status: vi.fn(() => ({ configured: true, connected: false })),
|
|
startConnect: vi.fn(() => 'https://provider.example/auth?state=s'),
|
|
completeCallback: vi.fn(async () => undefined),
|
|
disconnect: vi.fn(),
|
|
...over,
|
|
} as unknown as PluginOAuthService;
|
|
return { c: new PluginOAuthController(svc, new DatabaseService(dbConn)), svc };
|
|
}
|
|
|
|
describe('PluginOAuthController', () => {
|
|
beforeEach(() => { pluginsEnabled.mockReturnValue(true); getMock.mockReturnValue({ 1: 1 }); });
|
|
|
|
it('status is gated: runtime off / no user / inactive → not configured', () => {
|
|
expect(ctrl().c.status('p', req(5))).toEqual({ configured: true, connected: false });
|
|
pluginsEnabled.mockReturnValue(false);
|
|
expect(ctrl().c.status('p', req(5))).toEqual({ configured: false, connected: false });
|
|
pluginsEnabled.mockReturnValue(true);
|
|
expect(ctrl().c.status('p', req(undefined))).toEqual({ configured: false, connected: false });
|
|
getMock.mockReturnValue(undefined as never); // inactive
|
|
expect(ctrl().c.status('p', req(5))).toEqual({ configured: false, connected: false });
|
|
});
|
|
|
|
it('connect returns the authorize URL for a bound user', () => {
|
|
const { c, svc } = ctrl();
|
|
expect(c.connect('p', req(5))).toEqual({ authorizeUrl: 'https://provider.example/auth?state=s' });
|
|
expect(svc.startConnect).toHaveBeenCalledWith('p', 5, expect.any(Number));
|
|
});
|
|
|
|
it('callback redirects with :connected on success and :failed on a thrown exchange', async () => {
|
|
const okRes = fakeRes();
|
|
await ctrl().c.callback('p', 'code', 'state', undefined, req(5), okRes as never);
|
|
expect(okRes.redirectedTo).toBe('/settings?oauth=p:connected');
|
|
|
|
const failRes = fakeRes();
|
|
await ctrl({ completeCallback: vi.fn(async () => { throw new Error('boom'); }) }).c.callback('p', 'code', 'state', undefined, req(5), failRes as never);
|
|
expect(failRes.redirectedTo).toBe('/settings?oauth=p:failed'); // never leaks the error
|
|
|
|
const denyRes = fakeRes();
|
|
await ctrl().c.callback('p', undefined, undefined, 'access_denied', req(5), denyRes as never);
|
|
expect(denyRes.redirectedTo).toBe('/settings?oauth=p:denied');
|
|
});
|
|
|
|
it('disconnect delegates for a bound user', () => {
|
|
const { c, svc } = ctrl();
|
|
expect(c.disconnect('p', req(5))).toEqual({ connected: false });
|
|
expect(svc.disconnect).toHaveBeenCalledWith('p', 5);
|
|
});
|
|
});
|